Summary:
This file was huge and was hard to understand what was going on. changes:
1. UIActions moved out to separate file
2. create UIstate moved out
3. All declared state (atoms or plain js objects) moved to the top of the function like a class
4. utilities moved out
Reviewed By: lblasa
Differential Revision: D47547844
fbshipit-source-id: e7fa705a14a23bff2415016a488147bed7ad9e91
Summary:
Currently state writes can either go through a named handler that is easy to find and debug or they can directly modify the state.
By exposing readonly atoms only we ensure that all state writes go through a UIACtions. This adds consistency and ease of future debugging.
E.g We could add a utility to wrap all ui actions with logging statements
Reviewed By: antonk52
Differential Revision: D47547531
fbshipit-source-id: f88651169d8e7c5f7e31068d64f9aa5b6b573647
Summary:
UINode has never been a good name, we have 3 versions of a node.
ClientNode Previously UINode (the raw data from the client)
NestedNode (for the visualiser)
TreeNode (extends ClientNode and adds stuff specific to the tree like indentation and expanded states)
Arguablely we dont need nested node but that is another story
Reviewed By: elboman
Differential Revision: D47547529
fbshipit-source-id: 9a3b119d1230ea7b6734e7a3270c28287b04faf1
Summary: This file was getting overwelhming, and this seemed like a reasonable way to split it
Reviewed By: elboman
Differential Revision: D47547532
fbshipit-source-id: ab2bfa22daabbed13ec1445da0cf8ba88bda12d7
Summary: Very basic framework events table, quite useful for debugging will add more to this soon
Reviewed By: lblasa
Differential Revision: D47520035
fbshipit-source-id: 10f4572dd4ed3529324f03a969773c7e91fde030
Summary: Timeout exceptions while connection to new clients where rethrown but catched nowhere. Probably this warning should be handled more gracefully, but this at least moves it to warn rather than spawning our monitoring on transient issues
Reviewed By: passy, antonk52
Differential Revision: D47665050
fbshipit-source-id: ad51808d12e9f4de318d4426933ecb3787839b7c
Summary:
The Setup Doctor screen was hard-set into a modal window. Instead, make this an optional that defaults to yes.
This will allow the usage of the screen in non-modal container.
Reviewed By: antonk52
Differential Revision: D47629528
fbshipit-source-id: c5248df1358f1b14775b90c9bf12fd63b8885caf
Summary:
^
Not all selections have a left sidebar. If the current selection doesn't have one, it doesn't make sense to have the toggle sidebar button, so hide it.
Reviewed By: LukeDefeo
Differential Revision: D47593545
fbshipit-source-id: 940d59536e26bd1ab341d2038df431c67e0a5442
Summary: This will allow us to build a nice table easily.
Reviewed By: lblasa
Differential Revision: D47520029
fbshipit-source-id: 3cdd776533b66688329171eb29b892e0b9153540
Summary: An more options page drop down of size one didnt really make a great deal of sense
Reviewed By: lblasa
Differential Revision: D47520034
fbshipit-source-id: cea7ac404f73a0d7e5a1541b16097c4fd6549215
Summary:
See title. The issue occurs because this tabs component derives a key by essentially serializing the children. Since its possible for different elements in the UIDebugger to have different number of tabs, due to framework events not always being present this was never anticipated.
Solution is to just let the callee supply a storage key which does not depend on the exact number of tabs
Reviewed By: lblasa
Differential Revision: D47520033
fbshipit-source-id: 67e57db5110fde52451d30496c25a25b0eb4a6f7
Summary: This adds a filter on top of the event types to only highlight when the thread occurs on the main thread
Reviewed By: lblasa
Differential Revision: D47520036
fbshipit-source-id: b4a67b262345d845e5dcbf79bba5a210c1bca4f8
Summary: The previous approach would set the atom many times causing several unnecessary renders
Reviewed By: lblasa
Differential Revision: D47519869
fbshipit-source-id: 536334c892334035a6c0fefc86a2e205b2c9769d
Summary: I was experiencing some odd behaviour and locks ups from deep within Ant d. It seems to be related to the fact that tooltips for the visualiser were showing up when there was a modal on top.
Reviewed By: lblasa
Differential Revision: D47519848
fbshipit-source-id: d67edaedba2910069ba1eb424548de55c2badff3
Summary:
Added selection source concept to onSelect callback. This allows us to only autoscroll the tree when selection source is the visualiser. We had feedback that the horizontal autoscrolling whilst using the tree was unhelpful.
A side benefit of selection source is better tracking of how people use kb, tree vs visualiser to select things
Changelog: UIDebugger only autoscroll horizontally when selecting via the visualiser
Reviewed By: lblasa
Differential Revision: D47334078
fbshipit-source-id: d7eadddb8d3d0fd428d5c294b2dccc2f1efa5a95
Summary: It was complaining about no key for items in a list
Reviewed By: antonk52
Differential Revision: D47396639
fbshipit-source-id: c3d5cb7205dbe1c343d109e22f43e5756a071119
Summary:
Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.71 to 1.0.72.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/anyhow/releases">anyhow's releases</a>.</em></p>
<blockquote>
<h2>1.0.72</h2>
<ul>
<li>Documentation improvements</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e458996b0a"><code>e458996</code></a> Release 1.0.72</li>
<li><a href="660fb0f068"><code>660fb0f</code></a> Opt in to generate-link-to-definition when building on docs.rs</li>
<li><a href="24d9166581"><code>24d9166</code></a> Add CI job using minimal-versions</li>
<li><a href="2c913b3078"><code>2c913b3</code></a> Remove .clippy.toml in favor of respecting rust-version from Cargo.toml</li>
<li><a href="1f17666ef1"><code>1f17666</code></a> Ignore needless_else clippy lint in test suite</li>
<li><a href="6046674814"><code>6046674</code></a> Show error details during miri setup in CI</li>
<li><a href="dffcb4bf6c"><code>dffcb4b</code></a> Revert "Temporarily disable miri CI"</li>
<li><a href="438fec6036"><code>438fec6</code></a> Temporarily disable miri CI</li>
<li>See full diff in <a href="https://github.com/dtolnay/anyhow/compare/1.0.71...1.0.72">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4953
Reviewed By: antonk52
Differential Revision: D47553549
Pulled By: passy
fbshipit-source-id: 4486ad16fba61214dbc0749867498eca25517ca6
Summary:
Upgrade to Gradle `8.1.1`
Done using:
```bash
./gradlew wrapper --gradle-version=8.1.1 --distribution-type=all
```
This is to align with the bump to gradle `8.x` in React Native.
## Changelog
[GENERAL] [SECURITY] - Upgrade to Gradle `8.1.1`
Pull Request resolved: https://github.com/facebook/flipper/pull/4907
Test Plan: - CI checks should pass & builds should be successful without any errors.
Reviewed By: antonk52
Differential Revision: D47553708
Pulled By: passy
fbshipit-source-id: a0ab9ab732a254c563d8cb55b277f73571da8927
Summary:
Bumps [serde_yaml](https://github.com/dtolnay/serde-yaml) from 0.9.21 to 0.9.23.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/serde-yaml/releases">serde_yaml's releases</a>.</em></p>
<blockquote>
<h2>0.9.23</h2>
<ul>
<li>Documentation improvements</li>
</ul>
<h2>0.9.22</h2>
<ul>
<li>Update indexmap dependency to version 2</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="6b212e08b3"><code>6b212e0</code></a> Release 0.9.23</li>
<li><a href="cc83b0a220"><code>cc83b0a</code></a> Opt in to generate-link-to-definition when building on docs.rs</li>
<li><a href="954e38428c"><code>954e384</code></a> Make minimal-versions job consistent with other repos</li>
<li><a href="060eb8669c"><code>060eb86</code></a> Release 0.9.22</li>
<li><a href="b12ad38d63"><code>b12ad38</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/serde-yaml/issues/377">https://github.com/facebook/flipper/issues/377</a> from dtolnay/indexmap</li>
<li><a href="c418ad56c3"><code>c418ad5</code></a> Update indexmap dependency to version 2</li>
<li><a href="f1cd9e6b7f"><code>f1cd9e6</code></a> Remove .clippy.toml in favor of respecting rust-version from Cargo.toml</li>
<li><a href="147103c4f4"><code>147103c</code></a> Show error details during miri setup in CI</li>
<li><a href="622553f382"><code>622553f</code></a> Fix unused import warnings in test under cfg miri</li>
<li><a href="2037c7e62b"><code>2037c7e</code></a> Fix new unused_mut detected by nightly-2023-04-30</li>
<li>See full diff in <a href="https://github.com/dtolnay/serde-yaml/compare/0.9.21...0.9.23">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4952
Reviewed By: antonk52
Differential Revision: D47553552
Pulled By: passy
fbshipit-source-id: 2d90115eebe71748270d813e26cea7053e96bdb0
Summary: Filter exceptions allow us to add singular items to table views. Extremely useful for Bloks Debugger where we have to jump between multiple types of rows that could be filtered out
Reviewed By: LukeDefeo
Differential Revision: D47472006
fbshipit-source-id: 74d21a65d364ec5ab88652effc06aade20ad80b2
Summary: This was added initially for login button only which was redundant. Fixed in this diff
Reviewed By: elboman
Differential Revision: D47517366
fbshipit-source-id: 58191c618fe2e85d6a06e444029a308223b4e235
Summary:
- remove tooltip as it is about the items that are in the navbar now
- metro buttons and bookmarks are still located in the sidebar
- so are plugin app actions
Reviewed By: elboman
Differential Revision: D47470797
fbshipit-source-id: cb7d757821eaa45ea770d3731b94e4e2f1a6d0ff
Summary: Don't mind busy navbar, flipper debugger buttons will be moved into a menu down the stack
Reviewed By: elboman
Differential Revision: D47469851
fbshipit-source-id: b29367810287d77106a56a5b1ae4aec49188e8fc
Summary: I also changed the "export" button icon as having two bug icons in the navbar is confusion. lblasa is going to squish all 4 or 5 debug flipper related buttons into one in the near future, so I am not focused on solving this currently
Reviewed By: elboman
Differential Revision: D47468721
fbshipit-source-id: 9492f9feba0df4afaf5b72470cb65e5cefbcb955
