Summary: Just a small task to make debugging of the main process easier
Reviewed By: jknoxville
Differential Revision: D19792592
fbshipit-source-id: 9d1060dbb58a01615230bff2361144cfc88e41b7
Summary: In order to select IDs in a different manner, I am introducing functionality to the Network plugin to allow it to accept more than just IDs that it has assigned, and add the ability to select this plugin with a default search term. I hope to use this to allow for selecting rows by request name.
Reviewed By: mweststrate
Differential Revision: D19702494
fbshipit-source-id: 58ea397fa30eb7d80e9640a4c92905de22bb27d4
Summary: Adding a utility for capturing screenshots to the configured location without having to worry about where to store it or use buffers etc.
Reviewed By: mweststrate
Differential Revision: D19765926
fbshipit-source-id: d6b51c4ffafab7450e97a60468926d84a25a8c0f
Summary:
Plugin to plugin deeplinking was broken because the state reducer was ignoring the parameter.
This fixes it.
Reviewed By: jonathoma
Differential Revision: D19791230
fbshipit-source-id: 158b3a6278f5e634093c4284018458883e9aa5ca
Summary: We have already rolled out `support_requests_v2` to 100% of FB employees. Thus removing the unneeded checks for the GK.
Reviewed By: jknoxville
Differential Revision: D19770930
fbshipit-source-id: 06fcf7b6b7c1305ab1b5b3c8df344e2877251e65
Summary: This diff removes the older support form as we no longer use it.
Reviewed By: jknoxville
Differential Revision: D19769541
fbshipit-source-id: ca2088e721f2895f2c8a1205889b0670477cc2d2
Summary: This is experimental feature to prove that vsix format can be used to publish plugins. Turns out there are almost no differences of vsix in comparison with npm packages.
Reviewed By: jknoxville
Differential Revision: D19770476
fbshipit-source-id: b3c62e7f2a4e8000113b9f1651e8657eb3e0d6fa
Summary:
This diff fixes the broken video recording feature for iOS.
There were two bugs, the `stopScreenCapture` was misspelled and one with the codec, ReactPlayer was not able to render with the default codec of hevc
Reviewed By: jknoxville
Differential Revision: D19746904
fbshipit-source-id: f951b016be5f5aec5d4e6bcea4c9c246a62b37a3
Summary: To test plugin installation I need to restart Flipper often, however restart in dev mode is not "true" restart - instead it just reloads the window and doesn't load freshly installed plugins. To make my life easier I have implemented more realistic way for restart in dev mode.
Reviewed By: jknoxville
Differential Revision: D19770263
fbshipit-source-id: 8755663746dc265e0826ed79b9782e073132537f
Summary:
Adding a way to install plugins directly from package files. This is required for testing after packaging format changes.
Stage 3: Implemented installation of plugins directly from package file.
Reviewed By: jknoxville
Differential Revision: D19765619
fbshipit-source-id: 57f36c87d3cf5d4e1c9a1f8f9f9f32b14a18bc8b
Summary:
Adding a way to install plugins directly from package files. This is required for testing after packaging format changes.
Stage 2: Added new component for file selection and implemented UI required for plugin installation from package file
Reviewed By: priteshrnandgaonkar
Differential Revision: D19743998
fbshipit-source-id: 1112d5afca9a649df11e33eb6ac15c0e06747d47
Summary:
The structure of the page is:
```
<FlexColumn>
<Toolbar />
<Content />
<Toolbar />
</FelxColumn>
```
When Content is a FlexColumn, it doesn't play well with the others and uses all the space, to you don't see the bottom toolbar.
Changing it to a FlexRow fixes this. Also added an inner FlexColumn to make sure the behaviour for things inside Content isn't changed (flex-direction needs to be column in there).
Reviewed By: nikoant
Differential Revision: D19766120
fbshipit-source-id: 2872561bbc954db0d4dc3d7040f60c3eec6e3ff2
Summary:
Adding a way to install plugins directly from package files. This is required for testing after packaging format changes.
Stage 1: refactored the plugin manager component file layout, no functional changes.
Reviewed By: jknoxville
Differential Revision: D19741085
fbshipit-source-id: bd9d72382ddc4894de5b3cd9a71877c799886fbf
Summary:
Context: https://fb.workplace.com/groups/flippersupport/permalink/804152663398727/
This gives flipper the location of every node, in relation to the entire screen. This allows it to visualize the position of each node on it's own diagram, overlayed over a screenshot for example. The use case in mind is after importing flipper data, you'll still be able to see layout nodes overlayed over a screenshot taken during export.
Currently this is only added to Android Views, meaning we don't get it for Litho views or anything on iOS.
This is basically to get something working end-to-end, and if it's all good, then I'll add the other types of views.
Reviewed By: passy
Differential Revision: D19747691
fbshipit-source-id: 8ba3aae6b7685de6faaf55b9628c200802801db4
Summary:
Some improvements on the previous diff that were too much for just comments.
- Remove an unnecessary `touch` that I commented on in the previous diff.
- Ensure that the recording button is not set to "recording" if there's an error during the setup.
- More reliable way of checking the file size on the device before pulling.
Still not done: Show the error more prominently in the UI. Out of scope for this but if we could come up with a design for showing this (perhaps in place of the recording button) when something went wrong, that would be more obvious than having the error caret show up at the top of the screen.
Reviewed By: jknoxville
Differential Revision: D19723627
fbshipit-source-id: 20babcc1482e5a9ac829ff6d6ae7a731a3454fa0
Summary:
Original commit changeset: 5caf9df02c95
It backs out the diff as it broke the video recording button in support form.
Bug:
{F227855063}
Reviewed By: passy
Differential Revision: D19742486
fbshipit-source-id: 4a275e6ead919b4f4ed94889545a650c101f89b7
Summary:
Getting the error
```
$ /mnt/btrfs/trunk-hg-fb4a-fbsource-86184178-1580774714/xplat/sonar/node_modules/.bin/tsc --noemit
src/plugins/network/index.tsx(180,59): error TS2349: This expression is not callable.
Type 'Number' has no call signatures.
error Command failed with exit code 1.
```
EDIT: This error was a red herring from another commit I was based on. Either way, `Number` is discouraged by the Typescript standard (https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html), so let's move these to `number` instead.
Reviewed By: mweststrate
Differential Revision: D19712113
fbshipit-source-id: b754780063a1c429724abcd343da06514671bc83
Summary:
Currently `exportStore` function returns the serialized string along with errorArray. errorArray contains an error when there is some issue with fetching metadata. Essentially, it keeps the error in the errorArray and continues with fetching the data for the next plugin. Previously we used to exit our submit form execution when the errorArray had any value. So this diff removes that check and instead logs it on the console and in our logging system.
It will handle the case mentioned [here](https://fb.workplace.com/groups/1430200360634661/permalink/2566831316971554/)
This diff also adds a log when there is failure to upload flipper data.
Reviewed By: mweststrate
Differential Revision: D19723674
fbshipit-source-id: 18bf90461156f67ecc2b4ce4b1eac4aa3485188d
Summary: Shows warning when requiredplugin has empty data. It also makes the validation box as an error one, to distinguish between the two boxes.
Reviewed By: passy
Differential Revision: D19704910
fbshipit-source-id: ffd9413c3cd65c09f8b6019889191decefa6b6f6
Summary:
Backgrouds
- For screen recording Flipper use 'adb shell scrrenrecord' and 'adb pull'.
- 'screenrecord' make error and doens't works for some android devices and AOS versions.
- For example, "--bugreport" option doesn't work old version of AOS.
- We can not control 'screenrecord' command yet.
- It is better let user know the situation early.
<AS-IS>
When 'screenrecord' emit error:
- Noting happened for users.
- Result of screen record file is just empty. (pull command create the file)
<TO-BE>
When 'screenrecord' emit error:
- Let users know 'screenrecord' is not working properly.
Reviewed By: passy
Differential Revision: D19643060
fbshipit-source-id: 5caf9df02c956283f371c50c1735060be2158fb2
Summary: Adds analytics for the selected group, failure cases and distinguishing between user clicks for the support form vs deeplink.
Reviewed By: passy
Differential Revision: D19697856
fbshipit-source-id: 62d5afa998d2096252570387c9a3df1c7c134e67
Summary:
## The dependency [algoliasearch]() was updated from `3.35.1` to `4.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [nunomaduro](https://www.npmjs.com/~nunomaduro)
**License:** MIT
[Find out more about this release]().
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/772
Test Plan: Manually tested searching and installing still works.
Reviewed By: jknoxville
Differential Revision: D19690706
Pulled By: passy
fbshipit-source-id: 46cb05fb2c0429c4a1f7fb31a833cd000805825d
Summary:
## The devDependency [types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped) was updated from `24.9.1` to `25.1.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [types](https://www.npmjs.com/~types)
**License:** MIT
[Find out more about this release](https://github.com/DefinitelyTyped/DefinitelyTyped).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/764
Reviewed By: jknoxville, mweststrate
Differential Revision: D19602722
Pulled By: passy
fbshipit-source-id: 8f20b325389c68e4422842eea164c2f6fc84162a
Summary:
## The devDependency [ts-jest](https://github.com/kulshekhar/ts-jest) was updated from `24.3.0` to `25.1.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [kul](https://www.npmjs.com/~kul)
**License:** MIT
[Find out more about this release](https://github.com/kulshekhar/ts-jest).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/768
Reviewed By: mweststrate
Differential Revision: D19639975
Pulled By: passy
fbshipit-source-id: d3e344d54d76127476c42146e2cc6c4c578d89c8
Summary: This diff refactors the scattered logic of required plugins and default selection of the plugins into Group class. Also the same class handles the deeplink logic.
Reviewed By: mweststrate
Differential Revision: D19666745
fbshipit-source-id: c9427f0ddba643f0b32aac7b6f2496e2e3248b12
Summary:
Write now the logic to append (Imported) and (Offline) text for archived devices is scattered at multiple places. Due to which we had the following bug
{F227484749}
Reviewed By: mweststrate
Differential Revision: D19663506
fbshipit-source-id: 1f5c0060825d8b246c94da85ac4a18cc4ff040d2
Summary: Updated the source a while ago to also include the images plugin.
Reviewed By: nikoant
Differential Revision: D19691720
fbshipit-source-id: 70bf1929e4c571f02db2d8ef787f1130a480d05f
Summary: Changed the plugin display logic in SupportForm to show plugins which are enabled(includes device plugins) and plugins which has `exportPersistedState` defined.
Reviewed By: mweststrate
Differential Revision: D19643857
fbshipit-source-id: 7a4a5882507c06c6b6f9c481ee2c5c36ecc32ac6
Summary:
getTargetDeviceId is now being called directly from within server.tsx.
Since it's exported anyway, it should always sanitize its input.
Changed the ios method to sanitize the CSR in the same way that the android one does.
Reviewed By: cekkaewnumchai
Differential Revision: D19663992
fbshipit-source-id: 77662542b3a8767ecdd4e984a8e2d990761a9815
Summary:
This diff makes sure that important errors are always shown to the user, such as an xcode version mismatch.
Also made some small styling improvements
Reviewed By: jknoxville
Differential Revision: D19660337
fbshipit-source-id: 24dfb4d98bfdd1666164403f87b6a4e1dc915ddb
Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.115.0` to `0.117.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [mvitousek](https://www.npmjs.com/~mvitousek)
**License:** MIT
[Find out more about this release](https://github.com/flowtype/flow-bin).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/763
Reviewed By: passy
Differential Revision: D19621269
Pulled By: mweststrate
fbshipit-source-id: d213eeda19ba3715471f3843b38a8ae5d7a53713
Summary: Remove the old sidebar, since the new one has been rolled out fully
Reviewed By: jknoxville
Differential Revision: D19659945
fbshipit-source-id: d1592df98fe69ef07d88d3a40790768dee3ab11c
Summary: Fixes issue where the user would loose context if having a lot of apps open, and then opening a bug report
Reviewed By: priteshrnandgaonkar
Differential Revision: D19640759
fbshipit-source-id: cc3aa617d99aae1904999da98d12b8a3595f6fbe
Summary:
mityal implemented a new check for nullsafe to warn about potentially
incorrect overrides of `equals` method (not yet released).
While testing some other things I stumbled upon incorrect `equal`
overrides in Flipper, particularly not properly handling `null` param.
Reviewed By: passy
Differential Revision: D19639882
fbshipit-source-id: 7f9aec7270e89a906810807f6849628967047b2a
Summary: Added radio buttons when the listview enforces single selection
Reviewed By: mweststrate
Differential Revision: D19626710
fbshipit-source-id: 9220fad7b0825cac5ba39def4d5e85d671c61da7
Summary: Adds a status message when the one deeplinks to support form and the selectedClient doesn't support GraphQL plugin.
Reviewed By: jknoxville
Differential Revision: D19602900
fbshipit-source-id: 98a45ead2659bb229f4a1301e918e02dca05fc66
Summary: Update the deps as proposed by greenkeeper, to check if they indeed break the build
Reviewed By: passy
Differential Revision: D19620346
fbshipit-source-id: 9e273012373f7091180d90c368a8193572b7155a
Summary: Fixes the broken Layout plugin in wilde. Before this fix it will just show an empty screen in the layout plugin.
Reviewed By: jknoxville
Differential Revision: D19621517
fbshipit-source-id: e10078248b95b93c6b9c87ccf4508628b6ad86bb
Summary: A small clarification after the question 7964772f82 (comments)
Reviewed By: jknoxville
Differential Revision: D19619402
fbshipit-source-id: c392c492fe5e9cd46d46c93f617288ac0a4d02a5
Summary: When JavaScript fiction meets native interop reality, things get weird. Apparently some coordinates must be integer values.
Reviewed By: mweststrate
Differential Revision: D19606677
fbshipit-source-id: 88a6e8c465e59078b070b56b37eee571274c494a
