Summary:
what else can I say
move_complexity
Reviewed By: passy
Differential Revision: D31483414
fbshipit-source-id: 1692c792121a3aae0843eb238040cae0445cdf54
Summary: Moved Logger, sleep, timeout and server contract types to flipper-common packages.
Reviewed By: passy
Differential Revision: D31475790
fbshipit-source-id: 42d2147698875f9e919ad5250f9953f3bff3ec2d
Summary: Further decoupling of `server/` from the rest of the code base. Also fixed a problem with promise chaining causing promises to create unhandled rejection errors.
Reviewed By: passy
Differential Revision: D31474919
fbshipit-source-id: 027cccbe9b57d856c94d63c093d39b6cb3e53312
Summary: In a diff down the stack I introduced sending of info/warn/error logs to Scuba. Here I'm just changing level of all connectivity-related logging to "info" as they often required for investigations.
Reviewed By: mweststrate
Differential Revision: D31532770
fbshipit-source-id: 956d6712918291579b3beb12cb91ab69ce1e3859
Summary: Just a small fix to ensure all plugins are shown in the list even if no device / app is connected to Flipper. We show them under "Unavailable plugins" with explanation why they not available. This allows user to check plugin documentation even without connecting anything to Flipper.
Reviewed By: passy
Differential Revision: D31532732
fbshipit-source-id: 4e481b3d6923bb073a1478b2bd283db25a374c72
Summary: As we now send warn logs to server - it better to reduce their count. This diff folds all the warnings for plugins using the legacy API into one warning.
Reviewed By: passy
Differential Revision: D31532559
fbshipit-source-id: 0621a170e11e9d9645964dd8ecf2f9e753273225
Summary:
Bumps [ansi-to-html](https://github.com/rburns/ansi-to-html) from 0.7.1 to 0.7.2.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/rburns/ansi-to-html/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2962
Reviewed By: nikoant
Differential Revision: D31545947
Pulled By: passy
fbshipit-source-id: 48457ea23946ac946347137e50ee30bea943c93e
Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.114.0 to 0.114.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/flipper/releases">react-native-flipper's releases</a>.</em></p>
<blockquote>
<h2>v0.114.1</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md</a>
for full notes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e7b3ea9344"><code>e7b3ea9</code></a> Flipper Release: v0.114.1</li>
<li><a href="4736abc29c"><code>4736abc</code></a> Upgrade publish action</li>
<li><a href="c3ff0ff355"><code>c3ff0ff</code></a> Set up Flipper decapitated packages</li>
<li><a href="99acd766b9"><code>99acd76</code></a> Upgrade example project to 0.66</li>
<li><a href="d56375970d"><code>d563759</code></a> Cleaning up sheet abstraction to use Ant/flipper-plugin dialogs instead</li>
<li><a href="9e5575cf69"><code>9e5575c</code></a> Dialog management cleanup</li>
<li><a href="89b193b438"><code>89b193b</code></a> Clean up Sheet abstraction</li>
<li><a href="740093d0d9"><code>740093d</code></a> Separate Client in server and client part</li>
<li><a href="eab4804792"><code>eab4804</code></a> Update React DevTools from 4.13.0 -> 4.19.1</li>
<li><a href="a7e02f234a"><code>a7e02f2</code></a> Set license to MIT</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.114.0...v0.114.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2964
Reviewed By: nikoant
Differential Revision: D31545930
Pulled By: passy
fbshipit-source-id: 3308bed8c54bc2a5986b6943554085bd78a03b72
Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.112.0 to 0.114.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/flipper/releases">react-native-flipper's releases</a>.</em></p>
<blockquote>
<h2>v0.114.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md</a>
for full notes.</p>
<h2>v0.113.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md</a>
for full notes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="49d41f15e3"><code>49d41f1</code></a> Flipper Release: v0.114.0</li>
<li><a href="37529af074"><code>37529af</code></a> Track plugin selection steps</li>
<li><a href="bce2cdc316"><code>bce2cdc</code></a> Reduce logging verbosity for flipper socket provider switches</li>
<li><a href="026f8fc308"><code>026f8fc</code></a> Store clients as Map rather than array</li>
<li><a href="c9a34d3cc2"><code>c9a34d3</code></a> Fix inconsistent handling of app id and name</li>
<li><a href="ba89daf12c"><code>ba89daf</code></a> Bump RN example pod files</li>
<li><a href="799d88275e"><code>799d882</code></a> Remove WebSocket delegate before closing</li>
<li><a href="20185f37ab"><code>20185f3</code></a> Init and error logging</li>
<li><a href="d6cc115a90"><code>d6cc115</code></a> Flipper Snapshot Bump: v0.113.1-SNAPSHOT</li>
<li><a href="672cfad7d6"><code>672cfad</code></a> Flipper Release: v0.113.0</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.112.0...v0.114.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2949
Reviewed By: muraziz
Differential Revision: D31502057
Pulled By: passy
fbshipit-source-id: f2a290b07c569982e7de3c9d1b28c9b60b73159c
Summary:
This is not actionable on our end because this will get
triggered for anyone setting a wrong ANDROID_HOME path.
Reviewed By: mweststrate
Differential Revision: D31502390
fbshipit-source-id: 529f1ba940cf6e38363933f706d167196116231a
Summary:
Following mweststrate's advice on how to fix this.
Pull Request resolved: https://github.com/facebook/flipper/pull/2956
Test Plan: Watch the Action.
Reviewed By: lblasa
Differential Revision: D31502115
Pulled By: passy
fbshipit-source-id: 0f6dc73bcfde30fe7e2ee78e58d1c8e6fc16ec29
Summary:
Bumps [okhttp](https://github.com/square/okhttp) from 4.9.1 to 4.9.2.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/square/okhttp/blob/master/CHANGELOG.md">okhttp's changelog</a>.</em></p>
<blockquote>
<h2>Version 4.9.2</h2>
<p><em>2021-09-30</em></p>
<ul>
<li>Fix: Don't include potentially-sensitive header values in <code>Headers.toString()</code> or exceptions.
This applies to <code>Authorization</code>, <code>Cookie</code>, <code>Proxy-Authorization</code>, and <code>Set-Cookie</code> headers.</li>
<li>Fix: Don't crash with an <code>InaccessibleObjectException</code> when running on JDK17+ with strong
encapsulation enabled.</li>
<li>Fix: Strictly verify hostnames used with OkHttp's <code>HostnameVerifier</code>. Programs that make direct
manual calls to <code>HostnameVerifier</code> could be defeated if the hostnames they pass in are not
strictly ASCII. This issue is tracked as [CVE-2021-0341].</li>
</ul>
<h2>Version 5.0.0-alpha.2</h2>
<p><em>2021-01-30</em></p>
<p><strong>In this release MockWebServer has a new Maven coordinate and package name.</strong> A longstanding
problem with MockWebServer has been its API dependency on JUnit 4. We've reorganized things to
remove that dependency while preserving backwards compatibility.</p>
<table>
<thead>
<tr>
<th align="left">Maven Coordinate</th>
<th align="left">Package Name</th>
<th align="left">Description</th>
</tr>
</thead>
<tbody>
<tr>
<td align="left">com.squareup.okhttp3:mockwebserver3:5.0.0-alpha.2</td>
<td align="left">mockwebserver3</td>
<td align="left">Core module. No JUnit dependency!</td>
</tr>
<tr>
<td align="left">com.squareup.okhttp3:mockwebserver3-junit4:5.0.0-alpha.2</td>
<td align="left">mockwebserver3.junit4</td>
<td align="left">Optional JUnit 4 integration.</td>
</tr>
<tr>
<td align="left">com.squareup.okhttp3:mockwebserver3-junit5:5.0.0-alpha.2</td>
<td align="left">mockwebserver3.junit5</td>
<td align="left">Optional JUnit 5 integration.</td>
</tr>
<tr>
<td align="left">com.squareup.okhttp3:mockwebserver:5.0.0-alpha.2</td>
<td align="left">okhttp3.mockwebserver</td>
<td align="left">Obsolete. Depends on JUnit 4.</td>
</tr>
</tbody>
</table>
<p>The new APIs use <code>mockwebserver3</code> in both the Maven coordinate and package name. This new API is
<strong>not stable</strong> and will likely change before the final 5.0.0 release.</p>
<p>If you have code that subclasses <code>okhttp3.mockwebserver.QueueDispatcher</code>, this update is not source
or binary compatible. Migrating to the new <code>mockwebserver3</code> package will fix this problem.</p>
<ul>
<li>New: DNS over HTTPS is now a stable feature of OkHttp. We introduced this as an experimental
module in 2018. We are confident in its stable API and solid implementation.</li>
<li>Fix: Work around a crash in Android 10 and 11 that may be triggered when two threads
concurrently close an SSL socket. This would have appeared in crash logs as
<code>NullPointerException: bio == null</code>.</li>
<li>Fix: Use plus <code>+</code> instead of <code>%20</code> to encode space characters in <code>FormBody</code>. This was a
longstanding bug in OkHttp. The fix makes OkHttp consistent with major web browsers.</li>
<li>Fix: Don't crash if Conscrypt returns a null version.</li>
<li>Fix: Include the public suffix data as a resource in GraalVM native images.</li>
<li>Fix: Fail fast when the cache is corrupted.</li>
<li>Fix: Fail fast when a private key cannot be encoded.</li>
<li>Fix: Fail fast when attempting to verify a non-ASCII hostname.</li>
<li>Upgrade: [GraalVM 21][graalvm_21].</li>
<li>Upgrade: [Kotlin 1.4.20][kotlin_1_4_20].</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="3edf17ca8a"><code>3edf17c</code></a> Prepare for release 4.9.2.</li>
<li><a href="262b3cde9f"><code>262b3cd</code></a> Handle strict module handling on JDK17 (<a href="https://github-redirect.dependabot.com/square/okhttp/issues/6707">#6707</a>) (<a href="https://github-redirect.dependabot.com/square/okhttp/issues/6742">#6742</a>)</li>
<li><a href="f574ea2f52"><code>f574ea2</code></a> Cherry pick fix for CVE-2021-0341 onto 4.9.x (<a href="https://github-redirect.dependabot.com/square/okhttp/issues/6741">#6741</a>)</li>
<li><a href="1fd7c0afdc"><code>1fd7c0a</code></a> Make it more difficult to accidentally log sensitive headers (<a href="https://github-redirect.dependabot.com/square/okhttp/issues/6551">#6551</a>) (<a href="https://github-redirect.dependabot.com/square/okhttp/issues/6740">#6740</a>)</li>
<li><a href="b0397cc7a9"><code>b0397cc</code></a> 4.9.x GitHub builds update (<a href="https://github-redirect.dependabot.com/square/okhttp/issues/6732">#6732</a>)</li>
<li><a href="eb5a8343ea"><code>eb5a834</code></a> Prepare next development version.</li>
<li>See full diff in <a href="https://github.com/square/okhttp/compare/parent-4.9.1...parent-4.9.2">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2937
Reviewed By: muraziz
Differential Revision: D31502045
Pulled By: passy
fbshipit-source-id: 32af7cda9440b01eab1bca83dc694391d99bf7e6
Summary: I upgraded the docker image which should pull the latest GHR release (https://github.com/tcnksm/ghr).
Reviewed By: lblasa
Differential Revision: D31442256
fbshipit-source-id: 0f9fa81ec1be1285aea3da621b7ef5a1e63c3e84
Summary:
This diff introduces the packages necessary for Flipper decapitated.
* flipper-common: utilities & types shared between client, server, flipper-plugin
* flipper-server-core: all device & client management goes in here. Basically flipper's backend
* flipper-ui-core: all UI goes in here, as far as it doesn't depend on Electron
* desktop: the Electron app, will load server-core and ui-core, and glue them together, providing implementations for some electron specific stuff like dialgos
* flipper-server: A node process hosting flipper-server-core, that can be connected to over websockets. And probably can serve a browser version of the UI as well.
* flipper-ui-browser: thin wrapper around flipper-ui-core, providing some browser specific behavior / stubs.
* flipper-dump: (might remove later), but want to hack a quick and dirt flipper dump in here, as alternative way to test flipper-server-core.
This diff just creates the packages, but doesn't move any code, so it can be summarized as:
restoftheowl
Reviewed By: nikoant
Differential Revision: D30218646
fbshipit-source-id: 735598a1261a98e584f52504b5eba01ec0afa162
Summary:
Per https://react-native-community.github.io/upgrade-helper/?from=0.65.1&to=0.66.0
Also cleaned up lockfiles, made relative-deps non-default, removed old resolutions since I got weird errors with them.
allow-large-files
Reviewed By: timur-valiev
Differential Revision: D31471307
fbshipit-source-id: 2ef8856498bb73293d6638b2c08a1042adb636e5
Summary:
This diff cleans up order remaining dialogs, the ones involved in exporting to file or url. Includes some legacy component cleanup boyscouting, but not too much.
This removes a lot of code where state of the wizard was stored globally, and makes it locally instead.
Other code that was removed involves interaction with the old UI, which allowed import / export to be running in the background as well. (which is no longer needed since we optimised the process)
Reviewed By: timur-valiev
Differential Revision: D30192000
fbshipit-source-id: 13be883c5bf217a3d58b610b78516359e9bd0ebc
Summary:
This diff moves the dialogs
* Settings
* Plugin Manager
* Doctor
* Sign in
* Changelog
To use the imperative dialog APIs, rather then organising them through reducers which adds a lot of indirection which isn't really needed but hard to follow.
Reviewed By: passy
Differential Revision: D30192002
fbshipit-source-id: ba38b2e700da3e442653786448fcbf85074981ad
Summary: This stack gets rid of Flippers old sheet abstraction that relies on native (Electron) overlays, and implements it using Ant dialogs instead. Also removes a lot of code by making dialog API imperative, rather than reducer organised, like done in the deeplink handling.
Reviewed By: passy
Differential Revision: D30192001
fbshipit-source-id: 9bca3274bd039207e58f8f9394027515e391671d
Summary: This diff separates the concept of a Client as now on the UI, from the concept of a Client as known on the server, and makes all interactions with client and vice versa async.
Reviewed By: timur-valiev
Differential Revision: D31235682
fbshipit-source-id: 99089e9b390b4c5359f97f6f2b15bf4b182b6cb9
Summary:
The entire repo is MIT (unless stated otherwise) but
without the flag, yarn is very noisy on every startup.
{F668266100}
Reviewed By: timur-valiev
Differential Revision: D31429016
fbshipit-source-id: 11a963181dc309a251e6c71a9a16ab93d12b7f93
Summary: Sets up some logging for the various drop-out points when going through the deeplink flow.
Reviewed By: lblasa
Differential Revision: D31345623
fbshipit-source-id: a06ca97c1e687e39ea97a1f47fd8bb614149056f
Summary: Refactor clients storage: array -> map. A lot of logic looks up clients by their id, which is currently done with an array.find operation, which is pretty inefficient. This diff changes it to a map, that is pretty important, as in the next diff the decoupled client message handing will need to find the client again for every message that arrives.
Reviewed By: timur-valiev
Differential Revision: D31303536
fbshipit-source-id: ca3f540a3de7665930d2354436d37cb0fbfd5546
Summary:
Changelog: Improved plugin / device / app selection handing.
During some refactorings I discovered that the `connetions.selectedApp` field contained sometimes an application id, and sometimes just the name. This caused inconsistent behavior especially in unit tests.
I've cleaned that up, and renamed it to `selectedAppId` where applicable, to make the distinction more clear.
And, in contrast, userPreferredApp now always has a name, not an id.
During refactoring our existing selection update logic was quite in the way, which was overcomplicated still, since during the sandy chrome migration, the reducers needed to be able to handle both the old UI, and the new application selection UI. That logic has been simplified now, and a lot of tests were added.
As a further simplification the preferredApp/Device/Plugin are now only read and used when updating selection, but not when running selectors.
Reviewed By: timur-valiev
Differential Revision: D31305180
fbshipit-source-id: 2dbd9f9c33950227cc63aa29cc4a98bdd0db8e7a
Summary:
This change removes ourselves as a delegate before closing.
SocketRocket uses its own internal async queue to perform most operations.
After a disconnect, we don't expect to receive any more delegate calls as the handlers may contain references which may have become invalid.
So, removing ourselves as delegates will ensure that we don't get called after a disconnect.
For sanity, we are also taking a copy of the message handler instead of a reference to it.
Reviewed By: briantkelley
Differential Revision: D31360721
fbshipit-source-id: bae5a2423757cd9064ffac28afb8b78c28a20d87
Summary:
Set up some basic logging for deep link usage at the entry point and error cases.
More granular logging coming up next.
Reviewed By: nikoant
Differential Revision: D31337822
fbshipit-source-id: 171eae68fb3d9a11aa155087baf6f8309bbd7295
Summary:
Add screenreader-focusable property to AccessibilityUtil#getAccessibilityNodeInfoData
The accessibility hierarchy displays various AccessibilityNodeInfo properties. However, it was missing the screenreader-focusable property.
## Changelog
Display screenreader-focusable property in the accessibility hierarchy.
Pull Request resolved: https://github.com/facebook/flipper/pull/2925
Test Plan: Test suite passes and code lints.
Reviewed By: mweststrate
Differential Revision: D31312381
Pulled By: passy
fbshipit-source-id: c5044cef6aabe5bd2d2ce5e315f5aafd6990a137
Summary: Some drive-by changes as I'm working on other stuff.
Reviewed By: mweststrate
Differential Revision: D31337500
fbshipit-source-id: 8f348af06b7c4b159703d7adf160a7380ba57b22
Summary:
Splitting this up into the wiring and the actual usage.
This just ensures we have a logger in place for handling
deeplinks.
Reviewed By: mweststrate
Differential Revision: D31337457
fbshipit-source-id: b088a7396e38554a87502ba7d5669dbef1b398d7
Summary:
Grey -> gray. "Cancelled" seems quite common in APIs though, so I disabled that.
A few promise cleanups
Reviewed By: aigoncharov
Differential Revision: D31323610
fbshipit-source-id: c8863d995936f451c24eb408fe5c26677187f089
