Commit Graph

6639 Commits

Author SHA1 Message Date
dependabot[bot]
199b14a4eb Bump @emotion/react from 11.4.1 to 11.5.0 in /desktop (#3022)
Summary:
Bumps [emotion/react](https://github.com/emotion-js/emotion) from 11.4.1 to 11.5.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@​emotion/react</code>'s releases</a>.</em></p>
<blockquote>
<h2><code>@​emotion/react</code><a href="https://github.com/11"><code>@​11</code></a>.5.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>
<p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2498">https://github.com/facebook/flipper/issues/2498</a> <a href="e5beae8e32"><code>e5beae8e</code></a> Thanks <a href="https://github.com/Andarist"><code>@​Andarist</code></a>! - Fixed an edge case issue with incorrect rules being generated. When a context selector (<code>&amp;</code>) was used not at the beginning of a selector (which is not valid SCSS but is allowed by the Stylis parser that we are using) within a group of selectors containing a pseudoclass then it was not replaced correctly with the current context selector.</p>
</li>
<li>
<p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2500">https://github.com/facebook/flipper/issues/2500</a> <a href="eda5e687c0"><code>eda5e687</code></a> Thanks <a href="https://github.com/Jarred-Sumner"><code>@​Jarred-Sumner</code></a>! - Fix error loading <code>@​emotion/react</code> in alternative JS environments</p>
</li>
<li>
<p>Updated dependencies [<a href="e5beae8e32"><code>e5beae8e</code></a>, <a href="9ae4a91a08"><code>9ae4a91a</code></a>, <a href="f2eda82954"><code>f2eda829</code></a>]:</p>
<ul>
<li><code>@​emotion/cache</code><a href="https://github.com/11"><code>@​11</code></a>.5.0</li>
<li><code>@​emotion/sheet</code><a href="https://github.com/1"><code>@​1</code></a>.0.3</li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="4be3391914"><code>4be3391</code></a> Version Packages (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2495">https://github.com/facebook/flipper/issues/2495</a>)</li>
<li><a href="f2eda82954"><code>f2eda82</code></a> Prevent flush from raising error on detached tag (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2447">https://github.com/facebook/flipper/issues/2447</a>)</li>
<li><a href="d7d768e056"><code>d7d768e</code></a> Implement automatic adding of jsxImportSource pragma definition (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2353">https://github.com/facebook/flipper/issues/2353</a>)</li>
<li><a href="685bbec099"><code>685bbec</code></a> Improve readability of the <code>extractCriticalToChunks</code> example in the docs (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2460">https://github.com/facebook/flipper/issues/2460</a>)</li>
<li><a href="218e4f78ca"><code>218e4f7</code></a> Add <code>RegExp</code> as a valid type for the <code>target</code> option accepted by `toHaveStyle...</li>
<li><a href="eda5e687c0"><code>eda5e68</code></a> Fix error in alternative JS environments (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2500">https://github.com/facebook/flipper/issues/2500</a>)</li>
<li><a href="84522ded6e"><code>84522de</code></a> fix: update docs references (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2497">https://github.com/facebook/flipper/issues/2497</a>)</li>
<li><a href="500cdd828b"><code>500cdd8</code></a> Support typings for Jest v27 (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2456">https://github.com/facebook/flipper/issues/2456</a>)</li>
<li><a href="e5beae8e32"><code>e5beae8</code></a> Fixed an issue with context selector not at the beginning (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2498">https://github.com/facebook/flipper/issues/2498</a>)</li>
<li><a href="63a0a6c5d1"><code>63a0a6c</code></a> Fix URLs in the <code>docs/extract-static.mdx</code> (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2496">https://github.com/facebook/flipper/issues/2496</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/emotion-js/emotion/compare/emotion/react@11.4.1...@emotion/react@11.5.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@emotion/react&package-manager=npm_and_yarn&previous-version=11.4.1&new-version=11.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3022

Reviewed By: passy

Differential Revision: D32202484

Pulled By: mweststrate

fbshipit-source-id: 85c7df21741e7e19108039199c8c3671258a7c87
2021-11-05 05:29:54 -07:00
Michel Weststrate
2eaccff720 Remove Electron devtools closing
Summary: Follow up on D31992230 (2e7015388c) to replace `require('electron')` with `global.electronRequire('electron')`. However, during testing noticed that the Hermes debugger works just fine even with Electron DevTools open, so removed the logic altogether.

Reviewed By: aigoncharov

Differential Revision: D32167673

fbshipit-source-id: c6c6c07f07ac8c44e0f6959d56bf4c16725c186e
2021-11-05 05:14:03 -07:00
Michel Weststrate
4cf1920e36 Fix cert generation for new users
Summary:
Changelog: Fix server certificates not being generated for first time users.

As reported in https://fb.workplace.com/groups/flippersupport/permalink/1247554795725176/, server certificates are not generated properly for new users.

Also the fix. Omg. How does typechecking not find this?

...Oh yeah yeah I now, `await not-a-promise` is juuuusst fine. Long live `.then(` I guess...

Reviewed By: jknoxville

Differential Revision: D32203132

fbshipit-source-id: abd75c178e9c8640a266b2012b9250503d4258be
2021-11-05 05:08:46 -07:00
Michel Weststrate
1e146d68c3 Fix publish script
Summary:
Changelog: Fix js-flipper package being published empty

Build js-flipper before publishing

Fixes(?) https://github.com/facebook/flipper/issues/3023

Reviewed By: jknoxville

Differential Revision: D32201978

fbshipit-source-id: 962b14fe1b5accb99bb06c098d86a6824599c967
2021-11-05 05:08:46 -07:00
Pascal Hartig
72c886e91f Fix reading of launcher settings
Summary:
Noticed in a bug report that the read value was `[object Promise]`.

This wasn't a huge issue before because the worst case was that when writing settings, it would replace them again with the defaults, but still not great.

Reviewed By: mweststrate

Differential Revision: D32181718

fbshipit-source-id: cf6cd7aa3bd823845d6657c5466fbcdef6adac28
2021-11-05 05:03:02 -07:00
Pascal Hartig
3bc8cbc5c5 Add comments for remaining events
Summary:
Ugh, VS Code blocked on the formatter and didn't include these
in my previous commit.

Reviewed By: mweststrate

Differential Revision: D32179985

fbshipit-source-id: e8cf178996bc3b468c88023a5c48e69271758e07
2021-11-05 05:03:02 -07:00
Pascal Hartig
513c475e3d Add comments for interaction events
Summary: Per title

Reviewed By: mweststrate

Differential Revision: D32171224

fbshipit-source-id: b7610e8c10674d56e75468f46a3fd0664d70b4aa
2021-11-05 05:03:02 -07:00
Abhishek Nandwana
2f471cc2b2 Visual changes to let the user easily know what release channel they are using
Summary:
1. Added a text label similar to the launch screen that tells user the release channel they are using.
2. Show a different coloured logo when the user is using the "Insiders" channel.

I have tried to keep the style as similar to the launch screen as possible for consistency.

Reviewed By: passy

Differential Revision: D32169268

fbshipit-source-id: f119a379fce983d9df765ede94148a4deaa31c9c
2021-11-04 14:01:34 -07:00
Andrey Goncharov
9d41c3c44c Fix device connection timeout notification
Summary:
Currently, when a new app connects to Flipper, we show a lost connection notification even though it successfully connects to Flipper.
It happens because we of the device_id mismatch.

Reviewed By: mweststrate

Differential Revision: D32169917

fbshipit-source-id: 6df3ae7fd621b4549e18c1835473a13f18cfb339
2021-11-04 09:12:56 -07:00
Gerard Delmas
6bcb5a435b Hide "no application selected" warning when there is no device
Summary:
In the left App Inspect sidebar on Flipper there were two warning messages
- "no devices found"
- "no application selected"

As there can be no application selected, while no device is active, this change removes the "no application selected" warning. Resulting in only showing one warning at a time.

As I am not familiar with all the states, nor what kind of devices or applications can exist in detail, I have moved up the logic to show the "no device found" message. Then reused it for the "no application selected" visibility.

In case the upper device list can show "connecting" without an actual device in the list, the "no application selected" message will be shown.

Reviewed By: passy

Differential Revision: D32139077

fbshipit-source-id: 06456e81fbe1f86d65f9aba598ee84ed8cd6b043
2021-11-04 05:13:46 -07:00
Flipper Bot
3ff955c42b Flipper Snapshot Bump: v0.118.1-SNAPSHOT
Summary: Releasing snapshot version 0.118.1-SNAPSHOT

Reviewed By: mweststrate

Differential Revision: D32167845

fbshipit-source-id: aba7fc088fa2a4fa97a6d762c67b05d232e3c264
2021-11-04 04:29:00 -07:00
Flipper Bot
4c4ef9b68f Flipper Release: v0.118.0
Summary: Releasing version 0.118.0

Reviewed By: mweststrate

Differential Revision: D32167843

fbshipit-source-id: 1731e360ee1427ffabb9f0933470b1288bbe51a4
2021-11-04 04:29:00 -07:00
Andrey Goncharov
047d6d5d4e Update RN iOS example
Summary: Update RN iOS dependencies

Reviewed By: lblasa

Differential Revision: D32140297

fbshipit-source-id: 5c35794ada1c35948e9dd9bb9a66634b2de81515
2021-11-04 03:43:39 -07:00
Daniel Kohli
67b4b53c20 Rotate Styling for Vertical Sidebar
Summary: - We are using the `Sidebar` component in our `LogViewer` implementation and we noticed that it needed some styling updates to be used properly as a vertical `Sidebar`.

Reviewed By: mweststrate

Differential Revision: D32083159

fbshipit-source-id: 441f3972ae900b5d5f353d3c7b56117c489850ba
2021-11-03 09:48:38 -07:00
Andrey Goncharov
9975aa9319 Fix idb pull
Summary:
Workaround for idb weirdness
Originally started at D27590885
Re-appared at https://github.com/facebook/flipper/issues/3009

Reviewed By: mweststrate

Differential Revision: D32106952

fbshipit-source-id: 63d4fa64503c5c2ba80dae113850c937450ab0fb
2021-11-03 08:11:01 -07:00
Andrey Goncharov
bffd58b3a6 Fix idb device duplicates
Summary:
idb sometimes returns duplicates when we query targets. It leads us to removing valid devices and reconnecting to them again. Eventually, it starves the idb thread pool.
This diff removes the duplicates from the idb output.

Reviewed By: jknoxville

Differential Revision: D32099320

fbshipit-source-id: 7d8b756360f82557000ea5aa037a249b33be9961
2021-11-03 08:11:01 -07:00
Michel Weststrate
2e7015388c Remove remaining Electron imports from product code: paths & env
Summary:
This diff removes most remaining Electron imports, by storing env and path constants on the RenderHost. As nice side effect those paths are all cached now as well.

To make sure RenderHost is initialised before Flipper itself, forced loading Flipper through a require. Otherwise the setup is super sensitive to circular import statements, since a lot of module initialisation code depends on those paths / env vars.

Reviewed By: nikoant

Differential Revision: D31992230

fbshipit-source-id: 91beb430902272aaf4b051b35cdf12d2fc993347
2021-11-03 07:01:21 -07:00
Pascal Hartig
dba09542f9 Enforce promise chains lint
Summary: Setting the lint level to error and fixing the last three violations.

Reviewed By: nikoant

Differential Revision: D32109025

fbshipit-source-id: 213ecaa17317f665ac5a192682fa06d182c28581
2021-11-03 06:53:22 -07:00
Pascal Hartig
03a824ea18 Enforce console.error usage with context
Summary: We're down to zero!

Reviewed By: nikoant

Differential Revision: D32099777

fbshipit-source-id: af76a2e39b2bdf1523baa0a9cb219d8219818fa9
2021-11-03 06:53:22 -07:00
Pascal Hartig
dc6dd47a23 Make openssl check async
Summary:
This was the last eslint warning for `flipper-server-core` and the only call-site
was async already.

Reviewed By: mweststrate

Differential Revision: D32026626

fbshipit-source-id: 0d6f06086c33707b26f58f668ad533daca9de7dd
2021-11-03 05:40:04 -07:00
Michel Weststrate
72ce759e61 Remove some unhandled rejections in tests
Summary: Fixed several tests that caused uncaught promise rejects to fire after the tests finished. This caused jest to fail if there are too many of them.

Reviewed By: aigoncharov

Differential Revision: D32118124

fbshipit-source-id: 50734dab6dee2efec7f056940af72858b27b1707
2021-11-03 03:14:08 -07:00
Michel Weststrate
8f3e729b7b Bump electron-builder
Summary: `yarn build --mac` started failing with errors. This fixes it. Probable root cause: https://github.com/electron-userland/electron-builder/issues/5668

Reviewed By: aigoncharov

Differential Revision: D32101006

fbshipit-source-id: 50011f8be8079bd96c8f602002ccb500c3ad4794
2021-11-02 09:19:41 -07:00
Andrey Goncharov
db59652d0e Fix ___cxa_increment_exception_refcount
Summary: Replicates https://www.internalfb.com/diff/D30950944

Reviewed By: lblasa

Differential Revision: D32019911

fbshipit-source-id: 8e8a486a2feb7dd34650819d403c2cb21410218c
2021-11-01 11:41:25 -07:00
Juan Tejada
763a29d799 Update React Devtools v4.21.0
Summary:
Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Flippe, etc.

`js1 upgrade react-devtools -v 4.21.0`

# Changelog:

[General][Changed] - Upgraded react-devtools-core dependency to 4.21.0

Reviewed By: bvaughn

Differential Revision: D32065685

fbshipit-source-id: 30d0cca2bec6e9abe384da2afefab1d241e0523f
2021-11-01 10:46:02 -07:00
Edward Pastuszenski
64df212cd3 Support iOS FlipperConnection send with array parameters
Summary: Achieving API parity with C++ and Android.

Reviewed By: lblasa

Differential Revision: D31921830

fbshipit-source-id: 873901107fc3c53166fa7bbaaff65ebdb0e53c2a
2021-10-28 14:58:36 -07:00
Anton Kastritskiy
4a4cc21d89 Refine DataSource id to use actual key type instead of a wide string type
Summary: Current implementation uses type `string` as a key for indexing items stored in datasource. However, users can provide any key as an index which means that the type of index item can be anything, not only string. This diff introduces a more refined types for the key. It adds another requirement to provide a key property to a generic which is used to infer the index type.

Reviewed By: mweststrate, aigoncharov

Differential Revision: D31895751

fbshipit-source-id: 19ba907bd6f35df87e3fa442db5fc5cec6af174d
2021-10-28 10:44:01 -07:00
Michel Weststrate
64e791e253 Remove usage of Electron context menus
Summary: Removed the usage of electron's native context menus, and replaces it with Antd based context menu's.

Reviewed By: passy

Differential Revision: D31990756

fbshipit-source-id: 0312cbac5fd20a1a30603ce1058c03f4291b23b1
2021-10-28 07:41:00 -07:00
Michel Weststrate
25590e14b9 Move Electron stuff to separate folder, decapitate restart
Summary: Per title

Reviewed By: passy

Differential Revision: D31991715

fbshipit-source-id: 9ca58cdd26c1f540fbe09dcfc7b7f5e7a319ea7d
2021-10-28 07:41:00 -07:00
dependabot[bot]
7a19b1c8d4 Bump ws from 7.5.5 to 8.2.3 in /desktop (#3004)
Summary:
Bumps [ws](https://github.com/websockets/ws) from 7.5.5 to 8.2.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/websockets/ws/releases">ws's releases</a>.</em></p>
<blockquote>
<h2>8.2.3</h2>
<h1>Bug fixes</h1>
<ul>
<li>When context takeover is enabled, messages are now compressed even if their size
is below the value of the <code>perMessageDeflate.threshold</code> option (41ae5631).</li>
</ul>
<h2>8.2.2</h2>
<h1>Bug fixes</h1>
<ul>
<li>Some closing operations are now run only if needed (ec9377ca).</li>
</ul>
<h2>8.2.1</h2>
<h1>Bug fixes</h1>
<ul>
<li>Fixed an issue where the socket was not resumed, preventing the connection
from being closed cleanly (869c9892).</li>
</ul>
<h2>8.2.0</h2>
<h1>Features</h1>
<ul>
<li>Added <code>WebSocket.WebSocket</code> as an alias for <code>WebSocket</code> and
<code>WebSocket.WebSocketServer</code> as an alias for <code>WebSocket.Server</code> to fix name
consistency and improve interoperability with the ES module wrapper (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/1935">https://github.com/facebook/flipper/issues/1935</a>).</li>
</ul>
<h2>8.1.0</h2>
<h1>Features</h1>
<ul>
<li>Added ability to skip UTF-8 validation (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/1928">https://github.com/facebook/flipper/issues/1928</a>).</li>
</ul>
<h1>Bug fixes</h1>
<ul>
<li>Fixed an issue with a breaking change in Node.js master (6a72da3e).</li>
<li>Fixed a misleading error message (c95e695d).</li>
</ul>
<h2>8.0.0</h2>
<h1>Breaking changes</h1>
<ul>
<li>The <code>WebSocket</code> constructor now throws a <code>SyntaxError</code> if any of the
subprotocol names are invalid or duplicated (0aecf0c9).</li>
<li>The server now aborts the opening handshake if an invalid
<code>Sec-WebSocket-Protocol</code> header field value is received (1877ddeb).</li>
<li>The <code>protocols</code> argument of <code>handleProtocols</code> hook is no longer an <code>Array</code> but
a <code>Set</code> (1877ddeb).</li>
<li>The opening handshake is now aborted if the <code>Sec-WebSocket-Extensions</code> header
field value is empty or it begins or ends with a white space (e814110e).</li>
<li>Dropped support for Node.js &lt; 10.0.0 (552b5067).</li>
<li>The <code>WebSocket</code> constructor now throws a <code>SyntaxError</code> if the connection URL
contains a fragment identifier or if the URL's protocol is not one of <code>'ws:'</code>,
<code>'wss:'</code>, or <code>'ws+unix:'</code> (ebea038f).</li>
<li>Text messages and close reasons are no longer decoded to strings. They are</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="cfd99b6309"><code>cfd99b6</code></a> [dist] 8.2.3</li>
<li><a href="fef7942a18"><code>fef7942</code></a> [ci] Fix typo</li>
<li><a href="41ae56313b"><code>41ae563</code></a> [fix] Ignore the <code>threshold</code> option if context takeover is enabled</li>
<li><a href="474aa3616f"><code>474aa36</code></a> [doc] Improve <code>WebSocket#{p{i,o}ng,send}()</code> documentation</li>
<li><a href="055949fd23"><code>055949f</code></a> [doc] Remove no longer needed noop function from code snippet</li>
<li><a href="5b85322f54"><code>5b85322</code></a> [ci] Update coverallsapp/github-action action to version 1.1.3</li>
<li><a href="f871195c55"><code>f871195</code></a> [doc] Update issue template</li>
<li><a href="72296e54ca"><code>72296e5</code></a> [dist] 8.2.2</li>
<li><a href="3039b6b9d2"><code>3039b6b</code></a> [doc] Change label text to CI</li>
<li><a href="04c032c51b"><code>04c032c</code></a> [ci] Use Github Actions for Windows x86 testing</li>
<li>Additional commits viewable in <a href="https://github.com/websockets/ws/compare/7.5.5...8.2.3">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ws&package-manager=npm_and_yarn&previous-version=7.5.5&new-version=8.2.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3004

Reviewed By: passy

Differential Revision: D31991546

Pulled By: cekkaewnumchai

fbshipit-source-id: 029092fa88e0c4a0816574c6c18e5565b9650615
2021-10-28 06:18:12 -07:00
dependabot[bot]
66661ca4fa Bump socket.io from 4.1.3 to 4.3.1 in /desktop (#3003)
Summary:
Bumps [socket.io](https://github.com/socketio/socket.io) from 4.1.3 to 4.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases">socket.io's releases</a>.</em></p>
<blockquote>
<h2>4.3.1</h2>
<h3>Bug Fixes</h3>
<ul>
<li>fix server attachment (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4127">#4127</a>) (<a href="0ef2a4d02c">0ef2a4d</a>)</li>
</ul>
<h4>Links:</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/socket.io/compare/4.3.0...4.3.1">https://github.com/socketio/socket.io/compare/4.3.0...4.3.1</a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.3.1">4.3.1</a></li>
<li>engine.io version:  <code>~6.0.0</code></li>
<li>ws version: <code>~8.2.3</code></li>
</ul>
<h2>4.3.0</h2>
<p>For this release, most of the work was done on the client side, see <a href="https://github.com/socketio/socket.io-client/releases/tag/4.3.0">here</a>.</p>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> add name field to cookie option (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4099">#4099</a>) (<a href="033c5d399a">033c5d3</a>)</li>
<li>send volatile packets with binary attachments (<a href="dc81fcf461">dc81fcf</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li>serve ESM bundle (<a href="60edecb3bd">60edecb</a>)</li>
</ul>
<h4>Links:</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/socket.io/compare/4.2.0...4.3.0">https://github.com/socketio/socket.io/compare/4.2.0...4.3.0</a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.3.0">4.3.0</a></li>
<li>engine.io version:  <code>~6.0.0</code> (<a href="https://github.com/socketio/engine.io/compare/5.2.0...6.0.0">diff</a>)</li>
<li>ws version: <code>~8.2.3</code> (<a href="https://github.com/websockets/ws/compare/7.4.2...8.2.3">diff</a>)</li>
</ul>
<h2>4.2.0</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> allow async listener in typed events (<a href="ccfd8caba6">ccfd8ca</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li>ignore the query string when serving client JavaScript (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4024">#4024</a>) (<a href="24fee27ba3">24fee27</a>)</li>
</ul>
<h4>Links:</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/socket.io/compare/4.1.3...4.2.0">https://github.com/socketio/socket.io/compare/4.1.3...4.2.0</a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.2.0">4.2.0</a></li>
<li>engine.io version:  <code>~5.2.0</code></li>
<li>ws version: <code>~7.4.2</code></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/blob/master/CHANGELOG.md">socket.io's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/socketio/socket.io/compare/4.3.0...4.3.1">4.3.1</a> (2021-10-16)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>fix server attachment (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4127">#4127</a>) (<a href="0ef2a4d02c">0ef2a4d</a>)</li>
</ul>
<h1><a href="https://github.com/socketio/socket.io/compare/4.2.0...4.3.0">4.3.0</a> (2021-10-14)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> add name field to cookie option (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4099">#4099</a>) (<a href="033c5d399a">033c5d3</a>)</li>
<li>send volatile packets with binary attachments (<a href="dc81fcf461">dc81fcf</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li>serve ESM bundle (<a href="60edecb3bd">60edecb</a>)</li>
</ul>
<h1><a href="https://github.com/socketio/socket.io/compare/4.1.3...4.2.0">4.2.0</a> (2021-08-30)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> allow async listener in typed events (<a href="ccfd8caba6">ccfd8ca</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li>ignore the query string when serving client JavaScript (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4024">#4024</a>) (<a href="24fee27ba3">24fee27</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="ccc5ec39a8"><code>ccc5ec3</code></a> chore(release): 4.3.1</li>
<li><a href="0ef2a4d02c"><code>0ef2a4d</code></a> fix: fix server attachment (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4127">#4127</a>)</li>
<li><a href="95810aa62d"><code>95810aa</code></a> chore(release): 4.3.0</li>
<li><a href="60edecb3bd"><code>60edecb</code></a> feat: serve ESM bundle</li>
<li><a href="eb5fdbd03e"><code>eb5fdbd</code></a> chore: bump engine.io to version 6.0.0</li>
<li><a href="4974e9077c"><code>4974e90</code></a> docs: update .NET client library link (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4115">#4115</a>)</li>
<li><a href="033c5d399a"><code>033c5d3</code></a> fix(typings): add name field to cookie option (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4099">#4099</a>)</li>
<li><a href="7a74b66872"><code>7a74b66</code></a> test: remove hardcoded ports</li>
<li><a href="dc81fcf461"><code>dc81fcf</code></a> fix: send volatile packets with binary attachments</li>
<li><a href="c100b7b61c"><code>c100b7b</code></a> chore(release): 4.2.0</li>
<li>Additional commits viewable in <a href="https://github.com/socketio/socket.io/compare/4.1.3...4.3.1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=socket.io&package-manager=npm_and_yarn&previous-version=4.1.3&new-version=4.3.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3003

Reviewed By: passy

Differential Revision: D31991555

Pulled By: cekkaewnumchai

fbshipit-source-id: de5c8726d8ff0efd5bed7945697f58b8684f7048
2021-10-28 06:18:12 -07:00
dependabot[bot]
197614fd3e Bump @typescript-eslint/eslint-plugin from 4.31.0 to 4.33.0 in /desktop (#3000)
Summary:
Bumps [typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.31.0 to 4.33.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@​typescript-eslint/eslint-plugin</code>'s releases</a>.</em></p>
<blockquote>
<h2>v4.33.0</h2>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.32.0...v4.33.0">4.33.0</a> (2021-10-04)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [lines-between-class-members] fix <code>exceptAfterOverload</code> for abstract methods (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3943">#3943</a>) (<a href="240fc65c30">240fc65</a>)</li>
<li><strong>eslint-plugin:</strong> [no-confusing-void-expression] support optional chaining (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3937">#3937</a>) (<a href="c40dd13df7">c40dd13</a>)</li>
<li><strong>eslint-plugin:</strong> [no-restricted-imports] fix crash when no options given (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3947">#3947</a>) (<a href="edaa3c10eb">edaa3c1</a>)</li>
<li><strong>eslint-plugin:</strong> [non-nullable-type-assertion-style] false-positive with non-nullish <code>as</code> assertions and types (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3940">#3940</a>) (<a href="40760f98da">40760f9</a>)</li>
<li><strong>eslint-plugin:</strong> [padding-line-between-statements] TSModuleBlock should change scope (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3944">#3944</a>) (<a href="f8f534e42b">f8f534e</a>)</li>
<li><strong>eslint-plugin:</strong> [prefer-regexp-exec] check <code>RegExp</code> without flags (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3946">#3946</a>) (<a href="0868725713">0868725</a>)</li>
<li><strong>experimental-utils:</strong> add <code>getPhysicalFilename()</code> to <code>RuleContext</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3934">#3934</a>) (<a href="ee5dfd4989">ee5dfd4</a>)</li>
<li><strong>experimental-utils:</strong> require fix in suggestions (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3949">#3949</a>) (<a href="f022fb14c7">f022fb1</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li><strong>experimental-utils:</strong> extract <code>isNodeOfTypeWithConditions</code> out of <code>ast-utils</code>' <code>predicates</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3837">#3837</a>) (<a href="214f898178">214f898</a>)</li>
</ul>
<h2>v4.32.0</h2>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.31.2...v4.32.0">4.32.0</a> (2021-09-27)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [consistent-type-definitions] correct fix for <code>export default</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3899">#3899</a>) (<a href="ebb33ed8bc">ebb33ed</a>)</li>
<li><strong>eslint-plugin:</strong> [no-require-imports] report only global <code>require</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3871">#3871</a>) (<a href="8aa87a136e">8aa87a1</a>)</li>
<li><strong>eslint-plugin:</strong> [no-shadow] ignore type-only imports properly (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3868">#3868</a>) (<a href="dda9cee68a">dda9cee</a>)</li>
<li><strong>eslint-plugin:</strong> [no-var-requires] report problems within <code>NewExpression</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3884">#3884</a>) (<a href="ed5e45983f">ed5e459</a>)</li>
<li><strong>eslint-plugin:</strong> [padding-line-between-statements] problems within namespaces not being reported (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3869">#3869</a>) (<a href="186135698b">1861356</a>)</li>
<li><strong>eslint-plugin:</strong> [prefer-regexp-exec] respect flags when using <code>RegExp</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3855">#3855</a>) (<a href="ffdb5ff990">ffdb5ff</a>)</li>
<li><strong>eslint-plugin:</strong> [prefer-return-this-type] handle generics properly in fixer (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3852">#3852</a>) (<a href="9e98b8f43c">9e98b8f</a>)</li>
<li><strong>eslint-plugin:</strong> false-positive/negative with array index in no-unnecessary-condition (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3805">#3805</a>) (<a href="bdb8f0be14">bdb8f0b</a>)</li>
<li><strong>experimental-utils:</strong> add missing signature for <code>isParenthesized</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3887">#3887</a>) (<a href="806eaac6af">806eaac</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li><strong>eslint-plugin:</strong> [no-type-alias]: add allowGenerics option (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3865">#3865</a>) (<a href="4195919973">4195919</a>)</li>
<li><strong>eslint-plugin:</strong> add <code>no-non-null-asserted-nullish-coalescing</code> rule (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3349">#3349</a>) (<a href="4e999614e9">4e99961</a>)</li>
<li><strong>eslint-plugin:</strong> add new extended rule <code>no-restricted-imports</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3775">#3775</a>) (<a href="ec5d50696b">ec5d506</a>)</li>
<li><strong>eslint-plugin-internal:</strong> [prefer-ast-types-enum] add <code>DefinitionType</code> enum (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3916">#3916</a>) (<a href="13b7de508e">13b7de5</a>)</li>
<li>Support <code>'latest'</code> as <code>ecmaVersion</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3873">#3873</a>) (<a href="25a42c0bbe">25a42c0</a>)</li>
</ul>
<h2>v4.31.2</h2>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.31.1...v4.31.2">4.31.2</a> (2021-09-20)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@​typescript-eslint/typescript-eslint</code></p>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md"><code>@​typescript-eslint/eslint-plugin</code>'s changelog</a>.</em></p>
<blockquote>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.32.0...v4.33.0">4.33.0</a> (2021-10-04)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [lines-between-class-members] fix <code>exceptAfterOverload</code> for abstract methods (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3943">#3943</a>) (<a href="240fc65c30">240fc65</a>)</li>
<li><strong>eslint-plugin:</strong> [no-confusing-void-expression] support optional chaining (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3937">#3937</a>) (<a href="c40dd13df7">c40dd13</a>)</li>
<li><strong>eslint-plugin:</strong> [no-restricted-imports] fix crash when no options given (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3947">#3947</a>) (<a href="edaa3c10eb">edaa3c1</a>)</li>
<li><strong>eslint-plugin:</strong> [non-nullable-type-assertion-style] false-positive with non-nullish <code>as</code> assertions and types (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3940">#3940</a>) (<a href="40760f98da">40760f9</a>)</li>
<li><strong>eslint-plugin:</strong> [padding-line-between-statements] TSModuleBlock should change scope (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3944">#3944</a>) (<a href="f8f534e42b">f8f534e</a>)</li>
<li><strong>eslint-plugin:</strong> [prefer-regexp-exec] check <code>RegExp</code> without flags (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3946">#3946</a>) (<a href="0868725713">0868725</a>)</li>
</ul>
<h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.31.2...v4.32.0">4.32.0</a> (2021-09-27)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [consistent-type-definitions] correct fix for <code>export default</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3899">#3899</a>) (<a href="ebb33ed8bc">ebb33ed</a>)</li>
<li><strong>eslint-plugin:</strong> [no-require-imports] report only global <code>require</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3871">#3871</a>) (<a href="8aa87a136e">8aa87a1</a>)</li>
<li><strong>eslint-plugin:</strong> [no-shadow] ignore type-only imports properly (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3868">#3868</a>) (<a href="dda9cee68a">dda9cee</a>)</li>
<li><strong>eslint-plugin:</strong> [no-var-requires] report problems within <code>NewExpression</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3884">#3884</a>) (<a href="ed5e45983f">ed5e459</a>)</li>
<li><strong>eslint-plugin:</strong> [padding-line-between-statements] problems within namespaces not being reported (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3869">#3869</a>) (<a href="186135698b">1861356</a>)</li>
<li><strong>eslint-plugin:</strong> [prefer-regexp-exec] respect flags when using <code>RegExp</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3855">#3855</a>) (<a href="ffdb5ff990">ffdb5ff</a>)</li>
<li><strong>eslint-plugin:</strong> [prefer-return-this-type] handle generics properly in fixer (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3852">#3852</a>) (<a href="9e98b8f43c">9e98b8f</a>)</li>
<li><strong>eslint-plugin:</strong> false-positive/negative with array index in no-unnecessary-condition (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3805">#3805</a>) (<a href="bdb8f0be14">bdb8f0b</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li><strong>eslint-plugin:</strong> [no-type-alias]: add allowGenerics option (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3865">#3865</a>) (<a href="4195919973">4195919</a>)</li>
<li><strong>eslint-plugin:</strong> add <code>no-non-null-asserted-nullish-coalescing</code> rule (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3349">#3349</a>) (<a href="4e999614e9">4e99961</a>)</li>
<li><strong>eslint-plugin:</strong> add new extended rule <code>no-restricted-imports</code> (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3775">#3775</a>) (<a href="ec5d50696b">ec5d506</a>)</li>
<li><strong>eslint-plugin-internal:</strong> [prefer-ast-types-enum] add <code>DefinitionType</code> enum (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3916">#3916</a>) (<a href="13b7de508e">13b7de5</a>)</li>
</ul>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.31.1...v4.31.2">4.31.2</a> (2021-09-20)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@​typescript-eslint/eslint-plugin</code></p>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="7bf8c9cb02"><code>7bf8c9c</code></a> chore: publish v4.33.0</li>
<li><a href="edaa3c10eb"><code>edaa3c1</code></a> fix(eslint-plugin): [no-restricted-imports] fix crash when no options given (...</li>
<li><a href="0868725713"><code>0868725</code></a> fix(eslint-plugin): [prefer-regexp-exec] check <code>RegExp</code> without flags (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/3946">#3946</a>)</li>
<li><a href="f8f534e42b"><code>f8f534e</code></a> fix(eslint-plugin): [padding-line-between-statements] TSModuleBlock should ch...</li>
<li><a href="240fc65c30"><code>240fc65</code></a> fix(eslint-plugin): [lines-between-class-members] fix <code>exceptAfterOverload</code> f...</li>
<li><a href="40760f98da"><code>40760f9</code></a> fix(eslint-plugin): [non-nullable-type-assertion-style] false-positive with n...</li>
<li><a href="c40dd13df7"><code>c40dd13</code></a> fix(eslint-plugin): [no-confusing-void-expression] support optional chaining ...</li>
<li><a href="35a8acfc52"><code>35a8acf</code></a> refactor(eslint-plugin): [no-shadow] use <code>findVariable</code> from utils (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/3921">#3921</a>)</li>
<li><a href="3c773e475b"><code>3c773e4</code></a> docs(eslint-plugin): [no-unsafe-argument] fix grammar (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/3889">#3889</a>)</li>
<li><a href="02c6ff3c5a"><code>02c6ff3</code></a> chore: publish v4.32.0</li>
<li>Additional commits viewable in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v4.33.0/packages/eslint-plugin">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@typescript-eslint/eslint-plugin&package-manager=npm_and_yarn&previous-version=4.31.0&new-version=4.33.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3000

Reviewed By: passy

Differential Revision: D31991585

Pulled By: cekkaewnumchai

fbshipit-source-id: 15ea4adeb250934dcc142915b1f4196e6e776abd
2021-10-28 06:18:12 -07:00
dependabot[bot]
cd2804c553 Bump eslint-plugin-promise from 5.1.0 to 5.1.1 in /desktop (#3001)
Summary:
Bumps [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise) from 5.1.0 to 5.1.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/xjamundx/eslint-plugin-promise/commits">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=eslint-plugin-promise&package-manager=npm_and_yarn&previous-version=5.1.0&new-version=5.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3001

Reviewed By: passy

Differential Revision: D31991583

Pulled By: cekkaewnumchai

fbshipit-source-id: af1be4f0e2d70885d2d6622363a7433a786c7778
2021-10-28 06:18:12 -07:00
dependabot[bot]
7094475431 Bump split2 from 3.2.2 to 4.1.0 in /desktop (#3002)
Summary:
Bumps [split2](https://github.com/mcollina/split2) from 3.2.2 to 4.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/mcollina/split2/releases">split2's releases</a>.</em></p>
<blockquote>
<h2>v4.1.0</h2>
<h2>What’s Changed</h2>
<ul>
<li>Add engines field. Add node 10.x to CI (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/52">https://github.com/facebook/flipper/issues/52</a>) <a href="https://github.com/mcollina"><code>@​mcollina</code></a></li>
</ul>
<h2>v4.0.0</h2>
<h2>What’s Changed</h2>
<ul>
<li>Update to node 12 (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/50">https://github.com/facebook/flipper/issues/50</a>) <a href="https://github.com/mcollina"><code>@​mcollina</code></a></li>
<li>Upgrade to GitHub-native Dependabot (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/48">https://github.com/facebook/flipper/issues/48</a>) <a href="https://github.com/dependabot-preview"><code>@​dependabot-preview</code></a></li>
<li>Bump standard from 15.0.1 to 16.0.1 (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/43">https://github.com/facebook/flipper/issues/43</a>) <a href="https://github.com/dependabot-preview"><code>@​dependabot-preview</code></a></li>
<li>Bump standard from 14.3.4 to 15.0.0 (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/41">https://github.com/facebook/flipper/issues/41</a>) <a href="https://github.com/dependabot-preview"><code>@​dependabot-preview</code></a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="06818424cb"><code>0681842</code></a> Bumped v4.1.0</li>
<li><a href="beff8a031c"><code>beff8a0</code></a> Add engines field. Add node 10.x to CI (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/52">https://github.com/facebook/flipper/issues/52</a>)</li>
<li><a href="b66af507ca"><code>b66af50</code></a> Bumped v4.0.0</li>
<li><a href="f662904a41"><code>f662904</code></a> Update to node 12 (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/50">https://github.com/facebook/flipper/issues/50</a>)</li>
<li><a href="4a776ffa20"><code>4a776ff</code></a> Upgrade to GitHub-native Dependabot (<a href="https://github-redirect.dependabot.com/mcollina/split2/issues/48">https://github.com/facebook/flipper/issues/48</a>)</li>
<li><a href="c3124e3d9b"><code>c3124e3</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/mcollina/split2/issues/43">https://github.com/facebook/flipper/issues/43</a> from mcollina/dependabot/npm_and_yarn/standard-16.0.1</li>
<li><a href="efe0ddd808"><code>efe0ddd</code></a> Bump standard from 15.0.1 to 16.0.1</li>
<li><a href="bc6e5fc7fb"><code>bc6e5fc</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/mcollina/split2/issues/41">https://github.com/facebook/flipper/issues/41</a> from mcollina/dependabot/npm_and_yarn/standard-15.0.0</li>
<li><a href="03c7cecc3c"><code>03c7cec</code></a> Bump standard from 14.3.4 to 15.0.0</li>
<li>See full diff in <a href="https://github.com/mcollina/split2/compare/v3.2.2...v4.1.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=split2&package-manager=npm_and_yarn&previous-version=3.2.2&new-version=4.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3002

Reviewed By: passy

Differential Revision: D31991563

Pulled By: cekkaewnumchai

fbshipit-source-id: 3a133ca1d60a0ec471147ac7af4c9772060c6e35
2021-10-28 06:18:11 -07:00
dependabot[bot]
3297c4f44b Bump algoliasearch from 4.10.5 to 4.11.0 in /desktop (#2998)
Summary:
Bumps [algoliasearch](https://github.com/algolia/algoliasearch-client-javascript) from 4.10.5 to 4.11.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/releases">algoliasearch's releases</a>.</em></p>
<blockquote>
<h2>4.11.0</h2>
<h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.10.5...4.11.0">v4.11.0</a></h2>
<ul>
<li>fix(insideBoundingBox): allow strings (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1310">https://github.com/facebook/flipper/issues/1310</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/87d5b0d">87d5b0d</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1310">https://github.com/facebook/flipper/issues/1310</a></li>
<li>feat: add custom request function (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1312">https://github.com/facebook/flipper/issues/1312</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/3cea192">3cea192</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1312">https://github.com/facebook/flipper/issues/1312</a></li>
<li>feat(ts): document enableReRanking (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1306">https://github.com/facebook/flipper/issues/1306</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/00ad924">00ad924</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1306">https://github.com/facebook/flipper/issues/1306</a></li>
<li>docs(recommend): add TSDoc (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1305">https://github.com/facebook/flipper/issues/1305</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/a5df2fb">a5df2fb</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1305">https://github.com/facebook/flipper/issues/1305</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/blob/master/CHANGELOG.md">algoliasearch's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.10.5...4.11.0">v4.11.0</a></h2>
<ul>
<li>fix(insideBoundingBox): allow strings (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1310">https://github.com/facebook/flipper/issues/1310</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/87d5b0d">87d5b0d</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1310">https://github.com/facebook/flipper/issues/1310</a></li>
<li>feat: add custom request function (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1312">https://github.com/facebook/flipper/issues/1312</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/3cea192">3cea192</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1312">https://github.com/facebook/flipper/issues/1312</a></li>
<li>feat(ts): document enableReRanking (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1306">https://github.com/facebook/flipper/issues/1306</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/00ad924">00ad924</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1306">https://github.com/facebook/flipper/issues/1306</a></li>
<li>docs(recommend): add TSDoc (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1305">https://github.com/facebook/flipper/issues/1305</a>) (<a href="https://github.com/algolia/algoliasearch-client-javascript/commit/a5df2fb">a5df2fb</a>), closes <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1305">https://github.com/facebook/flipper/issues/1305</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="9392aa43ab"><code>9392aa4</code></a> chore: release v4.11.0 (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1313">https://github.com/facebook/flipper/issues/1313</a>)</li>
<li><a href="dfe3eac629"><code>dfe3eac</code></a> ci(circle): use nvm for node unit tests (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1314">https://github.com/facebook/flipper/issues/1314</a>)</li>
<li><a href="8011c0ecb7"><code>8011c0e</code></a> chore(ci): remove unused travis config</li>
<li><a href="87d5b0d842"><code>87d5b0d</code></a> fix(insideBoundingBox): allow strings (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1310">https://github.com/facebook/flipper/issues/1310</a>)</li>
<li><a href="3cea192c5c"><code>3cea192</code></a> feat: add custom request function (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1312">https://github.com/facebook/flipper/issues/1312</a>)</li>
<li><a href="7c38e642b2"><code>7c38e64</code></a> chore: dockerize development environment (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1308">https://github.com/facebook/flipper/issues/1308</a>)</li>
<li><a href="6223bf63f5"><code>6223bf6</code></a> fix(ci): update docker image (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1309">https://github.com/facebook/flipper/issues/1309</a>)</li>
<li><a href="00ad9246a9"><code>00ad924</code></a> feat(ts): document enableReRanking (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1306">https://github.com/facebook/flipper/issues/1306</a>)</li>
<li><a href="a5df2fb905"><code>a5df2fb</code></a> docs(recommend): add TSDoc (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/issues/1305">https://github.com/facebook/flipper/issues/1305</a>)</li>
<li>See full diff in <a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.10.5...4.11.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=algoliasearch&package-manager=npm_and_yarn&previous-version=4.10.5&new-version=4.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2998

Reviewed By: mweststrate

Differential Revision: D31991634

Pulled By: cekkaewnumchai

fbshipit-source-id: 3e6f04390b542f2e51d42446f8758e2ed591bb9b
2021-10-28 06:18:11 -07:00
Pascal Hartig
2525a5efd4 Fix Flipper lints #9
Summary:
This introduces a few more lints in fact because I renamed the icon functions
to make clear that they use sync methods under the hood.

Reviewed By: timur-valiev

Differential Revision: D31964701

fbshipit-source-id: d0beb58b5b301f5428fdbfe8c65784df0d86eaad
2021-10-28 05:47:40 -07:00
Pascal Hartig
f8117240af Fix async filtering (#3008)
Summary:
I relied too much on the types which in this case don't help at all.
Filtering on a promise will just automatically get all values to pass.

Pull Request resolved: https://github.com/facebook/flipper/pull/3008

Test Plan: `yarn build --mac` works again on the GH checkout.

Reviewed By: mweststrate

Differential Revision: D31991576

Pulled By: passy

fbshipit-source-id: f632d29ddfc09b7130b68b4b17264fd30e1969ce
2021-10-28 05:36:52 -07:00
Pascal Hartig
366c8f2681 Fix Flipper lints #9 1/n
Summary: Mostly ignoring things in this one because it's tests.

Reviewed By: timur-valiev

Differential Revision: D31955716

fbshipit-source-id: f799bf2b3eaae6753f41121264c777fdeda03165
2021-10-27 11:10:52 -07:00
Pascal Hartig
1b5cd3d2d5 Fix Flipper lints #12
Reviewed By: timur-valiev

Differential Revision: D31932981

fbshipit-source-id: 4cf905495494466462c0494116f56cd16773e549
2021-10-27 11:10:52 -07:00
Flipper Bot
898cadad2d Flipper Snapshot Bump: v0.117.1-SNAPSHOT
Summary: Releasing snapshot version 0.117.1-SNAPSHOT

Reviewed By: aigoncharov

Differential Revision: D31955242

fbshipit-source-id: 777bebd4e0634a54ba8206cdb7962b0412702134
2021-10-27 09:44:32 -07:00
Flipper Bot
360ecb4b24 Flipper Release: v0.117.0
Summary: Releasing version 0.117.0

Reviewed By: aigoncharov

Differential Revision: D31955241

fbshipit-source-id: 0a4c848c96bc63ebd1f4d642965693a1e3502f6c
2021-10-27 09:44:32 -07:00
Pascal Hartig
dbbda21b55 Upgrade docusaurus
Summary: Was gonna write some docs so wanted to use the opportunity to get docusaurus up-to-date.

Reviewed By: jknoxville

Differential Revision: D31956185

fbshipit-source-id: be7304ac2def5bb5576e076c1c13f79cb2b4bab3
2021-10-27 04:29:04 -07:00
Pascal Hartig
0f9698312a Fix capitalization of method reference
Summary: Docs only.

Reviewed By: jknoxville

Differential Revision: D31928323

fbshipit-source-id: 14be8bf89215054e6561fc38f73040ccfae229c4
2021-10-27 02:48:07 -07:00
Michel Weststrate
9763af4c96 Decouple open/save dialogs, reload, shouldUseDarkColors from Electron
Summary: Per title. Less imports from Electron.

Reviewed By: timur-valiev, aigoncharov

Differential Revision: D31923504

fbshipit-source-id: dc7557cf7c88c0c8168ba22f7dca7b3e2d339a09
2021-10-26 12:07:22 -07:00
Chaiwat Ekkaewnumchai
d5e4b0c360 Clear Activity after Being Destroyed
Summary:
[Reported in the support request](https://fb.workplace.com/groups/flippersupport/posts/1237466586733997/), Activity object is held by ObjectTracker even though the Activity is destroyed. This, in this case, caused strict mode in Portal app to forcibly terminate.

This diff tried to remove activities from the reference holder.

Reviewed By: passy

Differential Revision: D31828290

fbshipit-source-id: aad7e8d7ba14069f8dd7c654a3604d482d85e110
2021-10-26 03:39:41 -07:00
Daniel Parreira
9ef4303a1a Add platform wizard when opening Flipper for first time
Summary: T103651722 - Added a first time wizard to pick the user platforms when the user opens it for the first time. The fact that the wizard was shown is stored in localstorage.

Reviewed By: mweststrate

Differential Revision: D31861286

fbshipit-source-id: a46c532520cd88a0c4c608d3ee314289f0407475
2021-10-25 15:05:04 -07:00
Daniel Kohli
fa7e8a6b37 Add max-width Style Prop to Tabs.tsx
Summary:
- We're using the `Tabs` component from `flipper-plugin` and upon adding them, we noticed that our view being displayed within the tabs no longer scrolled and the tab internally was being stretched far off the screen. (D31538124)
- After egp did some digging, he discovered that by adding the `maxWidth` style property to the inner `Layout.Container`, the tab no longer stretched and the scrolling was restored.
- We played around by adding wrapper elements around the contents of our Tab and adding the same style prop, but this did not yield the same result.

***Would Love some input from the Flipper team as to the best way to ensure that this won't break other's plugins.  Thank you!***

Reviewed By: mweststrate

Differential Revision: D31672790

fbshipit-source-id: 99cab1873f359f4c1827e4c94f2527636884c237
2021-10-25 14:13:35 -07:00
Juan Tejada
2423423183 Update React DevTools v4.20.2
Summary:
Update `react-devtools-core` and `react-devtools` dependencies for RN, VSCode, Flipper, etc.

`js1 upgrade react-devtools -v 4.20.2`

# Changelog:

[General][Changed] - Upgraded react-devtools-core dependency to 4.20.2

Reviewed By: lunaruan

Differential Revision: D31809278

fbshipit-source-id: 0360fe173cfc7ce09595e6db4e8e41c6f64becd7
2021-10-25 14:00:42 -07:00
Artem Kholodnyi
72b652fb87 Fix the observer effect in Images Flipper plugin (encoded cache)
Reviewed By: oprisnik

Differential Revision: D31897870

fbshipit-source-id: bdd70d1679029931339ee589c98114f51646cb68
2021-10-25 10:11:48 -07:00
Lorenzo Blasa
ef8557b5a1 Improve error message for unresponsive clients
Summary:
This change adds 'adb' to the error message checks. If the device is Android, is confusing to suggest the problem may be with 'idb'.

This could be further improved by looking at the client OS and device type to suggest formulate the correct message.

Reviewed By: passy

Differential Revision: D31894695

fbshipit-source-id: 8eb2ca152807afd9706af1523c917803611246d7
2021-10-25 06:50:49 -07:00
Michel Weststrate
945f133593 Remove some Electron imports
Summary: Remove some Electron imports that weren't needed

Reviewed By: passy

Differential Revision: D31893756

fbshipit-source-id: 92edeb2e00a7c37e32365bb059d00d7c730a7a92
2021-10-25 06:12:20 -07:00