Summary: nil objects from sqlite is NSNull object, so we need to consider this case in the ObjectMapper as well.
Differential Revision: D48394360
fbshipit-source-id: 61bcdb03cb4cbf17a2fef000a5a61ac2f2c035dd
Summary: Some objects returned from sqlite in json blob is a NSDictionary, we need to parse data at this case.
Differential Revision: D48394361
fbshipit-source-id: c977ebdd33c392fca77741cdacdeb0c975e2ca36
Summary:
There's no explicit way of knowing if the file selection dialog was dismissed/canceled without a selection.
Instead, subscribe once to the windows focus event, as it will the event will be received when this happens.
Reviewed By: antonk52
Differential Revision: D48434187
fbshipit-source-id: dd20c55885bb3ef6bef423e17a2606d71ede288d
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/5048
Reviewed By: ivanmisuno
Differential Revision: D48397521
Pulled By: passy
fbshipit-source-id: 2333aa312f982b2ceff1dd2a2f8dfe9d0e63c893
Summary:
Refactor all usages of import NetworkingModule.setCustomClientBuilder to use CustomClientBuilder instead of NetworkModule.CustomClientBuilder
changelog: [internal] internal
Reviewed By: cortinico
Differential Revision: D48280921
fbshipit-source-id: ffa979defb34ecaac9d327eaafee33598ea22b5d
Summary: These two functions were not enabled for the browser experience.
Reviewed By: antonk52
Differential Revision: D48315991
fbshipit-source-id: 2944a386d9de8a06b043305e7ceb8a6c41e11209
Summary: Implementation was missing for the browser. This provides a default implementation.
Reviewed By: aigoncharov
Differential Revision: D48311198
fbshipit-source-id: fd067600f571234e0fbccfb90853b62f175ff8fb
Summary:
This diff is fixing a NoSuchMethodError when calling FbReactApplicationBaseSonarUtil.startSonarClient.
This is causing catalyst Android app to not start.
This was caused by D47468613, which changed the signature of the method
Reviewed By: cortinico
Differential Revision: D48275730
fbshipit-source-id: 4693c299dbd3b6a9ad58a1439bddd9e4bfb8bdf5
Summary:
This should hopefully unblock our Android builds for real this time. I didn't realise that the AGP itself seems to ship with a version of Dokka, so just removing the import didn't actually address the problem we were seeing.
Pull Request resolved: https://github.com/facebook/flipper/pull/5005
Test Plan:
```
./gradlew publishToMavenLocal -PRELEASE_SIGNING_ENABLED=false
```
This now succeeds.
Reviewed By: jknoxville
Differential Revision: D48312784
Pulled By: passy
fbshipit-source-id: f049e089a511726857f544386fe13dcb50fb2971
Summary: Not really a connectivity related log, so removed [conn] from it.
Reviewed By: passy
Differential Revision: D48266546
fbshipit-source-id: e384301d6301940366b594b4bc612349cc2264ce
Summary: Combine the two used commands as will make things easier for our users.
Reviewed By: passy
Differential Revision: D48266474
fbshipit-source-id: 1ee5c568ff001dc5ba3f11e21b09a2a6ab430ac7
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/5000
Reviewed By: lblasa
Differential Revision: D48268231
Pulled By: passy
fbshipit-source-id: 9f28d68aeeca2c921a9298cbfad7c13e261b6900
Summary:
Match isProduction definition in flipper-common and flipper-server/src/index.tsx.
Without it, PWA never quits after all clients disconnect because Flipper Launcher does not set NODE_ENV to production currently (changed in the next diff)
Reviewed By: LukeDefeo, lblasa
Differential Revision: D48265768
fbshipit-source-id: 59e4660cb57da20b606562144c47c65276999d6c
Summary: This change removes the UDS support and thus the need for having a proxy server.
Reviewed By: antonk52
Differential Revision: D48265244
fbshipit-source-id: c76bb4afba63959ddd17901b3887aa278b000beb
Summary: As TCP is the only option, remove all branches.
Reviewed By: passy
Differential Revision: D48265093
fbshipit-source-id: 174527f05d8a841797fd95256e77fdeb9b2e6ad5
Summary: UDS will be removed. The first step would be to remove the TCP optionality.
Reviewed By: passy
Differential Revision: D48264741
fbshipit-source-id: ca9e1b68be61e99240e95bcd4f26f2db63a64005
Summary: Instead of delaying the shutdown by a set timer, immediately shutdown.
Reviewed By: antonk52
Differential Revision: D48264571
fbshipit-source-id: 5e6556f2ecafb7cf9a19b3075e72f2be1abf9f95
Summary:
If listing devices is successful, then don't record the event
as this is triggered every X amount of seconds.
Reviewed By: antonk52
Differential Revision: D47995681
fbshipit-source-id: 2d0fa68fd7b9c4ce74bad9e8cc0296691d9b8880
Summary: Infra that will be used to capture litho framework events
Reviewed By: lblasa
Differential Revision: D47951601
fbshipit-source-id: 1dd756dc872d474f2872ff8cac1fd6aa3697e42b
Summary: The `DataDescriptionType` accepts the `BigInt` type but it doesn't render. Added the `case` for that and reuse the `NumberValue` tag for it.
Reviewed By: aigoncharov
Differential Revision: D48152012
fbshipit-source-id: 32ebc8a37df34d57b40c7ecdad331c547415b335
Summary:
[gradle] Remove dokka plugin
This is currently breaking our jetpack-compose build and blocks the entire release
as a consequence: https://github.com/facebook/flipper/issues/4970
There are all sorts of workarounds but they require changing the java target
which could have other downstream consequences: https://github.com/Kotlin/dokka/issues/2956
We don't actually rely on these artefacts at all, so it's probably safe to just disable this.
Closes https://github.com/facebook/flipper/issues/4970
Pull Request resolved: https://github.com/facebook/flipper/pull/4995
Test Plan: ./gradlew publishToMavenLocal
Reviewed By: antonk52
Differential Revision: D48062872
Pulled By: passy
fbshipit-source-id: aef0696d5ac83dd50bcbb96b0552f9b222f5a566
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4994
Reviewed By: mweststrate
Differential Revision: D48112730
Pulled By: passy
fbshipit-source-id: 1429d64dc5c200a8af3eb162702cf81e1c9af72a
Summary: Also removing topLevelSelection as it is no longer used in flipper
Reviewed By: aigoncharov
Differential Revision: D48069386
fbshipit-source-id: 6e4cdd6aab67d2cd30ac1884118703520125bf84
Summary: This is a continuation of flipper redesign. Next diff will mov notification and connectivity into modals as well
Reviewed By: LukeDefeo
Differential Revision: D48066573
fbshipit-source-id: 3b4a22462221d8da13b07ad1738e05de849e00c4
Summary: Feedback from support group said it wasnt clear when recording was on
Reviewed By: antonk52
Differential Revision: D48027414
fbshipit-source-id: db61a9806da285610e8f550ceff5af4d7b7acb47
Summary: Add an option to kill the debugging bridge directly within Flipper.
Reviewed By: antonk52
Differential Revision: D47990786
fbshipit-source-id: 30cd8ca1d55e8b2ade03700d884e5d849a2dadbf
Summary: Commands can be idb or adb. If no ClientQuery is provided, set the OS accordingly.
Reviewed By: antonk52
Differential Revision: D47990745
fbshipit-source-id: 3e38b6ecb0a8ea21e584c1d6eff6feb53dd2cfab
