Commit Graph

2921 Commits

Author SHA1 Message Date
Chaiwat Ekkaewnumchai
76bf2f3603 (Server) Add Removing Route Button
Summary:
- Add a close button when hovering over the component
- Remove the route corresponding to it when clicking on closing

Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488

Reviewed By: mweststrate

Differential Revision: D20444419

fbshipit-source-id: 5ebe112c542b033a3e10ed10f23d6a04a730c657
2020-03-17 10:09:14 -07:00
Chaiwat Ekkaewnumchai
1d23b5418a (Server) Include Mock Component to Main Files
Summary:
- Add mock button if a client supports the function
- Open the dialog when clicking the button

Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488

Reviewed By: mweststrate

Differential Revision: D20440145

fbshipit-source-id: 750099020e0b2d6ed10bb20e883f6b3be664ae79
2020-03-17 10:09:13 -07:00
Chaiwat Ekkaewnumchai
84f36cd0ce (Server) Add MockResponseDialog
Summary:
per title

Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488

Reviewed By: mweststrate

Differential Revision: D20440146

fbshipit-source-id: 0a3ade1e78e62d3bc0d98ef9fb6c3f258b34af23
2020-03-17 10:09:13 -07:00
Chaiwat Ekkaewnumchai
adb1d6e976 (Server) Add ManageMockResponsePanel
Summary:
- Add ManageMockResponsePanel to add, modify and remove mocked route

Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488

Reviewed By: mweststrate

Differential Revision: D20440147

fbshipit-source-id: 3af127c4b091f288c13b41b74d78c07b4eb0e52f
2020-03-17 10:09:13 -07:00
Chaiwat Ekkaewnumchai
95376a17b9 (Server) Add MockResponseDetail and Package Used Inside
Summary:
- Add MockResponseDetail component to show and edit mocked route
- Add `immer` package which will be used for internal state handler

Change from PR
- Change to functional component

Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488

Reviewed By: mweststrate

Differential Revision: D20440149

fbshipit-source-id: d7c35600b9a22cb62c2bdae7e19abe5c767e3670
2020-03-17 10:09:12 -07:00
Chaiwat Ekkaewnumchai
59c821db8d (Server) Add Context to Manipulate Route State
Summary:
This diff added dummy state handler for route, which appeared in the next diffs. Routes will be used to render components for mocking handler and determine data on the client side.

State and other variables will appear on the next diffs.

Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488

Reviewed By: mweststrate

Differential Revision: D20440150

fbshipit-source-id: d441ae1d53caf7280bef78d937aaa71617e2da9f
2020-03-17 10:09:12 -07:00
Chaiwat Ekkaewnumchai
f3eb695fa6 (Server) Add a New Type to Capture Mocking
Summary:
per title

Note:
- This is a part of this PR: https://github.com/facebook/flipper/pull/488

Reviewed By: mweststrate

Differential Revision: D20440148

fbshipit-source-id: 9365f0b83449f295e819cccc2fa622d866dca129
2020-03-17 10:09:11 -07:00
generatedunixname89002005306973
afa8d6274a Flipper Release: v0.34.0
Summary: Releasing version 0.34.0

Reviewed By: nikoant

Differential Revision: D20480419

fbshipit-source-id: e83a532690c6df8e781683b3dcc2418b8744c961
2020-03-17 05:31:04 -07:00
Michel Weststrate
f919a0d1a3 fixed issue where install script errors were not properly propagated
Summary:
Our post install scripts didn't propagate installation errors in CI (or locally), leading to problems only appearing later in time, causing a lot of lost time {emoji:1f605}

Also moved printing what package is installing to _before_ running the script, so that you have actual useful info in case it fails.

Compilation errors of pkg and doctor were printed in our CI, but never threw exceptions.

Fixed the cause of those compilation errors as well using `skipLibCheck` like done in the root tsconfig

Reviewed By: jknoxville

Differential Revision: D20470985

fbshipit-source-id: 1b13d4d2c096f253cc9c1f0aac06982fc4aedf55
2020-03-16 16:52:31 -07:00
Michel Weststrate
f83a088f0d Dependency bumps [3/n]
Summary:
allow-large-files

Bumped dependencies using yarn upgrade-interactive. Closes a lot of GH issues / PR's

Reviewed By: passy

Differential Revision: D20446667

fbshipit-source-id: 59acc77dde36600e0479f1e180b8b5ee7b01d801
2020-03-16 11:22:45 -07:00
Michel Weststrate
353c0657d0 Bump several dependencies
Summary:
Bumped several dependencies. For operational efficiency doing this in one diff.

Lands GH diffs #747, #826, #839, #875, #876

Reviewed By: passy

Differential Revision: D20419326

fbshipit-source-id: 2378d66362d754e0345f129097b22c52b44b7879
2020-03-16 11:22:44 -07:00
Pascal Hartig
28e735a4c5 Fix prettier error (#893)
Summary:
^
Pull Request resolved: https://github.com/facebook/flipper/pull/893

Test Plan: eyes

Reviewed By: nikoant

Differential Revision: D20469555

Pulled By: passy

fbshipit-source-id: 70e3ebbc8a65de5f2fc407b9435d5b249f158f00
2020-03-16 11:00:57 -07:00
Pritesh Nandgaonkar
4784c45778 Make view scrollable if error message is long
Summary:
Bug:

{F231521873}

Reviewed By: mweststrate

Differential Revision: D20460428

fbshipit-source-id: 1ea7cbef2bd7c173defd0b056641abc87e66f93c
2020-03-16 05:23:16 -07:00
Pritesh Nandgaonkar
f889dc5e40 Refactor Plugin Selection sheet and add snapshot test
Summary:
This diff fixes a UI bug in export data sheet where the plugin names are stuck to the left and also the bottom buttons are stuck together with no padding. I have also added snapshot test for the same. In order to write test and reduce the complexity I changed the `ExportDataPluginSheet`'s connect method.

Bug:

{F231521086}

Reviewed By: mweststrate

Differential Revision: D20459692

fbshipit-source-id: 1047d6b38738691d682ad6e4ccec45c05e14cbbe
2020-03-16 05:23:16 -07:00
Pritesh Nandgaonkar
18915ba43c Fix the bug where flipper tried to fetch meta data from archived device after importing from same device
Summary:
This diff fixes an issue where when one imports an archived device and tries to export again through the same device with which the initial import was made then the export functionality tries to also fetch metadata from the archived device, it waits for the metadata till it timeouts.

Also this diff fixes an issue where if the selected plugin is not present in the `selectedClient` then it will also ignore that plugin from the other clients even if it was supported by those clients.

Unit test cases for all the above cases are added.

Bug:

{F231519408}

Reviewed By: mweststrate

Differential Revision: D20459179

fbshipit-source-id: 4f0d8c40bec875e3cc43cd6aa70061c8b8da7b05
2020-03-16 05:23:15 -07:00
Pritesh Nandgaonkar
d75be90522 Fix the graph API failures
Summary:
Currenty in the prod version of Flipper the endpoints of media upload and flipper trace fail with status code 400. Reason being different origin and refferer as compared to the dev version. This diff matches the origin and the refferer with the dev one.

I referenced Anton's diff D20278701.

Reviewed By: nikoant

Differential Revision: D20454562

fbshipit-source-id: 20f80a731878fb491d08a208d64fc9260e442fa3
2020-03-16 05:23:15 -07:00
Pritesh Nandgaonkar
148f90de7f Catch DataExportError from shareFlipperData
Summary:
There was a bug where if the `shareFlipperData` returned an `error` with a status code of less than 400 then it will be ignored. If the status code was of greater than or equal to 400 then `shareFlipperData` throws an error and it is caught and logged appropriately.

This diff fixes the above issue where if the return type from shareFlipperData is of type DataExportError then it is checked and not ignored. Also this fixes an issue where if DataExportError happens the loader is replaced with an error message.

Basically the bug mentioned here, T55169042. Also this diff logs the metadata of result, so that we can debug the exact error through scuba.

Reviewed By: mweststrate

Differential Revision: D20450159

fbshipit-source-id: 95b1f384886c16fe444ae0cd6f6d9b2251c29005
2020-03-16 05:23:15 -07:00
Anton Nikolaev
952cb7783a Allow direct references of doctor and pkg from the main bundle
Summary: This diff allows direct referencing pkg and doctor packages from the main bundle so they can be changed and used in the main app without publishing to npm

Reviewed By: mweststrate

Differential Revision: D20390416

fbshipit-source-id: af625a8b7cead4481743a88aec198493d363ce76
2020-03-14 15:59:22 -07:00
Anton Nikolaev
10d990c32c Move plugins to "sonar/desktop/plugins"
Summary:
Plugins moved from "sonar/desktop/src/plugins" to "sonar/desktop/plugins".

Fixed all the paths after moving.

New "desktop" folder structure:
- `src` - Flipper desktop app JS code executing in Electron Renderer (Chrome) process.
- `static` - Flipper desktop app JS code executing in Electron Main (Node.js) process.
- `plugins` - Flipper desktop JS plugins.
- `pkg` - Flipper packaging lib and CLI tool.
- `doctor` - Flipper diagnostics lib and CLI tool.
- `scripts` - Build scripts for Flipper desktop app.
- `headless` - Headless version of Flipper desktop app.
- `headless-tests` - Integration tests running agains Flipper headless version.

Reviewed By: mweststrate

Differential Revision: D20344186

fbshipit-source-id: d020da970b2ea1e001f9061a8782bfeb54e31ba0
2020-03-14 14:35:18 -07:00
Anton Nikolaev
beb5c85e69 Enable eslint import checks and fixed the reported errors (#878)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/878

1) Enabled eslint error reporting for unresolved imports and fixed all the errors
2) Enabled eslint for typings (d.ts) and fixed all the errors

Reviewed By: passy

Differential Revision: D20335151

fbshipit-source-id: 7b142281a406b32df0f02a5cd0d7d05eba941acd
2020-03-14 14:35:18 -07:00
Anton Nikolaev
85c13bb1f3 Move desktop-related code to "desktop" subfolder (#872)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/872
Move all the JS code related to desktop app to "desktop" subfolder.

The structure of "desktop" folder:
- `src` - JS code of Flipper desktop app executing in Electron Renderer (Chrome) process. This folder also contains all the Flipper plugins in subfolder "src/plugins".
- `static` - JS code of Flipper desktop app bootstrapping executing in Electron Main (Node.js) process
- `pkg` - Flipper packaging lib and CLI tool
- `doctor` - Flipper diagnostics lib and CLI tool
- `scripts` - Build scripts for Flipper desktop app
- `headless` - Headless version of Flipper app
- `headless-tests` - Integration tests running agains Flipper headless version

Reviewed By: passy

Differential Revision: D20249304

fbshipit-source-id: 9a51c63b51b92b758a02fc8ebf7d3d116770efe9
2020-03-14 14:35:17 -07:00