Summary: There is no support of navigation plugin outside of Meta and it is not planned, so it's better to state directly in open-source docs instead of saying "Coming soon".
Reviewed By: lblasa
Differential Revision: D42370752
fbshipit-source-id: 23d6400ab7374877a0b13ae3b9c79fcb584763db
Summary:
This code path is when a send results in an error being returned from the client. We reject the promise but also raise an error on the message bus.
There is a handler for this 'error' event that is raised that is over zelous and reports a crash to the crash reporter. This should not happen
Reviewed By: lblasa
Differential Revision: D42385292
fbshipit-source-id: f668a396b0d266ee9d1c7c1ca740e7bb5ae9608a
Summary: As part of BE, this diff creates the initial Flipper plugin for VR Call Hub using `scarf flipper-plugin` from the tutorial https://www.internalfb.com/intern/staticdocs/flipper/docs/tutorial/intro/
Differential Revision: D42146201
fbshipit-source-id: 8bc52184b21b2e47304f694068d11fd962b07b9d
Summary:
Bumps [tslib](https://github.com/Microsoft/tslib) from 2.3.1 to 2.4.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/Microsoft/tslib/releases">tslib's releases</a>.</em></p>
<blockquote>
<h2>tslib 2.4.1</h2>
<p>This release contains <a href="https://github-redirect.dependabot.com/microsoft/tslib/pull/186">fixes for early <code>return</code>s and <code>throw</code>s invoked on generators</a>.</p>
<h2>tslib 2.4.0</h2>
<p>This release includes the <code>__classPrivateFieldIn</code> helper as well as an update to <code>__createBinding</code> to reduce indirection between multiple re-exports.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8acd4b30d3"><code>8acd4b3</code></a> Bump version to 2.4.1.</li>
<li><a href="5f7365ee1c"><code>5f7365e</code></a> Remove extra line in generator.md</li>
<li><a href="b1d38ee117"><code>b1d38ee</code></a> Fix early call to return/throw on generator (<a href="https://github-redirect.dependabot.com/Microsoft/tslib/issues/186">https://github.com/facebook/flipper/issues/186</a>)</li>
<li><a href="4e27e9fc6e"><code>4e27e9f</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Microsoft/tslib/issues/181">https://github.com/facebook/flipper/issues/181</a> from microsoft/users/GitHubPolicyService/201dd6b7-4ca...</li>
<li><a href="7af3973ab3"><code>7af3973</code></a> Microsoft mandatory file</li>
<li><a href="5bfaf87d1d"><code>5bfaf87</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Microsoft/tslib/issues/172">https://github.com/facebook/flipper/issues/172</a> from microsoft/add-test-vite</li>
<li><a href="a7129c7bd5"><code>a7129c7</code></a> Update bower.json</li>
<li><a href="5b7da89bf0"><code>5b7da89</code></a> Update package.json</li>
<li><a href="f5417485cf"><code>f541748</code></a> Drop node@10 from test matrix, add node@16</li>
<li><a href="8860d619ff"><code>8860d61</code></a> Add a test for vite</li>
<li>Additional commits viewable in <a href="https://github.com/Microsoft/tslib/compare/2.3.1...2.4.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4346
Reviewed By: antonk52
Differential Revision: D41578593
Pulled By: mweststrate
fbshipit-source-id: 82a3794ac67e58740e5a06135bacf7f013ff1338
Summary: this assumption doesnt hold true for android as the snapshot is of the decor view and app bounds include the status bar / bottom bar
Reviewed By: elboman
Differential Revision: D42035810
fbshipit-source-id: 177b5d086487a940e0bdbe20c2a001c420a08d69
Summary:
1. Greater spacing between levels
2. Align children when one has chevron and another doesnt
3. Allow searching of inline attribute values
Reviewed By: lblasa
Differential Revision: D41955235
fbshipit-source-id: aa6bce71810a32cd218db790287aaaf506df75b7
Summary: There is no reason to have a context menu rendered by react for each item in the tree, its pretty wastefull. It also means less props drilled to the tree node
Reviewed By: lblasa
Differential Revision: D41872778
fbshipit-source-id: b13491a310c03334d7f3056207f5de23d20c3e61
Summary:
1. only useValue from tree root
2. Pass down props for ui state instead subscribing ad hoc
3. Pass down callbacks, instead of updating atoms ad hoc.
4. Create ui actions object holding api, will use this later on in the vizualizer as some of the same
In general its more verbose but with memoizing perf should be fine should hopefully be easier to reason about components and what they can do as things are more explicit
Hopefully this serves as a general template for how to organise the react code going forward
Reviewed By: lblasa
Differential Revision: D41872490
fbshipit-source-id: 94a33b0e951c04df367ba102fa0a097d4a0389cd
Summary:
This is temporary solution to get to parity with the old plugin. In future would like to make this more flexible on the desktop side
Additionally getData was renamed to getAttributes for consistency
Reviewed By: lblasa
Differential Revision: D41845248
fbshipit-source-id: 50e94a7712f5d42938229134e212cef5d379475d
Summary: While moving mouse and changing hover state react render is under 1ms due to subscribing to state rather than passing hover as prop to all components
Reviewed By: lblasa
Differential Revision: D41838168
fbshipit-source-id: c9b3334adc44df5018e0a785684a2883aeb3bab1
Summary: The old implementation would always rerender on every operation (select, hover etc) and was quite slow for large hierachies
Reviewed By: lblasa
Differential Revision: D41838166
fbshipit-source-id: 1270841027926440a9c1f1a846d3aedc75ffe8bf
Summary:
Followup of D39772453 (2437aeb3e9)
Fixes https://fb.workplace.com/groups/flippersupport/permalink/1518236858656967/
1. Stop using clientWidth and offsetWidth because they have rounding errors
2. Since step 1 did not resolve the issue entirely (for some weird reason I do not really have the capacity now to investigate - my bet it is a rounding error when you sum up doubles) set offset of the table to "scroll" instead of "auto". As a result, it starts rendering space for the scrollbars all the time, but since Flipper is a dev tool it should be fine
Reviewed By: antonk52
Differential Revision: D41839402
fbshipit-source-id: cf50eb1600b692d3970003fd1b45b953ee45e3df
Summary:
The root view resolver will always find all root views but there was a bug in the listrootviews method. The code was very complex and most of the code seemed to be unneeded. Its now working. The listrootviews method now just returns teh contents of the observable array.
The reason we needed this is that Certain activities dont seem to tracked by the listener we add to `registerActivityLifecycleCallbacks` Its as if there is a floating decor with no activity. One example in FB4a is clicking on a notification in the notifications panel
Reviewed By: lblasa
Differential Revision: D41522791
fbshipit-source-id: b49b0104ddf758f097e1fd3f9ac6588de2d3646e
Summary:
Bumps [oclif/plugin-warn-if-update-available](https://github.com/oclif/plugin-warn-if-update-available) from 2.0.4 to 2.0.14.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/oclif/plugin-warn-if-update-available/releases"><code>@oclif/plugin-warn-if-update-available</code>'s releases</a>.</em></p>
<blockquote>
<h2>2.0.14</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump <code>@oclif/core</code> from 1.20.3 to 1.20.4 (<a href="10fff9af86">10fff9a</a>)</li>
</ul>
<h2>2.0.13</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump <code>@oclif/core</code> from 1.20.0 to 1.20.3 (<a href="56c514e199">56c514e</a>)</li>
</ul>
<h2>2.0.12</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump async from 2.6.3 to 2.6.4 (<a href="3536f48d5a">3536f48</a>)</li>
</ul>
<h2>2.0.11</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump <code>@oclif/core</code> from 1.19.1 to 1.20.0 (<a href="f1a417375e">f1a4173</a>)</li>
</ul>
<h2>2.0.10</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump <code>@oclif/core</code> from 1.18.0 to 1.19.1 (<a href="388b4101fc">388b410</a>)</li>
</ul>
<h2>2.0.9</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump <code>@oclif/core</code> from 1.16.5 to 1.18.0 (<a href="0e252b24ef">0e252b2</a>)</li>
</ul>
<h2>2.0.8</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump semver from 7.3.7 to 7.3.8 (<a href="02ec3564e0">02ec356</a>)</li>
</ul>
<h2>2.0.7</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump <code>@oclif/core</code> from 1.16.4 to 1.16.5 (<a href="1a81356ae1">1a81356</a>)</li>
</ul>
<h2>2.0.6</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump moment from 2.29.2 to 2.29.4 (<a href="51c59d5722">51c59d5</a>)</li>
</ul>
<h2>2.0.5</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump <code>@oclif/core</code> from 1.1.1 to 1.16.4 (<a href="b8808ca1b7">b8808ca</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/oclif/plugin-warn-if-update-available/blob/main/CHANGELOG.md"><code>@oclif/plugin-warn-if-update-available</code>'s changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<p>All notable changes to this project will be documented in this file. See <a href="https://github.com/conventional-changelog/standard-version">standard-version</a> for commit guidelines.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b821c57bab"><code>b821c57</code></a> chore(release): 2.0.14 [skip ci]</li>
<li><a href="f12100c86d"><code>f12100c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/oclif/plugin-warn-if-update-available/issues/327">https://github.com/facebook/flipper/issues/327</a> from oclif/dependabot-npm_and_yarn-oclif-core-1.20.4</li>
<li><a href="10fff9af86"><code>10fff9a</code></a> fix(deps): bump <code>@oclif/core</code> from 1.20.3 to 1.20.4</li>
<li><a href="6e8a6f9b1e"><code>6e8a6f9</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/oclif/plugin-warn-if-update-available/issues/328">https://github.com/facebook/flipper/issues/328</a> from oclif/dependabot-npm_and_yarn-chai-and-types-cha...</li>
<li><a href="bded580245"><code>bded580</code></a> chore(dev-deps): bump chai and <code>@types/chai</code></li>
<li><a href="81e38a0747"><code>81e38a0</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/oclif/plugin-warn-if-update-available/issues/324">https://github.com/facebook/flipper/issues/324</a> from oclif/dependabot-npm_and_yarn-types-lodash-4.14.188</li>
<li><a href="502b073c7c"><code>502b073</code></a> chore(dev-deps): bump <code>@types/lodash</code> from 4.14.186 to 4.14.188</li>
<li><a href="951d36474d"><code>951d364</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/oclif/plugin-warn-if-update-available/issues/325">https://github.com/facebook/flipper/issues/325</a> from oclif/dependabot-npm_and_yarn-tslib-2.4.1</li>
<li><a href="b98ff2e8fe"><code>b98ff2e</code></a> chore(dev-deps): bump tslib from 2.4.0 to 2.4.1</li>
<li><a href="6469b28776"><code>6469b28</code></a> chore(release): 2.0.13 [skip ci]</li>
<li>Additional commits viewable in <a href="https://github.com/oclif/plugin-warn-if-update-available/compare/v2.0.4...2.0.14">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4341
Reviewed By: antonk52
Differential Revision: D41578608
Pulled By: mweststrate
fbshipit-source-id: 71066c6c1b62bcd23f4943ea7d028d939c29cd61
Summary:
Bumps [oclif/config](https://github.com/oclif/config) from 1.18.3 to 1.18.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/oclif/config/releases"><code>@oclif/config</code>'s releases</a>.</em></p>
<blockquote>
<h2>1.18.6</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump <code>@oclif/parser</code> from 3.8.8 to 3.8.9 (<a href="6c30537f9a">6c30537</a>)</li>
</ul>
<h2>1.18.5</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump <code>@oclif/parser</code> from 3.8.7 to 3.8.8 (<a href="b03591e782">b03591e</a>)</li>
</ul>
<h2>1.18.4</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump <code>@oclif/errors</code> from 1.3.5 to 1.3.6 (<a href="8fbab1517f">8fbab15</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/oclif/config/blob/main/CHANGELOG.md"><code>@oclif/config</code>'s changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<p>All notable changes to this project will be documented in this file. See <a href="https://github.com/conventional-changelog/standard-version">standard-version</a> for commit guidelines.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="7b9bd9359c"><code>7b9bd93</code></a> chore(release): 1.18.6 [skip ci]</li>
<li><a href="e328852f15"><code>e328852</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/oclif/config/issues/342">https://github.com/facebook/flipper/issues/342</a> from oclif/dependabot-npm_and_yarn-oclif-parser-3.8.9</li>
<li><a href="6c30537f9a"><code>6c30537</code></a> fix(deps): bump <code>@oclif/parser</code> from 3.8.8 to 3.8.9</li>
<li><a href="4d8137011a"><code>4d81370</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/oclif/config/issues/339">https://github.com/facebook/flipper/issues/339</a> from oclif/dependabot-npm_and_yarn-types-node-14.18.33</li>
<li><a href="335064dd4c"><code>335064d</code></a> chore(dev-deps): bump <code>@types/node</code> from 14.18.32 to 14.18.33</li>
<li><a href="dc8129050b"><code>dc81290</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/oclif/config/issues/338">https://github.com/facebook/flipper/issues/338</a> from oclif/repo-sync/leif/default</li>
<li><a href="8a103317d0"><code>8a10331</code></a> chore([no ci]): Synced local '.github/workflows/manualRelease.yml' with remot...</li>
<li><a href="5dade910ad"><code>5dade91</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/oclif/config/issues/337">https://github.com/facebook/flipper/issues/337</a> from oclif/dependabot-npm_and_yarn-types-node-14.18.32</li>
<li><a href="be81537a3f"><code>be81537</code></a> chore(dev-deps): bump <code>@types/node</code> from 14.18.31 to 14.18.32</li>
<li><a href="cf927d9910"><code>cf927d9</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/oclif/config/issues/336">https://github.com/facebook/flipper/issues/336</a> from oclif/repo-sync/leif/default</li>
<li>Additional commits viewable in <a href="https://github.com/oclif/config/compare/v1.18.3...1.18.6">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4301
Reviewed By: antonk52
Differential Revision: D41578628
Pulled By: mweststrate
fbshipit-source-id: 100b203984df2589dc088a2e2acea67aef934b8b
Summary:
This change adds a small feedback alert banner. It will have a link to our workplace feedback group.
Additionally, it asks engineers to record their sessions.
Reviewed By: LukeDefeo
Differential Revision: D41531851
fbshipit-source-id: 7ec8ca79350e7a84ab0532065bc57187ef0055ba
Summary:
Attributes Inspector didn't have support for inspectable arrays.
This change addresses an issue with the inspectable itself and adds basic support to it in the visualiser.
Reviewed By: LukeDefeo
Differential Revision: D41522879
fbshipit-source-id: f9cad42470541039c8157477b0fe9bc58f18f1ba
Summary: also made the controls component full width to push down the visualiser
Reviewed By: lblasa
Differential Revision: D41548665
fbshipit-source-id: 2bca527e70c92bc0ded120e51a0880f76f7cca87
Summary: This was causing the hover state to linger which is now quite noticable in the tree
Reviewed By: lblasa
Differential Revision: D41548249
fbshipit-source-id: cdf8ed434aa064dba05ebf31773bedaef18ba007
