87e7afe4ab88f35fe2027df685ed4025e70708e1
986 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Pascal Hartig
|
e788bb09be |
Add logs support for physical devices
Summary: There's a bit of an oddity with `idb` that the `stream` parameter is implied even though the docs say otherwise and if you try to use it, it'll give you a strange Python error. That's likely why we never implemented it. Now, it works just as it does using local tooling. Reviewed By: mweststrate Differential Revision: D26228036 fbshipit-source-id: e20cb31167170ba0501e2929ed129305cb9aaf2c |
||
generatedunixname89002005306973
|
0429c1892f |
Flipper Release: v0.74.0
Summary: Releasing version 0.74.0 Reviewed By: jknoxville Differential Revision: D26253173 fbshipit-source-id: 80f4e3917cf130bbf546af6d48e43a62265660d0 |
||
|
Pascal Hartig
|
87caca9e77 |
Demote iOS connection errors
Summary: The "attaching failed" error provides no context and is a handled error, so we don't need to elevate this to a warning. We also see a socket warning on stderr every time we start up logging through simctl, so we don't need to treat that as an error. Reviewed By: nikoant Differential Revision: D26228037 fbshipit-source-id: 1938dadd54499462e1fd614c9477f738661c387b |
||
|
Pascal Hartig
|
661af25ff9 |
getAppVersion for UpdateIndicator
Summary:
VSCode got a new thing where it doesn't save my file because it waits for a formatter or some stuff indefinitely, which is really cool, because it means my diffs end up being incomplete.
So this should have been in D26223274 (
|
||
Anton Nikolaev
|
2f03aca5eb |
Revert D26222885: Upgrade metro to 0.65.0
Differential Revision:
D26222885 (
|
||
|
Pascal Hartig
|
642d89213d |
Extract getAppVersion() util
Summary: Just some simple memoisation so we limit this particular `remote` call to one per session. Reviewed By: mweststrate Differential Revision: D26223274 fbshipit-source-id: 7a12764758823c52f68fb7075f46caf58affb22f |
||
Michel Weststrate
|
40abef860f |
Fix key warning
Summary: Crash reporter generated React errors because the different lines in a stack trace are not per definition unique Reviewed By: jknoxville Differential Revision: D26201941 fbshipit-source-id: 084e0157b1fa3b8216d35f62f0dc17b0d6414b8e |
||
|
Anton Nikolaev
|
9fe82dd6c7 |
Upgrade metro to 0.65.0
Summary: Upgrade metro to 0.65.0 Reviewed By: passy Differential Revision: D26222885 fbshipit-source-id: bb386ae4bc913d47d9f3431368e45c6319f0d65d |
||
dependabot[bot]
|
e09e3c82ee |
Bump antd from 4.9.1 to 4.11.2 in /desktop (#1886)
Summary: allow-large-files Bumps [antd](https://github.com/ant-design/ant-design) from 4.9.1 to 4.11.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p> <blockquote> <h2>4.11.2</h2> <ul> <li>{emoji:1f41e} Fix rc-trigger BuildInPlacements TypeScript compile error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li> </ul> <hr /> <ul> <li>{emoji:1f41e} 修复 rc-trigger BuildInPlacements TypeScript 编译错误。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li> </ul> <h2>4.11.1</h2> <ul> <li>{emoji:1f484} Layout inline sub menu now has grey background. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f195} PageHeader supports <code>breadcrumbRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li> <li>{emoji:1f195} Typography <code>ellipsis</code> support <code>tooltip</code> to customize tooltip when ellipsis. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li> <li>Image <ul> <li>{emoji:1f195} Image supports <code>preview.maskClassName</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li> <li>{emoji:1f41e} Fix preview image will move after click it. <a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li> <li>{emoji:1f41e} Fix Image <code>placeholder</code> disappear issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li> <li>{emoji:1f41e} Fix multiple Image.PreviewGroup contain same image. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li> </ul> </li> <li>ConfigProvider <ul> <li>{emoji:1f195} ConfigProvider supports <code>iconPrefixCls</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li> <li>{emoji:26a1} Optimize ConfigProvider props updating perfermance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li> </ul> </li> <li>{emoji:1f484} Tweak TreeSelect filter highlight color. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li> <li>{emoji:1f484} Fix Select item align style with custom <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li> <li>Form <ul> <li>{emoji:1f41e} Fix Form.Item can not clear nested <code>noStyle</code> error message. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li> <li>{emoji:1f41e} Form.Item with <code>preserve=false</code> will reset value to <code>initialValues</code> when removed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li> </ul> </li> <li>{emoji:1f41e} Fix Button click effect style not working in shadow root. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28995">#28995</a> <a href="https://github.com/rinick"><code>rinick</code></a></li> <li>{emoji:1f41e} Fix Table custom filter menu cannot close bug. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28688">#28688</a> <a href="https://github.com/alekye"><code>alekye</code></a></li> <li>Less <ul> <li>{emoji:1f484} Add <code>menu-inline-submenu-bg</code> less variable and rename <code>menu-dark-submenu-bg</code> to <code>menu-dark-inline-submenu-bg</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f484} Add less variable <code>drawer-footer-padding-horizontal</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28975">#28975</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li> </ul> </li> <li>RTL <ul> <li>{emoji:1f484} Fix Card actions divider style in RTL. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28915">#28915</a> <a href="https://github.com/Aghosey"><code>Aghosey</code></a></li> </ul> </li> <li>TypeScript <ul> <li>� Expose interfaces and types from default entry of antd. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28963">#28963</a></li> <li>� Improve Input/Skeleton <code>style</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28966">#28966</a> <a href="https://github.com/yingpengsha"><code>yingpengsha</code></a></li> </ul> </li> </ul> <hr /> <ul> <li>{emoji:1f484} Layout 内联子表单添加背景颜色以更好的区分层级。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f195} PageHeader 支持 <code>breadcrumbRender</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li> <li>{emoji:1f195} Typography <code>ellipsis</code> 属性添加 <code>tooltip</code> 支持以自定义收缩时的提示信息。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li> <li>Image <ul> <li>{emoji:1f195} Image 支持配置 <code>preview.maskClassName</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li> <li>{emoji:1f41e} 修复预览图片会跟随鼠标移动的问题。<a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li> <li>{emoji:1f41e} 修复 Image <code>placeholder</code> 不显示的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li> <li>{emoji:1f41e} 修复多个 Image.PreviewGroup 之间图片互串的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li> </ul> </li> <li>ConfigProvider</li> <li>ConfigProvider <ul> <li>{emoji:1f195} ConfigProvider 支持 <code>iconPrefixCls</code> 修改图标样式前缀。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li> <li>{emoji:26a1} 优化 ConfigProvider 切换属性的性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li> </ul> </li> <li>{emoji:1f484} 调整 TreeSelect 搜索高亮条目的颜色。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li> <li>{emoji:1f484} 修复 Select 自定义 <code>tagRender</code> 时不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li> <li>Form <ul> <li>{emoji:1f41e} 修复 Form.Item 无法正确清理嵌套的 <code>noStyle</code> 错误信息问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li> <li>{emoji:1f41e} Form.Item 配置 <code>preserve=false</code> 时，移除该字段将自动重置对应值为 <code>initialValues</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p> <blockquote> <h2>4.11.2</h2> <p><code>2021-01-26</code></p> <ul> <li>{emoji:1f41e} Fix rc-trigger BuildInPlacements TypeScript compile error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li> </ul> <h2>4.11.1</h2> <p><code>2021-01-24</code></p> <ul> <li>{emoji:1f484} Layout inline sub menu now has grey background. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f195} PageHeader supports <code>breadcrumbRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li> <li>{emoji:1f195} Typography <code>ellipsis</code> support <code>tooltip</code> to customize tooltip when ellipsis. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li> <li>Image <ul> <li>{emoji:1f195} Image supports <code>preview.maskClassName</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li> <li>{emoji:1f41e} Fix preview image will move after click it. <a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li> <li>{emoji:1f41e} Fix Image <code>placeholder</code> disappear issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li> <li>{emoji:1f41e} Fix multiple Image.PreviewGroup contain same image. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li> </ul> </li> <li>ConfigProvider <ul> <li>{emoji:1f195} ConfigProvider supports <code>iconPrefixCls</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li> <li>{emoji:26a1} Optimize ConfigProvider props updating perfermance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li> </ul> </li> <li>{emoji:1f484} Tweak TreeSelect filter highlight color. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li> <li>{emoji:1f484} Fix Select item align style with custom <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li> <li>Form <ul> <li>{emoji:1f41e} Fix Form.Item can not clear nested <code>noStyle</code> error message. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li> <li>{emoji:1f41e} Form.Item with <code>preserve=false</code> will reset value to <code>initialValues</code> when removed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li> </ul> </li> <li>{emoji:1f41e} Fix Button click effect style not working in shadow root. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28995">#28995</a> <a href="https://github.com/rinick"><code>rinick</code></a></li> <li>{emoji:1f41e} Fix Table custom filter menu cannot close bug. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28688">#28688</a> <a href="https://github.com/alekye"><code>alekye</code></a></li> <li>Less <ul> <li>{emoji:1f484} Add <code>menu-inline-submenu-bg</code> less variable and rename <code>menu-dark-submenu-bg</code> to <code>menu-dark-inline-submenu-bg</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li> <li>{emoji:1f484} Add less variable <code>drawer-footer-padding-horizontal</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28975">#28975</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li> </ul> </li> <li>RTL <ul> <li>{emoji:1f484} Fix Card actions divider style in RTL. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28915">#28915</a> <a href="https://github.com/Aghosey"><code>Aghosey</code></a></li> </ul> </li> <li>TypeScript <ul> <li>� Expose interfaces and types from default entry of antd. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28963">#28963</a></li> <li>� Improve Input/Skeleton <code>style</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28966">#28966</a> <a href="https://github.com/yingpengsha"><code>yingpengsha</code></a></li> </ul> </li> </ul> <h2>4.11.0</h2> <p><code>2021-01-24</code></p> <p>It is a wrong release which same as <code>4.10.3</code>, don't use it.</p> <h2>4.10.3</h2> <p><code>2021-01-18</code></p> <ul> <li>{emoji:1f41e} Fix Button not adapting to the <code>btn-border-width</code> when loading. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28886">#28886</a> <a href="https://github.com/jjanssen"><code>jjanssen</code></a></li> <li>Table <ul> <li>{emoji:1f484} Add <code>table-border-color</code> less variable. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28903">#28903</a></li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Pritesh Nandgaonkar
|
6a0854557e |
Add gk checks in plugin
Summary: This diff adds gk checks, VPN check and User login check to our plugin. I added gk checks for Insta and FB apps. There are three kind of GK's. One with FB universe, one with Distillery universe and one with Insta WWW universe. We have API's to check gk with FB and Distillery universe. API to check with Insta WWW universe doesn't exists. There are some technical challenges to build this API. So right now for gks with Insta WWW universe, we just show an notification with info icon. For gks in other universe we aggressively check it when user closes the notif to verify if user assigned himself/herself to it. In long term we are moving away from gks altogether, we need this UX improvement as it will help users to onboard easily. See the following flow. Reviewed By: mweststrate Differential Revision: D26176996 fbshipit-source-id: 92a931610f9b244c14c6888bb12df936b62edd75 |
||
|
Pascal Hartig
|
9469ad33af |
Make addErrorNotification raise a warning
Summary: These are recoverable, handled errors. We shouldn't treat these as events that require actions from us. They also have a tendency of firing a lot. Reviewed By: nikoant Differential Revision: D26202358 fbshipit-source-id: 445f3c2bcd0041d5cd773ec04172fdeed9b32222 |
||
|
Pascal Hartig
|
6dffc5695e |
Bump ts linters
Summary: It had this scary warning at the top that the TS version was too new for the linters. Reviewed By: nikoant Differential Revision: D26202273 fbshipit-source-id: df03d6bf176da00ee37b027679b9f258ab123395 |
||
|
dependabot[bot]
|
5850bb6b52 |
Bump open from 7.0.3 to 7.3.1 in /desktop (#1867)
Summary: Bumps [open](https://github.com/sindresorhus/open) from 7.0.3 to 7.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sindresorhus/open/releases">open's releases</a>.</em></p> <blockquote> <h2>v7.3.1</h2> <ul> <li>Fix support for WSL when Windows isn&<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/39">https://github.com/facebook/flipper/issues/39</a>;t mounted in <code>/mnt/</code> (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/210">https://github.com/facebook/flipper/issues/210</a>) a3bbadc</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.3.0...v7.3.1">https://github.com/sindresorhus/open/compare/v7.3.0...v7.3.1</a></p> <h2>v7.3.0</h2> <ul> <li>Support WSL configuration where Windows paths are not in PATH (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/195">https://github.com/facebook/flipper/issues/195</a>) be0f794</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.2.1...v7.3.0">https://github.com/sindresorhus/open/compare/v7.2.1...v7.3.0</a></p> <h2>v7.2.1</h2> <ul> <li>Fix <code>app</code> option on Windows (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/191">https://github.com/facebook/flipper/issues/191</a>) 9bcd285</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.2.0...v7.2.1">https://github.com/sindresorhus/open/compare/v7.2.0...v7.2.1</a></p> <h2>v7.2.0</h2> <ul> <li>Use PowerShell on Windows for improved reliability (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/188">https://github.com/facebook/flipper/issues/188</a>) f7ca0d3</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.1.0...v7.2.0">https://github.com/sindresorhus/open/compare/v7.1.0...v7.2.0</a></p> <h2>v7.1.0</h2> <ul> <li>Add <a href="https://github.com/sindresorhus/open#allownonzeroexitcode"><code>allowNonzeroExitCode</code></a> option (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/176">https://github.com/facebook/flipper/issues/176</a>) e009765</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.0.4...v7.1.0">https://github.com/sindresorhus/open/compare/v7.0.4...v7.1.0</a></p> <h2>v7.0.4</h2> <ul> <li>Fix double-encoding of URLs (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/182">https://github.com/facebook/flipper/issues/182</a>) 48b6d0e</li> </ul> <p><a href="https://github.com/sindresorhus/open/compare/v7.0.3...v7.0.4">https://github.com/sindresorhus/open/compare/v7.0.3...v7.0.4</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Michel Weststrate
|
9bd3d6fd7c |
Fix serialization performance
Summary:
Using our serialization utilities in the previous diff absolute destroyed the performance of serializing the device logs. Investigated a bit, and the root cause is that *every* object serialization would notify the UI.
This is not only pointless, since the UI won't be updated until the next tick anyway, it also is terribly expensive since React has to process and queue all these updates.
Exporting the device logs went down from **2 minutes to a few seconds** with this change. (Still a lot slower than JSON.stringify, but I think the flexibility for plugin devs is worth it).
This change does not only benefit devicelogs plugin, but all existing plugins as well, plugins like GraphQL should now export their data much quicker.
Before (practically all time of serialization is spend in React's setState):
{F366147730}
After (only a spike at the end of the idler tick):
{F366147779}
Reviewed By: priteshrnandgaonkar
Differential Revision: D26146420
fbshipit-source-id: 9bbeccf04701fd044e041956b7bb00f1e0622b63
|
||
|
Michel Weststrate
|
594fa4d2bc |
serialize Sandy plugins with serialization utils to support Date/Set/Map
Summary: Unlike non-sandy plugins, non-sandy plugins weren't serialized using our serialization utility yet. This diff addresses that, meaning that users don't have to bother about how to serialize maps, sets and dates. Unlike the old fashioned plugins, the `makeObjectSerialize` utility is used, rather than `serialize`. This normalizes the objects, but doesn't serialize them, which is done at the end of the export data process anyway for the whole tree. This avoids creating a double JSON serialization which is fully of ugly escape characters. This makes the onImport / onExport definition of the logs plugin nicer. Also improved the docs. Reviewed By: nikoant Differential Revision: D26146421 fbshipit-source-id: 6abfb6ee2e3312e2a13a11832ff103dc62fd844c |
||
|
Michel Weststrate
|
e614993558 |
Fix incorrect date serialization
Summary:
While creating some other tests, discovered that our current date serialization uses `toString()` serialization, causing the amount of milliseconds to be lost. The serialization (see below) uses less bytes as well since the human readable timezone isn't included. This change only affects serialization and is backward compatible.
```
✓ test serialize and deserializeObject function for non Object input (1 ms)
✕ test makeObjectSerializable and deserializeObject function for Date input (2 ms)
✓ test makeObjectSerializable and deserializeObject function for Map of Sets
✓ test makeObjectSerializable and deserializeObject function for Map, Dates and Set with complex nesting (1 ms)
● test makeObjectSerializable and deserializeObject function for Date input
expect(received).toEqual(expected) // deep equality
Expected: 2021-03-01T10:31:07.205Z
Received: 2021-03-01T10:31:07.000Z
```
Reviewed By: priteshrnandgaonkar
Differential Revision: D26145941
fbshipit-source-id: dfd6607a4199ca46e2075027856138efb88a07f9
|
||
|
Michel Weststrate
|
7cc55daf34 |
Stop storing device logs on the device object and in the plugin
Summary: Logs were stored hardcoded on the Device object first, this diff makes it normal plugin state. This makes sure that we can use the same abstractions as in all plugins that store large data sets, and that we can leverage the upcoming DataSource abstraction. Reviewed By: nikoant Differential Revision: D26127243 fbshipit-source-id: 7c386a615fa7989f35ba0df5b7c1d218d37b57a2 |
||
|
Michel Weststrate
|
f2ade40239 |
Support custom data processing during import
Summary: Per title, this allows for pre-processing data after it is deserialized and before it is stored in the plugin Reviewed By: nikoant Differential Revision: D26126423 fbshipit-source-id: bc08a6ab205d2a0d551515563cd85a197595ddb2 |
||
|
Michel Weststrate
|
34c915a739 |
Add support for async / custom plugin export
Summary: Sandy plugins can now set up an `onExport` handler to enable customizing the export format of a plugin: `client.onExport(callback: (idler, onStatusMessage) => Promise<state>)` Import will be done in next diff Reviewed By: nikoant Differential Revision: D26124440 fbshipit-source-id: c787c79d929aa8fb484f15a9340d7c87545793cb |
||
|
Michel Weststrate
|
32bde8cace |
add support for device plugin import / export
Summary: Sandy device plugins weren't exported till now (the only stateful plugin so far was Logs, but logs were stored hardcoded on the device rather than using the plugin export mechanisms). This diff makes sure that SandyDevicePlugins will be exported as well if they are persistable. Reviewed By: nikoant Differential Revision: D22724822 fbshipit-source-id: a10354a9c7e02f3e696d0cdda0f2c6be6f5ac61e |
||
|
Michel Weststrate
|
e1daa449ba |
Unify computation of available plugins
Summary: While trying to change something, discovered we have 3 different mechanisms in our code base to compute active plugins; the plugin list component, support form, and export flipper trace form had all their own, subtly different implementations of computing which plugins are available to the user. Also removed some hardcoded exceptions for e.g. Logs plugin, which in the next diff and onward will be just a vanilla plugin without special casing Unified that, which some how went a bit deeper than hoped, trough some hoops in in circular deps. Also unified to use the same testing utils, to avoid some gobbling objects manually together, with resulted in a bunch of unexpected NPEs. Found out that we actually still have unit tests using Flow in the process :-P. Converted one to TS. Reviewed By: nikoant Differential Revision: D26103172 fbshipit-source-id: 2fce2577d97d98543cb9312b3d013f24faee43aa |
||
bizzguy
|
5320015776 |
Fix mock export file format (#1872)
Summary:
Provide a more robust technique for exporting the mocks to a file.
The current technique for exporting mocks to a file seems to fail under some scenarios. The correct format is an array of objects:
```
[
{
"requestUrl": "https://api.github.com/repos/facebook/yoga",
"requestMethod": "GET",
```
However, the following format is sometimes exported instead:
```
{
"10": {
"requestUrl": "https://demo9512366.mockable.io/SonarPost",
```
Using `Object.values` provides a more robust technique that has been successful during subsequent testing.
## Changelog
Network Plugin - new technique for exporting mocks
Pull Request resolved: https://github.com/facebook/flipper/pull/1872
Test Plan:
Create mocks in the network plugin
Export mocks
Manually examine file for correct format
Import mocks and verify that the file has been imported correctly
Reviewed By: nikoant
Differential Revision: D26172954
Pulled By: mweststrate
fbshipit-source-id: bdfa3ba7dfe656f30ef17df001fc83dd8ea18ece
|
||
|
dependabot[bot]
|
a9ad3d2f1b |
Bump @testing-library/react from 11.1.0 to 11.2.3 in /desktop (#1868)
Summary: Bumps [testing-library/react](https://github.com/testing-library/react-testing-library) from 11.1.0 to 11.2.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/testing-library/react-testing-library/releases"><code>testing-library/react's releases</code></a>.</em></p> <blockquote> <h2>v11.2.3</h2> <h2><a href="https://github.com/testing-library/react-testing-library/compare/v11.2.2...v11.2.3">11.2.3</a> (2021-01-07)</h2> <h3>Bug Fixes</h3> <ul> <li>Return type of unmount is <code>void</code> (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/857">https://github.com/facebook/flipper/issues/857</a>) (<a href=" |
||
|
dependabot[bot]
|
31bf578a8b |
Bump @types/ws from 7.2.7 to 7.4.0 in /desktop (#1869)
Summary: Bumps [types/ws](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ws) from 7.2.7 to 7.4.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ws">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/1869 Reviewed By: mweststrate Differential Revision: D26149508 Pulled By: passy fbshipit-source-id: 6bc9360d297bb9285e3c7515b4731f5c3478c97b |
||
|
bizzguy
|
6a9d06a4ce |
Misc UI fixes (#1873)
Summary: Continue with cleanup of Network plugin mock screens. This mostly consists of replacing FlexColumn, FlexRow and FlexBox with equivalent Sandy components. Here is the new screen: - replace text buttons with Button - add NUX info to "Copy Highlighted Calls" button - add message when no calls have been highlighted - in routes list remove padding on line items  Here is the prior screen:  ## Changelog Network Plugin - Additional cleanup of UI on mock screen Pull Request resolved: https://github.com/facebook/flipper/pull/1873 Test Plan: Create and modify mocks Verify that the functionality has not been affected by UI changes Reviewed By: passy Differential Revision: D26172915 Pulled By: mweststrate fbshipit-source-id: f0af143d8509b53585076737832657fb095e75a6 |
||
|
Michel Weststrate
|
2f15ef883d |
Improve OSS plugin template
Summary: Based https://github.com/facebook/flipper/issues/1866 and running `npx flipper-plugin init` locally. Doesn't address the original issue Fixes #1866 Reviewed By: passy Differential Revision: D26147089 fbshipit-source-id: 608dc92c5ccc741b6e760ea5a5034f9444e951b7 |
||
|
bizzguy
|
8c3abf7450 |
Network Plugin - Minor UI fixes (#1864)
Summary: Made UI fixes to Network Plugin (mostly to Route screens) to continue migration to the new design framework. This consisted mostly of replacing FlexColumn and FlexRow with Layout.Container and Layout.Horizontal. Also, contains some cosmetic changes to "Mock Network Response" page. Here is the screenshot with UI changes:  This was the old screen for comparison:  ## Changelog Network Plugin - UI changes to continue migration to Sandy design framework Pull Request resolved: https://github.com/facebook/flipper/pull/1864 Test Plan: Manual testing to ensure that all data still displayed with new UI changes (especially the Data and Headers info in the "Route Info" section) Reviewed By: passy Differential Revision: D26125656 Pulled By: mweststrate fbshipit-source-id: a25104274ed25788e5c0738ac0a9609f2cead751 |
||
|
Pascal Hartig
|
4b711716f2 |
Improve plugin ready message
Summary: Minor change. Reviewed By: mweststrate Differential Revision: D26129625 fbshipit-source-id: 2b823bb34314b7ff1b84eb1ae708733b7dcc9881 |
||
|
Pascal Hartig
|
c41a2a3605 |
Link to MSC
Summary: Found out about this today. Reviewed By: mweststrate Differential Revision: D26129626 fbshipit-source-id: 82aa5d9fa536010b51fc1cf937f521e5ffa88015 |
||
Timur Valiev
|
d39ea08a6c |
add vs coe glyphs and links to reduction tree
Summary: let's make it easier for users to spot possiblity to jump to source code from flipper Reviewed By: priteshrnandgaonkar Differential Revision: D26147686 fbshipit-source-id: 6e248c10e73f3b8fcd937d915af6e91db1fe6abe |
||
|
Pascal Hartig
|
5ac8f7a16f |
Small refactors
Summary: Going to make more changes here soon and wanted to apply some small changes first. Reviewed By: jknoxville Differential Revision: D26078645 fbshipit-source-id: 3a2bcd593b893160b5a332c858a514ebe89d3f4d |
||
|
generatedunixname89002005306973
|
20cd25f726 |
Flipper Release: v0.73.0
Summary: Releasing version 0.73.0 Reviewed By: nikoant Differential Revision: D26125287 fbshipit-source-id: 7fd00aa679a5ac3d69013d0bdb0cf5d868fd5cc7 |
||
|
Anton Nikolaev
|
d7cfcb5d8e |
Extend device plugin metadata to include supported devices
Summary: Plugin metadata format extended to include type of each plugin (client / device) and list of supported devices (android/ios/..., emulator/physical, etc). This will allow to detect plugins supported by device even if they are not installed and only available on Marketplace. Reviewed By: mweststrate Differential Revision: D26073531 fbshipit-source-id: e331f1be1af1046cd4220a286a1d52378c26cc53 |
||
|
Anton Nikolaev
|
1ce619af7e |
Tolerate individual plugin load errors
Summary: This diff fixes the issue when there is an error on checking GK for any of plugins and because of it the entire set of plugins failed to load. Each plugin should be loaded in isolation from others. Reviewed By: passy Differential Revision: D26099735 fbshipit-source-id: ba5475f4baf2d06f8922d345c9d401f5b15956ec |
||
|
bizzguy
|
6df117ba04 |
Network Plugin - New functions to import, export and clear Routes (#1855)
Summary: In the network plugin, add features to import and export routes as described in issue https://github.com/facebook/flipper/issues/1651 Primary use case is that external testers (such as QA teams) would be able to create test data, convert it to mocks and save the mocks to make bug fixes easier for devs. Here is a screenshot showing location of buttons to perform import/export (and clearing) of mock routes:  Here is another screenshot showing export dialog:  Changelog: [Network] Mock routes can now be imported and exported. Thanks bizzguy! Pull Request resolved: https://github.com/facebook/flipper/pull/1855 Test Plan: Performed manual testing - create new mocks - export mocks - clear mocks - import mocks - verify that mocks still work by making GET/POST requests in sample app Performed various permutations of above manual tests, including restarting Flipper at various points to ensure that test plan still worked. Also performed visual inspection of exported files to verify correctness. Would be very interested in learning how to create automated tests for this functionality. Reviewed By: passy Differential Revision: D26072928 Pulled By: mweststrate fbshipit-source-id: 51bd5e19e78d830b94add850d5dc9b9e45fa6fad |
||
|
Michel Weststrate
|
14997a5b98 |
Add antd to builtInModules
Summary: importing `antd` in a plugin that lives in the Flipper repo will give a int warning. This fixes that, antd is provided by the host package. Reviewed By: nikoant Differential Revision: D26073161 fbshipit-source-id: 897357fafce20129f7e12c035ff99cb4870cc814 |
||
|
Michel Weststrate
|
f6d8b19001 |
Replace search view with drop down
Summary: The support form currently has a search form to select a group, but unless the selection is cleared, it won't show you which groups is actually available, which makes it hard for people to select the right group if they don't know up front. Since the scale of available groups doesn't justify needing a typeahead, converted it to an ordinary dropdown. An added benefit is that this allows us to remove a large and complicated component we shouldn't be maintaining ourselves, but rather reuse from Ant. Reviewed By: nikoant Differential Revision: D26046131 fbshipit-source-id: f499e5848eec8b961b054104c8e3a01567e2801e |
||
|
dependabot[bot]
|
de60b28cc7 |
Bump rsocket-flowable from 0.0.14 to 0.0.22 in /desktop (#1863)
Summary: Bumps [rsocket-flowable](https://github.com/rsocket/rsocket-js) from 0.0.14 to 0.0.22. <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
b4319387ad |
Bump react-refresh from 0.8.3 to 0.9.0 in /desktop (#1861)
Summary: Bumps [react-refresh](https://github.com/facebook/react/tree/HEAD/packages/react) from 0.8.3 to 0.9.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/react/releases">react-refresh's releases</a>.</em></p> <blockquote> <h2>v0.9.0</h2> <h2>What’s New?</h2> <p>This version includes better support for normalizing event properties across all supported browsers so that you need to worry even less about cross-browser differences. We've also made many improvements to error messages and have refactored the core to never rethrow errors, so stack traces are more accurate and Chrome's purple break-on-error stop sign now works properly.</p> <p>We've also added to the add-ons build <a href="https://github.com/facebook/react/tree/HEAD/packages/react/blob/HEAD/react/docs/test-utils.html">React.addons.TestUtils</a>, a set of new utilities to help you write unit tests for React components. You can now simulate events on your components, and several helpers are provided to help make assertions about the rendered DOM tree.</p> <p>We've also made several other improvements and a few breaking changes; the full changelog is provided below.</p> <h2>JSX Whitespace</h2> <p>In addition to the changes to React core listed below, we've made a small change to the way JSX interprets whitespace to make things more consistent. With this release, space between two components on the same line will be preserved, while a newline separating a text node from a tag will be eliminated in the output. Consider the code:</p> <pre lang="html"><code><div> Monkeys: {listOfMonkeys} {submitButton} </div> </code></pre> <p>In v0.8 and below, it was transformed to the following:</p> <pre lang="javascript"><code>React.DOM.div(null, " Monkeys: ", listOfMonkeys, submitButton ) </code></pre> <p>In v0.9, it will be transformed to this JS instead:</p> <pre lang="javascript{2,3}"><code>React.DOM.div(null, "Monkeys:", listOfMonkeys, " ", submitButton ) </code></pre> <p>We believe this new behavior is more helpful and elimates cases where unwanted whitespace was previously added.</p> <p>In cases where you want to preserve the space adjacent to a newline, you can write <code>{'Monkeys: '}</code> or <code>Monkeys:{' '}</code> in your JSX source. We've included a script to do an automated codemod of your JSX source tree that preserves the old whitespace behavior by adding and removing spaces appropriately. You can <a href="https://github.com/facebook/react/blob/master/npm-jsx_whitespace_transformer/README.md">install jsx_whitespace_transformer from npm</a> and run it over your source tree to modify files in place. The transformed JSX files will preserve your code's existing whitespace behavior.</p> <h2>Changelog</h2> <h3>React Core</h3> <h4>Breaking Changes</h4> <ul> <li>The lifecycle methods <code>componentDidMount</code> and <code>componentDidUpdate</code> no longer receive the root node as a parameter; use <code>this.getDOMNode()</code> instead</li> <li>Whenever a prop is equal to <code>undefined</code>, the default value returned by <code>getDefaultProps</code> will now be used instead</li> <li><code>React.unmountAndReleaseReactRootNode</code> was previously deprecated and has now been removed</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/facebook/react/blob/master/CHANGELOG.md">react-refresh's changelog</a>.</em></p> <blockquote> <h2>0.9.0 (February 20, 2014)</h2> <h3>React Core</h3> <h4>Breaking Changes</h4> <ul> <li>The lifecycle methods <code>componentDidMount</code> and <code>componentDidUpdate</code> no longer receive the root node as a parameter; use <code>this.getDOMNode()</code> instead</li> <li>Whenever a prop is equal to <code>undefined</code>, the default value returned by <code>getDefaultProps</code> will now be used instead</li> <li><code>React.unmountAndReleaseReactRootNode</code> was previously deprecated and has now been removed</li> <li><code>React.renderComponentToString</code> is now synchronous and returns the generated HTML string</li> <li>Full-page rendering (that is, rendering the <code><html></code> tag using React) is now supported only when starting with server-rendered markup</li> <li>On mouse wheel events, <code>deltaY</code> is no longer negated</li> <li>When prop types validation fails, a warning is logged instead of an error thrown (with the production build of React, type checks are now skipped for performance)</li> <li>On <code>input</code>, <code>select</code>, and <code>textarea</code> elements, <code>.getValue()</code> is no longer supported; use <code>.getDOMNode().value</code> instead</li> <li><code>this.context</code> on components is now reserved for internal use by React</li> </ul> <h4>New Features</h4> <ul> <li>React now never rethrows errors, so stack traces are more accurate and Chrome's purple break-on-error stop sign now works properly</li> <li>Added support for SVG tags <code>defs</code>, <code>linearGradient</code>, <code>polygon</code>, <code>radialGradient</code>, <code>stop</code></li> <li>Added support for more attributes: <ul> <li><code>crossOrigin</code> for CORS requests</li> <li><code>download</code> and <code>hrefLang</code> for <code><a></code> tags</li> <li><code>mediaGroup</code> and <code>muted</code> for <code><audio></code> and <code><video></code> tags</li> <li><code>noValidate</code> and <code>formNoValidate</code> for forms</li> <li><code>property</code> for Open Graph <code><meta></code> tags</li> <li><code>sandbox</code>, <code>seamless</code>, and <code>srcDoc</code> for <code><iframe></code> tags</li> <li><code>scope</code> for screen readers</li> <li><code>span</code> for <code><colgroup></code> tags</li> </ul> </li> <li>Added support for defining <code>propTypes</code> in mixins</li> <li>Added <code>any</code>, <code>arrayOf</code>, <code>component</code>, <code>oneOfType</code>, <code>renderable</code>, <code>shape</code> to <code>React.PropTypes</code></li> <li>Added support for <code>statics</code> on component spec for static component methods</li> <li>On all events, <code>.currentTarget</code> is now properly set</li> <li>On keyboard events, <code>.key</code> is now polyfilled in all browsers for special (non-printable) keys</li> <li>On clipboard events, <code>.clipboardData</code> is now polyfilled in IE</li> <li>On drag events, <code>.dragTransfer</code> is now present</li> <li>Added support for <code>onMouseOver</code> and <code>onMouseOut</code> in addition to the existing <code>onMouseEnter</code> and <code>onMouseLeave</code> events</li> <li>Added support for <code>onLoad</code> and <code>onError</code> on <code><img></code> elements</li> <li>Added support for <code>onReset</code> on <code><form></code> elements</li> <li>The <code>autoFocus</code> attribute is now polyfilled consistently on <code>input</code>, <code>select</code>, and <code>textarea</code></li> </ul> <h4>Bug Fixes</h4> <ul> <li>React no longer adds an <code>__owner__</code> property to each component's <code>props</code> object; passed-in props are now never mutated</li> <li>When nesting top-level components (e.g., calling <code>React.renderComponent</code> within <code>componentDidMount</code>), events now properly bubble to the parent component</li> <li>Fixed a case where nesting top-level components would throw an error when updating</li> <li>Passing an invalid or misspelled propTypes type now throws an error</li> <li>On mouse enter/leave events, <code>.target</code>, <code>.relatedTarget</code>, and <code>.type</code> are now set properly</li> <li>On composition events, <code>.data</code> is now properly normalized in IE9 and IE10</li> <li>CSS property values no longer have <code>px</code> appended for the unitless properties <code>columnCount</code>, <code>flex</code>, <code>flexGrow</code>, <code>flexShrink</code>, <code>lineClamp</code>, <code>order</code>, <code>widows</code></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/facebook/react/commits/v0.9.0/packages/react">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/1861 Reviewed By: passy Differential Revision: D26047350 Pulled By: mweststrate fbshipit-source-id: ee94f7e41970ac8b01eeb4719b7a9dd0ac556398 |
||
|
dependabot[bot]
|
278f16947e |
Bump @babel/traverse from 7.12.10 to 7.12.12 in /desktop (#1859)
Summary: Bumps [babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.12.10 to 7.12.12. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>babel/traverse's releases</code></a>.</em></p> <blockquote> <h2>v7.12.12 (2020-12-23)</h2> <p>This was the first release <a href="https://github.com/babel/babel/actions/runs/440377535">published from GitHub Actions</a>! 🎉</p> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-plugin-transform-block-scoping</code>, <code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12530">#12530</a> skip discriminant when renamer starts from SwitchStatement (<a href="https://github.com/Zzzen"><code>Zzzen</code></a>)</li> </ul> </li> <li><code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12521">#12521</a> Restore <code>babel/types</code> support for old TS versions (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-block-scoping</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12512">#12512</a> Fix annex B block function hoisting semantics (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-polyfill</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12541">#12541</a> Archive <code>babel/polyfill</code> (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-builder-react-jsx-experimental</code>, <code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12524">#12524</a> refactor: Move <code>react-jsx-development</code> implementation into <code>react-jsx</code> (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-fixtures</code>, <code>babel-helper-transform-fixture-test-runner</code>, <code>babel-plugin-proposal-async-generator-functions</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12130">#12130</a> Remove babel polyfill from fixture test runner (<a href="https://github.com/JLHwung"><code>JLHwung</code></a>)</li> </ul> </li> <li>Other <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12527">#12527</a> Update <code>release-tool</code> and define implicit deps for <code>babel/runtime</code> (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12011">#12011</a> Enable PnP linker on CI build job (<a href="https://github.com/JLHwung"><code>JLHwung</code></a>)</li> </ul> </li> </ul> <h4>Committers: 4</h4> <ul> <li>Babel Bot (<a href="https://github.com/babel-bot"><code>babel-bot</code></a>)</li> <li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>JLHwung</code></a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> <li>Zen (<a href="https://github.com/Zzzen"><code>Zzzen</code></a>)</li> </ul> <h2>v7.12.11 (2020-12-16)</h2> <p>Thanks <a href="https://github.com/vitorveiga"><code>vitorveiga</code></a> for your first PR!</p> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12366">#12366</a> Disallow non octal decimal escape before use strict (<a href="https://github.com/JLHwung"><code>JLHwung</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-plugin-transform-block-scoping</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11801">#11801</a> fix: handle block-level function declaration (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/10046">#10046</a>) (<a href="https://github.com/vitorveiga"><code>vitorveiga</code></a>)</li> </ul> </li> <li><code>babel-helper-builder-react-jsx-experimental</code>, <code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12493">#12493</a> Lazily inject imports to the JSX runtime (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-builder-react-jsx-experimental</code>, <code>babel-preset-react</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12495">#12495</a> Fixed issue with skipping over self & source generated by another instance (<a href="https://github.com/Andarist"><code>Andarist</code></a>)</li> </ul> </li> <li><code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/10862">#10862</a> Add js extension to preset-env generated polyfill imports (<a href="https://github.com/JLHwung"><code>JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helper-builder-react-jsx-experimental</code>, <code>babel-plugin-transform-react-jsx</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12479">#12479</a> Setup JSX runtime even if the file doesn't contain JSX (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-builder-react-jsx-experimental</code>, <code>babel-plugin-transform-react-jsx-development</code>, <code>babel-preset-react</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12475">#12475</a> Fixed a regression for multiple __self & __source props with classic runtime (<a href="https://github.com/Andarist"><code>Andarist</code></a>)</li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>babel/traverse's changelog</code></a>.</em></p> <blockquote> <h2>v7.12.12 (2020-12-23)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-plugin-transform-block-scoping</code>, <code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12530">#12530</a> skip discriminant when renamer starts from SwitchStatement. Closes <a href="https://github-redirect.dependabot.com/babel/babel/issues/12148">#12148</a> (<a href="https://github.com/Zzzen"><code>Zzzen</code></a>)</li> </ul> </li> <li><code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12521">#12521</a> Restore <code>babel/types</code> support for old TS versions (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-block-scoping</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12512">#12512</a> Fix annex B block function hoisting semantics (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-polyfill</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12541">#12541</a> Archive <code>babel/polyfill</code> (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-builder-react-jsx-experimental</code>, <code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12524">#12524</a> refactor: Move <code>react-jsx-development</code> implementation into <code>react-jsx</code> (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-fixtures</code>, <code>babel-helper-transform-fixture-test-runner</code>, <code>babel-plugin-proposal-async-generator-functions</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12130">#12130</a> Remove babel polyfill from fixture test runner (<a href="https://github.com/JLHwung"><code>JLHwung</code></a>)</li> </ul> </li> <li>Other <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12527">#12527</a> Update <code>release-tool</code> and define implicit deps for <code>babel/runtime</code> (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12011">#12011</a> Enable PnP linker on CI build job (<a href="https://github.com/JLHwung"><code>JLHwung</code></a>)</li> </ul> </li> </ul> <h2>v7.12.11 (2020-12-16)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12366">#12366</a> Disallow non octal decimal escape before use strict (<a href="https://github.com/JLHwung"><code>JLHwung</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-plugin-transform-block-scoping</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11801">#11801</a> fix: handle block-level function declaration (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/10046">#10046</a>) (<a href="https://github.com/vitorveiga"><code>vitorveiga</code></a>)</li> </ul> </li> <li><code>babel-helper-builder-react-jsx-experimental</code>, <code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12493">#12493</a> Lazily inject imports to the JSX runtime (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-builder-react-jsx-experimental</code>, <code>babel-preset-react</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12495">#12495</a> Fixed issue with skipping over self & source generated by another instance (<a href="https://github.com/Andarist"><code>Andarist</code></a>)</li> </ul> </li> <li><code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/10862">#10862</a> Add js extension to preset-env generated polyfill imports (<a href="https://github.com/JLHwung"><code>JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helper-builder-react-jsx-experimental</code>, <code>babel-plugin-transform-react-jsx</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12479">#12479</a> Setup JSX runtime even if the file doesn't contain JSX (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-builder-react-jsx-experimental</code>, <code>babel-plugin-transform-react-jsx-development</code>, <code>babel-preset-react</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12475">#12475</a> Fixed a regression for multiple __self & __source props with classic runtime (<a href="https://github.com/Andarist"><code>Andarist</code></a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12510">#12510</a> Improve AST node definitions in babel/types (<a href="https://github.com/zxbodya"><code>zxbodya</code></a>)</li> </ul> </li> <li>Other <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12508">#12508</a> chore: always check yarn lock and dedupe during update (<a href="https://github.com/JLHwung"><code>JLHwung</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12480">#12480</a> Avoid force trailing comma on test files (<a href="https://github.com/JLHwung"><code>JLHwung</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12462">#12462</a> Run e2e tests also with BABEL_8_BREAKING (<a href="https://github.com/nicolo-ribaudo"><code>nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-react-display-name</code>, <code>babel-plugin-transform-react-jsx</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12502">#12502</a> Reorganize some JSX-related tests (<a href="https://github.com/Andarist"><code>Andarist</code></a>)</li> </ul> </li> <li><code>babel-standalone</code>, <code>babel-types</code></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
35fe336537 |
Bump console-feed from 3.1.10 to 3.2.1 in /desktop (#1862)
Summary: Bumps [console-feed](https://github.com/samdenty99/console-feed) from 3.1.10 to 3.2.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/samdenty99/console-feed/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/1862 Reviewed By: passy Differential Revision: D26047359 Pulled By: mweststrate fbshipit-source-id: de6735949589ea7d319dd2f48f78d3d89bb4ab47 |
||
|
dependabot[bot]
|
802edb9749 |
Bump @types/which from 1.3.2 to 2.0.0 in /desktop (#1860)
Summary: Bumps [types/which](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/which) from 1.3.2 to 2.0.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/which">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/1860 Reviewed By: passy Differential Revision: D26047347 Pulled By: mweststrate fbshipit-source-id: 7a9549468273f69112ca5986e1dedc65c5e43068 |
||
John Knox
|
3e911c8288 |
Add option to cold boot emulators
Summary: This is useful when your emulator freezes. Reviewed By: mweststrate Differential Revision: D25998579 fbshipit-source-id: 236c16c3008f0e33d62e4c486b5a04383b1a59ba |
||
|
Michel Weststrate
|
d77940a839 |
Don't require an app in Flipper specific support questions
Summary: Changelog: Submitting a bug report to Flipper itself no longer requires to have an app connected Reviewed By: jknoxville Differential Revision: D26046284 fbshipit-source-id: d86ba7668c4187629752a9c27d63209af61bda13 |
||
|
Michel Weststrate
|
e5232da402 |
make sure Dropdown.Button uses flex like Button
Summary: Button fills out by default in Ant design if used in a flex container. Dropdown.Button doesn't do so. With this change Reviewed By: jknoxville Differential Revision: D26045409 fbshipit-source-id: 593b767aa7e38a98c8887b426f36fe41cb41bfd3 |
||
|
Michel Weststrate
|
12e59afdc6 |
Remove non-Sandy UI
Summary: This removes the Non-Sandy UI from the Flipper codebase. It is a pretty rough scan for unused components, over time when converting more advanced components to Ant design probably even more code can be removed. Partially used `npx ts-purge` to reveal never imported source files. Changelog: It is no longer possible to opt out of the new Sandy UI Reviewed By: jknoxville Differential Revision: D25825282 fbshipit-source-id: 9041dbc7e03bce0760c9a0a34f1877851b5f06cf |
||
|
Michel Weststrate
|
ba74b074c2 |
Fix employee detection in OSS version
Summary: Changelog: Fix incorrect warning in OSS builds hinting to install a closed source build. Fixes #1853 Reviewed By: passy Differential Revision: D26019227 fbshipit-source-id: 61a0270997d0aa67d55224e4f6268ed3103099c7 |
||
|
Anton Nikolaev
|
592d4b9227 |
Pass release channel when checking for update
Summary: Retrieve updated version in accordance to the currently selected release channel. Also changed message for "insiders" channel - removed mention of fbsource pinning. Reviewed By: mweststrate Differential Revision: D26011703 fbshipit-source-id: 7f3396e89db047cb24b4e00b224f79ca0fd64327 |
||
|
Anton Nikolaev
|
8ce69975a5 |
Re-enable asar and unpack PortForwardingMacApp
Summary: Enabled asar packaging for Flipper resources, and set PortForwardingMacApp as unpacked from it, because it is launched as external app. Reviewed By: passy Differential Revision: D26006771 fbshipit-source-id: 91c8401a469a390144bf9867996a66d754ea90e6 |
||
|
Michel Weststrate
|
ab31ad69e9 |
Fix keyboard events to incorrectly listen / propagate globally
Summary: As reported in https://fb.workplace.com/groups/flippersupport/permalink/1033379297142728/, using keyboard shortcuts in one component, can change the state of another. This was caused by two problems: 1. ManagedTable established a global keyboard listener, rather than a local one 2. The Layout Inspector did not stop its keyboard events from propagating up in the DOM This diff fixes both issues Reviewed By: timur-valiev Differential Revision: D26018248 fbshipit-source-id: 23d9cc38ad56d47213cb553ffaf528b05fbe1929 |
