jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't require an app in Flipper specific support questions

Browse Source 
Summary: Changelog: Submitting a bug report to Flipper itself no longer requires to have an app connected

Reviewed By: jknoxville

Differential Revision: D26046284

fbshipit-source-id: d86ba7668c4187629752a9c27d63209af61bda13
This commit is contained in:
Michel Weststrate
2021-01-25 06:40:20 -08:00
committed by Facebook GitHub Bot
parent e5232da402
commit d77940a839
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
desktop/app/src/reducers/supportForm.tsx
View File

@@ -99,14 +99,16 @@ export class Group {
// OS validation
let osError: string | null = null;
if (!selectedOS) {
osError = 'Please select an app from the drop down.';
} else if (!this.supportedOS.includes(selectedOS)) {
osError = `The group ${
this.name
} supports exports from ${this.supportedOS.join(
', ',
)}. But your selected device's OS is ${selectedOS}, which is unsupported.`;
if (this.name !== 'Flipper') {
if (!selectedOS) {
osError = 'Please select an app from the drop down.';
} else if (!this.supportedOS.includes(selectedOS)) {
osError = `The group ${
this.name
} supports exports from ${this.supportedOS.join(
', ',
)}. But your selected device's OS is ${selectedOS}, which is unsupported.`;
}
}
return {plugins: str, os: osError};
}