Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/872
Move all the JS code related to desktop app to "desktop" subfolder.
The structure of "desktop" folder:
- `src` - JS code of Flipper desktop app executing in Electron Renderer (Chrome) process. This folder also contains all the Flipper plugins in subfolder "src/plugins".
- `static` - JS code of Flipper desktop app bootstrapping executing in Electron Main (Node.js) process
- `pkg` - Flipper packaging lib and CLI tool
- `doctor` - Flipper diagnostics lib and CLI tool
- `scripts` - Build scripts for Flipper desktop app
- `headless` - Headless version of Flipper app
- `headless-tests` - Integration tests running agains Flipper headless version
Reviewed By: passy
Differential Revision: D20249304
fbshipit-source-id: 9a51c63b51b92b758a02fc8ebf7d3d116770efe9
Summary: Just had two minutes to kill during a rebase.
Reviewed By: mweststrate
Differential Revision: D20439168
fbshipit-source-id: f4054d5a3f9d78ca9efeba9d6b5a7cd84dc207bd
Summary:
I need a diff to test launcher stuff. Might as well do something
useful.
Reviewed By: mweststrate
Differential Revision: D20439124
fbshipit-source-id: a9799126c3545e544910e7caf3e9c31a975b66db
Summary:
This diff
1. Fixes an reported issue where a concurrent running standalone React Devtools results in Flipper not connecting with a clear message
2. Improves the Error UI so that it is more clear what is happening
3. Introduces a Retry button that can be smashed to retrigger the whole initialization sequence, including retrying to grab the port needed for the connection
Reviewed By: jknoxville
Differential Revision: D20439911
fbshipit-source-id: f37a47f1000dd3b049dae8503856f6015cd422ab
Summary: Make the logic to find the static file path reusable
Reviewed By: passy
Differential Revision: D20219731
fbshipit-source-id: a4f1fa021ea958681a078cb103621322bbfc1e48
Summary: Change compiler flag "-Wno-unguarded-availability" to "-Wunguarded-availability" in order to make build time safety check for unsafe newly introduced api without guarding it with available conditional.
Reviewed By: priteshrnandgaonkar
Differential Revision: D20335903
fbshipit-source-id: b4b0e492a9244233f1bc3b5ba2a63c6415c92bb4
Summary:
## The dependency [immer](https://github.com/immerjs/immer) was updated from `5.3.6` to `6.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [aleclarson](https://www.npmjs.com/~aleclarson)
**License:** MIT
<details>
<summary>Release Notes for v6.0.0</summary>
<h1><a href="https://urls.greenkeeper.io/immerjs/immer/compare/v5.3.6...v6.0.0">6.0.0</a> (2020-03-03)</h1>
<ul>
<li>Merge pull request <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="566542863" data-permission-text="Title is private" data-url="https://github.com/immerjs/immer/issues/536" data-hovercard-type="pull_request" data-hovercard-url="/immerjs/immer/pull/536/hovercard" href="https://urls.greenkeeper.io/immerjs/immer/pull/536">https://github.com/facebook/flipper/issues/536</a> from immerjs/multi-bundle (<a href="0d87fc88e8">0d87fc8</a>), closes <a href="https://urls.greenkeeper.io/immerjs/immer/issues/536" data-hovercard-type="pull_request" data-hovercard-url="/immerjs/immer/pull/536/hovercard">https://github.com/facebook/flipper/issues/536</a></li>
</ul>
<h3>BREAKING CHANGES</h3>
<ul>
<li>Support for ES5, patches and Map/Set collections has to be <em>explicitly</em> enable now: <a href="https://immerjs.github.io/immer/docs/installation" rel="nofollow">https://immerjs.github.io/immer/docs/installation</a></li>
<li>Custom serialization hooks are no longer supported</li>
</ul>
<p>feat: Adding large data sets to a draft has been optimized (in case autofreeze is disabled)</p>
</details>
<details>
<summary>Commits</summary>
<p>The new version differs by 41 commits.</p>
<ul>
<li><a href="0d87fc88e8"><code>0d87fc8</code></a> <code>Merge pull request https://github.com/facebook/flipper/issues/536 from immerjs/multi-bundle</code></li>
<li><a href="d676e61b63"><code>d676e61</code></a> <code>removed notes file</code></li>
<li><a href="3cfd62103b"><code>3cfd621</code></a> <code>backported new API's</code></li>
<li><a href="0d7f883067"><code>0d7f883</code></a> <code>Merge pull request https://github.com/facebook/flipper/issues/541 from phryneas/typesversions-compat</code></li>
<li><a href="f215409d2e"><code>f215409</code></a> <code>Merge branch 'multi-bundle' into typesversions-compat</code></li>
<li><a href="5f86272a3a"><code>5f86272</code></a> <code>Fixed entry point</code></li>
<li><a href="b94c34fc81"><code>b94c34f</code></a> <code>Merge pull request https://github.com/facebook/flipper/issues/544 from delanni/patch-1</code></li>
<li><a href="30e0f54d30"><code>30e0f54</code></a> <code>Add section about using classes with immer</code></li>
<li><a href="e6c3f13479"><code>e6c3f13</code></a> <code>stricter compression</code></li>
<li><a href="7a38af91d2"><code>7a38af9</code></a> <code>unclassed scope</code></li>
<li><a href="cb3b9d6839"><code>cb3b9d6</code></a> <code>Processed some todo's</code></li>
<li><a href="895e0cc9f8"><code>895e0cc</code></a> <code>Updated docs</code></li>
<li><a href="edb1cad865"><code>edb1cad</code></a> <code>Renamed utils dir</code></li>
<li><a href="db1652018a"><code>db16520</code></a> <code>Tests for plugins</code></li>
<li><a href="ab49edc11c"><code>ab49edc</code></a> <code>Moving files into folders</code></li>
</ul>
<p>There are 41 commits in total.</p>
<p>See the <a href="21c1597f17...0d87fc88e8">full diff</a></p>
</details>
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/853
Reviewed By: passy
Differential Revision: D20303311
Pulled By: mweststrate
fbshipit-source-id: ba6ab68246144c858490fbffca8bcff641b930ad
Summary: Adding the new "Identity" section to CK components' description.
Reviewed By: cuva
Differential Revision: D19948738
fbshipit-source-id: cbd9bc9c77b6f6503e10cfc75581ef4b94dd0247
Summary:
This diff updates the podfile.lock and also updates all the dependencies in the lfs. Actually we don't need all the dependencies to be reuploaded in the lfs, but current script packs everythin in Pods folder and uploads it, I will upload the logic to look for the diff and only upload the changed dependencies.Also we can merge this logic in our release script. I will put this up in later diffs.
Right now the CK folks are stuck due to the release of CK dependency and their OSS job is failing and this should fix the failing oss-ios job on diff D19948738
Reviewed By: Andrey-Mishanin
Differential Revision: D20378076
fbshipit-source-id: 56ed996cd75fba77a15e7264f9e5c27b262f00d2
Summary:
Our SC release job failed when submitting directly from the prepare-release script, as the jf context wasn't properly setup. So instead we reuse the code we already have for that in SandcastleFlipperAutoReleaseCommand.
However, for manual releases we still do submit automatically and in name of the current user.
Reviewed By: passy
Differential Revision: D20384247
fbshipit-source-id: ed5eca180f009611f2890f8cb665bf203789d189
Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.119.0` to `0.119.1`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [jbrown215](https://www.npmjs.com/~jbrown215)
**License:** MIT
[Find out more about this release](https://github.com/flowtype/flow-bin).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/842
Reviewed By: cekkaewnumchai
Differential Revision: D20303393
Pulled By: passy
fbshipit-source-id: b08d88b3b24db8e041a06e9e64d8442efc64eb6d
Summary:
Node on SandCastle is ancient, this change makes sure we can use the node version of `www`.
Node 6 can't parse dangling comma's in argument lists, which is what prettier automatically inserts by fbsource standards
Reviewed By: passy
Differential Revision: D20366026
fbshipit-source-id: 1b2a0c1506e8671fa268fab7a8d3bfcd5064bb0b
Summary:
* Followed plan of D20221558
* Manually bumped Flipper version on iOS to 0.33.1, which contains https://github.com/facebook/flipper/pull/874/files (make Flipper compatible with iOS 9).
* Will submit a PR on RN to bump the iOS template
Reviewed By: passy
Differential Revision: D20361824
fbshipit-source-id: 4f013b731b40e2d4f941742f9201bf2bb4382ec3
Summary:
In line with, https://github.com/facebook/flipper/pull/874/files, the package should promote itself as iOS 9.0 compatibe, to prevent errors and warnings like:
```
mweststrate-mbp:ios mweststrate$ pod install
Detected React Native module pod for react-native-flipper
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
Fetching podspec for `Folly` from `../node_modules/react-native/third-party-podspecs/Folly.podspec`
Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec`
[!] CocoaPods could not find compatible versions for pod "react-native-flipper":
In Podfile:
react-native-flipper (from `../node_modules/react-native-flipper`)
Specs satisfying the `react-native-flipper (from `../node_modules/react-native-flipper`)` dependency were found, but they required a higher minimum deployment target.
```
```
mweststrate-mbp:ios mweststrate$ pod install
Detected React Native module pod for react-native-flipper
Analyzing dependencies
Downloading dependencies
Installing react-native-flipper 0.33.1
Generating Pods project
Integrating client project
Pod installation complete! There are 34 dependencies from the Podfile and 38 total pods installed.
[!] The platform of the target `ReactNativeFlipperExample` (iOS 9.0) may not be compatible with `react-native-flipper (0.33.1)` which has a minimum requirement of iOS 10.0.
[!] The platform of the target `ReactNativeFlipperExampleTests` (iOS 9.0) may not be compatible with `react-native-flipper (0.33.1)` which has a minimum requirement of iOS 10.0.
mweststrate-mbp:ios mweststrate$ cd ..
mweststrate-mbp:ReactNativeFlipperExample
```
Reviewed By: passy
Differential Revision: D20362156
fbshipit-source-id: 766d033f2ea2e5559a72a3473115bc4a470a284f
Summary: Yesterday's script failed if prepare-release was invoked from another dir
Reviewed By: jknoxville
Differential Revision: D20362093
fbshipit-source-id: a0ce877a2f145f320cf346dc86e3d2568279b8b9
Summary:
## There have been updates to the *react* monorepo:
- The `dependency` [react](https://github.com/facebook/react) was updated from `16.12.0` to `16.13.0`.
- The `dependency` [react-dom](https://github.com/facebook/react) was updated from `16.12.0` to `16.13.0`.
- The `dependency` [react-test-renderer](https://github.com/facebook/react) was updated from `16.12.0` to `16.13.0`.
These versions are **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
This monorepo update includes releases of one or more dependencies which all belong to the [react group definition](https://github.com/greenkeeperio/monorepo-definitions).
---
**Publisher:** [threepointone](https://www.npmjs.com/~threepointone)
**License:** MIT
[Find out more about this release](https://github.com/facebook/react).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/843
Reviewed By: mweststrate
Differential Revision: D20303301
Pulled By: passy
fbshipit-source-id: 3d2a65d6b85e5a451ba41a4ae17532887a83e240
Summary: This makes the changelog generating part of the bump-version process, rather than the build-release
Reviewed By: passy
Differential Revision: D20284211
fbshipit-source-id: f4a5c9bdb98c91f11a216957c9d5175c4b64fe70
Summary:
React Native v0.62.0’s template still uses iOS 9 as deployment target, bumping it to 10 this late in the release cycle is probably not a good idea, so instead I made this tiny change to make it iOS 9 compatible again.
⚠️ I made this change on top of the `v0.32.2` **tag**, as `master` was giving me a build failure and in any case it would be better to release _just_ this change as a patch release so the RN `v0.62.0-rc.3` release can go out without having to test Flipper as thoroughly again.
## Changelog
Make FlipperKit compatible with iOS 9 again.
Pull Request resolved: https://github.com/facebook/flipper/pull/874
Test Plan:
- `pod install` with a Podfile that has iOS 9 as its deployment target passes again.
- Building the Flipper Sample works.
- Building with a RN application created with the `v0.62.0-rc.3` template works.
Reviewed By: priteshrnandgaonkar
Differential Revision: D20307073
Pulled By: passy
fbshipit-source-id: 0dd02dfb810b7382c52ca81b8f1322f807fb3f29
Summary:
This diff adds the ability to run iOS tests without doing pod install in sandcastle. For this, the repo will already have the dependencies archived and checked into the repo. For this I have already added the script, `recreate_offline_mirrors` which takes the first argument, which is the sample app's name, in our case it will be `Sample` and `SampleSwift`. There is one more script `prepare_pods` which untars the dependencies and copies it into the Pods folders.
Reason we are moving away from using `pod install` is that internet is unreliable in sandcastle and there have been many instances that the job fails due to flaky internet.
Reviewed By: passy
Differential Revision: D20136440
fbshipit-source-id: 41028c11da6c66b484f36c7d1090ac7ffd847ec2
Summary:
## The dependency [p-map](https://github.com/sindresorhus/p-map) was updated from `3.0.0` to `4.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [sindresorhus](https://www.npmjs.com/~sindresorhus)
**License:** MIT
<details>
<summary>Release Notes for v4.0.0</summary>
<h3>Breaking</h3>
<ul>
<li>Require Node.js 10 <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="bf03769576/hovercard" href="bf03769576"><tt>bf03769</tt></a></li>
</ul>
<h3>Improvements</h3>
<ul>
<li>Ensure <code>concurrency</code> option is an integer <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="b342717a9c/hovercard" href="b342717a9c"><tt>b342717</tt></a></li>
</ul>
<p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/p-map/compare/v3.0.0...v4.0.0"><tt>v3.0.0...v4.0.0</tt></a></p>
</details>
<details>
<summary>Commits</summary>
<p>The new version differs by 5 commits.</p>
<ul>
<li><a href="a4b4dec459"><code>a4b4dec</code></a> <code>4.0.0</code></li>
<li><a href="b342717a9c"><code>b342717</code></a> <code>Ensure <code>concurrency</code> is an integer</code></li>
<li><a href="bf03769576"><code>bf03769</code></a> <code>Require Node.js 10</code></li>
<li><a href="f8ccb4e778"><code>f8ccb4e</code></a> <code>Tidelift tasks</code></li>
<li><a href="ed1b661ae9"><code>ed1b661</code></a> <code>Fix test race condition (https://github.com/facebook/flipper/issues/21)</code></li>
</ul>
<p>See the <a href="a8c06732e4...a4b4dec459">full diff</a></p>
</details>
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/865
Reviewed By: mweststrate
Differential Revision: D20303303
Pulled By: passy
fbshipit-source-id: a5c553e559d28f32e2254a9dfa7a19069e39e9fb
Summary:
## The dependency [p-map](https://github.com/sindresorhus/p-map) was updated from `3.0.0` to `4.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [sindresorhus](https://www.npmjs.com/~sindresorhus)
**License:** MIT
<details>
<summary>Release Notes for v4.0.0</summary>
<h3>Breaking</h3>
<ul>
<li>Require Node.js 10 <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="bf03769576/hovercard" href="bf03769576"><tt>bf03769</tt></a></li>
</ul>
<h3>Improvements</h3>
<ul>
<li>Ensure <code>concurrency</code> option is an integer <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="b342717a9c/hovercard" href="b342717a9c"><tt>b342717</tt></a></li>
</ul>
<p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/p-map/compare/v3.0.0...v4.0.0"><tt>v3.0.0...v4.0.0</tt></a></p>
</details>
<details>
<summary>Commits</summary>
<p>The new version differs by 5 commits.</p>
<ul>
<li><a href="a4b4dec459"><code>a4b4dec</code></a> <code>4.0.0</code></li>
<li><a href="b342717a9c"><code>b342717</code></a> <code>Ensure <code>concurrency</code> is an integer</code></li>
<li><a href="bf03769576"><code>bf03769</code></a> <code>Require Node.js 10</code></li>
<li><a href="f8ccb4e778"><code>f8ccb4e</code></a> <code>Tidelift tasks</code></li>
<li><a href="ed1b661ae9"><code>ed1b661</code></a> <code>Fix test race condition (https://github.com/facebook/flipper/issues/21)</code></li>
</ul>
<p>See the <a href="a8c06732e4...a4b4dec459">full diff</a></p>
</details>
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/864
Reviewed By: mweststrate
Differential Revision: D20303306
Pulled By: passy
fbshipit-source-id: 0de6df2e1a9f907c88cad30f70ff35d6af0f328b
Summary:
Original diff broke OSS flipper. Need a new OSS release of CK first
Original commit changeset: 3e7564b25610
Reviewed By: kfirapps
Differential Revision: D20304743
fbshipit-source-id: 08a56359a42bc56b576d212e7cf642197a064076
Summary: Use `component.className` in sonar for the layout inspector.
Reviewed By: kfirapps
Differential Revision: D20184486
fbshipit-source-id: 3e7564b2561016ee59f3b1fc9d21313e068bacb3
Summary:
`build --mac` no longer implies building the DMG so the upload step currently fails.
Pull Request resolved: https://github.com/facebook/flipper/pull/869
Reviewed By: mweststrate
Differential Revision: D20283002
Pulled By: passy
fbshipit-source-id: c255ae3a7e4e006e198b79ad8ce79cfd5e80b6a3
Summary:
This seems to only encourage snark. I've yet to see this being used productively.
Pull Request resolved: https://github.com/facebook/flipper/pull/871
Reviewed By: mweststrate
Differential Revision: D20283096
Pulled By: passy
fbshipit-source-id: 1f5d8553505eb41ef8d4000e55cacf510e46949b
Summary:
We're no longer building this internally because it requires a Mac to build and we only use it in OSS.
Pull Request resolved: https://github.com/facebook/flipper/pull/852
Reviewed By: mweststrate
Differential Revision: D20250521
Pulled By: passy
fbshipit-source-id: c1691c62b2db3bc22cb0231040f593a35ec4f17e
Summary:
The script introduced here finds the last auto released diff in the history, and scans all diffs in between, in the `xplat/sonar` directory for `CHANGELOG: `entries.
Didn't make a distinction between internal and external commits at this point, as plugins are moving to their independent release process, in which case we have to revisit this anyway, and this will probably not result in too much noise.
Will perform some additional tests to see everything works out nicely with the release process, and post instructions in UI Tools group and wiki once this has landed.
(lol, meta:)
CHANGELOG: Flipper will now generate a changelog during release
Reviewed By: passy
Differential Revision: D20190698
fbshipit-source-id: e3b87cd986a17873c06b5f97b2ebffaf197ed0bf
Summary: ts-jest is unhappy with us using an old version. Let's bump it.
Reviewed By: mweststrate
Differential Revision: D20191204
fbshipit-source-id: d6ed4ad9bf20c4011ae9be1048a116ddc5ee6028
Summary:
There's a lot going on here:
- I'm moving over to android build hosts. They're are faster and more plentiful. They seem to work just fine for what we do. We already have a tenant capacity for them. *Edit:* Even more importantly, we need `adb` for certain tasks. The Android SDK isn't installed on Lego.
- I'm splitting our `sandcastle_setup` up into a pure yarn setup and an electron setup. The latter downloads from LFS and installs Wine (on Linux) which takes some time. This isn't needed unless we actually run Electron. That's for builds and Electron tests only.
- There were so, so many weird little edge cases. One of them is that `electron-builder`'s `app-builder` (a go app) switches between an x86 and an x86_64 version of wine to use for signing Windows apps, but only on Mac. On Linux it's hard-coded to 32bits. So we need to manually override the binary in the cache. I do this in the script rather in the cache because this is impossible to remember when upgrading.
- Wine is only bundled for Mac. On Linux you have to get it somewhere else. Luckily, we run as root, so we can do that.
- `$HOME` is set to `/var/twscsvc` which isn't owned by `root` but by `twscsvc`. Wine no happy. So we have to manually set this to a path that `root` owns. Hence the `export HOME`.
Reviewed By: nikoant
Differential Revision: D20223753
fbshipit-source-id: 0b2b09d19409ce172f395a7d1f85ec601654c6f6
Summary:
This works now with the Electron update. Wine doesn't work there so the app signing step needs to be disabled. I'm not entirely sure if this has other consequences than disabling signing - which we don't use.
We also can't build `.dmg`s on Linux because it relies on a CLI tool that only exists on Macs. But we can quite easily move this to GitHub Actions, which I set up with https://github.com/facebook/flipper/pull/852
Reviewed By: nikoant
Differential Revision: D20160545
fbshipit-source-id: a888c8b0e8f7dbe8bec818d57f5f22bcf800322c
Summary:
The target selector was broken on iOS. The overlay view which has the gesture recognizer, was never added to the window, due to which the gestures were not registered and the feature broke.
This diff adds the overlay view in the window object as the subview and then discards it in its view descriptor as otherwise we will capture all our touches in this view.
This was the most popular bug in our research trip and almost everyone reported it.
Reviewed By: fabiomassimo
Differential Revision: D20225594
fbshipit-source-id: af4041859d7e662152b2575d1eb258dd0c2d990e
