79997f2b3872d4cb34584614cd18fbd7b86298bf
3719 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Chaiwat Ekkaewnumchai
|
79997f2b38 |
Change Template
Summary: Flipper reads metadata to show on the sidebar from `package.json` and static fields (`id`, `title`, and `icon`) from `FlipperPlugin` class. If there are fields declared in both file, `FlipperPlugin` class takes precedences. With Sandy (new Flipper plugin API), there is no static field available. In order to prevent unexpected scenario happening when migrating to Sandy, this codemod-ish is applied to plugins that contain static field. The static fields are merged into `package.json` to get the same result. In addition, the static fields are also removed. Reviewed By: mweststrate Differential Revision: D22411822 fbshipit-source-id: 3f22e3537f22f01d2d0208980e12da48c85d64f6 |
||
|
Chaiwat Ekkaewnumchai
|
9e83e93662 |
Move Static Fields to package.json: reactdevtools
Summary: Flipper reads metadata to show on the sidebar from `package.json` and static fields (`id`, `title`, and `icon`) from `FlipperPlugin` class. If there are fields declared in both file, `FlipperPlugin` class takes precedences. With Sandy (new Flipper plugin API), there is no static field available. In order to prevent unexpected scenario happening when migrating to Sandy, this codemod-ish is applied to plugins that contain static field. The static fields are merged into `package.json` to get the same result. In addition, the static fields are also removed. Reviewed By: mweststrate Differential Revision: D22411845 fbshipit-source-id: b6f043e74358a9a66d5d466a17252820d712b71c |
||
|
Chaiwat Ekkaewnumchai
|
8e7089fb4c |
Move Static Fields to package.json: navigation
Summary: Flipper reads metadata to show on the sidebar from `package.json` and static fields (`id`, `title`, and `icon`) from `FlipperPlugin` class. If there are fields declared in both file, `FlipperPlugin` class takes precedences. With Sandy (new Flipper plugin API), there is no static field available. In order to prevent unexpected scenario happening when migrating to Sandy, this codemod-ish is applied to plugins that contain static field. The static fields are merged into `package.json` to get the same result. In addition, the static fields are also removed. Reviewed By: mweststrate Differential Revision: D22411856 fbshipit-source-id: 491d93fbe6393a7e9eded91208fdd71990402bb9 |
||
|
Chaiwat Ekkaewnumchai
|
288feafb25 |
Move Static Fields to package.json: kaios-allocations
Summary: Flipper reads metadata to show on the sidebar from `package.json` and static fields (`id`, `title`, and `icon`) from `FlipperPlugin` class. If there are fields declared in both file, `FlipperPlugin` class takes precedences. With Sandy (new Flipper plugin API), there is no static field available. In order to prevent unexpected scenario happening when migrating to Sandy, this codemod-ish is applied to plugins that contain static field. The static fields are merged into `package.json` to get the same result. In addition, the static fields are also removed. Reviewed By: eleweek Differential Revision: D22411839 fbshipit-source-id: efce530bb25def9a10ba8d85c48b31ee8657daa7 |
||
|
Chaiwat Ekkaewnumchai
|
f7e7131a7b |
Move Static Fields to package.json: hermesdebuggerrn
Summary: Flipper reads metadata to show on the sidebar from `package.json` and static fields (`id`, `title`, and `icon`) from `FlipperPlugin` class. If there are fields declared in both file, `FlipperPlugin` class takes precedences. With Sandy (new Flipper plugin API), there is no static field available. In order to prevent unexpected scenario happening when migrating to Sandy, this codemod-ish is applied to plugins that contain static field. The static fields are merged into `package.json` to get the same result. In addition, the static fields are also removed. Reviewed By: rickhanlonii Differential Revision: D22411862 fbshipit-source-id: cb381261f575313110b781c2fddd3a2099e6479a |
||
Pritesh Nandgaonkar
|
2ce65c1b3c |
Solve the issue where the bottom view of Sidebar was pushed down
Summary: This fixes the issue raised [here](https://fb.workplace.com/groups/flippersupport/permalink/911822855965040/). Reviewed By: nikoant Differential Revision: D22411617 fbshipit-source-id: ca1078bf418532863823fb3748e9edea4526cbc2 |
||
dependabot[bot]
|
8c33c17bbc |
Bump eslint-plugin-import from 2.19.1 to 2.22.0 in /desktop (#1336)
Summary: Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.19.1 to 2.22.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md">eslint-plugin-import's changelog</a>.</em></p> <blockquote> <h2>[2.22.0] - 2020-06-26</h2> <h3>Added</h3> <ul> <li>[<code>no-unused-modules</code>]: consider exported TypeScript interfaces, types and enums (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1819">#1819</a>, thanks [<a href="https://github.com/nicolashenry">nicolashenry</a>])</li> <li>[<code>no-cycle</code>]: allow <code>maxDepth</code> option to be <code>"∞"</code> (thanks [<a href="https://github.com/ljharb">ljharb</a>])</li> </ul> <h3>Fixed</h3> <ul> <li>[<code>order</code>]/TypeScript: properly support <code>import = object</code> expressions (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1823">#1823</a>, thanks [<a href="https://github.com/manuth">manuth</a>])</li> <li>[<code>no-extraneous-dependencies</code>]/TypeScript: do not error when importing type from dev dependencies (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1820">#1820</a>, thanks [<a href="https://github.com/fernandopasik">fernandopasik</a>])</li> <li>[<code>default</code>]: avoid crash with <code>export =</code> (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1822">#1822</a>, thanks [<a href="https://github.com/AndrewLeedham">AndrewLeedham</a>])</li> <li>[<code>order</code>]/[<code>newline-after-import</code>]: ignore TypeScript's "export import object" (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1830">#1830</a>, thanks [<a href="https://github.com/be5invis">be5invis</a>])</li> <li>[<code>dynamic-import-chunkname</code>]/TypeScript: supports <code>typescript-eslint/parser</code> (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1833">#1833</a>, thanks [<a href="https://github.com/noelebrun">noelebrun</a>])</li> <li>[<code>order</code>]/TypeScript: ignore ordering of object imports (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1831">#1831</a>, thanks [<a href="https://github.com/manuth">manuth</a>])</li> <li>[<code>namespace</code>]: do not report on shadowed import names (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/518">https://github.com/facebook/flipper/issues/518</a>, thanks [<a href="https://github.com/ljharb">ljharb</a>])</li> <li>[<code>export</code>]: avoid warning on <code>export * as</code> non-conflicts (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1834">#1834</a>, thanks [<a href="https://github.com/ljharb">ljharb</a>])</li> </ul> <h3>Changed</h3> <ul> <li>[<code>no-extraneous-dependencies</code>]: add tests for importing types (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1824">#1824</a>, thanks [<a href="https://github.com/taye">taye</a>])</li> <li>[docs] [<code>no-default-export</code>]: Fix docs url (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1836">#1836</a>, thanks [<a href="https://github.com/beatrizrezener">beatrizrezener</a>])</li> <li>[docs] [<code>imports-first</code>]: deprecation info and link to <code>first</code> docs (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1835">#1835</a>, thanks [<a href="https://github.com/beatrizrezener">beatrizrezener</a>])</li> </ul> <h2>[2.21.2] - 2020-06-09</h2> <h3>Fixed</h3> <ul> <li>[<code>order</code>]: avoid a crash on TypeScript’s <code>export import</code> syntax (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1808">#1808</a>, thanks [<a href="https://github.com/ljharb">ljharb</a>])</li> <li>[<code>newline-after-import</code>]: consider TypeScript <code>import =</code> syntax' (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1811">#1811</a>, thanks [<a href="https://github.com/ljharb">ljharb</a>])</li> <li>[<code>no-internal-modules</code>]: avoid a crash on a named export declaration (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1814">#1814</a>, thanks [<a href="https://github.com/ljharb">ljharb</a>])</li> </ul> <h2>[2.21.1] - 2020-06-07</h2> <h3>Fixed</h3> <ul> <li>TypeScript: [<code>import/named</code>]: avoid requiring <code>typescript</code> when not using TS (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1805">#1805</a>, thanks [<a href="https://github.com/ljharb">ljharb</a>])</li> </ul> <h2>[2.21.0] - 2020-06-07</h2> <h3>Added</h3> <ul> <li>[<code>import/default</code>]: support default export in TSExportAssignment (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1528">#1528</a>, thanks [<a href="https://github.com/joaovieira">joaovieira</a>])</li> <li>[<code>no-cycle</code>]: add <code>ignoreExternal</code> option (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1681">#1681</a>, thanks [<a href="https://github.com/sveyret">sveyret</a>])</li> <li>[<code>order</code>]: Add support for TypeScript's "import equals"-expressions (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1785">#1785</a>, thanks [<a href="https://github.com/manuth">manuth</a>])</li> <li>[<code>import/default</code>]: support default export in TSExportAssignment (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1689">#1689</a>, thanks [<a href="https://github.com/Maxim-Mazurok">Maxim-Mazurok</a>])</li> <li>[<code>no-restricted-paths</code>]: add custom message support (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1802">#1802</a>, thanks [<a href="https://github.com/malykhinvi">malykhinvi</a>])</li> </ul> <h3>Fixed</h3> <ul> <li>[<code>group-exports</code>]: Flow type export awareness (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1702">#1702</a>, thanks [<a href="https://github.com/ernestostifano">ernestostifano</a>])</li> <li>[<code>order</code>]: Recognize pathGroup config for first group (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1719">#1719</a>, <a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1724">#1724</a>, thanks [<a href="https://github.com/forivall">forivall</a>], [<a href="https://github.com/xpl">xpl</a>])</li> <li>[<code>no-unused-modules</code>]: Fix re-export not counting as usage when used in combination with import (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1722">#1722</a>, thanks [<a href="https://github.com/Ephem">Ephem</a>])</li> <li>[<code>no-duplicates</code>]: Handle TS import type (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1676">#1676</a>, thanks [<a href="https://github.com/kmui2">kmui2</a>])</li> <li>[<code>newline-after-import</code>]: recognize decorators (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1139">https://github.com/facebook/flipper/issues/1139</a>, thanks [<a href="https://github.com/atos1990">atos1990</a>])</li> <li>[<code>no-unused-modules</code>]: Revert "[flow] <code>no-unused-modules</code>: add flow type support" (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1770">#1770</a>, thanks [<a href="https://github.com/Hypnosphi">Hypnosphi</a>])</li> <li>TypeScript: Add nested namespace handling (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1763">#1763</a>, thanks [<a href="https://github.com/julien1619">julien1619</a>])</li> <li>[<code>namespace</code>]/<code>ExportMap</code>: Fix interface declarations for TypeScript (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1764">#1764</a>, thanks [<a href="https://github.com/julien1619">julien1619</a>])</li> <li>[<code>no-unused-modules</code>]: avoid order-dependence (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1744">#1744</a>, thanks [<a href="https://github.com/darkartur">darkartur</a>])</li> <li>[<code>no-internal-modules</code>]: also check <code>export from</code> syntax (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1691">#1691</a>, thanks [<a href="https://github.com/adjerbetian">adjerbetian</a>])</li> <li>TypeScript: [<code>export</code>]: avoid a crash with <code>export =</code> (<a href="https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1801">#1801</a>, thanks [<a href="https://github.com/ljharb">ljharb</a>])</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
a923c87ec9 |
Bump @babel/parser from 7.9.4 to 7.10.4 in /desktop (#1334)
Summary: Bumps [babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.9.4 to 7.10.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases">babel/parser's releases</a>.</em></p> <blockquote> <h2>v7.10.4 (2020-06-30)</h2> <p>Thanks <a href="https://github.com/penguingovernor">penguingovernor</a>, <a href="https://github.com/sajadtorkamani">sajadtorkamani</a> and <a href="https://github.com/wojtekmaj">wojtekmaj</a> for their first PRs!</p> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11669">#11669</a> Add <code>delete obj?.#x.a</code> support (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11652">#11652</a> fix: implement early errors for record and tuple (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11752">#11752</a> [regression] Don't validate file.comments in <code>babel/types</code> (<a href="https://github.com/nicolo-ribaudo">nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-do-expressions</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11724">#11724</a> fix: do-statementlist behavior (<a href="https://github.com/wlawt">wlawt</a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11722">#11722</a> Add better parser error when using jsx (<a href="https://github.com/penguingovernor">penguingovernor</a>)</li> </ul> </li> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11544">#11544</a> Refine babel core types (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-fixtures</code>, <code>babel-standalone</code>, <code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11758">#11758</a> Replace non-inclusive "whitelist" and "blacklist" terms with "allowlist" etc. (<a href="https://github.com/wojtekmaj">wojtekmaj</a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11376">#11376</a> Add babel/eslint-plugin-development-internal (<a href="https://github.com/kaicataldo">kaicataldo</a>)</li> </ul> </li> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11544">#11544</a> Refine babel core types (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>Committers: 7</h4> <ul> <li>Huáng Jùnliàng (<a href="https://github.com/JLHwung">JLHwung</a>)</li> <li>Jorge Henriquez (<a href="https://github.com/penguingovernor">penguingovernor</a>)</li> <li>Kai Cataldo (<a href="https://github.com/kaicataldo">kaicataldo</a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo">nicolo-ribaudo</a>)</li> <li>Simon Kotwicz (<a href="https://github.com/simonkotwicz">simonkotwicz</a>)</li> <li>William Law (<a href="https://github.com/wlawt">wlawt</a>)</li> <li>Wojciech Maj (<a href="https://github.com/wojtekmaj">wojtekmaj</a>)</li> </ul> <h2>v7.10.3 (2020-06-19)</h2> <p>Thanks <a href="https://github.com/AjayPoshak">AjayPoshak</a>, <a href="https://github.com/jessethomson">jessethomson</a>, <a href="https://github.com/sajadtorkamani">sajadtorkamani</a>, <a href="https://github.com/shaodahong">shaodahong</a> and <a href="https://github.com/wlawt">wlawt</a> for their first PRs!</p> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11676">#11676</a> Properly parse <code>export default from</code> when <code>exportDefaultFrom</code> is not enabled (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-proposal-optional-chaining</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11662">#11662</a> refactor: do not rely on AST extra properties in plugins (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-logical-assignment-operators</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11658">#11658</a> Perform NamedEvaluation of Anonymous Functions in Logical Assignment (<a href="https://github.com/jridgewell">jridgewell</a>)</li> </ul> </li> <li><code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-proposal-optional-chaining</code></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md">babel/parser's changelog</a>.</em></p> <blockquote> <h2>v7.10.4 (2020-06-30)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11669">#11669</a> Add <code>delete obj?.#x.a</code> support (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11652">#11652</a> fix: implement early errors for record and tuple (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11752">#11752</a> [regression] Don't validate file.comments in <code>babel/types</code> (<a href="https://github.com/nicolo-ribaudo">nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-do-expressions</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11724">#11724</a> fix: do-statementlist behavior (<a href="https://github.com/wlawt">wlawt</a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11722">#11722</a> Add better parser error when using jsx (<a href="https://github.com/penguingovernor">penguingovernor</a>)</li> </ul> </li> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11544">#11544</a> Refine babel core types (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-fixtures</code>, <code>babel-standalone</code>, <code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11758">#11758</a> Replace non-inclusive "whitelist" and "blacklist" terms with "allowlist" etc. (<a href="https://github.com/wojtekmaj">wojtekmaj</a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11376">#11376</a> Add babel/eslint-plugin-development-internal (<a href="https://github.com/kaicataldo">kaicataldo</a>)</li> </ul> </li> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11544">#11544</a> Refine babel core types (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h2>v7.10.3 (2020-06-19)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11676">#11676</a> Properly parse <code>export default from</code> when <code>exportDefaultFrom</code> is not enabled (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-proposal-optional-chaining</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11662">#11662</a> refactor: do not rely on AST extra properties in plugins (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-logical-assignment-operators</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11658">#11658</a> Perform NamedEvaluation of Anonymous Functions in Logical Assignment (<a href="https://github.com/jridgewell">jridgewell</a>)</li> </ul> </li> <li><code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-proposal-optional-chaining</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11623">#11623</a> fix: ensure (a?.b)() has proper this (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code>, <code>babel-plugin-transform-flow-comments</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11697">#11697</a> Fix innercomments (<a href="https://github.com/shaodahong">shaodahong</a>)</li> </ul> </li> <li><code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11703">#11703</a> fix:added check for forXstatement pattern (<a href="https://github.com/wlawt">wlawt</a>)</li> </ul> </li> <li><code>babel-template</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11695">#11695</a> Allow templates to parse v8intrinsics (<a href="https://github.com/jridgewell">jridgewell</a>)</li> </ul> </li> <li><code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11687">#11687</a> improve node type definitions to avoid any's in generated types (<a href="https://github.com/zxbodya">zxbodya</a>)</li> </ul> </li> <li><code>babel-plugin-transform-react-pure-annotations</code></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Anton Nikolaev
|
09269ddd58 |
Documented plugin release workflow
Summary: See title Reviewed By: jknoxville Differential Revision: D22410580 fbshipit-source-id: 79cc5cf1d2a04a2edf7695bdb0e3d16b38baaae9 |
||
|
dependabot[bot]
|
e2b2d13a41 |
Bump @algolia/client-search from 4.1.0 to 4.3.0 in /desktop (#1331)
Summary: Bumps [algolia/client-search](https://github.com/algolia/algoliasearch-client-javascript) from 4.1.0 to 4.3.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/algolia/algoliasearch-client-javascript/blob/master/CHANGELOG.md">algolia/client-search's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.2.0...4.3.0">v4.3.0</a></h2> <h2>Added</h2> <ul> <li><code>naturalLanguages</code> option type (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1147">https://github.com/facebook/flipper/issues/1147</a>)</li> <li><code>shouldStop</code> option to stop browse (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1029">https://github.com/facebook/flipper/issues/1029</a>)</li> <li><code>inner_queries</code> property to <code>getLogs</code> response (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1109">https://github.com/facebook/flipper/issues/1109</a>, <a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1166">https://github.com/facebook/flipper/issues/1166</a>)</li> <li><code>enablePersonalization</code> option to type <code>Settings</code> (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1151">https://github.com/facebook/flipper/issues/1151</a>)</li> </ul> <h2>Fixed</h2> <ul> <li>additional <code>clear</code>, <code>delete</code> & <code>deleteObject</code> types for the <code>.batch</code> method (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1149">https://github.com/facebook/flipper/issues/1149</a>)</li> <li>unhandled promise issue while using while using <code>accountCopyIndex</code> (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1154">https://github.com/facebook/flipper/issues/1154</a>)</li> <li>node requester unicode characters being corrupted on large responses (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1164">https://github.com/facebook/flipper/issues/1164</a>)</li> </ul> <h2><a href="https://github.com/algolia/algoliasearch-client-javascript/compare/4.1.0...4.2.0">v4.2.0</a></h2> <h3>Added</h3> <ul> <li>Improved <code>acl</code> property type in <code>GetApiKeyResponse</code> and <code>addApiKey</code> function param (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1126">https://github.com/facebook/flipper/issues/1126</a>)</li> <li>Improved <code>AnalyticsClientOptions</code> property type region (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1085">https://github.com/facebook/flipper/issues/1085</a>)</li> <li>Responses types can now be mutated (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1068">https://github.com/facebook/flipper/issues/1068</a>)</li> </ul> <h3>Fixed</h3> <ul> <li>Type <code>Log</code> (<a href="https://github-redirect.dependabot.com/algolia/algoliasearch-client-javascript/pull/1139">https://github.com/facebook/flipper/issues/1139</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
ddd42960e8 |
Bump @types/uuid from 7.0.0 to 8.0.0 in /desktop (#1335)
Summary: Bumps [types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) from 7.0.0 to 8.0.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid">compare view</a></li> </ul> </details> <br /> [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/1335 Reviewed By: mweststrate Differential Revision: D22409664 Pulled By: passy fbshipit-source-id: 0de34177f04f71b3e58de71027b37ccf4372e0c2 |
||
|
dependabot[bot]
|
29eb378b1a |
Bump flow-bin from 0.127.0 to 0.128.0 in /desktop (#1332)
Summary: Bumps [flow-bin](https://github.com/flowtype/flow-bin) from 0.127.0 to 0.128.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/flowtype/flow-bin/commits">compare view</a></li> </ul> </details> <br /> [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/1332 Reviewed By: nikoant Differential Revision: D22392634 Pulled By: passy fbshipit-source-id: 15659ba36e2973e17d10bd635771ea36465b9541 |
||
GitHub
|
8e43a06eac |
Automated: Update Podfile.lock (#1324)
Summary: This is an automated PR to update the Podfile.lock. - Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions. - Also make sure that all the dependencies are updated to the latest one. - This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request) Pull Request resolved: https://github.com/facebook/flipper/pull/1324 Reviewed By: mweststrate Differential Revision: D22389097 Pulled By: passy fbshipit-source-id: 54e4d43c85298f0e7929ce33ff67c3e2e2327a49 |
||
|
dependabot[bot]
|
3cffaaa9b7 |
Bump envinfo from 7.4.0 to 7.5.1 in /desktop (#1323)
Summary: Bumps [envinfo](https://github.com/tabrindle/envinfo) from 7.4.0 to 7.5.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/tabrindle/envinfo/releases">envinfo's releases</a>.</em></p> <blockquote> <h2>7.5.1</h2> <ul> <li>add support for edge on macOS</li> <li>add support for erlang</li> <li>fix package paths on windows</li> <li>fix crash on alpine linux</li> <li>fix --npmGlobalPackages on windows</li> <li>fix home directory replacement with ~</li> <li>fix rust version</li> <li>update example in docs</li> <li>remove unnecessary fs calls</li> <li>add unit tests</li> <li>add alpine to e2e tests</li> <li>add node 12 + 13 to e2e tests</li> </ul> <p>Thanks to these contributors for this release:</p> <ul> <li><a href="https://github.com/ryhinchey">ryhinchey</a></li> <li><a href="https://github.com/gengjiawen">gengjiawen</a></li> </ul> <h2>7.5.0</h2> <p>No release notes provided.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
97e0c8b442 |
Bump @babel/plugin-transform-flow-strip-types from 7.9.0 to 7.10.4 in /desktop (#1322)
Summary: Bumps [babel/plugin-transform-flow-strip-types](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-flow-strip-types) from 7.9.0 to 7.10.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases">babel/plugin-transform-flow-strip-types's releases</a>.</em></p> <blockquote> <h2>v7.10.4 (2020-06-30)</h2> <p>Thanks <a href="https://github.com/penguingovernor">penguingovernor</a>, <a href="https://github.com/sajadtorkamani">sajadtorkamani</a> and <a href="https://github.com/wojtekmaj">wojtekmaj</a> for their first PRs!</p> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11669">#11669</a> Add <code>delete obj?.#x.a</code> support (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11652">#11652</a> fix: implement early errors for record and tuple (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11752">#11752</a> [regression] Don't validate file.comments in <code>babel/types</code> (<a href="https://github.com/nicolo-ribaudo">nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-do-expressions</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11724">#11724</a> fix: do-statementlist behavior (<a href="https://github.com/wlawt">wlawt</a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11722">#11722</a> Add better parser error when using jsx (<a href="https://github.com/penguingovernor">penguingovernor</a>)</li> </ul> </li> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11544">#11544</a> Refine babel core types (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-fixtures</code>, <code>babel-standalone</code>, <code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11758">#11758</a> Replace non-inclusive "whitelist" and "blacklist" terms with "allowlist" etc. (<a href="https://github.com/wojtekmaj">wojtekmaj</a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11376">#11376</a> Add babel/eslint-plugin-development-internal (<a href="https://github.com/kaicataldo">kaicataldo</a>)</li> </ul> </li> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11544">#11544</a> Refine babel core types (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>Committers: 7</h4> <ul> <li>Huáng Jùnliàng (<a href="https://github.com/JLHwung">JLHwung</a>)</li> <li>Jorge Henriquez (<a href="https://github.com/penguingovernor">penguingovernor</a>)</li> <li>Kai Cataldo (<a href="https://github.com/kaicataldo">kaicataldo</a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo">nicolo-ribaudo</a>)</li> <li>Simon Kotwicz (<a href="https://github.com/simonkotwicz">simonkotwicz</a>)</li> <li>William Law (<a href="https://github.com/wlawt">wlawt</a>)</li> <li>Wojciech Maj (<a href="https://github.com/wojtekmaj">wojtekmaj</a>)</li> </ul> <h2>v7.10.3 (2020-06-19)</h2> <p>Thanks <a href="https://github.com/AjayPoshak">AjayPoshak</a>, <a href="https://github.com/jessethomson">jessethomson</a>, <a href="https://github.com/sajadtorkamani">sajadtorkamani</a>, <a href="https://github.com/shaodahong">shaodahong</a> and <a href="https://github.com/wlawt">wlawt</a> for their first PRs!</p> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11676">#11676</a> Properly parse <code>export default from</code> when <code>exportDefaultFrom</code> is not enabled (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-proposal-optional-chaining</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11662">#11662</a> refactor: do not rely on AST extra properties in plugins (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-logical-assignment-operators</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11658">#11658</a> Perform NamedEvaluation of Anonymous Functions in Logical Assignment (<a href="https://github.com/jridgewell">jridgewell</a>)</li> </ul> </li> <li><code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-proposal-optional-chaining</code></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md">babel/plugin-transform-flow-strip-types's changelog</a>.</em></p> <blockquote> <h2>v7.10.4 (2020-06-30)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11669">#11669</a> Add <code>delete obj?.#x.a</code> support (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11652">#11652</a> fix: implement early errors for record and tuple (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11752">#11752</a> [regression] Don't validate file.comments in <code>babel/types</code> (<a href="https://github.com/nicolo-ribaudo">nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-do-expressions</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11724">#11724</a> fix: do-statementlist behavior (<a href="https://github.com/wlawt">wlawt</a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11722">#11722</a> Add better parser error when using jsx (<a href="https://github.com/penguingovernor">penguingovernor</a>)</li> </ul> </li> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11544">#11544</a> Refine babel core types (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-fixtures</code>, <code>babel-standalone</code>, <code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11758">#11758</a> Replace non-inclusive "whitelist" and "blacklist" terms with "allowlist" etc. (<a href="https://github.com/wojtekmaj">wojtekmaj</a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11376">#11376</a> Add babel/eslint-plugin-development-internal (<a href="https://github.com/kaicataldo">kaicataldo</a>)</li> </ul> </li> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11544">#11544</a> Refine babel core types (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h2>v7.10.3 (2020-06-19)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11676">#11676</a> Properly parse <code>export default from</code> when <code>exportDefaultFrom</code> is not enabled (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-proposal-optional-chaining</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11662">#11662</a> refactor: do not rely on AST extra properties in plugins (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-logical-assignment-operators</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11658">#11658</a> Perform NamedEvaluation of Anonymous Functions in Logical Assignment (<a href="https://github.com/jridgewell">jridgewell</a>)</li> </ul> </li> <li><code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-proposal-optional-chaining</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11623">#11623</a> fix: ensure (a?.b)() has proper this (<a href="https://github.com/JLHwung">JLHwung</a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code>, <code>babel-plugin-transform-flow-comments</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11697">#11697</a> Fix innercomments (<a href="https://github.com/shaodahong">shaodahong</a>)</li> </ul> </li> <li><code>babel-helper-member-expression-to-functions</code>, <code>babel-plugin-proposal-class-properties</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11703">#11703</a> fix:added check for forXstatement pattern (<a href="https://github.com/wlawt">wlawt</a>)</li> </ul> </li> <li><code>babel-template</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11695">#11695</a> Allow templates to parse v8intrinsics (<a href="https://github.com/jridgewell">jridgewell</a>)</li> </ul> </li> <li><code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/11687">#11687</a> improve node type definitions to avoid any's in generated types (<a href="https://github.com/zxbodya">zxbodya</a>)</li> </ul> </li> <li><code>babel-plugin-transform-react-pure-annotations</code></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Anton Nikolaev
|
a2e77f5da0 |
Patch metro to avoid erasing "process" global var
Summary: Patch for "metro" to avoid erasing of "process" global var during bundling. Also removed "process" babel transform for main Electron process which was also made to workaround the same issue with "process" being erased. Reviewed By: mweststrate Differential Revision: D22389153 fbshipit-source-id: 569882e20534eedfca45509b8efe0186d335c681 |
||
Luc Oth
|
7c3d264803 |
ManagedTable: pass an innerRef to bypass debounceRender
Summary: The ref would point to the DebouncedComponent instead of the ManagedTable passing an innerRef and handling binding manually. Reviewed By: mweststrate Differential Revision: D22374912 fbshipit-source-id: d404931405939ef8bfbde31f9aec7d531a3b62e3 |
||
Pascal Hartig
|
51e7ce3566 |
Fragment sample test (#1328)
Summary: Wanted to have a way to test fragment support in open source for https://github.com/facebook/flipper/issues/1209. Stacked on https://github.com/facebook/flipper/issues/1327. Pull Request resolved: https://github.com/facebook/flipper/pull/1328 Test Plan:  Reviewed By: jknoxville Differential Revision: D22356283 Pulled By: passy fbshipit-source-id: 2ad84df0aae85634c8245e71f18b803ce8dd6ca0 |
||
|
Pascal Hartig
|
74c9f8ea33 |
Upgrade gradle and gradle plugin (#1327)
Summary: Android Studio is on 4.0 now, we need the plugin for proper support. Pull Request resolved: https://github.com/facebook/flipper/pull/1327 Test Plan: Synced and build with it. Reviewed By: nikoant Differential Revision: D22356268 Pulled By: passy fbshipit-source-id: 63c7b727e9a0eaaea7beed1f9819c1e2d15a0ff4 |
||
|
Anton Nikolaev
|
a8a16e24b3 |
Set exit code to 1 if script failed
Summary: Fixed scripts to return exit code 1 in case of error. Reviewed By: passy Differential Revision: D22357664 fbshipit-source-id: 1e067fe507e8f33cf21e70f3d15fd97175b9544e |
||
|
Anton Nikolaev
|
70b87b70c7 |
Fix standalone package build for unity plugins
Summary: Fixed error on building standalone packages for "unity" apps. The error was because "immer" imports were not transformed to use "immer" from Flipper bundle. Reviewed By: passy Differential Revision: D22357571 fbshipit-source-id: 590321f36208c9ed02d56d2c0c085c7cd1878018 |
||
Richard Zadorozny
|
91cccbe436 |
Sonar tag for skipping empty view groups in layout target mode
Summary: I think it's somewhat common to have large containers that can hold future views, especially fragments. The problem is the presence of these containers can block the layout inspector's "target" mode. I found out from cekkaewnumchai that Flipper does in fact return multiple results from the pick, but I think it could still be helpful to have this new tag since it is more convenient than having to do the secondary drill down each time. Reviewed By: jknoxville Differential Revision: D22284972 fbshipit-source-id: 1a2826ec746e4f31690db33ed72815ae168bffab |
||
Joao Alves
|
51e37311d0 |
Fix: Release builds on android (#1325)
Summary: After `react-native-flipper` 0.48.0 I cannot build releases on android (I think that passed on CI tests because the example was running an older version of this package, 0.47.0). So I moved all the `android/src/main` content to `android/src/debug` because we will not use Flipper in another Build Variant ## Changelog I moved all content from `react-native-flipper/android/src/main` to `react-native-flipper/android/src/debug`. Probably solves https://github.com/facebook/flipper/issues/1303 Pull Request resolved: https://github.com/facebook/flipper/pull/1325 Test Plan: Maybe create a custom CI script to verify if Flipper deps are present on Release Builds, [something like this](https://github.com/facebook/flipper/issues/1274#issue-641197153) Reviewed By: cekkaewnumchai Differential Revision: D22333432 Pulled By: passy fbshipit-source-id: 4abbab5ecbe08d44752b2138569ff60d25724087 |
||
|
Anton Nikolaev
|
228d09d572 |
Script for resolving plugin directory by its package name
Summary: Changed "build-plugin" script to allow triggering release by plugin name (required to enable triggering releases by button in Marketplace): 1) Added new script to resolve plugin dir by name 2) Allow passing either plugin dir or name to "build-plugin" script Reviewed By: passy Differential Revision: D22354643 fbshipit-source-id: b7aca57acefc81ca0b6d9c7f359f63d8f0599e39 |
||
Adam Ernst
|
b11082d229 |
Don't show accessibilityComponentAction in Flipper
Summary: This field is going to be removed in a subsequent version of the struct. Showing it is not that important, so let's just remove it. Reviewed By: kevin0571 Differential Revision: D22335170 fbshipit-source-id: 0916927ee30757678f847cd0f826caa1d4a6c7cc |
||
Kevin Lin
|
29c85e672b |
Rename CKComponentLayout to CKLayout
Summary: Rename `CKComponentLayout` to `CKLayout` #nocancel Reviewed By: adamjernst Differential Revision: D22332214 fbshipit-source-id: 8845f2b313e214cd7892199bf0c40341c88a595a |
||
Paco Estevez Garcia
|
d871ce0a04 |
Extract TouchOverlayView to new class
Summary: Before this diff, `TouchOverlayView` would be an inner non-static class,so it'd be difficult to track memory ownership for it. It also made `InspectorFlipperPlugin` longer and harder to read. Reviewed By: cekkaewnumchai Differential Revision: D22285744 fbshipit-source-id: 6fdd8c33a07be6ab900ebb28a8c3ebf3761fb598 |
||
|
Paco Estevez Garcia
|
c1d9527406 |
Fix potential nullable accesss
Summary:
While ramping up to Flipper I found this potential NPE caused by ordering issues.
There are only 3 uses downstream that don't use a constant that's part of the default initializer.
```
λ festevezga-mbp xplat → buck build sonar/android/src/main/java/com/facebook/flipper/plugins/inspector/... 2>&1 | rg ' = descriptorForClass' | awk '{$1=$1};1' | sort | uniq -c
5 NodeDescriptor descriptor = descriptorForClass(Object.class);
3 NodeDescriptor descriptor = descriptorForClass(View.class);
1 NodeDescriptor descriptor = descriptorForClass(node.getClass());
2 final NodeDescriptor descriptor = descriptorForClass(Dialog.class);
12 final NodeDescriptor descriptor = descriptorForClass(Fragment.class);
5 final NodeDescriptor descriptor = descriptorForClass(Object.class);
26 final NodeDescriptor descriptor = descriptorForClass(View.class);
2 final NodeDescriptor descriptor = descriptorForClass(Window.class);
1 final NodeDescriptor descriptor = descriptorForClass(node.getClass());
1 final NodeDescriptor descriptor = descriptorForClass(topChild.getClass());
2 final NodeDescriptor objectDescriptor = descriptorForClass(Object.class);
```
Reviewed By: muraziz
Differential Revision: D22284669
fbshipit-source-id: b41c8d78c70c5b5acdc08aa6f0e7afa681f4242d
|
||
Michel Weststrate
|
babc88e472 |
Convert Seammammals plugin to Sandy {emoji:1f389}
Summary: Converted the Seammammals plugin to use Sandy plugin infra (but the old components). Also updated lock file. Added unittests have been added as well. The UI snapshots in there are kinda overkill, but nice demo that it works. This completes the full roundtrip of the new Sandy infra, so this will be the last diff of this stack. I promise. I think. Reviewed By: nikoant Differential Revision: D22308265 fbshipit-source-id: 260e91a1951d486f6689880fe25281e80a71806a |
||
|
Michel Weststrate
|
581ddafd18 |
Fixed re-enabling a still selected plugin
Summary: While testing manually discovered the sandy plugin infra din't cover the case that a plugin can be selected but not enabled at the same time. Added test and fixed that. Reviewed By: nikoant Differential Revision: D22308597 fbshipit-source-id: 6cef2b543013ee81cee449396d523dd9a657ad1c |
||
|
Michel Weststrate
|
d16c6061c1 |
Introduce createState which can be used in components to propagate updates
Summary:
Introduced a minimal state abstraction so that state can be maintained in the plugin instance, but subscribe to by the UI.
At a later point we could pick an off the shelve solution like Recoil or MobX, or introduce cursors to read something deep etc etc, but for now that doesn't seem to be needed at all, and I think this will be pretty comprehensible for plugin authors (see also the 25th diff in this stack).
The api
```
createState(initialValue): Atom
Atom {
get() // returns current value
set(newValue) // sets a new value
update(draft => { }) // updates a complex value using Immer behind the scenes
}
// hook, subscribes to the updates of the Atom and always returns the current value
useValue(atom)
```
Reviewed By: nikoant
Differential Revision: D22306673
fbshipit-source-id: c49f5af85ae9929187e4d8a051311a07c1b88eb5
|
||
|
Michel Weststrate
|
159c0deaf1 |
Added usePlugin hooks
Summary: `usePlugin(pluginFactory)` returns the current plugin instance's api that was exposed by the plugin directory. Passing `pluginFactory` is technically strictly not needed, but having the user pass it, we can make sure it is strongly typed Reviewed By: nikoant Differential Revision: D22286293 fbshipit-source-id: 4268b6849b8cd3d524103de7eadbd6c0a65c7a61 |
||
|
Michel Weststrate
|
952e929699 |
Fix disabling a plugin nog clearing the message queue
Summary: While writing unit tests discovered a bug that disabling a plugin doesn't guarantee cleaning the messagequeues (both the buffer in client and the messagequeue reducer). Fixed that. That was thanks to @#%@#$@#%@ Redux a lot harder than it should be; as 'STAR_PLUGIN' reasons about a plugin + app name, while the message queue reducer would need to deduct the plugin keys from that, but it can't because that mapping is stored in the connections reducers. So I moved the `STAR_PLUGIN` action handling to the root reducer, sot that it can reason about the state of multiple reducers, which looked like the least of all evils. For more ranting about that and possible alternative solutions: https://twitter.com/mweststrate/status/1277556309706117122 Reviewed By: nikoant Differential Revision: D22284043 fbshipit-source-id: 35d0a8ba3a21a5959d2bb6ef17da3ff5077f48fd |
||
|
Michel Weststrate
|
bb0c8e0df0 |
Support receiving messages in Sandy plugins
Summary: This diffs adds the capability to listen to messages in Sandy plugins. Although API wise it looks more like the old `this.subscribe`, semantically it behaves like the `persistedStateReducer`; messages are queued if the plugin is enabled but not active. Reviewed By: nikoant Differential Revision: D22282711 fbshipit-source-id: 885faa702fe779ac8d593c1d224b2be13e688d47 |
||
|
Michel Weststrate
|
6c79408b0f |
Move plugin stats to their own file
Summary: Really nothing interesting to see here , just moved pluginStats out of messageQueue, as it started there and kept growing Reviewed By: nikoant Differential Revision: D22257318 fbshipit-source-id: 26be7efb4629fcef1b14de96a2b60f17f7d76785 |
||
|
Michel Weststrate
|
ec85dd5b01 |
Allow plugins to send messages
Summary: Sandy plugins can now send messages to plugins. The methods and params are strongly typed in implementation and unit tests, based on the <Methods> generic of FlipperClient. Reviewed By: nikoant Differential Revision: D22256972 fbshipit-source-id: 549523a402949b3eb6bb4b4ca160dedb5c5e722d |
||
|
Michel Weststrate
|
8b2d8498e6 |
Upgrade to TypeScript 3.9
Summary: Upgrading to TypeScript 3.9 so that we can use `// ts-expect-error`, that allows us to basically write unit tests for typings. Fixed the typescript path in `settings.json`, because otherwise VSCode kept picking the built-in version (3.8.3 atm) of ts when opening the `sonar` folder as workspace. Reviewed By: passy Differential Revision: D22255818 fbshipit-source-id: ae54aedb237445f32f1797b4290656dbfb0e528f |
||
|
Michel Weststrate
|
df6a8cd031 |
Provide initial plugin test infra for plugin devs
Summary: This sets up the initial infra that is to be used by plugin devs to test plugins. There is not much yet to see, as there is no state or message sending yet. But at least the life cycle of plugins can be test, things are strongly typed and everything is in the place where it should be :) N.b. the import difference with these utils and the createFlipperMock utilities in Flipper are 1. this testing infra is entirely inside flipper-plugin package, so that plugin devs don't need flipper as a dependency 2. this testing infra doesn't provide abstractions for plugin / device / client switching; it tests plugins purely in isolation of the rest of the world (except for firing `onConnect` / `onDisconnect` which is normally the effect of switching plugins) Reviewed By: nikoant Differential Revision: D22255262 fbshipit-source-id: b94ccbab720d2b49428a646aed3c55af71a5bc80 |
||
|
Michel Weststrate
|
c902a27bce |
Add Sandy to internal documentation
Summary: Scaffolded some internal Sandy notes and made them only internally available. Since most of the pipeline was already set up by jknoxville, it is unclear to me if something needs to be done to set up the auto redirect from fbflipper.com Reviewed By: jknoxville Differential Revision: D22233534 fbshipit-source-id: 4bdf5535f5745e7e4d335647759c6cf1b7cc73c6 |
||
|
Michel Weststrate
|
bde112bf85 |
Introduce onConnect / onDisconnect hooks
Summary: Introduced hooks that are called whenever the plugin is connected / disconnected to it's counter part on the device. There is some logic duplication between `PluginContainer` for old plugins, and `PluginRenderer` for new plugins, mostly caused by the fact that those lifecycles are triggered from the UI rather than from the reducers, but I figured refactoring that to be too risky. Reviewed By: jknoxville Differential Revision: D22232337 fbshipit-source-id: a384c45731a4c8d9b8b532a83e2becf49ce807c2 |
||
|
Michel Weststrate
|
dd0d957d8b |
Fix vscodeUtils make a request on every unit test run
Summary:
When running unit tests, every unit would try to make a graphql request (since promises always kick off immediately, even when not being awaited) and print an error. Fixed that by lazily choosing the preferred whatever it is.
Before:
{F241368814}
After:
(crickets)
Reviewed By: passy
Differential Revision: D22208422
fbshipit-source-id: b290d528d94dbed7ae867e07694d8d4cd85d8376
|
||
|
Michel Weststrate
|
f2c39aed55 |
Introduce PluginRenderer to render plugins
Summary: PluginContainer will now wrap Sandy plugins in PluginRenderer. PluginRenderer will also be used by plugin unit tests in the future Reviewed By: jknoxville Differential Revision: D22159359 fbshipit-source-id: 69f9c8f4bec9392022c1d7a14957f5aca0339d97 |
||
|
Michel Weststrate
|
ba01fa5bc9 |
Introduce onDestroy hook
Summary: This diff introduces the `onDestroy` hook that can be used by plugins to listen to the event where a plugin is cleaned up (either because it is disabled, or because the client is being cleaned up) Reviewed By: jknoxville Differential Revision: D22208121 fbshipit-source-id: 9c4951ae671be611f21da171c548d4054c481166 |
||
|
Michel Weststrate
|
04a29315e2 |
Remove instanceof checks
Summary: Replaced `instanceof` checks with `isSandyPlugin` utility. That is cleaner to read and makes it easier to find places where we make exceptions for Sandy plugins Reviewed By: jknoxville Differential Revision: D22206707 fbshipit-source-id: b44a1b585424f3b9bf0d7ce200c34107f03ed55e |
||
|
Michel Weststrate
|
1dc9e899b8 |
Make sure Sandy plugis can be initialized
Summary:
This diff makes sure sandy plugins are initialized.
Sandy plugins are stored directly in the client for two reasons
1. we want to decouple any plugin state updates from our central redux store, as redux is particularly bad in handling high frequency updates.
2. The lifecycle of a plugin is now bound to the lifecycle of a client. This means that we don't need 'persistedStore' to make sure state is preserved; that is now the default. Switching plugins will no longer reinitialize them (but only run specific hooks, see later diffs).
3. PersistedState will be introduced for sandy plugins as well later, but primarily for import / export / debug reasons.
A significant difference with the current persistent state, is that if a client crashes and reconnects, plugins will loose their state. We can prevent this (again, since state persisting will be reintroduced), but I'm not sure we need that for the specific reconnect scenario. Because
1. we should fix reconnecting clients anyway, and from stats it looks to happen less already
2. reconnects are usually caused by plugins that aggregate a lot of data and get slower over time. Restoring old state also restores those unstabilites.
For the overview bringing back the archi picture of earlier diff:
{F241508042}
Also fixed a bug where enabling background plugins didn't enable them on all devices with that app.
Reviewed By: jknoxville
Differential Revision: D22186276
fbshipit-source-id: 3fd42b577f86920e5280aa8cce1a0bc4d5564ed9
|
||
|
Michel Weststrate
|
bf79c9472e |
Always mock FBLogger during unit tests
Summary: Unit tests tend to randomly bail out once FBLogger is (indirectly) required by some module under test. This makes sure FBLogger is stubbed by default. We might want to do the same for `User` in the future. Reviewed By: jknoxville Differential Revision: D22186274 fbshipit-source-id: 2ede364c4b691d69826781355592226b075d8367 |
||
|
Michel Weststrate
|
83e6968fa1 |
cleaner test API
Summary: The test mock utilities now return a promise, rather than taking a callback, which makes tests slightly nicer to read (similar to react-testing-library). No semantic changes. Reviewed By: jknoxville Differential Revision: D22186278 fbshipit-source-id: ec5b9f4e6bfeee9160e331f8c20a1d4fdcbfeede |
||
|
Michel Weststrate
|
12ac29685d |
make sure plugins can be loaded into Flipper
Summary: Make sure Sandy plugins are loaded properly from disk Reviewed By: jknoxville Differential Revision: D22186275 fbshipit-source-id: fd2f560a7bed959b18e05db2a087909ad876ab9d |
||
|
Michel Weststrate
|
1029a6c97c |
Introduce types for Sandy plugins through code base
Summary:
So far there were 2 types of plugins: `FlipperPlugin` and `FlipperDevicePlugin`. This introduces a third kind: `SandyPluginDefinition`.
Unlike with the old plugins, the export of the module is not directly exposed as the plugin definition. Rather, we use class `SandyPluginDefinition` (instance) that holds a loaded definition and its meta data separately (`PluginDetails`). This means that we don't have to mix in and mutate loaded definitions, and that for unit tests we can avoid needing to provide a bunch of meta data. This also prevents a bunch of meta data existing on two places: on the loaded classes as static fields, and in the meta data field of the loaded class as well. Finally, we can now freely extends the `PluginDetails` interface in flipper, without needing to store it on the loaded classes and we are sure that no naming conflicts are caused by this in the future.
For compatibility with the existing code base, common fields are delegated from the `SandyPluginDefinition` class to the meta data.
Also cleaned up types around plugins a little bit and removed some unnecessary casts.
For all features that reason about plugins in general (such as exports), sandy plugins are ignored for now.
`SandyPluginInstance` is worked out in further diffs
The `instanceof` calls are replaced by a utility function in later diffs.
{F241363645}
Reviewed By: jknoxville
Differential Revision: D22091432
fbshipit-source-id: 3aa6b12fda5925268913779f3c3c9e84494438f8
|
||
|
Michel Weststrate
|
845c9b67f5 |
Read flipper-plugin from peer deps
Summary: To know whether plugins should be mounted with the old setup or new setup (with a Provided / context based api), we need to be able to recognize whether a plugin is written with the old or new setup. We do this by checking if the flipper-plugin dependency is declared as peer dependency. This we can to check for SDK compatibility as well. Reviewed By: jknoxville Differential Revision: D22043085 fbshipit-source-id: 21afabb6e58d86253a464470f4690c51cced87ab |
