Summary: Removing this information from the error as it will cause duplicated error tasks.
Reviewed By: passy
Differential Revision: D48646678
fbshipit-source-id: 26e5525318b4720568275a5086df00f21b7d2836
Summary:
This change adds the necessary scaffolding to enable deep-link for PWA.
1. Registers the protocol/scheme in the manifest.json
2. Add a skeleton handler that parses the received arguments
Notes for reviewers:
PWA cannot reuse the 'flipper://' scheme as is not allowed. PWA schemes are limited. The only extension point is 'web+...' which is the one that is used.
Reviewed By: antonk52
Differential Revision: D48562301
fbshipit-source-id: e191fcb1a6604d20a55c1acdadf6a8eb0194895b
Summary:
The sessionId is just uuid() which is held by the config. This changes moves that to a single place.
This achieves two goals:
1) Makes it very clear where is created and what value it holds
2) It allows us to know the sessionId even before the config is available. This becomes useful as we can start logging to Scribe earlier.
Reviewed By: passy
Differential Revision: D48601829
fbshipit-source-id: c54d86d76f0b58d2b59f8dd1c45d7f345c4a84c3
Summary:
This change replaces the existing logging infra with the one defined and exposed in flipper-server-core.
Functionality remains the same with the addition of having support for Scribe.
Reviewed By: aigoncharov
Differential Revision: D48515246
fbshipit-source-id: 7970f6ad069821ee4f15136adc8da40d0b1fb0c7
Summary:
Gets rid of
{F1074904830}
See D48603710 for some more information.
This patches the bundle which includes the reference to silence the error.
Changelog: No longer show importFile.worker.worker.js warning on startup
Reviewed By: lblasa
Differential Revision: D48605129
fbshipit-source-id: 20dc292191742400c8c390a75b1e53f11630ad5a
Summary: The one-off hack for slog makes this hard to refactor, so I've added a headers field, putting the caller in charge of this.
Reviewed By: LukeDefeo
Differential Revision: D48564065
fbshipit-source-id: f8e78e9b8597fd3131bf3741197e6179807ad5da
Summary: As the type is now defined in flipper-common, it can be used.
Reviewed By: antonk52
Differential Revision: D48557043
fbshipit-source-id: 3838a189e431718cd1438d2dad5d7034d34bb93b
Summary: It removes the ScribeLogger found in flipper-ui-core and also updates its references to point to the type defined in flipper-common.
Reviewed By: passy
Differential Revision: D48556328
fbshipit-source-id: 525d9e8ee9a80f68aecb8b8b2e25ffd4714649bd
Summary:
Given that we have to retry aggressively to fetch reduciton traces the blok augmentation can take a longer time. For cases like embedded bloks this can slow down the ui debugger even if you arent debuggin bloks. To avoid this we display the frame immediatley and then asynchronously augment it.
There is a possibility that you might see bloks bound tree nodes with no name briefly since this is this the state they come from the client as.
This isnt the ideal solution as the better way would be to do the unminification first and then add the derived components (which depends on reduction trace) after. This avoid this qurik but is a much bigger refactor so will do it another time if needed
Reviewed By: lblasa
Differential Revision: D48600897
fbshipit-source-id: 06fc5c5ecc6fe575f815d3ebca685f363275c84c
Summary: Use the visualiser as a reference for the event table
Reviewed By: antonk52
Differential Revision: D48562105
fbshipit-source-id: 8707efdcb0631e9716dd0a06e01518480ca2edc1
Summary: Now when entering framework event table from a tree root we filter that so you can see all tree events. Also we use exact matches to avoid and nasty substring bugs
Reviewed By: lblasa
Differential Revision: D48560169
fbshipit-source-id: 1df375a2b8c5035003d82c210b55adebda8bd4ec
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/5054
Reviewed By: ivanmisuno
Differential Revision: D48559248
Pulled By: passy
fbshipit-source-id: 8dc0741c63c43ed177769ce9e9bac46f40f3728a
Summary: There's nothing specific nor private about the ScribeLogger, so it is moved to flipper-common.
Reviewed By: LukeDefeo
Differential Revision: D48556074
fbshipit-source-id: aa9446036fd07fe6e6debc5a978a42308fc93fe0
Summary: The log tailer is already defined in flipper-common, use that instead.
Reviewed By: passy
Differential Revision: D48524909
fbshipit-source-id: 1c0674276f08893ea80dc2fc9f8b45679f33e93e
Summary: Log tailer is/could/will be used in different places, move to a centralised place.
Reviewed By: antonk52
Differential Revision: D48524579
fbshipit-source-id: 81d6c4670572284ba2821a93011f5daa133b21fa
Summary:
Session Id should be shared between client and server, but it was defined deep in the client (redux store).
The proposed solution presented below is to move the session id to the server configuration. By doing this, it becomes available to both server and client VERY early in the application life-cycle for both Electron and non-Electron builds.
Reviewed By: LukeDefeo
Differential Revision: D48520367
fbshipit-source-id: ca959b27ab18b1a2e4cd2fac1d28545664f1b514
Summary: The existing log message was quite verbose without really adding any value. Make it simpler by stripping out the client query.
Reviewed By: passy
Differential Revision: D48518212
fbshipit-source-id: f50d7a1ca8f9f6b440451022d60cf0f309c89634
Summary: IGSQLiteDatabaseDriver implements the DatabaseDriver protocol that is required to flipper send requests from desktop app to the client.
Differential Revision: D48172578
fbshipit-source-id: 09ac9415dd1b98c347984228def617f27d2e1aa0
Summary:
This diff fixes this compilation error that appear in the next diff (in case I don't fix it before).
```
Action failed: fbsource//xplat/sonar/iOS/Plugins/FlipperKitDatabasesPlugin:FlipperKitDatabasesPlugin (cxx_compile FlipperKitDatabasesPlugin/DatabasesManager.m (pic))
Local command returned non-zero exit code 1
Reproduce locally: `env -- "BUCK_SCRATCH_PATH=buck-out/v2/tmp/fbsource/4f538045b2fada5e/xplat/sonar/iOS/Plugins/FlipperK ...<omitted>... erKitDatabasesPlugin__/__dep_files_intermediaries__/FlipperKitDatabasesPlugin/DatabasesManager.m.pic (run `buck2 log what-failed` to get the full command)`
stdout:
stderr:
xplat/sonar/iOS/Plugins/FlipperKitDatabasesPlugin/FlipperKitDatabasesPlugin/DatabasesManager.m:121:57: error: implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
stringByAppendingString:exception.reason]];
^
xplat/sonar/iOS/Plugins/FlipperKitDatabasesPlugin/FlipperKitDatabasesPlugin/DatabasesManager.m:157:57: error: implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
stringByAppendingString:exception.reason]];
^
xplat/sonar/iOS/Plugins/FlipperKitDatabasesPlugin/FlipperKitDatabasesPlugin/DatabasesManager.m:191:57: error: implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
stringByAppendingString:exception.reason]];
^
3 errors generated.
```
Differential Revision: D48438432
fbshipit-source-id: acba91ec8e4fdab2c09a1e98387c203aa0d49489
Summary:
Electron-builder puts its results in a different directory, based on the architecture you build on.
While we don't have plans to release an arm64 build internally, we still need to support local builds for testing.
Without this, it fails with a rather confusing error message:
```
Script termnated. Error: spawn zip ENOENT
at Process.ChildProcess._handle.onexit (node:internal/child_process:283:19)
at onErrorNT (node:internal/child_process:476:16)
at processTicksAndRejections (node:internal/process/task_queues:82:21) {
errno: -2,
code: 'ENOENT',
syscall: 'spawn zip',
path: 'zip',
spawnargs: [ '-qyr9', '../Flipper-mac.zip', 'Flipper.app' ]
```
Reviewed By: lblasa
Differential Revision: D48517426
fbshipit-source-id: 21a133f8fce3aee0737ce5cbccc7a692a613b98e
Summary: Using substring doesnt make sense for these actions. As you say I want to filer on this cell but it includes many others
Reviewed By: aigoncharov
Differential Revision: D48515476
fbshipit-source-id: b7a77c022052bb33e2ce2a3f656dabab114d8a78
Summary: Leverages the new connection listener inside the ui debugger to send framework events out of the Litho debug api and to the UIDebugger
Reviewed By: adityasharat
Differential Revision: D48350647
fbshipit-source-id: 2af48578b70bc50da43712f244f2bd208ad40988
Summary: This lets you debug when events go off screen
Reviewed By: lblasa
Differential Revision: D48395787
fbshipit-source-id: 51a6eb74fa0f61c34f25e86a6ee40bf5969379ee
Summary: Lets you filter a nodes events by thread or type
Reviewed By: lblasa
Differential Revision: D48346955
fbshipit-source-id: 455d65ad21c54c5ad26782ac6a446f7ae15a4356
Summary: Its easier this way since this is how they come out of android internally, also a bit nicer to display the full string this way
Reviewed By: lblasa
Differential Revision: D48346954
fbshipit-source-id: 997dd3922159683fcdf4b5f5f288702a5d998dc4
Summary: Now when you click on an event the bottom bar appears automatically showing you every thing you need
Reviewed By: lblasa
Differential Revision: D48318694
fbshipit-source-id: 6505e439d949941dc0e091b9576d7d1321d8a05f
Summary: This was complaining about mixing shorthand and separete css attributes. Just use separate since its clearer
Reviewed By: passy
Differential Revision: D48315864
fbshipit-source-id: e73e76d7fb94b3d7bba36a34d408202bc91933be
Summary: The bottom panel got broken during the virtualisation+ panel refactor, we need to tell the tree how much height is taken by the panel so it can size itself accordingly.
Reviewed By: lblasa
Differential Revision: D48313766
fbshipit-source-id: 849886101eb0869cc068fd0ad6dc1d053233043e
Summary:
1. removed background hover
2. made can select actually work
3. disable user selection
4. remove decimal points from ms
Reviewed By: lblasa
Differential Revision: D48270181
fbshipit-source-id: 724efedb5cad7f93c80ed5dd7f49efe4c434c324
Summary:
Added new tree id to the framework event. Its currently optional.
The tree id is the parent component tree / tree manager this tree belongs to, this is so we can view all tree events at once in the table.
We ony show the context menu item when we have the tree root tag which is set for component tree only at this point. We can add for blok and ios later
Reviewed By: lblasa
Differential Revision: D48268120
fbshipit-source-id: 3dee06309b146a0392ca32fbb5e8231883b8439a
Summary: The linter otherwise wants us to remove `awaits` which are in fact required.
Reviewed By: lblasa
Differential Revision: D48467534
fbshipit-source-id: 355aee4bc22098086600b85edf58c8ed077b8aaf
Summary:
This isn't actionable and can't be deduplicated due to the device identifier.
Changelog: Don't report errors related to timeouts of background plugins
Reviewed By: lblasa
Differential Revision: D48467028
fbshipit-source-id: 94f32848962d8d3e3b1998a88f6f30a6cf86c4f6
Summary:
This updates minor and patch level dependencies. Frustratingly, I had to revert a bunch
of changes in that version range that still caused incompatibilities and test failures.
If I find time, I'll dig a bit deeper.
Reviewed By: ivanmisuno
Differential Revision: D48433210
fbshipit-source-id: 9ab12e774c1992d4f22cc1428d34f102ce820b75
