Summary:
Often fails with things like "can't resolve github.com" ... I don't think there's a fix for that apart from trying again.
Pull Request resolved: https://github.com/facebook/flipper/pull/2685
Test Plan: Waiting for things to turn green here.
Reviewed By: timur-valiev
Differential Revision: D30301456
Pulled By: passy
fbshipit-source-id: 585758284e18bd02ab2a905b6f110a32099b861e
Summary:
From the changelog:
> Removed the deprecated uploadArchives and installArchives tasks. Use publish and publishToMavenLocal instead.
Made the necessary changes to docs and scripts.
Reviewed By: nikoant
Differential Revision: D29752895
fbshipit-source-id: 6e96c7ea9b26be2acb40b9089cb361837ab10a1b
Summary:
This PR splits the linting of the flipperkit pods into different subspecs. This will fasten the overall validation time. Before, all the pods were validated in a serialised fashion, but now its done in a parallel way.
This brings down the total validation time from 2+ hrs to ~ 25mins
## Changelog
- Split the validation of the FlipperKit pod into parallelised subspecs
Pull Request resolved: https://github.com/facebook/flipper/pull/2540
Test Plan: https://github.com/facebook/flipper/actions/runs/986790548
Reviewed By: passy
Differential Revision: D29489716
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 55557c581d56ee01796ca64405cf78b647d2a68b
Summary:
This PR adds a script to publish pods. It handles different edge cases like:
- The version was already pushed but still you are trying to push it, it will skip in that case and give a proper message.
- This also makes sure that the same version Flipper pod exists before pushing FlipperKit.
- It also has the retry mechanism in place if at all the pod trunk push fails to push.
## Changelog
Updated the workflow to push pods
Pull Request resolved: https://github.com/facebook/flipper/pull/2511
Test Plan:
While pushing already published release:
https://github.com/facebook/flipper/actions/runs/974346766
While pushing new release:
https://github.com/facebook/flipper/actions/runs/978707041
Reviewed By: passy
Differential Revision: D29415078
Pulled By: priteshrnandgaonkar
fbshipit-source-id: f0fb68a2e399802e5719d7be4216d4a5ed6ef782
Summary:
This should take care of the build issue. It's an annoying caching issue that's been around for ages. Also why it didn't happen locally.
Pull Request resolved: https://github.com/facebook/flipper/pull/2432
Test Plan: GitHub CI
Reviewed By: mweststrate
Differential Revision: D28958707
Pulled By: passy
fbshipit-source-id: 8538f6616dec934d924c04713af93e7a6b89e617
Summary:
We missed that D28795384 (09951d505e) broke the Kotlin plugin until we got to
our Snapshot job. This makes sure we build all artifacts and get
signal on PRs.
Pull Request resolved: https://github.com/facebook/flipper/pull/2404
Test Plan:
CI
`./gradlew assembleDebug` failed correctly when applying the change.
Reviewed By: nikoant
Differential Revision: D28801494
Pulled By: passy
fbshipit-source-id: 704047ea17af632091c6597024ddacc9247255a9
Summary:
Per title
After landing this and verifying in CI, will apply those version bumps to RN itself: https://github.com/facebook/react-native/pull/31562, and remove the custom overrides in the future
Reviewed By: passy
Differential Revision: D28573552
fbshipit-source-id: e52c40f4751f933f17312aac2aacfd695f554a3f
Summary:
This diff updates and adds the boost ios podspec in flipper repo. This new boost dep works for Arm and i386 archs for simulator too.
This diff also updates our GH Action to remove i386 from excluded archs. Still arm64 is kept as non M1 mac machines do not have arm swift symbols for arm simulator. And since all our CI is on non M1, it is required.
It also takes care of https://github.com/facebook/flipper/issues/2268
## Changelog
- Update the boost dep
- Update the GH action
Pull Request resolved: https://github.com/facebook/flipper/pull/2341
Test Plan: CI
Reviewed By: mweststrate
Differential Revision: D28537004
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 474ccec674d0edf5fa7b792b15a326e0f139d977
Summary:
Updated to the latest version which apparently doesn't need a privileged token anymore, which would be good news.
Also updated the message to include a `[ci skip]` which instructs CircleCI not to run because we're having a chicken-and-egg-problem here with CircleCI otherwise needing a config to tell it not to run, otherwise it will run and fail because there's no config.
Pull Request resolved: https://github.com/facebook/flipper/pull/2342
Test Plan:
hopeitwork
Task: T91157540
Reviewed By: mweststrate
Differential Revision: D28539468
Pulled By: passy
fbshipit-source-id: 609c3fa1578e0506aadeb225c4e38ff53db67934
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2275
Forced all current pods to use the latest available. If this builds successfully, will create a PR against React Native so that they become the default, and remove them here again.
This job currently does limit the architectures we build for. Pritesh is investigating if we can wide that again, as this might not be acceptable to RN in general.
This doesn't bump the android version to 0.88, as the artifact publishing failed for that version, but since there are currently less problems with the Android version I wanted to go ahead with just iOS.
Reviewed By: cekkaewnumchai, priteshrnandgaonkar
Differential Revision: D28257283
fbshipit-source-id: a631b1c354617ed356cd1e74b9e8e8aa050eed60
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2271
Fix react native OSS build. As discussed a couple of weeks ago, we can bump deps, but cannot bump lock files during release, as artifacts are then not yet available.
We backed out from these bumps before D27764997 (98c3913b62), but that didn't seem to be sufficient. Filed T90301619 as follow up
Reviewed By: priteshrnandgaonkar
Differential Revision: D28255272
fbshipit-source-id: ee4d5b158a653c78f73b46c9ca695cfced315e56
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2245
This diff does the following:
- Updates Folly to the latest version.
- Updates boost to latest version and the boost is added as pre built artefact
- Updates RSocket to the latest version
- Updates ComponentKit to the latest version which has a fix for XCode 12.5
- Adds Flipper-Glog dependency updated with a fix for the issue mentioned [here](https://github.com/facebook/flipper/issues/2174)
- This diff also ensures that Flipper, FlipperKit builds with Sample and SampleSwift app.
- This diff also ensures that the bug mentioned [here](https://github.com/facebook/flipper/issues/2248) is addressed.
Note: For Tutorial App to work we will have to make a release of Flipper and FlipperKit to CococaPods. Because the tutorial app refers the released version of Flipper and FlipperKit. It doesn't refer it locally.
Reviewed By: passy
Differential Revision: D28058972
fbshipit-source-id: d45dfc7315ace5d5c7d3a4ba94911fd4b58bdc31
Summary:
This PR updates the Glog and DoubleConversion deps. Now the deps are shipped with precompiled xcframework. It will speed up our build time a bit.
The definition can be found [here for glog](https://github.com/priteshrnandgaonkar/glog/tree/update-0.3.5) and [here for double-conversion](https://github.com/priteshrnandgaonkar/double-conversion/)
There has been improvements in time. I will try to precompile folly to improve the timings significantly.
## Changelog
- Updated the Glog and DoubleConversion deps to the precompiled xcframework one
- Updated the sample app's Podfile.lock
Pull Request resolved: https://github.com/facebook/flipper/pull/2153
Test Plan:
- CI should be green
- Verified that sample app builds.
Reviewed By: mweststrate
Differential Revision: D27560567
Pulled By: priteshrnandgaonkar
fbshipit-source-id: ba295cbe84bb9d5ed6bd6ab17bd1cf5ea22f3cee
Summary:
The time we spend on this isn't much. However, we quite often see flakiness coming from yarnpkg not responding which should hopefully be addressed by this.
Pull Request resolved: https://github.com/facebook/flipper/pull/2137
Test Plan: CI
Reviewed By: mweststrate
Differential Revision: D27461679
Pulled By: passy
fbshipit-source-id: c7144d2a8426c078f9cab2d3a94662908a03a182
Summary:
Updates the run conditions of iOS jobs so that it is triggered when we change "Flipper.podspec" and "FlipperKit.podspec"
## Changelog
- Update the run conditions
Pull Request resolved: https://github.com/facebook/flipper/pull/2136
Test Plan: CI
Reviewed By: passy
Differential Revision: D27402914
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 3b687612f26a0e22773c48540b76a7660bb29ed6
Summary:
This PR updates the logic when these iOS jobs should be run. This change just makes it run for pushes to iOS folders and xplat c++ folders.
## Changelog
- Update the GH action.
Pull Request resolved: https://github.com/facebook/flipper/pull/2118
Test Plan: Note that no iOS job is run.
Reviewed By: mweststrate
Differential Revision: D27395681
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 37a7c2fb9b3fdfa22307ac5e7403364bfeb0a384
Summary:
Sample and SampleSwift directly link to the debug version and don't reference `flipperkit_version` which is why the script is failing.
Pull Request resolved: https://github.com/facebook/flipper/pull/2117
Test Plan: hopeitwork
Reviewed By: priteshrnandgaonkar
Differential Revision: D27395244
Pulled By: passy
fbshipit-source-id: 3485731b0489376fbdf987c082ef7d288f66bbe8
Summary:
Builds up a file with checksums of all `build.gradle` files. Deliberately excludes the `gradle.properties` which changes all the time. The cache shouldn't require nuking except in some rare circumstances.
Pull Request resolved: https://github.com/facebook/flipper/pull/1922
Test Plan: From 41 minutes down to 17: https://github.com/passy/flipper-1/actions/runs/561501374
Reviewed By: mweststrate
Differential Revision: D26427242
Pulled By: passy
fbshipit-source-id: ff1d7370d477c9d7b57c62082ec985108a5ba698
Summary:
This PR updates the flipperkit version of the Tutorial and updates the GH action to test it without the arch flag.
This PR also fixes the script which updates the `flipperkit_version` tag in all the files. It was broken for Tutorial, as it used to replace the last released version of the pod with the current one in each file, but for some reason the flipper version in the Tutorial/Podfile was way older and it never got updated.
I have fixed the logic now to replace the current version in the file with the new one, rather than relying on only last version to be replaced.
## Changelog
- Updated the GH action of tutorial to remove the -arch flag
- Updated Tutorial/Podfile and Podfile.lock
- Updated scripts/update-pod-versions.sh
Pull Request resolved: https://github.com/facebook/flipper/pull/1896
Test Plan:
CI should be green
Tested that the version gets updated for each and every file, file tested were Flipper.podspec, FlipperKit.podspec, Sample/Podfile SampleSwift/Podfile Tutorial/Podfile
{F369967362}
{F369967395}
Reviewed By: nikoant
Differential Revision: D26275657
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 0f21a2a33c740938d2b29624e95974e80a2e38ba
Summary:
Solves the sampleswift failing job, by removing the linker flags which were used when we relied on CocoaLibEvent, but now we do not rely on this.
## Changelog
- Removed cocoalib flag
- Removed arch requirement from the workflow for sample swift
If the flag is removed from the objc sample then I get the following error. It looks like for the objc project, xcode is not able to find the arm64 artifacts for swift deps.
I tried all the alternatives for solving this issue, but it didn't work for objc. I will wait for new xcode and will try with that, hopefully, the newer xcode has the fix.
```
ld: warning: Could not find or use auto-linked library 'swiftFoundation'
ld: warning: Could not find or use auto-linked library 'swiftMetal'
ld: warning: Could not find or use auto-linked library 'swiftUIKit'
ld: warning: Could not find or use auto-linked library 'swiftDarwin'
ld: warning: Could not find or use auto-linked library 'swiftObjectiveC'
ld: warning: Could not find or use auto-linked library 'swiftCoreFoundation'
ld: warning: Could not find or use auto-linked library 'swiftDispatch'
ld: warning: Could not find or use auto-linked library 'swiftCoreImage'
ld: warning: Could not find or use auto-linked library 'swiftCore'
ld: warning: Could not find or use auto-linked library 'swiftQuartzCore'
ld: warning: Could not find or use auto-linked library 'swiftCoreGraphics'
ld: warning: Could not find or use auto-linked library 'swiftSwiftOnoneSupport'
Undefined symbols for architecture arm64:
"protocol descriptor for Swift.ExpressibleByFloatLiteral", referenced from:
l_got.$ss25ExpressibleByFloatLiteralMp in libYogaKit.a(YGLayoutExtensions.o)
"associated type descriptor for Swift.ExpressibleByIntegerLiteral.IntegerLiteralType", referenced from:
l_got.$s18IntegerLiteralTypes013ExpressibleByaB0PTl in libYogaKit.a(YGLayoutExtensions.o)
"associated conformance descriptor for Swift.ExpressibleByIntegerLiteral.Swift.ExpressibleByIntegerLiteral.IntegerLiteralType: Swift._ExpressibleByBuiltinIntegerLiteral", referenced from:
l_got.$ss27ExpressibleByIntegerLiteralP0cD4TypeAB_s01_ab7BuiltincD0Tn in libYogaKit.a(YGLayoutExtensions.o)
"method descriptor for Swift.ExpressibleByFloatLiteral.init(floatLiteral: A.FloatLiteralType) -> A", referenced from:
l_got.$ss25ExpressibleByFloatLiteralP05floatD0x0cD4TypeQz_tcfCTq in libYogaKit.a(YGLayoutExtensions.o)
"protocol descriptor for Swift.ExpressibleByIntegerLiteral", referenced from:
l_got.$ss27ExpressibleByIntegerLiteralMp in libYogaKit.a(YGLayoutExtensions.o)
"value witness table for Builtin.Int32", referenced from:
full type metadata for __C.YGUnit in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftCoreImage", referenced from:
__swift_FORCE_LOAD_$_swiftCoreImage_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftCoreImage_$_YogaKit)
"associated type descriptor for Swift.ExpressibleByFloatLiteral.FloatLiteralType", referenced from:
l_got.$s16FloatLiteralTypes013ExpressibleByaB0PTl in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftQuartzCore", referenced from:
__swift_FORCE_LOAD_$_swiftQuartzCore_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftQuartzCore_$_YogaKit)
"__swift_FORCE_LOAD_$_swiftDispatch", referenced from:
__swift_FORCE_LOAD_$_swiftDispatch_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftDispatch_$_YogaKit)
"method descriptor for Swift.ExpressibleByIntegerLiteral.init(integerLiteral: A.IntegerLiteralType) -> A", referenced from:
l_got.$ss27ExpressibleByIntegerLiteralP07integerD0x0cD4TypeQz_tcfCTq in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftCoreFoundation", referenced from:
__swift_FORCE_LOAD_$_swiftCoreFoundation_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftCoreFoundation_$_YogaKit)
"protocol witness table for Swift.Int : Swift._ExpressibleByBuiltinIntegerLiteral in Swift", referenced from:
associated type witness table accessor for Swift.ExpressibleByIntegerLiteral.IntegerLiteralType : Swift._ExpressibleByBuiltinIntegerLiteral in __C.YGValue : Swift.ExpressibleByIntegerLiteral in YogaKit in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftObjectiveC", referenced from:
__swift_FORCE_LOAD_$_swiftObjectiveC_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftObjectiveC_$_YogaKit)
"__swift_FORCE_LOAD_$_swiftCoreGraphics", referenced from:
__swift_FORCE_LOAD_$_swiftCoreGraphics_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftCoreGraphics_$_YogaKit)
"_swift_getForeignTypeMetadata", referenced from:
type metadata accessor for __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
type metadata accessor for __C.YGUnit in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftFoundation", referenced from:
__swift_FORCE_LOAD_$_swiftFoundation_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftFoundation_$_YogaKit)
"associated conformance descriptor for Swift.ExpressibleByFloatLiteral.Swift.ExpressibleByFloatLiteral.FloatLiteralType: Swift._ExpressibleByBuiltinFloatLiteral", referenced from:
l_got.$ss25ExpressibleByFloatLiteralP0cD4TypeAB_s01_ab7BuiltincD0Tn in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftUIKit", referenced from:
__swift_FORCE_LOAD_$_swiftUIKit_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftUIKit_$_YogaKit)
"__swift_FORCE_LOAD_$_swiftMetal", referenced from:
__swift_FORCE_LOAD_$_swiftMetal_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftMetal_$_YogaKit)
"Swift.Float.init(Swift.Double) -> Swift.Float", referenced from:
static (extension in YogaKit):CoreGraphics.CGFloat.% postfix(CoreGraphics.CGFloat) -> __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
(extension in YogaKit):__C.YGValue.init(CoreGraphics.CGFloat) -> __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
"__swift_FORCE_LOAD_$_swiftDarwin", referenced from:
__swift_FORCE_LOAD_$_swiftDarwin_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftDarwin_$_YogaKit)
"protocol witness table for Swift.Float : Swift._ExpressibleByBuiltinFloatLiteral in Swift", referenced from:
associated type witness table accessor for Swift.ExpressibleByFloatLiteral.FloatLiteralType : Swift._ExpressibleByBuiltinFloatLiteral in __C.YGValue : Swift.ExpressibleByFloatLiteral in YogaKit in libYogaKit.a(YGLayoutExtensions.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
Pull Request resolved: https://github.com/facebook/flipper/pull/1893
Test Plan:
CI in github should be green
flipper-oss-ios-build works
https://www.internalfb.com/intern/sandcastle/job/22517998513117018/
Reviewed By: mweststrate
Differential Revision: D26254390
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 291cfb949e781ccb9e0317679daa673dcf8e9479
Summary:
This PR updates the OpenSSL pod and thus updates the corresponding Folly and RSocket pods. The new OpenSSL pod has a support of arm64 artifact for iPhomeSimulators.This PR also updates the replaces the libevent pod which didn't work with arm64 arch for iPhoneSimulator.
## Changelog
- Update OpenSSL pod
- Update Folly dep
- Update RSocket dep
- Replace Libevent pod.
Pull Request resolved: https://github.com/facebook/flipper/pull/1892
Test Plan: CI
Reviewed By: mweststrate
Differential Revision: D26229304
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 46256d9cd3e0cf5aab6e477e612c3bcb77e31627
Summary:
This PR adds github actions to validate the pods, so that the changes which breaks the validation is not made. This PR also downgrades the version update of OpenSSL, as it doesn't validate the Folly podspec. I have [raised](https://github.com/krzyzanowskim/OpenSSL/issues/113) an issue on the repository which manages the openssl dependency.
## Changelog
- Added githubaction for dependent pod validation
- Downgraded the openssl version, as with upgraded version the folly pod didn't validate.
Pull Request resolved: https://github.com/facebook/flipper/pull/1834
Test Plan: CI
Reviewed By: passy
Differential Revision: D25939525
Pulled By: priteshrnandgaonkar
fbshipit-source-id: f70d043f1f6b2c79028212d8f56c6b8632092e33
Summary:
This diff sets all package version to "0.0.0" except of the root package and changes the bump script to only bump version in the root package. This should reduce possibility of conflicts on release diffs. Anyway we always use the same version for all of our packages, so we can only set it to the root.
Before npm publishing we will set all package versions to the same number as in the root package (we actually already do that) so there will be no differences except we won't need to bump version in more than 100 packages each release.
Reviewed By: mweststrate
Differential Revision: D25162373
fbshipit-source-id: 02fe401bee72845339c67925c130027bdaee559d
Summary: Adds an action for publishing packages to npm. Secret was added as part of T80403944.
Reviewed By: nikoant
Differential Revision: D25195740
fbshipit-source-id: 51d43d9f5e84a25a67b637233b2c62a9a1a15063
Summary:
To make sure we're staying in sync with the internal version. Requires some more manual updating, but even if we do this every couple of months, it should be fine.
Pull Request resolved: https://github.com/facebook/flipper/pull/1719
Test Plan: CI
Reviewed By: nikoant
Differential Revision: D25195565
Pulled By: passy
fbshipit-source-id: 763a9d877a20659e91c8b77d0900b999e5f630d3
Summary:
I honestly don't know how the resolution works but it seems that we need
more than just one NDK.
Pull Request resolved: https://github.com/facebook/flipper/pull/1715
Test Plan: Let's hope this turns green.
Reviewed By: mweststrate
Differential Revision: D25170962
Pulled By: passy
fbshipit-source-id: dcdf25b5c77f08bdeceef50d924727cb0c9dcca9
Summary: This is suggested as a fix for the consistency issue (https://github.com/facebook/flipper/issues/1638) when interdependent packages published together and one of them cannot find another because it takes time to synchronise published packages to CDN. This fix is suggested here: https://github.com/CocoaPods/CocoaPods/issues/9497.
Reviewed By: mweststrate
Differential Revision: D25184732
fbshipit-source-id: d8d58b33f65ff7e87f935fb7cb85964dbf95dd13
Summary:
Honestly not sure what's causing the new NDK to be pulled in
but at least locally installing it fixes the failure we see here:
https://github.com/facebook/flipper/runs/1424681947
Pull Request resolved: https://github.com/facebook/flipper/pull/1693
Test Plan: Wait for the Actions on the PR
Reviewed By: nikoant
Differential Revision: D25093335
Pulled By: passy
fbshipit-source-id: e7af63fcf3c5270c869acc3d094234d15968aeda
Summary: Just a small mispelling in step specification
Reviewed By: mweststrate
Differential Revision: D25053437
fbshipit-source-id: 39e7c9c578a448495b92f8aa3632b2843d79490c
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1687
I cleaned up and tagged both of the custom actions.
It's much better to pin them down properly so that
future changes on `main` don't break anything.
Reviewed By: nikoant
Differential Revision: D24996462
fbshipit-source-id: 6d63e76b758439ba8df4ef2f5b77992789744e7b
Summary:
GitHub only issues one push event for multiple commits.
This causes things to behave weirdly. My action now
looks for a commit with a certain message and runs
the subsequent steps on it. If there's more than one
matching commit, it uses the last one. Not great, not terrible.
Pull Request resolved: https://github.com/facebook/flipper/pull/1678
Test Plan: Ran it on my fork: https://github.com/passy/flipper-1/actions/runs/360332680
Reviewed By: nikoant
Differential Revision: D24955986
Pulled By: passy
fbshipit-source-id: 6dcbe11e69bf77c803e3907ced3185ca85483ec8
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1673
XCode 12 starts building for apple hardware, but that fails on x86, so only build x86_64.
Reviewed By: nikoant
Differential Revision: D24857260
fbshipit-source-id: 30c0e021d4f809fd3a8ad72537a2627a43e589eb
Summary: Had the `PERSONAL_TOKEN` put in place by the OSS oncall. Still won't know if it has the right permissions until we run this. :/
Reviewed By: nikoant
Differential Revision: D24833829
fbshipit-source-id: 4fbf6e0b0abbc50d0b9a1e9b7ca8b02f6e1f5171
Summary:
No longer necessary as this is now taken care of by the new unified release Action.
Pull Request resolved: https://github.com/facebook/flipper/pull/1655
Test Plan: Next release, I'm afraid.
Reviewed By: nikoant
Differential Revision: D24782070
Pulled By: passy
fbshipit-source-id: 36ce0db814ad60fa04e4ed81b3657323bc5c983b
Summary:
Noticed that the icon download fails occasionally from GitHub.
This adds a few retries in case that happens.
Reviewed By: nikoant
Differential Revision: D24647690
fbshipit-source-id: 3ed84cb0972b7715fd87c8b1e1e1bca9f89485a9
Summary:
As part of our release confidence effort, this replaces the flaky internal task that creates the tag, promotes it to a release and uploads the artifacts to it.
Instead, we do all this in one lengthy GitHub Action. There seems to be some duplication here but this is because of the unfortunate restriction GitHub Actions imposes to avoid recursive Actions. I.e. we cannot create a tag/release and have another, independent Action pick up from there to do the building and releasing.
The `passy/` references were necessary because existing Actions didn't quite what we wanted to:
- `tag-version-commit` expected the title of the commit to match the precise tag to create. However, we want to use a regex to *extract* from the "Flipper Release: vA.B.C". My fork allows specifying a grouping regex for that.
- `github-upload-release-artifacts-action` relied on being triggered by a tag. As described above, that's not possible with this setup. Instead, this takes an existing tag and attaches to it.
Reviewed By: nikoant
Differential Revision: D24627518
fbshipit-source-id: 8121df6aa7bd36bda28e0d3cb207a002cd127647
