jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
9,047 Commits 1 Branch 0 Tags
683fbfd6fb34277cb5e4c901b3c3b907dd6a8881
Commit Graph

1130 Commits

Author SHA1 Message Date
Pascal Hartig
92f3ab8ff4 Improve error handling for iOSDevices 
Summary:
Adding context everywhere as naked messages are hard to track down
and making common errors like missing Xcode license agreements
a warning + error popup instead.

Changelog: Reduce spamminess of iOS connection warnings

Reviewed By: mweststrate

Differential Revision: D26370235

fbshipit-source-id: b283d297479c2bf76a11b5a3f96a59fad70a4a67
 2021-02-11 05:08:36 -08:00
Michel Weststrate
8d5f136a34 Fix active state reducer mutating existing state 
Summary:
This reducer was mutating existing state, which will throw since we freeze state to prevent exactly that. Fixed it by using a defensive copy.

Note that `newActiveNotifications` doesn't suffer from the same as it is freshly allocated.

See https://www.internalfb.com/intern/diffusion/FBS/browse/master/xplat/sonar/desktop/app/src/reducers/notifications.tsx?commit=29b592866b44&lines=160

Reviewed By: passy

Differential Revision: D26399200

fbshipit-source-id: 5f9f22db3de48f4f595a028faf9e9ec547641cfb
 2021-02-11 03:41:54 -08:00
Michel Weststrate
e9922746ed Fixed text of imported devices 
Summary: Noticed in the support group that the imported device label was incorrect. Probably a copy paste error.

Reviewed By: nikoant

Differential Revision: D26368664

fbshipit-source-id: abc2aad4d20a9f44d6f1ac45962ab28863d78f0d
 2021-02-10 08:38:23 -08:00
dependabot[bot]
054bfdb047 Bump antd from 4.11.2 to 4.12.2 in /desktop (#1909) 
Summary:
Bumps [antd](https://github.com/ant-design/ant-design) from 4.11.2 to 4.12.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.12.2</h2>
<ul>
<li>{emoji:1f484} Make Table expand icon and checkbox same size and aligned. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29214">#29214</a></li>
<li>{emoji:1f41e} Fix List with <code>gutter</code> makes column break line. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29211">#29211</a></li>
</ul>
<hr />
<ul>
<li>{emoji:1f484} 调整 Table 展开图标和选择框的大小一致并对齐。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29214">#29214</a></li>
<li>{emoji:1f41e} 修复 List 配置 <code>gutter</code> 时列会折行的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29211">#29211</a></li>
</ul>
<h2>4.12.1</h2>
<ul>
<li>{emoji:1f41e} Fix antd crash when load before page ready. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29202">#29202</a></li>
<li>{emoji:1f41e} Fix Table pagination <code>current</code> change logic when <code>pageSize</code> changes. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29184">#29184</a></li>
</ul>
<hr />
<ul>
<li>{emoji:1f41e} 修复 antd 在页面加载之前载入导致的页面崩溃问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29202">#29202</a></li>
<li>{emoji:1f41e} 修正 Table 改变 <code>pageSize</code> 重置 <code>current</code> 的逻辑，现在若超出会重置到最大页数。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29184">#29184</a></li>
</ul>
<h2>4.12.0</h2>
<ul>
<li>{emoji:1f195} Image.PreviewGroup add <code>current</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29153">#29153</a></li>
<li>InputNumber
<ul>
<li>{emoji:1f195} InputNumber support <code>bordered</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29105">#29105</a></li>
<li>{emoji:1f195} InputNumber add <code>keyboard</code> prop which could disable keyboard behavior. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29110">#29110</a> <a href="https://github.com/kerm1it"><code>kerm1it</code></a></li>
</ul>
</li>
<li>{emoji:1f484} Darken Tag text color to enhance readability. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29144">#29144</a></li>
<li>{emoji:1f484} Fix Row with vertical <code>gutter</code> provides additional <code>margin-bottom</code> style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29059">#29059</a></li>
<li>{emoji:1f41e} Fix Collapse header disappers with delay. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29158">#29158</a></li>
<li>{emoji:1f41e} Fix the problem that <code>showCount</code> display data is incorrect when TextArea input emoji. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29057">#29057</a> <a href="https://github.com/HomyeeKing"><code>HomyeeKing</code></a></li>
<li>{emoji:1f4e6} Optimize ConfigProvider to avoid import all icons when tree shaking is not enabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29045">#29045</a></li>
<li>{emoji:1f310} Add en-GB missing translations for table. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29131">#29131</a> <a href="https://github.com/eberjoe"><code>eberjoe</code></a></li>
<li>Table
<ul>
<li>{emoji:1f195} Table <code>showSorterTooltip</code> now could be a object for more configuration. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29002">#29002</a> <a href="https://github.com/harrisoff"><code>harrisoff</code></a></li>
<li>{emoji:26a1} Optimize calling sequence of <code>onChange</code> and <code>onSelectAll</code> in <code>rowSelection</code> of Table. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29079">#29079</a> <a href="https://github.com/kerm1it"><code>kerm1it</code></a></li>
</ul>
</li>
<li>Badge
<ul>
<li>{emoji:1f484} Fix Badge change <code>count</code> content to hide miss style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29089">#29089</a></li>
<li>{emoji:1f41e} Fix Badge digital animation problem. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29100">#29100</a></li>
</ul>
</li>
<li>TypeScript
<ul>
<li>� Table TS definition update <code>dataSource</code> to <code>readonly</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29084">#29084</a></li>
</ul>
</li>
<li>Less
<ul>
<li>{emoji:1f484} Add less variable <code>progress-info-text-color</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28981">#28981</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li>
</ul>
</li>
</ul>
<hr />
<ul>
<li>{emoji:1f195} Image.PreviewGroup 添加 <code>current</code> 属性支持受控模式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29153">#29153</a></li>
<li>InputNumber
<ul>
<li>{emoji:1f195} InputNumber 支持 <code>bordered</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29105">#29105</a></li>
<li>{emoji:1f195} InputNumber 添加 <code>keyboard</code> 属性以支持禁用键盘行为。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29110">#29110</a> <a href="https://github.com/kerm1it"><code>kerm1it</code></a></li>
</ul>
</li>
<li>{emoji:1f484} 加深 Tag 文字颜色以提升可读性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29144">#29144</a></li>
<li>{emoji:1f484} 修复 Row 配置垂直 <code>gutter</code> 时会额外添加 <code>margin-bottom</code> 样式的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29059">#29059</a></li>
<li>{emoji:1f41e} 修复 Collapse 标题区域隐藏延迟的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29158">#29158</a></li>
<li>{emoji:1f41e} 修复 TextArea 输入 emoji 时 <code>showCount</code> 展示数据不正确的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29057">#29057</a> <a href="https://github.com/HomyeeKing"><code>HomyeeKing</code></a></li>
<li>{emoji:1f4e6} 优化 ConfigProvider 在未开启 tree shaking 的项目中引入所有图标的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29045">#29045</a></li>
<li>{emoji:1f1ec_1f1e7} 为表格添加 <code>en-GB</code> 翻译。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29131">#29131</a> <a href="https://github.com/eberjoe"><code>eberjoe</code></a></li>
<li>Badge
<ul>
<li>{emoji:1f41e} 修复 Badge 的数字动画方向问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29100">#29100</a></li>
<li>{emoji:1f484} 修复 Badge 修改 <code>count</code> 内容以隐藏时的样式问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29089">#29089</a></li>
</ul>
</li>
<li>Table</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.12.2</h2>
<p><code>2021-02-04</code></p>
<ul>
<li>{emoji:1f484} Make Table expand icon and checkbox same size and aligned. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29214">#29214</a></li>
<li>{emoji:1f41e} Fix List with <code>gutter</code> makes column break line. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29211">#29211</a></li>
</ul>
<h2>4.12.1</h2>
<p><code>2021-02-03</code></p>
<ul>
<li>{emoji:1f41e} Fix antd crash when load before page ready. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29202">#29202</a></li>
<li>{emoji:1f41e} Fix Table pagination <code>current</code> change logic when <code>pageSize</code> changes. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29184">#29184</a></li>
</ul>
<h2>4.12.0</h2>
<p><code>2021-02-03</code></p>
<ul>
<li>{emoji:1f195} Image.PreviewGroup add <code>current</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29153">#29153</a></li>
<li>InputNumber
<ul>
<li>{emoji:1f195} InputNumber support <code>bordered</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29105">#29105</a></li>
<li>{emoji:1f195} InputNumber add <code>keyboard</code> prop which could disable keyboard behavior. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29110">#29110</a> <a href="https://github.com/kerm1it"><code>kerm1it</code></a></li>
</ul>
</li>
<li>{emoji:1f484} Darken Tag text color to enhance readability. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29144">#29144</a></li>
<li>{emoji:1f484} Fix Row with vertical <code>gutter</code> provides additional <code>margin-bottom</code> style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29059">#29059</a></li>
<li>{emoji:1f41e} Fix Collapse header disappers with delay. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29158">#29158</a></li>
<li>{emoji:1f41e} Fix the problem that <code>showCount</code> display data is incorrect when TextArea input emoji. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29057">#29057</a> <a href="https://github.com/HomyeeKing"><code>HomyeeKing</code></a></li>
<li>{emoji:1f4e6} Optimize ConfigProvider to avoid import all icons when tree shaking is not enabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29045">#29045</a></li>
<li>{emoji:1f310} Add en-GB missing translations for table. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29131">#29131</a> <a href="https://github.com/eberjoe"><code>eberjoe</code></a></li>
<li>Table
<ul>
<li>{emoji:1f195} Table <code>showSorterTooltip</code> now could be a object for more configuration. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29002">#29002</a> <a href="https://github.com/harrisoff"><code>harrisoff</code></a></li>
<li>{emoji:26a1} Optimize calling sequence of <code>onChange</code> and <code>onSelectAll</code> in <code>rowSelection</code> of Table. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29079">#29079</a> <a href="https://github.com/kerm1it"><code>kerm1it</code></a></li>
</ul>
</li>
<li>Badge
<ul>
<li>{emoji:1f484} Fix Badge change <code>count</code> content to hide miss style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29089">#29089</a></li>
<li>{emoji:1f41e} Fix Badge digital animation problem. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29100">#29100</a></li>
</ul>
</li>
<li>TypeScript
<ul>
<li>� Table TS definition update <code>dataSource</code> to <code>readonly</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29084">#29084</a></li>
</ul>
</li>
<li>Less
<ul>
<li>{emoji:1f484} Add less variable <code>progress-info-text-color</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28981">#28981</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li>
</ul>
</li>
</ul>
<h2>4.11.3</h2>
<p><code>2021-02-03</code></p>
<p>Wrong release is the same as <code>4.12.0</code>, if you need to lock the version, you need to lock it to <code>4.11.2</code>.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="eb557abeaa"><code>eb557ab</code></a> docs: 4.12.2 changelog (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/29223">#29223</a>)</li>
<li><a href="c56a434cca"><code>c56a434</code></a> ci: update verify trigger</li>
<li><a href="69a5be7c40"><code>69a5be7</code></a> docs: Update FAQ (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/29210">#29210</a>)</li>
<li><a href="f6683ebfc3"><code>f6683eb</code></a> style: make Table expand icon same size as checkbox (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/29214">#29214</a>)</li>
<li><a href="f434440bd1"><code>f434440</code></a> ci: update verify package version</li>
<li><a href="d5097a88e9"><code>d5097a8</code></a> Delete codeql-analysis.yml</li>
<li><a href="c1f5f19001"><code>c1f5f19</code></a> ci: add verify-package-version (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/29205">#29205</a>)</li>
<li><a href="a26e5036e6"><code>a26e503</code></a> fix: only row gutter use gap (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/29211">#29211</a>)</li>
<li><a href="1f7d200f70"><code>1f7d200</code></a> docs: 4.12.1 changelog (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/29204">#29204</a>)</li>
<li><a href="c234b33c19"><code>c234b33</code></a> chore: add changelog check script (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/29198">#29198</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.11.2...4.12.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.11.2&new-version=4.12.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/1909

Reviewed By: mweststrate

Differential Revision: D26341378

Pulled By: passy

fbshipit-source-id: b43fb60e58b7e9c6844af65628daf87c0222724a
 2021-02-10 05:51:51 -08:00
Michel Weststrate
bf7599e574 Bumped some deps to fix parsing of template literal types 
Summary:
I want to use TypesScipt type literals in a next diff (e.g.

```
type Percentage = `${number}%`
```

But to be able to use that typescript, prettier and eslint needed bumps :)

Reviewed By: nikoant

Differential Revision: D26321133

fbshipit-source-id: a4891246ef8c654f324c6daf303c5c4b2f54496e
 2021-02-10 02:52:22 -08:00
Michel Weststrate
3b6be6b7b6 Minor improvements in handling offline applications 
Summary:
Some minor loose ends from exploratory testing:

- disconnect device logs event listeners if the device disconnects
- show metro if that is still up, even if the app is no longer connected
- hide the options in the support form to record videos / screenshots if the device isn't connected

Reviewed By: nikoant

Differential Revision: D26277100

fbshipit-source-id: 49d0c934d587b226bc25524224efce60b53939e9
 2021-02-09 04:16:27 -08:00
Michel Weststrate
54f9ff260b Show quick notification if plugin interaction fails 
Summary:
Per title, if a plugin makes a client call, show a quick notif so that the user knows why his plugin interactions aren't responding in case the plugin doesn't use `isConnected` guards.

This might turn out to be too spammy, but I think it should be ok.

Reviewed By: nikoant

Differential Revision: D26277099

fbshipit-source-id: bd555ea84acae6189ec7f8fff0fc0a088dbc5337
 2021-02-09 04:16:27 -08:00
Michel Weststrate
60cfcb54a1 Wrap plugin calls into isConnected guards 
Summary:
Previously, plugins could relatively safely use `client.call` at any moment in time to fetch some information from / to the client. Except for some raise conditions there was generally speaking a connection available.

With this stack it becomes possible to interact with plugins even after an app (unexpectedly) disconnected, which makes Flipper a lot more versatile, especially when it comes to inspect crashes post mortem. (For more explanation see the second diff in this stack)

However, this means that it is no longer safe to assume there is always a connection available. For that reason `client.isConnected` has been introduced to safeguard against that.

This diff introduces guards on all user interactions that are not super explicitly triggered by the user to avoid a lot of errors being generated. This is mostly in `init()` blocks and implicit user events like selecting or hovering rows.

Explicit user interactions like pressing buttons are not guarded by this diff, as ideally failure to communicate with the client should be communicated back to the user more explicitly rather than failing silently. The next diff will introduce a fallback mechanism where a popup is shown in case those calls aren't guarded.

Fixed a few key warnings while at it.

Reviewed By: nikoant

Differential Revision: D26275604

fbshipit-source-id: 5630066cdd9541e448a6dd1f8a21861b5d751ced
 2021-02-09 04:16:26 -08:00
Michel Weststrate
43c68c0e7c Separate the concepts of archived and disconnected devices 
Summary:
Minor code cleanup to avoid future confusion:

- archived: a device that was imported from a Flipper trace, and only has persisted state
- (dis)connected: a real stateful device that might or might not have an active connection

Reviewed By: nikoant

Differential Revision: D26275459

fbshipit-source-id: eba554b37c39711e367c3795ff4456329a303c22
 2021-02-09 04:16:26 -08:00
Michel Weststrate
1bb1cae167 Don't send messages to disconnected clients. Make exportPersistedState compatible with disconnected devices. 
Summary:
This diff addresses two problems:

1. Since clients plugins can be active beyond having a connection, we have to make it possible for plugin authors to check if they are connected before they make a call.
2. if there is a custom `exportPersistedState`, plugins should be able to skip making calls if the device has disconnected.

Introducing this change makes it possible to interact with a reasonable level with disconnected clients, and makes it possible to create Flipper traces for disconnected clients.

Note that both items were already problems before supporting offline clients; as there can be a noticeable delay between disconnecting and Flipper detecting that (i've seen up to 30 secs). What happend previously in those cases is that the export would simply hang, as would other user interactions, as loosing the connection in the middle of a process would cause the promise chains to be neither rejected or resolved, which is pretty iffy.

Before this diff, trying to export a disconnected device would hang forever like:

{F369600601}

Reviewed By: nikoant

Differential Revision: D26250895

fbshipit-source-id: 177624a116883c3cba14390cd0fe164e243bb97c
 2021-02-09 04:16:26 -08:00
Michel Weststrate
7650ab620d Fixed bug causing pending events of non-sandy plugins not to be part of the export 
Summary:
During testing I noticed that even though plugin queues were flushed, the processed messages didn't end up in the export snapshots. This was caused by holding a ref of an older snapshot of the state

Changelog: Fixed an issue where data that arrived in the background was not part of the generated Flipper export.

Reviewed By: nikoant

Differential Revision: D26250897

fbshipit-source-id: ddd3f5bb19e38a1b13498d03f235bf63858eb8f8
 2021-02-09 04:16:25 -08:00
Michel Weststrate
2df117923c Select new client after connecting, if possible 
Summary:
Small UX improvement, try to select a newly arriving client if possible, this is nice as it means that disconnecting and connecting will typically end you up in the same app.

Changelog: If a new client connects, Flipper will try to focus on it

Reviewed By: nikoant

Differential Revision: D26250896

fbshipit-source-id: 83d9777a8608cd887d663a6bbe1444d2aa614e95
 2021-02-09 04:16:25 -08:00
Michel Weststrate
ff7997b3fa Make sure disconnected devices / apps can be imported and exported 
Summary:
It should be possible to exported disconnected devices, so that flipper traces / support form reports can be created from them. This diff introduces this functionality. Support for plugins with custom export logic is introduced in a later diff.

Issues fixed in this diff:
- don't try to take a screenshot for a disconnected device (this would hang forever)
- device plugins were always exported, regardless whether the user did select them or not
- sandy plugins were never part of exported disconnected clients
- increased the amount of data exported for device logs to ~10 MB. This makes more sense now as the logs will no longer be included in all cases
- fixed issue where are plugins would appear to be enabled after the client disconnected (this bug is the result of some unfortunate naming of `isArchived` vs `isConnected` semantics. Will clean up those names in a later diff.

Changelog: It is now possible to create a Flipper trace for disconnected devices and apps

Reviewed By: nikoant

Differential Revision: D26250894

fbshipit-source-id: 4dd0ec0cb152b1a8f649c31913e80efc25bcc5dd
 2021-02-09 04:16:25 -08:00
Michel Weststrate
8bc1b953c2 Show current device/app connection status in AppInspect selector 
Summary: UX love for imported and disconnected devices, so that stuff looks better :)

Reviewed By: nikoant

Differential Revision: D26249348

fbshipit-source-id: 70db682ccf0cb73161e136994f5135717f3c6be6
 2021-02-09 04:16:25 -08:00
Michel Weststrate
bb529411b5 Expose current connection status to Sandy plugins 
Summary:
Introduced `isConnected` flag on device and plugin client to reflect whether a connection is still available for the plugins, or that they have been disconnected.

Potentially we could expose the (readonly) `connected` state atom for this as well, or an `onDisconnect` event for device pugins, to create a responsive UI, but there might be no need for that, in which case this suffices.

Reviewed By: nikoant

Differential Revision: D26249346

fbshipit-source-id: b8486713fdf2fcd520488ce54f771bd038fd13f8
 2021-02-09 04:16:24 -08:00
Michel Weststrate
7e1bf0f58b Preserve client state after disconnect 
Summary:
This diff introduces support for keeping clients around after they have disconnected. This is a pretty important debugging improvement, that will allow inspecting a device / app after it crashed for example.

With this diff, the current client is just kept around until it connects again, instead of throwing clients immediately away if they disconnect. After this change, ArchivedClients will only be created by imports / exports, and no longer by disconnects. Initially I played with improving the creation of archived devices, by migrating all plugin state over from the original client to the archive, but I discovered that is very prone, as it would be a lot of pointer redistribution (plugins would point to a different client / device etc). While in contrast, disconnected clients is already an existing concept in Flipper, so reusing that keeps all the changes relatively simple.

Note that we could potentially still reuse old clients around after reconnected, but it would become much harder to reason about how plugins would behave if they missed updates for a while, so throwing away the device / clients and starting with a fresh slate sounds safer. So I figured that chance to be too risky for now, but would probably be good follow up work.

Issues with import / export, UX, and making calls to to a disconnected client will be addressed in follow up diffs

Changelog: Clients will retain their state after being disconnected, until they reconnect again

Reviewed By: nikoant

Differential Revision: D26224677

fbshipit-source-id: feb9d241df2304341c2847fe7fd751ac54c045f6
 2021-02-09 04:16:24 -08:00
Michel Weststrate
c43049d881 Preserve device state after disconnect 
Summary:
This diff stack introduces support for keeping devices and clients around after they have disconnected. This is a pretty important debugging improvement, that will allow inspecting a device / app after it crashed for example.

This feature existed partially before, but only supported Android, and only support plugins with persisted state; as it replace the current device with an archived version of the same device. In practice this didn't work really well, as most plugins would not be available, and all non-persisted state would be lost.

This diff makes sure we can keep devices around after disconnecting, the next one will keep the clients around as well. And explain some code choices in more detail.

Note that `Device.isArchived` was an overloaded term before, and even more now (both representing imported and disconnected devices), will address that in a later diff.

https://github.com/facebook/flipper/issues/1460
https://github.com/facebook/flipper/issues/812
https://github.com/facebook/flipper/issues/1487

Changelog: iOS and Android devices will preserve their state after being disconnected

Reviewed By: nikoant

Differential Revision: D26224310

fbshipit-source-id: 7dfc93c2a109a51c2880ec212a00463bc8d32041
 2021-02-09 04:16:24 -08:00
Michel Weststrate
9987c8ee89 Make sure antd is used from Flipper 
Summary: Fix build job that didn't include require rewrites for antd

Reviewed By: timur-valiev

Differential Revision: D26311554

fbshipit-source-id: 473a9c7d343e4534a33e5938ea27667f7795d8ac
 2021-02-08 04:16:53 -08:00
Pascal Hartig
949b57b473 Improve types 
Summary:
The any type was masking how the log object is actually initialised.

Sorry for the deluge of drive-by diffs. Something more substantial is coming.

Reviewed By: mweststrate

Differential Revision: D26250580

fbshipit-source-id: 5ba3f450ac1a646616868a8fd8b3cb42fb14dcc8
 2021-02-05 14:26:11 -08:00
Pascal Hartig
e788bb09be Add logs support for physical devices 
Summary:
There's a bit of an oddity with `idb` that the `stream` parameter is implied even though the docs say otherwise and if you try to use it, it'll give you a strange Python error. That's likely why we never implemented it.

Now, it works just as it does using local tooling.

Reviewed By: mweststrate

Differential Revision: D26228036

fbshipit-source-id: e20cb31167170ba0501e2929ed129305cb9aaf2c
 2021-02-05 03:53:11 -08:00
Pascal Hartig
87caca9e77 Demote iOS connection errors 
Summary: The "attaching failed" error provides no context and is a handled error, so we don't need to elevate this to a warning. We also see a socket warning on stderr every time we start up logging through simctl, so we don't need to treat that as an error.

Reviewed By: nikoant

Differential Revision: D26228037

fbshipit-source-id: 1938dadd54499462e1fd614c9477f738661c387b
 2021-02-04 04:35:02 -08:00
Pascal Hartig
661af25ff9 getAppVersion for UpdateIndicator 
Summary:
VSCode got a new thing where it doesn't save my file because it waits for a formatter or some stuff indefinitely, which is really cool, because it means my diffs end up being incomplete.

So this should have been in D26223274 (642d89213d) but now it's here.

angry_cry

Reviewed By: nikoant

Differential Revision: D26228038

fbshipit-source-id: 98b84179dce4e8e8c71f9196ab78d534327ea301
 2021-02-04 04:35:02 -08:00
Anton Nikolaev
2f03aca5eb Revert D26222885: Upgrade metro to 0.65.0 
Differential Revision:
D26222885 (9fe82dd6c7)

Original commit changeset: bb386ae4bc91

fbshipit-source-id: 5b8b1b71437b481a91c8b9cdaaeda051da3e2972
 2021-02-03 23:37:57 -08:00
Pascal Hartig
642d89213d Extract getAppVersion() util 
Summary:
Just some simple memoisation so we limit this particular `remote`
call to one per session.

Reviewed By: mweststrate

Differential Revision: D26223274

fbshipit-source-id: 7a12764758823c52f68fb7075f46caf58affb22f
 2021-02-03 08:01:48 -08:00
Anton Nikolaev
9fe82dd6c7 Upgrade metro to 0.65.0 
Summary: Upgrade metro to 0.65.0

Reviewed By: passy

Differential Revision: D26222885

fbshipit-source-id: bb386ae4bc913d47d9f3431368e45c6319f0d65d
 2021-02-03 04:42:22 -08:00
dependabot[bot]
e09e3c82ee Bump antd from 4.9.1 to 4.11.2 in /desktop (#1886) 
Summary:
allow-large-files

Bumps [antd](https://github.com/ant-design/ant-design) from 4.9.1 to 4.11.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.11.2</h2>
<ul>
<li>{emoji:1f41e} Fix rc-trigger BuildInPlacements TypeScript compile error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li>
</ul>
<hr />
<ul>
<li>{emoji:1f41e} 修复 rc-trigger BuildInPlacements TypeScript 编译错误。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li>
</ul>
<h2>4.11.1</h2>
<ul>
<li>{emoji:1f484} Layout inline sub menu now has grey background. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li>
<li>{emoji:1f195} PageHeader supports <code>breadcrumbRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li>
<li>{emoji:1f195} Typography <code>ellipsis</code> support <code>tooltip</code> to customize tooltip when ellipsis. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li>
<li>Image
<ul>
<li>{emoji:1f195} Image supports <code>preview.maskClassName</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li>
<li>{emoji:1f41e} Fix preview image will move after click it. <a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li>
<li>{emoji:1f41e} Fix Image <code>placeholder</code> disappear issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li>
<li>{emoji:1f41e} Fix multiple Image.PreviewGroup contain same image. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li>
</ul>
</li>
<li>ConfigProvider
<ul>
<li>{emoji:1f195} ConfigProvider supports <code>iconPrefixCls</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li>
<li>{emoji:26a1} Optimize ConfigProvider props updating perfermance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li>
</ul>
</li>
<li>{emoji:1f484} Tweak TreeSelect filter highlight color. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li>
<li>{emoji:1f484} Fix Select item align style with custom <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li>
<li>Form
<ul>
<li>{emoji:1f41e} Fix Form.Item can not clear nested <code>noStyle</code> error message. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li>
<li>{emoji:1f41e} Form.Item with <code>preserve=false</code> will reset value to <code>initialValues</code> when removed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li>
</ul>
</li>
<li>{emoji:1f41e} Fix Button click effect style not working in shadow root. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28995">#28995</a> <a href="https://github.com/rinick"><code>rinick</code></a></li>
<li>{emoji:1f41e} Fix Table custom filter menu cannot close bug. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28688">#28688</a> <a href="https://github.com/alekye"><code>alekye</code></a></li>
<li>Less
<ul>
<li>{emoji:1f484} Add <code>menu-inline-submenu-bg</code> less variable and rename <code>menu-dark-submenu-bg</code> to <code>menu-dark-inline-submenu-bg</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li>
<li>{emoji:1f484} Add less variable <code>drawer-footer-padding-horizontal</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28975">#28975</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li>
</ul>
</li>
<li>RTL
<ul>
<li>{emoji:1f484} Fix Card actions divider style in RTL. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28915">#28915</a> <a href="https://github.com/Aghosey"><code>Aghosey</code></a></li>
</ul>
</li>
<li>TypeScript
<ul>
<li>� Expose interfaces and types from default entry of antd. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28963">#28963</a></li>
<li>� Improve Input/Skeleton <code>style</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28966">#28966</a> <a href="https://github.com/yingpengsha"><code>yingpengsha</code></a></li>
</ul>
</li>
</ul>
<hr />
<ul>
<li>{emoji:1f484} Layout 内联子表单添加背景颜色以更好的区分层级。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li>
<li>{emoji:1f195} PageHeader 支持 <code>breadcrumbRender</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li>
<li>{emoji:1f195} Typography <code>ellipsis</code> 属性添加 <code>tooltip</code> 支持以自定义收缩时的提示信息。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li>
<li>Image
<ul>
<li>{emoji:1f195} Image 支持配置 <code>preview.maskClassName</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li>
<li>{emoji:1f41e} 修复预览图片会跟随鼠标移动的问题。<a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li>
<li>{emoji:1f41e} 修复 Image <code>placeholder</code> 不显示的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li>
<li>{emoji:1f41e} 修复多个 Image.PreviewGroup 之间图片互串的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li>
</ul>
</li>
<li>ConfigProvider</li>
<li>ConfigProvider
<ul>
<li>{emoji:1f195} ConfigProvider 支持 <code>iconPrefixCls</code> 修改图标样式前缀。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li>
<li>{emoji:26a1} 优化 ConfigProvider 切换属性的性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li>
</ul>
</li>
<li>{emoji:1f484} 调整 TreeSelect 搜索高亮条目的颜色。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li>
<li>{emoji:1f484} 修复 Select 自定义 <code>tagRender</code> 时不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li>
<li>Form
<ul>
<li>{emoji:1f41e} 修复 Form.Item 无法正确清理嵌套的 <code>noStyle</code> 错误信息问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li>
<li>{emoji:1f41e} Form.Item 配置 <code>preserve=false</code> 时，移除该字段将自动重置对应值为 <code>initialValues</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li>
</ul>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.11.2</h2>
<p><code>2021-01-26</code></p>
<ul>
<li>{emoji:1f41e} Fix rc-trigger BuildInPlacements TypeScript compile error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/29029">#29029</a> <a href="https://github.com/waiwaiku"><code>waiwaiku</code></a></li>
</ul>
<h2>4.11.1</h2>
<p><code>2021-01-24</code></p>
<ul>
<li>{emoji:1f484} Layout inline sub menu now has grey background. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li>
<li>{emoji:1f195} PageHeader supports <code>breadcrumbRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28999">#28999</a></li>
<li>{emoji:1f195} Typography <code>ellipsis</code> support <code>tooltip</code> to customize tooltip when ellipsis. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28821">#28821</a></li>
<li>Image
<ul>
<li>{emoji:1f195} Image supports <code>preview.maskClassName</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28681">#28681</a></li>
<li>{emoji:1f41e} Fix preview image will move after click it. <a href="https://github-redirect.dependabot.com/react-component/image/pull/61">react-component/image#61</a> <a href="https://github.com/simonwong"><code>simonwong</code></a></li>
<li>{emoji:1f41e} Fix Image <code>placeholder</code> disappear issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28953">#28953</a></li>
<li>{emoji:1f41e} Fix multiple Image.PreviewGroup contain same image. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/28881">#28881</a></li>
</ul>
</li>
<li>ConfigProvider
<ul>
<li>{emoji:1f195} ConfigProvider supports <code>iconPrefixCls</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28924">#28924</a></li>
<li>{emoji:26a1} Optimize ConfigProvider props updating perfermance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28792">#28792</a> <a href="https://github.com/zxc0328"><code>zxc0328</code></a></li>
</ul>
</li>
<li>{emoji:1f484} Tweak TreeSelect filter highlight color. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28984">#28984</a></li>
<li>{emoji:1f484} Fix Select item align style with custom <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28962">#28962</a></li>
<li>Form
<ul>
<li>{emoji:1f41e} Fix Form.Item can not clear nested <code>noStyle</code> error message. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28918">#28918</a></li>
<li>{emoji:1f41e} Form.Item with <code>preserve=false</code> will reset value to <code>initialValues</code> when removed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28908">#28908</a></li>
</ul>
</li>
<li>{emoji:1f41e} Fix Button click effect style not working in shadow root. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28995">#28995</a> <a href="https://github.com/rinick"><code>rinick</code></a></li>
<li>{emoji:1f41e} Fix Table custom filter menu cannot close bug. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28688">#28688</a> <a href="https://github.com/alekye"><code>alekye</code></a></li>
<li>Less
<ul>
<li>{emoji:1f484} Add <code>menu-inline-submenu-bg</code> less variable and rename <code>menu-dark-submenu-bg</code> to <code>menu-dark-inline-submenu-bg</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28842">#28842</a></li>
<li>{emoji:1f484} Add less variable <code>drawer-footer-padding-horizontal</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28975">#28975</a> <a href="https://github.com/yuxuan"><code>yuxuan</code></a></li>
</ul>
</li>
<li>RTL
<ul>
<li>{emoji:1f484} Fix Card actions divider style in RTL. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28915">#28915</a> <a href="https://github.com/Aghosey"><code>Aghosey</code></a></li>
</ul>
</li>
<li>TypeScript
<ul>
<li>� Expose interfaces and types from default entry of antd. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28963">#28963</a></li>
<li>� Improve Input/Skeleton <code>style</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28966">#28966</a> <a href="https://github.com/yingpengsha"><code>yingpengsha</code></a></li>
</ul>
</li>
</ul>
<h2>4.11.0</h2>
<p><code>2021-01-24</code></p>
<p>It is a wrong release which same as <code>4.10.3</code>, don't use it.</p>
<h2>4.10.3</h2>
<p><code>2021-01-18</code></p>
<ul>
<li>{emoji:1f41e} Fix Button not adapting to the <code>btn-border-width</code> when loading. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28886">#28886</a> <a href="https://github.com/jjanssen"><code>jjanssen</code></a></li>
<li>Table
<ul>
<li>{emoji:1f484} Add <code>table-border-color</code> less variable. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/28903">#28903</a></li>
</ul>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8158f45611"><code>8158f45</code></a> chore: upgrade ant-design/tools</li>
<li><a href="83904e56ea"><code>83904e5</code></a> docs: release 4.11.2</li>
<li><a href="20c49b7bbb"><code>20c49b7</code></a> docs: fix demo-focus layout (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/29028">#29028</a>)</li>
<li><a href="da0f6519f0"><code>da0f651</code></a> fix: import BuildInPlacements type (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/29029">#29029</a>)</li>
<li><a href="47792085b0"><code>4779208</code></a> docs: Update showCheckedStrategy desc</li>
<li><a href="9dff2dd9c3"><code>9dff2dd</code></a> dos({emoji:1f6e1} ): update test badge</li>
<li><a href="52e84f92e0"><code>52e84f9</code></a> test({emoji:1f500}): use wearerequired/git-mirror-action (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/29012">#29012</a>)</li>
<li><a href="48842e2a49"><code>48842e2</code></a> chore: update mirror.yml</li>
<li><a href="eebdb95cbe"><code>eebdb95</code></a> test: should not ignore *.md</li>
<li><a href="d86cfba197"><code>d86cfba</code></a> docs: release 4.11.1</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.9.1...4.11.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.9.1&new-version=4.11.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/1886

Reviewed By: passy

Differential Revision: D26222325

Pulled By: nikoant

fbshipit-source-id: f769bca6be6939b607678defa1ad2ea5beba5b50
 2021-02-03 03:37:19 -08:00
Pritesh Nandgaonkar
6a0854557e Add gk checks in plugin 
Summary:
This diff adds gk checks, VPN check and User login check to our plugin.

I added gk checks for Insta and FB apps. There are three kind of GK's. One with FB universe, one with Distillery universe and one with Insta WWW universe. We have API's to check gk with FB and Distillery universe. API to check with Insta WWW universe doesn't exists. There are some technical challenges to build this API. So right now for gks with Insta WWW universe, we just show an notification with info icon. For gks in other universe we aggressively check it when user closes the notif to verify if user assigned himself/herself to it.

In long term we are moving away from gks altogether, we need this UX improvement as it will help users to onboard easily.

See the following flow.

Reviewed By: mweststrate

Differential Revision: D26176996

fbshipit-source-id: 92a931610f9b244c14c6888bb12df936b62edd75
 2021-02-03 02:25:54 -08:00
Pascal Hartig
9469ad33af Make addErrorNotification raise a warning 
Summary:
These are recoverable, handled errors. We shouldn't treat these
as events that require actions from us. They also have
a tendency of firing a lot.

Reviewed By: nikoant

Differential Revision: D26202358

fbshipit-source-id: 445f3c2bcd0041d5cd773ec04172fdeed9b32222
 2021-02-02 10:58:50 -08:00
dependabot[bot]
5850bb6b52 Bump open from 7.0.3 to 7.3.1 in /desktop (#1867) 
Summary:
Bumps [open](https://github.com/sindresorhus/open) from 7.0.3 to 7.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sindresorhus/open/releases">open's releases</a>.</em></p>
<blockquote>
<h2>v7.3.1</h2>
<ul>
<li>Fix support for WSL when Windows isn&amp;<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/39">https://github.com/facebook/flipper/issues/39</a>;t mounted in <code>/mnt/</code> (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/210">https://github.com/facebook/flipper/issues/210</a>)  a3bbadc</li>
</ul>
<p><a href="https://github.com/sindresorhus/open/compare/v7.3.0...v7.3.1">https://github.com/sindresorhus/open/compare/v7.3.0...v7.3.1</a></p>
<h2>v7.3.0</h2>
<ul>
<li>Support WSL configuration where Windows paths are not in PATH (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/195">https://github.com/facebook/flipper/issues/195</a>)  be0f794</li>
</ul>
<p><a href="https://github.com/sindresorhus/open/compare/v7.2.1...v7.3.0">https://github.com/sindresorhus/open/compare/v7.2.1...v7.3.0</a></p>
<h2>v7.2.1</h2>
<ul>
<li>Fix <code>app</code> option on Windows (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/191">https://github.com/facebook/flipper/issues/191</a>)  9bcd285</li>
</ul>
<p><a href="https://github.com/sindresorhus/open/compare/v7.2.0...v7.2.1">https://github.com/sindresorhus/open/compare/v7.2.0...v7.2.1</a></p>
<h2>v7.2.0</h2>
<ul>
<li>Use PowerShell on Windows for improved reliability (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/188">https://github.com/facebook/flipper/issues/188</a>)  f7ca0d3</li>
</ul>
<p><a href="https://github.com/sindresorhus/open/compare/v7.1.0...v7.2.0">https://github.com/sindresorhus/open/compare/v7.1.0...v7.2.0</a></p>
<h2>v7.1.0</h2>
<ul>
<li>Add <a href="https://github.com/sindresorhus/open#allownonzeroexitcode"><code>allowNonzeroExitCode</code></a> option (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/176">https://github.com/facebook/flipper/issues/176</a>)  e009765</li>
</ul>
<p><a href="https://github.com/sindresorhus/open/compare/v7.0.4...v7.1.0">https://github.com/sindresorhus/open/compare/v7.0.4...v7.1.0</a></p>
<h2>v7.0.4</h2>
<ul>
<li>Fix double-encoding of URLs (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/182">https://github.com/facebook/flipper/issues/182</a>)  48b6d0e</li>
</ul>
<p><a href="https://github.com/sindresorhus/open/compare/v7.0.3...v7.0.4">https://github.com/sindresorhus/open/compare/v7.0.3...v7.0.4</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="3182c380bd"><code>3182c38</code></a> 7.3.1</li>
<li><a href="a3bbadcf3c"><code>a3bbadc</code></a> Fix support for WSL when Windows isn't mounted in <code>/mnt/</code> (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/210">https://github.com/facebook/flipper/issues/210</a>)</li>
<li><a href="fe91dea810"><code>fe91dea</code></a> Fix readme typo (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/213">https://github.com/facebook/flipper/issues/213</a>)</li>
<li><a href="003c78f193"><code>003c78f</code></a> Move to GitHub Actions</li>
<li><a href="f3748e4f5a"><code>f3748e4</code></a> 7.3.0</li>
<li><a href="be0f794515"><code>be0f794</code></a> Support WSL configuration where Windows paths are not in PATH (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/195">https://github.com/facebook/flipper/issues/195</a>)</li>
<li><a href="45e50caaae"><code>45e50ca</code></a> 7.2.1</li>
<li><a href="9bcd285712"><code>9bcd285</code></a> Fix <code>app</code> option on Windows (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/191">https://github.com/facebook/flipper/issues/191</a>)</li>
<li><a href="1022f42026"><code>1022f42</code></a> 7.2.0</li>
<li><a href="f7ca0d3541"><code>f7ca0d3</code></a> Use PowerShell on Windows for improved reliability (<a href="https://github-redirect.dependabot.com/sindresorhus/open/issues/188">https://github.com/facebook/flipper/issues/188</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/sindresorhus/open/compare/v7.0.3...v7.3.1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=open&package-manager=npm_and_yarn&previous-version=7.0.3&new-version=7.3.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/1867

Reviewed By: mweststrate

Differential Revision: D26149526

Pulled By: passy

fbshipit-source-id: 732e6a464a41df4f258baa5c7ddc3a1a34ccd0a7
 2021-02-02 10:13:26 -08:00
Michel Weststrate
9bd3d6fd7c Fix serialization performance 
Summary:
Using our serialization utilities in the previous diff absolute destroyed the performance of serializing the device logs. Investigated a bit, and the root cause is that *every* object serialization would notify the UI.

This is not only pointless, since the UI won't be updated until the next tick anyway, it also is terribly expensive since React has to process and queue all these updates.

Exporting the device logs went down from **2 minutes to a few seconds** with this change. (Still a lot slower than JSON.stringify, but I think the flexibility for plugin devs is worth it).

This change does not only benefit devicelogs plugin, but all existing plugins as well, plugins like GraphQL should now export their data much quicker.

Before (practically all time of serialization is spend in React's setState):

{F366147730}

After (only a spike at the end of the idler tick):

{F366147779}

Reviewed By: priteshrnandgaonkar

Differential Revision: D26146420

fbshipit-source-id: 9bbeccf04701fd044e041956b7bb00f1e0622b63
 2021-02-01 11:43:31 -08:00
Michel Weststrate
594fa4d2bc serialize Sandy plugins with serialization utils to support Date/Set/Map 
Summary:
Unlike non-sandy plugins, non-sandy plugins weren't serialized using our serialization utility yet. This diff addresses that, meaning that users don't have to bother about how to serialize maps, sets and dates.

Unlike the old fashioned plugins, the `makeObjectSerialize` utility is used, rather than `serialize`. This normalizes the objects, but doesn't serialize them, which is done at the end of the export data process anyway for the whole tree. This avoids creating a double JSON serialization which is fully of ugly escape characters.

This makes the onImport / onExport definition of the logs plugin nicer.

Also improved the docs.

Reviewed By: nikoant

Differential Revision: D26146421

fbshipit-source-id: 6abfb6ee2e3312e2a13a11832ff103dc62fd844c
 2021-02-01 11:43:31 -08:00
Michel Weststrate
e614993558 Fix incorrect date serialization 
Summary:
While creating some other tests, discovered that our current date serialization uses `toString()` serialization, causing the amount of milliseconds to be lost. The serialization (see below) uses less bytes as well since the human readable timezone isn't included. This change only affects serialization and is backward compatible.

```
  ✓ test serialize and deserializeObject function for non Object input (1 ms)
  ✕ test makeObjectSerializable and deserializeObject function for Date input (2 ms)
  ✓ test makeObjectSerializable and deserializeObject function for Map of Sets
  ✓ test makeObjectSerializable and deserializeObject function for Map, Dates and Set with complex nesting (1 ms)

  ● test makeObjectSerializable and deserializeObject function for Date input

    expect(received).toEqual(expected) // deep equality

    Expected: 2021-03-01T10:31:07.205Z
    Received: 2021-03-01T10:31:07.000Z
```

Reviewed By: priteshrnandgaonkar

Differential Revision: D26145941

fbshipit-source-id: dfd6607a4199ca46e2075027856138efb88a07f9
 2021-02-01 11:43:30 -08:00
Michel Weststrate
7cc55daf34 Stop storing device logs on the device object and in the plugin 
Summary:
Logs were stored hardcoded on the Device object first, this diff makes it normal plugin state.

This makes sure that we can use the same abstractions as in all plugins that store large data sets, and that we can leverage the upcoming DataSource abstraction.

Reviewed By: nikoant

Differential Revision: D26127243

fbshipit-source-id: 7c386a615fa7989f35ba0df5b7c1d218d37b57a2
 2021-02-01 11:43:30 -08:00
Michel Weststrate
f2ade40239 Support custom data processing during import 
Summary: Per title, this allows for pre-processing data after it is deserialized and before it is stored in the plugin

Reviewed By: nikoant

Differential Revision: D26126423

fbshipit-source-id: bc08a6ab205d2a0d551515563cd85a197595ddb2
 2021-02-01 11:43:30 -08:00
Michel Weststrate
34c915a739 Add support for async / custom plugin export 
Summary:
Sandy plugins can now set up an `onExport` handler to enable customizing the export format of a plugin: `client.onExport(callback: (idler, onStatusMessage) => Promise<state>)`

Import will be done in next diff

Reviewed By: nikoant

Differential Revision: D26124440

fbshipit-source-id: c787c79d929aa8fb484f15a9340d7c87545793cb
 2021-02-01 11:43:29 -08:00
Michel Weststrate
32bde8cace add support for device plugin import / export 
Summary: Sandy device plugins weren't exported till now (the only stateful plugin so far was Logs, but logs were stored hardcoded on the device rather than using the plugin export mechanisms). This diff makes sure that SandyDevicePlugins will be exported as well if they are persistable.

Reviewed By: nikoant

Differential Revision: D22724822

fbshipit-source-id: a10354a9c7e02f3e696d0cdda0f2c6be6f5ac61e
 2021-02-01 11:43:29 -08:00
Michel Weststrate
e1daa449ba Unify computation of available plugins 
Summary:
While trying to change something, discovered we have 3 different mechanisms in our code base to compute active plugins; the plugin list component, support form, and export flipper trace form had all their own, subtly different implementations of computing which plugins are available to the user.

Also removed some hardcoded exceptions for e.g. Logs plugin, which in the next diff and onward will be just a vanilla plugin without special casing

Unified that, which some how went a bit deeper than hoped, trough some hoops in in circular deps. Also unified to use the same testing utils, to avoid some gobbling objects manually together, with resulted in a bunch of unexpected NPEs. Found out that we actually still have unit tests using Flow in the process :-P. Converted one to TS.

Reviewed By: nikoant

Differential Revision: D26103172

fbshipit-source-id: 2fce2577d97d98543cb9312b3d013f24faee43aa
 2021-02-01 11:43:29 -08:00
dependabot[bot]
a9ad3d2f1b Bump @testing-library/react from 11.1.0 to 11.2.3 in /desktop (#1868) 
Summary:
Bumps [testing-library/react](https://github.com/testing-library/react-testing-library) from 11.1.0 to 11.2.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/testing-library/react-testing-library/releases"><code>testing-library/react's releases</code></a>.</em></p>
<blockquote>
<h2>v11.2.3</h2>
<h2><a href="https://github.com/testing-library/react-testing-library/compare/v11.2.2...v11.2.3">11.2.3</a> (2021-01-07)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>Return type of unmount is <code>void</code> (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/857">https://github.com/facebook/flipper/issues/857</a>) (<a href="1389f09474">1389f09</a>)</li>
</ul>
<h2>v11.2.2</h2>
<h2><a href="https://github.com/testing-library/react-testing-library/compare/v11.2.1...v11.2.2">11.2.2</a> (2020-11-20)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>dependencies:</strong> bump dom testing library (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/836">https://github.com/facebook/flipper/issues/836</a>) (<a href="7fcb0f2e93">7fcb0f2</a>)</li>
</ul>
<h2>v11.2.1</h2>
<h2><a href="https://github.com/testing-library/react-testing-library/compare/v11.2.0...v11.2.1">11.2.1</a> (2020-11-19)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>types:</strong> Allow all HTML and SVG elements in render. (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/833">https://github.com/facebook/flipper/issues/833</a>) (<a href="1dc33b23be">1dc33b2</a>)</li>
</ul>
<h2>v11.2.0</h2>
<h1><a href="https://github.com/testing-library/react-testing-library/compare/v11.1.2...v11.2.0">11.2.0</a> (2020-11-18)</h1>
<h3>Features</h3>
<ul>
<li>bump dom testing library (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/831">https://github.com/facebook/flipper/issues/831</a>) (<a href="456424ff33">456424f</a>)</li>
</ul>
<h2>v11.1.2</h2>
<h2><a href="https://github.com/testing-library/react-testing-library/compare/v11.1.1...v11.1.2">11.1.2</a> (2020-11-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>import pretty-format from testing-library/dom (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/821">https://github.com/facebook/flipper/issues/821</a>) (<a href="2712dc2da4">2712dc2</a>)</li>
</ul>
<h2>v11.1.1</h2>
<h2><a href="https://github.com/testing-library/react-testing-library/compare/v11.1.0...v11.1.1">11.1.1</a> (2020-11-03)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>upgrade dependencies, typescript, testing-library/dom etc (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/816">https://github.com/facebook/flipper/issues/816</a>) (<a href="e07e6416f2">e07e641</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="deafd51bc2"><code>deafd51</code></a> docs: add sanchit121 as a contributor (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/858">https://github.com/facebook/flipper/issues/858</a>)</li>
<li><a href="1389f09474"><code>1389f09</code></a> fix: Return type of unmount is <code>void</code> (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/857">https://github.com/facebook/flipper/issues/857</a>)</li>
<li><a href="64a8b9c2f3"><code>64a8b9c</code></a> chore: update all deps (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/842">https://github.com/facebook/flipper/issues/842</a>)</li>
<li><a href="03bea9fd76"><code>03bea9f</code></a> chore: Add 'Cancel Previous Runs' step (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/840">https://github.com/facebook/flipper/issues/840</a>)</li>
<li><a href="7fcb0f2e93"><code>7fcb0f2</code></a> fix(dependencies): bump dom testing library (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/836">https://github.com/facebook/flipper/issues/836</a>)</li>
<li><a href="276673ff00"><code>276673f</code></a> chore(types): add test for rendering SVG elements (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/834">https://github.com/facebook/flipper/issues/834</a>)</li>
<li><a href="1dc33b23be"><code>1dc33b2</code></a> fix(types): Allow all HTML and SVG elements in render. (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/833">https://github.com/facebook/flipper/issues/833</a>)</li>
<li><a href="456424ff33"><code>456424f</code></a> feat: bump dom testing library (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/831">https://github.com/facebook/flipper/issues/831</a>)</li>
<li><a href="236ea4962d"><code>236ea49</code></a> chore: remove one temporary fix with a better permenant one</li>
<li><a href="96b9aebe96"><code>96b9aeb</code></a> chore: Update validate.yml (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/827">https://github.com/facebook/flipper/issues/827</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/testing-library/react-testing-library/compare/v11.1.0...v11.2.3">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@testing-library/react&package-manager=npm_and_yarn&previous-version=11.1.0&new-version=11.2.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/1868

Reviewed By: mweststrate

Differential Revision: D26149524

Pulled By: passy

fbshipit-source-id: 6cc8159ffdf8e13b7851042e7c25ff058f5c88cb
 2021-02-01 09:02:11 -08:00
Pascal Hartig
4b711716f2 Improve plugin ready message 
Summary: Minor change.

Reviewed By: mweststrate

Differential Revision: D26129625

fbshipit-source-id: 2b823bb34314b7ff1b84eb1ae708733b7dcc9881
 2021-01-29 08:55:41 -08:00
Pascal Hartig
c41a2a3605 Link to MSC 
Summary: Found out about this today.

Reviewed By: mweststrate

Differential Revision: D26129626

fbshipit-source-id: 82aa5d9fa536010b51fc1cf937f521e5ffa88015
 2021-01-29 08:55:40 -08:00
Pascal Hartig
5ac8f7a16f Small refactors 
Summary: Going to make more changes here soon and wanted to apply some small changes first.

Reviewed By: jknoxville

Differential Revision: D26078645

fbshipit-source-id: 3a2bcd593b893160b5a332c858a514ebe89d3f4d
 2021-01-29 05:10:29 -08:00
Anton Nikolaev
d7cfcb5d8e Extend device plugin metadata to include supported devices 
Summary: Plugin metadata format extended to include type of each plugin (client / device) and list of supported devices (android/ios/..., emulator/physical, etc). This will allow to detect plugins supported by device even if they are not installed and only available on Marketplace.

Reviewed By: mweststrate

Differential Revision: D26073531

fbshipit-source-id: e331f1be1af1046cd4220a286a1d52378c26cc53
 2021-01-27 17:31:41 -08:00
Anton Nikolaev
1ce619af7e Tolerate individual plugin load errors 
Summary: This diff fixes the issue when there is an error on checking GK for any of plugins and because of it the entire set of plugins failed to load. Each plugin should be loaded in isolation from others.

Reviewed By: passy

Differential Revision: D26099735

fbshipit-source-id: ba5475f4baf2d06f8922d345c9d401f5b15956ec
 2021-01-27 04:41:05 -08:00
Michel Weststrate
f6d8b19001 Replace search view with drop down 
Summary:
The support form currently has a search form to select a group, but unless the selection is cleared, it won't show you which groups is actually available, which makes it hard for people to select the right group if they don't know up front.

Since the scale of available groups doesn't justify needing a typeahead, converted it to an ordinary dropdown.

An added benefit is that this allows us to remove a large and complicated component we shouldn't be maintaining ourselves, but rather reuse from Ant.

Reviewed By: nikoant

Differential Revision: D26046131

fbshipit-source-id: f499e5848eec8b961b054104c8e3a01567e2801e
 2021-01-26 05:29:58 -08:00
dependabot[bot]
de60b28cc7 Bump rsocket-flowable from 0.0.14 to 0.0.22 in /desktop (#1863) 
Summary:
Bumps [rsocket-flowable](https://github.com/rsocket/rsocket-js) from 0.0.14 to 0.0.22.
<details>
<summary>Commits</summary>
<ul>
<li><a href="08bef0b23b"><code>08bef0b</code></a> v0.0.22</li>
<li><a href="d82ac4d8ad"><code>d82ac4d</code></a> bumps version</li>
<li><a href="1eea785dee"><code>1eea785</code></a> adds RoutingMetadata and removes deprecation of CompositeMetadata to enable `...</li>
<li><a href="4de7bd9980"><code>4de7bd9</code></a> improves CompositeMetadataExample</li>
<li><a href="7f4b418dd7"><code>7f4b418</code></a> adds support for AuthMetadata</li>
<li><a href="d8f69c6499"><code>d8f69c6</code></a> adds RoutingMetadata support</li>
<li><a href="8586850e42"><code>8586850</code></a> refactors CompositeMetadata API</li>
<li><a href="045c150101"><code>045c150</code></a> improves LiteBuffer and RSocketBufferUtils</li>
<li><a href="a1190c84ab"><code>a1190c8</code></a> v0.0.20</li>
<li><a href="0e72e419e2"><code>0e72e41</code></a> Revert &quot;v0.0.20&quot;</li>
<li>Additional commits viewable in <a href="https://github.com/rsocket/rsocket-js/compare/v0.0.14...v0.0.22">compare view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a href="https://www.npmjs.com/~shadowgun">shadowgun</a>, a new releaser for rsocket-flowable since your current version.</p>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=rsocket-flowable&package-manager=npm_and_yarn&previous-version=0.0.14&new-version=0.0.22)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/1863

Reviewed By: passy

Differential Revision: D26047361

Pulled By: mweststrate

fbshipit-source-id: 7349245323311f8e161af385032847d996cef8e3
 2021-01-26 05:26:28 -08:00
dependabot[bot]
b4319387ad Bump react-refresh from 0.8.3 to 0.9.0 in /desktop (#1861) 
Summary:
Bumps [react-refresh](https://github.com/facebook/react/tree/HEAD/packages/react) from 0.8.3 to 0.9.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react/releases">react-refresh's releases</a>.</em></p>
<blockquote>
<h2>v0.9.0</h2>
<h2>What’s New?</h2>
<p>This version includes better support for normalizing event properties across all supported browsers so that you need to worry even less about cross-browser differences. We've also made many improvements to error messages and have refactored the core to never rethrow errors, so stack traces are more accurate and Chrome's purple break-on-error stop sign now works properly.</p>
<p>We've also added to the add-ons build <a href="https://github.com/facebook/react/tree/HEAD/packages/react/blob/HEAD/react/docs/test-utils.html">React.addons.TestUtils</a>, a set of new utilities to help you write unit tests for React components. You can now simulate events on your components, and several helpers are provided to help make assertions about the rendered DOM tree.</p>
<p>We've also made several other improvements and a few breaking changes; the full changelog is provided below.</p>
<h2>JSX Whitespace</h2>
<p>In addition to the changes to React core listed below, we've made a small change to the way JSX interprets whitespace to make things more consistent. With this release, space between two components on the same line will be preserved, while a newline separating a text node from a tag will be eliminated in the output. Consider the code:</p>
<pre lang="html"><code>&lt;div&gt;
  Monkeys:
  {listOfMonkeys} {submitButton}
&lt;/div&gt;
</code></pre>
<p>In v0.8 and below, it was transformed to the following:</p>
<pre lang="javascript"><code>React.DOM.div(null,
  &quot; Monkeys: &quot;,
  listOfMonkeys, submitButton
)
</code></pre>
<p>In v0.9, it will be transformed to this JS instead:</p>
<pre lang="javascript{2,3}"><code>React.DOM.div(null,
  &quot;Monkeys:&quot;,
  listOfMonkeys, &quot; &quot;, submitButton
)
</code></pre>
<p>We believe this new behavior is more helpful and elimates cases where unwanted whitespace was previously added.</p>
<p>In cases where you want to preserve the space adjacent to a newline, you can write <code>{'Monkeys: '}</code> or <code>Monkeys:{' '}</code> in your JSX source. We've included a script to do an automated codemod of your JSX source tree that preserves the old whitespace behavior by adding and removing spaces appropriately. You can <a href="https://github.com/facebook/react/blob/master/npm-jsx_whitespace_transformer/README.md">install jsx_whitespace_transformer from npm</a> and run it over your source tree to modify files in place. The transformed JSX files will preserve your code's existing whitespace behavior.</p>
<h2>Changelog</h2>
<h3>React Core</h3>
<h4>Breaking Changes</h4>
<ul>
<li>The lifecycle methods <code>componentDidMount</code> and <code>componentDidUpdate</code> no longer receive the root node as a parameter; use <code>this.getDOMNode()</code> instead</li>
<li>Whenever a prop is equal to <code>undefined</code>, the default value returned by <code>getDefaultProps</code> will now be used instead</li>
<li><code>React.unmountAndReleaseReactRootNode</code> was previously deprecated and has now been removed</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react/blob/master/CHANGELOG.md">react-refresh's changelog</a>.</em></p>
<blockquote>
<h2>0.9.0 (February 20, 2014)</h2>
<h3>React Core</h3>
<h4>Breaking Changes</h4>
<ul>
<li>The lifecycle methods <code>componentDidMount</code> and <code>componentDidUpdate</code> no longer receive the root node as a parameter; use <code>this.getDOMNode()</code> instead</li>
<li>Whenever a prop is equal to <code>undefined</code>, the default value returned by <code>getDefaultProps</code> will now be used instead</li>
<li><code>React.unmountAndReleaseReactRootNode</code> was previously deprecated and has now been removed</li>
<li><code>React.renderComponentToString</code> is now synchronous and returns the generated HTML string</li>
<li>Full-page rendering (that is, rendering the <code>&lt;html&gt;</code> tag using React) is now supported only when starting with server-rendered markup</li>
<li>On mouse wheel events, <code>deltaY</code> is no longer negated</li>
<li>When prop types validation fails, a warning is logged instead of an error thrown (with the production build of React, type checks are now skipped for performance)</li>
<li>On <code>input</code>, <code>select</code>, and <code>textarea</code> elements, <code>.getValue()</code> is no longer supported; use <code>.getDOMNode().value</code> instead</li>
<li><code>this.context</code> on components is now reserved for internal use by React</li>
</ul>
<h4>New Features</h4>
<ul>
<li>React now never rethrows errors, so stack traces are more accurate and Chrome's purple break-on-error stop sign now works properly</li>
<li>Added support for SVG tags <code>defs</code>, <code>linearGradient</code>, <code>polygon</code>, <code>radialGradient</code>, <code>stop</code></li>
<li>Added support for more attributes:
<ul>
<li><code>crossOrigin</code> for CORS requests</li>
<li><code>download</code> and <code>hrefLang</code> for <code>&lt;a&gt;</code> tags</li>
<li><code>mediaGroup</code> and <code>muted</code> for <code>&lt;audio&gt;</code> and <code>&lt;video&gt;</code> tags</li>
<li><code>noValidate</code> and <code>formNoValidate</code> for forms</li>
<li><code>property</code> for Open Graph <code>&lt;meta&gt;</code> tags</li>
<li><code>sandbox</code>, <code>seamless</code>, and <code>srcDoc</code> for <code>&lt;iframe&gt;</code> tags</li>
<li><code>scope</code> for screen readers</li>
<li><code>span</code> for <code>&lt;colgroup&gt;</code> tags</li>
</ul>
</li>
<li>Added support for defining <code>propTypes</code> in mixins</li>
<li>Added <code>any</code>, <code>arrayOf</code>, <code>component</code>, <code>oneOfType</code>, <code>renderable</code>, <code>shape</code> to <code>React.PropTypes</code></li>
<li>Added support for <code>statics</code> on component spec for static component methods</li>
<li>On all events, <code>.currentTarget</code> is now properly set</li>
<li>On keyboard events, <code>.key</code> is now polyfilled in all browsers for special (non-printable) keys</li>
<li>On clipboard events, <code>.clipboardData</code> is now polyfilled in IE</li>
<li>On drag events, <code>.dragTransfer</code> is now present</li>
<li>Added support for <code>onMouseOver</code> and <code>onMouseOut</code> in addition to the existing <code>onMouseEnter</code> and <code>onMouseLeave</code> events</li>
<li>Added support for <code>onLoad</code> and <code>onError</code> on <code>&lt;img&gt;</code> elements</li>
<li>Added support for <code>onReset</code> on <code>&lt;form&gt;</code> elements</li>
<li>The <code>autoFocus</code> attribute is now polyfilled consistently on <code>input</code>, <code>select</code>, and <code>textarea</code></li>
</ul>
<h4>Bug Fixes</h4>
<ul>
<li>React no longer adds an <code>__owner__</code> property to each component's <code>props</code> object; passed-in props are now never mutated</li>
<li>When nesting top-level components (e.g., calling <code>React.renderComponent</code> within <code>componentDidMount</code>), events now properly bubble to the parent component</li>
<li>Fixed a case where nesting top-level components would throw an error when updating</li>
<li>Passing an invalid or misspelled propTypes type now throws an error</li>
<li>On mouse enter/leave events, <code>.target</code>, <code>.relatedTarget</code>, and <code>.type</code> are now set properly</li>
<li>On composition events, <code>.data</code> is now properly normalized in IE9 and IE10</li>
<li>CSS property values no longer have <code>px</code> appended for the unitless properties <code>columnCount</code>, <code>flex</code>, <code>flexGrow</code>, <code>flexShrink</code>, <code>lineClamp</code>, <code>order</code>, <code>widows</code></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/facebook/react/commits/v0.9.0/packages/react">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=react-refresh&package-manager=npm_and_yarn&previous-version=0.8.3&new-version=0.9.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/1861

Reviewed By: passy

Differential Revision: D26047350

Pulled By: mweststrate

fbshipit-source-id: ee94f7e41970ac8b01eeb4719b7a9dd0ac556398
 2021-01-26 02:59:20 -08:00
dependabot[bot]
35fe336537 Bump console-feed from 3.1.10 to 3.2.1 in /desktop (#1862) 
Summary:
Bumps [console-feed](https://github.com/samdenty99/console-feed) from 3.1.10 to 3.2.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/samdenty99/console-feed/commits">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=console-feed&package-manager=npm_and_yarn&previous-version=3.1.10&new-version=3.2.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/1862

Reviewed By: passy

Differential Revision: D26047359

Pulled By: mweststrate

fbshipit-source-id: de6735949589ea7d319dd2f48f78d3d89bb4ab47
 2021-01-25 09:14:48 -08:00
John Knox
3e911c8288 Add option to cold boot emulators 
Summary: This is useful when your emulator freezes.

Reviewed By: mweststrate

Differential Revision: D25998579

fbshipit-source-id: 236c16c3008f0e33d62e4c486b5a04383b1a59ba
 2021-01-25 08:57:01 -08:00
Michel Weststrate
d77940a839 Don't require an app in Flipper specific support questions 
Summary: Changelog: Submitting a bug report to Flipper itself no longer requires to have an app connected

Reviewed By: jknoxville

Differential Revision: D26046284

fbshipit-source-id: d86ba7668c4187629752a9c27d63209af61bda13
 2021-01-25 06:42:50 -08:00
Michel Weststrate
12e59afdc6 Remove non-Sandy UI 
Summary:
This removes the Non-Sandy UI from the Flipper codebase. It is a pretty rough scan for unused components, over time when converting more advanced components to Ant design probably even more code can be removed.

Partially used `npx ts-purge` to reveal never imported source files.

Changelog: It is no longer possible to opt out of the new Sandy UI

Reviewed By: jknoxville

Differential Revision: D25825282

fbshipit-source-id: 9041dbc7e03bce0760c9a0a34f1877851b5f06cf
 2021-01-25 04:48:45 -08:00