Commit Graph

3371 Commits

Author SHA1 Message Date
Joao Alves
5c60b2b94a Reenable windows test for DataInspector (#1102)
Summary:
Requires https://github.com/facebook/flipper/issues/1101.
Pull Request resolved: https://github.com/facebook/flipper/pull/1102

Test Plan: CI

Reviewed By: nikoant

Differential Revision: D21379837

Pulled By: passy

fbshipit-source-id: 64afbf20eb246487fbccac2f0108996507a353ed
2020-05-04 08:07:44 -07:00
greenkeeper[bot]
9658d1468d Update @types/tmp in group main to the latest version � (#1085)
Summary:
***
☝️ **Important announcement:** Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! [Find out how to migrate to Snyk and more at greenkeeper.io](https://greenkeeper.io)
***
## The devDependency [types/tmp](https://github.com/DefinitelyTyped/DefinitelyTyped) was updated from `0.1.0` to `0.2.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

 ---

**Publisher:** [types](https://www.npmjs.com/~types)
**License:** MIT

[Find out more about this release](https://github.com/DefinitelyTyped/DefinitelyTyped).

 ---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

 ---

Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/1085

Reviewed By: mweststrate

Differential Revision: D21378815

Pulled By: passy

fbshipit-source-id: 05c6dda22ae522f137bf944b287295fb42843a08
2020-05-04 07:04:01 -07:00
Joao Alves
d7bfa993a5 Add deb target to linux build (#1093)
Summary:
I'm adding the `.deb` option to linux build, it makes easier to install.
```bash
cd desktop
yarn build --linux --linux-deb
```

## Changelog

- Add deb target to linux build
Pull Request resolved: https://github.com/facebook/flipper/pull/1093

Reviewed By: mweststrate

Differential Revision: D21378807

Pulled By: passy

fbshipit-source-id: a72a85705d3c464cddd80091d38c92012bdbee2c
2020-05-04 06:15:47 -07:00
Pascal Hartig
c1b360cb0f Fix broken DataInspector test (#1100)
Summary:
Looks like we don't have a lint for `jest.mock` imports.
Pull Request resolved: https://github.com/facebook/flipper/pull/1100

Test Plan: yarn test

Reviewed By: jknoxville

Differential Revision: D21378747

Pulled By: passy

fbshipit-source-id: 118372596d6247282b1ddad1f22ed3916d303bb1
2020-05-04 05:34:47 -07:00
Chaiwat Ekkaewnumchai
fbc5d922b5 Fix ESLint Warning
Summary: Mainly, remove unused declaration

Reviewed By: mweststrate

Differential Revision: D21360395

fbshipit-source-id: 20cafefe3a650ab686534998a084301320333088
2020-05-04 05:27:33 -07:00
Anton Nikolaev
018c1f828c Fix jest auto-mocks hoisting on Windows
Summary: ts-jest transformation was not applied on Windows because of wrong pattern in jest.config. Because of this jest.mock calls was not hoisted to the top and were applied after imports.

Reviewed By: mweststrate

Differential Revision: D21379004

fbshipit-source-id: ec52f98228c5d9e58c0832f2ad201a36d6c8534e
2020-05-04 04:49:21 -07:00
Michel Weststrate
fdff6aeae0 Introduce highlight manager, add scroll on highlight
Summary:
Introduced a highlight manager, which prevents drilling the highlight through the entire component tree and causing too many re-renders.

Also smartly optimizes that non-matched highlighted text doesn't render unnecessarily, and debounces the updates.

Finally, automatically scroll to the first highlight.

Reviewed By: jknoxville

Differential Revision: D21348575

fbshipit-source-id: 71f7ba2e981ad3fc1ea7f5e7043645e6b6811fb7
2020-05-04 04:16:27 -07:00
Michel Weststrate
fd84820ee5 Add filter and highlight to JSON
Summary:
Large GraphQL responses feel pretty unwieldy, added a search option.

Added filter functionality to ManagedDataInspector, and use it in GraphQL

changelog: It is now possible to search inside GraphQL responses

making it slightly more efficient, and scrolling to the matches will be done in a next diff

Reviewed By: jknoxville

Differential Revision: D21347880

fbshipit-source-id: 85c95be0964515e737de2ab41bbdd8cc6a87544e
2020-05-04 04:16:27 -07:00
Anton Nikolaev
fe1c52f2f7 Disable cancelling all Node CI jobs if one of them failed (#1096)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1096

Disable cancelling all Node CI jobs if one of them failed. This will help to detect whether build is failing on all OSes (linux, mac, windows) or only some of them.

Reviewed By: mweststrate

Differential Revision: D21370606

fbshipit-source-id: 86cb3f1a2eb45e2832c5770414c0ca58e0869b66
2020-05-04 04:11:45 -07:00
John Knox
8aab57b0ac Update plugin-docusaurus-internaldocs-fb
Summary: 0.1.0 was using the wrong url. Upgrading to 0.1.1 which contains the right one.

Reviewed By: passy

Differential Revision: D21350730

fbshipit-source-id: 9ae7c42935c5d8f1db9a2bd72172a93f45771533
2020-05-01 15:57:27 -07:00
Pritesh Nandgaonkar
e15f6ccdc8 Commit Podfile.lock
Summary: This diff commits Podile.lock, once this diff gets landed I will add a github action to automatically raise a PR with the updated Podfile.lock

Reviewed By: cekkaewnumchai

Differential Revision: D21348940

fbshipit-source-id: e3bcdb8699442aa8d3092d9517c332eeb9c02981
2020-05-01 14:11:00 -07:00
Pascal Hartig
8818fbe375 Build all artifacts from packlist
Summary:
Instead of hardcoding the targets, it will now build all specified
types in the "packlist".

Reviewed By: jknoxville

Differential Revision: D21349762

fbshipit-source-id: 58f4a3bbf0b6ff4dd87eb44bbd7b200127da8017
2020-05-01 09:43:17 -07:00
Pascal Hartig
2c20f016d4 Use anyhow for error handling
Summary:
This is a nice solution if you don't want to spend
too much time thinking about error handling.
You have one common return type and can basically use `?`
everywhere while still maintaining the flexibility to
create custom error types where needed.

Reviewed By: jknoxville

Differential Revision: D21349046

fbshipit-source-id: 073539ce8422cdb3e0141886e95321052bc0c7a3
2020-05-01 09:43:16 -07:00
Pritesh Nandgaonkar
6f9d82117e Publish pods gh (#1083)
Summary:
This PR adds a github action to publish pods on a new tag. It also tries to fix a race condition which happens when we try to publish FlipperKit pod. During the release of FlipperKit pod, we rely on the newly published Flipper Pod, and sometimes the release of Flipper Pod takes a time to get updated in the cocoapods trunk.

This is a known issue by the Cocoapods and they will be shipping a fix to this in Cocoapods 1.10. Till then we can keep retrying for 5 times.

Ref: https://github.com/CocoaPods/CocoaPods/issues/9502#issuecomment-579486258

## Changelog

- Adds Github actions to publish cocoapods.
- Removes the Circle CI config to publish on cocoapods
Pull Request resolved: https://github.com/facebook/flipper/pull/1083

Test Plan: I tested this action by running it on this PR and it worked fine.

Reviewed By: jknoxville

Differential Revision: D21348084

Pulled By: priteshrnandgaonkar

fbshipit-source-id: f33f3cdef43ae032ad42c94db72323212e40ec67
2020-05-01 09:07:02 -07:00
John Knox
c5cd182ac6 Use docusaurus-plugin-internaldocs-fb
Summary: Adds a docusaurus plugin to direct fb employees to the internal documentation.

Reviewed By: nikoant

Differential Revision: D21348579

fbshipit-source-id: 5093d68a23ec6ba91c6ae94bf7cb0e58fcf3e7ef
2020-05-01 07:03:01 -07:00
Pascal Hartig
155a8c6952 Initial packer project
Summary:
This is a tool (right now more a script, really) for splitting a Flipper distribution into smaller chunks that can be individually cached, hashed and downloaded. It's incomplete but can already bundle up Mac apps into smaller chunks that can be merged back again into one app.

It takes a config file that specifies how to slice the inputs up and comes with a default copy bundled in. That's in line with the general "design" where it tries to make the right assumptions, for instance defaulting to the normal dist output directory.

Reviewed By: jknoxville

Differential Revision: D21302551

fbshipit-source-id: b22670ff4825ce526dd0f20320f87080c058cd93
2020-05-01 04:04:48 -07:00
Dan Melnic
de5147a516 Add support for io_uring based async read/recvmsg
Summary:
Add support for io_uring based async read/recvmsg

(Note: this ignores all push blocking failures!)

Reviewed By: kevin-vigor

Differential Revision: D21208891

fbshipit-source-id: 21b3b5e0f201e982ecb50a284d03ab53413ec3e3
2020-04-30 13:30:22 -07:00
John Knox
a0cd37b5ef Distinguish links from regular text
Summary: Changes the link color to something that isn't very similar to the rest of the text.

Reviewed By: nikoant

Differential Revision: D21328856

fbshipit-source-id: 9467e368411caeb58e00642b48ef4413d285850e
2020-04-30 10:26:24 -07:00
Anton Nikolaev
a47cd12c84 Fixed publishing of "flipper-pkg"
Summary: There was an error on "lint" command, because json schemas was not published as a part of npm package

Reviewed By: jknoxville

Differential Revision: D21328254

fbshipit-source-id: 531d5892ccfea0c68a6369d44af43c840c3fe4ca
2020-04-30 10:21:44 -07:00
John Knox
263aba9f31 Add custom edit url for ui-components page
Summary:
This page is auto generated, so the default link gives a 404.
Pointing it to the script instead.

Reviewed By: passy

Differential Revision: D21325554

fbshipit-source-id: 5ede07daa6335ad0199a11c5483e328c3ca2c5e3
2020-04-30 07:13:47 -07:00
Pascal Hartig
ac400e5420 Update homepage title
Summary:
It's currently a lower-case "index" which looks a bit off. :)

{F235813923}

Reviewed By: mweststrate

Differential Revision: D21324972

fbshipit-source-id: 6b75b23aa0122e2db08f7532205b6e07758155fc
2020-04-30 06:59:31 -07:00
Michel Weststrate
5db7820820 Add support for Jest runner
Summary:
This diff adds compatibility with https://marketplace.visualstudio.com/items?itemName=Orta.vscode-jest and makes sure the `yarn jest` command works without further arguments by defaulting to the unit test setup.

This makes tests runnable from VSCode, highlights which tests passed, and show errors inline (and coverage as well if desired), and will report failing tests in the problems panel.

{F235815220}

The debugger can be started right from the code pane as well by clicking the tiny 'debug'

{F235815208}

Currently set up the defaults to not start tests after startup, as it can be CPU hogging, so simply run the command CMD+SHIFT+P 'start jest runner' instead.

Reviewed By: passy

Differential Revision: D21325241

fbshipit-source-id: 7b87297a710a18bbac394110dc2006218ccc7d86
2020-04-30 06:32:34 -07:00
Michel Weststrate
b474ef24e0 expand components slowly
Summary:
This diff introduces the concept of `shouldExpand` in DataInspector. Rather than expanding components right away, we only expand if the CPU is idly, this makes sure our app remains interactive, rather than stalling for 15 seconds as shown in the example query.

In the future we could solve the blocking by using react suspense as well, but this solution has the nice benefit that it allows inspecting and interacting with the data right away.

Changelog: The JSON inspector in plugins like GraphQL no longer freezes Flipper temporarily when expanding large data sets and will remain interactive during

Reviewed By: jknoxville

Differential Revision: D21302821

fbshipit-source-id: 6a53858f9062175596dc695c4af172d60422abe7
2020-04-30 06:32:34 -07:00
Michel Weststrate
3726bddefc Refactor some render computations to local state
Summary: The goal of this stack is to gradually expand large data trees, rather than all at once. To enable that, we need to be able to distinguish 'expandability' vs. 'being expanded'. By moving computations from render to the component hooks and store the results locally, we get a step closer to that.

Reviewed By: jknoxville

Differential Revision: D21301927

fbshipit-source-id: cfb617214d4b2005796b33b41c1abe0032e41847
2020-04-30 06:32:34 -07:00
Michel Weststrate
8f22cf9e81 Add unit tests
Summary:
Added unit tests to DataInspector prevent regressions in upcoming refactor

Found a bug where changes in `collapsed` aren't propagated. Fixed as well.

Reviewed By: jknoxville

Differential Revision: D21301858

fbshipit-source-id: 764bddeff30f9d4dbfc85d990635f67c20cfacb1
2020-04-30 06:32:33 -07:00
Pascal Hartig
5c05e4e85b Point "Report Problems" to Workplace internally
Summary: OSS continues to be GitHub issues.

Reviewed By: mweststrate

Differential Revision: D21324887

fbshipit-source-id: c024337d7f8e976d9f755de928a0af29d76d4321
2020-04-30 06:05:46 -07:00
Pascal Hartig
1011042bdb Remove bugnub
Summary:
Good bye, sweet prince.
We've decided to remove the internal bugnub as its usage is quite low
and the experience is subpar. In the future, we'd rather reuse the
support form v2 and integrate it with our group.

Reviewed By: mweststrate

Differential Revision: D21300627

fbshipit-source-id: d3c7271efcee4ad22ec76394870902f2712e392d
2020-04-30 06:05:46 -07:00
John Knox
4a777df617 Fix more links
Summary:
Somehow I missed these two the last time.
These are the final broken links reported by https://www.brokenlinkcheck.com/broken-links.php#status except for the "edit this page" link on the autogenerated ui-components page.

Reviewed By: mweststrate

Differential Revision: D21325511

fbshipit-source-id: dbc61bbed1366a007ed2cdde3a72f8ea974d871f
2020-04-30 05:59:01 -07:00
Anton Nikolaev
fc18bafb71 Fix workspace version bumping script to also bump peerDependencies
Summary: Fixed bumping of local peer dependencies and manually bumped the version which was not bumped automatically during the latest release.

Reviewed By: passy

Differential Revision: D21308701

fbshipit-source-id: 936a04b432ad3c9313644c1bf96966c52e022d7e
2020-04-30 04:32:36 -07:00
Anton Nikolaev
b0a0b0f355 Babel transformations refactoring
Summary: Just a small refactoring to only create array with plugins once. This should make transformations a bit faster as all these methods are called many times for each file in the project.

Reviewed By: passy

Differential Revision: D21308498

fbshipit-source-id: 0ed47f13cebfebd2992817caa207dc55f1dbeb0a
2020-04-30 04:29:41 -07:00
Anton Nikolaev
c21ccedf14 Dev mode: fixed loading plugins located outside of the Flipper source root folder
Summary: Dev mode: fixed loading of plugins located outside of the Flipper source root folder, e.g. in ~/flipper-plugins as suggested in tutorial docs.

Reviewed By: passy

Differential Revision: D21306639

fbshipit-source-id: bb9044b25324065f0c12169b95fbe663da8d4305
2020-04-30 04:29:41 -07:00
John Knox
b27f8ee236 Fix broken links inside app
Summary:
Searched for broken link patterns inside the app itself. I think I found them all but it's not certain.

Patterns searched for and replaced:
```
.html
getting-started/)
getting-started)
getting-started"
```

and also searched the repo for regex `\]\(.*)` and checked them by eye.

Reviewed By: passy

Differential Revision: D21306944

fbshipit-source-id: a2e09b0fd8677f5f26e5cc4a06805b474247f7e6
2020-04-30 03:19:22 -07:00
Dan Yang
56b4d43eb0 Database Plugin - Increase blob max length and attempt to render UTF-8
Summary: 512 is a pretty small blob length. Increasing it to 5120 and changing it to attempt to stringify UTF-8 if not ascii.

Reviewed By: jknoxville

Differential Revision: D21253132

fbshipit-source-id: 1cc9226b86a9b9ddfd73e29c8b0c04ac54b5b4b2
2020-04-29 16:11:22 -07:00
Dan Yang
3e0f07ac97 Database plugin - Render blob cells
Summary: As titled. The android plugin was already sending the data in blob cells as `{ type: 'blob' value: string }` (see com/facebook/flipper/plugins/databases/ObjectMapper.java?lines=213-216).

Reviewed By: jknoxville

Differential Revision: D21253129

fbshipit-source-id: 15a44c72f4030887a50faece780c89aa65f6a45b
2020-04-29 16:11:21 -07:00
Chaiwat Ekkaewnumchai
168d06011f Try to Retrieve Body from Request
Summary:
Previously, requests were passed to process first in an interceptor, and it is responsibility of an interceptor to process requests for responses. In FlipperOkhttpInterceptor, we did read data from request body before processing it. This caused a bug when the network process itself wants to also read that data, but the stream has been closed because the interceptor has just read. The fix is to report request body after we have triggered network call so that we can just drop request body if we cannot read.

This diff tries to bring back the same functionality while not cause the bug to occur by cloning the content to be read by Flipper and using the same one for the request.

Reviewed By: jknoxville

Differential Revision: D21279679

fbshipit-source-id: 47f8b29a1896705d8d2d601661cd485db572d251
2020-04-29 10:47:16 -07:00
Adam Ernst
affade67ff Remove unused getAllNodes support from Layout plugin impl
Summary: Added in D14209157, but the JavaScript no longer ever calls this method.

Reviewed By: jknoxville

Differential Revision: D21290792

fbshipit-source-id: df1969d83f0dc096a24977c15c27100d2f2bdfc0
2020-04-29 08:37:55 -07:00
generatedunixname89002005306973
60e9ebb4f1 Flipper Snapshot Bump: v0.40.1-SNAPSHOT
Summary: Releasing snapshot version 0.40.1-SNAPSHOT

Reviewed By: nikoant

Differential Revision: D21302036

fbshipit-source-id: cbf996760ca70db53607ebec722ac593fa882959
2020-04-29 08:33:04 -07:00
generatedunixname89002005306973
bd320b94e1 Flipper Release: v0.40.0
Summary: Releasing version 0.40.0

Reviewed By: nikoant

Differential Revision: D21302037

fbshipit-source-id: 2f2aeaf0aaf7a0d2fb65b21b6243c9ecd2684cdc
2020-04-29 08:33:04 -07:00
Scott Kyle
c7a6908093 Add API to retrieve Java Object from Flipper objects
Summary: There's no existing API on the Flipper objects to get an arbitrary Java object, which we need in an inspector plugin we're building (`getDynamic` requires you to know what you want in the end).

Reviewed By: jknoxville

Differential Revision: D21223329

fbshipit-source-id: 29e9f8788be404cec44c6ddeb6b56b939b97b766
2020-04-29 08:27:21 -07:00
John Knox
7e4682b694 Fix the remaining broken links on fbflipper.com
Summary:
Used https://www.brokenlinkcheck.com/broken-links.php#status for now to find broken links and fixed them all.

Would be better to use some automated tool to check this at diff time, but that's not setup yet.

Reviewed By: passy

Differential Revision: D21301702

fbshipit-source-id: f13c8769b15d9f99563fc65dc0544320d07a2bfb
2020-04-29 07:33:43 -07:00
Pascal Hartig
f1abd8a4a4 Update bump binaries
Summary: Update pre-compiled binaries in the repo by running `stack build` on Linux and MacOS.

Reviewed By: nikoant

Differential Revision: D21301515

fbshipit-source-id: f3b648c03a4ec7c680c88574caa3f4abbe5e0fe0
2020-04-29 06:34:58 -07:00
Pascal Hartig
c21a2645ed Fix doc path
Summary: This was broke the script from running.

Reviewed By: nikoant

Differential Revision: D21301581

fbshipit-source-id: 146c4bacb638171d8efe9ba1d25d75cac0b19a06
2020-04-29 06:34:58 -07:00
Pritesh Nandgaonkar
513414de04 Make integration of new groups simpler
Summary: This diff simplifies the way new groups can be added into the Support form. Users will have to just make an entry in constants folder, thats it. It will automatically be added into the support form.

Reviewed By: jknoxville

Differential Revision: D21257033

fbshipit-source-id: 8823855c7a7732862a964fc17fa7311512b861db
2020-04-29 05:41:46 -07:00
Pritesh Nandgaonkar
38186c8995 Add dropdown for selecting groups
Summary: This diff refactors the group selection to the dropdown. As with the growing list of grps, dropdown will be easy to search and scale

Reviewed By: mweststrate

Differential Revision: D21175998

fbshipit-source-id: 90f1a81dfc6c2232cd2dcf767ed01205fc63e1fd
2020-04-29 05:41:45 -07:00
John Knox
281cd67ddb Fix some broken links
Summary:
KESHAmambo pointed out some internal links are broken on the website: https://twitter.com/KESHAmambo/status/1255443093542895619

The way relative links are processed in docusaurus v1 and v2 has changed. This fixes them up.

Reviewed By: mweststrate

Differential Revision: D21301293

fbshipit-source-id: 7610e38a55bc066625373cf2eee9a3efb63aec08
2020-04-29 05:21:31 -07:00
Adam Ernst
c62760b3e8 Speed up Flipper by using background queue for serialization
Reviewed By: jknoxville

Differential Revision: D21290732

fbshipit-source-id: 21fcb793900a6517d764fa3a581255fd75a39801
2020-04-28 21:32:49 -07:00
John Knox
b483e0688d Make h3 smaller than h2
Summary:
After moving to docusaurus v2, our h3 tags are bigger than the h2 tags.
Removing our custom css fixes this, so doing that to get closer to the default theme.

Reviewed By: mweststrate

Differential Revision: D21283840

fbshipit-source-id: ceaf7488b90bbb90a463037d9e1dfcca1d694366
2020-04-28 17:33:25 -07:00
John Knox
6554f23853 Fix numbered list syntax
Summary:
Numbered list syntax changed during the docusaurus migration from v1 to v2.

It looks wrong at https://fbflipper.com/docs/extending/js-setup/

This fixes it.

I searched for "1)" and replaced all numbered lists it found.

Reviewed By: mweststrate

Differential Revision: D21283693

fbshipit-source-id: adeb6e04693f50e0a0cfe4b2de5f4663075c34ce
2020-04-28 17:33:25 -07:00
Scott Kyle
39a384e33d Syntax highlight state values
Summary: This adds simple syntax highlighting for state value in the table.

Differential Revision: D21223208

fbshipit-source-id: 82b474cf19e3e13f5ebe5c474dc0f7d41cf4a56a
2020-04-28 15:54:22 -07:00
Anton Nikolaev
cdc851f281 Fix release version bumping in docs
Summary: Fix release version bumping in docs after switching from ".md" to ".mdx".

Reviewed By: mweststrate

Differential Revision: D21282492

fbshipit-source-id: 60ecfd9a058b71d1895945c9c3d05b9df8f6493c
2020-04-28 11:43:58 -07:00