Summary: This removes the mocked bookmarks section (which is being reimplemented in D24620250), so that early adopter don't see a non-working piece of UI
Reviewed By: passy
Differential Revision: D24827181
fbshipit-source-id: 9759f069bdbcc1efe3f1ecb56954ee539bbca1f0
Summary: For RN Debugger an ugly hack is used that roars its head now again; to make sure that the embedded debugger state isn't lost when switching to a different plugin, the chrome devtools are rendered _outside_ the domNode where they should normally appeared, and made invisible rather than removed when becoming invisible. Since at this moment this is the only place where we apply the trick, figured for now to condone it, rather than making a neater abstraction out of it (or kiling it all together)
Reviewed By: passy
Differential Revision: D24786771
fbshipit-source-id: 726617899bc620fc8b9db677d9413b31d5ad7653
Summary:
Bumps [data-encoding](https://github.com/ia0/data-encoding) from 2.3.0 to 2.3.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="34d1f0e89a"><code>34d1f0e</code></a> Release 2.3.1</li>
<li><a href="47b548f82a"><code>47b548f</code></a> Fix deps.rs URLs</li>
<li><a href="3236d7fc82"><code>3236d7f</code></a> lib: Update changelog</li>
<li><a href="289dca9030"><code>289dca9</code></a> Update documentation</li>
<li><a href="76e21dd413"><code>76e21dd</code></a> Remove stable feature</li>
<li><a href="21eb6991b8"><code>21eb699</code></a> Add no-std test for macro</li>
<li><a href="a89028bcfc"><code>a89028b</code></a> force proc-macro to be no_std compatable</li>
<li><a href="848efe37c1"><code>848efe3</code></a> Add dependency badge to readme</li>
<li><a href="3699a0d665"><code>3699a0d</code></a> Update LICENSE date</li>
<li><a href="6476fb0bb1"><code>6476fb0</code></a> lib: Maybe fix <a href="https://github-redirect.dependabot.com/ia0/data-encoding/issues/33">https://github.com/facebook/flipper/issues/33</a></li>
<li>See full diff in <a href="https://github.com/ia0/data-encoding/compare/v2.3.0...v2.3.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1656
Test Plan: Ran `cargo check`.
Reviewed By: mweststrate
Differential Revision: D24826840
Pulled By: passy
fbshipit-source-id: 353416e0efb3e6bae16773cd535d6bd4f62825e3
Summary: This adds macOS compatibility to Flipper client along with some of the standard plugins.
Reviewed By: jknoxville
Differential Revision: D24644439
fbshipit-source-id: dc15636a6ac1bf684fa1c89735f51f0e97667b62
Summary:
This should resolve all but one dependabot PRs. The `sha2` dependency
changes an API that's incompatible with our internally checked-in
`digest` crate.
Reviewed By: nikoant
Differential Revision: D24791506
fbshipit-source-id: 9a74e24b0efbe9c32c49c79eeb804eb9257bfb01
Summary:
No longer necessary as this is now taken care of by the new unified release Action.
Pull Request resolved: https://github.com/facebook/flipper/pull/1655
Test Plan: Next release, I'm afraid.
Reviewed By: nikoant
Differential Revision: D24782070
Pulled By: passy
fbshipit-source-id: 36ce0db814ad60fa04e4ed81b3657323bc5c983b
Summary:
allow-large-files
This diff introces the `NUX` element that can be wrapped around any other element to give a first-time usage hint.
Hint dismissal is stored by taking a hash of the hint contents, and scoped per plugin.
Users can reset the 'read' status in the settings page
Example usage:
```
<NUX
title="Use bookmarks to directly navigate to a location in the app."
placement="right">
<Input addonAfter={<SettingOutlined />} defaultValue="mysite" />
</NUX>
```
Reviewed By: nikoant
Differential Revision: D24622276
fbshipit-source-id: 0265634f9ab50c32214b74f033f59482cd986f23
Summary:
When creating the plugin overview (https://docs.google.com/spreadsheets/d/181jKpsUHO3q8I1G-bMcu-O7Hr3f4GCDVXKMVY2beOuQ/edit?usp=sharing) found some plugins with inactive points of contact
Per title, having no PoC entry makes it more clear there is none, rather than having an ex-employee in there that can't be reached
Reviewed By: nikoant
Differential Revision: D24783043
fbshipit-source-id: a852f87f42350476558bc9fc67cb3ad427268a2f
Summary: Encountered while debugging. Seems that the id was incorrect. This diff changes the id back to `"Example"`
Reviewed By: nikoant
Differential Revision: D24782578
fbshipit-source-id: ad1c6d6fe4962179ad609728c8641adc2063e929
Summary:
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.12.0 to 6.15.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md">eslint-config-prettier's changelog</a>.</em></p>
<blockquote>
<h3>Version 6.15.0 (2020-10-27)</h3>
<ul>
<li>Added: [typescript-eslint/space-infix-ops]. Thanks to Masafumi Koba (<a href="https://github.com/ybiquitous">ybiquitous</a>)!!</li>
</ul>
<h3>Version 6.14.0 (2020-10-21)</h3>
<ul>
<li>Added: New [eslint-plugin-vue] rules: [vue/array-bracket-newline] and [vue/block-tag-newline]. Thanks to <a href="https://github.com/xcatliu">xcatliu</a>!</li>
</ul>
<h3>Version 6.13.0 (2020-10-16)</h3>
<ul>
<li>Added: New rules in [eslint-plugin-vue] 7.0 (which supports Vue 3.0). Thanks to <a href="https://github.com/xcatliu">xcatliu</a>!</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b1ace774ac"><code>b1ace77</code></a> eslint-config-prettier v6.15.0</li>
<li><a href="c4a089a2d3"><code>c4a089a</code></a> Update npm packages</li>
<li><a href="b875b6efc7"><code>b875b6e</code></a> Turn off <code>typescript-eslint/space-infix-ops</code> (<a href="https://github-redirect.dependabot.com/prettier/eslint-config-prettier/issues/164">https://github.com/facebook/flipper/issues/164</a>)</li>
<li><a href="12b126d332"><code>12b126d</code></a> eslint-config-prettier v6.14.0</li>
<li><a href="2ba1a6145b"><code>2ba1a61</code></a> Update npm packages</li>
<li><a href="219757f1ab"><code>219757f</code></a> Turn off new eslint-plugin-vue rules (<a href="https://github-redirect.dependabot.com/prettier/eslint-config-prettier/issues/163">https://github.com/facebook/flipper/issues/163</a>)</li>
<li><a href="4edf6e6bc5"><code>4edf6e6</code></a> eslint-config-prettier v6.13.0</li>
<li><a href="ba40e0d165"><code>ba40e0d</code></a> Update npm packages</li>
<li><a href="fdc25da880"><code>fdc25da</code></a> Support eslint-plugin-vue@7 (which support Vue 3.0) (<a href="https://github-redirect.dependabot.com/prettier/eslint-config-prettier/issues/162">https://github.com/facebook/flipper/issues/162</a>)</li>
<li><a href="d5ae0c6e68"><code>d5ae0c6</code></a> Fix broken links in readme</li>
<li>Additional commits viewable in <a href="https://github.com/prettier/eslint-config-prettier/compare/v6.12.0...v6.15.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1636
Reviewed By: passy
Differential Revision: D24756414
Pulled By: cekkaewnumchai
fbshipit-source-id: 952d2f13caa3fb1536cccf9913dd42d148385536
Summary:
This quite often fails in CI. Adobe's fetch has some very sensible defaults
and will do exponential backoff and retry for up to a minute.
That should hopefully fix issues where we have to restart the whole build
just to fix one measly icon download.
Reviewed By: jknoxville
Differential Revision: D24649807
fbshipit-source-id: efbc9eb29e4b5a0f74b0b6ad6dea4aaf86391363
Summary:
Noticed that the icon download fails occasionally from GitHub.
This adds a few retries in case that happens.
Reviewed By: nikoant
Differential Revision: D24647690
fbshipit-source-id: 3ed84cb0972b7715fd87c8b1e1e1bca9f89485a9
Summary:
As part of our release confidence effort, this replaces the flaky internal task that creates the tag, promotes it to a release and uploads the artifacts to it.
Instead, we do all this in one lengthy GitHub Action. There seems to be some duplication here but this is because of the unfortunate restriction GitHub Actions imposes to avoid recursive Actions. I.e. we cannot create a tag/release and have another, independent Action pick up from there to do the building and releasing.
The `passy/` references were necessary because existing Actions didn't quite what we wanted to:
- `tag-version-commit` expected the title of the commit to match the precise tag to create. However, we want to use a regex to *extract* from the "Flipper Release: vA.B.C". My fork allows specifying a grouping regex for that.
- `github-upload-release-artifacts-action` relied on being triggered by a tag. As described above, that's not possible with this setup. Instead, this takes an existing tag and attaches to it.
Reviewed By: nikoant
Differential Revision: D24627518
fbshipit-source-id: 8121df6aa7bd36bda28e0d3cb207a002cd127647
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1652
Reviewed By: jknoxville
Differential Revision: D24710268
Pulled By: nikoant
fbshipit-source-id: 6f387d715a51127dc09c2f01852a84d583fe9eec
Summary:
Reported in [the Workplace group](https://fb.workplace.com/groups/flippersupport/permalink/1002324710248187/), the empty array and object in network plugin wasn't shown and left blank. This happened because data component checked for expandability and decided empty object is not expandable. Thus, it uses different path to render components.
This diff fixes that by rendering empty array and object as `[]` and `{}`
Reviewed By: jknoxville
Differential Revision: D24726219
fbshipit-source-id: 9b22e1011c39c363b73f759477f44f08520734a7
Summary:
Bumps [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) from 6.4.0 to 6.4.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/CHANGELOG.md">eslint-plugin-jsx-a11y's changelog</a>.</em></p>
<blockquote>
<h1>6.4.1 / 2020-10-26</h1>
<ul>
<li>f8a4496 Upgrade jsx-ast-utils to v3.1.0</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c99beef4f3"><code>c99beef</code></a> 6.4.1</li>
<li><a href="f8a4496b55"><code>f8a4496</code></a> Upgrade jsx-ast-utils to v3.1.0</li>
<li><a href="1834668927"><code>1834668</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/evcohen/eslint-plugin-jsx-a11y/issues/753">https://github.com/facebook/flipper/issues/753</a> from jsx-eslint/tag-6.4.0</li>
<li><a href="a6d883d4c6"><code>a6d883d</code></a> CHANGELOG update for v6.4.0</li>
<li>See full diff in <a href="https://github.com/evcohen/eslint-plugin-jsx-a11y/compare/v6.4.0...v6.4.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1640
Reviewed By: passy
Differential Revision: D24702721
Pulled By: cekkaewnumchai
fbshipit-source-id: 9614cf295774e171edd34a353f997a8ece9f720c
Summary:
Bumps [types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.2 to 14.14.6.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1645
Reviewed By: passy
Differential Revision: D24702589
Pulled By: cekkaewnumchai
fbshipit-source-id: 5f4c6cb0fed8681174aa4325ada03501da5f6241
Summary:
Bumps [npm-packlist](https://github.com/npm/npm-packlist) from 2.1.2 to 2.1.4.
<details>
<summary>Commits</summary>
<ul>
<li><a href="1f77b1b955"><code>1f77b1b</code></a> 2.1.4</li>
<li><a href="240ffb94a4"><code>240ffb9</code></a> push to git before npm</li>
<li><a href="9cb1dbf04a"><code>9cb1dbf</code></a> Strip slashes from package files list results</li>
<li><a href="3d1edd544e"><code>3d1edd5</code></a> 2.1.3</li>
<li><a href="abacc4099b"><code>abacc40</code></a> Maintain order in package.json files array globs</li>
<li>See full diff in <a href="https://github.com/npm/npm-packlist/compare/v2.1.2...v2.1.4">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1647
Reviewed By: passy
Differential Revision: D24702583
Pulled By: cekkaewnumchai
fbshipit-source-id: 413fc764345d8dfab722ae77e78d71c082e3a1da
Summary:
Bumps [types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 16.9.8 to 16.9.9.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1646
Reviewed By: passy
Differential Revision: D24702607
Pulled By: cekkaewnumchai
fbshipit-source-id: 175798a63ec3d6658a19b0c41524b5399ee446e2
Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.63.0 to 0.64.0.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/facebook/flipper/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1641
Reviewed By: passy
Differential Revision: D24702739
Pulled By: cekkaewnumchai
fbshipit-source-id: 04c42ade821899e85679b22a818e5e1c221ce507
Summary:
We've been using "booted" as a shortcut to select a device in `xcrun` but that will only refer to the *first* booted simulator. If you have multiple ones, that causes screenshots, videos and logs to always be pulled from the first.
Of course, this isn't documented anywhere, because Apple, but you can instead of `booted` pass in the "UDID" and refer to a specific device in all cases.
Reviewed By: nikoant
Differential Revision: D24627077
fbshipit-source-id: 2a52a8a17776746af4b3f6ca821dcce37bb0f7c2
Summary:
This diff makes the plugin manager and support form accessible from Sandy.
Actually converting them is TODO in T78698507 / T78698498
Reviewed By: cekkaewnumchai
Differential Revision: D24620558
fbshipit-source-id: c689d95b638b77ad504915a117e909cf0d88b841
Summary:
Make sure archived are displayed as such in the UI, and normal device functions aren't available:
* taking screenshots
* bookmarks
* metro device plugins
* disabling plugins
* disabled and unavailable plugins
* mobile builds
Also moved starting an emulator to the left rail, since it isn't a function related to the current selected thing
Reviewed By: cekkaewnumchai
Differential Revision: D24620247
fbshipit-source-id: f1f469e2fc5167fd90ccb35d583988873a9bc787
Summary:
This diffs adds support for the activeSheets mechanism in Sandy. It should be removed in the future (see T78696648) since open a dialog and keeping dialog state locally results in much more straight forward code, but supporting this for now makes sure that old flows are still supported.
With this change the plugin selection during a Flipper export for example wouldn't become visible
Reviewed By: cekkaewnumchai
Differential Revision: D24620074
fbshipit-source-id: f0558f5738e86a84a5cd0b9d574a3cfd0a3bf424
Summary: See test plan, if there is little space, 'tags' tended to overflow the search box. After this change the searchbox will grow were needed.
Reviewed By: cekkaewnumchai
Differential Revision: D24563826
fbshipit-source-id: 616173db7c080561ff51a76ab0e8938c58f87820
Summary:
Just bumping the peer dependencies to be in check with the dev deps.
React doesn't seem to be directly used, so I'm not sure why it
even needs to be listed.
Reviewed By: mweststrate
Differential Revision: D24537296
fbshipit-source-id: ac6313e7e58f79f75c7bad6ad4a6068b10ecab95
Summary:
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 4.1.2 to 4.2.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md">eslint-plugin-react-hooks's changelog</a>.</em></p>
<blockquote>
<h2>4.2.0</h2>
<ul>
<li>No changes, this was an automated release together with React 17.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1614
Reviewed By: cekkaewnumchai
Differential Revision: D24590115
Pulled By: passy
fbshipit-source-id: b7f4c86c6f41ad39e389b06e79f6b3e08402a230
Summary:
Bumps [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) from 6.3.1 to 6.4.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/CHANGELOG.md">eslint-plugin-jsx-a11y's changelog</a>.</em></p>
<blockquote>
<h1>6.4.0 / 2020-10-26</h1>
<ul>
<li>83e4ff2 [Deps] update <code>axe-core</code>, <code>jsx-ast-utils</code></li>
<li>eb92b07 [Dev Deps] update <code>babel/cli</code>, <code>babel/core</code>, <code>babel/plugin-transform-flow-strip-types</code>, <code>eslint-plugin-flowtype</code>, <code>eslint-plugin-import</code>, <code>estraverse</code>, <code>expect</code>, <code>object.assign</code></li>
<li>3d98d7a [Deps] update <code>babel/runtime</code>, <code>axe-core</code></li>
<li>f702f62 [readme] add Spanish translation</li>
<li>c2ae092 [Docs] <code>no-static-element-interactions</code>: Fixed rule name in comments</li>
<li>b90e20d Fix screenreader -> screen reader</li>
<li>645900a Fixed rule name in comments</li>
<li>381b9d6 [fix:634] Ignore control elements that are hidden</li>
<li>2c47f0a [Fix] <code>autocomplete-valid</code>: workaround for axe not being able to handle <code>null</code></li>
<li>00bd6d8 Add failing test for autocomplete with dynamic type</li>
<li>3c49c9a Add WCAG guidelines to rule documentation</li>
<li>4ecaf35 Add a testcase for tablist to interactive supports focus</li>
<li>dac6864 Deprecate the accessible-emoji rule</li>
<li>5191053 Update to axobject-query@2.2.0</li>
<li>b315698 Allow negative tabindex in aria-activedescendant-has-tabindex</li>
<li>8e6fcd0 docs: fix travis badge now points to correct location at travis-ci.com</li>
<li>2234df7 Account for additional control elements in label-has-associated-control</li>
<li>5cbb718 Adding test cases for label tests</li>
<li>66c425c Additional test case for no-redundant-roles</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="78080d432d"><code>78080d4</code></a> 6.4.0</li>
<li><a href="737e492959"><code>737e492</code></a> CHANGELOG update for v6.4.0</li>
<li><a href="83e4ff2870"><code>83e4ff2</code></a> [Deps] update <code>axe-core</code>, <code>jsx-ast-utils</code></li>
<li><a href="eb92b071ef"><code>eb92b07</code></a> [Dev Deps] update <code>babel/cli</code>, <code>babel/core</code>, `babel/plugin-transform-flow-...</li>
<li><a href="3d98d7a03a"><code>3d98d7a</code></a> [Deps] update <code>babel/runtime</code>, <code>axe-core</code></li>
<li><a href="f702f627a2"><code>f702f62</code></a> [readme] add Spanish translation</li>
<li><a href="5b35bb0c98"><code>5b35bb0</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/evcohen/eslint-plugin-jsx-a11y/issues/725">https://github.com/facebook/flipper/issues/725</a> from piperchester/patch-1</li>
<li><a href="36523578a6"><code>3652357</code></a> Merge branch 'master' into patch-1</li>
<li><a href="c2ae0924c8"><code>c2ae092</code></a> [Docs] <code>no-static-element-interactions</code>: Fixed rule name in comments</li>
<li><a href="b90e20d6ab"><code>b90e20d</code></a> Fix screenreader -> screen reader</li>
<li>Additional commits viewable in <a href="https://github.com/evcohen/eslint-plugin-jsx-a11y/compare/v6.3.1...v6.4.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1630
Reviewed By: cekkaewnumchai
Differential Revision: D24590110
Pulled By: passy
fbshipit-source-id: 7a3f411025c6df142c814ed534a0da15ef9f03df
Summary:
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.12.0 to 6.14.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md">eslint-config-prettier's changelog</a>.</em></p>
<blockquote>
<h3>Version 6.14.0 (2020-10-21)</h3>
<ul>
<li>Added: New [eslint-plugin-vue] rules: [vue/array-bracket-newline] and [vue/block-tag-newline]. Thanks to <a href="https://github.com/xcatliu">xcatliu</a>!</li>
</ul>
<h3>Version 6.13.0 (2020-10-16)</h3>
<ul>
<li>Added: New rules in [eslint-plugin-vue] 7.0 (which supports Vue 3.0). Thanks to <a href="https://github.com/xcatliu">xcatliu</a>!</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="12b126d332"><code>12b126d</code></a> eslint-config-prettier v6.14.0</li>
<li><a href="2ba1a6145b"><code>2ba1a61</code></a> Update npm packages</li>
<li><a href="219757f1ab"><code>219757f</code></a> Turn off new eslint-plugin-vue rules (<a href="https://github-redirect.dependabot.com/prettier/eslint-config-prettier/issues/163">https://github.com/facebook/flipper/issues/163</a>)</li>
<li><a href="4edf6e6bc5"><code>4edf6e6</code></a> eslint-config-prettier v6.13.0</li>
<li><a href="ba40e0d165"><code>ba40e0d</code></a> Update npm packages</li>
<li><a href="fdc25da880"><code>fdc25da</code></a> Support eslint-plugin-vue@7 (which support Vue 3.0) (<a href="https://github-redirect.dependabot.com/prettier/eslint-config-prettier/issues/162">https://github.com/facebook/flipper/issues/162</a>)</li>
<li><a href="d5ae0c6e68"><code>d5ae0c6</code></a> Fix broken links in readme</li>
<li><a href="5d479e9433"><code>5d479e9</code></a> Fix tests</li>
<li><a href="e73484d8cc"><code>e73484d</code></a> Remove "Example configuration" section in readme</li>
<li>See full diff in <a href="https://github.com/prettier/eslint-config-prettier/compare/v6.12.0...v6.14.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1618
Reviewed By: cekkaewnumchai
Differential Revision: D24590112
Pulled By: passy
fbshipit-source-id: 98cf91f8bda78469348459564ea841f9b86a8705
Summary: flipper-pkg is broken because of metro package name change. This change should fix it.
Reviewed By: priteshrnandgaonkar
Differential Revision: D24591217
fbshipit-source-id: 2036c43bc0c2bb052e56740a03dc248e7daa8cfc
Summary:
Bumps [console-feed](https://github.com/samdenty99/console-feed) from 3.1.8 to 3.1.10.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/samdenty99/console-feed/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1627
Reviewed By: cekkaewnumchai
Differential Revision: D24590105
Pulled By: passy
fbshipit-source-id: 490dc7bec5f231fa3c689abfb00aea33bb27fe0e
Summary:
Everything but react-native where we'd want to go through the
upgrade wizard. Used `yarn upgrade-interactive` to hit a few dependabot updates at once.
Reviewed By: mweststrate
Differential Revision: D24537224
fbshipit-source-id: c03f86310a9e5578cccc29e346c702165482a487
Summary: Added the Metro buttons to AppInspect
Reviewed By: cekkaewnumchai
Differential Revision: D24544760
fbshipit-source-id: 1eb6face14a7950d654c95b1a8fca31b8efed99b