Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4661
Reviewed By: ivanmisuno
Differential Revision: D44995374
Pulled By: passy
fbshipit-source-id: 4c93a3750da5ae9977e62451e0bf7f3717b8c233
Summary:
The 14.3 toolchain includes `-Wstrict-prototypes` in `-Wall`. Add it to the default warning list to ensure the code is buildable with the 14.3 toolchain.
Please forward fix any build breakage introduced by this change.
Reviewed By: NSProgrammer
Differential Revision: D44371491
fbshipit-source-id: 257c7f7748b079a34ffd5c041339d518bef9d1e5
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4624
Reviewed By: passy
Differential Revision: D44301473
Pulled By: aigoncharov
fbshipit-source-id: 8edee27e69b441aed959e9555a1fe5e1d1582e88
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4604
Reviewed By: mweststrate
Differential Revision: D44131877
Pulled By: passy
fbshipit-source-id: b1ce5dd121c077e88db2c9d916edd79b7d383f18
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4528
Reviewed By: ivanmisuno
Differential Revision: D43974467
Pulled By: passy
fbshipit-source-id: b2a0b3539add658f59221acadc6701bdcae3238c
Summary: This appears to be unreferenced and it constantly confuses our header autocomplete. Remove.
Reviewed By: d16r
Differential Revision: D43408140
fbshipit-source-id: ff6db8e5e4bbda394197168680cf8d15b07666c3
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4522
^
A codemod changed the name of `CKMountable` for the OSS ComponentKit integration, this is a breaking change as we are pinned to a specific Cocoapods version of CK.
Reviewed By: passy
Differential Revision: D43303489
fbshipit-source-id: 4d8ad472735414ca8e67a8ce4409efe84aab3e94
Summary:
This change mainly removes the connection timeout period as it may introduce a race condition in which slow server connections get terminated potentially creating connection loops.
Also, suspend and wait for all operations to complete once a socket is disconnected.
Reviewed By: ivanmisuno
Differential Revision: D43048252
fbshipit-source-id: 64c28a3d3d2fd4e065084d5f55a17444385c07e0
Summary:
^
Revert as to validate this is not causing regressions: T143523262
Reviewed By: passy
Differential Revision: D42800560
fbshipit-source-id: 8db61454eabfdb259637bb97c2bb4754984ecf6f
Summary:
^
SKDescriptorMapper owns the SKNodeDescriptor instances. SKNodeDescriptor instances should only have a weak reference to the mapper as to avoid retain cycles.
Reviewed By: passy
Differential Revision: D42673698
fbshipit-source-id: 8c98709b28fc3c711dc56c179c7c362417fa1f9d
Summary:
A few changes that should make our connect/disconnect more robust:
* Certificate provider handler should be set directly to and managed by the policy.
* Instantiate the socket once, synchronously on the connect method. Explicit deallocation once, synchronously on the disconnect method.
* Clear handlers on disconnect after clearing the delegate.
* Wait for the operation queue to drain before returning.
Reviewed By: passy
Differential Revision: D42664724
fbshipit-source-id: bd482acbb64a9bc9e36fb3418d4c81afa2109305
Summary:
The diagnostics controller is not the best crafted UIViewController. It has many things that should be improved.
- This diff just sets the background of the root view to white. At least, that will ensure that its text content is always shown if the screen background happens to be black (same as font colour).
- Correct offset calculation, used for scrolling. Effectively, only set it if the content to be displayed no longer fits in the scrollview viewport.
Reviewed By: LukeDefeo
Differential Revision: D41876904
fbshipit-source-id: e2a89d8f6001e5b626c8df1d0832e77783999b81
Summary:
On Android we already had an API to send raw arguments i.e. raw json as params.
This just adds feature parity on iOS.
Reviewed By: LukeDefeo
Differential Revision: D41433777
fbshipit-source-id: abd47f987b9e2b451100e81acf6fea61cd876807
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4271
Reviewed By: passy
Differential Revision: D40755392
Pulled By: aigoncharov
fbshipit-source-id: f296fe36535ff8744ddee6b6f9d2575d71c429f9
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4238
Reviewed By: aigoncharov
Differential Revision: D40636695
Pulled By: nikoant
fbshipit-source-id: fda37eba37dd286affe977d7a9046945c8aaaab8
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4235
Reviewed By: antonk52
Differential Revision: D40471242
Pulled By: aigoncharov
fbshipit-source-id: c8028f0b4be05ff5b9156443c52a86def4d1e179
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4210
Reviewed By: mweststrate
Differential Revision: D40341306
Pulled By: aigoncharov
fbshipit-source-id: 1383835dce4ede179cb49598f0b57840712975a9
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4176
Reviewed By: cekkaewnumchai
Differential Revision: D40095627
Pulled By: cekkaewnumchai
fbshipit-source-id: c37e6c148fb346a20e7c39a112ba7a441a81e386
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4156
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
Static Docs Site previews have moved into the custom phabricator field "Static Docs", and will no longer modify test plans after 5th October 2022.
Reviewed By: antonk52
Differential Revision: D39931809
Pulled By: antonk52
fbshipit-source-id: eb234e760e9a6be321b7290ff20b5232e9840fed
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4025
Reviewed By: lblasa
Differential Revision: D38979176
Pulled By: cekkaewnumchai
fbshipit-source-id: d455bbdb5390340cd2b310d9be5045b088dbb994
Summary:
Plumbs through an optional name for FollyScopedThreadScheduler.
This allows the threads to be named in XCode/lldb.
Differential Revision: D38582449
fbshipit-source-id: 1de50d25c0f91e7003cf81cb22faf4b10a8e23a8
Summary: In a previous diff D32278523 (8764da7c0b) The desktop request was changed from send to call. Call expects a response and not all code paths return a response. Most calls to set highlight are timing out.
Reviewed By: mweststrate
Differential Revision: D38074704
fbshipit-source-id: 6e85416d6b6470efaa177ad1b74420c8237366d5
Summary:
There are many files across fbobjc relying on -include_pch and therefore they miss Foundation.h and UIKit.h includes. This diff was generated by a codemod and fixes these missing includes.
More details on the missing imports https://fb.workplace.com/groups/929548250966094/permalink/981237982463787/
Changelog: [Internal]
Reviewed By: yannickl
Differential Revision: D37282740
fbshipit-source-id: 0f419025b3cf2f811e96ff464cb19e8e5a25aa09
Summary: Some files relying on -include_pch and therefore they miss Foundation.h and UIKit.h includes. This diff is fixing missing imports
Reviewed By: rmaz
Differential Revision: D37140239
fbshipit-source-id: bc57921e0c8365e0e9a5a571d607ba40ff1b31f3
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/3804
Reviewed By: nikoant
Differential Revision: D37068378
Pulled By: passy
fbshipit-source-id: d7f30af8f568f6440fc3ab66d4c1c1fe9a99790e
Summary: This function is no longer configured, so cut flipper's configuration of it.
Reviewed By: lblasa
Differential Revision: D34513641
fbshipit-source-id: 46e909a3a1ec7924ffd3b38ff7769020a486fda4
Summary:
This change isolates the usage of folly async from Flipper. Is now self-contained in Flipper Folly schedulers.
Users of Flipper can decide not to use the types defined in that header and implement their own.
NOTE: changes are minimal, we are just replacing direct calls to folly event base with a scheduler which simply relays this on to folly.
Reviewed By: fabiomassimo
Differential Revision: D36626483
fbshipit-source-id: add0241caf4af0aa5c3b5c2e7efc2e725f5400ab
Summary:
This change isolates the usage of folly async from Flipper. Is now self-contained in Flipper Folly schedulers.
Users of Flipper can decide not to use the types defined in that header and implement their own.
NOTE: changes are minimal, we are just replacing direct calls to folly event base with a scheduler which simply relays this on to folly.
Reviewed By: fabiomassimo
Differential Revision: D36052198
fbshipit-source-id: 170d64a324a1f1f100224e2622a59cbac3c8b642
Summary:
Flipper doesn really use library specific exceptions throughout, and that's OK.
Introducing SSLException as a replacement for the existing Folly Async Socket SSL exception.
This exception originally thrown by rsocket. Because we had rsocket and websockets using the same code, websockets were creating and throwing this same exception.
With rsocket gone, we can fully replace the usage of that exception. This is also needed as to decouple Flipper from folly async components.
Reviewed By: fabiomassimo
Differential Revision: D36245624
fbshipit-source-id: f5c97c5efe063280ce95be130008dee7f4e5d788
Summary:
^
There's a similar issue/request for Android. So, this change moves the code out from the FlipperKit into Flipper as to be able to reuse it.
Reviewed By: aigoncharov
Differential Revision: D35961745
fbshipit-source-id: aa255db582a7852dc06c2feaba389d1dac3b0f67
Summary:
^
In dark mode, the logs were not visible as font color is white, same as the background color of the label explicitly set to white.
Don't set it to white (unless the text color is changed as well).
Reviewed By: antonk52
Differential Revision: D36015027
fbshipit-source-id: bf37546a13e4a2153f7307ddeebddb23f27f4403
Summary:
This diff ensures that all operations on the socket are put into a serial background queue, including delegate callbacks.
All operations are executed asynchronously except disconnect, which is made synchronous as to guarantee no resources are accessed after the call.
Reviewed By: fabiomassimo
Differential Revision: D35254499
fbshipit-source-id: 33d93926f7bfc8948095c59f12ca31f0a932b8ae
Summary:
From a different diff, it was pointed out that calling methods on self are discouraged:
Generally you want to avoid calling methods on self in dealloc because it allows you to accidentally capture references to self in dealloc, which leads to zombies.
In this case, a disconnect effectively invalidates a timer and disconnect the underlying socket. Both take place either way when the members are deallocated too. The only thing is not done is notify the caller via the event handler of a close event.
In our case, the caller actually manually disconnects before deallocating so this is not an issue.
Reviewed By: fabiomassimo
Differential Revision: D35547600
fbshipit-source-id: 9b5b9892b657a69585943613bc81344b38dbef30
Summary:
^
Changelog: Check if there's a process listening at the specified port before attempting to establish a websocket connection on iOS
Reviewed By: fabiomassimo
Differential Revision: D35546817
fbshipit-source-id: 92ccca9afd8bcdc6d79205cc277ac813e0999166
