4bcc3d0c4622c58d8a3b577a9c95b541707711d0
178 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
dependabot[bot]
|
4bcc3d0c46 |
Bump app-builder-lib from 22.14.12 to 23.0.2 in /desktop (#3505)
Summary: allow-large-files Bumps [app-builder-lib](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib) from 22.14.12 to 23.0.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases">app-builder-lib's releases</a>.</em></p> <blockquote> <h2>v23.0.2</h2> <h2>What's Changed</h2> <ul> <li>fix(app-builder-lib): export missing TS types by <a href="https://github.com/indutny-signal"><code>@indutny-signal</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6692">electron-userland/electron-builder#6692</a></li> <li>fix(signing): Include swiftshader in signing directories for windows by <a href="https://github.com/karliatto"><code>@karliatto</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6682">electron-userland/electron-builder#6682</a></li> <li>fix: Upgrading app-builder-bin in an attempt to resolve <a href="https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib/issues/6678">#6678</a> by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6684">electron-userland/electron-builder#6684</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/karliatto"><code>@karliatto</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6682">electron-userland/electron-builder#6682</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.0.1...v23.0.2">https://github.com/electron-userland/electron-builder/compare/v23.0.1...v23.0.2</a></p> <h2>v23.0.1</h2> <h2>What's Changed</h2> <ul> <li>fix: signing of user-defined binaries by <a href="https://github.com/mifi"><code>@mifi</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6660">electron-userland/electron-builder#6660</a></li> <li>chore(docs): Update winOptions.ts comment to be more explicit by <a href="https://github.com/UppaJung"><code>@UppaJung</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6670">electron-userland/electron-builder#6670</a></li> <li>fix(dmg-builder): the "import" unbound issue by <a href="https://github.com/pan93412"><code>@pan93412</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6672">electron-userland/electron-builder#6672</a></li> <li>chore(deploy): Release by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6667">electron-userland/electron-builder#6667</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/UppaJung"><code>@UppaJung</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6670">electron-userland/electron-builder#6670</a></li> <li><a href="https://github.com/pan93412"><code>@pan93412</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6672">electron-userland/electron-builder#6672</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v23.0.0...v23.0.1">https://github.com/electron-userland/electron-builder/compare/v23.0.0...v23.0.1</a></p> <h2>v23.0.0</h2> <h2>What's Changed</h2> <ul> <li>chore(app-builder-lib): update electron-osx-sign from 0.5.0 to 0.6.0 by <a href="https://github.com/baparham"><code>@baparham</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6598">electron-userland/electron-builder#6598</a></li> <li>chore(deploy): Enable docker deployments by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6560">electron-userland/electron-builder#6560</a></li> <li>chore(deps): update amannn/action-semantic-pull-request action to v3.7.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6646">electron-userland/electron-builder#6646</a></li> <li>chore(deps): update amannn/action-semantic-pull-request action to v4 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6647">electron-userland/electron-builder#6647</a></li> <li>chore(deps): update tj-actions/changed-files action to v15 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6648">electron-userland/electron-builder#6648</a></li> <li>chore(deps): update typescript-eslint monorepo to v4.33.0 by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6582">electron-userland/electron-builder#6582</a></li> <li>chore(docs): Update configuration.md - Improve productName description by <a href="https://github.com/kiruh"><code>@kiruh</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6585">electron-userland/electron-builder#6585</a></li> <li>chore(docs): Updating docs to include instructions on pnpm usage by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6658">electron-userland/electron-builder#6658</a></li> <li>chore: Exit prerelease mode by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6653">electron-userland/electron-builder#6653</a></li> <li>chore: Migrate TravisCI and CircleCI to GH Actions by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6541">electron-userland/electron-builder#6541</a></li> <li>chore: Only publish electron-builder & electron-updater tags by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6595">electron-userland/electron-builder#6595</a></li> <li>chore: readme update by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6627">electron-userland/electron-builder#6627</a></li> <li>chore: Removing Bintray support since it was sunset. Ref: <a href="https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/">https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/</a> <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556">electron-userland/electron-builder#6556</a></li> <li>docs: add vite electron builder boilerplate by <a href="https://github.com/oceanlvr"><code>@oceanlvr</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6654">electron-userland/electron-builder#6654</a></li> <li>feat(mac): Force authentication for local mac squirrel update server <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556">electron-userland/electron-builder#6556</a></li> <li>feat(updater): Add Channel Support for Github with PreRelease by <a href="https://github.com/KenCorma"><code>@KenCorma</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6505">electron-userland/electron-builder#6505</a></li> <li>feat: use <code>mergeASARs</code> API by <code>@electron/universal</code> by <a href="https://github.com/indutny-signal"><code>@indutny-signal</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6578">electron-userland/electron-builder#6578</a></li> <li>fix(dmg-builder): Support python 3 by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6617">electron-userland/electron-builder#6617</a></li> <li>fix(docs): Fixing formatting of code groups and previews by <a href="https://github.com/mmaietta"><code>@mmaietta</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6601">electron-userland/electron-builder#6601</a></li> <li>fix(nsis): Adding --INPUTCHARSET to makensis <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556">electron-userland/electron-builder#6556</a></li> <li>fix(nsis): Fail-fast for windows signature verification failures. Adding <code>-LiteralPath</code> to update file path to disregard injected wildcards <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556">electron-userland/electron-builder#6556</a></li> <li>fix(nsis): Force strip path separators for backslashes on Windows during update process <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6556">electron-userland/electron-builder#6556</a></li> <li>fix(NSIS): prevent partial overwrites by <a href="https://github.com/indutny-signal"><code>@indutny-signal</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6547">electron-userland/electron-builder#6547</a></li> <li>fix(nsis): use atomic rmdir on update by <a href="https://github.com/indutny-signal"><code>@indutny-signal</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6551">electron-userland/electron-builder#6551</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/CHANGELOG.md">app-builder-lib's changelog</a>.</em></p> <blockquote> <h2>23.0.2</h2> <h3>Patch Changes</h3> <ul> <li><a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6682">#6682</a> <a href=" |
||
Anton Nikolaev
|
37ff34390a |
Enable Marketplace for Flipper (#3491)
Summary: This is PR on top of: https://github.com/facebook/flipper/pull/3473 It adds an option to Settings to allow distribution of marketplace plugins. Also includes a simple fetch function to retrieve data from external API/server. ## Changelog Allow marketplace plugins Pull Request resolved: https://github.com/facebook/flipper/pull/3491 Test Plan: 1. Enable marketplace 2. Provide custom marketplace server (it will serve the list of internal plugins with downloadURL) 3. Test if can see Available plugins and can download/remove the plugin 4. If new update for the plugin, it should also allow auto update Reviewed By: antonk52 Differential Revision: D34586339 Pulled By: nikoant fbshipit-source-id: c887982aa0f0f9abd3b5360f22e8692a2445d345 |
||
Pascal Hartig
|
7c1251075f |
Dep bump for /desktop
Summary: Combining a bunch of dependabot PRs. N.B. I had to manually clean up the `yarn.lock` a few times because some dependencies resolved to multiple version numbers, catching tsc off-guard. allow-large-files Reviewed By: nikoant Differential Revision: D34579180 fbshipit-source-id: a4848e1010ff240d9b0e721d3878585e7b4bd078 |
||
Andrey Goncharov
|
8ee788239b |
Update version number for default plugins
Summary: Prior to this fix, plugins were copied with verion 0.0.0 which forced them to be updated with "newer" versions from marketplace Reviewed By: nikoant Differential Revision: D34457087 fbshipit-source-id: a3242578c570447f8ecf9c62bcaa69e5d9688c42 |
||
|
Andrey Goncharov
|
2ce037d96b |
Load bundled server add-ons
Reviewed By: antonk52 Differential Revision: D34238883 fbshipit-source-id: 01b4b1c1c0a63cbfb639e903f6a77307ae370330 |
||
|
Andrey Goncharov
|
5cdb7c952e |
Update build scripts to support bundling server add-ons
Summary: Summary Reviewed By: nikoant Differential Revision: D34170565 fbshipit-source-id: be9904809bf33e85536a4c6ead0e753ef05209ff |
||
|
Pascal Hartig
|
1910d3b713 |
Bump dependencies in /desktop
Summary: Combining green-ticked upgrades from GitHub into one push. Reviewed By: lblasa Differential Revision: D34212788 fbshipit-source-id: 12b207a05b9df08eac5b5c58fe1025932c448258 |
||
|
dependabot[bot]
|
1f41f1dc2d |
Bump @adobe/node-fetch-retry from 2.0.0 to 2.1.0 in /desktop (#3384)
Summary: Bumps [adobe/node-fetch-retry](https://github.com/adobe/node-fetch-retry) from 2.0.0 to 2.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/adobe/node-fetch-retry/releases"><code>@adobe/node-fetch-retry</code>'s releases</a>.</em></p> <blockquote> <h2>v2.1.0</h2> <h1><a href="https://github.com/adobe/node-fetch-retry/compare/v2.0.0...v2.1.0">2.1.0</a> (2022-01-24)</h1> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Anton Kastritskiy
|
071bcaff96 |
Rename second batch for '.ts' files to '.tsx' in scripts dir
Summary: Rename first batch for '.ts' files to '.tsx' Reviewed By: passy Differential Revision: D33843246 fbshipit-source-id: eb8080db8cc3ef07820339bf8deafa208432de7c |
||
|
Anton Kastritskiy
|
b4fc108c2e |
Rename first batch for '.ts' files to '.tsx' in doctor, static and test-utils
Summary: Rename first batch for '.ts' files to '.tsx' Reviewed By: nikoant Differential Revision: D33843051 fbshipit-source-id: 68dd2dc6538afce2daaf24c6412dc5db8b38acbc |
||
|
dependabot[bot]
|
493915bc8d |
Bump dotenv from 8.2.0 to 14.2.0 in /desktop (#3344)
Summary: Bumps [dotenv](https://github.com/motdotla/dotenv) from 8.2.0 to 14.2.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md">dotenv's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/motdotla/dotenv/compare/v14.1.1...v14.2.0">14.2.0</a> (2022-01-17)</h2> <h3>Added</h3> <ul> <li>Add <code>dotenv_config_override</code> cli option</li> <li>Add <code>DOTENV_CONFIG_OVERRIDE</code> command line env option</li> </ul> <h2><a href="https://github.com/motdotla/dotenv/compare/v14.1.0...v14.1.1">14.1.1</a> (2022-01-17)</h2> <h3>Added</h3> <ul> <li>Add React gotcha to FAQ on README</li> </ul> <h2><a href="https://github.com/motdotla/dotenv/compare/v14.0.1...v14.1.0">14.1.0</a> (2022-01-17)</h2> <h3>Added</h3> <ul> <li>Add <code>override</code> option 🎉 (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/595">https://github.com/facebook/flipper/issues/595</a>)</li> </ul> <h2><a href="https://github.com/motdotla/dotenv/compare/v14.0.0...v14.0.1">14.0.1</a> (2022-01-16)</h2> <h3>Added</h3> <ul> <li>Log error on failure to load <code>.env</code> file (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/594">https://github.com/facebook/flipper/issues/594</a>)</li> </ul> <h2><a href="https://github.com/motdotla/dotenv/compare/v13.0.1...v14.0.0">14.0.0</a> (2022-01-16)</h2> <h3>Added</h3> <ul> <li><em>Breaking:</em> Support inline comments for the parser 🎉 (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/568">https://github.com/facebook/flipper/issues/568</a>)</li> </ul> <h2><a href="https://github.com/motdotla/dotenv/compare/v13.0.0...v13.0.1">13.0.1</a> (2022-01-16)</h2> <h3>Changed</h3> <ul> <li>Hide comments and newlines from debug output (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/404">https://github.com/facebook/flipper/issues/404</a>)</li> </ul> <h2><a href="https://github.com/motdotla/dotenv/compare/v12.0.4...v13.0.0">13.0.0</a> (2022-01-16)</h2> <h3>Added</h3> <ul> <li><em>Breaking:</em> Add type file for <code>config.js</code> (<a href="https://github-redirect.dependabot.com/motdotla/dotenv/pull/539">https://github.com/facebook/flipper/issues/539</a>)</li> </ul> <h2><a href="https://github.com/motdotla/dotenv/compare/v12.0.3...v12.0.4">12.0.4</a> (2022-01-16)</h2> <h3>Changed</h3> <ul> <li>README updates</li> <li>Minor order adjustment to package json format</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Pascal Hartig
|
7135456434 |
Dep bump
Summary: Get ahead of dependabot by bundling a few small bumps. Reviewed By: nikoant Differential Revision: D33739602 fbshipit-source-id: 1482c062493a4214da81cbf5daf408aa382fb0ac |
||
|
dependabot[bot]
|
629bdbea3d |
Bump socket.io from 4.4.0 to 4.4.1 in /desktop (#3313)
Summary: Bumps [socket.io](https://github.com/socketio/socket.io) from 4.4.0 to 4.4.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases">socket.io's releases</a>.</em></p> <blockquote> <h2>4.4.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>types:</strong> make <code>RemoteSocket.data</code> type safe (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4234">#4234</a>) (<a href=" |
||
|
Pascal Hartig
|
a51f25e9c2 |
Ensure distDir exists
Summary:
That avoids failures like these:
{F693123233}
Reviewed By: aigoncharov
Differential Revision: D33585422
fbshipit-source-id: b2b5af2daf7beaa796b331c5988e51ea3ed94699
|
||
|
Pascal Hartig
|
abb2c99ecd |
Increase timeout for icon download
Summary:
As mentioned in D33427938 (
|
||
Michel Weststrate
|
bc606dc073 |
fix public release build failing for flipper-server
Summary: Fixed failing release build, see https://github.com/facebook/flipper/runs/4790065925?check_suite_focus=true. Reviewed By: passy Differential Revision: D33550553 fbshipit-source-id: ecbcfa77a29e1afb7815453bc53b66a46da9aa9f |
||
|
dependabot[bot]
|
a9785c8fc9 |
Bump express from 4.17.1 to 4.17.2 in /desktop (#3257)
Summary: Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.17.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/expressjs/express/releases">express's releases</a>.</em></p> <blockquote> <h2>4.17.2</h2> <ul> <li>Fix handling of <code>undefined</code> in <code>res.jsonp</code></li> <li>Fix handling of <code>undefined</code> when <code>"json escape"</code> is enabled</li> <li>Fix incorrect middleware execution with unanchored <code>RegExp</code>s</li> <li>Fix <code>res.jsonp(obj, status)</code> deprecation message</li> <li>Fix typo in <code>res.is</code> JSDoc</li> <li>deps: body-parser@1.19.1 <ul> <li>deps: bytes@3.1.1</li> <li>deps: http-errors@1.8.1</li> <li>deps: qs@6.9.6</li> <li>deps: raw-body@2.4.2</li> <li>deps: safe-buffer@5.2.1</li> <li>deps: type-is@~1.6.18</li> </ul> </li> <li>deps: content-disposition@0.5.4 <ul> <li>deps: safe-buffer@5.2.1</li> </ul> </li> <li>deps: cookie@0.4.1 <ul> <li>Fix <code>maxAge</code> option to reject invalid values</li> </ul> </li> <li>deps: proxy-addr@~2.0.7 <ul> <li>Use <code>req.socket</code> over deprecated <code>req.connection</code></li> <li>deps: forwarded@0.2.0</li> <li>deps: ipaddr.js@1.9.1</li> </ul> </li> <li>deps: qs@6.9.6</li> <li>deps: safe-buffer@5.2.1</li> <li>deps: send@0.17.2 <ul> <li>deps: http-errors@1.8.1</li> <li>deps: ms@2.1.3</li> <li>pref: ignore empty http tokens</li> </ul> </li> <li>deps: serve-static@1.14.2 <ul> <li>deps: send@0.17.2</li> </ul> </li> <li>deps: setprototypeof@1.2.0</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/expressjs/express/blob/master/History.md">express's changelog</a>.</em></p> <blockquote> <h1>4.17.2 / 2021-12-16</h1> <ul> <li>Fix handling of <code>undefined</code> in <code>res.jsonp</code></li> <li>Fix handling of <code>undefined</code> when <code>"json escape"</code> is enabled</li> <li>Fix incorrect middleware execution with unanchored <code>RegExp</code>s</li> <li>Fix <code>res.jsonp(obj, status)</code> deprecation message</li> <li>Fix typo in <code>res.is</code> JSDoc</li> <li>deps: body-parser@1.19.1 <ul> <li>deps: bytes@3.1.1</li> <li>deps: http-errors@1.8.1</li> <li>deps: qs@6.9.6</li> <li>deps: raw-body@2.4.2</li> <li>deps: safe-buffer@5.2.1</li> <li>deps: type-is@~1.6.18</li> </ul> </li> <li>deps: content-disposition@0.5.4 <ul> <li>deps: safe-buffer@5.2.1</li> </ul> </li> <li>deps: cookie@0.4.1 <ul> <li>Fix <code>maxAge</code> option to reject invalid values</li> </ul> </li> <li>deps: proxy-addr@~2.0.7 <ul> <li>Use <code>req.socket</code> over deprecated <code>req.connection</code></li> <li>deps: forwarded@0.2.0</li> <li>deps: ipaddr.js@1.9.1</li> </ul> </li> <li>deps: qs@6.9.6</li> <li>deps: safe-buffer@5.2.1</li> <li>deps: send@0.17.2 <ul> <li>deps: http-errors@1.8.1</li> <li>deps: ms@2.1.3</li> <li>pref: ignore empty http tokens</li> </ul> </li> <li>deps: serve-static@1.14.2 <ul> <li>deps: send@0.17.2</li> </ul> </li> <li>deps: setprototypeof@1.2.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Michel Weststrate
|
b05219d09c |
Fix release build
Summary: This diff fixes the issue where flipper-server didn't properly build when creating a release build, due to plugins being resolved from both source `desktop/plugins` and `desktop/static/defaultPlugins` folders. The `desktop/plugins` folder should not be included in the build, but wasn't sure why not, as it isn't a problem for desktop release either? Anyway solved it for now to unblock releasing by using bundled-plugins, which might actually be better anyway for a bunch of use cases of flipper-server (e.g. when installed to an OD). So I think this is fine for now. It does increase the build to ~40 MB, which is still halve of our unbundled electron build. Reviewed By: aigoncharov Differential Revision: D33427938 fbshipit-source-id: c931c2d1bea1e04c7b1603a488dcb76a41488740 |
||
|
dependabot[bot]
|
f265adc976 |
Bump app-builder-lib from 22.14.8 to 22.14.12 in /desktop (#3235)
Summary: Bumps [app-builder-lib](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/app-builder-lib) from 22.14.8 to 22.14.12. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases">app-builder-lib's releases</a>.</em></p> <blockquote> <h2>v22.14.12</h2> <h2>What's Changed</h2> <ul> <li>fix: specify protocol as https to complete proxy support fix by <a href="https://github.com/robertpatrick"><code>@robertpatrick</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6516">electron-userland/electron-builder#6516</a></li> <li>fix: improve logged warning during macCodeSign by <a href="https://github.com/Matrixbirds"><code>@Matrixbirds</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6522">electron-userland/electron-builder#6522</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Matrixbirds"><code>@Matrixbirds</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6522">electron-userland/electron-builder#6522</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v22.14.11...v22.14.12">https://github.com/electron-userland/electron-builder/compare/v22.14.11...v22.14.12</a></p> <h2>v22.14.11</h2> <h2>What's Changed</h2> <ul> <li>chore(deps): update dependency <code>@changesets/changelog-github</code> to v0.4.2 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6459">electron-userland/electron-builder#6459</a></li> <li>chore(deps): update dependency <code>@types/fs-extra</code> to v9.0.13 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6460">electron-userland/electron-builder#6460</a></li> <li>fix(nsis): Ignore other users processes by <a href="https://github.com/I-Otsuki"><code>@I-Otsuki</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6472">electron-userland/electron-builder#6472</a></li> <li>docs: warn users to not disable zip for macos by <a href="https://github.com/lidel"><code>@lidel</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6496">electron-userland/electron-builder#6496</a></li> <li>chore(deps): update amannn/action-semantic-pull-request action to v3.5.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6501">electron-userland/electron-builder#6501</a></li> <li>chore(deps): lock file maintenance by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6509">electron-userland/electron-builder#6509</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/I-Otsuki"><code>@I-Otsuki</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6472">electron-userland/electron-builder#6472</a></li> <li><a href="https://github.com/lidel"><code>@lidel</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6496">electron-userland/electron-builder#6496</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v22.14.10...v22.14.11">https://github.com/electron-userland/electron-builder/compare/v22.14.10...v22.14.11</a></p> <h2>v22.14.10</h2> <p>electron-updater@4.6.5</p> <h2>What's Changed</h2> <ul> <li>fix: get arch wrong with 'process.arch' in mac silicon by <a href="https://github.com/zhanjinfeng"><code>@zhanjinfeng</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6381">electron-userland/electron-builder#6381</a></li> <li>fix(app-builder-lib): channel alternation for github is not working by <a href="https://github.com/saadshahd"><code>@saadshahd</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6449">electron-userland/electron-builder#6449</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/zhanjinfeng"><code>@zhanjinfeng</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6381">electron-userland/electron-builder#6381</a></li> <li><a href="https://github.com/saadshahd"><code>@saadshahd</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6449">electron-userland/electron-builder#6449</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v22.14.9...v22.14.10">https://github.com/electron-userland/electron-builder/compare/v22.14.9...v22.14.10</a></p> <h2>v22.14.9</h2> <h2>What's Changed</h2> <ul> <li>fix(nsis): fix per-machine installs by <a href="https://github.com/robertpatrick"><code>@robertpatrick</code></a> in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6450">electron-userland/electron-builder#6450</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/robertpatrick"><code>@robertpatrick</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/electron-userland/electron-builder/pull/6450">electron-userland/electron-builder#6450</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/electron-userland/electron-builder/compare/v22.14.8...v22.14.9">https://github.com/electron-userland/electron-builder/compare/v22.14.8...v22.14.9</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/CHANGELOG.md">app-builder-lib's changelog</a>.</em></p> <blockquote> <h2>22.14.12</h2> <h3>Patch Changes</h3> <ul> <li>Updated dependencies [<a href=" |
||
|
dependabot[bot]
|
4ba96dd2b7 |
Bump @babel/code-frame from 7.16.0 to 7.16.7 in /desktop (#3239)
Summary: Bumps [babel/code-frame](https://github.com/babel/babel/tree/HEAD/packages/babel-code-frame) from 7.16.0 to 7.16.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@babel/code-frame</code>'s releases</a>.</em></p> <blockquote> <h2>v7.16.7 (2021-12-31)</h2> <p>Thanks <a href="https://github.com/exb"><code>@exb</code></a> for your first PR!</p> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14049">#14049</a> fix: check preceding line break before exclamation (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-plugin-transform-runtime</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14081">#14081</a> Import the correct <code>./typeof.js</code> helper in <code>babel/runtime</code> (<a href="https://github.com/exb"><code>@exb</code></a>)</li> </ul> </li> <li><code>babel-helpers</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14072">#14072</a> Fix derived classes in Chrome <= 36 (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-plugin-transform-function-name</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14047">#14047</a> Fix unicode handling in generated function names (<a href="https://github.com/The-x-Theorist"><code>@The-x-Theorist</code></a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14067">#14067</a> Allow <code>$schema</code> property in json config files (<a href="https://github.com/The-x-Theorist"><code>@The-x-Theorist</code></a>)</li> </ul> </li> </ul> <h4>Committers: 4</h4> <ul> <li>Endrit Bajo (<a href="https://github.com/exb"><code>@exb</code></a>)</li> <li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li>Sneh Khatri (<a href="https://github.com/The-x-Theorist"><code>@The-x-Theorist</code></a>)</li> </ul> <h2>v7.16.6 (2021-12-14)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14055">#14055</a> fix: handle tokens for invalid template element (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> </ul> <h4>Committers: 2</h4> <ul> <li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> <h2>v7.16.5 (2021-12-13)</h2> <p>Thanks <a href="https://github.com/chimurai"><code>@chimurai</code></a> and <a href="https://github.com/krosenberg"><code>@krosenberg</code></a> for your first PRs!</p> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-cli</code>, <code>babel-core</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-proposal-decorators</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-jscript</code>, <code>babel-plugin-transform-parameters</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-plugin-transform-spread</code>, <code>babel-plugin-transform-typescript</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12115">#12115</a> Mark class prototype as read-only (<a href="https://github.com/wentout"><code>@wentout</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-plugin-transform-parameters</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14032">#14032</a> Fix: default rest argument array elements as undefined (<a href="https://github.com/The-x-Theorist"><code>@The-x-Theorist</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-arrow-functions</code>, <code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14036">#14036</a> Don't resolve shadowed <code>arguments</code> variables from functions (<a href="https://github.com/The-x-Theorist"><code>@The-x-Theorist</code></a>)</li> </ul> </li> <li><code>babel-parser</code></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/code-frame</code>'s changelog</a>.</em></p> <blockquote> <h2>v7.16.7 (2021-12-31)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14049">#14049</a> fix: check preceding line break before exclamation (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-plugin-transform-runtime</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14081">#14081</a> Import the correct <code>./typeof.js</code> helper in <code>babel/runtime</code> (<a href="https://github.com/exb"><code>@exb</code></a>)</li> </ul> </li> <li><code>babel-helpers</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14072">#14072</a> Fix derived classes in Chrome <= 36 (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-plugin-transform-function-name</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14047">#14047</a> Fix unicode handling in generated function names (<a href="https://github.com/The-x-Theorist"><code>@The-x-Theorist</code></a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-core</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14067">#14067</a> Allow <code>$schema</code> property in json config files (<a href="https://github.com/The-x-Theorist"><code>@The-x-Theorist</code></a>)</li> </ul> </li> </ul> <h2>v7.16.6 (2021-12-14)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14055">#14055</a> fix: handle tokens for invalid template element (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> </ul> <h2>v7.16.5 (2021-12-13)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-cli</code>, <code>babel-core</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-proposal-decorators</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-jscript</code>, <code>babel-plugin-transform-parameters</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-plugin-transform-spread</code>, <code>babel-plugin-transform-typescript</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12115">#12115</a> Mark class prototype as read-only (<a href="https://github.com/wentout"><code>@wentout</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-plugin-transform-parameters</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14032">#14032</a> Fix: default rest argument array elements as undefined (<a href="https://github.com/The-x-Theorist"><code>@The-x-Theorist</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-arrow-functions</code>, <code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14036">#14036</a> Don't resolve shadowed <code>arguments</code> variables from functions (<a href="https://github.com/The-x-Theorist"><code>@The-x-Theorist</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14039">#14039</a> maintain estree string literal shape when cloned (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14016">#14016</a> Fix duplicate declaration error on ambient class declarations (<a href="https://github.com/The-x-Theorist"><code>@The-x-Theorist</code></a>)</li> </ul> </li> <li><code>babel-generator</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14014">#14014</a> Support flow function type annotation with no parent (<a href="https://github.com/krosenberg"><code>@krosenberg</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-react-jsx</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14012">#14012</a> Fix JSX pragma anywhere in comment (<a href="https://github.com/The-x-Theorist"><code>@The-x-Theorist</code></a>)</li> </ul> </li> <li><code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-environment-visitor</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-helper-module-transforms</code>, <code>babel-helper-replace-supers</code>, <code>babel-plugin-transform-classes</code>, <code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/14005">#14005</a> Fix handling of <code>this</code>&co in computed keys in arrows transform (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13968">#13968</a> Recover from shorthand assign exprs (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13975">#13975</a> fix: update UnexpectedPrivateField error message (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> </ul> <h4>📝 Documentation</h4> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Michel Weststrate
|
ebc4752077 |
Left some code comments
Summary: Added some additional code comments as requested in earlier diffs Reviewed By: passy Differential Revision: D33361691 fbshipit-source-id: 2d1adc8830af58e6cb7bac4b283a5c0171cf749e |
||
|
Michel Weststrate
|
d92c403dd2 |
Run server build as part of normal SandCastle build
Summary: Build flipper-server as normal build job. Note that `--no-rebuild-plugins` is used to save a lot of time, and Reviewed By: passy Differential Revision: D33361569 fbshipit-source-id: 55e97f81dbcfa98901ddc21e2f35f4d1134c74ef |
||
Michel Weststrate
|
582ea64011 |
Publish flipper-server to NPM (#3224)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/3224 Automatically publish to https://www.npmjs.com/package/flipper-server Changelog: [experimental] It is now possible to run a full fledged Flipper as node + browser appication by using `npx flipper-server` Pull Request resolved: https://github.com/facebook/flipper/pull/3224 Test Plan: https://github.com/facebook/flipper/runs/4659854128?check_suite_focus=true Checked that the build is non-fb, has no fb plugins etc, and runs from npm {F690008124} {F690008123} {F690008122} Reviewed By: nikoant Differential Revision: D33297125 Pulled By: mweststrate fbshipit-source-id: b5fe6fcb81c665036273db814cb61855aaceff85 |
||
|
Michel Weststrate
|
dda68de445 |
Fix issue where TypeScript errors in scripts/ folder weren't picked up
Summary: This diff fixes an issue where the `scripts` folder wasn't automatically type checked by TypeScript, and as a result `yarn flipper-server` was broken atm. Reviewed By: nikoant Differential Revision: D33348825 fbshipit-source-id: 059a834cacb881d45ae4b0933af3f1feabb90182 |
||
Andres Suarez
|
79023ee190 |
Update copyright headers from Facebook to Meta
Reviewed By: bhamodi Differential Revision: D33331422 fbshipit-source-id: 016e8dcc0c0c7f1fc353a348b54fda0d5e2ddc01 |
||
|
Michel Weststrate
|
521ef9e243 |
Check plugin entry points before bundling them stripped
Summary: When packaging plugins into flipper-server package, we assume an idiomatic plugin structure, warn and skip if a plugin doesn't conform to it. Reviewed By: antonk52 Differential Revision: D33308367 fbshipit-source-id: fd6d1dbc66739b0867034930579429e97d9e2bfa |
||
|
Michel Weststrate
|
bc98a77cf7 |
Improved build-release open args
Summary: Improved `flipper:build-release` command with several options as suggested in earlier reviews. Flags added: * `--npx` install using npx and start * `--start` run directly from the build folder * `--open` icmw previous two, spawn a browser This should generally benefit developing from for example an on-demand server (although current socket access is currently only open to local host, so a port forward or remote entry point needs to be set up) Reviewed By: antonk52 Differential Revision: D33308198 fbshipit-source-id: fb905647c8d9fbda9d3efc2bfdcbd4d03be84938 |
||
|
Michel Weststrate
|
cbda298b9d |
Add support to build flipper-server from SandCastle
Summary: This refactors the flipper-server release script in such a way that it works the same as the normal release script, which solves two problems: 1) the official release script modifies versioned files, as it touches the package.json 2) it was slightly confusing that `flipper-server/static` was filled for release builds only, but not used in dev builds 3) running test:npx without running a release build before it, would fail with hard to comprehend errors. this has been solved now by removing that script and make it an arg of `build:flipper-server` Also some further minor changes to prepare running a corresponding build / release job from SandCastle (later in this stack) Reviewed By: nikoant Differential Revision: D33297214 fbshipit-source-id: f6299aa982c3e59d1cc6479a93c56cbe4b57f85c |
||
|
Michel Weststrate
|
3dffce32b9 |
Fix GH build error on windows (#3212)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/3212 Fix a build error caused by missing types for metro-resolver. For some reason it triggers only on windows, but we don't have typings for those indeed. Reviewed By: nikoant Differential Revision: D33308474 fbshipit-source-id: 1bd4354ee3c4df54a0a8e65d890721dd9dbac013 |
||
|
Michel Weststrate
|
54dacb7e5d |
Make sure icons are bundled
Summary: Make sure icons are prefetched for flipper-server prod builds, like we do for electron, so that the user doesn't need an internet connection to see icons Reviewed By: nikoant Differential Revision: D33296389 fbshipit-source-id: bfa92d78d8d77030238e5cca10d7aa6dcfb88e8b |
||
|
Michel Weststrate
|
72fa481d27 |
Fix generation of bundled.json, make source maps work in prod builds
Summary: This diff fixes several issues around loading plugin, such as: * make suresource maps work in the flipper-server production build * make sure default plugins are no symlinked, which wouldn't work anywhere else but on the the system where it was build * support release channel param for flipper-server Bundled flipper-server is now 42MB (with icons (see later diffs) and plugins ``` ll flipper-server-v0.0.0.tgz -rw-r--r-- 1 mweststrate staff 42M 23 Dec 15:29 flipper-server-v0.0.0.tgz ``` Reviewed By: nikoant Differential Revision: D33294677 fbshipit-source-id: 63538dc8127f883fee6a3608673ad11ce239b350 |
||
|
Michel Weststrate
|
b1d960e4c4 |
Make sure plugin loading works in NPX builds
Summary: Make sure non-bundled plugins load correctly . Note that sourcemaps don't load yet Reviewed By: nikoant Differential Revision: D33278639 fbshipit-source-id: 9951286ec6df65f33149e4687261a43e6c072c31 |
||
|
Michel Weststrate
|
86b6d2c99d |
Make flipper-server NPX-able
Summary: Make sure flipper-server is bundled in such a way that it is self-contained NPX-able. Also added some checks to make sure that dev dependencies don't accidentallly end up in in Flipper buidls Reviewed By: nikoant Differential Revision: D33190254 fbshipit-source-id: 443162e537d8ca9f956acac2d7bd52cbf0c92172 |
||
|
Michel Weststrate
|
6ff4abbc67 |
Make flipper-server stand-alone servable
Summary: This diff makes flipper-server stand-alone servable as a single package. It basically works as follows: - (default) plugins are build as usually into static folder - static folder is copied into flipper-server/static (as far as relevant) - `flipper-server/src/index.tsx` is bundled into `flipper-server/dist/index.js` - `flipper-ui-browser/src/index.tsx` is bundled into `flipper-server/static/bundle.js` If flipper-server is started without the `--bundler` config, the `bundle.js` will be served statically, rather than starting up the Metro bundler with all the typical transforms (in a distributed version of the package those all wouldn't resolve) Things to be done in next diffs: * make sure plugins actually load in the non bundled setup * make sure flipper-server gets published properly * make sure build is created as part of CI At the end of this stack, running `npx flipper-server` on any machine should basically be a viable approach to get flipper up and running locally :) Reviewed By: nikoant Differential Revision: D33171107 fbshipit-source-id: 4af8ac2699467a0b55283fe084640482700744c2 |
||
|
Michel Weststrate
|
e46fcba0b2 |
Make sure that test stuff doesn't end up in bundles
Summary: When bundling a production bundle of flipper-ui / flipper-server, noticed that a lot of irrelevant stuff ends up. Like: `jest`, `metro`, `testing-library`. The whole jungle basically. Will add safety checks in the next diffs that this no longer happens Reviewed By: passy Differential Revision: D33186531 fbshipit-source-id: 1e2034153c8c4a3fac02cd9ce27d99224223df7a |
||
|
Michel Weststrate
|
e0afebeb32 |
Disabled consistently failing OSS test (#3188)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/3188 Fixes failing typescript issue (probably case sensitivity thing, on windows it was complaining about `Metro` not being resolvable while we use `metro` everywhere). Put a `ts-ignore` on it, since the metro typings we use are empty anyway Disabled a test that failed consistently on GH CI. Maybe timing or Node version issue? Reviewed By: fabiomassimo Differential Revision: D33191515 fbshipit-source-id: 18a143024824eeeafaffe4941df474591fb7b70a |
||
|
Michel Weststrate
|
cea7be7fde |
Clean up globals
Summary: This diff is some boyscouting on cleaning up our globals, and stop using them inconsistently icmw global or window Reviewed By: aigoncharov Differential Revision: D33171108 fbshipit-source-id: 400893e5f31523631a7ab6fda428524c751901f1 |
||
|
Michel Weststrate
|
5df34a337c |
Unshare global types
Summary: This diff adds `types` fields on the compiler config for every project. This way we can make sure that for example node types and packages are not available in flipper-ui-core. Without an explicit types field, all types would be shared between all packages, and implicitly included into the compilation of everything. For the same reason `types/index.d.ts` has been removed, we want to be intentional on which types are being used in which package. This diff does most of the work, the next diff will fine tune the globals, and do some further cleanup. As an alternative solution I first tried a `nohoist: **/node_modules/types/**` and make sure every package list explicitly the types used in package json, which works but is much more error prone, as for example two different react types versions in two packages will cause the most unreadable compiler error due to the types not being shared and not literally the same. Reviewed By: lawrencelomax Differential Revision: D33124441 fbshipit-source-id: c2b9d768f845ac28005d8331ef5fa1066c7e4cd7 |
||
|
Michel Weststrate
|
dcfeb4a4d5 |
Clean up packages and types
Summary:
This diff removes most deps from the root package.json, which now only contains electron and shared build / test infra structure: lint, prettier, jest, typescript.
This makes it possible to control much better which packages are used where, as all sub packages now have their deps explicitly in their package.json instead of incidentally shared. This allows for example to disable DOM types for all packages by default (flipper-plugin, ui(-core) and app still request it), and in the next diff I hope to add to this that nodeJS types are no longer shared either, so that UI oriented packages will generate compile errors when using Node built-ins
This diff removes most deps that were currently unused, and dedupes a bunch of other ones, so the build should probably be a bit smaller now as well:
{F686704253}
{F686704295}
Reviewed By: antonk52
Differential Revision: D33062859
fbshipit-source-id: 5afaa4f2103d055188382a3370c1fffa295a298a
|
||
|
Michel Weststrate
|
5ce5d897c8 |
Make loading of bundled plugins working and robust
Summary: Bundled plugins so far didn't load because the defaultPlugins was not generated yet. Fixed follow up errors that resulted from node modules not being available in the browser, and made the process more robust so that one plugin that fails to initialise doesn't kill all bundled plugins from being loaded. Cleaned up the server scripts, and reused the BUILTINS list that is already maintained in the babel transformer. Report errors during the build process if modules are referred that are stubbed out (later on we could maybe error on that) Reviewed By: aigoncharov Differential Revision: D33020243 fbshipit-source-id: 3ce13b0049664b5fb19c1f45f0b33c1d7fdbea4c |
||
|
Michel Weststrate
|
3ef1923b29 |
Use uniform Socket message size to avoid disconnects
Summary: During startup the socket connection would close a few times, among others because Scribe dumps 1.3 MB of data after startup, and the maximum payload of `socket.io` defaults to 1MB. This diff changes it to 100MB (the max size used by `ws` library). We know that we need at least > 10 MB, as that is what plugins like Network cap at. Reviewed By: aigoncharov Differential Revision: D33017653 fbshipit-source-id: 1233af6fbdc4b9eed42786ee418cfd6d43b2b433 |
||
|
Michel Weststrate
|
7e9ad72baa |
Fix --no-bundled-plugins was not respected
Summary: Even with the `--no-bundled-plugins` flag, still a hundred plugins were loaded when running flipper-server Reviewed By: timur-valiev, aigoncharov Differential Revision: D32987158 fbshipit-source-id: 19e51e7e5f8ec9e664eb48cf2f2b8936f2f5ed73 |
||
|
Michel Weststrate
|
6f9983eb42 |
Add --open / --no-open to yarn flipper-server
Summary: As a convenience, open the browser by default when starting up Reviewed By: timur-valiev Differential Revision: D32984536 fbshipit-source-id: 540abf594f2f2553880f587bcd7d4811ea36fe74 |
||
|
Michel Weststrate
|
73c6e8ee05 |
Make flipper server debuggable
Summary: This diffs adds debugging support to flipper server, by adding VSCode config for it Reviewed By: timur-valiev, aigoncharov Differential Revision: D32982874 fbshipit-source-id: 8e187ad05a05566a598db04b97e8b08e3de7e835 |
||
|
Michel Weststrate
|
ae56f2b62f |
change server build process to respect babel transforms
Summary: The build process for the server was a simple ts-node that compiled all deps. However, that didn't do any source transformations we need, like replacing `fb-stubs` with `fb` in facebook builds. This diff works out the dev build process to align more with how other parts of the code base is build, by starting metro to build and bundle the server (only the sources of flipper-server, flipper-server-core and other flipper packages are bundled, node-deps are left as is). To achieve this, since metro doesn't have support for 'external' packages like any arbitrarily other bundler, we recycle the electronRequire work around that is used in the desktop app as well Reviewed By: aigoncharov Differential Revision: D32949677 fbshipit-source-id: 00d326bb17b68aece6fb43af98d0def13b335e74 |
||
|
Andrey Goncharov
|
adb2573a1f |
Forbid imports from nested directories of flipper-common, flipper-plugin, flipper-ui-core
Summary: Forbid imports from nested directories of flipper-common, flipper-plugin, flipper-ui-core In the stack of D32926830 I occasionally imported from flipper-plugin/src/... which is not allowed. This should fix any auto-import related issues once and for all. Reviewed By: timur-valiev Differential Revision: D32987054 fbshipit-source-id: f19f6278219961ad283cacfec094a6c703ca93f8 |
||
|
Michel Weststrate
|
2b2cbb1103 |
Move offline icon storage to app/
Summary: This diff splits Facebook management into a ui-core and electron part: * Cleaned up code and introduces a uniform Icon type to describe a requested icon * Computing icon urls is done in the ui-core * Introduced a RenderHost hook that can transform the request icon into a different url, in this case, a url to load icons from disk in production builds For the browser UI, the urls are currently no rewritten since we have only dev builds (which always used only FB urls already). We could do the same rewrite in the future and download the static assets during build time. But for now this means that in the browser implementation we depend on normal browser caching, with the biggest downside that icons might not appear if the user has no internet connections. With this change we lost our last usage of staticPath computations in ui-core Reviewed By: aigoncharov Differential Revision: D32767426 fbshipit-source-id: d573b6a373e649c7dacd380cf63a50c2dbbd9e70 |
||
|
Michel Weststrate
|
86995e0d11 |
Introduce static resource URLs
Summary: Introduced an API that converts a filepath, relatively to the `desktop/static/` folder in a url that can be resolved by the render environment. This will generate `file://` urls in Electron, and root relative `/` urls in browser envs Reviewed By: aigoncharov Differential Revision: D32767427 fbshipit-source-id: 378da7709bcb19449873358a8703b9c5a5809c57 |
||
|
Michel Weststrate
|
2a4fe77404 |
Extract environment config initialisation to server-core
Summary: This diff makes most stuff that is read from the `os` package, and version info etc available from the `serverConfig` object, so that flipper-ui-core no longer needs the `os` package. Reviewed By: passy Differential Revision: D32694848 fbshipit-source-id: 93af1e95d898da9aaf351a6970b5a7652ee835c8 |
||
|
Michel Weststrate
|
de59bbedd2 |
Make plugin loading async
Summary: This diff makes plugin loading async, which we'd need in a browser env (either because we'd use `import()` or we need to fetch the source and than eval it), and deals with all the fallout of that Reviewed By: timur-valiev Differential Revision: D32669995 fbshipit-source-id: 73babf38a6757c451b8200c3b320409f127b8b5b |