Commit Graph

9202 Commits

Author SHA1 Message Date
Luke De Feo
4ada8b9322 Summary:
Make as manything as inferred enum as possible

changelog: [Logs] Improve power search config to populate dropdown for level, PID & Tag

Reviewed By: aigoncharov

Differential Revision: D51199644

fbshipit-source-id: 383b61abca5d91a8e318bbfb1aac7d3852074167
2023-11-13 04:43:05 -08:00
Andrey Goncharov
a400eb2872 Finalize log stream before exiting process
Reviewed By: antonk52

Differential Revision: D51229230

fbshipit-source-id: 0e7f657a170eb8602ade9abf1db1976c5b51dc3f
2023-11-11 08:21:12 -08:00
Anton Kastritskiy
0cbd640e5c expand on ios doctor suggestions
Summary:
this should help to address support posts like this one

https://fb.workplace.com/groups/flippersupport/posts/1724631861350798

Reviewed By: potomak

Differential Revision: D51203549

fbshipit-source-id: 097faeb6c9d506bc1fa2ac4602cba95e99a4e2cb
2023-11-10 09:54:08 -08:00
Anton Kastritskiy
45157c3675 Change order of ios checks
Summary:
Current order is confusion, the new order better reflects order at which users gets started with iOS

1. Install Xcode
2. Point Xcode-select at most recent xcode version
3. Install SDK
4. Accept Xcode SDK license
5. check idb health

Reviewed By: lblasa

Differential Revision: D51202202

fbshipit-source-id: da39acf7ef325889c2288b3941cef0ca803356cd
2023-11-10 09:54:08 -08:00
Anton Kastritskiy
b7a4741e40 remove all mentions of metro from flipper-ui-core
Summary: All functionality was about selecting plugins

Reviewed By: lblasa

Differential Revision: D51200129

fbshipit-source-id: edc33c2b989eabec2ca4a7e285f92c50950977ed
2023-11-10 09:34:52 -08:00
Anton Kastritskiy
5269800738 remove metro button
Reviewed By: lblasa

Differential Revision: D51199560

fbshipit-source-id: ebd844a57b0b30859b186361136cc8a2f897d9f2
2023-11-10 09:34:52 -08:00
Andrey Goncharov
9ca6f01c40 Use simplified enum config for network plugin
Reviewed By: LukeDefeo

Differential Revision: D51203032

fbshipit-source-id: fc2a9a1dcd55ca05381037743622b5aa9b45f24f
2023-11-10 09:08:28 -08:00
Andrey Goncharov
cd9db40e4f Support occasionally stringified null and undefined in enums
Reviewed By: LukeDefeo

Differential Revision: D51202685

fbshipit-source-id: 74d0a3d7ed956f3fafc393f180b30cd2fcc55384
2023-11-10 09:08:28 -08:00
Andrey Goncharov
2d28ca2c37 Support enum label inferral for simplified config
Reviewed By: LukeDefeo

Differential Revision: D51199436

fbshipit-source-id: c611f0d5a21d7500447342d3e2a5e12c55e9b67d
2023-11-10 09:08:28 -08:00
Anton Kastritskiy
2d253b1387 fix displayed error in virtual device picker
Summary: Error thrown from server is serialiased that is a string, not instance of Error

Reviewed By: LukeDefeo

Differential Revision: D51201870

fbshipit-source-id: 833818789a50a21d3d27e0388635e0e2b7470c9d
2023-11-10 08:03:34 -08:00
Anton Kastritskiy
e5f6ad0ca6 default adb path
Summary:
As I was setting up a new mac I had to change this setting in flipper settings.

From a few android people that I've spoken to no one could answer me if the old one is still used.

Ideally we should infer this during the first time flipper starts

- `/opt/android_sdk` current default
- `$HOME/Library/Android/sdk` adb from Android Studio
- `$HOME/fbsource/third-party/toolchains/android-sdk` adb that is always available in fbsource

Reviewed By: lblasa

Differential Revision: D51120929

fbshipit-source-id: edb2a58b9c9f37465ea2fc5493975dd427d5523b
2023-11-10 08:03:34 -08:00
generatedunixname89002005306973
b08e6feb44 Flipper Snapshot Bump: v0.237.1-SNAPSHOT
Summary: Releasing snapshot version 0.237.1-SNAPSHOT

Reviewed By: aigoncharov

Differential Revision: D51199541

fbshipit-source-id: 97420b530bee02d2721af752a13dcd8020ada369
2023-11-10 06:50:40 -08:00
generatedunixname89002005306973
91efcce5c5 Flipper Release: v0.237.0
Summary: Releasing version 0.237.0

Reviewed By: aigoncharov

Differential Revision: D51199543

fbshipit-source-id: 4579641a9c113cd14127db69a180e76358b68de9
2023-11-10 06:50:40 -08:00
Andrey Goncharov
a1070b8cea Add regex support
Reviewed By: LukeDefeo

Differential Revision: D51198464

fbshipit-source-id: 445cc47f90c2730f3b0728e5bf667330274d103d
2023-11-10 04:34:09 -08:00
Anton Kastritskiy
d023bcc42e remove shortcuts
Reviewed By: aigoncharov

Differential Revision: D51159922

fbshipit-source-id: fbb59b416f92b9156c74a12247da8d0df07f1a4e
2023-11-10 04:33:02 -08:00
Andrey Goncharov
04b4bf7bdf Setup prefetcher during startup
Reviewed By: passy

Differential Revision: D51198236

fbshipit-source-id: 00781afda72258f2aee64a9d0481117979c49031
2023-11-10 04:11:35 -08:00
Andrey Goncharov
4b3f572205 Preserve previous error messages
Reviewed By: passy

Differential Revision: D51197113

fbshipit-source-id: 237c6f1f894cb4d758150ff2bddf14c104d3b381
2023-11-10 03:39:32 -08:00
Andrey Goncharov
8348d617d0 Fix token replacements
Reviewed By: lblasa

Differential Revision: D51196650

fbshipit-source-id: 184c104b32a1d619163c799ae70419e6aad23e98
2023-11-10 03:35:14 -08:00
Andrey Goncharov
6e19c4155c Track session length
Differential Revision: D51172955

fbshipit-source-id: d4f93564a94e232066347c945fa4798033dc0da1
2023-11-09 14:34:52 -08:00
Andrey Goncharov
8ef29c8160 Embed auth token into HTML
Summary:
Auth token used be injected in the manifest file. Instead, have the server injected into the main HTML page.

The main driver to this change are:
- Simplify
- There are instances in which for some reason reading/writing the token from the manifest fails. This will address that problem.

Reviewed By: lblasa

Differential Revision: D51160521

fbshipit-source-id: 4626fd8f56bc8b61182a53a5d9cf5acad1e723bc
2023-11-09 14:05:43 -08:00
Lorenzo Blasa
69378c4b09 Add logs for early exit when writing token to manifest
Summary: ^

Reviewed By: aigoncharov

Differential Revision: D51154908

fbshipit-source-id: 0c04ee50d07db1478ec5a77faa6d6157b7c9960b
2023-11-09 09:08:33 -08:00
Andrey Goncharov
d54bd7c3ba Refactor browser connection performance tracking
Reviewed By: lblasa

Differential Revision: D51158256

fbshipit-source-id: 17e020dd3c26ac73bf2cf0ceb4c664638c6778e9
2023-11-09 08:25:28 -08:00
Andrey Goncharov
54217f2c79 Use simplified power search config
Reviewed By: lblasa

Differential Revision: D51116200

fbshipit-source-id: a73036020649c06cb5afeb78d9c219a77dac7d4a
2023-11-09 05:08:16 -08:00
Andrey Goncharov
b5cb7fcce2 Support simplified power search config
Summary: It is quite cumbersome to list all of the operators. Much simpler to use a predefined set of power search operators we set up for each specific filed type

Reviewed By: lblasa

Differential Revision: D51116029

fbshipit-source-id: 5dd0b7f4176097109666107dfc3cab996379b818
2023-11-09 05:08:16 -08:00
Andrey Goncharov
284dee0460 Extend default list of operators for unconfigured columns
Summary:
It does not make too much sense to keep the unknown value conversion behind a flag. It is relatively cheap. Let's do it for all strings.
Also, let's extend the list of default string operators

Reviewed By: lblasa

Differential Revision: D51115573

fbshipit-source-id: a62c08a90d8ddf6f23f59412c3fd981e19225e47
2023-11-09 05:08:16 -08:00
Andrey Goncharov
51e149765e Add more logging
Reviewed By: antonk52

Differential Revision: D51154065

fbshipit-source-id: 7532d1e141562adacb9170b112185bd6f730cc5a
2023-11-09 03:57:59 -08:00
Pascal Hartig
f856cedf81 Update release docs
Summary: Document the new release flow that does no longer involve local builds.

Reviewed By: antonk52

Differential Revision: D51115563

fbshipit-source-id: 0c518e51dba64b2325047d6b1e485216e48d9777
2023-11-09 02:21:11 -08:00
Lorenzo Blasa
3993e7461d Shutdown after 5 hours
Summary:
If after 5 hours there are no connected clients, shutdown the server.

This is to prevent cases whereas the long-lived instance makes users use stale versions of Flipper if Flipper stays indefinitely running in the background.

Reviewed By: passy

Differential Revision: D51111926

fbshipit-source-id: 4c38e392cf8a6a4fb840bffdea92c0b0314aefb9
2023-11-08 10:39:18 -08:00
Lorenzo Blasa
640fb86edc Do not shutdown when there's no connected clients
Summary:
^

Also, track client closes with their code and/or error.

Reviewed By: antonk52

Differential Revision: D51110574

fbshipit-source-id: 2416e36256b000664b7677fcf2c03b045d318ed2
2023-11-08 10:39:18 -08:00
Luke De Feo
4d0a5ff42b Change how custom columsn work
Summary:
Previously the render function was selecting the data from the paylaod object, this mean what was on screen and waht powersearch saw was diffferent.

Now we supply a dotted key path and remove this from render, power search operator also uses this dotted key path so the search works

changelog: UIdebugger added powersearch operators to Framework event table

Reviewed By: aigoncharov

Differential Revision: D51113095

fbshipit-source-id: 3c951c2a8a7a0a35e0aa79a194b979b699f83008
2023-11-08 10:30:55 -08:00
Luke De Feo
03c2828630 Power search config for framework event table
Summary: Basic config, added inferred enum support for the event type.

Reviewed By: aigoncharov

Differential Revision: D51113094

fbshipit-source-id: 13acd83e7f7a5d4ee6b62641b13616cc49377e0a
2023-11-08 10:30:55 -08:00
Luke De Feo
e461229075 Enum dropdown width matches content rather than parent input
Reviewed By: aigoncharov

Differential Revision: D51112879

fbshipit-source-id: e3647df81ce7bbed91a606e68d44a503c367c948
2023-11-08 10:30:55 -08:00
Lorenzo Blasa
92d1454140 Open flag when starting server in debug mode
Summary:
It was hard-coded to always open the first time.

This allows to run the server on debug mode without opening UI.

Reviewed By: antonk52

Differential Revision: D51115746

fbshipit-source-id: 9467f0fbff45987247a2bb3bf5eb1aa578de1913
2023-11-08 09:20:13 -08:00
Lorenzo Blasa
9b9eb00b63 Endpoint to Open UI
Summary: Expose an endpoint to open Flipper UI. This will be used by the Flipper Server Cocoa app to open the UI.

Reviewed By: antonk52

Differential Revision: D51115327

fbshipit-source-id: 1ab1c32d93945cf8d75b145905983738331a6468
2023-11-08 09:20:13 -08:00
Lorenzo Blasa
137e75ad46 Refactor Open
Summary: Extract our launch UI logic into flipper-server-core.

Reviewed By: passy

Differential Revision: D51115241

fbshipit-source-id: 185e381eab6b480d86a5e1201f45c070104d0cea
2023-11-08 09:20:13 -08:00
Lorenzo Blasa
9164e04e29 Better appId and productName
Summary:
As to not conflict with non-electron installations, this will ensure the product name and app id matches the installation.

By doing this, both Flipper installations can co-exist, which I think is desirable.

Reviewed By: antonk52

Differential Revision: D51078955

fbshipit-source-id: fabaa6eb2a45ac542297b0456a09e938a2ec2e0b
2023-11-08 02:51:34 -08:00
Andrey Goncharov
3dc9cc5d3d Skip unknown values during filtering by default
Reviewed By: LukeDefeo

Differential Revision: D51078471

fbshipit-source-id: b3a005f31eebd77e9ff77349640133032f4b0164
2023-11-08 02:13:47 -08:00
Andrey Goncharov
4bb0f59ab8 Migrate to power search
Reviewed By: LukeDefeo

Differential Revision: D51027189

fbshipit-source-id: 4fb3699a278db280237e5182d41d3c746e44a2bb
2023-11-08 02:08:25 -08:00
Andrey Goncharov
a8f5fecc2b Infer enum labels
Reviewed By: LukeDefeo

Differential Revision: D51067952

fbshipit-source-id: ed39d3ab037a2169120187bf20bf4a023488c025
2023-11-08 02:08:25 -08:00
Andrey Goncharov
701ae01501 Support tracking secondary indecies in DataSource
Reviewed By: LukeDefeo

Differential Revision: D51026559

fbshipit-source-id: 1f8f40ceedf70dfdc8978e0d6e447a1a58f8f82a
2023-11-08 02:08:25 -08:00
Andrey Goncharov
da5856138d Add event emitter to datasource
Reviewed By: LukeDefeo

Differential Revision: D51026560

fbshipit-source-id: 8348c6765633d7eecf0d1c80bc5bbd5af8130298
2023-11-08 02:08:25 -08:00
Aria Fallah
3536ffe737 Add worker plugin to plugin esbuild
Summary:
## Context
https://fb.workplace.com/groups/flippersupport/posts/1722856878194963

## Changes
* Add a worker plugin that takes modules suffixed with `?worker`, bundles them, treats them as web workers, and returns a function as a default export that instanitates a new worker

Reviewed By: antonk52

Differential Revision: D51059224

fbshipit-source-id: cef89486f7a2d5b8ce38354df4a5749271a6c41d
2023-11-07 11:09:10 -08:00
Anton Kastritskiy
39b1b37172 Off vpn error banner
Summary:
Some features of bloks do not work off vpn.

Until we figure out how to make them off vpn

Reviewed By: LukeDefeo

Differential Revision: D51076469

fbshipit-source-id: c83d96e89d33d245845312b39928a7460a235217
2023-11-07 10:57:06 -08:00
generatedunixname89002005306973
4fa25b0770 Flipper Snapshot Bump: v0.236.1-SNAPSHOT
Summary: Releasing snapshot version 0.236.1-SNAPSHOT

Reviewed By: aigoncharov

Differential Revision: D50975303

fbshipit-source-id: 47629fbf8fd241ebcc05d4fd09ec72234ae3c53c
2023-11-03 16:03:43 -07:00
generatedunixname89002005306973
ddeda3f851 Flipper Release: v0.236.0
Summary: Releasing version 0.236.0

Reviewed By: aigoncharov

Differential Revision: D50975304

fbshipit-source-id: 3181dd2f913c23324e0dfbdaa068bfc32e653e12
2023-11-03 16:03:43 -07:00
Andrey Goncharov
7c5ede7a5e Force legacy search for network plugin
Summary: Uses legacy API `tableManagerRef.current?.setSearchValue` not currently available in power search

Reviewed By: LukeDefeo

Differential Revision: D50969833

fbshipit-source-id: c83d9dce24f5d7a37b6cc68e19da2ae5da374941
2023-11-03 08:03:50 -07:00
Andrey Goncharov
d9ecac4bc2 Track legacy manager API access
Summary:
We swap legacy MasterDetail and DataTable with the new ones that have power search.
The new ones have partially incompatible table manager API.
This diff adds a warning, a migration guide and  tracking for these cases.

Reviewed By: LukeDefeo

Differential Revision: D50969831

fbshipit-source-id: ef4153fec9720ea5d7ae1cb4df3528c5d6bca2bb
2023-11-03 08:03:50 -07:00
Andrey Goncharov
9c5df1516f Export legacy MasterDetail and DataTable
Summary: Allow plugin developers to force old search for migration purposes

Reviewed By: LukeDefeo

Differential Revision: D50969832

fbshipit-source-id: 7fe5c3e65680d628bced2cd09823f7f3c132d33a
2023-11-03 08:03:50 -07:00
generatedunixname89002005325672
36cb69e1fd Daily arc lint --take KTFMT
Reviewed By: martintrojer

Differential Revision: D50964272

fbshipit-source-id: 1bdfffd1b32f76f2a81e95c6a59e15805a3a9436
2023-11-03 07:00:14 -07:00
Anton Kastritskiy
99dbcfa079 casing convension
Summary:
[eslint-typescript/naming-convension rule docs](https://typescript-eslint.io/rules/naming-convention/)

Initially looked into it to enforce UPPER_CASE for top most constants like `const DELAY = 10` which is a standard in js ecosystem, which turned to be more difficuilt(we will still get there).

Turns out we had casing checks disabled for everything but typeLike names. What I did in this diff

- use default setting for eslint rule
    `✖ 9890 problems`
- with any propery names
    `✖ 8229 problems`
- without checking properies at all
    `✖ 3683 problems`
- without checking enum members
    `✖ 3231 problems`
- without checking object properties/methods
    `✖ 2978 problems`
- allowing PascalCase for variables
    `✖ 1657 problems
- allowing PascalCase for functions
    `✖ 975 problems
- not checking typeMethod and parameters
    `✖ 916 problems`
- allow double underscore before after variable
    `✖ 461 problems`
- allow snake_case variables
    `✖ 49 problems`

Fix remaining problems.

Future plans. Ban usage of PascalCase for variables that are not components

Reviewed By: LukeDefeo

Differential Revision: D50970193

fbshipit-source-id: d9f3abe6b02c9f7822598c8fa5382f58d067f70e
2023-11-03 06:16:18 -07:00