Anton Kastritskiy
4ad54db723
eslint warn on non null assertions
...
Summary:
Let's ban the non null assertion syntax `maybeNull!` as it is unsafe and can cause unexpected behavior. Ideally this should be an error or require a comment explaining why the value cannot be nullish. Though, there are 468 occurrences around the codebase and it is not worth it to manually go around fixing it now. Thus I used a warn to still warn developers to avoid the use where possible.
Last week I spend over an hour on debugging something where the code was null-asserted as the developer thought the value could never be null while in reallity it could. Adding a runtime check in this case sounds reasonable.
rule docs
https://typescript-eslint.io/rules/no-non-null-assertion/
Reviewed By: nikoant
Differential Revision: D45773327
fbshipit-source-id: 9e8a40af353ce979f469ffaedd8e777d72500dab
2023-05-11 07:30:07 -07:00
Lorenzo Blasa
a96caacb2b
EnvironmentInfo as argument to start server
...
Summary:
Clean initialisation by passing down the environment info to start server.
(Also rename dir to path as that's the name used in other places)
Reviewed By: passy
Differential Revision: D45731751
fbshipit-source-id: a60fdd49c567fc312d1f8da72db3a46a0828c140
2023-05-11 04:10:16 -07:00
Luke De Feo
0f9eeda2dd
Remove ctrl to stop drawing children
...
Summary: This feature is annoying and useless
Reviewed By: antonk52
Differential Revision: D45696921
fbshipit-source-id: 01c007d3e196a7511b940b7973bb8e6a880e27e5
2023-05-10 09:14:47 -07:00
Luke De Feo
da268f0095
Bump mock-fs
...
Summary: various tests failing due to this dep
Reviewed By: antonk52
Differential Revision: D45731274
fbshipit-source-id: cb79199c15a8973f50e5075dab16605d0120b30c
2023-05-10 07:47:19 -07:00
Szu-Kai Hsu
10f967fe60
feat: Update paste argument schema to support specified programming language ( #4732 )
...
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4732
This diff adds a `language` field into `CreatePasteArgs` type to potentially specify programming language in the paste service
Reviewed By: mweststrate
Differential Revision: D45701098
fbshipit-source-id: 080d76e5ff332518881e9c6b84aa47aaea680309
2023-05-10 07:36:49 -07:00
Luke De Feo
23ebd8b865
Change logic for generating debug wrapper for nodes
...
Summary:
Previously we would only generate debug wrapper for render core layout result when uidebugger was currently connected.
This meant if you navigate to a bloks screen *before* having the ui debugger open at render time it would read ui debugger as disconnected since the ui debugger is not a background plugin. The result is the user would see the native nodes instead of the bound tree, it was extra confusing since the layout result was cached so going forward and back doesnt solve it.
The ideal solution would be to have a global flipper is connected on the client but this isnt available yet, lorenzo said he would work on it later.
As a work around we use the fact that the uidebugger has ever been connected in this session.
It can still be confusing since the initial load of a bloks screen migt not generate the debug nodes until you navigate to the plugin once. I will add a note to the docs so say that you need to have open the uidebugger once before nodes will appear
Reviewed By: mweststrate
Differential Revision: D45605120
fbshipit-source-id: 970943b9f8f98221b7fc5e20bb1caf18c2266474
2023-05-10 05:05:34 -07:00
Lorenzo Blasa
fdd1a9e887
Use different location for token depending on build type
...
Summary:
For Electron builds, use the same directory as certificates and keys.
For headless builds, then use the static directory.
Reviewed By: antonk52
Differential Revision: D45728515
fbshipit-source-id: 55a3b143a9289fed23e57cbf6b701a5e48d27332
2023-05-10 04:35:17 -07:00
Lorenzo Blasa
b94f6b6152
Set the right environment info for headless builds
...
Summary: The isHeadlessBuild flag was not properly set.
Reviewed By: antonk52
Differential Revision: D45728435
fbshipit-source-id: 3616c4358114d4f3d96372766dabf48b27b44333
2023-05-10 04:35:17 -07:00
Ruslan Lesiutin
1086e05ba0
upgrade react-devtools to v4.27.7 in fbsource ( #4706 )
...
Summary:
X-link: https://github.com/facebook/react-native/pull/37146
Pull Request resolved: https://github.com/facebook/flipper/pull/4706
Changelog: [Internal]
Updating react-devtools-* packages to v4.27.7
Reviewed By: jacdebug
Differential Revision: D45317588
fbshipit-source-id: 5625f654feffced92ca933796e90ac10fc4801ff
2023-05-09 07:13:39 -07:00
Lorenzo Blasa
133ea43f7d
Add auth.token to .gitignore
...
Summary:
Bit annoying if everytime we run it we have to manually delete/discard file.
So, add to gitignore.
Reviewed By: LukeDefeo, passy
Differential Revision: D45688164
fbshipit-source-id: 6ae2b570f571a3d44b0c75bb3d614887e4943e5b
2023-05-09 03:12:35 -07:00
Lorenzo Blasa
238f40f55d
Mandate auth token to connect over TCP
...
Summary:
Until now, launching flipper-server with TCP would accept any incoming connection as long as it comes from the same origin (localhost) using web socket host origin verification.
This is not entirely secure as origin can be spoofed with tools like curl.
Our team created a security review and a proposal was written:
https://docs.google.com/document/d/16iXypCQibPiner061SoaQUFUY9tLVAEpkKfV_hUXI7c/
Effectively, Flipper can generate a token which is then used by the client to authenticate.
This diff contains the changes required to generate, obtain, and validate authentication tokens from clients connecting to flipper over TCP connections.
The token itself is a JWT token. JWT was chosen because it is a simple industry standard which offers three features which can immediately benefit us:
- Expiration handling. No need for Flipper to store this information anywhere.
- Payload. Payload can be used to push any data we deem relevant i.e. unix username.
- Signing. Signed and verified using the same server key pair which is already in place for certificate exchange.
Additionally, the token is stored in the Flipper static folder. This ensures that the browser and PWA clients have access to it.
Reviewed By: mweststrate
Differential Revision: D45179654
fbshipit-source-id: 6761bcb24f4ba30b67d1511cde8fe875158d78af
2023-05-05 07:52:13 -07:00
Luke De Feo
70cdc9bedc
Android start sending frame scan event instead of subtree update
...
Summary: Cosmetic change to make the events more inline with what they are
Reviewed By: lblasa
Differential Revision: D42999134
fbshipit-source-id: e026e38da7e50e8f5520271246f9627eb22e8965
2023-05-04 04:12:01 -07:00
Luke De Feo
98b94d62cf
Add bloks integration infra + Layout result wrapper
...
Summary:
This adds the base infra for the UIDebugger bloks integration as well as an implementation for the Layout result wrapper for bloks. When theUIDebugger is connected we wrap the original layout result with a debug varient that delegates all methods to the original layout result but also provides access to the bloks model.
This allows the UIDebugger to inspect the Layout result and bloks model together
Reviewed By: pasqualeanatriello
Differential Revision: D43444444
fbshipit-source-id: ac531a0c7491c05db1d6f7671e3ab09c73c213b9
2023-05-03 07:51:29 -07:00
Luke De Feo
42320e1c09
Remove focus mode when frame no longer contains previously focused mode
...
Summary:
The logic was a little outdated to when we were accumulating subtrees, now its much simpler, if the previously focused id is not in the new frame, remove focus
Changelog: UIDebugger, fix focus mode behaviour
Reviewed By: mweststrate
Differential Revision: D45523026
fbshipit-source-id: 894a85df21cc27eb57dbef411ae57743d0c4f753
2023-05-03 06:24:07 -07:00
dependabot[bot]
f4e02f04ca
Bump anyhow from 1.0.70 to 1.0.71 in /packer ( #4707 )
...
Summary:
Bumps [anyhow](https://github.com/dtolnay/anyhow ) from 1.0.70 to 1.0.71.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/anyhow/releases ">anyhow's releases</a>.</em></p>
<blockquote>
<h2>1.0.71</h2>
<ul>
<li>Documentation improvements</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8b4fc434293c33b4b072https://redirect.github.com/dtolnay/anyhow/issues/306 ">#306</a> from dtolnay/noinline</li>
<li><a href="d491b88840https://github.com/dtolnay/anyhow/compare/1.0.70...1.0.71 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4707
Reviewed By: antonk52
Differential Revision: D45484397
Pulled By: passy
fbshipit-source-id: 4c960ef862e882789a6a1ff94aafb5b62ffb5058
2023-05-02 09:12:26 -07:00
dependabot[bot]
ec22a81e4a
Bump org.mockito:mockito-core from 5.2.0 to 5.3.1 ( #4685 )
...
Summary:
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito ) from 5.2.0 to 5.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/mockito/mockito/releases ">org.mockito:mockito-core's releases</a>.</em></p>
<blockquote>
<h2>v5.3.1</h2>
<p><!-- raw HTML omitted --><!-- raw HTML omitted --><em>Changelog generated by <a href="https://github.com/shipkit/shipkit-changelog ">Shipkit Changelog Gradle Plugin</a></em><!-- raw HTML omitted --><!-- raw HTML omitted --></p>
<h4>5.3.1</h4>
<ul>
<li>2023-04-21 - <a href="https://github.com/mockito/mockito/compare/v5.3.0...v5.3.1 ">2 commit(s)</a> by Rafael Winterhalter, jfrantzius</li>
<li>Fixes 2972: Weakens visibility constraint [(<a href="https://redirect.github.com/mockito/mockito/issues/2983 ">https://github.com/facebook/flipper/issues/2983 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2983 ">mockito/mockito#2983</a>)</li>
<li>Bugfix 2974 fix npe [(<a href="https://redirect.github.com/mockito/mockito/issues/2976 ">https://github.com/facebook/flipper/issues/2976 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2976 ">mockito/mockito#2976</a>)</li>
<li>Fix for <a href="https://redirect.github.com/mockito/mockito/issues/2958 ">https://github.com/facebook/flipper/issues/2958 </a> eliminates CCE but leads to NPE [(<a href="https://redirect.github.com/mockito/mockito/issues/2974 ">https://github.com/facebook/flipper/issues/2974 </a>)](<a href="https://redirect.github.com/mockito/mockito/issues/2974 ">mockito/mockito#2974</a>)</li>
<li>Spying objects not working properly since 5.3.0 [(<a href="https://redirect.github.com/mockito/mockito/issues/2972 ">https://github.com/facebook/flipper/issues/2972 </a>)](<a href="https://redirect.github.com/mockito/mockito/issues/2972 ">mockito/mockito#2972</a>)</li>
</ul>
<h2>v5.3.0</h2>
<p><!-- raw HTML omitted --><!-- raw HTML omitted --><em>Changelog generated by <a href="https://github.com/shipkit/shipkit-changelog ">Shipkit Changelog Gradle Plugin</a></em><!-- raw HTML omitted --><!-- raw HTML omitted --></p>
<h4>5.3.0</h4>
<ul>
<li>2023-04-11 - <a href="https://github.com/mockito/mockito/compare/v5.2.0...v5.3.0 ">14 commit(s)</a> by Krzysztof Krasoń, Maciej Walkowiak, Rafael Winterhalter, Wesley Tsai, dependabot[bot], jfrantzius</li>
<li>Bump com.diffplug.spotless from 6.17.0 to 6.18.0 [(<a href="https://redirect.github.com/mockito/mockito/issues/2967 ">https://github.com/facebook/flipper/issues/2967 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2967 ">mockito/mockito#2967</a>)</li>
<li>Bump versions.bytebuddy from 1.14.3 to 1.14.4 [(<a href="https://redirect.github.com/mockito/mockito/issues/2966 ">https://github.com/facebook/flipper/issues/2966 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2966 ">mockito/mockito#2966</a>)</li>
<li>Adds <code>withoutAnnotations</code> parameter to <code>Mock</code> [(<a href="https://redirect.github.com/mockito/mockito/issues/2965 ">https://github.com/facebook/flipper/issues/2965 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2965 ">mockito/mockito#2965</a>)</li>
<li>Fix ClassCastException [(<a href="https://redirect.github.com/mockito/mockito/issues/2962 ">https://github.com/facebook/flipper/issues/2962 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2962 ">mockito/mockito#2962</a>)</li>
<li>Bump org.codehaus.groovy:groovy from 3.0.16 to 3.0.17 [(<a href="https://redirect.github.com/mockito/mockito/issues/2959 ">https://github.com/facebook/flipper/issues/2959 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2959 ">mockito/mockito#2959</a>)</li>
<li>ClassCastException when combining InjectMocks with generified Mock field [(<a href="https://redirect.github.com/mockito/mockito/issues/2958 ">https://github.com/facebook/flipper/issues/2958 </a>)](<a href="https://redirect.github.com/mockito/mockito/issues/2958 ">mockito/mockito#2958</a>)</li>
<li>Bump versions.bytebuddy from 1.14.2 to 1.14.3 [(<a href="https://redirect.github.com/mockito/mockito/issues/2950 ">#2950</a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2950 ">mockito/mockito#2950</a>)</li>
<li>Add <code>ArgumentMatchers#assertArg</code> method. [(<a href="https://redirect.github.com/mockito/mockito/issues/2949 ">https://github.com/facebook/flipper/issues/2949 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2949 ">mockito/mockito#2949</a>)</li>
<li>Fixes 2947: correct visibility check to respect nestmates [(<a href="https://redirect.github.com/mockito/mockito/issues/2948 ">https://github.com/facebook/flipper/issues/2948 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2948 ">mockito/mockito#2948</a>)</li>
<li>spy does not initialize objects fully with InstrumentationMemberAccessor [(<a href="https://redirect.github.com/mockito/mockito/issues/2947 ">https://github.com/facebook/flipper/issues/2947 </a>)](<a href="https://redirect.github.com/mockito/mockito/issues/2947 ">mockito/mockito#2947</a>)</li>
<li>Fixes <a href="https://redirect.github.com/mockito/mockito/issues/2877 ">https://github.com/facebook/flipper/issues/2877 </a>: removed mockito-inline as subproject and actual subproject [(<a href="https://redirect.github.com/mockito/mockito/issues/2945 ">https://github.com/facebook/flipper/issues/2945 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2945 ">mockito/mockito#2945</a>)</li>
<li><a href="https://redirect.github.com/mockito/mockito/issues/2934 ">https://github.com/facebook/flipper/issues/2934 </a> throw exception on multiple matches by type if cannot be reduce… [(<a href="https://redirect.github.com/mockito/mockito/issues/2942 ">https://github.com/facebook/flipper/issues/2942 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2942 ">mockito/mockito#2942</a>)</li>
<li>Bump org.eclipse.platform:org.eclipse.osgi from 3.18.200 to 3.18.300 [(<a href="https://redirect.github.com/mockito/mockito/issues/2941 ">https://github.com/facebook/flipper/issues/2941 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2941 ">mockito/mockito#2941</a>)</li>
<li>Bump com.diffplug.spotless from 6.16.0 to 6.17.0 [(<a href="https://redirect.github.com/mockito/mockito/issues/2940 ">https://github.com/facebook/flipper/issues/2940 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2940 ">mockito/mockito#2940</a>)</li>
<li>Bump org.codehaus.groovy:groovy from 3.0.15 to 3.0.16 [(<a href="https://redirect.github.com/mockito/mockito/issues/2939 ">https://github.com/facebook/flipper/issues/2939 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2939 ">mockito/mockito#2939</a>)</li>
<li>Bump versions.bytebuddy from 1.14.1 to 1.14.2 [(<a href="https://redirect.github.com/mockito/mockito/issues/2938 ">https://github.com/facebook/flipper/issues/2938 </a>)](<a href="https://redirect.github.com/mockito/mockito/pull/2938 ">mockito/mockito#2938</a>)</li>
<li>Feature suggestion: TerminalMockCandidateFilter should report error when more than one candidate left [(<a href="https://redirect.github.com/mockito/mockito/issues/2934 ">https://github.com/facebook/flipper/issues/2934 </a>)](<a href="https://redirect.github.com/mockito/mockito/issues/2934 ">mockito/mockito#2934</a>)</li>
<li>Mockito-inline dependency after upgrade 5.0.0 [(<a href="https://redirect.github.com/mockito/mockito/issues/2877 ">https://github.com/facebook/flipper/issues/2877 </a>)](<a href="https://redirect.github.com/mockito/mockito/issues/2877 ">mockito/mockito#2877</a>)</li>
<li>Assertions on parameters during verification [(<a href="https://redirect.github.com/mockito/mockito/issues/2285 ">https://github.com/facebook/flipper/issues/2285 </a>)](<a href="https://redirect.github.com/mockito/mockito/issues/2285 ">mockito/mockito#2285</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="baf59c48eahttps://redirect.github.com/mockito/mockito/issues/2983 ">https://github.com/facebook/flipper/issues/2983 </a>)</li>
<li><a href="02b9634b74https://redirect.github.com/mockito/mockito/issues/2976 ">https://github.com/facebook/flipper/issues/2976 </a>)</li>
<li><a href="6ffd23e1bfhttps://redirect.github.com/mockito/mockito/issues/2949 ">https://github.com/facebook/flipper/issues/2949 </a>)</li>
<li><a href="203132db49https://redirect.github.com/mockito/mockito/issues/2965 ">https://github.com/facebook/flipper/issues/2965 </a>)</li>
<li><a href="84a5eee1ced65bba7e6ahttps://redirect.github.com/mockito/mockito/issues/2966 ">https://github.com/facebook/flipper/issues/2966 </a>)</li>
<li><a href="600eaa06f4https://redirect.github.com/mockito/mockito/issues/2967 ">https://github.com/facebook/flipper/issues/2967 </a>)</li>
<li><a href="f9fbf50bd6https://redirect.github.com/mockito/mockito/issues/2959 ">https://github.com/facebook/flipper/issues/2959 </a>)</li>
<li><a href="0b8685c37bhttps://redirect.github.com/mockito/mockito/issues/2950 ">#2950</a>)</li>
<li><a href="5486617f7ahttps://redirect.github.com/mockito/mockito/issues/2948 ">https://github.com/facebook/flipper/issues/2948 </a>)</li>
<li>Additional commits viewable in <a href="https://github.com/mockito/mockito/compare/v5.2.0...v5.3.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4685
Reviewed By: lblasa
Differential Revision: D45350822
Pulled By: passy
fbshipit-source-id: 964ade81d6f6bf6d01233428705ec8a24bc9101d
2023-05-02 03:35:08 -07:00
Andrey Goncharov
78b650dbe0
Make fliters non-exclusive
...
Summary:
Project: https://docs.google.com/document/d/1SbFrpvfIShX5npANNa1AkgHliR1M-VMLW5Q9RhREt94/edit
Also, sync quick filters with the internal filter state of the table
Reviewed By: antonk52
Differential Revision: D45396180
fbshipit-source-id: 6a8ef4ac61a49ec7af71ae9e26f20f395fb34cef
2023-04-28 12:19:45 -07:00
Andrey Goncharov
65daaf80f1
Expose table state from table manager
...
Summary: Project: https://docs.google.com/document/d/1SbFrpvfIShX5npANNa1AkgHliR1M-VMLW5Q9RhREt94/edit
Reviewed By: antonk52
Differential Revision: D45395107
fbshipit-source-id: 8ca3639a109e40b26acead8bb4b0eace68ac9bce
2023-04-28 12:19:45 -07:00
Andrey Goncharov
424985a75a
Expose removing filters programatically
...
Summary: Project: https://docs.google.com/document/d/1SbFrpvfIShX5npANNa1AkgHliR1M-VMLW5Q9RhREt94/edit
Reviewed By: antonk52
Differential Revision: D45394864
fbshipit-source-id: d2c140d542eaee157cbad5b6a0f29fc62f73a18b
2023-04-28 12:19:45 -07:00
Andrey Goncharov
647bc06f3a
Make filtered state of columns more apparent
...
Summary: People complained about barely noticeable filtered state indication multiple times
Reviewed By: antonk52
Differential Revision: D45394233
fbshipit-source-id: 60a3531b1808ae8f95ce8cd405a20b74bad0ed46
2023-04-28 12:19:45 -07:00
Andrey Goncharov
9d2de05723
Allow to disable column sorting
...
Summary: Project: https://docs.google.com/document/d/1SbFrpvfIShX5npANNa1AkgHliR1M-VMLW5Q9RhREt94/edit#
Reviewed By: antonk52
Differential Revision: D45394048
fbshipit-source-id: 4255777d477f8240f52b5f82c28e922ef1011989
2023-04-28 12:19:45 -07:00
Andrey Goncharov
a819c77f18
Expose addColumnFilter from DataTable
...
Summary:
Project: https://docs.google.com/document/d/1SbFrpvfIShX5npANNa1AkgHliR1M-VMLW5Q9RhREt94/edit#
Used to set filters externally in next diff
Reviewed By: antonk52
Differential Revision: D45393487
fbshipit-source-id: 15c1186292f45de455ebbcbfced7a63c824a6c19
2023-04-28 12:19:45 -07:00
Andrey Goncharov
27eb5978a9
Pass TableManager instance to Details sidebar of any MasterDetail table
...
Summary: Project: https://docs.google.com/document/d/1SbFrpvfIShX5npANNa1AkgHliR1M-VMLW5Q9RhREt94/edit#
Reviewed By: passy
Differential Revision: D45354900
fbshipit-source-id: 7f968c9d235f5d8bb23e59e50e39fc1e9f498f46
2023-04-28 12:19:45 -07:00
Andrey Goncharov
423a8d1935
Revamp newScript detailed view
...
Summary: Project: https://docs.google.com/document/d/1SbFrpvfIShX5npANNa1AkgHliR1M-VMLW5Q9RhREt94/edit#
Reviewed By: antonk52
Differential Revision: D45353402
fbshipit-source-id: 88cc26f9886fd7b2cdcd5ca3d021790d8669c140
2023-04-28 12:19:45 -07:00
dependabot[bot]
4d390d0906
Bump com.squareup.okhttp3:okhttp from 4.9.3 to 4.11.0 ( #4688 )
...
Summary:
Bumps [com.squareup.okhttp3:okhttp](https://github.com/square/okhttp ) from 4.9.3 to 4.11.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="68a106d32619c634f32dhttps://redirect.github.com/square/okhttp/issues/7780 ">#7780</a>)</li>
<li><a href="40cb04338dhttps://redirect.github.com/square/okhttp/issues/7701 ">#7701</a>)</li>
<li><a href="cbcf4f32ffhttps://redirect.github.com/square/okhttp/issues/7660 ">#7660</a>)</li>
<li><a href="8eddd1d6b8https://redirect.github.com/square/okhttp/issues/7648 ">#7648</a>)</li>
<li><a href="949262e9fbhttps://redirect.github.com/square/okhttp/issues/7634 ">#7634</a>)</li>
<li><a href="81d34114e2https://redirect.github.com/square/okhttp/issues/7591 ">#7591</a>)</li>
<li><a href="e46a200fcehttps://redirect.github.com/square/okhttp/issues/6295 ">#6295</a>) (<a href="https://redirect.github.com/square/okhttp/issues/7453 ">#7453</a>)</li>
<li><a href="cf088f852ehttps://redirect.github.com/square/okhttp/issues/6792 ">#6792</a>) (<a href="https://redirect.github.com/square/okhttp/issues/7471 ">#7471</a>)</li>
<li><a href="d2d251ccaahttps://redirect.github.com/square/okhttp/issues/7454 ">#7454</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/square/okhttp/compare/parent-4.9.3...parent-4.11.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4688
Reviewed By: mweststrate
Differential Revision: D45390718
Pulled By: passy
fbshipit-source-id: d4118719fa309859ca8fdc59770980a93dd7d61d
2023-04-28 10:06:43 -07:00
dependabot[bot]
8a50364652
Bump react-native-flipper from 0.184.0 to 0.190.0 in /react-native/ReactNativeFlipperExample ( #4702 )
...
Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper ) from 0.184.0 to 0.190.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/flipper/releases ">react-native-flipper's releases</a>.</em></p>
<blockquote>
<h2>v0.190.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md ">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md </a>
for full notes.</p>
<h2>v0.189.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md ">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md </a>
for full notes.</p>
<h2>v0.188.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md ">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md </a>
for full notes.</p>
<h2>v0.187.1</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md ">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md </a>
for full notes.</p>
<h2>v0.187.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md ">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md </a>
for full notes.</p>
<h2>v0.186.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md ">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md </a>
for full notes.</p>
<h2>v0.185.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md ">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md </a>
for full notes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="f8ca1551d72583a076c08657bcba648cd2bb97bf22e28a4f3e53aca9a661c2fc54057aeee74044ff3cec113b0ehttps://redirect.github.com/facebook/flipper/issues/4675 ">https://github.com/facebook/flipper/issues/4675 </a>)</li>
<li><a href="489d9ba3e0https://redirect.github.com/facebook/flipper/issues/4679 ">https://github.com/facebook/flipper/issues/4679 </a>)</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.184.0...v0.190.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4702
Reviewed By: mweststrate
Differential Revision: D45390721
Pulled By: passy
fbshipit-source-id: 2fede4ada395eb620a3c9a39d623634676b54f47
2023-04-28 08:51:33 -07:00
dependabot[bot]
e909f8c8e7
Bump org.robolectric:robolectric from 4.9.2 to 4.10 ( #4687 )
...
Summary:
Bumps [org.robolectric:robolectric](https://github.com/robolectric/robolectric ) from 4.9.2 to 4.10.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/robolectric/robolectric/releases ">org.robolectric:robolectric's releases</a>.</em></p>
<blockquote>
<p>Robolectric 4.10 adds support for native Android graphics. It is currently disabled by default and can be enabled using <code>GraphicsMode(NATIVE)</code>. When native graphics is enabled, interactions with Android graphics classes use real native Android graphics code and are much higher fidelity.</p>
<h2>Behavior changes</h2>
<p>In Robolectric 4.10, <code>ReflectionHelpers.setStaticField</code> no longer removes the <code>final</code> keyword from static fields. This is because removing <code>final</code> using reflection stops working in JDK 18 due to <a href="https://openjdk.java.net/jeps/416 ">https://openjdk.java.net/jeps/416 </a>. To remove <code>final</code> from static fields, consider using some instrumentation-based approach, such as mockito-inline.</p>
<h2>What's Changed</h2>
<ul>
<li>Remove dead code that uses Plan based instrumentation (ClassHandler.Plan) <a href="https://redirect.github.com/robolectric/robolectric/pull/7610 ">robolectric/robolectric#7610</a></li>
<li>Run SDK 33 tests on CI by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7613 ">robolectric/robolectric#7613</a></li>
<li>Bump maximum API for GMD to SDK 33 by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7614 ">robolectric/robolectric#7614</a></li>
<li>Remove use-sdk from androidx_test/sharedTest/AndroidManifest.xml by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7615 ">robolectric/robolectric#7615</a></li>
<li>[Warning] Eliminated AnnotateFormatMethod warnings by <a href="https://github.com/hellosagar "><code>@hellosagar</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7353 ">robolectric/robolectric#7353</a></li>
<li>Remove 0x prefix for string format log by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7617 ">robolectric/robolectric#7617</a></li>
<li>Bump compile/targetSdk to 33 by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7616 ">robolectric/robolectric#7616</a></li>
<li>Remove unused Exception for ShadowActivityTest by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7618 ">robolectric/robolectric#7618</a></li>
<li>Support Activity setShowWhenLocked() and setTurnScreenOn() by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7438 ">robolectric/robolectric#7438</a></li>
<li>Exclude kotlin-stdlib dependency from utils generated .pom by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7607 ">robolectric/robolectric#7607</a></li>
<li>Move dependencies of shadows/framework to gradle.properties by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7627 ">robolectric/robolectric#7627</a></li>
<li>Bump ASM to 9.3 by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7626 ">robolectric/robolectric#7626</a></li>
<li>Add the ability to deploy specific preinstrumented jars to maven by <a href="https://github.com/hoisie "><code>@hoisie</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7602 ">robolectric/robolectric#7602</a></li>
<li>Combine exceptions for ReflectionHelpers#getDeclaredField by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7634 ">robolectric/robolectric#7634</a></li>
<li>Clean up ShadowAccountManager by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7636 ">robolectric/robolectric#7636</a></li>
<li>Migrate Gradle dependencies to dependencies.gradle by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7635 ">robolectric/robolectric#7635</a></li>
<li>Add alternative to Unsafe.defineAnonymousClass by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7633 ">robolectric/robolectric#7633</a></li>
<li>Support all authentication results for BiometricManager by <a href="https://github.com/charlesng "><code>@charlesng</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7427 ">robolectric/robolectric#7427</a></li>
<li>Bump bcprov-jdk15on from 1.68 to 1.70 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7638 ">robolectric/robolectric#7638</a></li>
<li>Bump constraintlayout from 2.1.3 to 2.1.4 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7640 ">robolectric/robolectric#7640</a></li>
<li>Reuse bytecode of ClassWriter for ProxyMaker by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7643 ">robolectric/robolectric#7643</a></li>
<li>Migrate instance calling in ReflectionHelpers to lambda by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7644 ">robolectric/robolectric#7644</a></li>
<li>Bump compile-testing from 0.18 to 0.19 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7645 ">robolectric/robolectric#7645</a></li>
<li>Bump apiCompatVersion from 4.7 to 4.8.2 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7647 ">robolectric/robolectric#7647</a></li>
<li>Bump gson from 2.8.6 to 2.9.1 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7646 ">robolectric/robolectric#7646</a></li>
<li>Bump core from 1.5.0 to 1.9.0 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7649 ">robolectric/robolectric#7649</a></li>
<li>Clean up unused code for ShadowDisplayManagerTest by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7662 ">robolectric/robolectric#7662</a></li>
<li>Remove unused shadows ShadowCornerPathEffect and ShadowLinearGradient <a href="https://redirect.github.com/robolectric/robolectric/pull/7668 ">robolectric/robolectric#7668</a></li>
<li>Bump apiCompatVersion from 4.8.2 to 4.9 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7672 ">robolectric/robolectric#7672</a></li>
<li>Add call to $$robo$init for Jacoco-instrumented constructors <a href="https://redirect.github.com/robolectric/robolectric/pull/7677 ">robolectric/robolectric#7677</a></li>
<li>Respect ShadowProvider priority when populating the ShadowPicker map <a href="https://redirect.github.com/robolectric/robolectric/pull/7686 ">robolectric/robolectric#7686</a></li>
<li>Properly parse & populate process information from the manifest. ServiceInfo.processName and ActivityInfo.processName will now correctly reflect the value of the process attribute from their respective manifest entry. <a href="https://redirect.github.com/robolectric/robolectric/pull/7690 ">robolectric/robolectric#7690</a></li>
<li>Bump autoServiceVersion from 1.0-rc6 to 1.0.1 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7674 ">robolectric/robolectric#7674</a></li>
<li>Create an activity context for activities. <a href="https://redirect.github.com/robolectric/robolectric/pull/6481 ">robolectric/robolectric#6481</a></li>
<li>Remove deprecated Utils#intArrayToList by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7687 ">robolectric/robolectric#7687</a></li>
<li>Fix configuration/resource handling in activity contexts <a href="https://redirect.github.com/robolectric/robolectric/pull/7692 ">robolectric/robolectric#7692</a></li>
<li>Add Java source & target compatibility config for preinstrumented by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7664 ">robolectric/robolectric#7664</a></li>
<li>Update the <code>ResourcesManager</code> configuration when applying qualifiers <a href="https://redirect.github.com/robolectric/robolectric/pull/7697 ">robolectric/robolectric#7697</a></li>
<li>Replace Config with Implementation <a href="https://redirect.github.com/robolectric/robolectric/pull/7710 ">robolectric/robolectric#7710</a></li>
<li>Switch to ubuntu-20.04 for GitHub Actions by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7716 ">robolectric/robolectric#7716</a></li>
<li>Bump errorproneVersion from 2.9.0 to 2.16 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7715 ">robolectric/robolectric#7715</a></li>
<li>Bump Kotlin to 1.7.10 by <a href="https://github.com/utzcoz "><code>@utzcoz</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7497 ">robolectric/robolectric#7497</a></li>
<li>Upgrade androidx.test and androidx.fragment versions to latest. by <a href="https://github.com/brettchabot "><code>@brettchabot</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7683 ">robolectric/robolectric#7683</a></li>
<li>Bump kotlinVersion from 1.5.20 to 1.7.20 by <a href="https://github.com/dependabot "><code>@dependabot</code></a> in <a href="https://redirect.github.com/robolectric/robolectric/pull/7694 ">robolectric/robolectric#7694</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="245c8f6405732290ae0a301c15872cf8cfc865abd2340ee8461d3cdabd68877eb6af0945cb89345940c16eaac4adb2d07ea0https://github.com/robolectric/robolectric/compare/robolectric-4.9.2...robolectric-4.10 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4687
Reviewed By: lblasa
Differential Revision: D45350804
Pulled By: passy
fbshipit-source-id: c3de6d41ec56a52ca76964f0744388d4b84c346d
2023-04-28 03:35:40 -07:00
dependabot[bot]
bbfaae3c09
Bump com.google.protobuf:protobuf-java from 3.21.12 to 3.22.3 ( #4686 )
...
Summary:
Bumps [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf ) from 3.21.12 to 3.22.3.
<details>
<summary>Commits</summary>
<ul>
<li><a href="482156c0f969776b0b0ehttps://redirect.github.com/protocolbuffers/protobuf/issues/12457 ">#12457</a> from deannagarcia/updateDep</li>
<li><a href="553422572d21b4fd581fhttps://redirect.github.com/protocolbuffers/protobuf/issues/12453 ">#12453</a> from protocolbuffers/deannagarcia-patch-5</li>
<li><a href="f51da1fe665ddb1fc609https://redirect.github.com/protocolbuffers/protobuf/issues/12406 ">#12406</a>) (<a href="https://redirect.github.com/protocolbuffers/protobuf/issues/12419 ">#12419</a>)</li>
<li><a href="f1c7820c9bhttps://redirect.github.com/protocolbuffers/protobuf/issues/12355 ">#12355</a>)</li>
<li><a href="58ecf38aa5https://redirect.github.com/protocolbuffers/protobuf/issues/12303 ">#12303</a> from protocolbuffers/deannagarcia-patch-4</li>
<li><a href="cb009b29fahttps://redirect.github.com/protocolbuffers/protobuf/issues/12301 ">#12301</a> from mkruskal-google/cmake-fix</li>
<li><a href="6e624e4f6bhttps://github.com/protocolbuffers/protobuf/compare/v3.21.12...v3.22.3 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4686
Reviewed By: lblasa
Differential Revision: D45350815
Pulled By: passy
fbshipit-source-id: d9e74f07e71a031562eac21176027c80b949003c
2023-04-28 03:30:50 -07:00
Pascal Hartig
0afdfdea63
Set up sha256 validation for wrapper ( #4704 )
...
Summary:
Just to make sure that nobody injects something in our build chain. Checksum taken from the official website: https://gradle.org/release-checksums/
Pull Request resolved: https://github.com/facebook/flipper/pull/4704
Reviewed By: antonk52
Differential Revision: D45320680
fbshipit-source-id: 2a489264f3c377ef2c6bb4557cb788b4ab19bcc5
2023-04-27 07:42:23 -07:00
Luke De Feo
862592e03d
Account for race conditions with stream intercetor
...
Summary:
Given that stream interceptor is async the folling race conditino could occur.
Frame at time t=0 comes in, we yeild to the event loop while fetching metadata, fetch takes 5 ticks
Frame at time t=1 comes in, we yeild to the event loop but fetch takes 1 tick
At time t=2 the second frame is augmented and display
At time t=5 the first fetch returns and we display and older frame
This is a simple check to avoid this.
Reviewed By: aigoncharov
Differential Revision: D45314013
fbshipit-source-id: 054e7e6beb52dfbfd94bc9f8ee3d0a758a669f66
2023-04-27 07:28:41 -07:00
Luke De Feo
7ce19f4359
Add static attributes from reduction trace
...
Summary:
In order to support this the stream inceptor transform nodes now is able to return a list of new meta enties, since these are new attributes we try to mimic what would have happened if they were generated on the client. This makes the rest of the logic downstream simpler
Introduced metadata register, same idea as on the clients.
The attributes available are a mixed bag, will work with blok server to imporove
Reviewed By: antonk52
Differential Revision: D45177781
fbshipit-source-id: 9d761b2f682e7e0fd4710f5b2e9d9d6ff26741fc
2023-04-27 07:28:41 -07:00
Luke De Feo
42963b16ab
Subtree Update => Framescan
...
Summary: This is purely a cosmetic change but more accurately reflects the nature of how we send data from device to desktop. Ie its always an entire frame rather than subtrees. This helps with correctness great Both ios and android are like this and have been for a while.
Reviewed By: lblasa
Differential Revision: D45080088
fbshipit-source-id: 8f68047056c4825b0b1dd89f26c7fa462e2ecb1b
2023-04-27 07:28:41 -07:00
Luke De Feo
47fe0641aa
Add error handling for reduciton trace and remove redundent memoization
...
Summary: We were memoizing the reduction trace fetch in the stream interceptor but this was redundant. We let the library handle that. Also pulled the calls into the uidebugger so we have more control over the retry behaviour
Reviewed By: mweststrate
Differential Revision: D45079132
fbshipit-source-id: 7354fce0fddbebdb0b027dade03398a36adc5e9a
2023-04-27 07:28:41 -07:00
Luke De Feo
4fdfbdc8df
Open in IDE for bloks derived components
...
Summary:
* Added line number as an attribute to node, in theory we could get it from the device in the case of compose
* dont need to use miles as have the file already
* cleaned up naming in ide file resolver so its clear its the qualified name we are talking about
Reviewed By: lblasa
Differential Revision: D45079135
fbshipit-source-id: 24f2d5814800a4a404b680599d307cc750758fcd
2023-04-27 07:28:41 -07:00
Luke De Feo
7cc1a1246e
Process Bloks derived components
...
Reviewed By: lblasa
Differential Revision: D45079131
fbshipit-source-id: 363f5ed2fedc6183130ef0185f8ff5bf58579c10
2023-04-27 07:28:41 -07:00
Luke De Feo
e34f3f4883
Process Bloks Bound tree
...
Summary:
1. Need to unminify the names from something call the minification map
2. Bloks attributes themselves are already minified. However the uidebugger also has a similar concept in its own metadata so the data we get off the device has been minified twice. To fix this we remap the metadata off the device using the minification map. In order to find the correct entry we need to get the style id of the bloks model parent. this is sent as a metadata custom attribute
Reviewed By: lblasa
Differential Revision: D45079136
fbshipit-source-id: bb448d81918c0b8c9e8ac87c4390b46a8a374d78
2023-04-27 07:28:41 -07:00
Luke De Feo
c96535e15f
Infrastructure for stream inteceptor transform metadata
...
Summary:
Hooked up metadata to the stream inteceptor, enhanced error handling to deal with:
1. Recording subsequent metadata messaages that came in while in error state such that all of them are processed
2. Recording any frames that came in while in error state such that after recovering from error we have the latest state
3. Splitting out recoverable and non recoverable errors more explicitly
Reviewed By: lblasa
Differential Revision: D45079137
fbshipit-source-id: 67a2ffef72d94d2b1492f201a2228659720e306b
2023-04-27 07:28:41 -07:00
Luke De Feo
fd673d0535
Infrastructure for stream interceptor transform nodes
...
Summary:
Added stream interecptor which gets a chance to augment the messages off the wire. Stream interceptor transformations are async and can fail due to network errors so added error state with a retry button. The retry button will just call the function again.
I am also handling errors better generally when this method fails unexpectedly, logging more clearly what went wrong and communicating it to the user
Did some refactoring of subtree update event to support this
Reviewed By: lblasa
Differential Revision: D44415260
fbshipit-source-id: a5a5542b318775b641d53941808399a8fa4634d3
2023-04-27 07:28:41 -07:00
Luke De Feo
6b7c5297a5
Added Hidden attributes to node
...
Summary: Type is any as it can be litterally anything, using json is a bit of pain as we have to do a lot of type checks to access anything
Reviewed By: lblasa
Differential Revision: D45079133
fbshipit-source-id: bcce93a1fce48d2779a648576f12df6392a0938e
2023-04-27 07:28:41 -07:00
Luke De Feo
9d34d12111
Added custom attributes to metadata typing
...
Summary: These replace tags, and are KV instead. They allow us to send framework specific data that arent common enough to be promoted to the top level, similar to hidden attributes. They will be needed for bloks
Reviewed By: lblasa
Differential Revision: D45079134
fbshipit-source-id: e4962bd56f0c24608504367f50cd796fd3d79fcd
2023-04-27 07:28:41 -07:00
Luke De Feo
1777cbf697
Remove coordinate update
...
Summary: This is no longer needed or sent by the client given our new approach to frames
Reviewed By: antonk52
Differential Revision: D44872566
fbshipit-source-id: 9ec340a5cc68605f730cf6677fb89778bf77a3a1
2023-04-27 07:28:41 -07:00
sol
b8feab9a41
Update react-native.mdx ( #4696 )
...
Summary:
Typo in Docs
## Changelog
Fixed typo in getting-started/react-native.mdx
react-native version => 0.69.0
0.159.0 -> 0.189.0
react-native version < 0.69.0
0.189.0 -> 0.162.0
Pull Request resolved: https://github.com/facebook/flipper/pull/4696
Test Plan: null
Reviewed By: lblasa
Differential Revision: D45350776
Pulled By: passy
fbshipit-source-id: 3afb21a7f6eb42b953bd821edd3a34d0c6fc28cc
2023-04-27 07:02:36 -07:00
generatedunixname89002005306973
4d4c10e2e9
Flipper Snapshot Bump: v0.190.1-SNAPSHOT
...
Summary: Releasing snapshot version 0.190.1-SNAPSHOT
Reviewed By: mweststrate
Differential Revision: D45308247
fbshipit-source-id: 584a96ebd47e5b4ccf887707a1518ecc9241c493
2023-04-26 05:30:21 -07:00
generatedunixname89002005306973
f8ca1551d7
Flipper Release: v0.190.0
...
Summary: Releasing version 0.190.0
Reviewed By: mweststrate
Differential Revision: D45308248
fbshipit-source-id: 3b03945474d644fec9a686f0f908864dbbca2322
2023-04-26 05:30:21 -07:00
Lorenzo Blasa
2583a076c0
Delete unused code
...
Summary:
^
There's no references to this anywhere, so delete.
Reviewed By: antonk52
Differential Revision: D45309041
fbshipit-source-id: e62e94b089eee30b82b05f64c8e7b31dd03597b6
2023-04-26 04:42:43 -07:00
Lorenzo Blasa
8657bcba64
Report payload size
...
Summary: Android changes to send payload size
Reviewed By: passy
Differential Revision: D45121791
fbshipit-source-id: 2cdf8f7b8849bce06949d3f7db6bdc5674fe15b7
2023-04-21 04:09:23 -07:00
Lorenzo Blasa
8cd2bb97bf
Add payload size to performance stats event
...
Summary: Payload size is useful to understand how much data is going down the wire for frame updates.
Reviewed By: LukeDefeo
Differential Revision: D45114582
fbshipit-source-id: d0c2a01deb84a67017db88bd396b4859e08d0037
2023-04-20 09:11:55 -07:00
Pascal Hartig
22e28a4f3e
Bump prettier from 2.6.2 to 2.8.7 in /desktop
...
Summary: Updates prettier and applies the fixes.
Reviewed By: antonk52
Differential Revision: D45087515
fbshipit-source-id: 226814ab4805eb12e64c2134407164498c708c0a
2023-04-19 03:04:19 -07:00
Luke De Feo
53aca9a661
Hidden attributes
...
Summary:
These are attributes that are:
1. Not common across frameworks
2. Not in every node
3. Will not be visualised via inspectable attribute mechansism
Currently we will use them for bloks but they should be useful for other features down the road
Reviewed By: lblasa
Differential Revision: D45048025
fbshipit-source-id: c258d0a384a2b09abb642778e68da178899fa9eb
2023-04-18 08:01:50 -07:00
Luke De Feo
c2fc54057a
Make metadata tags a map and rename to custom attributes
...
Summary: This will allow a lot more flexibility and will be essential for making bloks work
Reviewed By: lblasa
Differential Revision: D44871256
fbshipit-source-id: 59d9fdccea7b18406eac532080e80a69a251267b
2023-04-18 08:01:50 -07:00
