Commit Graph

4877 Commits

Author SHA1 Message Date
Bartosz Kaszubowski
40e6cdebb1 improve docs code blocks highlighting (#2049)
Summary:
This PR adds missing Objective-C entry to the Docusaurus config, fixes Objective-C code blocks label and adds or replaces several code block labels to improve the currently highlighted blocks.

Prism in Docusaurus by default also includes syntax highlight for `jsx` and `tsx`, which improves the nodes and props highlight, so I have used those syntaxes in few places too.

I have also fixed one typo that I have spotted and my IDE made a cleanup of whitespaces in edited files.

## Changelog

* [website] improve docs code blocks highlighting

Pull Request resolved: https://github.com/facebook/flipper/pull/2049

Test Plan:
The changes have been tested running Flipper website on `localhost`.

## Preview

<img width="650" alt="Screenshot 2021-03-12 150934" src="https://user-images.githubusercontent.com/719641/110951135-fff20d00-8344-11eb-96db-1bdc82c8d5ea.png">

<img width="649" alt="Screenshot 2021-03-12 151022" src="https://user-images.githubusercontent.com/719641/110951268-2ca62480-8345-11eb-9d3b-1a48f1267776.png">

Reviewed By: priteshrnandgaonkar

Differential Revision: D27336599

Pulled By: passy

fbshipit-source-id: c2dfb3d8cad4675da0f5e1270cada1e56a0175c0
2021-03-29 02:46:11 -07:00
Pascal Hartig
e4a814502a Mass bump deps
Summary:
Bumping everything that's just a patch version behind or safe-looking minor change.

Just hoping to get ahead of dependabot's next run.

Reviewed By: fabiomassimo

Differential Revision: D27367567

fbshipit-source-id: 1bf8bad02e5a9f07f5982466254f9906581230cf
2021-03-27 04:25:57 -07:00
dependabot[bot]
d5089b9f01 Bump com.github.ben-manes.versions from 0.28.0 to 0.38.0 (#2037)
Summary:
Bumps com.github.ben-manes.versions from 0.28.0 to 0.38.0.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.ben-manes.versions&package-manager=gradle&previous-version=0.28.0&new-version=0.38.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2037

Reviewed By: passy

Differential Revision: D27326600

Pulled By: mweststrate

fbshipit-source-id: a2697e74fb00dcfc4cbf9917f46e48b4cf8bf879
2021-03-26 10:28:18 -07:00
generatedunixname89002005306973
f12fd3314e Flipper Snapshot Bump: v0.82.2-SNAPSHOT
Summary: Releasing snapshot version 0.82.2-SNAPSHOT

Reviewed By: passy

Differential Revision: D27360491

fbshipit-source-id: 189d3c3f985f463b4c9f084acc8c0ea314e7d39e
2021-03-26 07:16:55 -07:00
generatedunixname89002005306973
979c49b18d Flipper Release: v0.82.1
Summary: Releasing version 0.82.1

Reviewed By: passy

Differential Revision: D27360493

fbshipit-source-id: 683605461956d39fdc20560d3a045fd42325e5fb
2021-03-26 07:16:55 -07:00
Pascal Hartig
276aa682e3 Update xmldom for RN apps (security fix)
Summary: Same security vuln. Need to hard-code for now as this is deep down in the dependency tree for an RN dep called `xcode`.

Reviewed By: mweststrate

Differential Revision: D27338548

fbshipit-source-id: b88dcf48471739ebb7762f49589548dae62433be
2021-03-26 05:47:29 -07:00
Pascal Hartig
00442cff4a Update xmldom (security fix)
Summary:
Fixes https://github.com/facebook/flipper/security/dependabot/desktop/yarn.lock/xmldom/open.

This is pulled in via electron-builder.

Reviewed By: jknoxville

Differential Revision: D27338307

fbshipit-source-id: e57cb0123289bb53d1f1d9e5957485fb7f65488a
2021-03-26 05:47:29 -07:00
Pascal Hartig
b80ab0188b Update is-svg (security fix)
Summary: Fixes https://github.com/facebook/flipper/security/dependabot/website/yarn.lock/is-svg/open

Reviewed By: jknoxville

Differential Revision: D27337757

fbshipit-source-id: 9f547b6fa693b8164c66ccd1e4550a047b634cbb
2021-03-26 05:47:29 -07:00
Pascal Hartig
cf4d8d4b1a Bump ssri (security fix)
Summary: Fixes https://github.com/facebook/flipper/security/dependabot/website/yarn.lock/ssri/open

Reviewed By: jknoxville

Differential Revision: D27337656

fbshipit-source-id: e17e7da0682d6ee9daaff988f407f88c1f83b4e0
2021-03-26 05:47:29 -07:00
Pascal Hartig
2f92ce9781 Update deps
Summary: Cleaning up the `resolutions` before going through the next batch of vulns.

Reviewed By: jknoxville, mweststrate

Differential Revision: D27337444

fbshipit-source-id: 5f042b200ac7a6f50efc7faf3c31770c263e401b
2021-03-26 05:47:29 -07:00
Pascal Hartig
a0a28c2e21 Fix ts-node for Windows (#2101)
Summary:
Somehow referring to the parent directory doesn't work on Windows. Please don't ask me why. Given that we run a script from outside the package doing it on the top-level seems more consistent anyway.

Pull Request resolved: https://github.com/facebook/flipper/pull/2101

Test Plan: Yarn on Windows succeeds: https://github.com/facebook/flipper/pull/2101/checks?check_run_id=2195613718

Reviewed By: fabiomassimo

Differential Revision: D27335250

Pulled By: passy

fbshipit-source-id: aaccdb3f7e78ca264b371a7723c9bad065919d45
2021-03-25 16:27:41 -07:00
Pritesh Nandgaonkar
790f23301e Refactor Layout Plugin
Summary:
This diff moves the iOS descriptors and other layout helpers into its own buck target. Earlier everything was part of the FlipperKitLayoutPlugin target. When kcui, tried to add macos descriptors, we realised that FlipperKitLayoutPlugin doesn't have macos platform in it and thus he had to put #if TARGET_OS_SIMULATOR check in iOS descriptors and at some other places.

In order to make the integration easier I decided to split the Layout Plugin in following way.

```
FlipperKitLayoutPlugin
  -> FlipperKitLayoutIOSDescriptors (platform set as IOS)
  -> FlipperKitLayoutHelpers (used in iOS Descriptors and usefule for Macos too)
  -> FlipperKitLayoutMacOSDescriptors(coming soon by kcui)(platform set as MacOS)

```

Reviewed By: kcui

Differential Revision: D27127587

fbshipit-source-id: f108ef81914297e93c886fe53dabf0a4bf11ebc1
2021-03-25 16:00:28 -07:00
Pascal Hartig
8c85da5bc8 Bump deps
Summary: Just trying to get ahead of dependabot and bump some easy dependencies all at once.

Reviewed By: fabiomassimo

Differential Revision: D27326687

fbshipit-source-id: 0c724c8e3a688aa9777945fcd46061284fd77969
2021-03-25 12:28:29 -07:00
dependabot[bot]
5f082d9267 Bump react-player from 1.15.3 to 2.9.0 in /desktop (#2015)
Summary:
Bumps [react-player](https://github.com/CookPete/react-player) from 1.15.3 to 2.9.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/cookpete/react-player/blob/master/CHANGELOG.md">react-player's changelog</a>.</em></p>
<blockquote>
<h4><a href="https://github.com/cookpete/react-player/compare/v2.8.2...v2.9.0">v2.9.0</a></h4>
<ul>
<li>Adds previewTabIndex property to light mode <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1169"><code>[https://github.com/facebook/flipper/issues/1169](https://github.com/CookPete/react-player/issues/1169)</code></a></li>
<li>Update YouTube URL pattern (<a href="https://github-redirect.dependabot.com/CookPete/react-player/issues/1170">https://github.com/facebook/flipper/issues/1170</a>) <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1171"><code>[https://github.com/facebook/flipper/issues/1171](https://github.com/CookPete/react-player/issues/1171)</code></a></li>
<li>Support Kaltura's HTML5 player <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1082"><code>[https://github.com/facebook/flipper/issues/1082](https://github.com/CookPete/react-player/issues/1082)</code></a></li>
<li>Fix suspense check for nextjs <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1165"><code>[https://github.com/facebook/flipper/issues/1165](https://github.com/CookPete/react-player/issues/1165)</code></a></li>
<li>Add kaltura player types <a href="b1e105342f"><code>b1e1053</code></a></li>
</ul>
<h4><a href="https://github.com/cookpete/react-player/compare/v2.8.1...v2.8.2">v2.8.2</a></h4>
<blockquote>
<p>26 January 2021</p>
</blockquote>
<ul>
<li>fix: ensure lazy typedefs mirror defaults <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1153"><code>[https://github.com/facebook/flipper/issues/1153](https://github.com/CookPete/react-player/issues/1153)</code></a></li>
<li>fix: nullify srcObject instead of calling removeAttribute <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1145"><code>[https://github.com/facebook/flipper/issues/1145](https://github.com/CookPete/react-player/issues/1145)</code></a></li>
<li>updated basic types with fallback <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1144"><code>[https://github.com/facebook/flipper/issues/1144](https://github.com/CookPete/react-player/issues/1144)</code></a></li>
<li>Update wistia url pattern <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1149"><code>[https://github.com/facebook/flipper/issues/1149](https://github.com/CookPete/react-player/issues/1149)</code></a></li>
<li>fix: ensure lazy typedefs mirror defaults (<a href="https://github-redirect.dependabot.com/CookPete/react-player/issues/1153">https://github.com/facebook/flipper/issues/1153</a>) <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1146"><code>[https://github.com/facebook/flipper/issues/1146](https://github.com/CookPete/react-player/issues/1146)</code></a></li>
</ul>
<h4><a href="https://github.com/cookpete/react-player/compare/v2.8.0...v2.8.1">v2.8.1</a></h4>
<blockquote>
<p>20 January 2021</p>
</blockquote>
<ul>
<li>Fix clean script <a href="9a448b1315"><code>9a448b1</code></a></li>
</ul>
<h4><a href="https://github.com/cookpete/react-player/compare/v2.7.2...v2.8.0">v2.8.0</a></h4>
<blockquote>
<p>20 January 2021</p>
</blockquote>
<ul>
<li>fix: remove srcObject attribute if next uri is not a MediaStream <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1121"><code>[https://github.com/facebook/flipper/issues/1121](https://github.com/CookPete/react-player/issues/1121)</code></a></li>
<li>added soundcloud playlist preview button for demo page so developers can know it also supports sc playlists <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1113"><code>[https://github.com/facebook/flipper/issues/1113](https://github.com/CookPete/react-player/issues/1113)</code></a></li>
<li>Add missing FLV props to TS defs <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1122"><code>[https://github.com/facebook/flipper/issues/1122](https://github.com/CookPete/react-player/issues/1122)</code></a></li>
<li>FEAT: customize fallback through props for lazy loading <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1133"><code>[https://github.com/facebook/flipper/issues/1133](https://github.com/CookPete/react-player/issues/1133)</code></a></li>
<li>Add onClickPreview <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1131"><code>[https://github.com/facebook/flipper/issues/1131](https://github.com/CookPete/react-player/issues/1131)</code></a></li>
<li>Added types for single players <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/953"><code>[https://github.com/facebook/flipper/issues/953](https://github.com/CookPete/react-player/issues/953)</code></a></li>
<li>Add custom control support to Wistia <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1125"><code>[https://github.com/facebook/flipper/issues/1125](https://github.com/CookPete/react-player/issues/1125)</code></a></li>
<li>Fix facebook muted logic <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1127"><code>[https://github.com/facebook/flipper/issues/1127](https://github.com/CookPete/react-player/issues/1127)</code></a></li>
<li>yarn upgrade <a href="0c7dd4a787"><code>0c7dd4a</code></a></li>
</ul>
<h4><a href="https://github.com/cookpete/react-player/compare/v2.7.1...v2.7.2">v2.7.2</a></h4>
<blockquote>
<p>16 December 2020</p>
</blockquote>
<ul>
<li>fix: add playIcon prop to TS declaration <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1084"><code>[https://github.com/facebook/flipper/issues/1084](https://github.com/CookPete/react-player/issues/1084)</code></a></li>
</ul>
<h4><a href="https://github.com/cookpete/react-player/compare/v2.7.0...v2.7.1">v2.7.1</a></h4>
<blockquote>
<p>16 December 2020</p>
</blockquote>
<ul>
<li>Improve youtube playlist regex <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1088"><code>[https://github.com/facebook/flipper/issues/1088](https://github.com/CookPete/react-player/issues/1088)</code></a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="5d38f882b2"><code>5d38f88</code></a> 2.9.0</li>
<li><a href="a41e3c791f"><code>a41e3c7</code></a> Fix suspense check for nextjs</li>
<li><a href="b1e105342f"><code>b1e1053</code></a> Add kaltura player types</li>
<li><a href="994820ee53"><code>994820e</code></a> Adds previewTabIndex property to light mode (<a href="https://github-redirect.dependabot.com/CookPete/react-player/issues/1169">https://github.com/facebook/flipper/issues/1169</a>)</li>
<li><a href="53e4aede5d"><code>53e4aed</code></a> Update YouTube URL pattern (<a href="https://github-redirect.dependabot.com/CookPete/react-player/issues/1170">https://github.com/facebook/flipper/issues/1170</a>) (<a href="https://github-redirect.dependabot.com/CookPete/react-player/issues/1171">https://github.com/facebook/flipper/issues/1171</a>)</li>
<li><a href="264cb10767"><code>264cb10</code></a> Support Kaltura's HTML5 player (<a href="https://github-redirect.dependabot.com/CookPete/react-player/issues/1082">https://github.com/facebook/flipper/issues/1082</a>)</li>
<li><a href="e1e99a1fee"><code>e1e99a1</code></a> 2.8.2</li>
<li><a href="61a27023ee"><code>61a2702</code></a> Update wistia url pattern</li>
<li><a href="0cc1b39b4e"><code>0cc1b39</code></a> fix: ensure lazy typedefs mirror defaults (<a href="https://github-redirect.dependabot.com/CookPete/react-player/issues/1153">https://github.com/facebook/flipper/issues/1153</a>)</li>
<li><a href="22bf8586a8"><code>22bf858</code></a> fix: nullify srcObject instead of calling removeAttribute (<a href="https://github-redirect.dependabot.com/CookPete/react-player/issues/1145">https://github.com/facebook/flipper/issues/1145</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/CookPete/react-player/compare/v1.15.3...v2.9.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=react-player&package-manager=npm_and_yarn&previous-version=1.15.3&new-version=2.9.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2015

Reviewed By: passy

Differential Revision: D27326596

Pulled By: mweststrate

fbshipit-source-id: 6a08e7aaab483a65749cc286db9751f51782b04c
2021-03-25 11:48:05 -07:00
Michel Weststrate
32447c9026 Fix failing build by not propagating deployment target to deps (#2103)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2103

Local builds break if the deploy target of deps isn't new enough. It seems that the project podfile is not respected in this regard, as reported here: https://stackoverflow.com/a/37289688/1983583. Will see if there is a better way to fix this.

Reviewed By: jknoxville

Differential Revision: D27328025

fbshipit-source-id: 6c5ac2dc88c3dd90dd84ce691a4f8e42188f96c2
2021-03-25 10:03:33 -07:00
generatedunixname89002005306973
49d763ad5a Flipper Snapshot Bump: v0.82.1-SNAPSHOT
Summary: Releasing snapshot version 0.82.1-SNAPSHOT

Reviewed By: mweststrate

Differential Revision: D27328584

fbshipit-source-id: ec58247c21e568496d4fb7f79ebb3198081003cd
2021-03-25 09:36:13 -07:00
generatedunixname89002005306973
9bccaf3951 Flipper Release: v0.82.0
Summary: Releasing version 0.82.0

Reviewed By: mweststrate

Differential Revision: D27328585

fbshipit-source-id: 720bc154078611295664a34a567299a94a790711
2021-03-25 09:36:13 -07:00
Michel Weststrate
740fbe57fd Fix release build issue
Summary:
D24358369 (8a31e984b3) introduced a dependency outside the `sonar/` dir, which probably should not have happened. D27324576 finally broke this, by adding a dep to QPL core, which will never be installed in our CI.

This diff unbreaks that rewriting the require to a locally provided version of crc32, however this is a stop gap, and it would be great if someone would look into a sustainable solution :)

Reviewed By: passy

Differential Revision: D27327272

fbshipit-source-id: 70cdf21c7ecf081ef804d6338ec11e498e3cb7cf
2021-03-25 08:42:08 -07:00
dependabot[bot]
bfde7c4d24 Bump eslint-plugin-flowtype from 5.3.1 to 5.4.0 in /flipper-js-client-sdk (#2052)
Summary:
Bumps [eslint-plugin-flowtype](https://github.com/gajus/eslint-plugin-flowtype) from 5.3.1 to 5.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gajus/eslint-plugin-flowtype/releases">eslint-plugin-flowtype's releases</a>.</em></p>
<blockquote>
<h2>v5.4.0</h2>
<h1><a href="https://github.com/gajus/eslint-plugin-flowtype/compare/v5.3.1...v5.4.0">5.4.0</a> (2021-03-14)</h1>
<h3>Features</h3>
<ul>
<li>migrate a new rule 'no-internal-flow-type' (<a href="https://github.com/gajus/eslint-plugin-flowtype/issues/469">https://github.com/facebook/flipper/issues/469</a>) (<a href="fd838c3dce">fd838c3</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="fd838c3dce"><code>fd838c3</code></a> feat: migrate a new rule 'no-internal-flow-type' (<a href="https://github.com/gajus/eslint-plugin-flowtype/issues/469">https://github.com/facebook/flipper/issues/469</a>)</li>
<li>See full diff in <a href="https://github.com/gajus/eslint-plugin-flowtype/compare/v5.3.1...v5.4.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=eslint-plugin-flowtype&package-manager=npm_and_yarn&previous-version=5.3.1&new-version=5.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2052

Reviewed By: passy

Differential Revision: D27230372

Pulled By: priteshrnandgaonkar

fbshipit-source-id: bbad17858718383788aac0c57230f7f2acc846f4
2021-03-25 05:28:31 -07:00
Michel Weststrate
f095a00c78 Fix Flipper crashing when decoding partial encoded requests
Summary:
Changelog: Fixed an issue where Flipper would crash when decoding large partial requests.

The current processing of partial requests assumes that the proviced base64 string is always an utf-8 string, which is incorrect as it might contain binary data as well. This causes `atob` build in to throw errors when trying to decode binary base64 strings with the following exception:

{F538782963}

However, what is worse, if those strings were larger than ~2 mb, it would completely crash Electron rather than on the JS level, with reports like:

```

Crashed Thread:        0  CrRendererMain  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       EXC_I386_GPFLT
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [85268]

Thread 0 Crashed:: CrRendererMain  Dispatch queue: com.apple.main-thread
0   com.github.Electron.framework 	0x000000011155b16f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 22324575
1   com.github.Electron.framework 	0x000000011155e811 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 22338561
2   com.github.Electron.framework 	0x00000001117e2e62 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 24978002
3   com.github.Electron.framework 	0x000000010fa32660 v8::internal::ClassScope::ResolvePrivateNamesPartially() + 14944
4   com.github.Electron.framework 	0x000000010fa322b5 v8::internal::ClassScope::ResolvePrivateNamesPartially() + 14005
5   com.github.Electron.framework 	0x000000010fa31933 v8::internal::ClassScope::ResolvePrivateNamesPartially() + 11571
6   com.github.Electron.framework 	0x000000011007ef58 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 451400
```

Reproduced this JS issue by lowering the `MAX_BODY_SIZE_IN_BYTES` in `NetworkFlipperPlugin.java` to 10KB, which causes all requests to be processed as partials.

Reproducing the the Electron crash is a lot harder, as it requires a surface that makes large, binary requests (more than a few mb), that is still intercepted by the Network layer. The best example I could find is sending large pictures or videos through a messenger for android chat. In that case it is still hard to produce due to caching though.

Fun fact, you can crash your own flipper and get the above crash by running this command:
`btoa(require("fs").readFileSync("/Users/mweststrate/Desktop/Screen Recording 2021-03-24 at 16.08.27 crop.mov", "binary"))`, where the provided file must be a few mb's large (this one is 10).

A result of fixing this issue, is that images that were send as partials can now be correctly previewed in the Network plugin again.

Reviewed By: jknoxville

Differential Revision: D27302961

fbshipit-source-id: 1ac86840f7268062bb59c789f3904537df3c51fa
2021-03-25 05:03:07 -07:00
dependabot[bot]
2622c084df Bump eslint from 7.21.0 to 7.22.0 in /flipper-js-client-sdk (#2054)
Summary:
Bumps [eslint](https://github.com/eslint/eslint) from 7.21.0 to 7.22.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/eslint/eslint/releases">eslint's releases</a>.</em></p>
<blockquote>
<h2>v7.22.0</h2>
<ul>
<li><a href="3a432d82b3"><code>3a432d8</code></a> Docs: Improve documentation for indent rule (<a href="https://github.com/eslint/eslint/issues/14168">#14168</a>) (Serkan Özel)</li>
<li><a href="f62ec8d30d"><code>f62ec8d</code></a> Update: throw error when fix range is invalid (<a href="https://github.com/eslint/eslint/issues/14142">#14142</a>) (Jacob Bandes-Storch)</li>
<li><a href="0eecad2713"><code>0eecad2</code></a> Upgrade: Update lodash in package.json to V 4.17.21 (<a href="https://github.com/eslint/eslint/issues/14159">#14159</a>) (Basem Al-Nabulsi)</li>
<li><a href="5ad91aa7df"><code>5ad91aa</code></a> Update: report es2021 globals in no-extend-native (refs <a href="https://github.com/eslint/eslint/issues/13602">#13602</a>) (<a href="https://github.com/eslint/eslint/issues/14177">#14177</a>) (Milos Djermanovic)</li>
<li><a href="c295581aca"><code>c295581</code></a> Chore: remove leftover JSDoc from lint-result-cache (<a href="https://github.com/eslint/eslint/issues/14176">#14176</a>) (Milos Djermanovic)</li>
<li><a href="0d541f9d9d"><code>0d541f9</code></a> Chore: Reduce lodash usage (<a href="https://github.com/eslint/eslint/issues/14178">#14178</a>) (Stephen Wade)</li>
<li><a href="27a67d71ff"><code>27a67d7</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li>
<li><a href="459d821f4a"><code>459d821</code></a> Chore: upgrade dependencies of browser test (<a href="https://github.com/eslint/eslint/issues/14127">#14127</a>) (Pig Fang)</li>
<li><a href="ebfb63a682"><code>ebfb63a</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li>
<li><a href="3ba029fbff"><code>3ba029f</code></a> Docs: Remove Extraneous Dash (<a href="https://github.com/eslint/eslint/issues/14164">#14164</a>) (Danny Hurlburt)</li>
<li><a href="6f4540ea7e"><code>6f4540e</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li>
<li><a href="ddf361ca2a"><code>ddf361c</code></a> Docs: Fix Formatting (<a href="https://github.com/eslint/eslint/issues/14154">#14154</a>) (Danny Hurlburt)</li>
<li><a href="c0d2ac16f8"><code>c0d2ac1</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li>
<li><a href="a8df03efe3"><code>a8df03e</code></a> Docs: Clarify triage process (<a href="https://github.com/eslint/eslint/issues/14117">#14117</a>) (Nicholas C. Zakas)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/eslint/eslint/blob/master/CHANGELOG.md">eslint's changelog</a>.</em></p>
<blockquote>
<p>v7.22.0 - March 12, 2021</p>
<ul>
<li><a href="3a432d82b3"><code>3a432d8</code></a> Docs: Improve documentation for indent rule (<a href="https://github.com/eslint/eslint/issues/14168">#14168</a>) (Serkan Özel)</li>
<li><a href="f62ec8d30d"><code>f62ec8d</code></a> Update: throw error when fix range is invalid (<a href="https://github.com/eslint/eslint/issues/14142">#14142</a>) (Jacob Bandes-Storch)</li>
<li><a href="0eecad2713"><code>0eecad2</code></a> Upgrade: Update lodash in package.json to V 4.17.21 (<a href="https://github.com/eslint/eslint/issues/14159">#14159</a>) (Basem Al-Nabulsi)</li>
<li><a href="5ad91aa7df"><code>5ad91aa</code></a> Update: report es2021 globals in no-extend-native (refs <a href="https://github.com/eslint/eslint/issues/13602">#13602</a>) (<a href="https://github.com/eslint/eslint/issues/14177">#14177</a>) (Milos Djermanovic)</li>
<li><a href="c295581aca"><code>c295581</code></a> Chore: remove leftover JSDoc from lint-result-cache (<a href="https://github.com/eslint/eslint/issues/14176">#14176</a>) (Milos Djermanovic)</li>
<li><a href="0d541f9d9d"><code>0d541f9</code></a> Chore: Reduce lodash usage (<a href="https://github.com/eslint/eslint/issues/14178">#14178</a>) (Stephen Wade)</li>
<li><a href="27a67d71ff"><code>27a67d7</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li>
<li><a href="459d821f4a"><code>459d821</code></a> Chore: upgrade dependencies of browser test (<a href="https://github.com/eslint/eslint/issues/14127">#14127</a>) (Pig Fang)</li>
<li><a href="ebfb63a682"><code>ebfb63a</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li>
<li><a href="3ba029fbff"><code>3ba029f</code></a> Docs: Remove Extraneous Dash (<a href="https://github.com/eslint/eslint/issues/14164">#14164</a>) (Danny Hurlburt)</li>
<li><a href="6f4540ea7e"><code>6f4540e</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li>
<li><a href="ddf361ca2a"><code>ddf361c</code></a> Docs: Fix Formatting (<a href="https://github.com/eslint/eslint/issues/14154">#14154</a>) (Danny Hurlburt)</li>
<li><a href="c0d2ac16f8"><code>c0d2ac1</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li>
<li><a href="a8df03efe3"><code>a8df03e</code></a> Docs: Clarify triage process (<a href="https://github.com/eslint/eslint/issues/14117">#14117</a>) (Nicholas C. Zakas)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="6ee803747f"><code>6ee8037</code></a> 7.22.0</li>
<li><a href="a55e8a1a01"><code>a55e8a1</code></a> Build: changelog update for 7.22.0</li>
<li><a href="3a432d82b3"><code>3a432d8</code></a> Docs: Improve documentation for indent rule (<a href="https://github.com/eslint/eslint/issues/14168">#14168</a>)</li>
<li><a href="f62ec8d30d"><code>f62ec8d</code></a> Update: throw error when fix range is invalid (<a href="https://github.com/eslint/eslint/issues/14142">#14142</a>)</li>
<li><a href="0eecad2713"><code>0eecad2</code></a> Upgrade: Update lodash in package.json to V 4.17.21 (<a href="https://github.com/eslint/eslint/issues/14159">#14159</a>)</li>
<li><a href="5ad91aa7df"><code>5ad91aa</code></a> Update: report es2021 globals in no-extend-native (refs <a href="https://github.com/eslint/eslint/issues/13602">#13602</a>) (<a href="https://github.com/eslint/eslint/issues/14177">#14177</a>)</li>
<li><a href="c295581aca"><code>c295581</code></a> Chore: remove leftover JSDoc from lint-result-cache (<a href="https://github.com/eslint/eslint/issues/14176">#14176</a>)</li>
<li><a href="0d541f9d9d"><code>0d541f9</code></a> Chore: Reduce lodash usage (<a href="https://github.com/eslint/eslint/issues/14178">#14178</a>)</li>
<li><a href="27a67d71ff"><code>27a67d7</code></a> Sponsors: Sync README with website</li>
<li><a href="459d821f4a"><code>459d821</code></a> Chore: upgrade dependencies of browser test (<a href="https://github.com/eslint/eslint/issues/14127">#14127</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/eslint/eslint/compare/v7.21.0...v7.22.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=eslint&package-manager=npm_and_yarn&previous-version=7.21.0&new-version=7.22.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2054

Reviewed By: passy

Differential Revision: D27230363

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 27ff5431b86f91b543cdc7093f8eed9c5147a489
2021-03-24 19:32:20 -07:00
dependabot[bot]
d575f2d388 Bump @types/express from 4.17.8 to 4.17.11 in /desktop (#2065)
Summary:
Bumps [types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.8 to 4.17.11.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@types/express&package-manager=npm_and_yarn&previous-version=4.17.8&new-version=4.17.11)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2065

Reviewed By: passy

Differential Revision: D27230321

Pulled By: priteshrnandgaonkar

fbshipit-source-id: cbdad9eb0b58b9c232b798d5d90a123a7c3ebe71
2021-03-24 19:32:20 -07:00
Pritesh Nandgaonkar
62863c8fe5 Change the logic to check the cert exchange is needed or not
Summary:
It has been seen [here](https://fb.workplace.com/groups/flippersupport/permalink/1094276434386347/) that the user's app sandbox can be in a state where it might not have the device id information, but other app certificates. This causes the issue of "Timed out waiting for unknown device".

We get the deviceid from flipper into app's sandbox when cert exchange happens. So if we don't have the device id information, we can again redo the cert exchange to get the sandbox in a state where flipper connects. Thus I updated the logic of `hasRequiredFiles` which checks the required files for cert exchange.

Reviewed By: mweststrate

Differential Revision: D27265693

fbshipit-source-id: ccf311f4728837ee9385c95c38f94c9c93380feb
2021-03-24 13:13:05 -07:00
Pritesh Nandgaonkar
d2fc10074f Bump react-native in react-native-flipper
Summary:
This diff bumps react-native dep in  react-native-flipper

This diff retries what D27230334 was trying to do. Looked like in the prev diff the yarn.lock had unwanted changes.

Reviewed By: passy

Differential Revision: D27297848

fbshipit-source-id: aecb4708fabb5515b9949a3eb59fffe05d49487f
2021-03-24 12:12:15 -07:00
Pascal Hartig
21cfa6921b Rebuild bump.lnx as static binary
Summary:
The dynamic verison ran on my devserver so I thought it was fine
but turns out our Lego host doesn't have the glibc version it linked
against: https://www.internalfb.com/intern/chronos/job?jobid=27021599014479361&smc=chronos_gp_admin_client

Reviewed By: fabiomassimo

Differential Revision: D27290193

fbshipit-source-id: 94f8048d6aa42d00401b433a622fe6af29126fd3
2021-03-24 04:46:14 -07:00
Hilal Alsibai
949545a2a7 Don't skip the first theme data retrieval
Summary: Was early returning on the first attempt to load theme data, this was left over from when the the theme feature was temporarily disabled.

Reviewed By: passy

Differential Revision: D27284040

fbshipit-source-id: bb641fbe4cd9c0ea6012e89dbda67e5dd10d59bd
2021-03-24 04:33:03 -07:00
Pascal Hartig
0a7f37d859 v0.3.0
Summary: Just bumpin'.

Reviewed By: fabiomassimo

Differential Revision: D27194182

fbshipit-source-id: 983cd09aab8087a70d133cd56c83b39a63890366
2021-03-23 13:28:14 -07:00
Pascal Hartig
8b97ce2954 Add integration test script
Summary:
Following priteshrnandgaonkar's advice of having something a little more automated
for testing the entire flow. This builds for each platform and
runs a little smoke test, ensuring that the right files are in each
archive.

Reviewed By: priteshrnandgaonkar

Differential Revision: D27229200

fbshipit-source-id: d83881a948ae001ce2379e9db5e21b777a5fe922
2021-03-23 13:28:14 -07:00
Pascal Hartig
0a9b7147c7 Update README
Reviewed By: mweststrate

Differential Revision: D27229201

fbshipit-source-id: faeb4528283a21be7ba51eb4a8e708a901307233
2021-03-23 13:28:14 -07:00
Pascal Hartig
fa97809178 Implement glob packing mode
Summary:
Best seen by looking at the packfile. This makes upgrades and changes
to the file format a lot more robust.

Reviewed By: priteshrnandgaonkar

Differential Revision: D27194152

fbshipit-source-id: a722adb3a59d73b7530287f7abd84ed865a35fa7
2021-03-23 13:28:14 -07:00
Pascal Hartig
ca55e68c89 Set up infra for different packing mode
Summary:
Electron 12 broke packing again because one file was renamed. I'm now setting up a separate mode for using globs and ignores to create artifact bundles. This will work like a reverse gitignore file. However, to keep the logic simple, I'll keep the old mode for MacOS where the folder structure lends itself to comprehensive, exact lists.

**This doesn't actually change anything just yet apart from the "packfile" format. The next diff will add the new packing mode. Feedback is always welcome but there's no need for super close scrutiny.**

Reviewed By: mweststrate

Differential Revision: D27191506

fbshipit-source-id: 663cef8b93eef6c2dbb56ef66de51ea9551412dd
2021-03-23 13:28:14 -07:00
Pascal Hartig
94e85b54c8 Update Linux binary
Summary: Per title.

Reviewed By: mweststrate

Differential Revision: D27266704

fbshipit-source-id: cc34c6d12b6db29650b7f45ed1594c0794d75e56
2021-03-23 13:07:48 -07:00
Pascal Hartig
9e30c60750 Update Mac binary
Summary: Per title.

Reviewed By: mweststrate

Differential Revision: D27266705

fbshipit-source-id: 3d279fe9fd6b9daae5126cbb1179ec8d97ef5e3f
2021-03-23 13:07:48 -07:00
Michel Weststrate
c7c75a082f Fix failing perf test
Summary: made a typescript booboo, and broke the test thereby. Also reduced the test set to avoid OOMs

Reviewed By: passy

Differential Revision: D27261187

fbshipit-source-id: bcb61bf95419421d9c33e7e0a944717797f96dfe
2021-03-23 12:56:17 -07:00
Michel Weststrate
ba8232f30d Move DetailSidebar to flipper-plugin
Summary: This moves `<DetailSidebar>` component to `flipper-plugin` and documents it. No semantic changes.

Reviewed By: passy

Differential Revision: D27234575

fbshipit-source-id: 74640602d718f84ad999f5dac0420089796ed7fb
2021-03-23 12:56:17 -07:00
Michel Weststrate
dd1f2fdeaa Move Sidebar to flipper-plugin
Summary:
This diff deprecates the Sidebar concept, and copies the implementation to Sandy (tried moving first, but since existing plugins use the Sidebar in non-flex (Layout) contexts, that the layout of several plugins, so rather deprecated the old implementation.

Instead of exposing `Sidebar` explicitly, one can now put the `resizable` flag on a Layout.Top/Left/Bottom/Right, which makes building layouts even simpler, see demo.

The gutter logic was moved to the new implementation, since that was only used by the Sandy chrome anyway.

Changelog: Layout.Top / Left / Bottom / Right now support a resizable option

Reviewed By: passy

Differential Revision: D27233899

fbshipit-source-id: fbbdeb2ebf30d49d0837705a00ea86bb07fc2ba2
2021-03-23 12:56:17 -07:00
Ranjith
0bf786544a Update leak-canary-2-plugin.mdx (#2085)
Summary:
Update the LeakCanary 2 plugin version in LeakCanary 2 plugin doc

While adding the version as in the doc, the import statements didn't work. Upon checking the maven repo, I found out that the latest version is `0.81.0`. Updating to the latest version helps

## Changelog
Updated LeakCanary 2  plugin docs to include the latest plugin version

Pull Request resolved: https://github.com/facebook/flipper/pull/2085

Test Plan: Not necessary

Reviewed By: mweststrate

Differential Revision: D27265598

Pulled By: passy

fbshipit-source-id: 2f82689c1f075c2f9cff8bae2831c9780a3db697
2021-03-23 11:01:41 -07:00
Pascal Hartig
aa83d2e620 Include leakcanary2 path
Summary:
Currently relying on PRs to bump this: https://github.com/facebook/flipper/pull/2085/files

Will need to rebuild binaries afterwards.

Reviewed By: mweststrate

Differential Revision: D27265679

fbshipit-source-id: 227a1350044573f37f477727e059be845e5369e0
2021-03-23 11:01:41 -07:00
dependabot[bot]
062882bb77 Bump gradle from 4.1.2 to 4.1.3 (#2090)
Summary:
Bumps gradle from 4.1.2 to 4.1.3.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.android.tools.build:gradle&package-manager=gradle&previous-version=4.1.2&new-version=4.1.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2090

Reviewed By: mweststrate

Differential Revision: D27265541

Pulled By: passy

fbshipit-source-id: ff3d914cc6f360364811e0d1402b02ccc89c1a8b
2021-03-23 11:01:41 -07:00
Pascal Hartig
55341dfc59 Fix React Native build (#2100)
Summary:
Currently failing because the 0.64.x build requires Node >= 0.12

Pull Request resolved: https://github.com/facebook/flipper/pull/2100

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D27265576

Pulled By: passy

fbshipit-source-id: d7ee0cac8bab1dc90a1b453eef6a7be30177052e
2021-03-23 10:57:46 -07:00
dependabot[bot]
256b025630 Bump rsocket-flowable from 0.0.23 to 0.0.25 in /desktop (#2069)
Summary:
Bumps [rsocket-flowable](https://github.com/rsocket/rsocket-js) from 0.0.23 to 0.0.25.
<details>
<summary>Commits</summary>
<ul>
<li><a href="a85a4db041"><code>a85a4db</code></a> v0.0.25</li>
<li><a href="b279d67569"><code>b279d67</code></a> ammend versions</li>
<li><a href="1e15f3c975"><code>1e15f3c</code></a> v0.0.24</li>
<li><a href="a4b7a93dc0"><code>a4b7a93</code></a> provides a temporary fix for <a href="https://github.com/rsocket/rsocket-js/issues/110">https://github.com/facebook/flipper/issues/110</a></li>
<li><a href="c271a37128"><code>c271a37</code></a> exports missing TlsClient</li>
<li><a href="844b10b35b"><code>844b10b</code></a> updates docs</li>
<li><a href="39a86dfa5f"><code>39a86df</code></a> updates docs</li>
<li><a href="97e1e9f922"><code>97e1e9f</code></a> updates versions</li>
<li><a href="90e70580d1"><code>90e7058</code></a> fixes RSocketMachine leak on the server-side (<a href="https://github.com/rsocket/rsocket-js/issues/120">https://github.com/facebook/flipper/issues/120</a>)</li>
<li><a href="f665cd1038"><code>f665cd1</code></a> adds METADATA_PUSH support (<a href="https://github.com/rsocket/rsocket-js/issues/119">https://github.com/facebook/flipper/issues/119</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/rsocket/rsocket-js/compare/v0.0.23...v0.0.25">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=rsocket-flowable&package-manager=npm_and_yarn&previous-version=0.0.23&new-version=0.0.25)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2069

Reviewed By: passy

Differential Revision: D27230118

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 814a094dabdffae71b26abd8b8ef0d6691ef94ee
2021-03-23 10:01:23 -07:00
dependabot[bot]
453499568d Bump @types/react-transition-group from 4.4.0 to 4.4.1 in /desktop (#2066)
Summary:
Bumps [types/react-transition-group](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-transition-group) from 4.4.0 to 4.4.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-transition-group">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@types/react-transition-group&package-manager=npm_and_yarn&previous-version=4.4.0&new-version=4.4.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2066

Reviewed By: passy

Differential Revision: D27230132

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 21b2276f21b63bd98f3169559590985de795dc64
2021-03-23 10:01:23 -07:00
Pascal Hartig
d19eeb2a53 Demote android emulator "errors"
Summary:
Really not errors at all. I'm getting warnings here about my Vulkan
support not working. That shouldn't be logged as a Flipper error.

Reviewed By: mweststrate

Differential Revision: D27260607

fbshipit-source-id: 6f9d2ab0da3fe37bb5c8c185ad627ef0d581e5d5
2021-03-23 09:52:44 -07:00
dependabot[bot]
df71f14c77 Bump electron-builder from 22.9.1 to 22.10.5 in /desktop (#2068)
Summary:
Bumps [electron-builder](https://github.com/electron-userland/electron-builder) from 22.9.1 to 22.10.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases">electron-builder's releases</a>.</em></p>
<blockquote>
<h2>22.10.5</h2>
<p>We have a new maintainer — welcome Mike Maietta (<a href="https://github.com/mmaietta"><code>@​mmaietta</code></a>)!</p>
<p><strong>electron-updater</strong>  4.3.8 contains fix for <a href="https://github.com/electron-userland/electron-builder/issues/5595">#5595</a>. This version is a pre-release.</p>
<h3>Bug Fixes</h3>
<ul>
<li>Look for the Amazon cred header to remove auth header (<a href="https://github.com/electron-userland/electron-builder/issues/5594">#5594</a>) (<a href="46a8840bb4">46a8840</a>)</li>
<li><strong>mac:</strong> fix &quot;Contents/Info.plist&quot; don't have identical SHAs when creating a universal build (<a href="https://github.com/electron-userland/electron-builder/issues/5550">#5550</a>) (<a href="0ba839b72b">0ba839b</a>)</li>
<li>updating nsis script to properly identify arm64 vs x64 vs ia32 package files within universal installers. (<a href="https://github.com/electron-userland/electron-builder/issues/5558">#5558</a>) (<a href="60f7fe367c">60f7fe3</a>)</li>
<li><strong>mac:</strong> Allow arm64 macs to update to x64 version if no arm64 version available (<a href="https://github.com/electron-userland/electron-builder/issues/5524">#5524</a>) (<a href="dc5c2f8e77">dc5c2f8</a>)</li>
<li><strong>mac:</strong> Pass platformName and options in doPack (<a href="https://github.com/electron-userland/electron-builder/issues/5511">#5511</a>) (<a href="f78e3f48d7">f78e3f4</a>)</li>
<li><strong>mac:</strong> Workaround for hdiutil randomly failing (<a href="https://github.com/electron-userland/electron-builder/issues/5431">#5431</a>) (<a href="https://github.com/electron-userland/electron-builder/issues/5464">#5464</a>) (<a href="53270cfe4e">53270cf</a>)</li>
<li>binary detection signing (<a href="https://github.com/electron-userland/electron-builder/issues/5493">#5493</a>) (<a href="a6e86b5930">a6e86b5</a>), closes <a href="https://github.com/electron-userland/electron-builder/issues/5465">#5465</a></li>
<li>ci-tests (<a href="https://github.com/electron-userland/electron-builder/issues/5523">#5523</a>) (<a href="ced6e50b93">ced6e50</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li><strong>electron-updater:</strong> follow <code>autoInstallOnAppQuit = false</code> on macOS (<a href="https://github.com/electron-userland/electron-builder/issues/5271">#5271</a>) (<a href="1643d56960">1643d56</a>)</li>
<li>add support for executableName to non-Linux Platforms (<a href="https://github.com/electron-userland/electron-builder/issues/5409">#5409</a>) (<a href="106b68010f">106b680</a>)</li>
<li>Custom electronDist callback (<a href="https://github.com/electron-userland/electron-builder/issues/5527">#5527</a>) (<a href="4f4e018771">4f4e018</a>)</li>
<li>macOS default architecture (<a href="https://github.com/electron-userland/electron-builder/issues/5495">#5495</a>) (<a href="https://github.com/electron-userland/electron-builder/issues/5504">#5504</a>) (<a href="5203d7eb15">5203d7e</a>)</li>
</ul>
<h2>22.10.4</h2>
<h3>Bug Fixes</h3>
<ul>
<li>CI unit tests (<a href="https://github.com/electron-userland/electron-builder/issues/5489">#5489</a>) (<a href="637334ddba">637334d</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li>Apple Silicon Universal Support (<a href="https://github.com/electron-userland/electron-builder/issues/5481">#5481</a>) (<a href="ca20151c34">ca20151</a>)</li>
<li><strong>mas:</strong> Apple Silicon support (<a href="https://github.com/electron-userland/electron-builder/issues/5484">#5484</a>) (<a href="6b7d30555d">6b7d305</a>)</li>
</ul>
<h3>Reverts</h3>
<ul>
<li>Revert &quot;fix: codesign all binary-like files (<a href="https://github.com/electron-userland/electron-builder/issues/5322">#5322</a>)&quot; (<a href="https://github.com/electron-userland/electron-builder/issues/5488">#5488</a>) (<a href="026227888f">0262278</a>), closes <a href="https://github.com/electron-userland/electron-builder/issues/5322">#5322</a> <a href="https://github.com/electron-userland/electron-builder/issues/5488">#5488</a></li>
</ul>
<h2>22.10.3</h2>
<h3>Bug Fixes</h3>
<ul>
<li>signing of playwright (<a href="https://github.com/electron-userland/electron-builder/issues/5451">#5451</a>) (<a href="50750683b1">5075068</a>)</li>
<li><strong>dmg:</strong> new version of mac_alias (<a href="https://github.com/electron-userland/electron-builder/issues/5460">#5460</a>) (<a href="a8acb583bc">a8acb58</a>)</li>
<li>compiler error and test updates (<a href="https://github.com/electron-userland/electron-builder/issues/5449">#5449</a>) (<a href="0dec1b8c19">0dec1b8</a>)</li>
<li><strong>AppImage:</strong> Add default argument --no-sandbox (<a href="https://github.com/electron-userland/electron-builder/issues/4496">#4496</a>) (<a href="ede6d50ddb">ede6d50</a>)</li>
<li><strong>linux:</strong> Linux icon is not set if path is not explicitly defined in config (<a href="https://github.com/electron-userland/electron-builder/issues/5385">#5385</a>) (<a href="9fd950bc04">9fd950b</a>)</li>
<li><strong>nsis:</strong> cs locale typos in messages (<a href="https://github.com/electron-userland/electron-builder/issues/5358">#5358</a>) (<a href="0fb69b5d11">0fb69b5</a>)</li>
<li>codesign all binary-like files (<a href="https://github.com/electron-userland/electron-builder/issues/5322">#5322</a>) (<a href="27ea1b2b9c">27ea1b2</a>)</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="79940292bd"><code>7994029</code></a> Cannot read property 'log' of undefined (<a href="https://github.com/electron-userland/electron-builder/issues/5622">#5622</a>)</li>
<li><a href="1643d56960"><code>1643d56</code></a> feat(electron-updater): follow <code>autoInstallOnAppQuit = false</code> on macOS (<a href="https://github.com/electron-userland/electron-builder/issues/5271">#5271</a>)</li>
<li><a href="0360cd1705"><code>0360cd1</code></a> chore(build-utils): remove unreachable useless statement in createMessage (<a href="https://github.com/electron-userland/electron-builder/issues/5">https://github.com/facebook/flipper/issues/5</a>...</li>
<li><a href="c348e318ce"><code>c348e31</code></a> Add &quot;open&quot; guard for AsarUtil to fix concurrent builds (<a href="https://github.com/electron-userland/electron-builder/issues/5567">#5567</a>)</li>
<li><a href="11aa06c701"><code>11aa06c</code></a> Detect CI tag for Bitbucket pipelines</li>
<li><a href="8decc18674"><code>8decc18</code></a> (fix) master branch depCheck + tests (<a href="https://github.com/electron-userland/electron-builder/issues/5630">#5630</a>)</li>
<li><a href="46a8840bb4"><code>46a8840</code></a> fix: Look for the Amazon cred header to remove auth header (<a href="https://github.com/electron-userland/electron-builder/issues/5594">#5594</a>)</li>
<li><a href="0ba839b72b"><code>0ba839b</code></a> fix(mac): fix &quot;Contents/Info.plist&quot; don't have identical SHAs when creating a...</li>
<li><a href="60f7fe367c"><code>60f7fe3</code></a> fix: updating nsis script to properly identify arm64 vs x64 vs ia32 package f...</li>
<li><a href="5de0db981d"><code>5de0db9</code></a> chore: lint</li>
<li>Additional commits viewable in <a href="https://github.com/electron-userland/electron-builder/compare/v22.9.1...v22.10.5">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=electron-builder&package-manager=npm_and_yarn&previous-version=22.9.1&new-version=22.10.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2068

Reviewed By: passy

Differential Revision: D27230125

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 775e8d532b0516bf485b95e7057544d1d5a91e59
2021-03-23 09:16:58 -07:00
dependabot[bot]
6589aee6f1 Bump @emotion/styled from 11.0.0 to 11.1.5 in /desktop (#2067)
Summary:
Bumps [emotion/styled](https://github.com/emotion-js/emotion) from 11.0.0 to 11.1.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@​emotion/styled's releases</code></a>.</em></p>
<blockquote>
<h2>emotion/styled@11.1.5</h2>
<h3>Patch Changes</h3>
<ul>
<li>
<p><a href="d029350801"><code>d0293508</code></a> <a href="https://github.com/emotion-js/emotion/pull/2240">#2240</a> Thanks <a href="https://github.com/wolszczak96"><code>@​wolszczak96</code></a>! - <code>as</code> prop has been removed from TypeScript declarations for composite components. This prop has not actually been handled by default by <code>styled</code> for those components - to make <code>styled</code> handle it you need to provide a custom <code>shouldForwardProp</code> that doesn't forward the <code>as</code> prop.</p>
</li>
<li>
<p>Updated dependencies [<a href="f3c2e81d10"><code>f3c2e81d</code></a>]:</p>
<ul>
<li>emotion/is-prop-valid@1.1.0</li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="2fe9e0e945"><code>2fe9e0e</code></a> Version Packages (<a href="https://github.com/emotion-js/emotion/issues/2207">#2207</a>)</li>
<li><a href="d029350801"><code>d029350</code></a> Removed type for <code>as</code> prop for composite components (<a href="https://github.com/emotion-js/emotion/issues/2240">#2240</a>)</li>
<li><a href="f3c2e81d10"><code>f3c2e81</code></a> Added <code>option</code> &amp; <code>fallback</code> AMP props to the list of valid props (<a href="https://github.com/emotion-js/emotion/issues/2232">#2232</a>)</li>
<li><a href="b62647e8f5"><code>b62647e</code></a> Fix regex to comply with no-useless-escape ESLint rule</li>
<li><a href="400c6f7290"><code>400c6f7</code></a> Update slack link</li>
<li><a href="00cb6141a7"><code>00cb614</code></a> Update example describing how one can provide a library theme type using inte...</li>
<li><a href="4d2e732e9f"><code>4d2e732</code></a> Added export for <code>SerializedStyles</code> Flow type from <code>emotion/react</code> (<a href="https://github.com/emotion-js/emotion/issues/2206">#2206</a>)</li>
<li><a href="a89d4257b0"><code>a89d425</code></a> Lift Emotion 11 codemod instructions to the earlier spot in the docs (<a href="https://github.com/emotion-js/emotion/issues/2194">#2194</a>)</li>
<li><a href="a1e44aa56b"><code>a1e44aa</code></a> Version Packages (<a href="https://github.com/emotion-js/emotion/issues/2187">#2187</a>)</li>
<li><a href="71ca9be336"><code>71ca9be</code></a> Fix TypeScript support for custom components with non-standard declarations (...</li>
<li>Additional commits viewable in <a href="https://github.com/emotion-js/emotion/compare/emotion/styled@11.0.0...@emotion/styled@11.1.5">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@emotion/styled&package-manager=npm_and_yarn&previous-version=11.0.0&new-version=11.1.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2067

Reviewed By: passy

Differential Revision: D27230129

Pulled By: priteshrnandgaonkar

fbshipit-source-id: fcd95fb0db6b160df165189b6841ce5a42694459
2021-03-23 09:16:58 -07:00
dependabot[bot]
fd9b5b562a Bump spectron from 11.0.0 to 14.0.0 in /desktop (#2071)
Summary:
allow-large-files
Bumps [spectron](https://github.com/electron/spectron) from 11.0.0 to 14.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/electron/spectron/releases">spectron's releases</a>.</em></p>
<blockquote>
<h2>v13.0.0</h2>
<p>No release notes provided.</p>
<h2>v12.0.0</h2>
<p>No release notes provided.</p>
<h2>v11.1.0</h2>
<p>Upgraded webdriverio to 6.1.20 <a href="https://github.com/electron/spectron/issues/631">https://github.com/facebook/flipper/issues/631</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/electron/spectron/commits">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=spectron&package-manager=npm_and_yarn&previous-version=11.0.0&new-version=14.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2071

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

yarn test-e2e

Test Suite Succeded after running yarn test-e2e

Reviewed By: passy

Differential Revision: D27230110

Pulled By: priteshrnandgaonkar

fbshipit-source-id: d6d2d6c1482fa563b9dde9472467f918496e2cea
2021-03-23 08:46:58 -07:00
dependabot[bot]
12717e1b9d Bump app-builder-lib from 22.9.1 to 22.10.5 in /desktop (#2072)
Summary:
allow-large-files
Bumps [app-builder-lib](https://github.com/electron-userland/electron-builder) from 22.9.1 to 22.10.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases">app-builder-lib's releases</a>.</em></p>
<blockquote>
<h2>22.10.5</h2>
<p>We have a new maintainer — welcome Mike Maietta (<a href="https://github.com/mmaietta"><code>@​mmaietta</code></a>)!</p>
<p><strong>electron-updater</strong>  4.3.8 contains fix for <a href="https://github.com/electron-userland/electron-builder/issues/5595">#5595</a>. This version is a pre-release.</p>
<h3>Bug Fixes</h3>
<ul>
<li>Look for the Amazon cred header to remove auth header (<a href="https://github.com/electron-userland/electron-builder/issues/5594">#5594</a>) (<a href="46a8840bb4">46a8840</a>)</li>
<li><strong>mac:</strong> fix &quot;Contents/Info.plist&quot; don't have identical SHAs when creating a universal build (<a href="https://github.com/electron-userland/electron-builder/issues/5550">#5550</a>) (<a href="0ba839b72b">0ba839b</a>)</li>
<li>updating nsis script to properly identify arm64 vs x64 vs ia32 package files within universal installers. (<a href="https://github.com/electron-userland/electron-builder/issues/5558">#5558</a>) (<a href="60f7fe367c">60f7fe3</a>)</li>
<li><strong>mac:</strong> Allow arm64 macs to update to x64 version if no arm64 version available (<a href="https://github.com/electron-userland/electron-builder/issues/5524">#5524</a>) (<a href="dc5c2f8e77">dc5c2f8</a>)</li>
<li><strong>mac:</strong> Pass platformName and options in doPack (<a href="https://github.com/electron-userland/electron-builder/issues/5511">#5511</a>) (<a href="f78e3f48d7">f78e3f4</a>)</li>
<li><strong>mac:</strong> Workaround for hdiutil randomly failing (<a href="https://github.com/electron-userland/electron-builder/issues/5431">#5431</a>) (<a href="https://github.com/electron-userland/electron-builder/issues/5464">#5464</a>) (<a href="53270cfe4e">53270cf</a>)</li>
<li>binary detection signing (<a href="https://github.com/electron-userland/electron-builder/issues/5493">#5493</a>) (<a href="a6e86b5930">a6e86b5</a>), closes <a href="https://github.com/electron-userland/electron-builder/issues/5465">#5465</a></li>
<li>ci-tests (<a href="https://github.com/electron-userland/electron-builder/issues/5523">#5523</a>) (<a href="ced6e50b93">ced6e50</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li><strong>electron-updater:</strong> follow <code>autoInstallOnAppQuit = false</code> on macOS (<a href="https://github.com/electron-userland/electron-builder/issues/5271">#5271</a>) (<a href="1643d56960">1643d56</a>)</li>
<li>add support for executableName to non-Linux Platforms (<a href="https://github.com/electron-userland/electron-builder/issues/5409">#5409</a>) (<a href="106b68010f">106b680</a>)</li>
<li>Custom electronDist callback (<a href="https://github.com/electron-userland/electron-builder/issues/5527">#5527</a>) (<a href="4f4e018771">4f4e018</a>)</li>
<li>macOS default architecture (<a href="https://github.com/electron-userland/electron-builder/issues/5495">#5495</a>) (<a href="https://github.com/electron-userland/electron-builder/issues/5504">#5504</a>) (<a href="5203d7eb15">5203d7e</a>)</li>
</ul>
<h2>22.10.4</h2>
<h3>Bug Fixes</h3>
<ul>
<li>CI unit tests (<a href="https://github.com/electron-userland/electron-builder/issues/5489">#5489</a>) (<a href="637334ddba">637334d</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li>Apple Silicon Universal Support (<a href="https://github.com/electron-userland/electron-builder/issues/5481">#5481</a>) (<a href="ca20151c34">ca20151</a>)</li>
<li><strong>mas:</strong> Apple Silicon support (<a href="https://github.com/electron-userland/electron-builder/issues/5484">#5484</a>) (<a href="6b7d30555d">6b7d305</a>)</li>
</ul>
<h3>Reverts</h3>
<ul>
<li>Revert &quot;fix: codesign all binary-like files (<a href="https://github.com/electron-userland/electron-builder/issues/5322">#5322</a>)&quot; (<a href="https://github.com/electron-userland/electron-builder/issues/5488">#5488</a>) (<a href="026227888f">0262278</a>), closes <a href="https://github.com/electron-userland/electron-builder/issues/5322">#5322</a> <a href="https://github.com/electron-userland/electron-builder/issues/5488">#5488</a></li>
</ul>
<h2>22.10.3</h2>
<h3>Bug Fixes</h3>
<ul>
<li>signing of playwright (<a href="https://github.com/electron-userland/electron-builder/issues/5451">#5451</a>) (<a href="50750683b1">5075068</a>)</li>
<li><strong>dmg:</strong> new version of mac_alias (<a href="https://github.com/electron-userland/electron-builder/issues/5460">#5460</a>) (<a href="a8acb583bc">a8acb58</a>)</li>
<li>compiler error and test updates (<a href="https://github.com/electron-userland/electron-builder/issues/5449">#5449</a>) (<a href="0dec1b8c19">0dec1b8</a>)</li>
<li><strong>AppImage:</strong> Add default argument --no-sandbox (<a href="https://github.com/electron-userland/electron-builder/issues/4496">#4496</a>) (<a href="ede6d50ddb">ede6d50</a>)</li>
<li><strong>linux:</strong> Linux icon is not set if path is not explicitly defined in config (<a href="https://github.com/electron-userland/electron-builder/issues/5385">#5385</a>) (<a href="9fd950bc04">9fd950b</a>)</li>
<li><strong>nsis:</strong> cs locale typos in messages (<a href="https://github.com/electron-userland/electron-builder/issues/5358">#5358</a>) (<a href="0fb69b5d11">0fb69b5</a>)</li>
<li>codesign all binary-like files (<a href="https://github.com/electron-userland/electron-builder/issues/5322">#5322</a>) (<a href="27ea1b2b9c">27ea1b2</a>)</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="79940292bd"><code>7994029</code></a> Cannot read property 'log' of undefined (<a href="https://github.com/electron-userland/electron-builder/issues/5622">#5622</a>)</li>
<li><a href="1643d56960"><code>1643d56</code></a> feat(electron-updater): follow <code>autoInstallOnAppQuit = false</code> on macOS (<a href="https://github.com/electron-userland/electron-builder/issues/5271">#5271</a>)</li>
<li><a href="0360cd1705"><code>0360cd1</code></a> chore(build-utils): remove unreachable useless statement in createMessage (<a href="https://github.com/electron-userland/electron-builder/issues/5">https://github.com/facebook/flipper/issues/5</a>...</li>
<li><a href="c348e318ce"><code>c348e31</code></a> Add &quot;open&quot; guard for AsarUtil to fix concurrent builds (<a href="https://github.com/electron-userland/electron-builder/issues/5567">#5567</a>)</li>
<li><a href="11aa06c701"><code>11aa06c</code></a> Detect CI tag for Bitbucket pipelines</li>
<li><a href="8decc18674"><code>8decc18</code></a> (fix) master branch depCheck + tests (<a href="https://github.com/electron-userland/electron-builder/issues/5630">#5630</a>)</li>
<li><a href="46a8840bb4"><code>46a8840</code></a> fix: Look for the Amazon cred header to remove auth header (<a href="https://github.com/electron-userland/electron-builder/issues/5594">#5594</a>)</li>
<li><a href="0ba839b72b"><code>0ba839b</code></a> fix(mac): fix &quot;Contents/Info.plist&quot; don't have identical SHAs when creating a...</li>
<li><a href="60f7fe367c"><code>60f7fe3</code></a> fix: updating nsis script to properly identify arm64 vs x64 vs ia32 package f...</li>
<li><a href="5de0db981d"><code>5de0db9</code></a> chore: lint</li>
<li>Additional commits viewable in <a href="https://github.com/electron-userland/electron-builder/compare/v22.9.1...v22.10.5">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=app-builder-lib&package-manager=npm_and_yarn&previous-version=22.9.1&new-version=22.10.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2072

Reviewed By: passy

Differential Revision: D27230105

Pulled By: priteshrnandgaonkar

fbshipit-source-id: e53e942319a15d982797f7ce3af128a8b25b357f
2021-03-23 08:46:58 -07:00
Robert A Barclay
025b51a284 Fixes the Flipper-RSocket podspec to exclude .txt and .md files (#2079)
Summary:
Fixes the Flipper-RSocket podspec similar to the [RSocket podpec](https://github.com/facebook/flipper/pull/1438) to exclude the .md and .txt files from the compilation, which is throwing a warning.

Removal of these warnings:

```
warning: no rule to process file '<redacted>/ios/Pods/Flipper-RSocket/rsocket/benchmarks/CMakeLists.txt' of type 'text' for architecture 'arm64' (in target 'Flipper-RSocket' from project 'Pods')
warning: no rule to process file '<redacted>/ios/Pods/Flipper-RSocket/rsocket/benchmarks/README.md' of type 'net.daringfireball.markdown' for architecture 'arm64' (in target 'Flipper-RSocket' from project 'Pods')
warning: no rule to process file '<redacted>/ios/Pods/Flipper-RSocket/rsocket/README.md' of type 'net.daringfireball.markdown' for architecture 'arm64' (in target 'Flipper-RSocket' from project 'Pods')
```

## Changelog

Fix Flipper-RSocket podspec to exclude .txt and .md files from being included in the compilation

Pull Request resolved: https://github.com/facebook/flipper/pull/2079

Reviewed By: passy

Differential Revision: D27230095

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 0876901aaad1a3b4e8093ed4ccf1cc845e18032a
2021-03-22 18:28:57 -07:00
dependabot[bot]
f5b729d91c Bump fresco from 2.2.0 to 2.3.0 (#2055)
Summary:
Bumps [fresco](https://github.com/facebook/fresco) from 2.2.0 to 2.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/fresco/releases">fresco's releases</a>.</em></p>
<blockquote>
<h2>Version 2.3.0</h2>
<h1>Highlights</h1>
<ul>
<li>
<p><strong>Bumped Fresco's minSdk to 14.</strong> We did not remove any Gingerbread-specific code yet, but will do so soon. 091e8b7c4cd11a6cc5b535dd84d8e21a1e243ac0</p>
</li>
<li>
<p>Proper nullability annotations for some classes by using new Infer annotations - this improves Kotlin support and null-safety.</p>
</li>
<li>
<p>Improved Java-only Fresco setup. 4a9961559c8240cbb88eeecf2303f956d0185120</p>
</li>
<li>
<p>Lots of debug logging improvements: More reliable image origin, new MEMORY_BITMAP_SHORTCUT origin, more debug information available. These are available via <code>ImagePerfData#getExtraData()</code></p>
</li>
<li>
<p>Added experimental option to recover from OOMs: f43d5990600c9ac6c3a18e14e4d3c260cf78b462</p>
</li>
<li>
<p>Added option to force a single image pipeline instance: 5f5c076fe26b17a849498c27c7541550c3ef3984</p>
</li>
<li>
<p>Disk cache support for the Fresco Flipper images plugin.</p>
</li>
<li>
<p>Bumped SoLoader version to 0.9.0.</p>
</li>
<li>
<p>Use <code>buildSrc</code> for Fresco's internal dependency management.</p>
</li>
<li>
<p>WIP: Lots of improvements for our new Fresco Vito UI components.</p>
</li>
</ul>
<p>Pull requests:</p>
<ul>
<li>Fixed resource leak problem while using BlurPostProcessor. Thanks <a href="https://github.com/FrancescoJo"><code>@​FrancescoJo</code></a> for the PR.</li>
<li>Make sure there is at least one overlay in GenericDraweeHierarchy. Thanks <a href="https://github.com/dengweichao"><code>@​dengweichao</code></a> for the PR.</li>
<li>Removed unused padding value. Thanks <a href="https://github.com/erenulas"><code>@​erenulas</code></a> for the PR.</li>
</ul>
<h1>Cleanup</h1>
<ul>
<li>Removed Drawee-Volley module. If you're using Drawee-Volley, you can still continue using it by just copying the files removed with 7c2517edee7d4080fab0daf54fd4ac4eca6a8497 into your project. We did not significantly change these in a long time, so this has been stable.</li>
<li>Removed OkHttp2 image pipeline artifact. See deba7d1c3c218377a5b67e58f269914d8f8a88be</li>
</ul>
<p>Full changelog: <a href="https://github.com/facebook/fresco/compare/v2.2.0...v2.3.0">https://github.com/facebook/fresco/compare/v2.2.0...v2.3.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="bbc795aa96"><code>bbc795a</code></a> Minor: remove StringDef usage</li>
<li><a href="c74abcdfa8"><code>c74abcd</code></a> Bump version to 2.3.0</li>
<li><a href="0de3d2c23e"><code>0de3d2c</code></a> Update recover-from-OOM experiment setup</li>
<li><a href="a9a2d71f2d"><code>a9a2d71</code></a> Add working range prefetching for FrescoVitoImage2Spec</li>
<li><a href="f43d599060"><code>f43d599</code></a> Add option to attempt a recover from OOM to DecodeProducer</li>
<li><a href="a771005806"><code>a771005</code></a> Daily <code>arc lint --take GOOGLEJAVAFORMAT</code></li>
<li><a href="b002d8eab4"><code>b002d8e</code></a> Use concurrent version of list in image perf monitor</li>
<li><a href="3c96d444a8"><code>3c96d44</code></a> Vito2: Add support for animated image auto play</li>
<li><a href="a1ced14444"><code>a1ced14</code></a> allow probing disk cache when image is fetched from network</li>
<li><a href="22a74867bb"><code>22a7486</code></a> HttpUrlConnectionNetworkFetcher: specify arbitrary request headers</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/fresco/compare/v2.2.0...v2.3.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.facebook.fresco:fresco&package-manager=gradle&previous-version=2.2.0&new-version=2.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2055

Reviewed By: passy

Differential Revision: D27230358

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 4fa283d75933b485676956b17474dd0ad3db3d66
2021-03-22 17:23:12 -07:00
dependabot[bot]
da25b49428 Bump espresso-intents from 3.1.0 to 3.3.0 (#2056)
Summary:
Bumps espresso-intents from 3.1.0 to 3.3.0.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=androidx.test.espresso:espresso-intents&package-manager=gradle&previous-version=3.1.0&new-version=3.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2056

Reviewed By: passy

Differential Revision: D27230354

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 18b7113a6463b486ae1e2c9023a986388d75776f
2021-03-22 17:23:12 -07:00