Summary:
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.148 to 1.0.152.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p>
<blockquote>
<h2>v1.0.152</h2>
<ul>
<li>Documentation improvements</li>
</ul>
<h2>v1.0.151</h2>
<ul>
<li>Update <code>serde::</code>{<code>ser</code>,<code>de</code>}<code>::StdError</code> to re-export <code>core::error::Error</code> when serde is built with <code>feature="std"</code> <strong>off</strong> and <code>feature="unstable"</code> <strong>on</strong> (<a href="https://github-redirect.dependabot.com/serde-rs/serde/issues/2344">https://github.com/facebook/flipper/issues/2344</a>)</li>
</ul>
<h2>v1.0.150</h2>
<ul>
<li>Relax some trait bounds from the <code>Serialize</code> impl of <code>HashMap</code> and <code>BTreeMap</code> (<a href="https://github-redirect.dependabot.com/serde-rs/serde/issues/2334">https://github.com/facebook/flipper/issues/2334</a>)</li>
<li>Enable <code>Serialize</code> and <code>Deserialize</code> impls of <code>std::sync::atomic</code> types on more platforms (<a href="https://github-redirect.dependabot.com/serde-rs/serde/issues/2337">https://github.com/facebook/flipper/issues/2337</a>, thanks <a href="https://github.com/badboy"><code>@badboy</code></a>)</li>
</ul>
<h2>v1.0.149</h2>
<ul>
<li>Relax some trait bounds from the <code>Serialize</code> impl of <code>BinaryHeap</code>, <code>BTreeSet</code>, and <code>HashSet</code> (<a href="https://github-redirect.dependabot.com/serde-rs/serde/issues/2333">https://github.com/facebook/flipper/issues/2333</a>, thanks <a href="https://github.com/jonasbb"><code>@jonasbb</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="ccf9c6fc07"><code>ccf9c6f</code></a> Release 1.0.152</li>
<li><a href="b25d0ea7f9"><code>b25d0ea</code></a> Link to Hjson data format</li>
<li><a href="4f4557fd05"><code>4f4557f</code></a> Link to bencode data format</li>
<li><a href="bf400d6799"><code>bf400d6</code></a> Link to serde_tokenstream data format</li>
<li><a href="4d2e36d19b"><code>4d2e36d</code></a> Wrap flexbuffers bullet point to 80 columns</li>
<li><a href="df6310e5f5"><code>df6310e</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/serde-rs/serde/issues/2347">https://github.com/facebook/flipper/issues/2347</a> from dtolnay/docsrs</li>
<li><a href="938ab5ddec"><code>938ab5d</code></a> Replace docs.serde.rs links with intra-rustdoc links</li>
<li><a href="ef5a0de384"><code>ef5a0de</code></a> Point documentation links to docs.rs instead of docs.serde.rs</li>
<li><a href="5d186c77a6"><code>5d186c7</code></a> Opt out -Zrustdoc-scrape-examples on docs.rs</li>
<li><a href="44bf3633af"><code>44bf363</code></a> Release 1.0.151</li>
<li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.148...v1.0.152">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4414
Reviewed By: ivanmisuno
Differential Revision: D43117895
Pulled By: mweststrate
fbshipit-source-id: 8c20da3d1e4566ed9a3cd060c9c4e4aa5be1237f
Summary:
This change addresses some obvious issues which made the ui-debugger unusable with dark mode on.
There may more things that need changing, but at the very least this should be a good place to start.
Reviewed By: fabiomassimo
Differential Revision: D43083218
fbshipit-source-id: 8e4338b79178d3a0f05f9bcaffa2fc6f35eb0e21
Summary: This is internal to ui-debugger so there's no need to surface this information to users.
Reviewed By: ivanmisuno
Differential Revision: D43081188
fbshipit-source-id: f6abdeb7828a1709d2590cf2a10407baec645420
Summary:
This change mainly removes the connection timeout period as it may introduce a race condition in which slow server connections get terminated potentially creating connection loops.
Also, suspend and wait for all operations to complete once a socket is disconnected.
Reviewed By: ivanmisuno
Differential Revision: D43048252
fbshipit-source-id: 64c28a3d3d2fd4e065084d5f55a17444385c07e0
Summary:
Provide a documentation about marketplace feature of Flipper.
This should cover:
1. Introduction of the feature (plugin discovery, auto update)2.
2. Marketplace server - to list available plugins
3. Flipper settings - describe the new settings and how to enable4.
Closes https://github.com/facebook/flipper/issues/3545.
## Changelog
Pull Request resolved: https://github.com/facebook/flipper/pull/4395
Reviewed By: antonk52
Differential Revision: D42918936
Pulled By: passy
fbshipit-source-id: 50b10178b569ecc6ea65b736ea58db401cf686c6
Summary:
Previously we were checking the framework events stream for any new events and populating the map from that. Now we expect the init event to contain event types.
This allows us to know if the app supports framework event and therefore we dont show the controls to monitor it. Additionally we can fully populate the event monitoring dialog
Reviewed By: lblasa
Differential Revision: D42996552
fbshipit-source-id: 7850ada53d0630ba102af6c0d74d9d904f75eada
Summary: When an event is monitored show running total in the tree
Reviewed By: lblasa
Differential Revision: D42996553
fbshipit-source-id: 9b7bd5d2e98d8775f28b0b541f4eb1bd8231cc3e
Summary:
Listen to framework events and store in a map based on node id
Added UI to allow for monitoring framework event types.
The event type is a string separated by : Each segment of this string represents a level in the dialog hierachy. For example Litho:Layout:StateUpdateSync would have levels, Litho Layout StateUpdateSync
When event type monitored and event comes in for a node flash the visualiser node briefly
Reviewed By: lblasa
Differential Revision: D42074988
fbshipit-source-id: 52458ad87ab84bf7b1749e87be516ed73106a6c0
Summary: We are using frame time on android so make sense to present it
Reviewed By: lblasa
Differential Revision: D42996555
fbshipit-source-id: 595a08571ccd82de0761cfeea8a204e576981ee0
Summary: For deep nested hierarchies, the current offset was too big making the hierarchy almost un-browsable. The current offset seems to work better.
Reviewed By: LukeDefeo
Differential Revision: D42996296
fbshipit-source-id: 808a2ecc32aff2d8d252bdb9f653344866e5653b
Summary:
^
Only for iOS this time.
Note: passing the device OS freely to the main component as this is just temporary code that will be deleted soon.
Reviewed By: antonk52
Differential Revision: D42990221
fbshipit-source-id: 41b4107caa6bf312191889af75afd28873f6eda5
Summary: The call to myles was a little slow and very cachable so use react query. Additionally it depends on VPN / light so added an error state to make that clear.
Reviewed By: lblasa
Differential Revision: D42990344
fbshipit-source-id: 8d6ad20aea79f1972a7cf1f61f8af729e5f3464f
Summary:
^
If the connected device was not an Android device, we were not showing the notification. This change removes that check to also advertise on iOS.
Reviewed By: mweststrate
Differential Revision: D42989975
fbshipit-source-id: eac8d588be789dcab281a746395a4fb7a88df790
Summary: Combining a bunch of upgrade tasks from my queue into one.
Reviewed By: antonk52
Differential Revision: D42884917
fbshipit-source-id: fecfdc0506d6081545b05d3de6ae18cd449917af
Summary:
It's currently failing and a few according to [the docs](https://github.com/benc-uk/workflow-dispatch) the token we supply shouldn't be necessary.
Pull Request resolved: https://github.com/facebook/flipper/pull/4495
Test Plan:
Sadly only one way:
testinprod
Reviewed By: lblasa
Differential Revision: D42989714
Pulled By: passy
fbshipit-source-id: e758340a583e351ff4e384514b70fecdf8bb3129
Summary:
The 'screenrecord' command is not in some Android phones e.g OPPO. So 'screenrecord' command can't be used as a basis for determining whether or not you can take a screenshot. Replace it with 'screencap' command to determine whether you can take a screenshot.
## Changelog
Fixed a bug where the screenshot of some Android phones was unavailable
Pull Request resolved: https://github.com/facebook/flipper/pull/4366
Test Plan: It passed the test on my Mac and OPPO phone Reno2.
Reviewed By: ivanmisuno
Differential Revision: D42918902
Pulled By: passy
fbshipit-source-id: c1f02f075817d90e0d447f466a1168b6ec932e4e
Summary: Ideally, this wouldn't fire at all as it's a timeout but removing the ID will at least allow de-duplication.
Reviewed By: ivanmisuno
Differential Revision: D42800581
fbshipit-source-id: 605f2e81c326a3203c72b253362cb0b27139a134
Summary:
Bumps [rayon](https://github.com/rayon-rs/rayon) from 1.6.0 to 1.6.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/rayon-rs/rayon/blob/master/RELEASES.md">rayon's changelog</a>.</em></p>
<blockquote>
<h1>Release rayon 1.6.1 (2022-12-09)</h1>
<ul>
<li>Simplified <code>par_bridge</code> to only pull one item at a time from the iterator,
without batching. Threads that are waiting for iterator items will now block
appropriately rather than spinning CPU. (Thanks <a href="https://github.com/njaard"><code>@njaard</code></a>!)</li>
<li>Added protection against recursion in <code>par_bridge</code>, so iterators that also
invoke rayon will not cause mutex recursion deadlocks.</li>
</ul>
<h1>Release rayon-core 1.10.1 (2022-11-18)</h1>
<ul>
<li>Fixed a race condition with threads going to sleep while a broadcast starts.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="401678ee55"><code>401678e</code></a> Merge <a href="https://github-redirect.dependabot.com/rayon-rs/rayon/issues/709">https://github.com/facebook/flipper/issues/709</a></li>
<li><a href="33e9843413"><code>33e9843</code></a> Release rayon 1.2.1 / rayon-core 1.6.1</li>
<li><a href="dd874ac5d4"><code>dd874ac</code></a> Bump crate versions and dependencies</li>
<li><a href="0c6338d267"><code>0c6338d</code></a> Reduce Option complexity in demo cpu_time</li>
<li><a href="be99e500bf"><code>be99e50</code></a> cargo fmt</li>
<li><a href="9b4d9798de"><code>9b4d979</code></a> Avoid mem::uninitialized in the demo cpu_time</li>
<li><a href="5a466434ab"><code>5a46643</code></a> Avoid mem::uninitialized in par_sort_unstable</li>
<li><a href="73b1061a23"><code>73b1061</code></a> Merge <a href="https://github-redirect.dependabot.com/rayon-rs/rayon/issues/705">https://github.com/facebook/flipper/issues/705</a></li>
<li><a href="54c0b0dc0c"><code>54c0b0d</code></a> Make sure that compat-Cargo.lock is fresh</li>
<li><a href="4fd13b0334"><code>4fd13b0</code></a> Regenerate compat-Cargo.lock</li>
<li>Additional commits viewable in <a href="https://github.com/rayon-rs/rayon/compare/rayon-core-v1.6.0...rayon-core-v1.6.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4368
Reviewed By: ivanmisuno
Differential Revision: D42706124
Pulled By: passy
fbshipit-source-id: 4222388e2c580e8c8f5ec4a88626b947749fff35
Summary:
Tasks like T143443148 pop up frequently and are inactionable. This is usually due to device flakiness, storage being full, incompatibility or configuration problems.
Start and stop were also copy-pasted to make matters worse.
Reviewed By: ivanmisuno
Differential Revision: D42800489
fbshipit-source-id: 11caaa4133e4fa1d773364a6ba4e5f5bb0d2f2ce
Summary: The additional panel was confusing. We can add a search filter box later if needed
Reviewed By: lblasa
Differential Revision: D42801264
fbshipit-source-id: 4b2ecb44c5bc4751564a5cac3716f5af4a951f58
Summary:
^
Revert as to validate this is not causing regressions: T143523262
Reviewed By: passy
Differential Revision: D42800560
fbshipit-source-id: 8db61454eabfdb259637bb97c2bb4754984ecf6f
Summary:
Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.21.9 to 3.21.12.
<details>
<summary>Commits</summary>
<ul>
<li><a href="f0dc78d7e6"><code>f0dc78d</code></a> Updating version.json and repo version numbers to: 21.12</li>
<li><a href="7b0ca6995d"><code>7b0ca69</code></a> Updated release branch to latest upb. (<a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/11258">#11258</a>)</li>
<li><a href="7c123c40e2"><code>7c123c4</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/11201">#11201</a> from protocolbuffers/21.x-202212080033</li>
<li><a href="44eafb2f65"><code>44eafb2</code></a> Update version.json to: 21.12-dev</li>
<li><a href="aea4a275e2"><code>aea4a27</code></a> Updating changelog</li>
<li><a href="ffe65a5040"><code>ffe65a5</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/11197">#11197</a> from protocolbuffers/21.x-202212071935</li>
<li><a href="a474c5b9ff"><code>a474c5b</code></a> Updating version.json and repo version numbers to: 21.11</li>
<li><a href="c0bc0cf076"><code>c0bc0cf</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/11196">#11196</a> from ericsalo/21.x</li>
<li><a href="9d17e97927"><code>9d17e97</code></a> sync with current 21.x upb</li>
<li><a href="d024e3bca1"><code>d024e3b</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/11118">#11118</a> from protocolbuffers/deannagarcia-patch-12</li>
<li>Additional commits viewable in <a href="https://github.com/protocolbuffers/protobuf/compare/v3.21.9...v3.21.12">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4385
Reviewed By: ivanmisuno
Differential Revision: D42706116
Pulled By: passy
fbshipit-source-id: d74a7a1984d7c49d1d95ce71fbcdff86715c7aa2
Summary:
This diff has been automatically generated by the inpage editor.
NOTE: If you want to update this diff, go via the preview link inside the static docs section below.
Ensure you are editing the same page that was used to create this diff.
Reviewed By: ivanmisuno
Differential Revision: D42740196
fbshipit-source-id: ae7add46f7901e123d7a670bc39675ebf7a08a78
Summary:
Even with batching, updates can get split in half due to fact that each litho view has its own independant throttle. Eventually they will drift and and a traversal will get scheduled past the current frame for some of the views. It results in artifacts in the visualiser and will make time travelling wonky
The
Reviewed By: lblasa
Differential Revision: D42606932
fbshipit-source-id: c4cdf729302a380928b4d8720a59d5f7f6ff645a
Summary:
This is needed in preperation for the next diff where we will introduce an observer per litho view. Without batching we end up with really poor performance for a few reasons:
1. There are some operations on the desktop plugin that are o(nodes) so even sending small batches
2. Flipper isnt really a high performance message bus, it seems to prefer fewer larger messages
3. Queuing time on the client builds up as you spend more time waiting on the socket
In a future diff will address:
The name of subtree update event. It should probably be called something like FrameUpdate since they are always full frames
The performance monitoring, will more to timing methods and summing the result rather than the current appraoch of time markers
Reviewed By: lblasa
Differential Revision: D42453229
fbshipit-source-id: eda9830b4420e82874717cc69b241e1689f20029
Summary: We have gotton concurrent modification crashes from this
Reviewed By: lblasa
Differential Revision: D42343224
fbshipit-source-id: 9cf4046da63d40cbe6632c3ae24d95abd21081ba
Summary: Combining a bunch of individual tasks for dep upgrades into one diff.
Reviewed By: ivanmisuno
Differential Revision: D42706074
fbshipit-source-id: 054b2545ad1295699f47f4c6eb5065b7b9a1d6a0
Summary:
Bumps [ignore](https://github.com/BurntSushi/ripgrep) from 0.4.18 to 0.4.20.
<details>
<summary>Commits</summary>
<ul>
<li><a href="fe97c0a152"><code>fe97c0a</code></a> ignore-0.4.20</li>
<li><a href="826f3fad5b"><code>826f3fa</code></a> ignore/api: add Clone and Debug impls for OverrideBuilder</li>
<li><a href="ca60fef4db"><code>ca60fef</code></a> grep-0.2.11</li>
<li><a href="a25307d6c8"><code>a25307d</code></a> deps: update to grep-printer 0.1.7</li>
<li><a href="b80947a8b3"><code>b80947a</code></a> grep-printer-0.1.7</li>
<li><a href="ad793a0d8f"><code>ad793a0</code></a> deps: update to grep-searcher 0.1.11</li>
<li><a href="120e55e7c7"><code>120e55e</code></a> grep-searcher-0.1.11</li>
<li><a href="3941a7701d"><code>3941a77</code></a> deps: update to grep-pcre2 0.1.6</li>
<li><a href="96e130fbf9"><code>96e130f</code></a> grep-pcre2-0.1.6</li>
<li><a href="180c4eaf8b"><code>180c4ea</code></a> deps: update to grep-regex 0.1.11</li>
<li>Additional commits viewable in <a href="https://github.com/BurntSushi/ripgrep/compare/ignore-0.4.18...ignore-0.4.20">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4441
Reviewed By: antonk52
Differential Revision: D42678099
Pulled By: passy
fbshipit-source-id: 63791511856586391cc19947e6e49a3684f936ab
Summary:
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.9.0 to 5.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/mockito/mockito/releases">mockito-core's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h1>Mockito 5: prepare for future JDK versions</h1>
<p>For a while now, we have seen an increase in problems/incompatibilities with recent versions of the JDK due to our usage of JVM-internal API.
Most notably, JDK 17 made some changes which are incompatible with the current subclass mockmaker.
Therefore, to prepare for the future of JDK, we are making some core changes to ensure Mockito keeps on working.</p>
<h2>Switch the default mockmaker to <code>mockito-inline</code></h2>
<p>Back in Mockito 2.7.6, we published a new mockmaker based on the "inline bytecode" principle.
This mockmaker creates mocks manipulating bytecode equivalent within the original class such that its method implementations hook into the normal Mockito machinery.
As a comparison, the subclass mockmaker generates "real" subclasses for mocks, to mimic the same behavior.
While the approaches are similar, the inline mockmaker avoids certain restrictions that the JDK imposes.
For example, it does not violate module boundaries (introduced in JDK 9, but more heavily used in JDK 17) and avoids the leaking of the creation of the subclass.</p>
<p>Massive thanks to community member <a href="https://github.com/reta"><code>@reta</code></a> who implemented this change.</p>
<h3>When should I still be using the subclass mockmaker?</h3>
<p>There are legitimate remaining use cases for the subclass mockmaker.
For example, on the Graal VM's native image, the inline mockmaker will not work and the subclass mockmaker is the appropriate choice.
Additionally, if you would like to avoid mocking final classes, using the subclass mockmaker is a possibibility.
Note however that if you solely want to use the subclass mockmaker to avoid mocking final, you will run into the above mentioned issues on JDK 17+.
We want to leave this choice up to our users, which is why we will keep on supporting the subclass mockmaker.</p>
<p>If you want to use the subclass mockmaker instead, you can use the new <code>mockito-subclass</code> artifact (published <a href="https://search.maven.org/artifact/org.mockito/mockito-subclass">on Maven Central</a> along with all our other artifacts).</p>
<h2>Update the minimum supported Java version to 11</h2>
<p>Mockito 4 supports Java 8 and above.
Similar to other open source projects, we are moving away from JDK 8 and to newer versions.
The primary reason for moving away from JDK 8 is the increasing maintenance costs with keeping our own infrastructure working.
Lately we have been running into more and more JDK 8 breakages.
Additionally, while we want to support the newest JDK API's, our current solution to support both JDK 8 and newer versions causes <a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2798">issues with the <code>SecurityManager</code></a>.
Since we want Mockito to work on the newest version and more and more businesses adopting JDK 11, we have decided to make the switch as well.</p>
<p>Massive thanks to community member <a href="https://github.com/reta"><code>@reta</code></a> who implemented this change.</p>
<h3>What should I do if I still run JDK 8?</h3>
<p>For JDK 8 and below, you can keep on using Mockito 4.
This is similar to if you are using JDK 6, for which you can keep on using Mockito 2.
The changes in Mockito 5 (for now) are primarily focused on the latest JDK versions, which means the API differences between Mockito 4 and 5 are minimal.
However, over time this will most likely widen, so we do recommend adopting JDK 11 in the future.</p>
<h2>New <code>type()</code> method on <code>ArgumentMatcher</code></h2>
<p>One of our most used public API's for customizing Mockito is the <a href="https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/ArgumentMatcher.html"><code>ArgumentMatcher</code> interface</a>.
The interface allows you to define a custom matcher, which you can pass into method arguments to provide more targeted matches.
One major shortcoming of the <code>ArgumentMatcher</code> was the lack of varargs support.</p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="adf528d173"><code>adf528d</code></a> Bump versions.bytebuddy from 1.12.21 to 1.12.22 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2864">https://github.com/facebook/flipper/issues/2864</a>)</li>
<li><a href="2418419a19"><code>2418419</code></a> Bump versions.junitJupiter from 5.9.1 to 5.9.2 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2858">https://github.com/facebook/flipper/issues/2858</a>)</li>
<li><a href="3d40cd51d3"><code>3d40cd5</code></a> Bump junit-platform-launcher from 1.9.1 to 1.9.2 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2859">https://github.com/facebook/flipper/issues/2859</a>)</li>
<li><a href="9bec8e3a1a"><code>9bec8e3</code></a> Bump versions.errorprone from 2.17.0 to 2.18.0 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2857">https://github.com/facebook/flipper/issues/2857</a>)</li>
<li><a href="a9595f559c"><code>a9595f5</code></a> Switch the default mockmaker to the inline mockmaker on JDK 17+ (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2834">https://github.com/facebook/flipper/issues/2834</a>)</li>
<li><a href="c5d7fbc532"><code>c5d7fbc</code></a> Bump assertj-core from 3.23.1 to 3.24.1 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2854">https://github.com/facebook/flipper/issues/2854</a>)</li>
<li><a href="dbd7f2ff4a"><code>dbd7f2f</code></a> Bump versions.bytebuddy from 1.12.20 to 1.12.21 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2852">https://github.com/facebook/flipper/issues/2852</a>)</li>
<li><a href="4d62fa75c7"><code>4d62fa7</code></a> Bump junit from 1.1.4 to 1.1.5 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2850">https://github.com/facebook/flipper/issues/2850</a>)</li>
<li><a href="b1b6d6afcb"><code>b1b6d6a</code></a> Bump espresso-core from 3.5.0 to 3.5.1 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2849">https://github.com/facebook/flipper/issues/2849</a>)</li>
<li><a href="7b5b8dd840"><code>7b5b8dd</code></a> Remove use case for non-existent method VerificationWithTimeout#never (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2848">https://github.com/facebook/flipper/issues/2848</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/mockito/mockito/compare/v4.9.0...v5.0.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4444
Reviewed By: antonk52
Differential Revision: D42678087
Pulled By: passy
fbshipit-source-id: 7e1e38af900b985a26b42342297e15ab7eda9546
Summary:
Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.66 to 1.0.68.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/anyhow/releases">anyhow's releases</a>.</em></p>
<blockquote>
<h2>1.0.67</h2>
<ul>
<li>Improve the backtrace captured when <code>context()</code> is used on an <code>Option</code> (<a href="https://github-redirect.dependabot.com/dtolnay/anyhow/issues/280">https://github.com/facebook/flipper/issues/280</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="867763b8fc"><code>867763b</code></a> Release 1.0.68</li>
<li><a href="c0a87d0a1f"><code>c0a87d0</code></a> Opt out -Zrustdoc-scrape-examples on docs.rs</li>
<li><a href="1cc707b6f8"><code>1cc707b</code></a> Release 1.0.67</li>
<li><a href="613b26115c"><code>613b261</code></a> Update build status badge</li>
<li><a href="0f922d7c51"><code>0f922d7</code></a> Disable backtrace CI on Rust 1.50</li>
<li><a href="acecd9bd35"><code>acecd9b</code></a> Update ui test suite to nightly-2022-12-15</li>
<li><a href="0bac51f19b"><code>0bac51f</code></a> Time out workflows after 45 minutes</li>
<li><a href="60e88002dc"><code>60e8800</code></a> Fix renamed let_underscore_drop lint</li>
<li><a href="8d1c734b81"><code>8d1c734</code></a> Update ui test suite to nightly-2022-11-16</li>
<li><a href="451651b2ba"><code>451651b</code></a> Update ui test suite to nightly-2022-11-11</li>
<li>Additional commits viewable in <a href="https://github.com/dtolnay/anyhow/compare/1.0.66...1.0.68">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4400
Reviewed By: antonk52
Differential Revision: D42639009
Pulled By: passy
fbshipit-source-id: 2d512ef7b99d2ad51736cab2ae2395df82f9c078
Summary:
Bumps [serde_yaml](https://github.com/dtolnay/serde-yaml) from 0.9.14 to 0.9.17.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/serde-yaml/releases">serde_yaml's releases</a>.</em></p>
<blockquote>
<h2>0.9.17</h2>
<ul>
<li>Improve Debug representation of some error messages</li>
</ul>
<h2>0.9.16</h2>
<ul>
<li>Opt out of <code>-Zrustdoc-scrape-examples</code> on docs.rs for now</li>
</ul>
<h2>0.9.15</h2>
<ul>
<li>Documentation improvements</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1cf6e8ebde"><code>1cf6e8e</code></a> Release 0.9.17</li>
<li><a href="0d9e6c756b"><code>0d9e6c7</code></a> Improve formatting of single quote in Debug</li>
<li><a href="3ff550655d"><code>3ff5506</code></a> Speed up cargo fuzz CI job</li>
<li><a href="8261d9327d"><code>8261d93</code></a> Lint derive_hash_xor_eq renamed to derived_hash_with_manual_eq</li>
<li><a href="bb17d5ee8f"><code>bb17d5e</code></a> Preserve is_human_readable setting of wrapped de/serializer</li>
<li><a href="ecdb5bf2ec"><code>ecdb5bf</code></a> Prevent actions duplication on noop merge commits</li>
<li><a href="aed75edf52"><code>aed75ed</code></a> Sync license text with rust-lang repos</li>
<li><a href="e8fbca66b4"><code>e8fbca6</code></a> Release 0.9.16</li>
<li><a href="80ad63022b"><code>80ad630</code></a> Opt out -Zrustdoc-scrape-examples on docs.rs</li>
<li><a href="2d0b7bd7bd"><code>2d0b7bd</code></a> Release 0.9.15</li>
<li>Additional commits viewable in <a href="https://github.com/dtolnay/serde-yaml/compare/0.9.14...0.9.17">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4459
Reviewed By: antonk52
Differential Revision: D42678096
Pulled By: passy
fbshipit-source-id: d525da955a9aa274f553a7a6477f99c6118045d4
Summary:
^
SKDescriptorMapper owns the SKNodeDescriptor instances. SKNodeDescriptor instances should only have a weak reference to the mapper as to avoid retain cycles.
Reviewed By: passy
Differential Revision: D42673698
fbshipit-source-id: 8c98709b28fc3c711dc56c179c7c362417fa1f9d
Summary:
A few changes that should make our connect/disconnect more robust:
* Certificate provider handler should be set directly to and managed by the policy.
* Instantiate the socket once, synchronously on the connect method. Explicit deallocation once, synchronously on the disconnect method.
* Clear handlers on disconnect after clearing the delegate.
* Wait for the operation queue to drain before returning.
Reviewed By: passy
Differential Revision: D42664724
fbshipit-source-id: bd482acbb64a9bc9e36fb3418d4c81afa2109305
