Summary: Turns out Windows really doesn't like colons in filenames. Sigh.
Reviewed By: jknoxville
Differential Revision: D17664236
fbshipit-source-id: 664885308815d862007c8a9a9d1278c426b4e756
Summary:
Instead of our ad-hoc mechanism. There's quite a bit
of trickery involved to make this work reliably on Windows
so I'd rather take an off-the-shelf solution than reimplement this
myself.
Reviewed By: jknoxville
Differential Revision: D17628949
fbshipit-source-id: 98806b60a107231d9ee07b721ebb70f2cbd8aec1
Summary:
D17629896 was intended to fix this in ovrsource, but it turns out these changes should be made on fbsource first then get synced.
The MSVC build of OculusPCSDK has numerous warnings, including these low-hanging fruit:
```
c:\open\ovrsource\xplat\omnistore\client\common\reportsubscriptionstatetiming.cpp(28): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\databaseanalyticsmetadatatiming.cpp(23): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\sendqueuereportbacklogtiming.cpp(32): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\omnistore.cpp(192): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\omnistore.cpp(907): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\omnistore.cpp(934): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\omnistore.cpp(946): warning C4101: 'e': unreferenced local variable
```
Clang doesn't complain, but the code is just as clear without the 'e' so best to remove.
Reviewed By: vener91
Differential Revision: D17631747
fbshipit-source-id: 0190a48e640311b40c9d1b988b0c07cfbdcfd7e5
Summary:
This can quite easily happen if you manually edit it and
aren't careful. The least we can do is tell the user about it,
because it be a bit surprising otherwise.
Reviewed By: jknoxville
Differential Revision: D17626760
fbshipit-source-id: 8c7d64b041fa4b97ce2753116800d0e855442dd9
Summary: Introduces basic KaiOSDevice class. Since kaios phones support adb, it is inherited from AndroidDevice
Reviewed By: jknoxville
Differential Revision: D17608605
fbshipit-source-id: 6b2c5834a1f5862b864c8e76202d0d401e58cbcc
Summary:
The build-release script was using different logic to construct the local url, than the lookup file.
Changed so they both use the same function.
And unit tests added.
Reviewed By: passy
Differential Revision: D17602476
fbshipit-source-id: 6aaedd58eafb2cc59adcdc0ebb4dd329bf99c33a
Summary:
I noticed this didn't have the node prefix so isn't run during `yarn test`.
Now it runs and passes :)
Also checked `ls **/__tests__/*.js` for any similar files and found none.
Reviewed By: passy
Differential Revision: D17601931
fbshipit-source-id: cf45a0ba578d5d0000ba1d25ae4fb26a4f7fc7af
Summary:
**Highlights**
- Android: Leakcanary is no longer part of the core distribution but a separate artifact: `com.facebook.flipper:flipper-leakcanary-plugin`.
Reviewed By: priteshrnandgaonkar
Differential Revision: D17601074
fbshipit-source-id: 862fc44d45b4ddc95059deb3959476af162b1cb0
Summary:
In the previous implementation plugins were downloaded from npm, but dependencies weren't. This diff uses the `live-plugin-manager` which does mostly what we want. It install a package from NPM with all its dependencies.
live-plugin-manager puts the plugin and its dependencies in the same folder. We expect the plugins to be in `node_modules`. For this reason, we are installing the plugin into `$pluginName/node_modules` and move the plugin after the installation out of the `node_modules` folder.
* Fixed plugin loading path for thirdparty plugins.
* Disabled hot reloading for plugins in the flipper folder to prevent reloads when moving around files and installing dependencies here.
* an empty `.watchmanconfig` is created, because metro requires it
* tsx files are added to the list of supported extensions for metro
Reviewed By: passy
Differential Revision: D17570413
fbshipit-source-id: ecbedc60841b36188fec9c83da41ef1f27e5e155
Summary:
Background plugins are initialised when flipper connects.
But there's no isolation, so if any fail to initialize, then we don't carry on initializing the rest.
This fixes that by skipping failed ones only.
Reviewed By: passy
Differential Revision: D17600854
fbshipit-source-id: 2ef04cbcecda78ca448c2f4d56639ba63792e2f7
Summary: This diff sets up Flipper to attach flipper trace to the support form. This diff adds a property named `exportResult` in the redux store. This will hold the export url or the path of the export, depending on the type of the flipper export. Once the exportResult is populated, we listen for this change and update the button style and fill the comment box.
Reviewed By: passy
Differential Revision: D17478491
fbshipit-source-id: 10dd5e130a9e3df5f41afde42b92b08959d9ed9e
Summary: Just updating the apparently copy-pasted comment about the `options` prop.
Reviewed By: passy
Differential Revision: D17567256
fbshipit-source-id: ed4ff93ad42ef8bdcadb5371fe11ae90dba47ca3
Summary: 0.8.0 is required for compatibility of our sample app with new fbjni.
Reviewed By: jknoxville
Differential Revision: D17547812
fbshipit-source-id: 5ad98fe5629cd63be8a253c881e20e8df4d0df74
Summary:
The test is failing right now because D14932994 changed the layout manipulation.
Disable the snapshot test for now and will be re-enabled in D17548543
Reviewed By: jknoxville
Differential Revision: D17549122
fbshipit-source-id: 8bf7a89594206e32cece150c8057ee03d190d2e5
Summary: Fix for p-map error at startup and `fbjni` dependency on Android.
Reviewed By: danielbuechele
Differential Revision: D17528600
fbshipit-source-id: db0fd2e99bd35645ceef63500312b3ad16c04d57
Summary:
This is now published to Maven Central and doesn't require a
separate repository.
Pull Request resolved: https://github.com/facebook/flipper/pull/557
Test Plan: CI
Reviewed By: danielbuechele
Differential Revision: D17526448
Pulled By: passy
fbshipit-source-id: 169b5bc5f6568d40697e5e48a9873f8a64bd5e00
Summary:
Putting this diff up now so we don't forget to land this once
the artifacts are released.
Reviewed By: danielbuechele
Differential Revision: D17480535
fbshipit-source-id: fcf1d2cf34581849bf50e606afcfcebc01cf45a2
Summary:
# Highlights
- Android: Separate artifacts for the Litho, Fresco and Network plugins.
This does not yet include updates to the docs as the publishing process requires manual approval by Bintray first.
Reviewed By: danielbuechele
Differential Revision: D17480406
fbshipit-source-id: 92cd54e708bc1718e40e9ea95ca62f8c73b11fdc
Summary: Change flipper from using the dodgy webview check that requires auth, to using the interngraph api for eligibility checking.
Reviewed By: passy
Differential Revision: D17498724
fbshipit-source-id: b81fd8b7b0bd36a7fcf73ba05d9885b61e420c61
Summary:
Here I add functionality to Wilde that allows navigation to internal deeplinks via Flipper. I beleive this was once a feature by allowing access to non whitelisted URL's but this has since been removed.
The Flipper plugin can now receive a navigate_to command which then emits a url over the navigateTo socket. This is picked up by the FBNavigationFlipperLogger plugin where it gets an instance of the NavigationCoordinator and opens the url.
Reviewed By: kolinkrewinkel
Differential Revision: D17282530
fbshipit-source-id: 0ba29aeac2a32d5464e8fa1dfa4e53af7cf94159
Summary:
After the '(Outdated SDK)' addition to apps when they need to be updated, the uninitilaized clients weren't matching up with the fully initialized ones, so instead of being replaced by the full client in the side bar, they sit there forever looking like they are loading.
This applies the same name change to both fully and non-initialized clients so they always match up.
Reviewed By: passy
Differential Revision: D17501718
fbshipit-source-id: 6f2090b717a17c16c2cff37701e184363c82d36f
Summary: Android Studio asked me to.
Reviewed By: danielbuechele
Differential Revision: D17501199
fbshipit-source-id: 4e57fad00c2b92ff04909d21474f3869d9adedc1
Summary:
In response to https://github.com/facebook/flipper/issues/553
This server is just serving the local assets to the electron instance, when you are running flipper from source (`yarn start`). It's not used in production releases.
I don't think there's a need to encrypt this traffic - it's analogous to running a local web server while you are developing it, however I don't see a reason not to restrict it to localhost.
Reviewed By: danielbuechele
Differential Revision: D17500039
fbshipit-source-id: 5b9df3937d71dc542cfa900da8c9e7f285a0e6ac
Summary: This diff adds an initial support to prefill the app information and the revision information. This diff also copies the workplace url in the clipboard.
Reviewed By: passy
Differential Revision: D16990925
fbshipit-source-id: 4f354e52de5fea07c2ea36336761d6963c27ef66
Summary:
I missed these. :(
Open source CI is unhappy about this - for good reasons.
Reviewed By: jknoxville
Differential Revision: D17500071
fbshipit-source-id: 96106f660dee59985c51e2635321ab4ad00a795a
Summary:
This is useful for system apps. The files are owned by root, but they need to be readable by the app. There's nothing secret in these files, so it's not a problem.
This doesn't address all issues with system apps, e.g. https://github.com/facebook/flipper/issues/536 but does go some way towards it.
I was able to get a system app to connect successfully, but there may be different states that they can be in, so I don't think it's a fix all.
Reviewed By: passy
Differential Revision: D17499438
fbshipit-source-id: ab82583b5d607f75ff4578ab9ac2baf9d74241f8
Summary:
Setting up the necessary metadata to publish the separate plugins
to Maven/Bintray.
Reviewed By: danielbuechele
Differential Revision: D17480263
fbshipit-source-id: 1772cee5b3744ce52fc6e2510a27cb7f500e72bf
Summary:
Breaking Litho/Sections off. Doesn't really make sense to have
two deps for this especially since they're pretty tightly coupled.
This makes our core already quite slim.
Reviewed By: jknoxville
Differential Revision: D17420118
fbshipit-source-id: 9a03911f4af6410745b9aefd0e6a75bdf106660f
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/548
First project to pull out of the "fat distribution" we currently have.
Still needs setup for Maven and registration in Bintray.
Reviewed By: jknoxville
Differential Revision: D17395660
fbshipit-source-id: 6244495a2e25d705dd930ef87c7e5e1f038eb921
