2e073bb663b4307b7ade8c12bc44314e7b908688
4881 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
dependabot[bot]
|
2e073bb663 |
Bump anyhow from 1.0.38 to 1.0.39 in /packer (#2086)
Summary: Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.38 to 1.0.39. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/anyhow/releases">anyhow's releases</a>.</em></p> <blockquote> <h2>1.0.39</h2> <ul> <li> <p>Add an opt-in implementation of <a href="https://docs.rs/anyhow/1.0.39/anyhow/struct.Error.html#method.backtrace"><code>Error::backtrace</code></a> on stable compilers based on the <code>backtrace</code> crate (<a href="https://github-redirect.dependabot.com/dtolnay/anyhow/issues/143">https://github.com/facebook/flipper/issues/143</a>)</p> <pre lang="toml"><code>[dependencies] anyhow = { version = "1.0", features = ["backtrace"] } </code></pre> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
aba15f8475 |
Bump dokka-gradle-plugin from 1.4.20 to 1.4.30 (#2089)
Summary: Bumps [dokka-gradle-plugin](https://github.com/Kotlin/dokka) from 1.4.20 to 1.4.30. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Kotlin/dokka/releases">dokka-gradle-plugin's releases</a>.</em></p> <blockquote> <h2>1.4.30 Alpha</h2> <p>In this release we focused on improving multi-module experience that would allow links, search and navigation to be rendered for the whole project rather than independent modules. We have also updated the compiler to 1.4.30 and introduced the versioning plugin for the multi module, that lets users generate documentation for each version incrementally and switch between them on the main page.</p> <h2>Breaking changes</h2> <ul> <li>Dokka multi module no longer uses generic <code>dokka${format}</code> task but rather <code>dokka${format}Partial</code> where <code>format</code> is the desired output format like <code>html</code> or <code>gfm</code></li> </ul> <h2>Improvements and bug fixes</h2> <ul> <li>JvmName support <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1675">https://github.com/facebook/flipper/issues/1675</a></li> <li>Use Maven directly to download additional dependencies <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1644">https://github.com/facebook/flipper/issues/1644</a> thanks <a href="https://github.com/adangel"><code>@adangel</code></a></li> <li>Fix docs on DProperty <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1671">https://github.com/facebook/flipper/issues/1671</a></li> <li>Refactor ContentTable builder and fix GFM table rendering <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1682">https://github.com/facebook/flipper/issues/1682</a></li> <li>Versioning <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1654">https://github.com/facebook/flipper/issues/1654</a></li> <li>Footer customisation <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1691">https://github.com/facebook/flipper/issues/1691</a></li> <li>Resolve Trove issue <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1715">https://github.com/facebook/flipper/issues/1715</a></li> <li>Fix incorrect DRI conversion in KotlinAsJava modes for nested definitions <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1701">https://github.com/facebook/flipper/issues/1701</a></li> <li>JvmOverloads (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1712">https://github.com/facebook/flipper/issues/1712</a>) and add detection of JvmSynthetic (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1718">https://github.com/facebook/flipper/issues/1718</a>) thanks <a href="https://github.com/bishiboosh"><code>@bishiboosh</code></a></li> <li>Annotations for parameters <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1710">https://github.com/facebook/flipper/issues/1710</a></li> <li>Fix links to method parameters from documentation <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1713">https://github.com/facebook/flipper/issues/1713</a></li> <li>Fix displaying default Java visibility <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1738">https://github.com/facebook/flipper/issues/1738</a></li> <li>Add legacy KotlinWebsite format to recognized link formats <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1750">https://github.com/facebook/flipper/issues/1750</a></li> <li>Fix parameters in CLI and bump kotlinx.cli <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1755">https://github.com/facebook/flipper/issues/1755</a></li> <li>Suppress tag support <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1742">https://github.com/facebook/flipper/issues/1742</a></li> <li>Add ability to suppress obvious functions like equals, toString <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1758">https://github.com/facebook/flipper/issues/1758</a></li> <li>Make Gradle plugin use <code>api</code> instead of <code>implementation</code> for dokka-core <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1771">https://github.com/facebook/flipper/issues/1771</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
33dbd5912e |
Bump relative-deps from 1.0.6 to 1.0.7 in /react-native/ReactNativeFlipperExample (#2092)
Summary: Bumps [relative-deps](https://github.com/mweststrate/relative-deps) from 1.0.6 to 1.0.7. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/mweststrate/relative-deps/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2092 Reviewed By: passy Differential Revision: D27326632 Pulled By: mweststrate fbshipit-source-id: 628614ac5a4b5fee8eb4470995c6449c35629836 |
||
Michel Weststrate
|
8dadf28125 |
Fix layout regression in sidebar
Summary: D27233899 (
|
||
Bartosz Kaszubowski
|
40e6cdebb1 |
improve docs code blocks highlighting (#2049)
Summary: This PR adds missing Objective-C entry to the Docusaurus config, fixes Objective-C code blocks label and adds or replaces several code block labels to improve the currently highlighted blocks. Prism in Docusaurus by default also includes syntax highlight for `jsx` and `tsx`, which improves the nodes and props highlight, so I have used those syntaxes in few places too. I have also fixed one typo that I have spotted and my IDE made a cleanup of whitespaces in edited files. ## Changelog * [website] improve docs code blocks highlighting Pull Request resolved: https://github.com/facebook/flipper/pull/2049 Test Plan: The changes have been tested running Flipper website on `localhost`. ## Preview <img width="650" alt="Screenshot 2021-03-12 150934" src="https://user-images.githubusercontent.com/719641/110951135-fff20d00-8344-11eb-96db-1bdc82c8d5ea.png"> <img width="649" alt="Screenshot 2021-03-12 151022" src="https://user-images.githubusercontent.com/719641/110951268-2ca62480-8345-11eb-9d3b-1a48f1267776.png"> Reviewed By: priteshrnandgaonkar Differential Revision: D27336599 Pulled By: passy fbshipit-source-id: c2dfb3d8cad4675da0f5e1270cada1e56a0175c0 |
||
Pascal Hartig
|
e4a814502a |
Mass bump deps
Summary: Bumping everything that's just a patch version behind or safe-looking minor change. Just hoping to get ahead of dependabot's next run. Reviewed By: fabiomassimo Differential Revision: D27367567 fbshipit-source-id: 1bf8bad02e5a9f07f5982466254f9906581230cf |
||
|
dependabot[bot]
|
d5089b9f01 |
Bump com.github.ben-manes.versions from 0.28.0 to 0.38.0 (#2037)
Summary: Bumps com.github.ben-manes.versions from 0.28.0 to 0.38.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2037 Reviewed By: passy Differential Revision: D27326600 Pulled By: mweststrate fbshipit-source-id: a2697e74fb00dcfc4cbf9917f46e48b4cf8bf879 |
||
generatedunixname89002005306973
|
f12fd3314e |
Flipper Snapshot Bump: v0.82.2-SNAPSHOT
Summary: Releasing snapshot version 0.82.2-SNAPSHOT Reviewed By: passy Differential Revision: D27360491 fbshipit-source-id: 189d3c3f985f463b4c9f084acc8c0ea314e7d39e |
||
|
generatedunixname89002005306973
|
979c49b18d |
Flipper Release: v0.82.1
Summary: Releasing version 0.82.1 Reviewed By: passy Differential Revision: D27360493 fbshipit-source-id: 683605461956d39fdc20560d3a045fd42325e5fb |
||
|
Pascal Hartig
|
276aa682e3 |
Update xmldom for RN apps (security fix)
Summary: Same security vuln. Need to hard-code for now as this is deep down in the dependency tree for an RN dep called `xcode`. Reviewed By: mweststrate Differential Revision: D27338548 fbshipit-source-id: b88dcf48471739ebb7762f49589548dae62433be |
||
|
Pascal Hartig
|
00442cff4a |
Update xmldom (security fix)
Summary: Fixes https://github.com/facebook/flipper/security/dependabot/desktop/yarn.lock/xmldom/open. This is pulled in via electron-builder. Reviewed By: jknoxville Differential Revision: D27338307 fbshipit-source-id: e57cb0123289bb53d1f1d9e5957485fb7f65488a |
||
|
Pascal Hartig
|
b80ab0188b |
Update is-svg (security fix)
Summary: Fixes https://github.com/facebook/flipper/security/dependabot/website/yarn.lock/is-svg/open Reviewed By: jknoxville Differential Revision: D27337757 fbshipit-source-id: 9f547b6fa693b8164c66ccd1e4550a047b634cbb |
||
|
Pascal Hartig
|
cf4d8d4b1a |
Bump ssri (security fix)
Summary: Fixes https://github.com/facebook/flipper/security/dependabot/website/yarn.lock/ssri/open Reviewed By: jknoxville Differential Revision: D27337656 fbshipit-source-id: e17e7da0682d6ee9daaff988f407f88c1f83b4e0 |
||
|
Pascal Hartig
|
2f92ce9781 |
Update deps
Summary: Cleaning up the `resolutions` before going through the next batch of vulns. Reviewed By: jknoxville, mweststrate Differential Revision: D27337444 fbshipit-source-id: 5f042b200ac7a6f50efc7faf3c31770c263e401b |
||
Pascal Hartig
|
a0a28c2e21 |
Fix ts-node for Windows (#2101)
Summary: Somehow referring to the parent directory doesn't work on Windows. Please don't ask me why. Given that we run a script from outside the package doing it on the top-level seems more consistent anyway. Pull Request resolved: https://github.com/facebook/flipper/pull/2101 Test Plan: Yarn on Windows succeeds: https://github.com/facebook/flipper/pull/2101/checks?check_run_id=2195613718 Reviewed By: fabiomassimo Differential Revision: D27335250 Pulled By: passy fbshipit-source-id: aaccdb3f7e78ca264b371a7723c9bad065919d45 |
||
Pritesh Nandgaonkar
|
790f23301e |
Refactor Layout Plugin
Summary: This diff moves the iOS descriptors and other layout helpers into its own buck target. Earlier everything was part of the FlipperKitLayoutPlugin target. When kcui, tried to add macos descriptors, we realised that FlipperKitLayoutPlugin doesn't have macos platform in it and thus he had to put #if TARGET_OS_SIMULATOR check in iOS descriptors and at some other places. In order to make the integration easier I decided to split the Layout Plugin in following way. ``` FlipperKitLayoutPlugin -> FlipperKitLayoutIOSDescriptors (platform set as IOS) -> FlipperKitLayoutHelpers (used in iOS Descriptors and usefule for Macos too) -> FlipperKitLayoutMacOSDescriptors(coming soon by kcui)(platform set as MacOS) ``` Reviewed By: kcui Differential Revision: D27127587 fbshipit-source-id: f108ef81914297e93c886fe53dabf0a4bf11ebc1 |
||
|
Pascal Hartig
|
8c85da5bc8 |
Bump deps
Summary: Just trying to get ahead of dependabot and bump some easy dependencies all at once. Reviewed By: fabiomassimo Differential Revision: D27326687 fbshipit-source-id: 0c724c8e3a688aa9777945fcd46061284fd77969 |
||
|
dependabot[bot]
|
5f082d9267 |
Bump react-player from 1.15.3 to 2.9.0 in /desktop (#2015)
Summary: Bumps [react-player](https://github.com/CookPete/react-player) from 1.15.3 to 2.9.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/cookpete/react-player/blob/master/CHANGELOG.md">react-player's changelog</a>.</em></p> <blockquote> <h4><a href="https://github.com/cookpete/react-player/compare/v2.8.2...v2.9.0">v2.9.0</a></h4> <ul> <li>Adds previewTabIndex property to light mode <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1169"><code>[https://github.com/facebook/flipper/issues/1169](https://github.com/CookPete/react-player/issues/1169)</code></a></li> <li>Update YouTube URL pattern (<a href="https://github-redirect.dependabot.com/CookPete/react-player/issues/1170">https://github.com/facebook/flipper/issues/1170</a>) <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1171"><code>[https://github.com/facebook/flipper/issues/1171](https://github.com/CookPete/react-player/issues/1171)</code></a></li> <li>Support Kaltura's HTML5 player <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1082"><code>[https://github.com/facebook/flipper/issues/1082](https://github.com/CookPete/react-player/issues/1082)</code></a></li> <li>Fix suspense check for nextjs <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1165"><code>[https://github.com/facebook/flipper/issues/1165](https://github.com/CookPete/react-player/issues/1165)</code></a></li> <li>Add kaltura player types <a href=" |
||
|
Michel Weststrate
|
32447c9026 |
Fix failing build by not propagating deployment target to deps (#2103)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/2103 Local builds break if the deploy target of deps isn't new enough. It seems that the project podfile is not respected in this regard, as reported here: https://stackoverflow.com/a/37289688/1983583. Will see if there is a better way to fix this. Reviewed By: jknoxville Differential Revision: D27328025 fbshipit-source-id: 6c5ac2dc88c3dd90dd84ce691a4f8e42188f96c2 |
||
|
generatedunixname89002005306973
|
49d763ad5a |
Flipper Snapshot Bump: v0.82.1-SNAPSHOT
Summary: Releasing snapshot version 0.82.1-SNAPSHOT Reviewed By: mweststrate Differential Revision: D27328584 fbshipit-source-id: ec58247c21e568496d4fb7f79ebb3198081003cd |
||
|
generatedunixname89002005306973
|
9bccaf3951 |
Flipper Release: v0.82.0
Summary: Releasing version 0.82.0 Reviewed By: mweststrate Differential Revision: D27328585 fbshipit-source-id: 720bc154078611295664a34a567299a94a790711 |
||
|
Michel Weststrate
|
740fbe57fd |
Fix release build issue
Summary:
D24358369 (
|
||
|
dependabot[bot]
|
bfde7c4d24 |
Bump eslint-plugin-flowtype from 5.3.1 to 5.4.0 in /flipper-js-client-sdk (#2052)
Summary: Bumps [eslint-plugin-flowtype](https://github.com/gajus/eslint-plugin-flowtype) from 5.3.1 to 5.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/gajus/eslint-plugin-flowtype/releases">eslint-plugin-flowtype's releases</a>.</em></p> <blockquote> <h2>v5.4.0</h2> <h1><a href="https://github.com/gajus/eslint-plugin-flowtype/compare/v5.3.1...v5.4.0">5.4.0</a> (2021-03-14)</h1> <h3>Features</h3> <ul> <li>migrate a new rule 'no-internal-flow-type' (<a href="https://github.com/gajus/eslint-plugin-flowtype/issues/469">https://github.com/facebook/flipper/issues/469</a>) (<a href=" |
||
|
Michel Weststrate
|
f095a00c78 |
Fix Flipper crashing when decoding partial encoded requests
Summary:
Changelog: Fixed an issue where Flipper would crash when decoding large partial requests.
The current processing of partial requests assumes that the proviced base64 string is always an utf-8 string, which is incorrect as it might contain binary data as well. This causes `atob` build in to throw errors when trying to decode binary base64 strings with the following exception:
{F538782963}
However, what is worse, if those strings were larger than ~2 mb, it would completely crash Electron rather than on the JS level, with reports like:
```
Crashed Thread: 0 CrRendererMain Dispatch queue: com.apple.main-thread
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: EXC_I386_GPFLT
Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [85268]
Thread 0 Crashed:: CrRendererMain Dispatch queue: com.apple.main-thread
0 com.github.Electron.framework 0x000000011155b16f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 22324575
1 com.github.Electron.framework 0x000000011155e811 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 22338561
2 com.github.Electron.framework 0x00000001117e2e62 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 24978002
3 com.github.Electron.framework 0x000000010fa32660 v8::internal::ClassScope::ResolvePrivateNamesPartially() + 14944
4 com.github.Electron.framework 0x000000010fa322b5 v8::internal::ClassScope::ResolvePrivateNamesPartially() + 14005
5 com.github.Electron.framework 0x000000010fa31933 v8::internal::ClassScope::ResolvePrivateNamesPartially() + 11571
6 com.github.Electron.framework 0x000000011007ef58 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 451400
```
Reproduced this JS issue by lowering the `MAX_BODY_SIZE_IN_BYTES` in `NetworkFlipperPlugin.java` to 10KB, which causes all requests to be processed as partials.
Reproducing the the Electron crash is a lot harder, as it requires a surface that makes large, binary requests (more than a few mb), that is still intercepted by the Network layer. The best example I could find is sending large pictures or videos through a messenger for android chat. In that case it is still hard to produce due to caching though.
Fun fact, you can crash your own flipper and get the above crash by running this command:
`btoa(require("fs").readFileSync("/Users/mweststrate/Desktop/Screen Recording 2021-03-24 at 16.08.27 crop.mov", "binary"))`, where the provided file must be a few mb's large (this one is 10).
A result of fixing this issue, is that images that were send as partials can now be correctly previewed in the Network plugin again.
Reviewed By: jknoxville
Differential Revision: D27302961
fbshipit-source-id: 1ac86840f7268062bb59c789f3904537df3c51fa
|
||
|
dependabot[bot]
|
2622c084df |
Bump eslint from 7.21.0 to 7.22.0 in /flipper-js-client-sdk (#2054)
Summary: Bumps [eslint](https://github.com/eslint/eslint) from 7.21.0 to 7.22.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eslint/eslint/releases">eslint's releases</a>.</em></p> <blockquote> <h2>v7.22.0</h2> <ul> <li><a href=" |
||
|
dependabot[bot]
|
d575f2d388 |
Bump @types/express from 4.17.8 to 4.17.11 in /desktop (#2065)
Summary: Bumps [types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.8 to 4.17.11. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2065 Reviewed By: passy Differential Revision: D27230321 Pulled By: priteshrnandgaonkar fbshipit-source-id: cbdad9eb0b58b9c232b798d5d90a123a7c3ebe71 |
||
|
Pritesh Nandgaonkar
|
62863c8fe5 |
Change the logic to check the cert exchange is needed or not
Summary: It has been seen [here](https://fb.workplace.com/groups/flippersupport/permalink/1094276434386347/) that the user's app sandbox can be in a state where it might not have the device id information, but other app certificates. This causes the issue of "Timed out waiting for unknown device". We get the deviceid from flipper into app's sandbox when cert exchange happens. So if we don't have the device id information, we can again redo the cert exchange to get the sandbox in a state where flipper connects. Thus I updated the logic of `hasRequiredFiles` which checks the required files for cert exchange. Reviewed By: mweststrate Differential Revision: D27265693 fbshipit-source-id: ccf311f4728837ee9385c95c38f94c9c93380feb |
||
|
Pritesh Nandgaonkar
|
d2fc10074f |
Bump react-native in react-native-flipper
Summary: This diff bumps react-native dep in react-native-flipper This diff retries what D27230334 was trying to do. Looked like in the prev diff the yarn.lock had unwanted changes. Reviewed By: passy Differential Revision: D27297848 fbshipit-source-id: aecb4708fabb5515b9949a3eb59fffe05d49487f |
||
|
Pascal Hartig
|
21cfa6921b |
Rebuild bump.lnx as static binary
Summary: The dynamic verison ran on my devserver so I thought it was fine but turns out our Lego host doesn't have the glibc version it linked against: https://www.internalfb.com/intern/chronos/job?jobid=27021599014479361&smc=chronos_gp_admin_client Reviewed By: fabiomassimo Differential Revision: D27290193 fbshipit-source-id: 94f8048d6aa42d00401b433a622fe6af29126fd3 |
||
Hilal Alsibai
|
949545a2a7 |
Don't skip the first theme data retrieval
Summary: Was early returning on the first attempt to load theme data, this was left over from when the the theme feature was temporarily disabled. Reviewed By: passy Differential Revision: D27284040 fbshipit-source-id: bb641fbe4cd9c0ea6012e89dbda67e5dd10d59bd |
||
|
Pascal Hartig
|
0a7f37d859 |
v0.3.0
Summary: Just bumpin'. Reviewed By: fabiomassimo Differential Revision: D27194182 fbshipit-source-id: 983cd09aab8087a70d133cd56c83b39a63890366 |
||
|
Pascal Hartig
|
8b97ce2954 |
Add integration test script
Summary: Following priteshrnandgaonkar's advice of having something a little more automated for testing the entire flow. This builds for each platform and runs a little smoke test, ensuring that the right files are in each archive. Reviewed By: priteshrnandgaonkar Differential Revision: D27229200 fbshipit-source-id: d83881a948ae001ce2379e9db5e21b777a5fe922 |
||
|
Pascal Hartig
|
0a9b7147c7 |
Update README
Reviewed By: mweststrate Differential Revision: D27229201 fbshipit-source-id: faeb4528283a21be7ba51eb4a8e708a901307233 |
||
|
Pascal Hartig
|
fa97809178 |
Implement glob packing mode
Summary: Best seen by looking at the packfile. This makes upgrades and changes to the file format a lot more robust. Reviewed By: priteshrnandgaonkar Differential Revision: D27194152 fbshipit-source-id: a722adb3a59d73b7530287f7abd84ed865a35fa7 |
||
|
Pascal Hartig
|
ca55e68c89 |
Set up infra for different packing mode
Summary: Electron 12 broke packing again because one file was renamed. I'm now setting up a separate mode for using globs and ignores to create artifact bundles. This will work like a reverse gitignore file. However, to keep the logic simple, I'll keep the old mode for MacOS where the folder structure lends itself to comprehensive, exact lists. **This doesn't actually change anything just yet apart from the "packfile" format. The next diff will add the new packing mode. Feedback is always welcome but there's no need for super close scrutiny.** Reviewed By: mweststrate Differential Revision: D27191506 fbshipit-source-id: 663cef8b93eef6c2dbb56ef66de51ea9551412dd |
||
|
Pascal Hartig
|
94e85b54c8 |
Update Linux binary
Summary: Per title. Reviewed By: mweststrate Differential Revision: D27266704 fbshipit-source-id: cc34c6d12b6db29650b7f45ed1594c0794d75e56 |
||
|
Pascal Hartig
|
9e30c60750 |
Update Mac binary
Summary: Per title. Reviewed By: mweststrate Differential Revision: D27266705 fbshipit-source-id: 3d279fe9fd6b9daae5126cbb1179ec8d97ef5e3f |
||
|
Michel Weststrate
|
c7c75a082f |
Fix failing perf test
Summary: made a typescript booboo, and broke the test thereby. Also reduced the test set to avoid OOMs Reviewed By: passy Differential Revision: D27261187 fbshipit-source-id: bcb61bf95419421d9c33e7e0a944717797f96dfe |
||
|
Michel Weststrate
|
ba8232f30d |
Move DetailSidebar to flipper-plugin
Summary: This moves `<DetailSidebar>` component to `flipper-plugin` and documents it. No semantic changes. Reviewed By: passy Differential Revision: D27234575 fbshipit-source-id: 74640602d718f84ad999f5dac0420089796ed7fb |
||
|
Michel Weststrate
|
dd1f2fdeaa |
Move Sidebar to flipper-plugin
Summary: This diff deprecates the Sidebar concept, and copies the implementation to Sandy (tried moving first, but since existing plugins use the Sidebar in non-flex (Layout) contexts, that the layout of several plugins, so rather deprecated the old implementation. Instead of exposing `Sidebar` explicitly, one can now put the `resizable` flag on a Layout.Top/Left/Bottom/Right, which makes building layouts even simpler, see demo. The gutter logic was moved to the new implementation, since that was only used by the Sandy chrome anyway. Changelog: Layout.Top / Left / Bottom / Right now support a resizable option Reviewed By: passy Differential Revision: D27233899 fbshipit-source-id: fbbdeb2ebf30d49d0837705a00ea86bb07fc2ba2 |
||
Ranjith
|
0bf786544a |
Update leak-canary-2-plugin.mdx (#2085)
Summary: Update the LeakCanary 2 plugin version in LeakCanary 2 plugin doc While adding the version as in the doc, the import statements didn't work. Upon checking the maven repo, I found out that the latest version is `0.81.0`. Updating to the latest version helps ## Changelog Updated LeakCanary 2 plugin docs to include the latest plugin version Pull Request resolved: https://github.com/facebook/flipper/pull/2085 Test Plan: Not necessary Reviewed By: mweststrate Differential Revision: D27265598 Pulled By: passy fbshipit-source-id: 2f82689c1f075c2f9cff8bae2831c9780a3db697 |
||
|
Pascal Hartig
|
aa83d2e620 |
Include leakcanary2 path
Summary: Currently relying on PRs to bump this: https://github.com/facebook/flipper/pull/2085/files Will need to rebuild binaries afterwards. Reviewed By: mweststrate Differential Revision: D27265679 fbshipit-source-id: 227a1350044573f37f477727e059be845e5369e0 |
||
|
dependabot[bot]
|
062882bb77 |
Bump gradle from 4.1.2 to 4.1.3 (#2090)
Summary: Bumps gradle from 4.1.2 to 4.1.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2090 Reviewed By: mweststrate Differential Revision: D27265541 Pulled By: passy fbshipit-source-id: ff3d914cc6f360364811e0d1402b02ccc89c1a8b |
||
|
Pascal Hartig
|
55341dfc59 |
Fix React Native build (#2100)
Summary: Currently failing because the 0.64.x build requires Node >= 0.12 Pull Request resolved: https://github.com/facebook/flipper/pull/2100 Test Plan: CI Reviewed By: mweststrate Differential Revision: D27265576 Pulled By: passy fbshipit-source-id: d7ee0cac8bab1dc90a1b453eef6a7be30177052e |
||
|
dependabot[bot]
|
256b025630 |
Bump rsocket-flowable from 0.0.23 to 0.0.25 in /desktop (#2069)
Summary: Bumps [rsocket-flowable](https://github.com/rsocket/rsocket-js) from 0.0.23 to 0.0.25. <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
453499568d |
Bump @types/react-transition-group from 4.4.0 to 4.4.1 in /desktop (#2066)
Summary: Bumps [types/react-transition-group](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-transition-group) from 4.4.0 to 4.4.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-transition-group">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2066 Reviewed By: passy Differential Revision: D27230132 Pulled By: priteshrnandgaonkar fbshipit-source-id: 21b2276f21b63bd98f3169559590985de795dc64 |
||
|
Pascal Hartig
|
d19eeb2a53 |
Demote android emulator "errors"
Summary: Really not errors at all. I'm getting warnings here about my Vulkan support not working. That shouldn't be logged as a Flipper error. Reviewed By: mweststrate Differential Revision: D27260607 fbshipit-source-id: 6f9d2ab0da3fe37bb5c8c185ad627ef0d581e5d5 |
||
|
dependabot[bot]
|
df71f14c77 |
Bump electron-builder from 22.9.1 to 22.10.5 in /desktop (#2068)
Summary: Bumps [electron-builder](https://github.com/electron-userland/electron-builder) from 22.9.1 to 22.10.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/electron-userland/electron-builder/releases">electron-builder's releases</a>.</em></p> <blockquote> <h2>22.10.5</h2> <p>We have a new maintainer — welcome Mike Maietta (<a href="https://github.com/mmaietta"><code>@mmaietta</code></a>)!</p> <p><strong>electron-updater</strong> 4.3.8 contains fix for <a href="https://github.com/electron-userland/electron-builder/issues/5595">#5595</a>. This version is a pre-release.</p> <h3>Bug Fixes</h3> <ul> <li>Look for the Amazon cred header to remove auth header (<a href="https://github.com/electron-userland/electron-builder/issues/5594">#5594</a>) (<a href=" |
||
|
dependabot[bot]
|
6589aee6f1 |
Bump @emotion/styled from 11.0.0 to 11.1.5 in /desktop (#2067)
Summary: Bumps [emotion/styled](https://github.com/emotion-js/emotion) from 11.0.0 to 11.1.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@emotion/styled's releases</code></a>.</em></p> <blockquote> <h2>emotion/styled@11.1.5</h2> <h3>Patch Changes</h3> <ul> <li> <p><a href=" |
||
|
dependabot[bot]
|
fd9b5b562a |
Bump spectron from 11.0.0 to 14.0.0 in /desktop (#2071)
Summary: allow-large-files Bumps [spectron](https://github.com/electron/spectron) from 11.0.0 to 14.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/electron/spectron/releases">spectron's releases</a>.</em></p> <blockquote> <h2>v13.0.0</h2> <p>No release notes provided.</p> <h2>v12.0.0</h2> <p>No release notes provided.</p> <h2>v11.1.0</h2> <p>Upgraded webdriverio to 6.1.20 <a href="https://github.com/electron/spectron/issues/631">https://github.com/facebook/flipper/issues/631</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/electron/spectron/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/2071 Test Plan: Imported from GitHub, without a `Test Plan:` line. yarn test-e2e Test Suite Succeded after running yarn test-e2e Reviewed By: passy Differential Revision: D27230110 Pulled By: priteshrnandgaonkar fbshipit-source-id: d6d2d6c1482fa563b9dde9472467f918496e2cea |
