Summary: It's handy to copy images URI to paste it in other tools
Reviewed By: mweststrate
Differential Revision: D20221861
fbshipit-source-id: 09074b434d5c1277bb83daa7846b885717c5ee8d
Summary:
We use them implicitly right now which causes problems
with upgrades. See https://github.com/facebook/flipper/compare/master...facebook:greenkeeper%2Fpkg-4.4.4
where a patch upgrade removes the dependency and breaks the build.
Glob is used in the new TypeScript-ified plugin building process.
Reviewed By: nikoant
Differential Revision: D20189781
fbshipit-source-id: 3b2af349f64a470e1f3e5a78d69b94d7f28e1332
Summary:
The platform check is a side-effect and shouldn't be in the UI component
itself.
Reviewed By: mweststrate
Differential Revision: D20159799
fbshipit-source-id: c5fa99e0b915a140f10056283671cf5b7368e9c9
Summary: Updated keytar to match electron 8.0.1
Reviewed By: passy
Differential Revision: D20160252
fbshipit-source-id: fee8aaf152c7a95a62f5b9985c3615c99b5ed0d9
Summary:
This diff fixes the broken export which is being made [here](https://fb.workplace.com/groups/graphqlandroid/permalink/3319822971399628/). In the import there is no client and plugin states. The fact that the validation succeeded on submit button click suggests that the app got disconnected between the click on submit button and the initiation of export, thus exporting the store with no plugin data and client.
I have added a validation after exporting the store and before the trace is uploaded.
Also in the support request details page, we assumed that client can't be null, relaxed this assumption as the flipper should still open even the above broken export instead of crashing.
Reviewed By: mweststrate
Differential Revision: D20136295
fbshipit-source-id: f589d01f8ff0ec0b23d53ad5099e11ebbd0930cd
Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.118.0` to `0.119.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [jbrown215](https://www.npmjs.com/~jbrown215)
**License:** MIT
[Find out more about this release](https://github.com/flowtype/flow-bin).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/829
Reviewed By: nikoant
Differential Revision: D20139183
Pulled By: passy
fbshipit-source-id: fca3711e4299e02cc138e370ade8376c374a6f40
Summary: Adds the theme information relating to a Litho component in the layout inspector
Reviewed By: sjkirby
Differential Revision: D20133889
fbshipit-source-id: 93acb745f47c1ff9ce37be35a05b4a6269193a47
Summary:
Make sure that we can pass with the combinations of eslint/tslint
rules.
Reviewed By: nikoant
Differential Revision: D20067199
fbshipit-source-id: 40e208f75f09a1eff584f111fbb9bc1be87dba01
Summary: Remove asan checker, we can use `BuildConfig.IS_ASAN_BUILD` to check whether it's a asan build to instead of invoking a JNI api.
Differential Revision: D20088093
fbshipit-source-id: f26d367430a983fbe7b630919a4131fdf2e2d510
Summary: When running tests locally, some are quite flaky, and there is a lot of error logging noise. This diff doesn't remove all of it, but does reduce it significantly.
Reviewed By: nikoant
Differential Revision: D20034619
fbshipit-source-id: 183f74475b644f803b2f92b1b1301f4d0f6e193a
Summary:
This sets up a basic UI for a bundling command. It checks for the source, creates an output directory if necessary and automatically creates an output name, so it should hopefully be as intuitive as possible.
There are plenty of potential error case that I don't directly handle. That's something we may want to consider in the future.
Reviewed By: nikoant
Differential Revision: D19973889
fbshipit-source-id: 5638ed0e45187c5ad567b9e2559c8befe52c6085
Summary:
## The dependency [uuid](https://github.com/uuidjs/uuid) was updated from `3.4.0` to `7.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [ctavan](https://www.npmjs.com/~ctavan)
**License:** MIT
[Find out more about this release](https://github.com/uuidjs/uuid).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/827
Reviewed By: jknoxville
Differential Revision: D20067749
Pulled By: passy
fbshipit-source-id: 045c94cc1c28f0854680340f56bb35b854a37c51
Summary: The constructor is getting quite a few args now, so to avoid string, string mistakes I'm making sure you pass objects with named params.
Reviewed By: passy, mweststrate
Differential Revision: D20034012
fbshipit-source-id: 4e0d23eeaa9100c6c19d3e36fee62649659ad261
Summary:
Provides some really nice helpers and generators for
multi command CLIs, including test helpers and all
sorts of output niceties. This should make it quite
easy for us to add additional sub-commands for
bundling, publishing and keeping docs for all of it.
Heroku maintains this and provides some excellent
docs, too: https://oclif.io/
My only complaint is that it's class-based but that's
effectively only the way to declare new commands and
enforces a set of required/static properties on it.
Reviewed By: nikoant
Differential Revision: D19970293
fbshipit-source-id: 4228e502198c6fd376854a90ed2f01da29e96bc2
Summary: This will query for and display all of the associated theme information for each of the descriptors.
Reviewed By: passy
Differential Revision: D20008056
fbshipit-source-id: 720d224144b0822528ca8e23cdbec9fe9dd25e6b
Summary:
We don't want to test again against the compiled JS output.
Also, we *do* want to fail if we break the config and don't
actually run any tests.
Reviewed By: nikoant
Differential Revision: D20068114
fbshipit-source-id: c46e5a25fcd155d160f717a9db8f088787913a28
Summary:
## The dependency [uuid](https://github.com/uuidjs/uuid) was updated from `3.4.0` to `7.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [ctavan](https://www.npmjs.com/~ctavan)
**License:** MIT
[Find out more about this release](https://github.com/uuidjs/uuid).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/828
Reviewed By: cekkaewnumchai
Differential Revision: D20067757
Pulled By: passy
fbshipit-source-id: ac9e7f6aaff86e30c320c427323627ac732ddb73
Summary:
== Highlights ==
- Android: Theme information for Application, Activity and View descriptors are now visible in the Layout plugin. (6f4de969fb)
- App Visualiser: When importing an archived device, you can now see and inspect the last screen of the app. (20db85adf4)
== Fixes ==
- Fix `FlipperKit` warnings in XCode. (972277b031)
- Upgrade Folly to v2020.02.17.00 (GH809)
- Several performance improvements, originally caused by unnecessary rerenders.
- Crash reports weren't scrollable. (e1e8bb841c)
- Kill orhpaned instruments processes. (GH819)
Reviewed By: nikoant
Differential Revision: D20067792
fbshipit-source-id: 3f0ebcb03881373fd909f513e5d82e23a5f9f1f1
Summary: Use dev bundling for "yarn start"
Reviewed By: jknoxville
Differential Revision: D20034300
fbshipit-source-id: a46c75074c969f5a4958f498c5c0e15aab808552
Summary: Skip the main process code bundling when nothing changed
Reviewed By: mweststrate
Differential Revision: D20030261
fbshipit-source-id: 78de87377afe7e768627059425c51081239687dd
Summary:
As a first step I've configured bundling for the main process code using Metro. For now I haven't converted anything to ts, just made that possible.
The bundle is just produced into the "static" directory. To avoid too many changes I kept the "static" folder as it is, but probably non-static code should be moved from there.
Also installed modules from "node_modules" for the main process are not bundled to avoid potential issues with node native modules.
Reviewed By: mweststrate
Differential Revision: D19960982
fbshipit-source-id: efbd426254e2b37c913c5f5f75f042c50ccee2f3
Summary:
Tried to upgrade both electron and electron-builder but failed due to Windows binary build stuck.
Upgraded only electron for now. electron-builder will be upgraded separately
Reviewed By: nikoant
Differential Revision: D19877865
fbshipit-source-id: a2282c2f4062e6b470cdcba2e9e693419bfeaec4
Summary:
This workflow is currently building the android app and then trying to upload the mac app (which isn't built) which is failing.
I think it should be uploading the android app instead.
Pull Request resolved: https://github.com/facebook/flipper/pull/820
Reviewed By: passy
Differential Revision: D20035055
Pulled By: jknoxville
fbshipit-source-id: 08367d464a045b47cf1b8b5395fd2151793a23cf
