Commit Graph

8668 Commits

Author SHA1 Message Date
Luke De Feo
22d1bc2552 Allow exploring all events in table view
Summary: This lets you debug when events go off screen

Reviewed By: lblasa

Differential Revision: D48395787

fbshipit-source-id: 51a6eb74fa0f61c34f25e86a6ee40bf5969379ee
2023-08-21 04:24:16 -07:00
Luke De Feo
1bffe8bc6b Improve framework event filters
Reviewed By: lblasa

Differential Revision: D48393422

fbshipit-source-id: 18d92b53bd56c100b6d4bb6adc07ede0b4a46732
2023-08-21 04:24:16 -07:00
Luke De Feo
756a289883 Add button to get to table mode from node level stream
Reviewed By: lblasa

Differential Revision: D48348325

fbshipit-source-id: f54815226dc230aa2d3c2bafdae8edfa829bf3fe
2023-08-21 04:24:16 -07:00
Luke De Feo
4918d21df8 Show framework event metadata documentation in detail view and tree select
Reviewed By: lblasa

Differential Revision: D48348090

fbshipit-source-id: e48547508b78178b278f72ce72fc579c9f015570
2023-08-21 04:24:16 -07:00
Luke De Feo
f5bc03c263 Add framework event node level event filtering
Summary: Lets you filter a nodes events by thread or type

Reviewed By: lblasa

Differential Revision: D48346955

fbshipit-source-id: 455d65ad21c54c5ad26782ac6a446f7ae15a4356
2023-08-21 04:24:16 -07:00
Luke De Feo
3cd6079c24 Change framework event seperator to .
Summary: Its easier this way since this is how they come out of android internally, also a bit nicer to display the full string this way

Reviewed By: lblasa

Differential Revision: D48346954

fbshipit-source-id: 997dd3922159683fcdf4b5f5f288702a5d998dc4
2023-08-21 04:24:16 -07:00
Luke De Feo
7b6aff245a Extract framework event tree select
Summary: we will reuse this

Reviewed By: lblasa

Differential Revision: D48318965

fbshipit-source-id: a5d04481a02e18a2d709f79524aa7449a5b87844
2023-08-21 04:24:16 -07:00
Luke De Feo
d5814ea17c Use bottom panel as detail view for framework events
Summary: Now when you click on an event the bottom bar appears automatically showing you every thing you need

Reviewed By: lblasa

Differential Revision: D48318694

fbshipit-source-id: 6505e439d949941dc0e091b9576d7d1321d8a05f
2023-08-21 04:24:16 -07:00
Luke De Feo
6f6b953c62 Fix warning
Summary: This was complaining about mixing shorthand  and separete css attributes. Just use separate since its clearer

Reviewed By: passy

Differential Revision: D48315864

fbshipit-source-id: e73e76d7fb94b3d7bba36a34d408202bc91933be
2023-08-21 04:24:16 -07:00
Luke De Feo
4912b3f47e Fix bottom panel and make it resizable
Summary: The bottom panel got broken during the virtualisation+ panel refactor, we need to tell the tree how much height is taken by the panel so it can size itself accordingly.

Reviewed By: lblasa

Differential Revision: D48313766

fbshipit-source-id: 849886101eb0869cc068fd0ad6dc1d053233043e
2023-08-21 04:24:16 -07:00
Luke De Feo
2d217575bb improve marker timeline
Summary:
1. removed background hover
2. made can select actually work
3. disable user selection
4. remove decimal points from ms

Reviewed By: lblasa

Differential Revision: D48270181

fbshipit-source-id: 724efedb5cad7f93c80ed5dd7f49efe4c434c324
2023-08-21 04:24:16 -07:00
Luke De Feo
94114eb821 Add tree id
Summary:
Added new tree id to the framework event. Its currently optional.

The tree id is the parent component tree / tree manager this tree belongs to, this is so we can view all tree events at once in the table.

We ony show the context menu item when we have the tree root tag which is set for component tree only at this point. We can add for blok and ios later

Reviewed By: lblasa

Differential Revision: D48268120

fbshipit-source-id: 3dee06309b146a0392ca32fbb5e8231883b8439a
2023-08-21 04:24:16 -07:00
Pascal Hartig
7dad33a626 Fix keytar types
Summary: The linter otherwise wants us to remove `awaits` which are in fact required.

Reviewed By: lblasa

Differential Revision: D48467534

fbshipit-source-id: 355aee4bc22098086600b85edf58c8ed077b8aaf
2023-08-21 04:00:56 -07:00
Pascal Hartig
f6fcc1635f Silence background plugin timeout
Summary:
This isn't actionable and can't be deduplicated due to the device identifier.

Changelog: Don't report errors related to timeouts of background plugins

Reviewed By: lblasa

Differential Revision: D48467028

fbshipit-source-id: 94f32848962d8d3e3b1998a88f6f30a6cf86c4f6
2023-08-21 04:00:56 -07:00
Pascal Hartig
160b05a5bd Bump deps
Summary:
This updates minor and patch level dependencies. Frustratingly, I had to revert a bunch
of changes in that version range that still caused incompatibilities and test failures.

If I find time, I'll dig a bit deeper.

Reviewed By: ivanmisuno

Differential Revision: D48433210

fbshipit-source-id: 9ab12e774c1992d4f22cc1428d34f102ce820b75
2023-08-21 03:03:30 -07:00
Pascal Hartig
22c0eaa5cd Clean up update server
Reviewed By: lblasa

Differential Revision: D48433744

fbshipit-source-id: 749868e00e17af02040a8e2c164631e295deae65
2023-08-21 03:03:30 -07:00
generatedunixname89002005306973
891f9448a0 Flipper Snapshot Bump: v0.212.1-SNAPSHOT
Summary: Releasing snapshot version 0.212.1-SNAPSHOT

Reviewed By: lblasa

Differential Revision: D48473693

fbshipit-source-id: 221bacc609c16c49785b87e8db98b6207b5eeb0c
2023-08-19 03:47:16 -07:00
generatedunixname89002005306973
cc9c26d214 Flipper Release: v0.212.0
Summary: Releasing version 0.212.0

Reviewed By: lblasa

Differential Revision: D48473694

fbshipit-source-id: 751e563523881120795bbfef83616d89dcaa5f45
2023-08-19 03:47:16 -07:00
Lorenzo Blasa
4ff9279a0b Offline troubleshoot when server disconnects
Summary:
If there server disconnects, we used to show a red box message on the lower left section of the screen. It didn't say much other than the server had disconnected.
If you are aware of what the server is, then you may try to manually restart it.

Instead of doing that, a much better experience is to show the no connection troubleshoot with the button to start the server or with instructions on how to achieve this.

Reviewed By: antonk52

Differential Revision: D48467308

fbshipit-source-id: 0ffded95789c7548d9f1e1a9127409e02e72ab8c
2023-08-18 07:59:51 -07:00
Pascal Hartig
c1c586d2c7 Update deps
Summary: `cargo update`

Reviewed By: ivanmisuno

Differential Revision: D48397856

fbshipit-source-id: da8114992c9635b0aac966777d9e77a28dfd9d69
2023-08-17 14:13:18 -07:00
Pascal Hartig
7d23be077d Update deps
Summary: yarn upgrade-interactive --latest

Reviewed By: ivanmisuno

Differential Revision: D48397678

fbshipit-source-id: 0f5e4b494c49113ca94247f4cca5e804c6333901
2023-08-17 14:13:18 -07:00
Lorenzo Blasa
3f37d29b95 Reintroduce timeout and is production check
Summary:
For dev, let's not kill the server.
Also, reintroduce a timeout of 60 seconds before disconnecting.

Reviewed By: antonk52

Differential Revision: D48432317

fbshipit-source-id: bac6f67101e5be481af06a5ea6ccb3b3134c4075
2023-08-17 13:46:08 -07:00
Lorenzo Blasa
ce13ee426f Open file import
Summary: This change only adds the PWA as capable of handling files with the ".flipper" extension.

Reviewed By: aigoncharov

Differential Revision: D48353437

fbshipit-source-id: fd78942ac4dffb7d26d5ca5be826290018465b93
2023-08-17 13:46:08 -07:00
Fúlvio Abrahão de Paula
9728155cbf Consider NSNull object as type=null in ObjectMapper.
Summary: nil objects from sqlite is NSNull object, so we need to consider this case in the ObjectMapper as well.

Differential Revision: D48394360

fbshipit-source-id: 61bcdb03cb4cbf17a2fef000a5a61ac2f2c035dd
2023-08-17 11:19:50 -07:00
Fúlvio Abrahão de Paula
fb47b70d36 Parse NSDictionary in ObjectMapper.
Summary: Some objects returned from sqlite in json blob is a NSDictionary, we need to parse data at this case.

Differential Revision: D48394361

fbshipit-source-id: c977ebdd33c392fca77741cdacdeb0c975e2ca36
2023-08-17 11:19:50 -07:00
Lorenzo Blasa
b45eed0e9a 'Capture' cancel on file import
Summary:
There's no explicit way of knowing if the file selection dialog was dismissed/canceled without a selection.

Instead, subscribe once to the windows focus event, as it will the event will be received when this happens.

Reviewed By: antonk52

Differential Revision: D48434187

fbshipit-source-id: dd20c55885bb3ef6bef423e17a2606d71ede288d
2023-08-17 08:57:55 -07:00
github-actions[bot]
84e0eaa004 Automated: Update Podfile.lock (#5048)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/5048

Reviewed By: ivanmisuno

Differential Revision: D48397521

Pulled By: passy

fbshipit-source-id: 2333aa312f982b2ceff1dd2a2f8dfe9d0e63c893
2023-08-17 08:15:18 -07:00
David Vacca
65603771a9 Refactor all usages of import NetworkingModule.setCustomClientBuilder
Summary:
Refactor all usages of import NetworkingModule.setCustomClientBuilder to use CustomClientBuilder instead of NetworkModule.CustomClientBuilder

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D48280921

fbshipit-source-id: ffa979defb34ecaac9d327eaafee33598ea22b5d
2023-08-15 12:26:12 -07:00
generatedunixname89002005306973
8094370aba Flipper Snapshot Bump: v0.211.2-SNAPSHOT
Summary: Releasing snapshot version 0.211.2-SNAPSHOT

Reviewed By: passy

Differential Revision: D48349387

fbshipit-source-id: 121bf5516809f1b719be130379949de76895d944
2023-08-15 06:56:48 -07:00
generatedunixname89002005306973
7ef7b9a248 Flipper Release: v0.211.1
Summary: Releasing version 0.211.1

Reviewed By: passy

Differential Revision: D48349388

fbshipit-source-id: 7e152acb6009148bfbade2ee282bc681e12b110f
2023-08-15 06:56:48 -07:00
Lorenzo Blasa
007cdfee76 Enable flipper import/export
Summary: These two functions were not enabled for the browser experience.

Reviewed By: antonk52

Differential Revision: D48315991

fbshipit-source-id: 2944a386d9de8a06b043305e7ceb8a6c41e11209
2023-08-14 11:33:06 -07:00
Lorenzo Blasa
ff6f98fc0d Import File implementation
Summary: Implementation was missing for the browser. This provides a default implementation.

Reviewed By: aigoncharov

Differential Revision: D48311198

fbshipit-source-id: fd067600f571234e0fbccfb90853b62f175ff8fb
2023-08-14 11:33:06 -07:00
Fúlvio Abrahão de Paula
2f5f4911e5 Refactor FlipperKitDatabasePlugin to accept multiple database drivers.
Reviewed By: lblasa

Differential Revision: D48316901

fbshipit-source-id: 0eb7b93f53ce115a0a031a58ecef3db963b35f09
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
661ed9eb44 Isolate duplicated code in DatabasesManager.
Reviewed By: lblasa

Differential Revision: D48316900

fbshipit-source-id: 2ae984f0d6f10b9cb843a74f335c77428d2229ef
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
d102ae263c Fix mocks to return correct expected results.
Reviewed By: lblasa

Differential Revision: D48315430

fbshipit-source-id: 3a9210b6c4ce8192ff5489d2616e6a37264309b2
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
d9b34e7880 Return right format for databaseGetTableStructureResponseToDictionary method.
Reviewed By: lblasa

Differential Revision: D48315431

fbshipit-source-id: fc4ca1bc20e691162dfbe61a90a5ab9bf8df2466
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
7ba548d6e7 Implement executeSql command.
Reviewed By: lblasa

Differential Revision: D48310925

fbshipit-source-id: 136b7f09a3a1b886111b6e3cb0e377b73b126e59
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
42fb6f09f7 Implement getTableData command.
Reviewed By: lblasa

Differential Revision: D48267029

fbshipit-source-id: a2ee02d3d0c465c83acd99fd7093e0abb5c7c2de
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
a0510ad1bf Implement getTableInfo command.
Reviewed By: lblasa

Differential Revision: D48266744

fbshipit-source-id: 79f2fd3c4718d6bf7be4a0538ec0d1eb92503eb7
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
453b8f7b96 Implement getTableStructure command.
Reviewed By: lblasa

Differential Revision: D48191484

fbshipit-source-id: 6838590f4e10b4613074e9e9d112a62d4688f739
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
ce85f44a33 Create commands data models and add ObjectMapper.
Reviewed By: lblasa

Differential Revision: D48188172

fbshipit-source-id: 10c99250f993c71976c693a691586385d111a4fd
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
9db2c74632 Implement databaseList command and Add MockDatabaseDriver.
Reviewed By: lblasa

Differential Revision: D48172577

fbshipit-source-id: 10d6301041b3a4b3ab83b19e9afd3eac7ad7004c
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
fea326be79 Implement similar structure we have in Java plugin.
Reviewed By: lblasa

Differential Revision: D48172579

fbshipit-source-id: b2127507b04cdb85f426313e71405a81103e42bd
2023-08-14 11:07:07 -07:00
Fúlvio Abrahão de Paula
3003330067 Create initial databases plugin structure.
Reviewed By: lblasa

Differential Revision: D48172580

fbshipit-source-id: d000329c2fe8ebc12f59e3165861b1e8033ddbbe
2023-08-14 11:07:07 -07:00
David Vacca
76341a0215 Fix NoSuchMethodError when calling FbReactApplicationBaseSonarUtil.startSonarClient
Summary:
This diff is fixing a NoSuchMethodError when calling FbReactApplicationBaseSonarUtil.startSonarClient.

This is causing catalyst Android app to not start.

This was caused by D47468613, which changed the signature of the method

Reviewed By: cortinico

Differential Revision: D48275730

fbshipit-source-id: 4693c299dbd3b6a9ad58a1439bddd9e4bfb8bdf5
2023-08-14 09:54:54 -07:00
Pascal Hartig
29f072fc75 ACTUALLY disable dokka builds (#5005)
Summary:
This should hopefully unblock our Android builds for real this time. I didn't realise that the AGP itself seems to ship with a version of Dokka, so just removing the import didn't actually address the problem we were seeing.

Pull Request resolved: https://github.com/facebook/flipper/pull/5005

Test Plan:
```
./gradlew publishToMavenLocal -PRELEASE_SIGNING_ENABLED=false
```

This now succeeds.

Reviewed By: jknoxville

Differential Revision: D48312784

Pulled By: passy

fbshipit-source-id: f049e089a511726857f544386fe13dcb50fb2971
2023-08-14 06:34:51 -07:00
Lorenzo Blasa
bdbf5794ee Remove [conn] from log
Summary: Not really a connectivity related log, so removed [conn] from it.

Reviewed By: passy

Differential Revision: D48266546

fbshipit-source-id: e384301d6301940366b594b4bc612349cc2264ce
2023-08-11 14:16:21 -07:00
Lorenzo Blasa
9e2615cd80 Better troubleshoot guide to kill existing running instance
Summary: Combine the two used commands as will make things easier for our users.

Reviewed By: passy

Differential Revision: D48266474

fbshipit-source-id: 1ee5c568ff001dc5ba3f11e21b09a2a6ab430ac7
2023-08-11 14:16:21 -07:00
github-actions[bot]
84987b888b Automated: Update Podfile.lock (#5000)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/5000

Reviewed By: lblasa

Differential Revision: D48268231

Pulled By: passy

fbshipit-source-id: 9f28d68aeeca2c921a9298cbfad7c13e261b6900
2023-08-11 12:08:42 -07:00
Andrey Goncharov
359392a44c Match isProduction definitions
Summary:
Match isProduction definition in flipper-common and flipper-server/src/index.tsx.

Without it, PWA never quits after all clients disconnect because Flipper Launcher does not set NODE_ENV to production currently (changed in the next diff)

Reviewed By: LukeDefeo, lblasa

Differential Revision: D48265768

fbshipit-source-id: 59e4660cb57da20b606562144c47c65276999d6c
2023-08-11 10:56:38 -07:00