Commit Graph

11 Commits

Author SHA1 Message Date
Pascal Hartig
1b54a079f5 Upgrade upload actions (#3070)
Summary:
We're seeing some spurious failures, unrelated to any changes on our end.

I've upgraded the action to do two things:

- Retry on failure (up to three times): b0dfcdf1c7
- Replace the artefact if it's already present (otherwise this might fail subsequent retries): 92bec0ba48

Pull Request resolved: https://github.com/facebook/flipper/pull/3070

Reviewed By: nikoant

Differential Revision: D32532277

Pulled By: passy

fbshipit-source-id: f1899c89c405772490958674fa7f46f479c666f9
2021-11-18 08:50:26 -08:00
Pascal Hartig
4736abc29c Upgrade publish action
Summary: I upgraded the docker image which should pull the latest GHR release (https://github.com/tcnksm/ghr).

Reviewed By: lblasa

Differential Revision: D31442256

fbshipit-source-id: 0f9fa81ec1be1285aea3da621b7ef5a1e63c3e84
2021-10-08 03:40:49 -07:00
Pascal Hartig
1ec7ebbdb5 Create issue on publish failure (#2904)
Summary:
Because the publish runs aren't triggered on the main branch, we have limited visibility. Sending push notifications, webhooks or email integrations are hard, but opening an issue seems like a decent work-around for this.

We can broaden this to more publish actions as needed.

Pull Request resolved: https://github.com/facebook/flipper/pull/2904

Test Plan: Ran on my fork which generated this issue: https://github.com/passy/flipper/issues/9

Reviewed By: mweststrate

Differential Revision: D31146956

Pulled By: passy

fbshipit-source-id: 08f66bd4c96a5ea2cc5e70a7461c30e7e1f3d42e
2021-09-27 06:10:08 -07:00
Pascal Hartig
da9511a5bf Fix CI build for Android (#2836)
Summary:
I've been really sweating about this one. It looks like Google now removed NDK 21 as it's too old. However, we've been struggling with the upgrade because OpenSSL was built against an old version of the NDK/glibc/LLVM/some other stuff.

I've now managed to create an OpenSSL distribution for 1.1.1k (we had 1.1.0h before) that seems to build with this after some small modifications.

This seems to do the trick, but I wouldn't be shocked if we found some more incompatibilities further down the line.

Pull Request resolved: https://github.com/facebook/flipper/pull/2836

Test Plan:
- Locally: `./gradlew :tutorial:installDebug`. Builds, starts up. Cool.
- Public GitHub CI: Happy.
- Circle CI: Only triggers post-land. We'll see. But the setup is simple, so hopefully it should work there, too.
- Internal CI: Waiting for signal.

Reviewed By: fabiomassimo

Differential Revision: D30839209

Pulled By: passy

fbshipit-source-id: efe599f28cc0edfdf2149f905c3483555239edc0
2021-09-09 08:46:59 -07:00
Pascal Hartig
4f3ee3ea57 Bump gradle-maven-publish-plugin from 0.16.0 to 0.17.0
Summary:
From the changelog:

> Removed the deprecated uploadArchives and installArchives tasks. Use publish and publishToMavenLocal instead.

Made the necessary changes to docs and scripts.

Reviewed By: nikoant

Differential Revision: D29752895

fbshipit-source-id: 6e96c7ea9b26be2acb40b9089cb361837ab10a1b
2021-07-29 09:35:04 -07:00
Pascal Hartig
ab93c24dd6 Fix publishing pipeline (hopefully) (#2311)
Summary:
https://github.com/facebook/flipper/runs/2574198766?check_suite_focus=true
shows that the env vars aren't getting picked up. There's some sort
of transformation syntax (https://docs.gradle.org/current/userguide/build_environment.html#sec:project_properties)
which I thought this would follow but didn't.

I'm merging this now with the already existing gradle.properties update
we do. I also tested locally that this approach works.

Pull Request resolved: https://github.com/facebook/flipper/pull/2311

Test Plan:
Updated my local gradle.properties accordingly and re-uploaded the 0.90
release.

Reviewed By: nikoant

Differential Revision: D28440724

Pulled By: passy

fbshipit-source-id: 9f7238b61fe309eea087b5d6a063788e9ea76e85
2021-05-14 06:57:13 -07:00
Pascal Hartig
4a636c8e7b Update android publish task
Summary: A recent plugin upgrade removed the previous ones.

Reviewed By: cekkaewnumchai

Differential Revision: D28285219

fbshipit-source-id: e8dcb004ede225283d805b13011709c9d5f3bdae
2021-05-07 04:21:52 -07:00
Pascal Hartig
3cda93dade Cache Android builds on GitHub Actions (#1922)
Summary:
Builds up a file with checksums of all `build.gradle` files. Deliberately excludes the `gradle.properties` which changes all the time. The cache shouldn't require nuking except in some rare circumstances.

Pull Request resolved: https://github.com/facebook/flipper/pull/1922

Test Plan: From 41 minutes down to 17: https://github.com/passy/flipper-1/actions/runs/561501374

Reviewed By: mweststrate

Differential Revision: D26427242

Pulled By: passy

fbshipit-source-id: ff1d7370d477c9d7b57c62082ec985108a5ba698
2021-02-16 04:18:28 -08:00
Pascal Hartig
761f1354db Clean up secrets (#1921)
Summary:
See this being done elsewhere. I don't think it's necessary but why not?

Pull Request resolved: https://github.com/facebook/flipper/pull/1921

Test Plan: eyes

Reviewed By: jknoxville

Differential Revision: D26427191

Pulled By: passy

fbshipit-source-id: 80823bf50d6416d29d54c82cef433650c1451ac0
2021-02-15 10:31:03 -08:00
Pascal Hartig
7fd0c7d82e Fix upload of sample app apk (#1920)
Summary:
This was an expected failure, you can see here how the last step of the "Publish Android" workflow currently fails: https://github.com/facebook/flipper/runs/1873750507?check_suite_focus=true

This is because it no longer runs in a tagging context. We're now providing the tag as an input and my custom action knows how to attach to existing tags by name.

Pull Request resolved: https://github.com/facebook/flipper/pull/1920

Test Plan:
Test run here finished successfully: https://github.com/passy/flipper-1/actions/runs/560774414
Publish Android job: https://github.com/passy/flipper-1/actions/runs/560775419
Attached release: https://github.com/passy/flipper-1/releases/tag/v0.0.7
Artifacts on Central: https://repo.maven.apache.org/maven2/com/facebook/flipper/flipper/0.0.7/

{F372552533}

{F372552532}

Reviewed By: mweststrate

Differential Revision: D26402629

Pulled By: passy

fbshipit-source-id: 7290e6bb8d1078ee20a0cf10105dc37f1e7aa99a
2021-02-12 04:36:11 -08:00
Pascal Hartig
0085a0d140 Set up release automation (#1915)
Summary:
Depends on https://github.com/facebook/flipper/issues/1914.
This sets up the workflows for automatically building, publishing and "closing" the repository on Maven Central, which is a step you usually need to do manually in the web UI.

Still need to transfer all the secrets over to this repo for it to work.

Pull Request resolved: https://github.com/facebook/flipper/pull/1915

Test Plan:
Ran all of this in my this in my fork and released some `0.0.x` versions.

- Successful workflow: https://github.com/passy/flipper-1/actions/runs/552170713
- It's actually all on Maven: https://repo.maven.apache.org/maven2/com/facebook/flipper/

Reviewed By: jknoxville

Differential Revision: D26367469

Pulled By: passy

fbshipit-source-id: d65f64ee8eec1dc71af64b7e0f87473b9c956fec
2021-02-10 07:16:32 -08:00