Commit Graph

1730 Commits

Author SHA1 Message Date
Pascal Hartig
52b3edc5ad Move screenshot to iOSBridge
Summary:
In order to support IOS cloud devices, we need to abstract
over the direct uses of idb/xcrun so we can switch them
out based on more than the device type.

Note that there's a bit of a type weirdness in there. I'll
clean this up with the next diff.

Reviewed By: mweststrate

Differential Revision: D30248036

fbshipit-source-id: ec8571429e04abe059850ef334a6645ae4a5e034
2021-08-11 11:03:45 -07:00
Pascal Hartig
f515df1c01 Restructure iOS dispatcher initialization
Summary:
Avoid nested promises and log errors during initialization that were
previously thrown away.

Reviewed By: mweststrate

Differential Revision: D30247859

fbshipit-source-id: 1d9ef871d1861a25a64ed4e895978b04f5b51c7b
2021-08-11 11:03:45 -07:00
dependabot[bot]
4ca1227522 Bump path-parse from 1.0.6 to 1.0.7 in /desktop (#2681)
Summary:
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/jbgutierrez/path-parse/commits/v1.0.7">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=path-parse&package-manager=npm_and_yarn&previous-version=1.0.6&new-version=1.0.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/flipper/network/alerts).

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2681

Reviewed By: mweststrate

Differential Revision: D30246996

Pulled By: passy

fbshipit-source-id: 00e1e3a0a6530e4ac7dbc198a7a4b80ded11c054
2021-08-11 11:03:45 -07:00
Pascal Hartig
a630020ea0 Remove promisify use
Summary:
The results are often unpredictable, poorly typed and we have
dependencies that do the wrapping for us.

Listen, I'll get to writing some real code soon, I promise,
but I need to clean up my workspace first, okay?

Reviewed By: mweststrate

Differential Revision: D30247484

fbshipit-source-id: f5326ff71ff43af2dc64ab85ca1368f95fe87083
2021-08-11 11:03:45 -07:00
Pascal Hartig
4e17fb9c48 Extract temp path util
Summary:
`electron.remote` access is slow so we can cache this
like we do in other places. Also means one fewer `electron`
import which is gonna add up for Flipper Decap.

Reviewed By: mweststrate

Differential Revision: D30247431

fbshipit-source-id: 90f0e8df99af8bed40fbebcfd445abaca2965b7c
2021-08-11 11:03:45 -07:00
Pascal Hartig
11c1c39bdc Improve screen recording logging
Summary:
Error is handled, doesn't need a task. Also, prefix is wrong here
as it's used.

Reviewed By: mweststrate

Differential Revision: D30247416

fbshipit-source-id: 049490cb7e45b7ce6f433bf7366eb94893947625
2021-08-11 11:03:45 -07:00
Pascal Hartig
8223051905 Mute eslint rule
Summary:
A few drive-by changes ahead of the sustainathon.
(More to come.)

Reviewed By: mweststrate

Differential Revision: D30247395

fbshipit-source-id: e707377a1169eb634a42f08c3d27fe3e065b63bb
2021-08-11 11:03:45 -07:00
dependabot[bot]
bc4a998ac2 Bump jszip from 3.3.0 to 3.7.1 in /desktop (#2680)
Summary:
Bumps [jszip](https://github.com/Stuk/jszip) from 3.3.0 to 3.7.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/Stuk/jszip/blob/master/CHANGES.md">jszip's changelog</a>.</em></p>
<blockquote>
<h3>v3.7.1 2021-08-05</h3>
<ul>
<li>Fix build of <code>dist</code> files.
<ul>
<li>Note: this version ensures the changes from 3.7.0 are actually included in the <code>dist</code> files. Thanks to Evan W for reporting.</li>
</ul>
</li>
</ul>
<h3>v3.7.0 2021-07-23</h3>
<ul>
<li>Fix: Use a null prototype object for this.files  (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/766">https://github.com/facebook/flipper/issues/766</a>)
<ul>
<li>This change might break existing code if it uses prototype methods on the <code>.files</code> property of a zip object, for example <code>zip.files.toString()</code>. This approach is taken to prevent files in the zip overriding object methods that would exist on a normal object.</li>
</ul>
</li>
</ul>
<h3>v3.6.0 2021-02-09</h3>
<ul>
<li>Fix: redirect main to dist on browsers (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/742">https://github.com/facebook/flipper/issues/742</a>)</li>
<li>Fix duplicate require DataLengthProbe, utils (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/734">https://github.com/facebook/flipper/issues/734</a>)</li>
<li>Fix small error in read_zip.md (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/703">https://github.com/facebook/flipper/issues/703</a>)</li>
</ul>
<h3>v3.5.0 2020-05-31</h3>
<ul>
<li>Fix 'End of data reached' error when file extra field is invalid (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/544">https://github.com/facebook/flipper/issues/544</a>).</li>
<li>Typescript definitions: Add null to return types of functions that may return null (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/669">https://github.com/facebook/flipper/issues/669</a>).</li>
<li>Typescript definitions: Correct nodeStream's type (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/682">https://github.com/facebook/flipper/issues/682</a>)</li>
<li>Typescript definitions: Add string output type (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/666">https://github.com/facebook/flipper/issues/666</a>)</li>
</ul>
<h3>v3.4.0 2020-04-19</h3>
<ul>
<li>Add Typescript type definitions (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/601">https://github.com/facebook/flipper/issues/601</a>).</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="3f2f0da8b2"><code>3f2f0da</code></a> 3.7.1</li>
<li><a href="9f9c33b66b"><code>9f9c33b</code></a> Updates for 3.7.1</li>
<li><a href="5639745878"><code>5639745</code></a> Merge branch 'fix-build'</li>
<li><a href="e08003ec71"><code>e08003e</code></a> Fix lint</li>
<li><a href="79f7691e51"><code>79f7691</code></a> Revert &quot;Disable proto assert that fails in browsers&quot;</li>
<li><a href="89298b9f26"><code>89298b9</code></a> Update gitignore for Mac, and sort</li>
<li><a href="81cb5eb244"><code>81cb5eb</code></a> Temporarily update docs for building dist correctly</li>
<li><a href="e5b3f0ddaa"><code>e5b3f0d</code></a> 3.7.0</li>
<li><a href="e88ba4b367"><code>e88ba4b</code></a> Update for version 3.7.0</li>
<li><a href="90464873e3"><code>9046487</code></a> Disable proto assert that fails in browsers</li>
<li>Additional commits viewable in <a href="https://github.com/Stuk/jszip/compare/v3.3.0...v3.7.1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=jszip&package-manager=npm_and_yarn&previous-version=3.3.0&new-version=3.7.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/flipper/network/alerts).

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2680

Reviewed By: mweststrate

Differential Revision: D30246994

Pulled By: passy

fbshipit-source-id: b507ab24054ebfe905b092f0ca9da0c43ea37d16
2021-08-11 11:03:45 -07:00
dependabot[bot]
5cf86a8f6e Bump eslint-plugin-import from 2.23.4 to 2.24.0 in /desktop (#2671)
Summary:
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.23.4 to 2.24.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/import-js/eslint-plugin-import/blob/master/CHANGELOG.md">eslint-plugin-import's changelog</a>.</em></p>
<blockquote>
<h2>[2.24.0] - 2021-08-08</h2>
<h3>Added</h3>
<ul>
<li>[<code>no-dynamic-require</code>]: add option <code>esmodule</code> (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/1223">https://github.com/facebook/flipper/issues/1223</a>, thanks [<a href="https://github.com/vikr01"><code>@​vikr01</code></a>])</li>
<li>[<code>named</code>]: add <code>commonjs</code> option (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/1222">https://github.com/facebook/flipper/issues/1222</a>, thanks [<a href="https://github.com/vikr01"><code>@​vikr01</code></a>])</li>
<li>[<code>no-namespace</code>]: Add <code>ignore</code> option (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2112">https://github.com/facebook/flipper/issues/2112</a>, thanks [<a href="https://github.com/aberezkin"><code>@​aberezkin</code></a>])</li>
<li>[<code>max-dependencies</code>]: add option <code>ignoreTypeImports</code> (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/1847">https://github.com/facebook/flipper/issues/1847</a>, thanks [<a href="https://github.com/rfermann"><code>@​rfermann</code></a>])</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>[<code>no-duplicates</code>]: ensure autofix avoids excessive newlines (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2028">https://github.com/facebook/flipper/issues/2028</a>, thanks [<a href="https://github.com/ertrzyiks"><code>@​ertrzyiks</code></a>])</li>
<li>[<code>extensions</code>]: avoid crashing on partially typed import/export statements (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2118">https://github.com/facebook/flipper/issues/2118</a>, thanks [<a href="https://github.com/ljharb"><code>@​ljharb</code></a>])</li>
<li>[<code>no-extraneous-dependencies</code>]: add ESM intermediate package.json support] (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2121">https://github.com/facebook/flipper/issues/2121</a>, thanks [<a href="https://github.com/paztis"><code>@​paztis</code></a>])</li>
<li>Use <code>context.getPhysicalFilename()</code> when available (ESLint 7.28+) (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2160">https://github.com/facebook/flipper/issues/2160</a>, thanks [<a href="https://github.com/pmcelhaney"><code>@​pmcelhaney</code></a>])</li>
<li>[<code>extensions</code>]/<code>importType</code>: fix isScoped treating @/abc as scoped module (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2146">https://github.com/facebook/flipper/issues/2146</a>, thanks [<a href="https://github.com/rperello"><code>@​rperello</code></a>])</li>
</ul>
<h3>Changed</h3>
<ul>
<li>[Docs] [<code>extensions</code>]: removed incorrect cases (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2138">https://github.com/facebook/flipper/issues/2138</a>, thanks [<a href="https://github.com/wenfangdu"><code>@​wenfangdu</code></a>])</li>
<li>[Tests] [<code>order</code>]: add tests for <code>pathGroupsExcludedImportTypes: ['type']</code> (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2158">https://github.com/facebook/flipper/issues/2158</a>, thanks [<a href="https://github.com/atav32"><code>@​atav32</code></a>])</li>
<li>[Docs] [<code>order</code>]:  improve the documentation for the <code>pathGroupsExcludedImportTypes</code> option (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2156">https://github.com/facebook/flipper/issues/2156</a>, thanks [<a href="https://github.com/liby"><code>@​liby</code></a>])</li>
<li>[Tests] [<code>no-cycle</code>]: Restructure test files (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/1517">https://github.com/facebook/flipper/issues/1517</a>, thanks [<a href="https://github.com/soryy708"><code>@​soryy708</code></a>])</li>
<li>[Docs] add description how to use plugin with yarn berry (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2179">https://github.com/facebook/flipper/issues/2179</a>, thanks [<a href="https://github.com/KostyaZgara"><code>@​KostyaZgara</code></a>])</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="202e5e02db"><code>202e5e0</code></a> Bump to v2.24.0</li>
<li><a href="546f87f6c7"><code>546f87f</code></a> utils: v2.6.2</li>
<li><a href="74fa6c99cc"><code>74fa6c9</code></a> [resolvers/node] v0.3.5</li>
<li><a href="32bf645563"><code>32bf645</code></a> [Docs] add description how to use plugin with yarn berry</li>
<li><a href="794e869757"><code>794e869</code></a> [meta] update repo URLs</li>
<li><a href="429f3f6023"><code>429f3f6</code></a> [Tests] <code>no-cycle</code>: Restructure test files</li>
<li><a href="b743a650e9"><code>b743a65</code></a> [New] <code>max-dependencies</code>: add option <code>ignoreTypeImports</code></li>
<li><a href="bba59c4848"><code>bba59c4</code></a> [New] <code>no-namespace</code>: Add <code>ignore</code> option</li>
<li><a href="54d86c8a64"><code>54d86c8</code></a> [New] <code>named</code>: add <code>commonjs</code> option</li>
<li><a href="7626a14851"><code>7626a14</code></a> [Refactor] <code>named</code>: clean up formatting</li>
<li>Additional commits viewable in <a href="https://github.com/import-js/eslint-plugin-import/compare/v2.23.4...v2.24.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=eslint-plugin-import&package-manager=npm_and_yarn&previous-version=2.23.4&new-version=2.24.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2671

Reviewed By: mweststrate

Differential Revision: D30226888

Pulled By: passy

fbshipit-source-id: 5245244f87de76a0d51acc90b0ff43a1cd98b085
2021-08-11 11:03:45 -07:00
Pascal Hartig
dd536b9d1a Gracefully handle socket closures
Summary:
Got my first auto-created crashbot task. {emoji:1f973}

We do have some pretty granular handling for errors during disconnects but this one has fallen through the cracks.

I'm not 100% sure if this is the right way to handle it which is why I added mweststrate. :)

Reviewed By: mweststrate

Differential Revision: D30218833

fbshipit-source-id: 2b4c9201ee7faf1c278b1cc5268ad2648dc4c820
2021-08-10 16:12:02 -07:00
Michel Weststrate
8d7caa9dd4 Introduce Dialog.alert
Summary: Introduce `Dialog.alert` to show users a FYI message, and be able to wait for it to be handled, as utility around several `Modal` utilities.

Reviewed By: jknoxville

Differential Revision: D29875484

fbshipit-source-id: 5d2ea83e486631ac18a81800b467f97dfaac6d34
2021-08-10 13:24:23 -07:00
Michel Weststrate
4b892e7373 Check Flipper version when handling deeplinks
Summary: Check if Flipper is up to date before handling deeplink.

Reviewed By: nikoant

Differential Revision: D29846236

fbshipit-source-id: 011d05958346c3d18c76cf0ae63c3cb087f5933c
2021-08-10 13:24:23 -07:00
Michel Weststrate
38473121ba Check connection & user login when entering deeplink [1/n]
Summary: First steps in smoother deeplink flow, where connection and login status is being checked before trying to handle the deeplink.

Reviewed By: lblasa

Differential Revision: D29790461

fbshipit-source-id: e1e42ceb5db59c695077f316e836f1f216c7204a
2021-08-10 13:24:23 -07:00
Pascal Hartig
47faeade61 Patch dep bump
Summary: Excluding `react-virtual` which seems to include a breaking change with the patch release.

Reviewed By: jknoxville

Differential Revision: D30189687

fbshipit-source-id: b40cb5edd407fd03009ee38c0af5202c8deaaa26
2021-08-10 11:08:22 -07:00
Pascal Hartig
fc73e0d4ec Revert "Improve protobuf support (#2513)" (#2665)
Summary:
This reverts commit efd75ea435.

Sorry hbmartin! We're running into Kotlin compatibility problems. Your latest library release isn't compatible with Kotlin 1.3 and we can't upgrade just yet because Litho hasn't been able to release in a while. :(

Pull Request resolved: https://github.com/facebook/flipper/pull/2665

Test Plan: _eyes

Differential Revision: D30189360

Pulled By: passy

fbshipit-source-id: c1edbbc496742938579f4e2032a78debe08fcc26
2021-08-09 04:15:49 -07:00
Harold Martin
efd75ea435 Improve protobuf support (#2513)
Summary:
* Update protobuf library to support map types
* Improved usage messaging in UI
* Always attempt to decode requests with a protobuf definition
## Changelog
Improved protobuf support

Pull Request resolved: https://github.com/facebook/flipper/pull/2513

Reviewed By: mweststrate

Differential Revision: D30162379

Pulled By: passy

fbshipit-source-id: 201fb06045822641be5840b121da180a201be974
2021-08-09 02:42:35 -07:00
Ananya Arun
025ca05d62 Enrich plugin metadata on what apps they support and add unit tests
Summary:
- This Diff is part 1 of 2 of milestone 1 of my internship project flipper self sufficiency. The task can be found here - https://www.internalfb.com/tasks?q=958574791613645&t=91334896

- I have extended the plugin package meta data format to support a "supportedApps" field that consists of appID (facebook, instagram, messenger etc) along with OS and type that were previously defined in supportedDevices as well.

- The diff also adds unit tests for this new format to ensure addition of the supportedApps field does not break anything.

Reviewed By: nikoant

Differential Revision: D30133225

fbshipit-source-id: 6ef0d1cadd61c0d69640cf61793322acb4cd65f4
2021-08-06 07:14:44 -07:00
Flipper Bot
7b577f77c8 Flipper Release: v0.102.0
Summary: Releasing version 0.102.0

Reviewed By: nikoant

Differential Revision: D30131831

fbshipit-source-id: 05ffa592f0ae9e123dffed6a3c8c5c0e22daacf4
2021-08-05 09:43:40 -07:00
Anton Nikolaev
cc4064ec9f Force Sec-Fetch-Site header to 'none'
Reviewed By: bartoszniemczura

Differential Revision: D30047497

fbshipit-source-id: 0d9376c09d63176031291f19bfe82a56d5677641
2021-08-05 02:40:41 -07:00
Chaiwat Ekkaewnumchai
b280f75b06 Fix Vulnerability
Summary:
per title

For `xmldom`, npm can't push the update as mentioned in https://github.com/xmldom/xmldom/releases/tag/0.7.0

Reviewed By: lblasa

Differential Revision: D30101848

fbshipit-source-id: 0d84a302b845708787d5cae01643dba9963f0330
2021-08-04 09:36:14 -07:00
Flipper Bot
5dbb0b7a24 Flipper Release: v0.101.0
Summary: Releasing version 0.101.0

Reviewed By: lblasa

Differential Revision: D30098058

fbshipit-source-id: f6e6ed1942a30e492e66ed42aec6dc35d1cddd24
2021-08-04 07:37:17 -07:00
Ananya Arun
a5b83dc148 Add tracking for usage statistics
Summary:
- This diff adds usage statistics for
    - How often was the troubleshooting button opened
    - What were its end states ( Problem solved or file a support request)

- I am using the tracked flipper plugin to obtain and analyse the stats on Infinity analytics events dev in Scuba backend.
(Since this is not yet productionized we are using the dev version now )

Reviewed By: nikoant

Differential Revision: D30098054

fbshipit-source-id: 871cc18872bccf70a829dc1dd173a337b02ec6e6
2021-08-04 04:16:52 -07:00
Ananya Arun
84ec5813b6 Add modal dialogue for the end screen
Summary:
- Added a dialogue with 2 possible end state buttons
    - Problem Solved
    - File Support Request
- This diff is the start of the implementation of the troubleshooting wizard.
- The previously implemented troubleshooting button (D29993355 (921a65bc17)) now links to a modal dialogue box.
- This is essentially the last screen of the troubleshooting guide to be implemented.
- We have options for a user to either select file a support request if the issue persists after navigating the guide or click on problem solved if the guide helped them solve it.
- Selecting option 2 (file support request) links to the pre-existing form

The modal has been implemented as an independent reusable component and can be easily extended.

Reviewed By: passy

Differential Revision: D30069270

fbshipit-source-id: f61bf8c03de786e11b7f06194328dbee703abf8b
2021-08-03 12:49:49 -07:00
Lorenzo Blasa
4e6b895fc9 WebSocket server GK
Summary:
This change enables a WebSocket server if the user is on the 'flipper_websocket_server' GK.

I don't expect this change to make it as the final product of the entire solution. Instead, it can be used to quickly enable/disable WebSocket during development/testing without requiring any code changes.

Reviewed By: passy

Differential Revision: D30069694

fbshipit-source-id: 75daac75e6dad7f63cf194d8287971c33d3abb61
2021-08-03 09:34:57 -07:00
Lorenzo Blasa
b76ce357eb Addresses an issue with Flipper message identifier
Summary:
This change addresses a problem with using data.id straight into the if statement.

If `data.id` is not undefined but has a value of 0 then the expression evaluates to false.

Right now, that wasn't the intended usage.

Using this change to also export some types from Client.

Reviewed By: passy

Differential Revision: D30069746

fbshipit-source-id: 04a8d161efceadf7a38ee556be70c15b45c11056
2021-08-03 09:30:47 -07:00
Pascal Hartig
6791b29e45 Big dep bump
Summary: The markdown bump required ignoring another prop, the rest was smooth.

Reviewed By: timur-valiev

Differential Revision: D30067682

fbshipit-source-id: 6038ffe29d2e0041c81bac132eed747cbfe40f54
2021-08-03 05:18:34 -07:00
Andrey
6349ebe05d Fixed plugin installer overflow (#2652)
Summary:
https://user-images.githubusercontent.com/33036510/127777930-34ede219-0fb9-4486-8f2e-3d73ff8cb84d.mov

Content of plugin installer modal has no scroll and it is overflowing

## Changelog

- Fixed PluginInstaller table overflow

Pull Request resolved: https://github.com/facebook/flipper/pull/2652

Test Plan:
The video, demonstrating how the problem was fixed:
https://user-images.githubusercontent.com/33036510/127777930-34ede219-0fb9-4486-8f2e-3d73ff8cb84d.mov

Reviewed By: passy

Differential Revision: D30044703

Pulled By: cekkaewnumchai

fbshipit-source-id: 6d00ef766aaa295cc43fd944ca3b849371192a79
2021-08-02 14:30:46 -07:00
dependabot[bot]
20f4cfe70c Bump metro-cache from 0.66.1 to 0.66.2 in /desktop (#2660)
Summary:
Bumps [metro-cache](https://github.com/facebook/metro) from 0.66.1 to 0.66.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro-cache's releases</a>.</em></p>
<blockquote>
<h2>Release v0.66.2</h2>
<ul>
<li><strong>[Fix]</strong> Fix crash in React Native 0.65.0-rc.2. (f7c6325)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c21daba415"><code>c21daba</code></a> Bump metro to 0.66.2</li>
<li><a href="4972832419"><code>4972832</code></a> Deploy Flow v0.155.1</li>
<li><a href="f0247a811b"><code>f0247a8</code></a> Deploy Flow v0.155.1</li>
<li><a href="f7c6325cbe"><code>f7c6325</code></a> fix(metro): cannot read property 'toUpperCase' of undefined (<a href="https://github-redirect.dependabot.com/facebook/metro/issues/687">https://github.com/facebook/flipper/issues/687</a>)</li>
<li><a href="48b5b1eaa8"><code>48b5b1e</code></a> Update xplat to Flow v0.155.0</li>
<li>See full diff in <a href="https://github.com/facebook/metro/compare/v0.66.1...v0.66.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=metro-cache&package-manager=npm_and_yarn&previous-version=0.66.1&new-version=0.66.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2660

Reviewed By: passy

Differential Revision: D30044649

Pulled By: cekkaewnumchai

fbshipit-source-id: fbd9c77eb93accf8db241b37076dfdef75c82a4e
2021-08-02 14:08:04 -07:00
dependabot[bot]
82792af99b Bump chalk from 4.1.1 to 4.1.2 in /desktop (#2655)
Summary:
Bumps [chalk](https://github.com/chalk/chalk) from 4.1.1 to 4.1.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/chalk/chalk/releases">chalk's releases</a>.</em></p>
<blockquote>
<h2>v4.1.2</h2>
<ul>
<li>Readme updates</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="95d74cbe8d"><code>95d74cb</code></a> 4.1.2 - Readme updates</li>
<li>See full diff in <a href="https://github.com/chalk/chalk/compare/v4.1.1...v4.1.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=chalk&package-manager=npm_and_yarn&previous-version=4.1.1&new-version=4.1.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2655

Reviewed By: passy

Differential Revision: D30044697

Pulled By: cekkaewnumchai

fbshipit-source-id: 3e322863cc8f03f997783b90768a63edf6245c18
2021-08-02 14:08:04 -07:00
dependabot[bot]
66e8e2a375 Bump @babel/preset-env from 7.14.8 to 7.14.9 in /desktop (#2659)
Summary:
Bumps [babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.14.8 to 7.14.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@​babel/preset-env</code>'s releases</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<p>Thanks <a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a> for your first PR!</p>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 8</h4>
<ul>
<li>Andy Edwards (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
<li>Anna Henningsen (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
<li>Babel Bot (<a href="https://github.com/babel-bot"><code>@​babel-bot</code></a>)</li>
<li>Henry Zhu (<a href="https://github.com/hzoo"><code>@​hzoo</code></a>)</li>
<li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
<li>Rin Tepis (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
<li>王清雨 (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@​babel/preset-env</code>'s changelog</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="aa2cac5edc"><code>aa2cac5</code></a> v7.14.9</li>
<li><a href="93bade2a71"><code>93bade2</code></a> Update <code>core-js@3</code> packages (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env/issues/13621">#13621</a>)</li>
<li>See full diff in <a href="https://github.com/babel/babel/commits/v7.14.9/packages/babel-preset-env">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@babel/preset-env&package-manager=npm_and_yarn&previous-version=7.14.8&new-version=7.14.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2659

Reviewed By: passy

Differential Revision: D30044650

Pulled By: cekkaewnumchai

fbshipit-source-id: fb6c02ff3a710e76b91cbb11ab46159a17b73496
2021-08-02 14:08:04 -07:00
dependabot[bot]
533fd7e39e Bump @babel/traverse from 7.14.8 to 7.14.9 in /desktop (#2657)
Summary:
Bumps [babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.14.8 to 7.14.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@​babel/traverse</code>'s releases</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<p>Thanks <a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a> for your first PR!</p>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 8</h4>
<ul>
<li>Andy Edwards (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
<li>Anna Henningsen (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
<li>Babel Bot (<a href="https://github.com/babel-bot"><code>@​babel-bot</code></a>)</li>
<li>Henry Zhu (<a href="https://github.com/hzoo"><code>@​hzoo</code></a>)</li>
<li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
<li>Rin Tepis (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
<li>王清雨 (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@​babel/traverse</code>'s changelog</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="aa2cac5edc"><code>aa2cac5</code></a> v7.14.9</li>
<li><a href="d3a7cd5e8d"><code>d3a7cd5</code></a> Replace generic <code>__clone</code> call by specific methods (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13611">#13611</a>)</li>
<li><a href="d45ad500e7"><code>d45ad50</code></a> Improve <code>path.get</code> typings with TS template literal types (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13588">#13588</a>)</li>
<li><a href="d1f908924c"><code>d1f9089</code></a> Fix completion record for variable declarations (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13596">#13596</a>)</li>
<li><a href="e0dc925bbe"><code>e0dc925</code></a> feat(traverse): specific return type for virtual types' validators (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13578">#13578</a>)</li>
<li><a href="1d48bb0d8c"><code>1d48bb0</code></a> add 12 missing NODE_FIELDS (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13577">#13577</a>)</li>
<li>See full diff in <a href="https://github.com/babel/babel/commits/v7.14.9/packages/babel-traverse">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@babel/traverse&package-manager=npm_and_yarn&previous-version=7.14.8&new-version=7.14.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2657

Reviewed By: passy

Differential Revision: D30044695

Pulled By: cekkaewnumchai

fbshipit-source-id: f724c61e1da92afdf39d0b72f3544ee201c658ec
2021-08-02 14:08:04 -07:00
dependabot[bot]
2dd914b648 Bump @babel/generator from 7.14.5 to 7.14.9 in /desktop (#2661)
Summary:
Bumps [babel/generator](https://github.com/babel/babel/tree/HEAD/packages/babel-generator) from 7.14.5 to 7.14.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@​babel/generator</code>'s releases</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<p>Thanks <a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a> for your first PR!</p>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 8</h4>
<ul>
<li>Andy Edwards (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
<li>Anna Henningsen (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
<li>Babel Bot (<a href="https://github.com/babel-bot"><code>@​babel-bot</code></a>)</li>
<li>Henry Zhu (<a href="https://github.com/hzoo"><code>@​hzoo</code></a>)</li>
<li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
<li>Rin Tepis (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
<li>王清雨 (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
<h2>v7.14.8 (2021-07-20)</h2>
<p>Thanks <a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>, <a href="https://github.com/jaeseokk"><code>@​jaeseokk</code></a> and <a href="https://github.com/nme077"><code>@​nme077</code></a> for your first PRs!</p>
<h4>👓 Spec Compliance</h4>
<ul>
<li><code>babel-helper-create-class-features-plugin</code>, <code>babel-plugin-proposal-class-static-block</code>, <code>babel-plugin-transform-new-target</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13560">#13560</a> fix(class-properties): replace <code>new.target</code> in static properties with <code>undefined</code> (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13088">#13088</a> Fix await binding error within static block (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13531">#13531</a> fix: disallow computed <code>async</code>/<code>get</code>/<code>set</code> keyword (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@​babel/generator</code>'s changelog</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h2>v7.14.8 (2021-07-20)</h2>
<h4>👓 Spec Compliance</h4>
<ul>
<li><code>babel-helper-create-class-features-plugin</code>, <code>babel-plugin-proposal-class-static-block</code>, <code>babel-plugin-transform-new-target</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13560">#13560</a> fix(class-properties): replace <code>new.target</code> in static properties with <code>undefined</code> (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13088">#13088</a> Fix await binding error within static block (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13531">#13531</a> fix: disallow computed <code>async</code>/<code>get</code>/<code>set</code> keyword (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-helper-module-transforms</code>, <code>babel-helper-simple-access</code>, <code>babel-plugin-transform-modules-commonjs</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13258">#13258</a> Fix const violations in ESM imports when transformed to CJS (<a href="https://github.com/overlookmotel"><code>@​overlookmotel</code></a>)</li>
</ul>
</li>
</ul>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13575">#13575</a> Update babel-parser.d.ts (<a href="https://github.com/sosukesuzuki"><code>@​sosukesuzuki</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13548">#13548</a> Fix  parser <code>strictMode</code> option (<a href="https://github.com/overlookmotel"><code>@​overlookmotel</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13573">#13573</a> Fix issue to allow module block in member expression (<a href="https://github.com/nme077"><code>@​nme077</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13521">#13521</a> Overhaul comment attachment (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13534">#13534</a> Async do expression should start at async (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-arrow-functions</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12344">#12344</a> Fix arrow transformation when <code>arguments</code> is defined as variable (<a href="https://github.com/snitin315"><code>@​snitin315</code></a>)</li>
</ul>
</li>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13527">#13527</a> fix: accept duplicated import/variable in different module (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
</li>
<li><code>babel-types</code></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="aa2cac5edc"><code>aa2cac5</code></a> v7.14.9</li>
<li><a href="e4de256cdd"><code>e4de256</code></a> chore: reorganize benchmarks (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/13606">#13606</a>)</li>
<li><a href="1d48bb0d8c"><code>1d48bb0</code></a> add 12 missing NODE_FIELDS (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/13577">#13577</a>)</li>
<li><a href="03e8476b27"><code>03e8476</code></a> Generator performance (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/13593">#13593</a>)</li>
<li><a href="e591780244"><code>e591780</code></a> v7.14.8</li>
<li><a href="9bad558d13"><code>9bad558</code></a> [babel 8] Use an identifier for <code>TSTypeParameter.name</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/12829">#12829</a>)</li>
<li>See full diff in <a href="https://github.com/babel/babel/commits/v7.14.9/packages/babel-generator">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@babel/generator&package-manager=npm_and_yarn&previous-version=7.14.5&new-version=7.14.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2661

Reviewed By: passy

Differential Revision: D30044639

Pulled By: cekkaewnumchai

fbshipit-source-id: 402ed864952611a88409659d59d179ad04cf39ef
2021-08-02 14:08:04 -07:00
Ananya Arun
19f6b29879 Remove cyclic dependancy on components
Summary:
- Minor change on Diff - D30040808
- Removed cyclic dependancy on AppSelector
- Previous dependancy chain : AppSelector -> TroubleshootingGuide -> AppSelector
- Now the NoDevices component that troubleshooting guide was importing has been moved to an independent file.

Reviewed By: passy

Differential Revision: D30041820

fbshipit-source-id: 17856aad7d2a569ec4e0f19e63f458472b22dcf8
2021-08-02 09:43:03 -07:00
Ananya Arun
921a65bc17 Add troubleshooting button and a GK
Summary:
- Added a troubleshooting guide button which on clicking will open the expert chat bot system of flipper. ( Will be implemented in future diffs)
- This has been added only in the internal version of flipper available to FB.
- The public version shall continue to link to the troubleshooting guide for now.
- Also a new gatekeeper flipper_self_sufficiency was set up.
- This currently gives access to ongoing changes only to a few team members.
- In the future access shall be extended to the entire team, followed by the entire org and then finally all internal FB users in the final stages of the project.

Reviewed By: passy

Differential Revision: D29993355

fbshipit-source-id: afdb76baef6fde2c785c50ad6530ea2f76ce7284
2021-08-02 09:16:48 -07:00
Pascal Hartig
754100d9ed Revert D30012637: Bump antd from 4.16.8 to 4.16.9 in /desktop
Differential Revision:
D30012637 (069af92d12)

Original commit changeset: 5ebdb3f8bb6c

fbshipit-source-id: ac7c1f165ae401fdbaa66c1746fefe1ae634c323
2021-08-02 08:34:08 -07:00
dependabot[bot]
069af92d12 Bump antd from 4.16.8 to 4.16.9 in /desktop (#2645)
Summary:
allow-large-files
Bumps [antd](https://github.com/ant-design/ant-design) from 4.16.8 to 4.16.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.16.9</h2>
<ul>
<li>{emoji:1f41e} Fix Typography <code>ellipsis</code> calculation bug when browser zoomed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31449">#31449</a></li>
<li>{emoji:1f484} Fix Input wrong class when using <code>prefixCls</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31479">#31479</a> <a href="https://github.com/spawnia"><code>@​spawnia</code></a></li>
<li>{emoji:1f484} Fix Input.Password unexpected focus style of error status. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31456">#31456</a></li>
<li>{emoji:1f484} Fix Badge color transition issue when toggle visibility. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31458">#31458</a></li>
<li>{emoji:1f484} Fix Tabs <code>tabBarGutter</code> abnormal style behaviors. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31469">#31469</a></li>
<li>{emoji:1f310} Internationalization
<ul>
<li>{emoji:1f1f7_1f1fa} Update translation for Image in ru_RU. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31448">#31448</a> <a href="https://github.com/KirillSBarsukov"><code>@​KirillSBarsukov</code></a></li>
<li>{emoji:1f1e9_1f1f0} Add missing translation for Table in da_DK. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31486">#31486</a> <a href="https://github.com/bischmlb"><code>@​bischmlb</code></a></li>
</ul>
</li>
</ul>
<hr />
<ul>
<li>{emoji:1f41e} 修复 Typography <code>ellipsis</code> 在屏幕放大缩小时计算错误的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31449">#31449</a></li>
<li>{emoji:1f484} 修复 Input 使用 <code>prefixCls</code> class 错误的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31479">#31479</a> <a href="https://github.com/spawnia"><code>@​spawnia</code></a></li>
<li>{emoji:1f484} 修复 Input.Password 校验错误时的聚焦样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31456">#31456</a></li>
<li>{emoji:1f484} 修复 Badge 切换显隐时的颜色问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31458">#31458</a></li>
<li>{emoji:1f484} 修复 Tabs <code>tabBarGutter</code> 的一些样式异常行为。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31469">#31469</a></li>
<li>{emoji:1f310} 国际化
<ul>
<li>{emoji:1f1f7_1f1fa} 更新 ru_RU 中 Image 字段。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31448">#31448</a> <a href="https://github.com/KirillSBarsukov"><code>@​KirillSBarsukov</code></a></li>
<li>{emoji:1f1e9_1f1f0} 补充 da_DK 中 Table 文案。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31486">#31486</a> <a href="https://github.com/bischmlb"><code>@​bischmlb</code></a></li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.16.9</h2>
<p><code>2021-07-27</code></p>
<ul>
<li>{emoji:1f41e} Fix Typography <code>ellipsis</code> calculation bug when browser zoomed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31449">#31449</a></li>
<li>{emoji:1f484} Fix Input wrong class when using <code>prefixCls</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31479">#31479</a> <a href="https://github.com/spawnia"><code>@​spawnia</code></a></li>
<li>{emoji:1f484} Fix Input.Password unexpected focus style of error status. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31456">#31456</a></li>
<li>{emoji:1f484} Fix Badge color transition issue when toggle visibility. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31458">#31458</a></li>
<li>{emoji:1f484} Fix Tabs <code>tabBarGutter</code> abnormal style behaviors. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31469">#31469</a></li>
<li>{emoji:1f310} Internationalization
<ul>
<li>{emoji:1f1f7_1f1fa} Update translation for Image in ru_RU. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31448">#31448</a> <a href="https://github.com/KirillSBarsukov"><code>@​KirillSBarsukov</code></a></li>
<li>{emoji:1f1e9_1f1f0} Add missing translation for Table in da_DK. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31486">#31486</a> <a href="https://github.com/bischmlb"><code>@​bischmlb</code></a></li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="4a9f82e289"><code>4a9f82e</code></a> docs: update changelog date</li>
<li><a href="ace54fcceb"><code>ace54fc</code></a> docs: Update index.en-US.md (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/31533">#31533</a>)</li>
<li><a href="a9a329d37c"><code>a9a329d</code></a> fix: deps and TypeScript types (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/31519">#31519</a>)</li>
<li><a href="c7e0cda393"><code>c7e0cda</code></a> docs: add changelog 4.16.9 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/31515">#31515</a>)</li>
<li><a href="3549554a80"><code>3549554</code></a> docs: Update typography/index.zh-CN.md (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/31506">#31506</a>)</li>
<li><a href="474ada1384"><code>474ada1</code></a> docs: Add jish resource</li>
<li><a href="9fd2940fdd"><code>9fd2940</code></a> docs: update tree-select demo (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/31500">#31500</a>)</li>
<li><a href="d4d0b9be5e"><code>d4d0b9b</code></a> ci: add default.less forbid (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/31497">#31497</a>)</li>
<li><a href="5fc7396024"><code>5fc7396</code></a> feat: implemented missing table daDK locale  props (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/31486">#31486</a>)</li>
<li><a href="0431b1430a"><code>0431b14</code></a> docs(Steps): responsive doc (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/31490">#31490</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.16.8...4.16.9">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.16.8&new-version=4.16.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2645

Reviewed By: timur-valiev

Differential Revision: D30012637

Pulled By: passy

fbshipit-source-id: 5ebdb3f8bb6c8ec727d0296c2be96128947e0c93
2021-08-02 07:17:01 -07:00
dependabot[bot]
38b87f784f Bump rsocket-flowable from 0.0.25 to 0.0.27 in /desktop (#2647)
Summary:
Bumps [rsocket-flowable](https://github.com/rsocket/rsocket-js) from 0.0.25 to 0.0.27.
<details>
<summary>Commits</summary>
<ul>
<li><a href="23da9b0e93"><code>23da9b0</code></a> v0.0.27</li>
<li><a href="067dde0837"><code>067dde0</code></a> fixes format</li>
<li><a href="9b712e9db1"><code>9b712e9</code></a> updates version</li>
<li><a href="6e2617fff6"><code>6e2617f</code></a> v0.0.26</li>
<li><a href="3961e7febe"><code>3961e7f</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rsocket/rsocket-js/issues/149">https://github.com/facebook/flipper/issues/149</a> from rsocket/feature/scripts-support-windows</li>
<li><a href="002c6d3372"><code>002c6d3</code></a> fix: update scripts to support windows</li>
<li><a href="97ab802352"><code>97ab802</code></a> adds README to each published sub package (<a href="https://github-redirect.dependabot.com/rsocket/rsocket-js/issues/147">https://github.com/facebook/flipper/issues/147</a>)</li>
<li><a href="1d9e675483"><code>1d9e675</code></a> changes build status badge</li>
<li><a href="db50a84b0f"><code>db50a84</code></a> migrates to GHA (<a href="https://github-redirect.dependabot.com/rsocket/rsocket-js/issues/145">https://github.com/facebook/flipper/issues/145</a>)</li>
<li><a href="b994f7d6b0"><code>b994f7d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rsocket/rsocket-js/issues/139">https://github.com/facebook/flipper/issues/139</a> from rsocket/replace-fbjs-round-3</li>
<li>Additional commits viewable in <a href="https://github.com/rsocket/rsocket-js/compare/v0.0.25...v0.0.27">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=rsocket-flowable&package-manager=npm_and_yarn&previous-version=0.0.25&new-version=0.0.27)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2647

Reviewed By: timur-valiev

Differential Revision: D30012638

Pulled By: passy

fbshipit-source-id: 27f91f3347b7919d150f3691a705368d217c6a07
2021-08-02 05:36:00 -07:00
dependabot[bot]
b742a3c200 Bump globby from 11.0.4 to 12.0.0 in /desktop (#2631)
Summary:
Bumps [globby](https://github.com/sindresorhus/globby) from 11.0.4 to 12.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sindresorhus/globby/releases">globby's releases</a>.</em></p>
<blockquote>
<h2>v12.0.0</h2>
<h3>Breaking</h3>
<ul>
<li>Require Node.js 12.20 (<a href="https://github-redirect.dependabot.com/sindresorhus/globby/issues/181">https://github.com/facebook/flipper/issues/181</a>)  5c32b4a</li>
<li>This package is now pure ESM. Please <a href="https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c">read this</a>.</li>
<li>This package now uses named exports instead of a default export
<ul>
<li><code>globby</code> → <code>{globby}</code></li>
<li><code>globby.sync</code> → <code>{globbySync}</code></li>
<li><code>globby.stream</code> → <code>{globbyStream}</code></li>
<li><code>globby.generateGlobTasks</code> → <code>{generateGlobTasks}</code></li>
<li><code>globby.hasMagic</code> → <code>{isDynamicPattern}</code></li>
<li><code>globby.gitignore</code> → <code>{isGitIgnored}</code></li>
<li><code>globby.gitignore.sync</code> → <code>{isGitIgnoredSync}</code></li>
</ul>
</li>
</ul>
<pre lang="diff"><code>-const globby = require('globby');
+import {globby} from 'globby';
</code></pre>
<p><a href="https://github.com/sindresorhus/globby/compare/v11.0.4...v12.0.0">https://github.com/sindresorhus/globby/compare/v11.0.4...v12.0.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="24453e6bff"><code>24453e6</code></a> 12.0.0</li>
<li><a href="662cafc794"><code>662cafc</code></a> Minor tweaks</li>
<li><a href="5c32b4ab94"><code>5c32b4a</code></a> Require Node.js 12.20 and move to ESM (<a href="https://github-redirect.dependabot.com/sindresorhus/globby/issues/181">https://github.com/facebook/flipper/issues/181</a>)</li>
<li>See full diff in <a href="https://github.com/sindresorhus/globby/compare/v11.0.4...v12.0.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=globby&package-manager=npm_and_yarn&previous-version=11.0.4&new-version=12.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2631

Reviewed By: timur-valiev

Differential Revision: D30012641

Pulled By: passy

fbshipit-source-id: e37e70084e8169d567361e22acce44848ef7d2c6
2021-08-02 05:36:00 -07:00
Lorenzo Blasa
d0a0f1bc5b WebSocket server
Summary:
WebSocket implementation of ServerAdapter.

About the setup payload:

RSocket uses a setup payload sent by the client when the initial handshake takes place.

WebSocket handshake doesn't use one.

Instead, it is proposed to use the URL query string to embed any arguments that the server may require to correctly identify and verify a client.

This is the case for the existing Browser WebSocket server.

The only extra adjustment was made for the CSR, proposed to be Base64 encoded.
There's no particular reason to Base64 encode it, as it was already tested by simply escaping any necessary characters.

I feel Base64 adds a layer of simple obfuscation that although doesn't offer any security, it abstracts the content to the URL reader.

The only concern was about the URL maximum length. It seems to be accepted that URL lengths should be at most 2048 characters.

Also, it seems to be the case that the PEM encoded public key size is 451 characters.

That, combined with all the extra necessary arguments, the final URL seem to fit well within the 2048 characters limit.

Reviewed By: passy

Differential Revision: D30014341

fbshipit-source-id: f3e13754b9e513eb84473e45de03f9e101c73862
2021-08-02 02:44:20 -07:00
Pascal Hartig
dc1cf7a3e3 Lint for british spelling
Summary:
I hate when I have to comment on a diff and tell somebody to please not use
Her Majesty's Spelling, so I'll let the computer do the shouting.

Mixing two ways of spelling the same thing just isn't fun. I had to
work with an Android library that insisted on spelling it `colour`,
leading to awkward code like `colour: COLORS.BLUE` which is just annoying
and hard to remember.

Reviewed By: lblasa

Differential Revision: D30015807

fbshipit-source-id: 9f913e72617301273dbe12c60b9cdba8cea05537
2021-07-30 12:44:06 -07:00
dependabot[bot]
2f5f004425 Bump ansi-to-html from 0.6.15 to 0.7.1 in /desktop (#2650)
Summary:
Bumps [ansi-to-html](https://github.com/rburns/ansi-to-html) from 0.6.15 to 0.7.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/rburns/ansi-to-html/commits">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ansi-to-html&package-manager=npm_and_yarn&previous-version=0.6.15&new-version=0.7.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2650

Reviewed By: timur-valiev

Differential Revision: D30012636

Pulled By: passy

fbshipit-source-id: 5ddb58e6a84803bea166ce93d1335ed083ba4437
2021-07-30 09:22:04 -07:00
Lorenzo Blasa
2a39738ece ServerController switch to use the refactored components
Summary:
This is the change that will pull the previous diffs together by making ServerController use the refactored components.

There are no logical changes.

The only additions are the ServerEventsListener interface implementation that re-use logic that was previously scattered around this same type.

Reviewed By: passy

Differential Revision: D29989270

fbshipit-source-id: 9ed7ff84ae8cd8ca46fad0db0737456eb705241c
2021-07-30 06:04:16 -07:00
Lorenzo Blasa
0f37d488bb ServerFactory to be used to create server instances for Flipper to use
Summary:
ServerController creates, configures, and contains any necessary servers to be used by Flipper.

ServerFactory is added as a means to abstract the creation of servers from it.

Reviewed By: passy

Differential Revision: D29987328

fbshipit-source-id: ff60a408710dbd51ea28ff27a9f85c0020741f4b
2021-07-30 05:08:37 -07:00
Lorenzo Blasa
5c99170abd WebSocket-based server, base class and browser
Summary:
Introduce a base class for WebSocket based servers and a Browser-based implementation which is in use by Kite.

The implementation for the Browser-based one is basically taken as is from ServerController but slightly adapted to match the existing interface.

As with the RSocket-based implementation, this diff doesn't put this implementation into use but is a good opportunity to revisit the existing implementation.

Reviewed By: passy

Differential Revision: D29985886

fbshipit-source-id: 32abba37ec31478b6497ef5cfe90bb9aedc282d3
2021-07-30 02:01:16 -07:00
Lorenzo Blasa
6c72e78d04 RSocket server
Summary:
RSocket server which implements the ServerAdapter interface.

Most of the code was taken from the ServerController class with a few minor adjustments.

Once ServerController starts using ServerAdapter instances the code will be removed from there.

Reviewed By: fabiomassimo

Differential Revision: D29984578

fbshipit-source-id: e35e7635dff995314b3c1fbc85177f90384e025d
2021-07-29 03:20:31 -07:00
Lorenzo Blasa
b0e47bf75e Introduce ServerAdapter
Summary:
Introduce ServerAdapter which should be used as a base class for different server implementations e.g. RSocket, WebSocket.

The type is not used elsewhere at this point but this is a good chance to look at the API and suggest changes and/or improvements.

Reviewed By: passy

Differential Revision: D29958434

fbshipit-source-id: 50ba46332d40e836b0a87bcf354d3237bf8fe7c5
2021-07-28 08:05:56 -07:00
Flipper Bot
dd880b3ba9 Flipper Release: v0.100.0
Summary: Releasing version 0.100.0

Reviewed By: cekkaewnumchai

Differential Revision: D29958236

fbshipit-source-id: d1dabc4537b9691196d61d9c1a200cf6c8a86725
2021-07-28 04:05:49 -07:00
Lorenzo Blasa
554f8146d7 Extracting utility methods
Summary:
Extract the following utility functions from ServerController:

transformCertificateExchangeMediumToType
appNameWithUpdateHint

The functions are not tied to the ServerController and will be used outside of it.

Reviewed By: passy

Differential Revision: D29938355

fbshipit-source-id: ea489f54a3a6bf46ae4e108579d48ede1f891093
2021-07-27 12:21:02 -07:00
Pascal Hartig
27eaf4f03d Tuesday dep bump
Summary:
allow-large-files
Got a ton of open bumps in GitHub. Want to address a bunch of them in one swoop.

Reviewed By: jknoxville, nikoant

Differential Revision: D29933570

fbshipit-source-id: d5dc18fab22e8c5b300ab318e60dd1514aecfd52
2021-07-27 11:42:46 -07:00
Lorenzo Blasa
204c075782 Move BrowserClientFlipperConnection to a better location
Summary:
Move BrowserClientFlipperConnection to a better location.

All communication types should be located inside the comms/ directory.

Reviewed By: jknoxville

Differential Revision: D29937942

fbshipit-source-id: 7fbf92c60d53a8f4f16d738bcbd6c451ce367ff1
2021-07-27 10:00:52 -07:00