1b2d7b9f610439e79e992f05f801c81d5508ab1c
1730 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
1b2d7b9f61 |
Flipper Release: v0.105.0
Summary: Releasing version 0.105.0 Reviewed By: lblasa Differential Revision: D30694560 fbshipit-source-id: 0427c4d1d4b34345661472cce5a6e256a31f0f95 |
||
|
|
bd8912080b |
Kill IPC rendering / connection
Summary: Remove IPC rendering / connection implementation. This has been behind GK for a couple of weeks, and no one complained / white listed. See also D30367413. flipper_js_client_emulator Reviewed By: passy Differential Revision: D30452442 fbshipit-source-id: fbe7b4914fecc023f3ec78a027106ea32c5a99bd |
||
|
|
6383c0c15f |
Bump @babel/parser from 7.14.9 to 7.15.3 in /desktop (#2724)
Summary: Bumps [babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.14.9 to 7.15.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@babel/parser</code>'s releases</a>.</em></p> <blockquote> <h2>v7.15.3 (2021-08-11)</h2> <p>Thanks <a href="https://github.com/dhrubesh"><code>@dhrubesh</code></a> and <a href="https://github.com/doing-art"><code>@doing-art</code></a> for your first PRs!</p> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-helpers</code>, <code>babel-plugin-transform-classes</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13571">#13571</a> Derived constructors should not be allowed to return primitives (<a href="https://github.com/dhrubesh"><code>@dhrubesh</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13659">#13659</a> Fix parse error when using named import "as" with flow parser (<a href="https://github.com/doing-art"><code>@doing-art</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13655">#13655</a> [flow] Fix parsing of arrows in conditional expressions in parentheses (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13645">#13645</a> Disallow <code><T>(a => b)</code> when parsing Flow (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13657">#13657</a> fix(parser): add <code>attachComment</code> to <code>ParserOptions</code> type (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13643">#13643</a> Use <code>babel/eslint-parser/experimental-worker</code> for our own repo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> <h4>🏃♀️ Performance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13652">#13652</a> perf: minor tokenizer tweaks (<a href="https://github.com/lightmare"><code>@lightmare</code></a>)</li> </ul> </li> <li><code>babel-register</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13654">#13654</a> Reduce stat calls in register (<a href="https://github.com/overlookmotel"><code>@overlookmotel</code></a>)</li> </ul> </li> </ul> <h4>Committers: 7</h4> <ul> <li>Bogdan Savluk (<a href="https://github.com/zxbodya"><code>@zxbodya</code></a>)</li> <li>DIO (<a href="https://github.com/dhrubesh"><code>@dhrubesh</code></a>)</li> <li>Mickey Rose (<a href="https://github.com/lightmare"><code>@lightmare</code></a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li>Sosuke Suzuki (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> <li><a href="https://github.com/doing-art"><code>@doing-art</code></a></li> <li><a href="https://github.com/overlookmotel"><code>@overlookmotel</code></a></li> </ul> <h2>v7.15.2 (2021-08-08)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13653">#13653</a> Add <code>.errors</code> to the <code>babel/parser</code> return type definitions (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13641">#13641</a> Fix array destructuring elision parsing in TS arrow functions (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>Committers: 3</h4> <ul> <li>Babel Bot (<a href="https://github.com/babel-bot"><code>@babel-bot</code></a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li>Sosuke Suzuki (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> </ul> <h2>v7.15.1 (2021-08-05)</h2> <p>This patch is a revert for a regression that affects React Native users - <a href="https://github-redirect.dependabot.com/facebook/react-native/issues/31960">facebook/react-native#31960</a></p> <h4>↩️ Revert</h4> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/parser</code>'s changelog</a>.</em></p> <blockquote> <h2>v7.15.3 (2021-08-11)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-helpers</code>, <code>babel-plugin-transform-classes</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13571">#13571</a> Derived constructors should not be allowed to return primitives (<a href="https://github.com/dhrubesh"><code>@dhrubesh</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13659">#13659</a> Fix parse error when using named import "as" with flow parser (<a href="https://github.com/doing-art"><code>@doing-art</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13655">#13655</a> [flow] Fix parsing of arrows in conditional expressions in parentheses (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13645">#13645</a> Disallow <code><T>(a => b)</code> when parsing Flow (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13657">#13657</a> fix(parser): add <code>attachComment</code> to <code>ParserOptions</code> type (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13643">#13643</a> Use <code>babel/eslint-parser/experimental-worker</code> for our own repo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> <h4>🏃♀️ Performance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13652">#13652</a> perf: minor tokenizer tweaks (<a href="https://github.com/lightmare"><code>@lightmare</code></a>)</li> </ul> </li> <li><code>babel-register</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13654">#13654</a> Reduce stat calls in register (<a href="https://github.com/overlookmotel"><code>@overlookmotel</code></a>)</li> </ul> </li> </ul> <h2>v7.15.2 (2021-08-08)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13653">#13653</a> Add <code>.errors</code> to the <code>babel/parser</code> return type definitions (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13641">#13641</a> Fix array destructuring elision parsing in TS arrow functions (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h2>v7.15.1 (2021-08-05)</h2> <h4>↩️ Revert</h4> <ul> <li><code>babel-plugin-transform-react-display-name</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13637">#13637</a> Revert "Add display name after create context (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-parser/issues/13501">#13501</a>)" (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h2>v7.15.0 (2021-08-04)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13523">#13523</a> feat(ts): raise error for abstract property with initializer (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> </ul> <h4>🚀 New Feature</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13229">#13229</a> Add <code>attachComment</code> parser option to disable comment attachment (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13476">#13476</a> standalone: update <code>preset-stage-*</code> (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13555">#13555</a> feat: support hack pipeline in <code>babel/standalone</code> (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13387">#13387</a> Enable top-level <code>await</code> parsing by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code>, <code>babel-preset-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13324">#13324</a> Support TypeScript const enums (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13528">#13528</a> feat(typescript): implement namespace alias (<a href="https://github.com/colinaaa"><code>@colinaaa</code></a>)</li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
9e8ec02bf7 |
Remove idb describe querying
Summary: This can cause a lot of spam in the logs (locally, doesn't log as errors) and we've now found that `idb connect` is a better way to support remote devices. See https://docs.google.com/document/d/1Ih5eCyisMIzgKSJV6xichUBJMiioSJltcJCh6LCLecg/edit#bookmark=id.zhwvc6wk2bbz for more information. Reviewed By: fabiomassimo Differential Revision: D30546664 fbshipit-source-id: 066ea7f2eef6f82d8d6ce70db44313472b637768 |
||
|
|
89d7e17c26 |
Fix local CSR lookup
Summary: From what I can tell, `idb file pull` seems to behave slightly differently for simulators. When pulling from a remote simulator, it appears to first create a directory for the local destination causing the read in line 508 to as it is trying to read the *folder* `app.csr` not `app.csr/app.csr`. By omitting the destination file name, we avoid this behaviour. Reviewed By: fabiomassimo Differential Revision: D30541778 fbshipit-source-id: 851398aed5fd350a68ba0686707ce0f0aa09672c |
||
|
|
120788413f |
Flipper Release: v0.104.0
Summary: Releasing version 0.104.0 Reviewed By: passy Differential Revision: D30543476 fbshipit-source-id: a38f16d4928575c76a39da3c02812feb4620178e |
||
|
|
fa8827c103 |
Bump deps (#2736)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/2736 This should fix a bunch of open dependabot issues on GitHub. Reviewed By: fabiomassimo Differential Revision: D30539761 fbshipit-source-id: b355d41336b3b1d85b50fb0736fc1b33b12e83d0 |
||
|
|
b601ff5a09 |
Fix crash on missing children
Summary: T98487412 is firing again. This seems to be an expected case that's not handled correctly. thinkofthechildren Reviewed By: fabiomassimo Differential Revision: D30539615 fbshipit-source-id: d9625bb0a7b3622e5afb6e768bc525c27fdfb02d |
||
|
|
87580c4147 |
Fix build (#2735)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/2735 GitHub has been failing because an ant patch no longer applies. Reviewed By: jknoxville Differential Revision: D30539463 fbshipit-source-id: b16b4d04a366a4af8d0efe36856a4b565aeeecbd |
||
|
|
fa7628fbf4 |
Auto detect devices/apps and fetch plugin details (#2734)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/2734 This diff is the third out of n for the troubleshooting guide for flipper. What has been done - - Added autodetect and select for devices and apps. The user can now select these from the dropdown. - Added functions to get failed plugins from the store and the list of available plugins and their details. - This data will be used in future diffs to preprocess which state/question to redirect the user to. - Unit tests for this section will be added once the preprocessing is completed in the next diff. Right now the function just returns the plugin name itself. It will essentially return the state to toggle to in the future. NOTE - The location of the guide on the first screen of flipper has also been moved after discussion. The guide is now always open to select irrespective of devices connecting or not. Presently this is how the button is rendered. - Public build/ internal build when user is not in allowlist of the gatekeeper {F655248582} It does not appear in the public build once a device is detected {F655248769} - Internal build when user is in the allowlist {F655249521} Reviewed By: passy Differential Revision: D30450347 fbshipit-source-id: 68b4b311e913ebd82055acf7a3a581825246f4ed |
||
|
|
1304e7c5d7 |
Monday patch dep bump
Summary: allow-large-files Only patch bumps of >1.0.0, should be safe. Reviewed By: jknoxville Differential Revision: D30482302 fbshipit-source-id: b5f331822ba6931b6e5f68190c7d50c62611a153 |
||
|
|
fce7c7a32a |
Disable flaky test (#2711)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/2711 See failure in T98765066. Disabling for now. Reviewed By: nikoant Differential Revision: D30481963 fbshipit-source-id: 555295bbab33629250b53a194de37038fea2198a |
||
|
|
30d5170dee |
Fix lints in CertificateProvider
Summary:
Some of them got re-introduced after rebasing D30411434 (
|
||
|
|
e5404d2af3 |
Add linter for sync function calls
Summary: That's another thing I comment on a lot and is a mostly avoidable source of bad perf. Reviewed By: mweststrate Differential Revision: D30450577 fbshipit-source-id: bb82d8cbd34956fa790243f59cda09ff9c4e7379 |
||
|
|
f60429cab5 |
Small refactors in CertificateProvider
Summary: - Remove `fs` dependency in favour of `fs-extra`. - Replaced `Sync` variants with async wherever possible. - Removed some unnecessary Promise constructions. Reviewed By: timur-valiev Differential Revision: D30411434 fbshipit-source-id: 9faebbc1f9fb2283fec895ce3397918bc85a6c51 |
||
|
|
a2644b4a2e |
handle device / client absence for deeplinks
Summary: This diff makes the new deeplink format feature complete, make sure VPN connection, plugin installation, client & device selection are now all handled. See the test plan for examples. Changelog: Flipper now supports a richer protocol for opening deeplinks: https://fbflipper.com/docs/extending/deeplinks#open-plugin Reviewed By: timur-valiev Differential Revision: D30423809 fbshipit-source-id: e6cf4bf852b2c64e9a79a33ef0842eb27f68f840 |
||
|
|
846246ffae |
Introduce options dialog, cleaned up state managament
Summary: Made it easier to build 'pick' dialogs, and introduced Dialogs.options for a set of radio buttions Reviewed By: timur-valiev Differential Revision: D30424708 fbshipit-source-id: 98abd0d64f47c552c81053b4433e5fc524574145 |
||
|
|
419497db7e |
Bump @babel/preset-env from 7.14.9 to 7.15.0 in /desktop (#2696)
Summary: Bumps [babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.14.9 to 7.15.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@babel/preset-env</code>'s releases</a>.</em></p> <blockquote> <h2>v7.15.0 (2021-08-04)</h2> <p>Thanks <a href="https://github.com/a-tarasyuk"><code>@a-tarasyuk</code></a> and <a href="https://github.com/gausie"><code>@gausie</code></a> for your first PRs!</p> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13523">#13523</a> feat(ts): raise error for abstract property with initializer (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> </ul> <h4>🚀 New Feature</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13229">#13229</a> Add <code>attachComment</code> parser option to disable comment attachment (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13476">#13476</a> standalone: update <code>preset-stage-*</code> (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13555">#13555</a> feat: support hack pipeline in <code>babel/standalone</code> (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13387">#13387</a> Enable top-level <code>await</code> parsing by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code>, <code>babel-preset-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13324">#13324</a> Support TypeScript const enums (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13528">#13528</a> feat(typescript): implement namespace alias (<a href="https://github.com/colinaaa"><code>@colinaaa</code></a>)</li> </ul> </li> <li><code>babel-core</code>, <code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-modules-commonjs</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13290">#13290</a> feat: add <code>noIncompleteNsImportDetection</code> assumption to <code>plugin-transform-modules-commonjs</code> (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-react-display-name</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13501">#13501</a> Add display name after create context (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13416">#13416</a> Hack-pipe proposal with <code>%</code> topic token (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13191">#13191</a> Add support for the "Hack" pipeline proposal (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-runtime</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13398">#13398</a> Expose <code>babel/eslint-parser/experimental-worker</code> (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-helper-compilation-targets</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13448">#13448</a> Add support for rhino as a compilation target (<a href="https://github.com/gausie"><code>@gausie</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13554">#13554</a> Enable ergonomic brand checks (<code>#priv in</code>) by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code>, <code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13513">#13513</a> [ts] support optional chain call with generic (<a href="https://github.com/lala7573"><code>@lala7573</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13605">#13605</a> Handle typescript function overloading in a default export (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13536">#13536</a> Fix <code>%==</code> parsing in hack pipes (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13426">#13426</a> parser: Fix Hack/smart-pipe error positions (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13622">#13622</a> fix(ts): raise error for <code>export default interface {}</code> (<a href="https://github.com/a-tarasyuk"><code>@a-tarasyuk</code></a>)</li> </ul> </li> </ul> <h4>📝 Documentation</h4> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13607">#13607</a> chore(doc): add jest specific pckg command (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> <h4>Committers: 10</h4> <ul> <li>Federico Ciardi (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/preset-env</code>'s changelog</a>.</em></p> <blockquote> <h2>v7.15.0 (2021-08-04)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13523">#13523</a> feat(ts): raise error for abstract property with initializer (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> </ul> <h4>🚀 New Feature</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13229">#13229</a> Add <code>attachComment</code> parser option to disable comment attachment (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13476">#13476</a> standalone: update <code>preset-stage-*</code> (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13555">#13555</a> feat: support hack pipeline in <code>babel/standalone</code> (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13387">#13387</a> Enable top-level <code>await</code> parsing by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code>, <code>babel-preset-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13324">#13324</a> Support TypeScript const enums (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13528">#13528</a> feat(typescript): implement namespace alias (<a href="https://github.com/colinaaa"><code>@colinaaa</code></a>)</li> </ul> </li> <li><code>babel-core</code>, <code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-modules-commonjs</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13290">#13290</a> feat: add <code>noIncompleteNsImportDetection</code> assumption to <code>plugin-transform-modules-commonjs</code> (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-react-display-name</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13501">#13501</a> Add display name after create context (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13416">#13416</a> Hack-pipe proposal with <code>%</code> topic token (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13191">#13191</a> Add support for the "Hack" pipeline proposal (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-runtime</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13398">#13398</a> Expose <code>babel/eslint-parser/experimental-worker</code> (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-helper-compilation-targets</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13448">#13448</a> Add support for rhino as a compilation target (<a href="https://github.com/gausie"><code>@gausie</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13554">#13554</a> Enable ergonomic brand checks (<code>#priv in</code>) by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code>, <code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13513">#13513</a> [ts] support optional chain call with generic (<a href="https://github.com/lala7573"><code>@lala7573</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13605">#13605</a> Handle typescript function overloading in a default export (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13536">#13536</a> Fix <code>%==</code> parsing in hack pipes (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13426">#13426</a> parser: Fix Hack/smart-pipe error positions (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13622">#13622</a> fix(ts): raise error for <code>export default interface {}</code> (<a href="https://github.com/a-tarasyuk"><code>@a-tarasyuk</code></a>)</li> </ul> </li> </ul> <h4>📝 Documentation</h4> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13607">#13607</a> chore(doc): add jest specific pckg command (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
ebe5e7f9ff |
Make CertificateProvider side effect free in test (#2706)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/2706 Creating a CertificateProvider in test had the side effect of generating certificate files, which fails in windows CI. This change makes sure the files aren't generated in test. See https://github.com/facebook/flipper/runs/3366318523. Since it is not possible to start the flipper server 'physically' without writing file (for the secure server), figured to remove the test entirely, since there is high impact but little risk captured by it; if the server doesn't start, *any* manual / exploratory test will fail. Reviewed By: lblasa Differential Revision: D30423173 fbshipit-source-id: e411cc61df04120a7132983e9f8d3d140e4ca048 |
||
|
|
648e281377 |
Revert D30393320 and restructure fb only and public versions (#2703)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2703
- This diff reverts the following diff - D30393320 (
|
||
|
|
f4631eecc1 |
Flipper Release: v0.103.0
Summary: Releasing version 0.103.0 Reviewed By: passy Differential Revision: D30400660 fbshipit-source-id: e5d3e2e59c977e1e5a32945fffaba243c703823e |
||
|
|
393e47641b |
Asyncify complex promise function
Summary: Linter flagged this as it's using promises inside promises. This is a bit easier to read. Reviewed By: timur-valiev Differential Revision: D30402783 fbshipit-source-id: aee7dedc4468538bceec4fc64379f8b2d89a660c |
||
|
|
45ce538c8d |
Bump @babel/eslint-parser from 7.14.9 to 7.15.0 in /desktop (#2699)
Summary: Bumps [babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) from 7.14.9 to 7.15.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@babel/eslint-parser</code>'s releases</a>.</em></p> <blockquote> <h2>v7.15.0 (2021-08-04)</h2> <p>Thanks <a href="https://github.com/a-tarasyuk"><code>@a-tarasyuk</code></a> and <a href="https://github.com/gausie"><code>@gausie</code></a> for your first PRs!</p> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13523">#13523</a> feat(ts): raise error for abstract property with initializer (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> </ul> <h4>🚀 New Feature</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13229">#13229</a> Add <code>attachComment</code> parser option to disable comment attachment (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13476">#13476</a> standalone: update <code>preset-stage-*</code> (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13555">#13555</a> feat: support hack pipeline in <code>babel/standalone</code> (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13387">#13387</a> Enable top-level <code>await</code> parsing by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code>, <code>babel-preset-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13324">#13324</a> Support TypeScript const enums (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13528">#13528</a> feat(typescript): implement namespace alias (<a href="https://github.com/colinaaa"><code>@colinaaa</code></a>)</li> </ul> </li> <li><code>babel-core</code>, <code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-modules-commonjs</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13290">#13290</a> feat: add <code>noIncompleteNsImportDetection</code> assumption to <code>plugin-transform-modules-commonjs</code> (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-react-display-name</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13501">#13501</a> Add display name after create context (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13416">#13416</a> Hack-pipe proposal with <code>%</code> topic token (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13191">#13191</a> Add support for the "Hack" pipeline proposal (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-runtime</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13398">#13398</a> Expose <code>babel/eslint-parser/experimental-worker</code> (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-helper-compilation-targets</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13448">#13448</a> Add support for rhino as a compilation target (<a href="https://github.com/gausie"><code>@gausie</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13554">#13554</a> Enable ergonomic brand checks (<code>#priv in</code>) by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code>, <code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13513">#13513</a> [ts] support optional chain call with generic (<a href="https://github.com/lala7573"><code>@lala7573</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13605">#13605</a> Handle typescript function overloading in a default export (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13536">#13536</a> Fix <code>%==</code> parsing in hack pipes (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13426">#13426</a> parser: Fix Hack/smart-pipe error positions (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13622">#13622</a> fix(ts): raise error for <code>export default interface {}</code> (<a href="https://github.com/a-tarasyuk"><code>@a-tarasyuk</code></a>)</li> </ul> </li> </ul> <h4>📝 Documentation</h4> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13607">#13607</a> chore(doc): add jest specific pckg command (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> <h4>Committers: 10</h4> <ul> <li>Federico Ciardi (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/eslint-parser</code>'s changelog</a>.</em></p> <blockquote> <h2>v7.15.0 (2021-08-04)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13523">#13523</a> feat(ts): raise error for abstract property with initializer (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> </ul> <h4>🚀 New Feature</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13229">#13229</a> Add <code>attachComment</code> parser option to disable comment attachment (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13476">#13476</a> standalone: update <code>preset-stage-*</code> (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13555">#13555</a> feat: support hack pipeline in <code>babel/standalone</code> (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13387">#13387</a> Enable top-level <code>await</code> parsing by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code>, <code>babel-preset-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13324">#13324</a> Support TypeScript const enums (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13528">#13528</a> feat(typescript): implement namespace alias (<a href="https://github.com/colinaaa"><code>@colinaaa</code></a>)</li> </ul> </li> <li><code>babel-core</code>, <code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-modules-commonjs</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13290">#13290</a> feat: add <code>noIncompleteNsImportDetection</code> assumption to <code>plugin-transform-modules-commonjs</code> (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-react-display-name</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13501">#13501</a> Add display name after create context (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13416">#13416</a> Hack-pipe proposal with <code>%</code> topic token (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13191">#13191</a> Add support for the "Hack" pipeline proposal (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-runtime</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13398">#13398</a> Expose <code>babel/eslint-parser/experimental-worker</code> (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-helper-compilation-targets</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13448">#13448</a> Add support for rhino as a compilation target (<a href="https://github.com/gausie"><code>@gausie</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13554">#13554</a> Enable ergonomic brand checks (<code>#priv in</code>) by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code>, <code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13513">#13513</a> [ts] support optional chain call with generic (<a href="https://github.com/lala7573"><code>@lala7573</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13605">#13605</a> Handle typescript function overloading in a default export (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13536">#13536</a> Fix <code>%==</code> parsing in hack pipes (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13426">#13426</a> parser: Fix Hack/smart-pipe error positions (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13622">#13622</a> fix(ts): raise error for <code>export default interface {}</code> (<a href="https://github.com/a-tarasyuk"><code>@a-tarasyuk</code></a>)</li> </ul> </li> </ul> <h4>📝 Documentation</h4> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13607">#13607</a> chore(doc): add jest specific pckg command (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
68670e7698 |
Bump @babel/plugin-transform-modules-commonjs from 7.14.5 to 7.15.0 in /desktop (#2698)
Summary: Bumps [babel/plugin-transform-modules-commonjs](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-modules-commonjs) from 7.14.5 to 7.15.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@babel/plugin-transform-modules-commonjs</code>'s releases</a>.</em></p> <blockquote> <h2>v7.15.0 (2021-08-04)</h2> <p>Thanks <a href="https://github.com/a-tarasyuk"><code>@a-tarasyuk</code></a> and <a href="https://github.com/gausie"><code>@gausie</code></a> for your first PRs!</p> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13523">#13523</a> feat(ts): raise error for abstract property with initializer (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> </ul> <h4>🚀 New Feature</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13229">#13229</a> Add <code>attachComment</code> parser option to disable comment attachment (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13476">#13476</a> standalone: update <code>preset-stage-*</code> (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13555">#13555</a> feat: support hack pipeline in <code>babel/standalone</code> (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13387">#13387</a> Enable top-level <code>await</code> parsing by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code>, <code>babel-preset-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13324">#13324</a> Support TypeScript const enums (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13528">#13528</a> feat(typescript): implement namespace alias (<a href="https://github.com/colinaaa"><code>@colinaaa</code></a>)</li> </ul> </li> <li><code>babel-core</code>, <code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-modules-commonjs</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13290">#13290</a> feat: add <code>noIncompleteNsImportDetection</code> assumption to <code>plugin-transform-modules-commonjs</code> (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-react-display-name</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13501">#13501</a> Add display name after create context (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13416">#13416</a> Hack-pipe proposal with <code>%</code> topic token (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13191">#13191</a> Add support for the "Hack" pipeline proposal (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-runtime</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13398">#13398</a> Expose <code>babel/eslint-parser/experimental-worker</code> (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-helper-compilation-targets</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13448">#13448</a> Add support for rhino as a compilation target (<a href="https://github.com/gausie"><code>@gausie</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13554">#13554</a> Enable ergonomic brand checks (<code>#priv in</code>) by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code>, <code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13513">#13513</a> [ts] support optional chain call with generic (<a href="https://github.com/lala7573"><code>@lala7573</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13605">#13605</a> Handle typescript function overloading in a default export (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13536">#13536</a> Fix <code>%==</code> parsing in hack pipes (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13426">#13426</a> parser: Fix Hack/smart-pipe error positions (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13622">#13622</a> fix(ts): raise error for <code>export default interface {}</code> (<a href="https://github.com/a-tarasyuk"><code>@a-tarasyuk</code></a>)</li> </ul> </li> </ul> <h4>📝 Documentation</h4> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13607">#13607</a> chore(doc): add jest specific pckg command (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> <h4>Committers: 10</h4> <ul> <li>Federico Ciardi (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/plugin-transform-modules-commonjs</code>'s changelog</a>.</em></p> <blockquote> <h2>v7.15.0 (2021-08-04)</h2> <h4>👓 Spec Compliance</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13523">#13523</a> feat(ts): raise error for abstract property with initializer (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> </ul> <h4>🚀 New Feature</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13229">#13229</a> Add <code>attachComment</code> parser option to disable comment attachment (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13476">#13476</a> standalone: update <code>preset-stage-*</code> (<a href="https://github.com/sosukesuzuki"><code>@sosukesuzuki</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13555">#13555</a> feat: support hack pipeline in <code>babel/standalone</code> (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13387">#13387</a> Enable top-level <code>await</code> parsing by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code>, <code>babel-preset-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13324">#13324</a> Support TypeScript const enums (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13528">#13528</a> feat(typescript): implement namespace alias (<a href="https://github.com/colinaaa"><code>@colinaaa</code></a>)</li> </ul> </li> <li><code>babel-core</code>, <code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-modules-commonjs</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13290">#13290</a> feat: add <code>noIncompleteNsImportDetection</code> assumption to <code>plugin-transform-modules-commonjs</code> (<a href="https://github.com/fedeci"><code>@fedeci</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-react-display-name</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13501">#13501</a> Add display name after create context (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13416">#13416</a> Hack-pipe proposal with <code>%</code> topic token (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-syntax-pipeline-operator</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13191">#13191</a> Add support for the "Hack" pipeline proposal (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-runtime</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13398">#13398</a> Expose <code>babel/eslint-parser/experimental-worker</code> (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-helper-compilation-targets</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13448">#13448</a> Add support for rhino as a compilation target (<a href="https://github.com/gausie"><code>@gausie</code></a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-parser</code>, <code>babel-preset-env</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13554">#13554</a> Enable ergonomic brand checks (<code>#priv in</code>) by default (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code>, <code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13513">#13513</a> [ts] support optional chain call with generic (<a href="https://github.com/lala7573"><code>@lala7573</code></a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13605">#13605</a> Handle typescript function overloading in a default export (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13536">#13536</a> Fix <code>%==</code> parsing in hack pipes (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13426">#13426</a> parser: Fix Hack/smart-pipe error positions (<a href="https://github.com/js-choi"><code>@js-choi</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13622">#13622</a> fix(ts): raise error for <code>export default interface {}</code> (<a href="https://github.com/a-tarasyuk"><code>@a-tarasyuk</code></a>)</li> </ul> </li> </ul> <h4>📝 Documentation</h4> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13607">#13607</a> chore(doc): add jest specific pckg command (<a href="https://github.com/tony-go"><code>@tony-go</code></a>)</li> </ul> <h2>v7.14.9 (2021-08-01)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@addaleax</code></a>)</li> </ul> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
e9bcb947dc |
Bump @typescript-eslint/parser from 4.28.5 to 4.29.1 in /desktop (#2700)
Summary: Bumps [typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.28.5 to 4.29.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/parser</code>'s releases</a>.</em></p> <blockquote> <h2>v4.29.1</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.29.0...v4.29.1">4.29.1</a> (2021-08-09)</h2> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p> <h2>v4.29.0</h2> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.28.5...v4.29.0">4.29.0</a> (2021-08-02)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [no-implied-eval] handle bind on nested member expressions (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/3598">#3598</a>) (<a href=" |
||
|
|
75c4f20c8a |
Revert "First level of questions and redirection along with unit tests" (#2702)
Summary:
This reverts commit
|
||
|
|
0cb6c0b3d2 |
Fix NPE on children expansion
Summary: See task for stack trace. Reviewed By: timur-valiev Differential Revision: D30393458 fbshipit-source-id: 71589b42fd579db95dfb04a96a00966f8bc65a2a |
||
|
|
2e87164152 |
First level of questions and redirection along with unit tests
Summary: This diff is the first out of n for the troubleshooting guide for flipper. What has been done - - Defined a structure for the troubleshooting guide in TroubleshootingGuide.tsx (parent component ) to render children components or the individual questions from here. - The initial screen of the trouble shooting guide along with the 3 sections of questions users face. Clicking them prompts to individual question screens that will be built in future diffs. - Units tests in jest for the rendering of the screens and functions. Reviewed By: mweststrate Differential Revision: D30279739 fbshipit-source-id: 3e317b67e5ac461902c6779eaa584e1032741b85 |
||
|
|
0cbe063c77 |
Move UnitializedClient to server
Summary: Move UnitializedClient interface to server namespace Reviewed By: timur-valiev Differential Revision: D30367328 fbshipit-source-id: 367a607fa2bb20dd140b1ad28946073ca764e517 |
||
|
|
ea58f2b050 |
Decouple iOS devices from Store / core
Summary: Decouple iOS device detection from Redux Reviewed By: timur-valiev Differential Revision: D30309258 fbshipit-source-id: 74b4e3dd2e6b83fcefc75909794c39bfc8c987cf |
||
|
|
3736cbc480 |
Decouple JS device from Store
Summary: Made a start with decoupling JS device. Incomplete as there are still Electron deps. Reviewed By: timur-valiev Differential Revision: D30309257 fbshipit-source-id: b8002170cbbe8d68e1795ce7c12ffce4c8eac853 |
||
|
|
4ae7d9c42b |
Decouple Metro device handling from Flipper core
Summary: Decoupled metro 'device' from Redux store. Extracting some commonalities with Android device management up into FlipperServer Reviewed By: timur-valiev Differential Revision: D30309256 fbshipit-source-id: 1a9ac01e3f21d2d08761554d3644a7ae8d00a93e |
||
|
|
03f2f95a31 |
Decouple android device management from Flipper core/store
Summary: See earlier diffs in the stack. This diff decouple android device management from the Redux store, replacing it with specific events. Reviewed By: timur-valiev Differential Revision: D30286345 fbshipit-source-id: 42f52056bf123b862e2fc087f2e7130c02bdd742 |
||
|
|
bf65da0e72 |
Check if plugin status before opening
Summary: This diff takes care of current plugin status when handling deeplinks. It checks: 1. if the plugin failed to load 2. if the plugin is behind GK 3. if the plugin is installable from bundle 4. if the plugin is installable from marketplace Reviewed By: passy Differential Revision: D29875483 fbshipit-source-id: 8dac1aab63822f43a0d002b10efa5b4a756fce41 |
||
|
|
09107460a3 |
Filter duplicate requests
Summary: Right now this is throwing an error, we instead gracefully handle this. I'm not quite sure where this is coming from but as we're not really doing anything with the requests before they're added here, it must be coming from the network stack. We can't really build another stable key on the client side because we also need to match it up with the response. Open for ideas! Changelog: Network requests with duplicate IDs are filtered out Reviewed By: mweststrate Differential Revision: D30337820 fbshipit-source-id: d312833727b383fa5f4d18a506ab581cd2151d13 |
||
|
|
797007f367 |
Make error message unique
Summary: We're currently getting errors for every duplicate key and can't easily unify them, so we're adding the additional information to a warning instead. Reviewed By: mweststrate Differential Revision: D30337821 fbshipit-source-id: db9dc44d7d3424de169bed9b4447b482e411eb19 |
||
|
|
e880059167 |
Use idb describe to enumerate devices
Summary: This works for forwarded as well as local devices. There is a bunch more unification work that needs to be done here as we currently have three completely different ways of querying iOS devices. More on that next week. Reviewed By: jknoxville Differential Revision: D30308405 fbshipit-source-id: c58ac73e971ce2cc4da92e9508bc05dff9c1a95a |
||
|
|
83978f5989 |
Bump eslint-plugin-flowtype from 5.8.2 to 5.9.0 in /desktop (#2694)
Summary: Bumps [eslint-plugin-flowtype](https://github.com/gajus/eslint-plugin-flowtype) from 5.8.2 to 5.9.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/gajus/eslint-plugin-flowtype/releases">eslint-plugin-flowtype's releases</a>.</em></p> <blockquote> <h2>v5.9.0</h2> <h1><a href="https://github.com/gajus/eslint-plugin-flowtype/compare/v5.8.2...v5.9.0">5.9.0</a> (2021-08-02)</h1> <h3>Features</h3> <ul> <li>Interface Id Match rule (<a href="https://github-redirect.dependabot.com/gajus/eslint-plugin-flowtype/issues/492">https://github.com/facebook/flipper/issues/492</a>) (<a href=" |
||
|
|
781df776f2 |
Rename default branch references to main (#2689)
Summary: I really hope I hit everything and didn't break anything that wasn't referring to branch names. Pull Request resolved: https://github.com/facebook/flipper/pull/2689 Test Plan: _eyes CI |[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D30305789/V2/flipper/) Reviewed By: timur-valiev Differential Revision: D30305789 Pulled By: passy fbshipit-source-id: 5daaa09250bb96bb50be679fc01dae86c666eb73 |
||
|
|
c0cd32564a |
Organise files per device
Summary: Moved all logic per device type we support to its own dir, including tools and utilities around it, which makes it easier to consolidate logic and decouple in turn per device type. Per type, all logic can be found in `server/devices/(desktop|metro|android|ios|webapp)` Reviewed By: timur-valiev Differential Revision: D30277817 fbshipit-source-id: 2b5339c363d5d31ceeba07cec03826fc67cf3748 |
||
|
|
6175424d16 |
separate action dispatch from server
Summary: This diff moves the first small pieces of getting device detection up and running to `server/`, and the wiring between FlipperServer and flipper core / redux is setting up specific events and dispatch actions from there. Reviewed By: timur-valiev Differential Revision: D30276776 fbshipit-source-id: b30b996d03c27459815bebeb97b05b5fe5d24bec |
||
|
|
0de8a2eeb0 |
Support idb/physical devices for screen record
Summary: Another thing that's now supported by idb. Reviewed By: mweststrate Differential Revision: D30283450 fbshipit-source-id: fd973571c551b0823ba9c539c795d4dd526415b1 |
||
|
|
87e5e18c46 |
Support idb/physical devices for navigation
Summary: idb has a command for doing the same now. Reviewed By: timur-valiev Differential Revision: D30277192 fbshipit-source-id: eb46cdc7a7218077a7da90f6182d5f17bfcc758a |
||
|
|
dd47d08444 |
move device dispatchers to server
Summary: move_complexity Reviewed By: passy, timur-valiev Differential Revision: D30250314 fbshipit-source-id: 92510b0ed2555d039b75b6de1c14fc92d94fbb19 |
||
|
|
5e8c968222 |
Move devices to server folder
Summary: This is the first of many diffs that extracts the connection, device, client detection out of the flipper core, to create a reusable flipper-server library that can be used in e.g. flipper-dump. To keep diffs a little smaller, the current connection logic is first moved to the `server/` directory, and decoupled manually from the rest of the core, before moving it over to a separate package. This first diffs moves the `comms/`, `devices/` and certificate utilities to the `server` directory. Further untangling will follow in next diffs Reviewed By: timur-valiev Differential Revision: D30246551 fbshipit-source-id: c84259bfb1239119b3267a51b015e30c3c080866 |
||
|
|
6544e5a7a3 |
Fix large debugbutton numbers being cut off
Summary: One more. Reviewed By: timur-valiev Differential Revision: D30254356 fbshipit-source-id: 473532b1aeef00d95d1da0ca8f1ca047672bc432 |
||
|
|
4d295fa261 |
Prevent NUX from being cut off in plugin bar
Summary: See test plan. Reviewed By: timur-valiev Differential Revision: D30253538 fbshipit-source-id: c98a9b3ddaa29d6ff11260ce5756fd85f120e749 |
||
|
|
eb27796571 |
Fix Windows test (#2682)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/2682 Run path-specific tests only on Unix-like OSes. We could easily change the path to Windows, but honestly it's enough to confirm this on one platform. Reviewed By: timur-valiev Differential Revision: D30255014 fbshipit-source-id: 7db36bc1738d721625e3c86c210d46dfaf8f0ab8 |
||
|
|
7df77e2620 |
Asyncify screenshot helper
Summary: Suggested by mweststrate. Much more readable now! Reviewed By: mweststrate Differential Revision: D30251322 fbshipit-source-id: 269fefce3f63fa4eababb4c541ff09a660cc5cc0 |
||
|
|
757ba91bf6 |
Simplify bridge types
Summary: This turns the bridge type into a simpler struct with always-present methods so you don't need to add additional null check to the calling logic which are hard to deal with. Reviewed By: mweststrate Differential Revision: D30248628 fbshipit-source-id: cdaee44efcbb19dcbb301099b4a7d0eb0c350e67 |