Commit Graph

87 Commits

Author SHA1 Message Date
Michel Weststrate
42325e41c5 Automatically bump iOS pods
Summary: Update our pods automatically post release

Reviewed By: priteshrnandgaonkar

Differential Revision: D28283782

fbshipit-source-id: eff0b033c6704e4e46c0eb96cc4d527969ce7ccc
2021-05-07 09:41:22 -07:00
Michel Weststrate
25424ed47c Bump all Pods to latest (#2275)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2275

Forced all current pods to use the latest available. If this builds successfully, will create a PR against React Native so that they become the default, and remove them here again.

This job currently does limit the architectures we build for. Pritesh is investigating if we can wide that again, as this might not be acceptable to RN in general.

This doesn't bump the android version to 0.88, as the artifact publishing failed for that version, but since there are currently less problems with the Android version I wanted to go ahead with just iOS.

Reviewed By: cekkaewnumchai, priteshrnandgaonkar

Differential Revision: D28257283

fbshipit-source-id: a631b1c354617ed356cd1e74b9e8e8aa050eed60
2021-05-07 05:05:20 -07:00
Pascal Hartig
4a636c8e7b Update android publish task
Summary: A recent plugin upgrade removed the previous ones.

Reviewed By: cekkaewnumchai

Differential Revision: D28285219

fbshipit-source-id: e8dcb004ede225283d805b13011709c9d5f3bdae
2021-05-07 04:21:52 -07:00
Michel Weststrate
fcab54a76d Fix React Native build (#2271)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2271

Fix react native OSS build. As discussed a couple of weeks ago, we can bump deps, but cannot bump lock files during release, as artifacts are then not yet available.

We backed out from these bumps before D27764997 (98c3913b62), but that didn't seem to be sufficient. Filed T90301619 as follow up

Reviewed By: priteshrnandgaonkar

Differential Revision: D28255272

fbshipit-source-id: ee4d5b158a653c78f73b46c9ca695cfced315e56
2021-05-06 09:48:41 -07:00
Pritesh Nandgaonkar
5a69213dc3 Fixes the create pr job. (#2273)
Summary:
It fixes the GH action to create PR.

## Changelog

Updated the GH action to v3.

Pull Request resolved: https://github.com/facebook/flipper/pull/2273

Test Plan:
Check the PR created by CI
https://github.com/facebook/flipper/actions/runs/817306111
https://github.com/facebook/flipper/pull/2274/files

Reviewed By: mweststrate

Differential Revision: D28256828

Pulled By: priteshrnandgaonkar

fbshipit-source-id: c8d7a09723d6a1de1d4534891428b6dbc5be6277
2021-05-06 09:01:33 -07:00
Pritesh Nandgaonkar
e9ae8f45f9 Update all flipper transitive deps to latest versions (#2245)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2245

This diff does the following:
- Updates Folly to the latest version.
- Updates boost to latest version and the boost is added as pre built artefact
- Updates RSocket to the latest version
- Updates ComponentKit to the latest version which has a fix for XCode 12.5
- Adds Flipper-Glog dependency updated with a fix for the issue mentioned [here](https://github.com/facebook/flipper/issues/2174)
- This diff also ensures that Flipper, FlipperKit builds with Sample and SampleSwift app.
- This diff also ensures that the bug mentioned [here](https://github.com/facebook/flipper/issues/2248) is addressed.

Note: For Tutorial App to work we will have to make a release of Flipper and FlipperKit to CococaPods. Because the tutorial app refers the released version of Flipper and FlipperKit. It doesn't refer it locally.

Reviewed By: passy

Differential Revision: D28058972

fbshipit-source-id: d45dfc7315ace5d5c7d3a4ba94911fd4b58bdc31
2021-05-04 05:03:09 -07:00
Pritesh Nandgaonkar
6ba5a410a0 Update glog and doubleconversion which uses xcframework (#2153)
Summary:
This PR updates the Glog and DoubleConversion deps. Now the deps are shipped with precompiled xcframework. It will speed up our build time a bit.
The definition can be found [here for glog](https://github.com/priteshrnandgaonkar/glog/tree/update-0.3.5) and [here for double-conversion](https://github.com/priteshrnandgaonkar/double-conversion/)

There has been improvements in time. I will try to precompile folly to improve the timings significantly.

## Changelog

- Updated the Glog and DoubleConversion deps to the precompiled xcframework one
- Updated the sample app's Podfile.lock

Pull Request resolved: https://github.com/facebook/flipper/pull/2153

Test Plan:
- CI should be green
- Verified that sample app builds.

Reviewed By: mweststrate

Differential Revision: D27560567

Pulled By: priteshrnandgaonkar

fbshipit-source-id: ba295cbe84bb9d5ed6bd6ab17bd1cf5ea22f3cee
2021-04-06 06:02:47 -07:00
Pascal Hartig
77abba6459 Persist yarn cache (#2137)
Summary:
The time we spend on this isn't much. However, we quite often see flakiness coming from yarnpkg not responding which should hopefully be addressed by this.

Pull Request resolved: https://github.com/facebook/flipper/pull/2137

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D27461679

Pulled By: passy

fbshipit-source-id: c7144d2a8426c078f9cab2d3a94662908a03a182
2021-03-31 06:40:40 -07:00
Pritesh Nandgaonkar
526d985d15 Run iOS jobs on podspec changes (#2136)
Summary:
Updates the run conditions of iOS jobs so that it is triggered when we change "Flipper.podspec" and "FlipperKit.podspec"
## Changelog

- Update the run conditions

Pull Request resolved: https://github.com/facebook/flipper/pull/2136

Test Plan: CI

Reviewed By: passy

Differential Revision: D27402914

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 3b687612f26a0e22773c48540b76a7660bb29ed6
2021-03-29 11:41:34 -07:00
Pritesh Nandgaonkar
d22e893169 Update the run logic of iOS jobs (#2118)
Summary:
This PR updates the logic when these iOS jobs should be run. This change just makes it run for pushes to iOS folders and xplat c++ folders.

## Changelog

- Update the GH action.

Pull Request resolved: https://github.com/facebook/flipper/pull/2118

Test Plan: Note that no iOS job is run.

Reviewed By: mweststrate

Differential Revision: D27395681

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 37a7c2fb9b3fdfa22307ac5e7403364bfeb0a384
2021-03-29 06:57:10 -07:00
Pascal Hartig
1d67dd8a9f Remove pod bumps without flipperkit_version (#2117)
Summary:
Sample and SampleSwift directly link to the debug version and don't reference `flipperkit_version` which is why the script is failing.

Pull Request resolved: https://github.com/facebook/flipper/pull/2117

Test Plan: hopeitwork

Reviewed By: priteshrnandgaonkar

Differential Revision: D27395244

Pulled By: passy

fbshipit-source-id: 3485731b0489376fbdf987c082ef7d288f66bbe8
2021-03-29 06:53:54 -07:00
Pascal Hartig
55341dfc59 Fix React Native build (#2100)
Summary:
Currently failing because the 0.64.x build requires Node >= 0.12

Pull Request resolved: https://github.com/facebook/flipper/pull/2100

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D27265576

Pulled By: passy

fbshipit-source-id: d7ee0cac8bab1dc90a1b453eef6a7be30177052e
2021-03-23 10:57:46 -07:00
Pascal Hartig
7c22fe8acb Add more gradle sub projects (#1997)
Summary:
I don't fully understand how dependabot works with Android but it seems to only look at the literal fbjni version number based on the logs and we're actually outdated on a bunch of dependencies which Gradle doesn't handle very well.

Pull Request resolved: https://github.com/facebook/flipper/pull/1997

Test Plan: Tested on my fork and I've got a ton of PRs because of this. Brace yourselves.

Reviewed By: mweststrate

Differential Revision: D26784112

Pulled By: passy

fbshipit-source-id: 98ebd0b899a0603868d4b6bc0866e557c87fecd5
2021-03-04 08:36:58 -08:00
Michel Weststrate
3c60798352 Set up CI for ReactNativeFlipperExample (#1995)
Summary:
Added CI to build the Android and iOS debug ReactNativeFlipperExample app

Pull Request resolved: https://github.com/facebook/flipper/pull/1995

Test Plan:
The relevant jobs succedeed in:
https://github.com/facebook/flipper/pull/1995/checks?check_run_id=2023075981

Reviewed By: passy

Differential Revision: D26778297

Pulled By: mweststrate

fbshipit-source-id: 61f953739e1fa7dc7467af2fa5134798cce8b928
2021-03-03 09:43:32 -08:00
Pascal Hartig
3cda93dade Cache Android builds on GitHub Actions (#1922)
Summary:
Builds up a file with checksums of all `build.gradle` files. Deliberately excludes the `gradle.properties` which changes all the time. The cache shouldn't require nuking except in some rare circumstances.

Pull Request resolved: https://github.com/facebook/flipper/pull/1922

Test Plan: From 41 minutes down to 17: https://github.com/passy/flipper-1/actions/runs/561501374

Reviewed By: mweststrate

Differential Revision: D26427242

Pulled By: passy

fbshipit-source-id: ff1d7370d477c9d7b57c62082ec985108a5ba698
2021-02-16 04:18:28 -08:00
Pascal Hartig
761f1354db Clean up secrets (#1921)
Summary:
See this being done elsewhere. I don't think it's necessary but why not?

Pull Request resolved: https://github.com/facebook/flipper/pull/1921

Test Plan: eyes

Reviewed By: jknoxville

Differential Revision: D26427191

Pulled By: passy

fbshipit-source-id: 80823bf50d6416d29d54c82cef433650c1451ac0
2021-02-15 10:31:03 -08:00
Pascal Hartig
7fd0c7d82e Fix upload of sample app apk (#1920)
Summary:
This was an expected failure, you can see here how the last step of the "Publish Android" workflow currently fails: https://github.com/facebook/flipper/runs/1873750507?check_suite_focus=true

This is because it no longer runs in a tagging context. We're now providing the tag as an input and my custom action knows how to attach to existing tags by name.

Pull Request resolved: https://github.com/facebook/flipper/pull/1920

Test Plan:
Test run here finished successfully: https://github.com/passy/flipper-1/actions/runs/560774414
Publish Android job: https://github.com/passy/flipper-1/actions/runs/560775419
Attached release: https://github.com/passy/flipper-1/releases/tag/v0.0.7
Artifacts on Central: https://repo.maven.apache.org/maven2/com/facebook/flipper/flipper/0.0.7/

{F372552533}

{F372552532}

Reviewed By: mweststrate

Differential Revision: D26402629

Pulled By: passy

fbshipit-source-id: 7290e6bb8d1078ee20a0cf10105dc37f1e7aa99a
2021-02-12 04:36:11 -08:00
Pascal Hartig
0085a0d140 Set up release automation (#1915)
Summary:
Depends on https://github.com/facebook/flipper/issues/1914.
This sets up the workflows for automatically building, publishing and "closing" the repository on Maven Central, which is a step you usually need to do manually in the web UI.

Still need to transfer all the secrets over to this repo for it to work.

Pull Request resolved: https://github.com/facebook/flipper/pull/1915

Test Plan:
Ran all of this in my this in my fork and released some `0.0.x` versions.

- Successful workflow: https://github.com/passy/flipper-1/actions/runs/552170713
- It's actually all on Maven: https://repo.maven.apache.org/maven2/com/facebook/flipper/

Reviewed By: jknoxville

Differential Revision: D26367469

Pulled By: passy

fbshipit-source-id: d65f64ee8eec1dc71af64b7e0f87473b9c956fec
2021-02-10 07:16:32 -08:00
Pritesh Nandgaonkar
87e7afe4ab Update tutorial podfiles and GH actions (#1896)
Summary:
This PR updates the flipperkit version of the Tutorial and updates the GH action to test it without the arch flag.
This PR also fixes the script which updates the `flipperkit_version` tag in all the files. It was broken for Tutorial, as it used to replace the last released version of the pod with the current one in each file, but for some reason the flipper version in the Tutorial/Podfile was way older and it never got updated.

I have fixed the logic now to replace the current version in the file with the new one, rather than relying on only last version to be replaced.

## Changelog

- Updated the GH action of tutorial to remove the -arch flag
- Updated Tutorial/Podfile and Podfile.lock
- Updated scripts/update-pod-versions.sh

Pull Request resolved: https://github.com/facebook/flipper/pull/1896

Test Plan:
CI should be green
Tested that the version gets updated for each and every file, file tested were Flipper.podspec, FlipperKit.podspec, Sample/Podfile SampleSwift/Podfile Tutorial/Podfile

{F369967362}

{F369967395}

Reviewed By: nikoant

Differential Revision: D26275657

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 0f21a2a33c740938d2b29624e95974e80a2e38ba
2021-02-05 04:51:11 -08:00
Pritesh Nandgaonkar
8ade24abbc Solves the sampleswift failing job (#1893)
Summary:
Solves the sampleswift failing job, by removing the linker flags which were used when we relied on CocoaLibEvent, but now we do not rely on this.

## Changelog

- Removed cocoalib flag
- Removed arch requirement from the workflow for sample swift

If the flag is removed from the objc sample then I get the following error. It looks like for the objc project, xcode is not able to find the arm64 artifacts for swift deps.

I tried all the alternatives for solving this issue, but it didn't work for objc. I will wait for new xcode and will try with that, hopefully, the newer xcode has the fix.

```
ld: warning: Could not find or use auto-linked library 'swiftFoundation'
ld: warning: Could not find or use auto-linked library 'swiftMetal'
ld: warning: Could not find or use auto-linked library 'swiftUIKit'
ld: warning: Could not find or use auto-linked library 'swiftDarwin'
ld: warning: Could not find or use auto-linked library 'swiftObjectiveC'
ld: warning: Could not find or use auto-linked library 'swiftCoreFoundation'
ld: warning: Could not find or use auto-linked library 'swiftDispatch'
ld: warning: Could not find or use auto-linked library 'swiftCoreImage'
ld: warning: Could not find or use auto-linked library 'swiftCore'
ld: warning: Could not find or use auto-linked library 'swiftQuartzCore'
ld: warning: Could not find or use auto-linked library 'swiftCoreGraphics'
ld: warning: Could not find or use auto-linked library 'swiftSwiftOnoneSupport'
Undefined symbols for architecture arm64:
  "protocol descriptor for Swift.ExpressibleByFloatLiteral", referenced from:
      l_got.$ss25ExpressibleByFloatLiteralMp in libYogaKit.a(YGLayoutExtensions.o)
  "associated type descriptor for Swift.ExpressibleByIntegerLiteral.IntegerLiteralType", referenced from:
      l_got.$s18IntegerLiteralTypes013ExpressibleByaB0PTl in libYogaKit.a(YGLayoutExtensions.o)
  "associated conformance descriptor for Swift.ExpressibleByIntegerLiteral.Swift.ExpressibleByIntegerLiteral.IntegerLiteralType: Swift._ExpressibleByBuiltinIntegerLiteral", referenced from:
      l_got.$ss27ExpressibleByIntegerLiteralP0cD4TypeAB_s01_ab7BuiltincD0Tn in libYogaKit.a(YGLayoutExtensions.o)
  "method descriptor for Swift.ExpressibleByFloatLiteral.init(floatLiteral: A.FloatLiteralType) -> A", referenced from:
      l_got.$ss25ExpressibleByFloatLiteralP05floatD0x0cD4TypeQz_tcfCTq in libYogaKit.a(YGLayoutExtensions.o)
  "protocol descriptor for Swift.ExpressibleByIntegerLiteral", referenced from:
      l_got.$ss27ExpressibleByIntegerLiteralMp in libYogaKit.a(YGLayoutExtensions.o)
  "value witness table for Builtin.Int32", referenced from:
      full type metadata for __C.YGUnit in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftCoreImage", referenced from:
      __swift_FORCE_LOAD_$_swiftCoreImage_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftCoreImage_$_YogaKit)
  "associated type descriptor for Swift.ExpressibleByFloatLiteral.FloatLiteralType", referenced from:
      l_got.$s16FloatLiteralTypes013ExpressibleByaB0PTl in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftQuartzCore", referenced from:
      __swift_FORCE_LOAD_$_swiftQuartzCore_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftQuartzCore_$_YogaKit)
  "__swift_FORCE_LOAD_$_swiftDispatch", referenced from:
      __swift_FORCE_LOAD_$_swiftDispatch_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftDispatch_$_YogaKit)
  "method descriptor for Swift.ExpressibleByIntegerLiteral.init(integerLiteral: A.IntegerLiteralType) -> A", referenced from:
      l_got.$ss27ExpressibleByIntegerLiteralP07integerD0x0cD4TypeQz_tcfCTq in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftCoreFoundation", referenced from:
      __swift_FORCE_LOAD_$_swiftCoreFoundation_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftCoreFoundation_$_YogaKit)
  "protocol witness table for Swift.Int : Swift._ExpressibleByBuiltinIntegerLiteral in Swift", referenced from:
      associated type witness table accessor for Swift.ExpressibleByIntegerLiteral.IntegerLiteralType : Swift._ExpressibleByBuiltinIntegerLiteral in __C.YGValue : Swift.ExpressibleByIntegerLiteral in YogaKit in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftObjectiveC", referenced from:
      __swift_FORCE_LOAD_$_swiftObjectiveC_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftObjectiveC_$_YogaKit)
  "__swift_FORCE_LOAD_$_swiftCoreGraphics", referenced from:
      __swift_FORCE_LOAD_$_swiftCoreGraphics_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftCoreGraphics_$_YogaKit)
  "_swift_getForeignTypeMetadata", referenced from:
      type metadata accessor for __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
      type metadata accessor for __C.YGUnit in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftFoundation", referenced from:
      __swift_FORCE_LOAD_$_swiftFoundation_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftFoundation_$_YogaKit)
  "associated conformance descriptor for Swift.ExpressibleByFloatLiteral.Swift.ExpressibleByFloatLiteral.FloatLiteralType: Swift._ExpressibleByBuiltinFloatLiteral", referenced from:
      l_got.$ss25ExpressibleByFloatLiteralP0cD4TypeAB_s01_ab7BuiltincD0Tn in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftUIKit", referenced from:
      __swift_FORCE_LOAD_$_swiftUIKit_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftUIKit_$_YogaKit)
  "__swift_FORCE_LOAD_$_swiftMetal", referenced from:
      __swift_FORCE_LOAD_$_swiftMetal_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftMetal_$_YogaKit)
  "Swift.Float.init(Swift.Double) -> Swift.Float", referenced from:
      static (extension in YogaKit):CoreGraphics.CGFloat.% postfix(CoreGraphics.CGFloat) -> __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
      (extension in YogaKit):__C.YGValue.init(CoreGraphics.CGFloat) -> __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftDarwin", referenced from:
      __swift_FORCE_LOAD_$_swiftDarwin_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftDarwin_$_YogaKit)
  "protocol witness table for Swift.Float : Swift._ExpressibleByBuiltinFloatLiteral in Swift", referenced from:
      associated type witness table accessor for Swift.ExpressibleByFloatLiteral.FloatLiteralType : Swift._ExpressibleByBuiltinFloatLiteral in __C.YGValue : Swift.ExpressibleByFloatLiteral in YogaKit in libYogaKit.a(YGLayoutExtensions.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

Pull Request resolved: https://github.com/facebook/flipper/pull/1893

Test Plan:
CI in github should be green

flipper-oss-ios-build works
https://www.internalfb.com/intern/sandcastle/job/22517998513117018/

Reviewed By: mweststrate

Differential Revision: D26254390

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 291cfb949e781ccb9e0317679daa673dcf8e9479
2021-02-05 02:10:26 -08:00
Pritesh Nandgaonkar
0ebe3956a4 Update OpenSSL pod and remove exclude arch setting (#1892)
Summary:
This PR updates the OpenSSL pod and thus updates the corresponding Folly and RSocket pods. The new OpenSSL pod has a support of arm64 artifact for iPhomeSimulators.This PR also updates the replaces the libevent pod which didn't work with arm64 arch for iPhoneSimulator.

## Changelog

- Update OpenSSL pod
- Update Folly dep
- Update RSocket dep
- Replace Libevent pod.

Pull Request resolved: https://github.com/facebook/flipper/pull/1892

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D26229304

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 46256d9cd3e0cf5aab6e477e612c3bcb77e31627
2021-02-04 08:50:14 -08:00
Pritesh Nandgaonkar
140ff8861e Add github actions for dependency pod validations (#1834)
Summary:
This PR adds github actions to validate the pods, so that the changes which breaks the validation is not made. This PR also downgrades the version update of OpenSSL, as it doesn't validate the Folly podspec. I have [raised](https://github.com/krzyzanowskim/OpenSSL/issues/113) an issue on the repository which manages the openssl dependency.
## Changelog

- Added githubaction for dependent pod validation
- Downgraded the openssl version, as with upgraded version the folly pod didn't validate.

Pull Request resolved: https://github.com/facebook/flipper/pull/1834

Test Plan: CI

Reviewed By: passy

Differential Revision: D25939525

Pulled By: priteshrnandgaonkar

fbshipit-source-id: f70d043f1f6b2c79028212d8f56c6b8632092e33
2021-01-19 14:20:50 -08:00
Anton Nikolaev
dbc888613b Do not bump every package version for every release
Summary:
This diff sets all package version to "0.0.0" except of the root package and changes the bump script to only bump version in the root package. This should reduce possibility of conflicts on release diffs. Anyway we always use the same version for all of our packages, so we can only set it to the root.

Before npm publishing we will set all package versions to the same number as in the root package (we actually already do that) so there will be no differences except we won't need to bump version in  more than 100 packages each release.

Reviewed By: mweststrate

Differential Revision: D25162373

fbshipit-source-id: 02fe401bee72845339c67925c130027bdaee559d
2020-12-02 02:38:47 -08:00
Pascal Hartig
30628c8139 Publish npm packages from Action
Summary: Adds an action for publishing packages to npm. Secret was added as part of T80403944.

Reviewed By: nikoant

Differential Revision: D25195740

fbshipit-source-id: 51d43d9f5e84a25a67b637233b2c62a9a1a15063
2020-11-27 09:30:06 -08:00
Pascal Hartig
ac475d315c Pin down Rust toolchain (#1719)
Summary:
To make sure we're staying in sync with the internal version. Requires some more manual updating, but even if we do this every couple of months, it should be fine.

Pull Request resolved: https://github.com/facebook/flipper/pull/1719

Test Plan: CI

Reviewed By: nikoant

Differential Revision: D25195565

Pulled By: passy

fbshipit-source-id: 763a9d877a20659e91c8b77d0900b999e5f630d3
2020-11-27 08:45:04 -08:00
Pascal Hartig
8d879fdd77 Install more NDKs (#1715)
Summary:
I honestly don't know how the resolution works but it seems that we need
more than just one NDK.

Pull Request resolved: https://github.com/facebook/flipper/pull/1715

Test Plan: Let's hope this turns green.

Reviewed By: mweststrate

Differential Revision: D25170962

Pulled By: passy

fbshipit-source-id: dcdf25b5c77f08bdeceef50d924727cb0c9dcca9
2020-11-26 05:15:53 -08:00
Anton Nikolaev
c431657a39 Use --synchronous option for pushing FlipperKit cocoapod which should fix consistency issue
Summary: This is suggested as a fix for the consistency issue (https://github.com/facebook/flipper/issues/1638) when interdependent packages published together and one of them cannot find another because it takes time to synchronise published packages to CDN. This fix is suggested here: https://github.com/CocoaPods/CocoaPods/issues/9497.

Reviewed By: mweststrate

Differential Revision: D25184732

fbshipit-source-id: d8d58b33f65ff7e87f935fb7cb85964dbf95dd13
2020-11-26 02:14:14 -08:00
Pascal Hartig
ca5c2e4d11 Migrate from Travis CI to GitHub Actions (#1695)
Summary:
We've previously had the docs deployment in Travis. Also some builds
but they were redundant, so that doesn't really matter.

Pull Request resolved: https://github.com/facebook/flipper/pull/1695

Test Plan:
Tested it on my own branch.
6ac5b3fa70

![Screenshot 2020-11-20 at 11 09 34](https://user-images.githubusercontent.com/9906/99795354-8cbd5480-2b23-11eb-9fe9-10504b19e6a4.png)

Reviewed By: nikoant

Differential Revision: D25119924

Pulled By: passy

fbshipit-source-id: b31ccd05daacc7c0a9a452e88638ba9a3bcc4c74
2020-11-20 06:05:58 -08:00
Pascal Hartig
51de9b72cf Fix GitHub Actions for sample build (#1693)
Summary:
Honestly not sure what's causing the new NDK to be pulled in
but at least locally installing it fixes the failure we see here:

https://github.com/facebook/flipper/runs/1424681947

Pull Request resolved: https://github.com/facebook/flipper/pull/1693

Test Plan: Wait for the Actions on the PR

Reviewed By: nikoant

Differential Revision: D25093335

Pulled By: passy

fbshipit-source-id: e7af63fcf3c5270c869acc3d094234d15968aeda
2020-11-19 12:25:31 -08:00
Anton Nikolaev
46a1ac5947 Fix github release script
Summary: Just a small mispelling in step specification

Reviewed By: mweststrate

Differential Revision: D25053437

fbshipit-source-id: 39e7c9c578a448495b92f8aa3632b2843d79490c
2020-11-18 10:07:09 -08:00
Pascal Hartig
cb625d38dc Build tutorial app as part of sample build (#1677)
Summary:
Per title.

Will require https://github.com/facebook/flipper/issues/1676 to land first.

Pull Request resolved: https://github.com/facebook/flipper/pull/1677

Reviewed By: mweststrate

Differential Revision: D24981568

Pulled By: passy

fbshipit-source-id: 053f4bafaffbae0890603aef5b3a01c7d0e1137e
2020-11-17 03:12:03 -08:00
Pascal Hartig
9a3cd63d55 Pin workflow actions (#1687)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1687

I cleaned up and tagged both of the custom actions.
It's much better to pin them down properly so that
future changes on `main` don't break anything.

Reviewed By: nikoant

Differential Revision: D24996462

fbshipit-source-id: 6d63e76b758439ba8df4ef2f5b77992789744e7b
2020-11-16 13:03:57 -08:00
Pascal Hartig
30d212da65 Select release commit from larger push (#1678)
Summary:
GitHub only issues one push event for multiple commits.
This causes things to behave weirdly. My action now
looks for a commit with a certain message and runs
the subsequent steps on it. If there's more than one
matching commit, it uses the last one. Not great, not terrible.

Pull Request resolved: https://github.com/facebook/flipper/pull/1678

Test Plan: Ran it on my fork: https://github.com/passy/flipper-1/actions/runs/360332680

Reviewed By: nikoant

Differential Revision: D24955986

Pulled By: passy

fbshipit-source-id: 6dcbe11e69bf77c803e3907ced3185ca85483ec8
2020-11-16 11:05:30 -08:00
John Knox
a9ac4da146 Fix iOS CI Build (#1673)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1673

XCode 12 starts building for apple hardware, but that fails on x86, so only build x86_64.

Reviewed By: nikoant

Differential Revision: D24857260

fbshipit-source-id: 30c0e021d4f809fd3a8ad72537a2627a43e589eb
2020-11-10 08:10:11 -08:00
Pascal Hartig
50f2b0db5f Trigger publish-pods from release workflow
Summary: Had the `PERSONAL_TOKEN` put in place by the OSS oncall. Still won't know if it has the right permissions until we run this. :/

Reviewed By: nikoant

Differential Revision: D24833829

fbshipit-source-id: 4fbf6e0b0abbc50d0b9a1e9b7ca8b02f6e1f5171
2020-11-10 04:24:58 -08:00
Pascal Hartig
73f60c72dc Delete dmg-release.yml (#1655)
Summary:
No longer necessary as this is now taken care of by the new unified release Action.

Pull Request resolved: https://github.com/facebook/flipper/pull/1655

Test Plan: Next release, I'm afraid.

Reviewed By: nikoant

Differential Revision: D24782070

Pulled By: passy

fbshipit-source-id: 36ce0db814ad60fa04e4ed81b3657323bc5c983b
2020-11-06 08:23:42 -08:00
Pascal Hartig
d28610a9d2 Add retries to release GitHub Action
Summary:
Noticed that the icon download fails occasionally from GitHub.
This adds a few retries in case that happens.

Reviewed By: nikoant

Differential Revision: D24647690

fbshipit-source-id: 3ed84cb0972b7715fd87c8b1e1e1bca9f89485a9
2020-11-05 05:17:29 -08:00
Pascal Hartig
1fde900fcc Pin down custom actions
Summary:
I tagged my repos so messing on `master` won't break
our release flow.

Reviewed By: nikoant

Differential Revision: D24647691

fbshipit-source-id: c5e89dcf0a9063e86baf44e6d25164884a1a2b1e
2020-11-05 05:17:29 -08:00
Pascal Hartig
7293a7ff55 Move public build infra entirely to GitHub
Summary:
As part of our release confidence effort, this replaces the flaky internal task that creates the tag, promotes it to a release and uploads the artifacts to it.

Instead, we do all this in one lengthy GitHub Action. There seems to be some duplication here but this is because of the unfortunate restriction GitHub Actions imposes to avoid recursive Actions. I.e. we cannot create a tag/release and have another, independent Action pick up from there to do the building and releasing.

The `passy/` references were necessary because existing Actions didn't quite what we wanted to:

- `tag-version-commit` expected the title of the commit to match the precise tag to create. However, we want to use a regex to *extract* from the "Flipper Release: vA.B.C". My fork allows specifying a grouping regex for that.
- `github-upload-release-artifacts-action` relied on being triggered by a tag. As described above, that's not possible with this setup. Instead, this takes an existing tag and attaches to it.

Reviewed By: nikoant

Differential Revision: D24627518

fbshipit-source-id: 8121df6aa7bd36bda28e0d3cb207a002cd127647
2020-11-05 05:17:29 -08:00
Pascal Hartig
e40eb2dadd Change packer GitHub action (#1567)
Summary:
The one we're using right now appears to be borked: https://github.com/facebook/flipper/runs/1200221471

Pull Request resolved: https://github.com/facebook/flipper/pull/1567

Test Plan: Watching the CI here.

Reviewed By: mweststrate

Differential Revision: D24110022

Pulled By: passy

fbshipit-source-id: 6b9159ab634417123dc9512b293bbce77faff0f4
2020-10-05 09:04:25 -07:00
Michel Weststrate
54d36876b6 Upgrade to Electron 10 (#1532)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1532

Upgrade to Electron 10, in an attempt to fix random hard Electron crashes. Didn't fix it, but given the changelog of Electron with all the bug fixes, seems to be a good idea nonetheless :)

Changelog: Flipper now uses Electron 10

Reviewed By: nikoant

Differential Revision: D23565000

fbshipit-source-id: 3f07b8cf8c438147bde5314698d20046ac9f94cf
2020-09-17 09:44:27 -07:00
Pascal Hartig
33cd7d29df Set up coveralls Jest coverage tracking on GitHub (#1392)
Summary:
This adds some pretty nice unit test coverage analysis for our codebase. Especially useful for external pull requests as a gentle nudge to make sure they don't regress the topline number.

To learn more, check out https://github.com/coverallsapp/github-action

Pull Request resolved: https://github.com/facebook/flipper/pull/1392

Test Plan:
{F245038134}

{F245038132}

https://coveralls.io/builds/32250084

Reviewed By: jknoxville

Differential Revision: D22664361

Pulled By: passy

fbshipit-source-id: 4dc1fc79677da41a9d3ea198224c5678ae156ad4
2020-07-22 08:41:14 -07:00
Pritesh Nandgaonkar
a4422a7687 Update pod version after release (#1338)
Summary:
This diff updates the Github workflow to update pod versions after the release is published on Cocoapods.
## Changelog

- Update Github workflow to update the pod versions till the release is published in Cocoapods.

Pull Request resolved: https://github.com/facebook/flipper/pull/1338

Test Plan:
A PR got created with the updated pod versions after the release was pushed.
https://github.com/facebook/flipper/pull/1365

Reviewed By: passy

Differential Revision: D22456857

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 335996bc1ebb6da309d3f60a8f3401559e0a83c7
2020-07-10 02:20:14 -07:00
Pascal Hartig
74815a200e Add more packages to dependabot config (#1341)
Summary:
Adding more packages.

Pull Request resolved: https://github.com/facebook/flipper/pull/1341

Test Plan: ![Screenshot 2020-07-08 10 08 06](https://user-images.githubusercontent.com/9906/86900187-edaf3780-c102-11ea-8eb3-f692bba6ea29.png)

Reviewed By: mweststrate

Differential Revision: D22430656

Pulled By: passy

fbshipit-source-id: 7090bdb46bea08eeadcbad90b6100319f50add5c
2020-07-08 07:45:48 -07:00
Pascal Hartig
2f807880f4 Update dependabot.yml (#1299)
Summary:
Ewww, dependabot for GitHub is incompatible with the file format documented on dependabot.com.
So the current file is invalid:

![Screenshot 2020-06-26 15 04 59](https://user-images.githubusercontent.com/9906/85865837-6b4b7d00-b7be-11ea-9e5c-49007733a0e1.png)
Pull Request resolved: https://github.com/facebook/flipper/pull/1299

Test Plan: hopeitwork

Reviewed By: jknoxville, mweststrate

Differential Revision: D22286456

Pulled By: passy

fbshipit-source-id: bd783264b188fb5ce6e0e990bf269bca20d8d43b
2020-06-30 03:49:00 -07:00
Pascal Hartig
729549bc9f Set up GitHub test workflow for Packer (#1306)
Summary:
Per title.
Pull Request resolved: https://github.com/facebook/flipper/pull/1306

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D22285900

Pulled By: passy

fbshipit-source-id: 094cab21cc0f646495e9166435fb6563d50ee2a8
2020-06-29 10:10:39 -07:00
Pascal Hartig
5d033204e8 Update dmg-release.yml (#1296)
Summary:
The second publish job actually works, so let's remove the first one.
Pull Request resolved: https://github.com/facebook/flipper/pull/1296

Test Plan: https://github.com/facebook/flipper/runs/806859866?check_suite_focus=true

Reviewed By: jknoxville

Differential Revision: D22257369

Pulled By: passy

fbshipit-source-id: 72acc2e8ee10ad4514e315d57f4fa44656fce4e3
2020-06-26 07:52:25 -07:00
Pascal Hartig
b1ca674171 Update dependabot.yml (#1277)
Summary:
Move to `versioning-strategy: increase-if-necessary`. I'm not sure if that's what we want, but it's really annoying right now where if you include a lockfile, it will update every single patch release, whether or not it's covered by your version range right now.

Let's try this and revert if it doesn't do what I think it does.

Config description here: https://help.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates#versioning-strategy
Pull Request resolved: https://github.com/facebook/flipper/pull/1277

Reviewed By: nikoant

Differential Revision: D22118718

Pulled By: passy

fbshipit-source-id: 450c022fb2a17b68561bb2d9796976dddec002e2
2020-06-19 10:33:19 -07:00
dependabot-preview[bot]
763853a7cf Update Dependabot config file (#1244)
Summary:
👋 Dependabot is moving natively into GitHub! This pull request updates your config file to the [new syntax](https://help.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates). When you merge this pull request, we'll swap out `dependabot-preview` (me) for a new `dependabot` app, and you'll be all set!

With this change, you'll now use the [Dependabot page in GitHub](https://github.com/facebook/flipper/network/updates), rather than the [Dependabot dashboard](https://app.dependabot.com/), to monitor your version updates. Dependabot is now configured exclusively using config files.

If you've got any questions or feedback for us, please let us know by creating an issue in the [dependabot/feedback](https://github.com/dependabot/feedback) repository.

[Learn more about the relaunch of Dependabot](https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/)

Please note that regular `dependabot` commands do not work on this pull request.

:robot:💛
Pull Request resolved: https://github.com/facebook/flipper/pull/1244

Reviewed By: nikoant

Differential Revision: D21998719

Pulled By: passy

fbshipit-source-id: 4e76f8a932d5c95e23a0445e8ed74f7b8fa28919
2020-06-11 11:45:52 -07:00
Pascal Hartig
8ec6a6f664 Fix dmg-release.yml error (#1220)
Summary:
Key was duplicated. :(
Pull Request resolved: https://github.com/facebook/flipper/pull/1220

Reviewed By: mweststrate

Differential Revision: D21861770

Pulled By: passy

fbshipit-source-id: 6affdfbc488628465afc1a59c55ef0ec7ed61dff
2020-06-03 09:49:26 -07:00