Summary: lblasa said Sandy migration was done years ago. Can be removed safely.
Reviewed By: elboman
Differential Revision: D47439199
fbshipit-source-id: 3ae0e1b3133d051740cd28e9d47c978e6f478c36
Summary:
Requested by litho team
Changelog: UIDebugger Add seperate icon for litho mountables
Changelog: UIDebugger Serialize all props using java.lang.toString
Changelog: UIDebugger show drawables mounted by litho
Reviewed By: lblasa
Differential Revision: D47295799
fbshipit-source-id: ce5b9384e4796a5c58080a289709ed9f7afdf329
Summary:
Previous approach was a bit flawed as the `isOpen()` API returns true by the time close is called.
This was OK in the case of errors, as the open flag was set to false hence preventing us to report a close after the error. It is not OK on healthy disconnect situations as these events were not getting reported.
In this case, a better solution is just to clear the event handler after a close or error because in either case we are no longer interested in dispatching any other events to the handler.
Reviewed By: antonk52
Differential Revision: D47510883
fbshipit-source-id: 883a3f87f24f71fe44a624590a310fe2563cbd8a
Summary:
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.164 to 1.0.165.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p>
<blockquote>
<h2>v1.0.165</h2>
<ul>
<li>Fix incorrect count of fields passed to tuple deserialization methods when using <code>serde(skip_deserializing)</code> attributes (<a href="https://redirect.github.com/serde-rs/serde/issues/2466">https://github.com/facebook/flipper/issues/2466</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li>
<li>Fix <code>-Zminimal-versions</code> build</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="dcbc3e0162"><code>dcbc3e0</code></a> Release 1.0.165</li>
<li><a href="0289d31724"><code>0289d31</code></a> Fix -Zminimal-versions build</li>
<li><a href="015e39776f"><code>015e397</code></a> No need for single-element vec for chaining one element</li>
<li><a href="6a9a21f178"><code>6a9a21f</code></a> Resolve useless_conversion clippy lint in test</li>
<li><a href="81ac54b20d"><code>81ac54b</code></a> Resolve redundant_closure_call clippy lint</li>
<li><a href="6b4e75520a"><code>6b4e755</code></a> Resolve explicit_iter_loop pedantic clippy lint</li>
<li><a href="b053b4f492"><code>b053b4f</code></a> Touch up early return in Enum checks</li>
<li><a href="c0ba323166"><code>c0ba323</code></a> Support a manual trigger on CI workflow</li>
<li><a href="20a48c9580"><code>20a48c9</code></a> Remove .clippy.toml in favor of respecting rust-version from Cargo.toml</li>
<li><a href="09938803af"><code>0993880</code></a> Resolve redundant_static_lifetimes clippy lint</li>
<li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.164...v1.0.165">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4910
Reviewed By: lblasa
Differential Revision: D47294568
Pulled By: passy
fbshipit-source-id: 284710438e91a56b63f56f52a5974478af603eeb
Summary:
Add support for secondary indices, to allow for cheap lookups, like a set of events for a specific UI element in the events table:
```
#### getAllRecordsByIndex
Usage: `getAllRecordsByIndex({ indexedAttribute: value, indexAttribute2: value2, .... })`
This method allows fast lookups for objects that match specific attributes exactly.
Returns all items matching the specified index query.
Note that the results are unordered, unless
records have not been updated using upsert / update, in that case
insertion order is maintained.
If no index has been specified for this exact keyset in the indexQuery (see options.indices), this method will throw.
Example:
```
```
const ds = createDataSource([eatCookie, drinkCoffee, submitBug], {
key: 'id',
indices: [
['title']
['id', 'title'],
['title', 'done'],
],
});
// Find first element with title === cookie (or undefined)
const todo = ds.getFirstRecordByIndex({
title: 'cookie',
})
// Find all elements where title === cookie, and done === false
const todos = ds.getAllRecordsByIndex({
title: 'cookie',
done: false,
})
```
Reviewed By: antonk52
Differential Revision: D47396435
fbshipit-source-id: 20c4527be83532863b9b07ab20ebf20a80c3c35d
Summary:
Original commit changeset: 2a975690bab0
Original Phabricator Diff: D47257442
For context:
More things need updating and testing. Node, antd, etc. needs all updating.
Once this lands, a new release needs to be made triggered by:
https://www.internalfb.com/chronos/job/gp/27021599065494131
Differential Revision: D47456598
fbshipit-source-id: 1f96e88744b98c7d477c5ccc43167bde475e3036
Summary:
Right now, both Launcher and PWA share the same icon.
As to make it easier to identify which one is which, PWA will have a greyed icon instead.
Reviewed By: antonk52
Differential Revision: D47436998
fbshipit-source-id: 69d4d273c35e327263fbbf02d4ac7a005013f1d9
Summary: For Windows, we cannot use UDS, so use TCP instead.
Reviewed By: antonk52
Differential Revision: D47436314
fbshipit-source-id: ee2454f9f77b3642f4988957eefc250a64bf02b6
Summary:
If the proxy fails, exit.
The proxy server is the one listening on the supplied TCP port, used by PWA.
If it has failed, then quit the process.
Reviewed By: aigoncharov
Differential Revision: D47433631
fbshipit-source-id: 55750db5bf3e00876074a6b403747ec07718878c
Summary: "send" returns "void" which means we do not care about the execution result, including errors
Reviewed By: lblasa
Differential Revision: D47398015
fbshipit-source-id: ef185575f6e91d69356ab88c7f3d213033759da8
Summary: In the next diffs, we are going to show a message only once when the plugin gets activated. This diff adds a way to unsubscribe from Flipper events after the first execution.
Reviewed By: LukeDefeo
Differential Revision: D47366239
fbshipit-source-id: 18cb99df865f9cf26c055a99b7d1b7058dcb123c
Summary: If it is successful, we rarely care about stdout, which can be quite verbose. So don't use it.
Reviewed By: antonk52
Differential Revision: D47339446
fbshipit-source-id: 66f43d4184e44ed07364a6f33715139e19b2dc1d
Summary:
We had feedback that when a small eleemnt was selected it was hard to find, this should help
Changelog: [UIDebugger] Make selection more prominent in the visualiser
Reviewed By: lblasa
Differential Revision: D47223504
fbshipit-source-id: 33b448d36b0323e958e45fd1d0e2c7f659de293c
Summary:
Following feedback when using keyboard controls its a little bit awkward to have to move with arrows and then select with enter.
Now when using keyboard controls you are manipulating the selected state.
Enter still selects / unselects but its not really needed anymore
When using the mouse the hover state is still there
Changelog: [UIDebugger] Using keyboard arrow control changes the selected and hovered state together for faster / easier navigation
Reviewed By: lblasa
Differential Revision: D47212492
fbshipit-source-id: 996196880d623885b4d4b7d1a70954201f809d28
Summary:
To avoid showing the Ugly spinner in the context menu as well as a better UX we prefetch the IDE resolved path. It was important to limit the concurrency of the running arc jobs otherwise lots of bad things happen and the whole machine stalls out.
The general idea is as the frame comes off the wire we send them to react query to prefetch. by setting the cache time sending the same key twice will not result in 2 fetches, so we dont need to worry about deduplication on our side
Reviewed By: antonk52
Differential Revision: D47210292
fbshipit-source-id: 4a1d8efdfae754c1a73c6a868b02d1f3a0a5b567
Summary:
Originally we planned to move the IDE inline in the row but this is hard to do well, especially with the horizontal scroll as well as the extra buttons for biggrep, codehub, AS and vscode.
Context menu is still very natural so lets try this
Reviewed By: lblasa
Differential Revision: D47210289
fbshipit-source-id: 339508c820915298161bf95fd1c3cea60b800746
Summary: Remove debug logs and add re-format other warn logs to have parity with iOS
Reviewed By: antonk52
Differential Revision: D47330455
fbshipit-source-id: ac8edde2124bbe99d0ea11f46f3b85dd77b96c7b
Summary:
This change has a minimal Connectivity Hub with a log viewer of connectivity related events.
The hub is integrated so that is usable.
Reviewed By: antonk52
Differential Revision: D47296027
fbshipit-source-id: 7611ce0b1480e9bdb7cdff2bcedeb445a322c195
