Summary: Follow-up to D38155922. This was done almost entirely by just following suggestions from the compiler. No behaviour changes, just fewer bit-copies in memory.
Reviewed By: lblasa
Differential Revision: D38199244
fbshipit-source-id: 777e9d833d25cb660307380ab88b12a1d4eedf09
Summary:
The limitation to two types is arbitrary and limiting. Instead, we want to be able to create as many cache artifacts as is sensible to improve the caching behaviour.
A lot of unnecessary cloning in here. I might optimise this a bit in the future but it's not really perf critical as this is highly I/O bound.
Reviewed By: lblasa
Differential Revision: D38155922
fbshipit-source-id: 78b86ebff54269c5049e59197f1c25fedfad0111
Summary: This is needed so we can roll out releases of Flipper Server for Linux.
Reviewed By: lawrencelomax
Differential Revision: D38155968
fbshipit-source-id: 2be032466cb8da867fa555fa545d1f236724461f
Summary: A few small adjustments and updates.
Reviewed By: lawrencelomax
Differential Revision: D38155923
fbshipit-source-id: 1aea5f9b64a6b5e4783fe7bad214df6a74be7d45
Summary: In a previous diff D32278523 (8764da7c0b) The desktop request was changed from send to call. Call expects a response and not all code paths return a response. Most calls to set highlight are timing out.
Reviewed By: mweststrate
Differential Revision: D38074704
fbshipit-source-id: 6e85416d6b6470efaa177ad1b74420c8237366d5
Summary:
In order to accomplish multi-panel mode, we need to use multiple data views on the same data source so that the filters can be applied differently, etc.
This diff serves to refactor DataTable and some of its associated classes to use DataView as the primary driver for data management. Additionally, the diff refactored the state to allow multi-paneling to be on the DataPanel layer instead of the DataTable layer for ease of usage
This is the last diff of the larger stack which introduces the multi-panel mode feature. A possible next step could be allowing infinite(up to a certain limit) panels to be populated.
Changelog: Introduced side by side view feature for `DataTable`. There is now a new boolean for `DataTable` props called `enableMultiPanels`. If this is passed in, then the table will have an option to open a different "side panel" using a completely different dataview which allows different filters, searches, etc.
Reviewed By: mweststrate
Differential Revision: D37685390
fbshipit-source-id: 51e35f59da1ceba07ba8d379066970b57ab1734e
Summary:
Quoting lblasa:
History trip:
- It was used at the beginning of times with RSocket.
- RSocket introduced an RPC mechanism so a new responder was introduced which used it, thus making this responder legacy.
- WebSockets is introduced which doesn't have an RPC mechanism by default so this responder became the new non-legacy responder
Reviewed By: lblasa
Differential Revision: D37994288
fbshipit-source-id: 2458aed129058a5bfaafd607e73c52867d9713cf
Summary: SidebarInteractiveContainer sets mousedown/mouseup handlers. Whenever user tries to select text in child element those are triggered.
Reviewed By: passy
Differential Revision: D37994014
fbshipit-source-id: 5dcf5642b3a92ec50008aa4aad6b9522a09c1527
Summary:
There are many files across fbobjc relying on -include_pch and therefore they miss Foundation.h and UIKit.h includes. This diff was generated by a codemod and fixes these missing includes.
More details on the missing imports https://fb.workplace.com/groups/929548250966094/permalink/981237982463787/
Changelog: [Internal]
Reviewed By: yannickl
Differential Revision: D37282740
fbshipit-source-id: 0f419025b3cf2f811e96ff464cb19e8e5a25aa09
Summary:
Some old welcome links are 'Page Not Found'.
## Changelog
Some old links are 'Page Not Found', so update them as follows:
1. Update "Using Flipper" link to 'https://fbflipper.com/docs/features'
2. Update "Add Flipper Support to Your App" link to 'https://fbflipper.com/docs/getting-started'
Pull Request resolved: https://github.com/facebook/flipper/pull/3902
Test Plan: Pass the test on a Mac.
Reviewed By: lblasa
Differential Revision: D37927376
Pulled By: passy
fbshipit-source-id: 0aac129932395e3f2ce3afa8c47cc637f3e814a8
Summary:
^
Ignore the errors as otherwise it may cause unhandled rejection errors.
Reviewed By: aigoncharov
Differential Revision: D37926740
fbshipit-source-id: 50476378b4d254e28af953979fbedad1113e43aa
Summary:
When upgrading to RN 0.68, the upgrade helper removes the old Flipper initialization in favor of importing `RCTAppSetupUtils` which abstracts the Flipper initialization.
To be consistent, we should show in the docs that for 0.68 the preferred way is to import `RCTAppSetupUtils` in the AppDelegate.
## Changelog
- RN iOS setup docs has been updated to include the new way to initialize Flipper on React Native 0.68.
Pull Request resolved: https://github.com/facebook/flipper/pull/3905
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
**Static Docs Preview: flipper**
|[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D37927365/V2/flipper/)|
|**Modified Pages**|
|[docs/getting-started/react-native-ios](https://our.intern.facebook.com/intern/staticdocs/eph/D37927365/V2/flipper/docs/getting-started/react-native-ios/)|
Reviewed By: lblasa, cortinico
Differential Revision: D37927365
Pulled By: passy
fbshipit-source-id: c6799e91a217d341eb817abb175ce63ea70c9597
Summary:
Observed that a few requests tend to timeout when using Flipper with flipper-server.
Increasing timeout to 45s as to be a bit more flexible.
'exec' operations don't have a timeout when not using flipper-server.
Reviewed By: antonk52
Differential Revision: D37955108
fbshipit-source-id: 5d8ef7f066d6b316e4b485b281a015794b5bd2de
Summary:
Client calls return a promise. Not dealing with the error causes promise unhandled rejection errors.
This change adds a catch block and logs the error instead.
Reviewed By: antonk52
Differential Revision: D37955029
fbshipit-source-id: 50cac5a5339961d16868ab2102d3c77790e6943c
Summary:
Historically, RSocket used to raise an error when there was an error during send, most likely because the connection was dead.
With WS, this is no longer the case.
WS connection issues are raised through the according handlers.
Reviewed By: passy
Differential Revision: D37825821
fbshipit-source-id: 7fcda8cf26fb42eb0d8ca03b62482f11c931777f
Summary:
This diff has been automatically generated by the inpage editor.
If you want to update this diff, go through the preview link that would be attached to the test plan.
Please ensure you are editing the same page that was used to create this diff.
Reviewed By: passy
Differential Revision: D37853011
fbshipit-source-id: 1d68d5a80b30bb1b1cdf5703272717dadbe3a977
Summary:
Nothing interesting here, just adding necessary sources from Flipper into the VS Studio solution.
As a consequence, some warnings had to be turned off as otherwise they're treated as errors and the solution doesn't build.
Reviewed By: passy
Differential Revision: D36760242
fbshipit-source-id: 2f5e615f8a465554dd35c245756f94bcace6e34a
Summary:
This change brings in Folly and Boost into our solution.
Boost is resolved with NuGet. Folly is resolved by re-using the RNW integration.
For reference:
Flipper depends on Folly. Folly depends on a few things:
- Boost
- FMT
- Glog
- Double-Conversion
Folly from RNW uses some stubs to resolve fmt, glog, and double-conversion. That's OK.
Only Boost needs resolving.
On Visual Studio, we can use the following package managers: NuGet and vcpkg.
Boost can be resolved using either.
Using NuGet as otherwise vcpkg needs to be run locally by anybody wanting to build the solution. NuGet makes things easier.
Reviewed By: aigoncharov
Differential Revision: D36759384
fbshipit-source-id: 31a9a398ce5c5dc2f3def02689ae4bb8c42fbb99
Summary:
This diff adds a new menu option to the Logs plugin which allows for enabling/disabling the automatic filtering of search terms in the search history as user types.
Additionally, fixed bug regarding the search term that's used is not actually showing correctly. This is caused by the search value being set in the input search bar instead of the autoComplete component level
Differential Revision: D37555209
fbshipit-source-id: 8a76299f7e1a4b0a3adfa6a4dd883d17f1e7a442
Summary:
This change adds the template for a RNW module to the existing react-native flipper project.
Basically, the changes in this diff are the product of executing the react-native-windows init for the existing library.
See:
https://microsoft.github.io/react-native-windows/docs/getting-startedhttps://microsoft.github.io/react-native-windows/docs/native-modules-setup
Notes:
There's some auto-generated module code contained in this change: ReactNativeModule (.h/.cpp)
allow-large-files
Reviewed By: passy
Differential Revision: D36751772
fbshipit-source-id: 41207bedb00ea147883f6d13336ed6c1da4454d7
Summary:
^
If Flipper stops, we cannot freely access the client outside of the scheduler.
There may be an scheduled operation that depends on it.
Instead, schedule the stop and wait until it finishes.
Reviewed By: cekkaewnumchai
Differential Revision: D37814820
fbshipit-source-id: 44217b5f623a8d92211a3d72a4a204d674b4bb76
Summary:
Sets a default key binding of `ctrl+l` to clear the screen within built-in Flipper plugins which display a log view.
Motivation: A small quality of life improvement for developers used to the default "clear screen" binding. This makes our log-rendering plugins consistent with other native apps such as terminals, Chrome DevTools, and many others.
Reviewed By: mweststrate
Differential Revision: D37782638
fbshipit-source-id: 0a85b930faaa0e9468d5391f15092aad7b6057ee
Summary:
If there's a device client disconnect during request execution, no response is ever given back to the client (flipperd).
This change effectively subscribes to client disconnect events and notifies flipperd of any disconnection during request processing.
Reviewed By: passy
Differential Revision: D37787986
fbshipit-source-id: 31737a50b83b0cbe4141ce814064aebef7e09bfc
Summary:
Currently in the Flipper network plugin implementation, XMLTextFormatter is only enabled if `content-type` is `text/html`.
We should enable it for `application/xml` and `text/xml` as well.
Reviewed By: mweststrate
Differential Revision: D37733487
fbshipit-source-id: f272c5d0a305cf4afd32701d40459c3e11049886
Summary: For the Flipper Server Companion, if a plugin is being requested which is not yet installed, try to install it first from the marketplace.
Reviewed By: passy
Differential Revision: D37716962
fbshipit-source-id: d618fbc597f82b540dbb02e8ffc296dcee9e1eb9
Summary:
Expose two new methods as to be able to:
- List plugins from marketplace
- Install a plugin from marketplace
Reviewed By: passy
Differential Revision: D37749817
fbshipit-source-id: 82b78f7906c5664d5747289fa4f8eadebcde1d73
Summary: Expand PluginManager as to be able to load and install plugins from Marketplace.
Reviewed By: passy
Differential Revision: D37749802
fbshipit-source-id: 7d7e23427cc9d01f5c953b90e5b346a9d6bab19f
Summary:
Implementation taken from:
https://www.internalfb.com/code/fbsource/[85c1fe5afee7]/xplat/sonar/desktop/flipper-ui-core/src/fb/pluginMarketplaceAPI.tsx
As with the previous diff, the marketplace API for flipper-server-core accesses the existing config in a different way and depends on FlipperServer, instead of User, to execute intern request as to obtain marketplace plugins.
Reviewed By: passy
Differential Revision: D37749775
fbshipit-source-id: 968ea3f7a412893f032e5a7a50ecf17c298e18ff
Summary:
A few comments in my rewrite stack got missed, I am addressing them here.
In addition react testing library has been hoisted to the root module in the project and been made available to all sub modules
Reviewed By: mweststrate
Differential Revision: D37712339
fbshipit-source-id: 60984c3d16bd535b0c489570907f097c7d80f634
