Summary:
Original commit changeset: 2a975690bab0
Original Phabricator Diff: D47257442
For context:
More things need updating and testing. Node, antd, etc. needs all updating.
Once this lands, a new release needs to be made triggered by:
https://www.internalfb.com/chronos/job/gp/27021599065494131
Differential Revision: D47456598
fbshipit-source-id: 1f96e88744b98c7d477c5ccc43167bde475e3036
Summary:
Right now, both Launcher and PWA share the same icon.
As to make it easier to identify which one is which, PWA will have a greyed icon instead.
Reviewed By: antonk52
Differential Revision: D47436998
fbshipit-source-id: 69d4d273c35e327263fbbf02d4ac7a005013f1d9
Summary: For Windows, we cannot use UDS, so use TCP instead.
Reviewed By: antonk52
Differential Revision: D47436314
fbshipit-source-id: ee2454f9f77b3642f4988957eefc250a64bf02b6
Summary:
If the proxy fails, exit.
The proxy server is the one listening on the supplied TCP port, used by PWA.
If it has failed, then quit the process.
Reviewed By: aigoncharov
Differential Revision: D47433631
fbshipit-source-id: 55750db5bf3e00876074a6b403747ec07718878c
Summary: "send" returns "void" which means we do not care about the execution result, including errors
Reviewed By: lblasa
Differential Revision: D47398015
fbshipit-source-id: ef185575f6e91d69356ab88c7f3d213033759da8
Summary: In the next diffs, we are going to show a message only once when the plugin gets activated. This diff adds a way to unsubscribe from Flipper events after the first execution.
Reviewed By: LukeDefeo
Differential Revision: D47366239
fbshipit-source-id: 18cb99df865f9cf26c055a99b7d1b7058dcb123c
Summary: If it is successful, we rarely care about stdout, which can be quite verbose. So don't use it.
Reviewed By: antonk52
Differential Revision: D47339446
fbshipit-source-id: 66f43d4184e44ed07364a6f33715139e19b2dc1d
Summary:
We had feedback that when a small eleemnt was selected it was hard to find, this should help
Changelog: [UIDebugger] Make selection more prominent in the visualiser
Reviewed By: lblasa
Differential Revision: D47223504
fbshipit-source-id: 33b448d36b0323e958e45fd1d0e2c7f659de293c
Summary:
Following feedback when using keyboard controls its a little bit awkward to have to move with arrows and then select with enter.
Now when using keyboard controls you are manipulating the selected state.
Enter still selects / unselects but its not really needed anymore
When using the mouse the hover state is still there
Changelog: [UIDebugger] Using keyboard arrow control changes the selected and hovered state together for faster / easier navigation
Reviewed By: lblasa
Differential Revision: D47212492
fbshipit-source-id: 996196880d623885b4d4b7d1a70954201f809d28
Summary:
To avoid showing the Ugly spinner in the context menu as well as a better UX we prefetch the IDE resolved path. It was important to limit the concurrency of the running arc jobs otherwise lots of bad things happen and the whole machine stalls out.
The general idea is as the frame comes off the wire we send them to react query to prefetch. by setting the cache time sending the same key twice will not result in 2 fetches, so we dont need to worry about deduplication on our side
Reviewed By: antonk52
Differential Revision: D47210292
fbshipit-source-id: 4a1d8efdfae754c1a73c6a868b02d1f3a0a5b567
Summary:
Originally we planned to move the IDE inline in the row but this is hard to do well, especially with the horizontal scroll as well as the extra buttons for biggrep, codehub, AS and vscode.
Context menu is still very natural so lets try this
Reviewed By: lblasa
Differential Revision: D47210289
fbshipit-source-id: 339508c820915298161bf95fd1c3cea60b800746
Summary: Remove debug logs and add re-format other warn logs to have parity with iOS
Reviewed By: antonk52
Differential Revision: D47330455
fbshipit-source-id: ac8edde2124bbe99d0ea11f46f3b85dd77b96c7b
Summary:
This change has a minimal Connectivity Hub with a log viewer of connectivity related events.
The hub is integrated so that is usable.
Reviewed By: antonk52
Differential Revision: D47296027
fbshipit-source-id: 7611ce0b1480e9bdb7cdff2bcedeb445a322c195
Summary: To dispatch events, we need a valid instance of FlipperServer. This is the place so enable the recorder with it.
Reviewed By: antonk52
Differential Revision: D47295986
fbshipit-source-id: f2231544c58ba8f76e9102265e10a99520260b0a
Summary:
CertificateProvider is intrinsically related to a client query, make it available to it.
This becomes the optional 'context' of shell executions. When these are recorded, the context is provider to the recorder which can then link an ongoing certificate exchange process with the success or failure of said command.
Reviewed By: antonk52
Differential Revision: D47295894
fbshipit-source-id: 9469d18bda02793d71a6a8b29c93f4af1db23569
Summary:
Centralise connectivity logging into a single place. By having all logs go through a single interface, then it becomes trivial to manipulate them as needed.
In this change, this is not done.
In subsequent diffs, logs will be dispatched via an event and will be visualised in the Connectivity Hub.
Reviewed By: passy
Differential Revision: D47185054
fbshipit-source-id: fb5eab98895be0c8f61fb9a77d3e66d6a8dbcb27
Summary: These resolutions aren't used, validated with `yarn why`. See the diff higher in the stack for automation.
Reviewed By: yungsters
Differential Revision: D47282205
fbshipit-source-id: a2e909e3802f780fbe7525e5945faebee7004aef
Summary:
Scaffolding connectivity hub. The final place may be different though.
But at least for now whilst we iterate on the solution, this should be enough.
Reviewed By: passy
Differential Revision: D47230905
fbshipit-source-id: e3b3f7d773e1bf8b0dd9821cf25c6fa8e77669f4
Summary: As per comment, the issue is already fixed and released.
Reviewed By: LukeDefeo
Differential Revision: D47257442
fbshipit-source-id: 2a975690bab0eaed12b6b4233be41f675760a0bc
Summary:
Bit of refactoring, bit of improvements, maybe. Mainly:
- Name consistency
- Promise chaining to async/await
- Refactoring
Reviewed By: lawrencelomax, antonk52
Differential Revision: D47224620
fbshipit-source-id: 5f4515f576decc03d470c11f24577b43f34a5a28
Summary: Already have SecureClientQuery. No need to have this as a type as it's not used or needed anywhere.
Reviewed By: antonk52
Differential Revision: D47210345
fbshipit-source-id: d9f3026a0e2a0b5dd2e87f16dba34a388dacd75f
Summary: It should've been there with ClientQuery.
Reviewed By: antonk52
Differential Revision: D47210314
fbshipit-source-id: 869496918648f20b616c1a612296fff55597af77
Summary: Bit of reorganising as utils is a bit too generic and crowded.
Reviewed By: passy
Differential Revision: D47186536
fbshipit-source-id: 7b1dd26db95aef00778ff4f23d91f7371c4d07ad
Summary:
The field changed from mStates to states breaking our reflection based code. Ideally I would like to just check if type == KStateContainer and access the field normally but the rest of the infrastructure expect to work on a java field.
Added tests to catch this sort of thing in the future. had to shift buck files around a bit to get it to work
Reviewed By: antonk52
Differential Revision: D46974357
fbshipit-source-id: 87a6f5883b33e4d1a7359df5987fc7ead7c19033
Summary: It doesn't get more generic than 'comms'. So, narrow it down: app-connectivity.
Reviewed By: passy
Differential Revision: D47185255
fbshipit-source-id: 87e9c2487c9b07603d14e856de670757078c0da1
Summary: Make it more clear about that this is. `ServerAdapter` was VERY generic.
Reviewed By: passy
Differential Revision: D47185076
fbshipit-source-id: 7d9b30f423398004bedc92ad22bc0217d1c8453f
Summary: When the length of `pkcs12.second.c_str()` is equal to `length`, strncpy won't write a null-terminator at the end of the destination string, making the destination unsafe to read and potentially cause an overflow.
Reviewed By: lblasa
Differential Revision: D46934320
fbshipit-source-id: 5e7acd49523b80105bcc47471facd9ff23b8a2b8
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4905
Use fully qualified names in an attempt to fix the broken build.
Reviewed By: passy
Differential Revision: D47148297
fbshipit-source-id: bb2e81f62a65b9d4516a0bc4cfe2abddfc18a566
Summary: node count and root node prescense will be very useful
Reviewed By: lblasa
Differential Revision: D47153394
fbshipit-source-id: 067f6f3aefa17cdfa88124956781400f53fe08d7
Summary:
See https://github.com/samdenty/console-feed/issues/124.
This is breaking our CI and lots of other things. We should hopefully be able to cleanly revert this on Monday.
Reviewed By: ivanmisuno
Differential Revision: D47150333
fbshipit-source-id: f34d6afdb83607c8ac2cc7fb2989ca68733798e0
Summary: Set delegate and close inside the operation's queue as to make it safer i.e. all socket related operations are done inside the queue.
Reviewed By: ivanmisuno
Differential Revision: D47124235
fbshipit-source-id: 48b53db1cd47d017a26186a156046ba68fe358b7
Summary:
About to release React Native 0.72.1. This version of React Native has to depend on SocketRocket 0.7.0, released yesterday.
Cocoapods is failing to install dependencies with the following error:
```
In snapshot (Podfile.lock):
SocketRocket (= 0.7.0)
In Podfile:
FlipperKit/FlipperKitReactPlugin (= 0.182.0) was resolved to 0.182.0, which depends on
FlipperKit/Core (= 0.182.0) was resolved to 0.182.0, which depends on
SocketRocket (~> 0.6.0)
React-Core/RCTWebSocket (from `../react-native/`) was resolved to 1000.0.0, which depends on
SocketRocket (= 0.7.0)
React-CoreModules (from `../react-native/React/CoreModules`) was resolved to 1000.0.0, which depends on
SocketRocket
```
By bumping the SocketRocket dependencies and publishing a new version of FlipperKit, we would be able to release React Native.
Reviewed By: passy, cipolleschi
Differential Revision: D47125059
fbshipit-source-id: d0797880c502c14db9f0261c3e8abf2652e7bba2
