Commit Graph

3933 Commits

Author SHA1 Message Date
Andrey Goncharov
da5856138d Add event emitter to datasource
Reviewed By: LukeDefeo

Differential Revision: D51026560

fbshipit-source-id: 8348c6765633d7eecf0d1c80bc5bbd5af8130298
2023-11-08 02:08:25 -08:00
Aria Fallah
3536ffe737 Add worker plugin to plugin esbuild
Summary:
## Context
https://fb.workplace.com/groups/flippersupport/posts/1722856878194963

## Changes
* Add a worker plugin that takes modules suffixed with `?worker`, bundles them, treats them as web workers, and returns a function as a default export that instanitates a new worker

Reviewed By: antonk52

Differential Revision: D51059224

fbshipit-source-id: cef89486f7a2d5b8ce38354df4a5749271a6c41d
2023-11-07 11:09:10 -08:00
Anton Kastritskiy
39b1b37172 Off vpn error banner
Summary:
Some features of bloks do not work off vpn.

Until we figure out how to make them off vpn

Reviewed By: LukeDefeo

Differential Revision: D51076469

fbshipit-source-id: c83d96e89d33d245845312b39928a7460a235217
2023-11-07 10:57:06 -08:00
ea082e7a3e Merge branch 'main' of github.com:facebook/flipper into universalBuild 2023-11-07 12:42:02 +01:00
generatedunixname89002005306973
ddeda3f851 Flipper Release: v0.236.0
Summary: Releasing version 0.236.0

Reviewed By: aigoncharov

Differential Revision: D50975304

fbshipit-source-id: 3181dd2f913c23324e0dfbdaa068bfc32e653e12
2023-11-03 16:03:43 -07:00
Andrey Goncharov
7c5ede7a5e Force legacy search for network plugin
Summary: Uses legacy API `tableManagerRef.current?.setSearchValue` not currently available in power search

Reviewed By: LukeDefeo

Differential Revision: D50969833

fbshipit-source-id: c83d9dce24f5d7a37b6cc68e19da2ae5da374941
2023-11-03 08:03:50 -07:00
Andrey Goncharov
d9ecac4bc2 Track legacy manager API access
Summary:
We swap legacy MasterDetail and DataTable with the new ones that have power search.
The new ones have partially incompatible table manager API.
This diff adds a warning, a migration guide and  tracking for these cases.

Reviewed By: LukeDefeo

Differential Revision: D50969831

fbshipit-source-id: ef4153fec9720ea5d7ae1cb4df3528c5d6bca2bb
2023-11-03 08:03:50 -07:00
Andrey Goncharov
9c5df1516f Export legacy MasterDetail and DataTable
Summary: Allow plugin developers to force old search for migration purposes

Reviewed By: LukeDefeo

Differential Revision: D50969832

fbshipit-source-id: 7fe5c3e65680d628bced2cd09823f7f3c132d33a
2023-11-03 08:03:50 -07:00
Anton Kastritskiy
99dbcfa079 casing convension
Summary:
[eslint-typescript/naming-convension rule docs](https://typescript-eslint.io/rules/naming-convention/)

Initially looked into it to enforce UPPER_CASE for top most constants like `const DELAY = 10` which is a standard in js ecosystem, which turned to be more difficuilt(we will still get there).

Turns out we had casing checks disabled for everything but typeLike names. What I did in this diff

- use default setting for eslint rule
    `✖ 9890 problems`
- with any propery names
    `✖ 8229 problems`
- without checking properies at all
    `✖ 3683 problems`
- without checking enum members
    `✖ 3231 problems`
- without checking object properties/methods
    `✖ 2978 problems`
- allowing PascalCase for variables
    `✖ 1657 problems
- allowing PascalCase for functions
    `✖ 975 problems
- not checking typeMethod and parameters
    `✖ 916 problems`
- allow double underscore before after variable
    `✖ 461 problems`
- allow snake_case variables
    `✖ 49 problems`

Fix remaining problems.

Future plans. Ban usage of PascalCase for variables that are not components

Reviewed By: LukeDefeo

Differential Revision: D50970193

fbshipit-source-id: d9f3abe6b02c9f7822598c8fa5382f58d067f70e
2023-11-03 06:16:18 -07:00
Lorenzo Blasa
87cb9bd77a Track state changes
Summary: Track server connectivity state changes, queries will follow.

Reviewed By: antonk52

Differential Revision: D50928297

fbshipit-source-id: 9f3a3b799481556bab7339d710736448fed6004c
2023-11-02 10:42:15 -07:00
Lorenzo Blasa
afae1bd141 Track unable to become ready within timeout
Summary: This is currently done by querying the 'console-log' event. Instead, make it type safe and official.

Reviewed By: antonk52

Differential Revision: D50927954

fbshipit-source-id: ff767acdc51b942c6deb92ffbfd93288b3367062
2023-11-02 10:42:15 -07:00
Lorenzo Blasa
d5a0c206f2 Track WS server error
Summary: This is currently done by querying the 'console-log' event. Instead, make it type safe and official.

Reviewed By: antonk52

Differential Revision: D50927803

fbshipit-source-id: e0488782dd584e36b6f742f9892fc09ffaf62469
2023-11-02 10:42:15 -07:00
Lorenzo Blasa
8f1b4ffa1c Track UI launches
Summary: This is currently done by querying the 'console-log' event. Instead, make it type safe and official.

Reviewed By: antonk52

Differential Revision: D50927713

fbshipit-source-id: 780c0f158bf8bdaa6d009035a0cee62c7828f479
2023-11-02 10:42:15 -07:00
Lorenzo Blasa
fecaa8d974 Back out "Use isPWA utility function instead"
Summary:
Original commit changeset: 6bc0c942b3d9

Original Phabricator Diff: D50885337

There's an issue with the import, same reason we do:

```
require('flipper-ui-core').startFlipperDesktop(flipperServer);
```

Reviewed By: aigoncharov

Differential Revision: D50926125

fbshipit-source-id: 04e1b920bcecab9f245924907637b36dac312f1f
2023-11-02 04:28:14 -07:00
Lorenzo Blasa
c8ee1847a2 Flipper browser singleton
Summary:
This will ensure only one instance of Flipper is running at any given point in time.

#thanks antonk52 for guidance and advise implementing a single Flipper instance solution which will improve overall Flipper user experience.

Reviewed By: antonk52

Differential Revision: D50455446

fbshipit-source-id: 2407c77d43ba28e91d525f6cdb11d7b9db1cfab7
2023-11-02 03:31:35 -07:00
Lorenzo Blasa
1a98038979 Use isPWA utility function instead
Summary: As a follow-up from the utility created on the previous diff

Reviewed By: aigoncharov

Differential Revision: D50885337

fbshipit-source-id: 6bc0c942b3d96eb020ec15395f34d5794ba2ae15
2023-11-01 11:15:17 -07:00
Lorenzo Blasa
08e742ceff Utility to determine if client is PWA
Summary: This is currently used in multiple places, let's put it under utils.

Reviewed By: aigoncharov

Differential Revision: D50883125

fbshipit-source-id: ee161a035cd01ca73a2521f813c4b397aa647037
2023-11-01 11:15:17 -07:00
generatedunixname89002005306973
7a6f95d120 Flipper Release: v0.235.0
Summary: Releasing version 0.235.0

Reviewed By: aigoncharov

Differential Revision: D50885746

fbshipit-source-id: 582d6c6373ffcd96572ae59f11709bb2d2741c67
2023-11-01 10:11:43 -07:00
Andrey Goncharov
b4f77da11a Fix unexpected unkown options recognition
Summary:
#thanks LukeDefeo for helping to debug power search

Before:
 https://pxl.cl/3JFqq

Reviewed By: LukeDefeo, lblasa

Differential Revision: D50884084

fbshipit-source-id: 4cf76a73704cda3627b3bb5ab170d6e76df977cf
2023-11-01 07:55:57 -07:00
generatedunixname89002005306973
7bbc386d71 Flipper Release: v0.234.0
Summary: Releasing version 0.234.0

Reviewed By: aigoncharov

Differential Revision: D50878230

fbshipit-source-id: 79a2a01b4e881ae6b97e3616057e759fd4f73c64
2023-11-01 05:11:58 -07:00
Lorenzo Blasa
6dd1fcd569 Set x64 default architecture and .pkg target for RN-only builds
Summary: These are local changes required to make an installer for the last RN-only Electron distribution of Flipper. Instead of just throwing this away, let's keep it in the history of the repository, just in case.

Reviewed By: passy

Differential Revision: D50838207

fbshipit-source-id: 4966e046161e24a616c04d5cf57fee2512f06525
2023-11-01 04:44:48 -07:00
Andrey Goncharov
3706be8b2f Fix power search metrics
Summary: Move them from programmatic API that is barely used to a central place that handles state updates

Reviewed By: lblasa

Differential Revision: D50841152

fbshipit-source-id: 7938ae08629ba05736cb7acba5ca2014e2827acc
2023-10-31 09:51:13 -07:00
Lorenzo Blasa
57d4e86545 Additional troubleshoot guidance for idb
Summary:
Reference:
https://fb.workplace.com/groups/flippersupport/permalink/1717333982080586/

The steps added below seem to have fixed the issue.

Still need to investigate why these steps are needed.

Reviewed By: aigoncharov

Differential Revision: D50797561

fbshipit-source-id: a31c71dbedc506344438082846b41ff16b6f459a
2023-10-31 05:16:21 -07:00
Lorenzo Blasa
560a50485c Improve offline page
Summary:
The previous offline page suggested launching Flipper from terminal by running a command.

Although this works, guidance can be simplified by just instructing users to launch Flipper from within the Applications folder.

Reviewed By: aigoncharov

Differential Revision: D50833741

fbshipit-source-id: 5a41090a66ee62c30cfc35edd69de51ed9cbbab9
2023-10-31 04:45:33 -07:00
69522523c6 Merge branch 'main' of github.com:facebook/flipper into universalBuild 2023-10-31 10:13:43 +01:00
304bd81e07 patches 2023-10-31 10:12:54 +01:00
Lorenzo Blasa
34bbd41547 If unable to load main bundle, retry after 3 seconds
Summary: If we fail to load the main js bundle, retry after 3 seconds.

Reviewed By: aigoncharov

Differential Revision: D50732857

fbshipit-source-id: b19ea165776f8105d724e586b1bed20bf1f5178c
2023-10-27 10:19:33 -07:00
Andrey Goncharov
2c1e814264 Allow power search to be controlled externally
Reviewed By: LukeDefeo

Differential Revision: D50732883

fbshipit-source-id: a19932b5a3f319fd1dc45572fef251369283cc61
2023-10-27 05:45:28 -07:00
Lorenzo Blasa
f0023ea79d If there's an existing problem, show regardless
Summary:
Setup Doctor can be used to discover installation issues. I've seen numerous times when there's a setup issue but users didn't check / bother with using the tool.

Instead, if there's an issue, show the screen regardless.

Reviewed By: mweststrate

Differential Revision: D50642080

fbshipit-source-id: 10eb7a758a61765a5b06d398f5041897fff6280e
2023-10-27 03:12:03 -07:00
Luke De Feo
f3449a5641 Make panel adhere to Figma design
Summary: css to change the header styling

Reviewed By: lblasa

Differential Revision: D50595982

fbshipit-source-id: 836ea7881426e95abb449c085fca39606cd8cfdd
2023-10-26 05:24:30 -07:00
Luke De Feo
115cb1af71 Dont show empty subsections
Summary: changelog: UIDebugger - new sidebar design

Reviewed By: lblasa

Differential Revision: D50653551

fbshipit-source-id: 8a173abb033f35ba6abd2d5f417e647ca2ffe8e7
2023-10-26 05:24:30 -07:00
Luke De Feo
20a1b9d255 format numbers
Reviewed By: lblasa

Differential Revision: D50653525

fbshipit-source-id: 265a2821acef572ca6d9576be647ee1d07f3850e
2023-10-26 05:24:30 -07:00
Luke De Feo
8af6ca7f02 Shrink input size (final )
Summary:
Allows more content on screen. Final diff of stack

Changelog: UIDebugger, new sidebar design

Reviewed By: lblasa

Differential Revision: D50595987

fbshipit-source-id: 436af4191dba37f7a0f41dca23ab6349856358cd
2023-10-26 05:24:30 -07:00
Luke De Feo
aafd7e12df Add raw data panel
Reviewed By: lblasa

Differential Revision: D50595980

fbshipit-source-id: 3679d53cfbfe38ab466d96efe39928c0299fb4d5
2023-10-26 05:24:30 -07:00
Luke De Feo
457361985c Basic filtering
Summary: This filtering scheme is extremely basic, we only filter based on top level fields. Other schemes I considered were somewhat confusing and this works well in most if not all cases

Reviewed By: lblasa

Differential Revision: D50595986

fbshipit-source-id: 90cb82f8fc482fd4c6f996ff9e857f27766df544
2023-10-26 05:24:30 -07:00
Luke De Feo
ce693ef33e Handle inspectable array
Summary: This was not handled and arrays were not properly transformed

Reviewed By: lblasa

Differential Revision: D50595983

fbshipit-source-id: cae8777c653cc9fc2a1ea8cab05b3df476121855
2023-10-26 05:24:30 -07:00
Luke De Feo
fa2845d86d Use text for tab headings
Summary: Use text for tab headings

Reviewed By: lblasa

Differential Revision: D50595976

fbshipit-source-id: c062bb984ef83d76761e1deb9f24ec095099bd98
2023-10-26 05:24:30 -07:00
Luke De Feo
1b0eb31bd9 Default to first tab if active tab not available
Summary:
This is only really an issue in theUIDebugger where we have a dynamic number of tabs. on some nodes you have 3 tabs, on others you have 2. if you select the 3rd tab and move to a node with 2 tabs nothing will be selected.

With this fix we will fallback to the first tab

Reviewed By: lblasa

Differential Revision: D50595977

fbshipit-source-id: 25c36a5609f774c2d3fd650eb6520104864fbe95
2023-10-26 05:24:30 -07:00
Luke De Feo
184316545a Treat unknown as text
Reviewed By: lblasa

Differential Revision: D50595978

fbshipit-source-id: 867eb08c3ab365a808d5c7b53a7772298e9c9156
2023-10-26 05:24:30 -07:00
Luke De Feo
b4d80c3f80 Add support for complex types
Summary:
Complex nested arrays and objects are displayed in a modal since there isnt enough space to it practically.

Not many attributes in practice fall into this category

Reviewed By: lblasa

Differential Revision: D50595981

fbshipit-source-id: b1eda93c448de19c8803d64eb4cf105e2b6636a8
2023-10-26 05:24:30 -07:00
Luke De Feo
f5d974a26c Add support for color
Summary: we show rbga on one line, and hex + preview on second line

Reviewed By: lblasa

Differential Revision: D50595979

fbshipit-source-id: 86015ceeb5e64e67fb85e3431f85916f7d175ca2
2023-10-26 05:24:30 -07:00
Luke De Feo
65de40be7c Add support for Subsections
Summary:
in the figma design we have the concept of subsections which are single level deep objects shown inline
{F1126292520}

More complex nested objects are shown a a preview that you have to click on and will come later

Reviewed By: lblasa

Differential Revision: D50595984

fbshipit-source-id: ea831731b87ce9968516129cf177953e200cf4d5
2023-10-26 05:24:30 -07:00
Luke De Feo
b184500d94 New sidebar design 1/n
Summary: Added basic infra basic types

Reviewed By: lblasa

Differential Revision: D50595985

fbshipit-source-id: 48ebd74bd8ccebdd8a6d69dbda344b8d831dc04f
2023-10-26 05:24:30 -07:00
Pascal Hartig
50b06f2efd Remove unused eventemitter 3
Summary: This seems to be (no longer) in use.

Reviewed By: lblasa

Differential Revision: D50659072

fbshipit-source-id: 0fde643711ee4859a5d270a878d858694337d6a5
2023-10-26 03:05:02 -07:00
Pascal Hartig
abefa2165f Remove unused reconnecting-websocket dep
Summary: This seems to be (no longer) in use.

Reviewed By: lblasa

Differential Revision: D50645304

fbshipit-source-id: 6d8e89a376f57e9dccafe899cfb2be85271329c9
2023-10-26 03:05:02 -07:00
Pascal Hartig
ecfa9451db Remove unused which dependency
Summary: This seems to be (no longer) in use.

Reviewed By: lblasa

Differential Revision: D50645270

fbshipit-source-id: 69cf276f97d960a16ffd3e48342420b33fa646da
2023-10-26 03:05:02 -07:00
generatedunixname89002005306973
554cc88462 Flipper Release: v0.233.0
Summary: Releasing version 0.233.0

Reviewed By: lblasa

Differential Revision: D50642810

fbshipit-source-id: 6c42fdbdf61aed5c0af11dbb781496a917c44b8c
2023-10-25 06:57:03 -07:00
Andrey Goncharov
8c5078dc08 Catch sync errors while starting HTTP server
Reviewed By: lblasa

Differential Revision: D50636260

fbshipit-source-id: f23fb2005c779b87122ae34bfdd9371d8bdec8b4
2023-10-25 04:52:00 -07:00
Andrey Goncharov
97f01d0057 Check certs are good for TLS
Reviewed By: lblasa

Differential Revision: D50496418

fbshipit-source-id: fb4ee3a91b50d0e02f8b1d0e4618a510cf0c3a54
2023-10-25 04:52:00 -07:00
Lorenzo Blasa
da7917cefe No not delegate launch to Flipper Launcher
Summary: ^

Reviewed By: aigoncharov

Differential Revision: D50557385

fbshipit-source-id: d9571dda36520eae19f2d5fda4f52807f439a4e1
2023-10-24 07:18:43 -07:00