jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix power search metrics

Browse Source 
Summary: Move them from programmatic API that is barely used to a central place that handles state updates

Reviewed By: lblasa

Differential Revision: D50841152

fbshipit-source-id: 7938ae08629ba05736cb7acba5ca2014e2827acc
This commit is contained in:
Andrey Goncharov
2023-10-31 09:51:13 -07:00
committed by Facebook GitHub Bot
parent 8086816f82
commit 3706be8b2f
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
desktop/flipper-plugin/src/ui/data-table/DataTableManager.tsx
View File

@@ -223,6 +223,7 @@ export const dataTableManagerReducer = produce<
break;
}
case 'setSearchValue': {
getFlipperLib().logger.track('usage', 'data-table:filter:search');
draft.searchValue = action.value;
draft.previousSearchValue = '';
draft.filterExceptions = undefined;
@@ -240,6 +241,7 @@ export const dataTableManagerReducer = produce<
break;
}
case 'toggleSearchValue': {
getFlipperLib().logger.track('usage', 'data-table:filter:toggle-search');
draft.filterExceptions = undefined;
if (draft.searchValue) {
draft.previousSearchValue = draft.searchValue;
@@ -297,6 +299,7 @@ export const dataTableManagerReducer = produce<
break;
}
case 'addColumnFilter': {
getFlipperLib().logger.track('usage', 'data-table:filter:add-column');
draft.filterExceptions = undefined;
addColumnFilter(
draft.columns,
@@ -307,6 +310,7 @@ export const dataTableManagerReducer = produce<
break;
}
case 'removeColumnFilter': {
getFlipperLib().logger.track('usage', 'data-table:filter:remove-column');
draft.filterExceptions = undefined;
const column = draft.columns.find((c) => c.key === action.column)!;
const index =
@@ -321,6 +325,7 @@ export const dataTableManagerReducer = produce<
break;
}
case 'toggleColumnFilter': {
getFlipperLib().logger.track('usage', 'data-table:filter:toggle-column');
draft.filterExceptions = undefined;
const column = draft.columns.find((c) => c.key === action.column)!;
const index =
@@ -486,7 +491,6 @@ export function createDataTableManager<T>(
dispatch({type: 'sortColumn', column, direction});
},
setSearchValue(value, addToHistory = false) {
getFlipperLib().logger.track('usage', 'data-table:filter:search');
dispatch({type: 'setSearchValue', value, addToHistory});
},
toggleSearchValue() {
@@ -508,11 +512,9 @@ export function createDataTableManager<T>(
dispatch({type: 'setShowNumberedHistory', showNumberedHistory});
},
addColumnFilter(column, value, options = {}) {
getFlipperLib().logger.track('usage', 'data-table:filter:add-column');
dispatch({type: 'addColumnFilter', column, value, options});
},
removeColumnFilter(column, label) {
getFlipperLib().logger.track('usage', 'data-table:filter:remove-column');
dispatch({type: 'removeColumnFilter', column, label});
},
setFilterExceptions(exceptions: string[] | undefined) {

1
desktop/flipper-plugin/src/ui/data-table/DataTableWithPowerSearchManager.tsx
View File

@@ -303,7 +303,6 @@ export function createDataTableManager<T>(
dispatch({type: 'sortColumn', column, direction});
},
setSearchExpression(searchExpression) {
getFlipperLib().logger.track('usage', 'data-table:power-search:search');
dispatch({type: 'setSearchExpression', searchExpression});
},
toggleSideBySide() {