jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
9,282 Commits 1 Branch 0 Tags
universalBuild
Commit Graph

404 Commits

Author SHA1 Message Date
Andrey Goncharov
b4b9c0ab28 Implement receiving messages from add-on on the client 
Reviewed By: mweststrate

Differential Revision: D34249101

fbshipit-source-id: 07297b84ed8640e3b41599726ba613b6b4e2b62e
 2022-02-28 03:50:34 -08:00
Andrey Goncharov
4067f5bd88 Implement sending messages from desktop to add-on 
Reviewed By: antonk52

Differential Revision: D34239803

fbshipit-source-id: 1a18d522ba877ade3d0703fbb374c15b596241d7
 2022-02-28 03:50:34 -08:00
Andrey Goncharov
3b390b74ff Track client connections and autostop server add-ons when all clients leave 
Reviewed By: mweststrate

Differential Revision: D34045584

fbshipit-source-id: 1ad0cfffb9d304f0359c973d76d6956f7e932f72
 2022-02-28 03:50:34 -08:00
Andrey Goncharov
9113006851 Make Client initialize server add-ons 
Reviewed By: mweststrate

Differential Revision: D34044353

fbshipit-source-id: 99bcb1559787b2a904bdd796233666a7a4783ea4
 2022-02-28 03:50:34 -08:00
Anton Nikolaev
38c81ca159 Make internal plugin distribution code publicly available (#3473) 
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/3473

This diff is the first one which addresses https://github.com/facebook/flipper/issues/3320.

In this diff we are making a part of the code used for internal Flipper plugin distribution in Meta also available publicly for re-using in other orgs.

Some explanation on how plugin installation and updates is designed now:
1) We periodically poll for plugins available for download. API for retrieving available plugins list is abstracted and will be different between public and fb versions, however all other logic is re-used.
2) In addition to "Enabled" and "Disabled" plugins in the left panel Flipper shows "Detected in App" list. Plugins in this list are those which are known compatible with the currently selected device/app, but not yet installed.
3) User can install any of "Detected in App" plugins by clicking to "Download and install" button near them in the left panel similarly to enabling plugins in "Disabled" list.
4) If we detect that for some installed plugin we have a newer version available for download - we download it silently and store on disk.
5) If the plugin for which we have new downloaded version is disabled - we update it silently without any notifications by loading new version from the disk and unloading the previous version from cache.
6) If the plugin for which we have new downloaded version is enabled then we avoid updating it automatically (because we need to reset plugin state in such case) and instead show notification on top of the plugin and ask user to reload it to apply new version. On reloading we reset the plugin state.
7) On Flipper startup we always update all plugins to their latest versions available on the disk.

Reviewed By: aigoncharov

Differential Revision: D34380308

fbshipit-source-id: a94d724e42aa5ef78445af266fcd4c424226a703
 2022-02-22 05:23:05 -08:00
Anton Nikolaev
5da0a83a36 Refactor recommended plugin API 
Summary:
This is just refactoring in preparation to open-sourcing internal plugin distribution code to make it available for other orgs so they can distribute their internal plugins. See other diffs in the same stack.

This diff moves recommended plugins handling from `pluginMarketplace` which will be the same for fb-internal and OS versions into `pluginMarketplaceAPI` which will differ for fb-internal and OS versions. This will make it possible for other orgs to define their own "recommended" plugins which then will be automatically installed/enabled for new users.

Reviewed By: aigoncharov

Differential Revision: D34379981

fbshipit-source-id: 5c3a4efb6d0171256cf508f9005d914d7332e14f
 2022-02-22 05:23:05 -08:00
Lorenzo Blasa
77ab722b52 Better notification messaging 
Summary:
'Failed to start connection server' is a bit misleading. 'server-error' is used for both server and client errors.
Changelog: Better notification messaging

Reviewed By: aigoncharov

Differential Revision: D34269045

fbshipit-source-id: f51a28fc0e9ba394b464e5bfca4d0e497f740b1b
 2022-02-16 05:22:35 -08:00
Pascal Hartig
1910d3b713 Bump dependencies in /desktop 
Summary: Combining green-ticked upgrades from GitHub into one push.

Reviewed By: lblasa

Differential Revision: D34212788

fbshipit-source-id: 12b207a05b9df08eac5b5c58fe1025932c448258
 2022-02-14 09:55:15 -08:00
Michel Weststrate
762267bccc Fix name casing to make plugin more easily findable 
Summary:
Noticed in https://fb.workplace.com/groups/flippersupport/permalink/1305583723255616/ that always shows at the end of the plugin list.

Fixed this on two levels:
1. uppercase the title for consistency
2. Make sorting case insensitive

Differential Revision: D33985518

fbshipit-source-id: 70bed519e1ae5b3251b103931472844b2b55a512
 2022-02-04 01:15:42 -08:00
Michel Weststrate
e4a3696fd5 Don't create always rejecting promises for timeout 
Summary:
Our existing `timeout` implementation was always throwing an exception, due to sleeping and then throw an exception, which is than handled but ignored by `Promise.race`.

This implementation has a few problems

1. Because it always throws, having a debugger session with 'break on caught exceptions' will pause on every usage of timeout (rather than just the ones that actually timeout). This makes this way of debugging a bit useless.
2. Throwing exceptions is in principle an expensive process (due to the stack trace generation)
3. Not cancelling the timeout used by sleep is a bit of a waste as well

Reviewed By: lawrencelomax

Differential Revision: D33982717

fbshipit-source-id: d739c02112e1c1bc4cd691af852371d08a99abc6
 2022-02-04 01:15:41 -08:00
Bartosz Kaszubowski
6639b547dd UI: fix hover effect of LeftRail icons with badge (#3372) 
Summary:
This PR fixes the missing hover effect for the `LeftRail` component buttons, when they have included the badge.

To fix the issue, I had to wrap the whole `Button` with `Badge` component (instead wrapping only around icon). However, this solution required to added `offset` property to the `Badge` which moves the indicator to the position prior change (otherwise indicator was moved to the right corner of the button).

The file has been formatted after the changes with ESLint.

**Edit:** I have also spotted that this change fixes the icon placement inside the button, when badge is present. Earlier, as seen below, the log icon was moved towards the top of the button:
<img width="111" alt="Screenshot 2022-01-31 at 00 57 49" src="https://user-images.githubusercontent.com/719641/151723422-0ffb83ee-5806-412e-9191-f9953f78532e.png">

## Changelog

[desktop] UI: fix hover effect of LeftRail icons with badge

Pull Request resolved: https://github.com/facebook/flipper/pull/3372

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### Before
<img width="1339" alt="Screenshot 2022-01-31 at 00 24 23" src="https://user-images.githubusercontent.com/719641/151722800-a2f3dd44-aa24-4858-b43e-0620b1f2ae65.png">

#### After

> I have used mocked indicator values locally to ensure that the Badges are displayed correctly.

<img width="1339" alt="Screenshot 2022-01-31 at 00 26 10" src="https://user-images.githubusercontent.com/719641/151722795-745b04ac-9ee4-49a8-8217-206d8d7456e6.png">

<img width="1339" alt="Screenshot 2022-01-31 at 00 45 08" src="https://user-images.githubusercontent.com/719641/151722940-aaaf0e9b-f2d1-4245-8b2b-cfc11052b39e.png">

Reviewed By: aigoncharov

Differential Revision: D33975324

Pulled By: mweststrate

fbshipit-source-id: fe4773b4825b9f22e01821e45259747d319233aa
 2022-02-03 05:54:03 -08:00
dependabot[bot]
a0ec82c981 Bump @emotion/react from 11.6.0 to 11.7.1 in /desktop (#3388) 
Summary:
Bumps [emotion/react](https://github.com/emotion-js/emotion) from 11.6.0 to 11.7.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@​emotion/react</code>'s releases</a>.</em></p>
<blockquote>
<h2><code>@​emotion/react</code><a href="https://github.com/11"><code>@​11</code></a>.7.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>
<p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2577">https://github.com/facebook/flipper/issues/2577</a> <a href="04681a5f52"><code>04681a5f</code></a> Thanks <a href="https://github.com/Methuselah96"><code>@​Methuselah96</code></a>! - Export <code>Keyframes</code> type to avoid TypeScript inserting <code>import(&quot;emotion/serialize&quot;).Keyframes</code> references into declaration files emitted based on a source files exporting <code>keyframes</code> result. This avoids issues with strict package managers that don't allow accessing undeclared dependencies.</p>
</li>
<li>
<p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2590">https://github.com/facebook/flipper/issues/2590</a> <a href="1554a7e264"><code>1554a7e2</code></a> Thanks <a href="https://github.com/Andarist"><code>@​Andarist</code></a>! - Upgraded and pinned the version of Stylis - the CSS parser that Emotion uses under the hood.</p>
</li>
<li>
<p>Updated dependencies [<a href="1554a7e264"><code>1554a7e2</code></a>]:</p>
<ul>
<li><code>@​emotion/cache</code><a href="https://github.com/11"><code>@​11</code></a>.7.1</li>
</ul>
</li>
</ul>
<h2><code>@​emotion/react</code><a href="https://github.com/11"><code>@​11</code></a>.7.0</h2>
<h3>Patch Changes</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2534">https://github.com/facebook/flipper/issues/2534</a> <a href="57be9e8cb2"><code>57be9e8c</code></a> Thanks <a href="https://github.com/srmagura"><code>@​srmagura</code></a>! - Changed the implementation of the runtime label extraction in elements using the css prop (that only happens in development) to one that should yield more consistent results across browsers. This fixes some minor issues with React reporting hydration mismatches that wouldn't happen in production.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="01cca604ca"><code>01cca60</code></a> Version Packages (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2581">https://github.com/facebook/flipper/issues/2581</a>)</li>
<li><a href="1554a7e264"><code>1554a7e</code></a> Stylis upgrade (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2590">https://github.com/facebook/flipper/issues/2590</a>)</li>
<li><a href="04681a5f52"><code>04681a5</code></a> Export Keyframes type from <code>@​emotion/react</code> (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2577">https://github.com/facebook/flipper/issues/2577</a>)</li>
<li><a href="26ded6109f"><code>26ded61</code></a> Tweak grammar in the CHANGELOGs</li>
<li><a href="200bc6a56b"><code>200bc6a</code></a> Version Packages (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2564">https://github.com/facebook/flipper/issues/2564</a>)</li>
<li><a href="f046ae40bc"><code>f046ae4</code></a> Add ESLint 8 to the peer dependency range  (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2562">https://github.com/facebook/flipper/issues/2562</a>)</li>
<li><a href="57be9e8cb2"><code>57be9e8</code></a> Extract, unit test, and improve getLabelFromStackTrace (<a href="https://github-redirect.dependabot.com/emotion-js/emotion/issues/2534">https://github.com/facebook/flipper/issues/2534</a>)</li>
<li>See full diff in <a href="https://github.com/emotion-js/emotion/compare/emotion/react@11.6.0...@emotion/react@11.7.1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@emotion/react&package-manager=npm_and_yarn&previous-version=11.6.0&new-version=11.7.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3388

Reviewed By: nikoant

Differential Revision: D33892154

Pulled By: cekkaewnumchai

fbshipit-source-id: 460e820c36c367a4174e7cc44bc4d23340db020a
 2022-02-02 11:14:39 -08:00
Anton Kastritskiy
f2abbf63db ban interface usage for component props and state 
Summary: another eslint rule for flipper codebase

Reviewed By: passy

Differential Revision: D33917213

fbshipit-source-id: e60b867d359ef5b94a481edf0eda318ecff17eee
 2022-02-02 05:09:45 -08:00
Anton Kastritskiy
c5dd1fc350 rename files from ts to tsx in flipper-* packages 
Summary: mass files rename

Reviewed By: nikoant

Differential Revision: D33890252

fbshipit-source-id: d5afaa60af7340313a97d8e4967fe37f00abd9db
 2022-01-31 10:16:19 -08:00
dependabot[bot]
e9da574720 Bump antd from 4.18.2 to 4.18.5 in /desktop (#3346) 
Summary:
Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.2 to 4.18.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<hr />
<ul>
<li>Cascader
<ul>
<li>🐞 修复 Cascader 弹层超出屏幕时不会自动偏移以及激活选项不会自动滚动到正确位置的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
<li>💄 修复 Cascader 加载中图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
</ul>
</li>
<li>💄 修复 Tag 在暗黑主题下的样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 修复 Tooltip 的子元素含有禁用态的 CheckBox 时可能引起的行为和样式异常。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ 优化 Row 和 Layout.Sider 的 hooks 依赖数组。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 修复 Card <code>ref</code> 不生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 修复动态修改 Checkbox 的 <code>value</code> 时 <code>onChange</code> 不能正确传入修改后的值的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<ul>
<li>Typography
<ul>
<li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code>&lt;Icon component={HomeOutlined} /&gt;</code> and <code>&lt;HomeOutlined /&gt;</code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@​toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
</ul>
<hr />
<ul>
<li>Typography
<ul>
<li>⚡️ 优化 Typography 在配置 <code>tooltip</code> 时优先使用原生省略样式以提升性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 重构 Typography <code>ellipsis</code> 逻辑以修复 <code>children</code> 如果消费上游 Context 会报错的问题。 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 修复 <code>&lt;Icon component={HomeOutlined} /&gt;</code> 和 <code>&lt;HomeOutlined /&gt;</code> 不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">#33709</a></li>
<li>🐞 修复 <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> 抖动的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 修复 Input 相关组件设置 <code>hidden</code> 时的展示问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a>，<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 修复 Input 传入 <code>showCount</code> 时控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ 修复 ConfigProvider 和 Anchor 的渲染函数多次运行的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 修复 Cascader 组件中出现重复 key 的控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group 的 <code>options</code> 支持数组中直接传入 number 和 boolean 类型。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.18.5</h2>
<p><code>2022-01-24</code></p>
<ul>
<li>Cascader
<ul>
<li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li>
<li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li>
</ul>
</li>
<li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li>
<li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@​boomler</code></a></li>
<li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li>
</ul>
<h2>4.18.4</h2>
<p><code>2022-01-18</code></p>
<ul>
<li>Typography
<ul>
<li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li>
<li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li>
</ul>
</li>
<li>Icon
<ul>
<li>🐞 Fix <code>&lt;Icon component={HomeOutlined} /&gt;</code> and <code>&lt;HomeOutlined /&gt;</code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li>
<li>🐞 Fix <code>&lt;Icon component={SyncOutlined} spin /&gt;</code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@​JX-Zhuang</code></a></li>
</ul>
</li>
<li>Input
<ul>
<li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@​hydraZty</code></a></li>
<li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@​whwangms</code></a></li>
</ul>
</li>
<li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@​mrwd2009</code></a></li>
<li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@​dimbslmh</code></a></li>
<li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li>
<li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li>
<li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@​toSayNothing</code></a></li>
<li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@​fanerge</code></a></li>
<li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li>
<li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
</ul>
<h2>4.18.3</h2>
<p><code>2022-01-10</code></p>
<ul>
<li>🆕 Menu support <code>home</code> and <code>end</code> keyboard navigate. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33642">#33642</a> <a href="https://github.com/dartamonov-vertex"><code>@​dartamonov-vertex</code></a></li>
<li>Table
<ul>
<li>⚡️ Improve Table perfermance significantly when mount and unmount. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33554">#33554</a></li>
<li>🐞 Fix Table emptynode fixed display. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33610">#33610</a> <a href="https://github.com/hemengke1997"><code>@​hemengke1997</code></a></li>
<li>🐞 Fix Table tree data hover error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33638">#33638</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
</ul>
</li>
<li>Form
<ul>
<li>🐞 Fix Form validateMessages is not correct in default locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33511">#33511</a></li>
<li>🐞 Fix Form.Item help with empty string makes layout shaking. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33644">#33644</a></li>
</ul>
</li>
<li>🐞 Fix Input.Textarea throws error on preact. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33536">#33536</a> <a href="https://github.com/developit"><code>@​developit</code></a></li>
<li>🐞 Fix PageHeader state update error after unmounted. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33546">#33546</a> <a href="https://github.com/wuifdesign"><code>@​wuifdesign</code></a></li>
<li>💄 Fix Select tag margin issue when using <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33539">#33539</a></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8217c544da"><code>8217c54</code></a> docs(✨): release 4.18.5 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33822">#33822</a>)</li>
<li><a href="578aaad7f2"><code>578aaad</code></a> test: fix lint</li>
<li><a href="ab8fc12fa7"><code>ab8fc12</code></a> docs: add Plasmic for Ant (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33758">#33758</a>)</li>
<li><a href="a65ba8aa8a"><code>a65ba8a</code></a> docs: update sentence structure in the FAQ section (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33816">#33816</a>)</li>
<li><a href="e55a68670f"><code>e55a686</code></a> chore(deps): update dependency simple-git to v3 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33817">#33817</a>)</li>
<li><a href="fe23374871"><code>fe23374</code></a> fix: Invalid hook dependency array in Sider and Row (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33804">#33804</a>)</li>
<li><a href="75adc23fe3"><code>75adc23</code></a> chore: i18n contributing docs improve (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33760">#33760</a>)</li>
<li><a href="9cf0dca8fc"><code>9cf0dca</code></a> test: fix cascader test coverage (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33802">#33802</a>)</li>
<li><a href="5d2994ec12"><code>5d2994e</code></a> style: Cascader loading icon (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33799">#33799</a>)</li>
<li><a href="6dd39c1f89"><code>6dd39c1</code></a> fix(checkbox): disabled checkbox should works well with tooltip (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33772">#33772</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.18.2...4.18.5">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.18.2&new-version=4.18.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3346

Reviewed By: aigoncharov

Differential Revision: D33741775

Pulled By: lblasa

fbshipit-source-id: 82e770ed1c09d3a7f9d71a950014d3555c9367fd
 2022-01-28 03:09:50 -08:00
dependabot[bot]
1262ee05f1 Bump react-debounce-render from 7.0.0 to 7.0.1 in /desktop (#3351) 
Summary:
Bumps [react-debounce-render](https://github.com/podefr/react-debounce-render) from 7.0.0 to 7.0.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/podefr/react-debounce-render/commits">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=react-debounce-render&package-manager=npm_and_yarn&previous-version=7.0.0&new-version=7.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3351

Reviewed By: mweststrate

Differential Revision: D33741785

Pulled By: lblasa

fbshipit-source-id: 4ceee9922dd80ec2ec47b9826fd8da09cd551122
 2022-01-27 05:22:43 -08:00
Simek
f08bcb2a2c tweak dark mode theme colors, improve LeftRail UI (#3335) 
Summary:
Currently the design of `LeftRail` varies a bit between light and dark modes. Additionally washed background color is hard to differentiate from the main background color in comparison to the light theme (See `LeftRail` sidebars toggle buttons background for example). This lead to few contrast related issues, for example the hover effect on the WelcomeScreen elements is not visible in dark mode.

The PR tweaks the dark mode theme colors and fixes the unnecessary background of Settings icon in dark mode.

I have also spotted that icon `hover` effect is not working when icon has a badge (pure dot or count), I might have an idea how to fix this and I will push another PR for that. 🙂

## Changelog

* tweak dark mode theme colors, improve LeftRail UI

Pull Request resolved: https://github.com/facebook/flipper/pull/3335

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

<img width="390" alt="Screenshot 2022-01-24 at 13 37 20" align="left" src="https://user-images.githubusercontent.com/719641/150784627-36e222a8-e53e-4409-ab72-783d4a594f8e.png">
<img width="390" alt="Screenshot 2022-01-24 at 13 46 08" src="https://user-images.githubusercontent.com/719641/150785438-bb496adf-83ab-4b1c-928d-07f4b0098f1a.png">

Reviewed By: antonk52

Differential Revision: D33741513

Pulled By: lblasa

fbshipit-source-id: ef187db0725ac2b04c09b7f06823e713b50be88f
 2022-01-27 04:45:19 -08:00
Simek
903476bdad use centered prop for variable height modals (#3334) 
Summary:
Currently all of the modals are displayed using default positioning, which works fine for small modals and large app windows, but it cause small UI/UX issues (double scroll bars) when app window is quite small.

Adding [`centered` prop](https://ant.design/components/modal/#API) for variable height modals improves this situation a bit, but it also changes a bit the modal position when using maximised window, but I think this is bearable looking at improvements gained when window size is reduced.

## Changelog

* use `centered` prop for variable height modals to improve UI in small app window

Pull Request resolved: https://github.com/facebook/flipper/pull/3334

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### Small App Window
<img width="390" alt="Screenshot 2022-01-24 at 11 58 40" align="left" src="https://user-images.githubusercontent.com/719641/150771900-cb25d110-82c7-4ba9-8ee5-07a093c4f702.png">
<img width="390" alt="Screenshot 2022-01-24 at 11 58 37" src="https://user-images.githubusercontent.com/719641/150771911-c81592ac-1eba-4112-86ad-9549e6248239.png">

<img width="390" alt="Screenshot 2022-01-24 at 12 00 13" align="left" src="https://user-images.githubusercontent.com/719641/150772045-de37c432-4381-4207-8476-5f142dfb6fa5.png">
<img width="390" alt="Screenshot 2022-01-24 at 12 00 10" src="https://user-images.githubusercontent.com/719641/150772057-574cf6cd-6f1a-4ca2-a343-b8fd6342eddb.png">

#### Maximised App Window
<img width="390" alt="Screenshot 2022-01-24 at 12 12 12" align="left" src="https://user-images.githubusercontent.com/719641/150772777-8ac3cb59-3b41-4dcb-9554-137e95857af8.png">
<img width="390" alt="Screenshot 2022-01-24 at 12 12 29" src="https://user-images.githubusercontent.com/719641/150772758-ca9f8c20-d6d0-412d-9067-7e756da0b56c.png">

Reviewed By: mweststrate

Differential Revision: D33741484

Pulled By: lblasa

fbshipit-source-id: 0c3ca883d051cf4fcce9f9c1b6688974b66fd0d8
 2022-01-26 04:23:05 -08:00
dependabot[bot]
3764b5aa2d Bump immer from 9.0.7 to 9.0.12 in /desktop (#3345) 
Summary:
Bumps [immer](https://github.com/immerjs/immer) from 9.0.7 to 9.0.12.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/immerjs/immer/releases">immer's releases</a>.</em></p>
<blockquote>
<h2>v9.0.12</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.11...v9.0.12">9.0.12</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>produceWithPatches should not wrap result in Immutable, fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/850">https://github.com/facebook/flipper/issues/850</a>, <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/881">https://github.com/facebook/flipper/issues/881</a> (<a href="d8f26362a9">d8f2636</a>)</li>
</ul>
<h2>v9.0.11</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.10...v9.0.11">9.0.11</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>incorrect patches for <code>delete</code> on arrays. Fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/879">https://github.com/facebook/flipper/issues/879</a> (<a href="d91a6597e9">d91a659</a>)</li>
</ul>
<h2>v9.0.10</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.9...v9.0.10">9.0.10</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>No patches being generated for root primitive replacements. Fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/888">https://github.com/facebook/flipper/issues/888</a> (<a href="0f96270840">0f96270</a>)</li>
</ul>
<h2>v9.0.9</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.8...v9.0.9">9.0.9</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>make sure produceWithPatches accepts promises (<a href="d80e823733">d80e823</a>)</li>
</ul>
<h2>v9.0.8</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.7...v9.0.8">9.0.8</a> (2022-01-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>immerjs<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/876">https://github.com/facebook/flipper/issues/876</a> Ensure empty patch set for atomic set+delete on Map (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/878">https://github.com/facebook/flipper/issues/878</a>) (<a href="e1409180eb">e140918</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="d8f26362a9"><code>d8f2636</code></a> fix: produceWithPatches should not wrap result in Immutable, fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/850">https://github.com/facebook/flipper/issues/850</a>, <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/881">https://github.com/facebook/flipper/issues/881</a></li>
<li><a href="feba5d1404"><code>feba5d1</code></a> chore: remove debugger statement</li>
<li><a href="d91a6597e9"><code>d91a659</code></a> fix: incorrect patches for <code>delete</code> on arrays. Fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/879">https://github.com/facebook/flipper/issues/879</a></li>
<li><a href="0f96270840"><code>0f96270</code></a> fix: No patches being generated for root primitive replacements. Fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/888">https://github.com/facebook/flipper/issues/888</a></li>
<li><a href="d80e823733"><code>d80e823</code></a> fix: make sure produceWithPatches accepts promises</li>
<li><a href="e1409180eb"><code>e140918</code></a> fix: immerjs#876 Ensure empty patch set for atomic set+delete on Map (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/878">https://github.com/facebook/flipper/issues/878</a>)</li>
<li>See full diff in <a href="https://github.com/immerjs/immer/compare/v9.0.7...v9.0.12">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=immer&package-manager=npm_and_yarn&previous-version=9.0.7&new-version=9.0.12)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3345

Reviewed By: antonk52

Differential Revision: D33741770

Pulled By: lblasa

fbshipit-source-id: 2f52bee684c99d171c1e3460825c557b027e8cf0
 2022-01-25 03:30:52 -08:00
Simek
1c91d28390 improve dev perf canvas readability (#3333) 
Summary:
This PR updates the performance Canvas widgets readability in Dev mode.

Currently, for unknown for me reason, the text was rendered with stroke not fill, which results in blurry text.

Also the color of texts and plot in light mode have not enough contrast in comparison to the background. I have tried to use `theme` in there, but unfortunately the CSS variables are not available in the Canvas context and using those values leads to always black text.

## Changelog

* improve the performance canvas widgets readability in Development mode

Pull Request resolved: https://github.com/facebook/flipper/pull/3333

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### Dark Mode
<img width="189" alt="Screenshot 2022-01-23 at 17 46 20" align="left" src="https://user-images.githubusercontent.com/719641/150689046-28895487-d488-440f-9440-f792daeca86f.png">
<img width="189" alt="Screenshot 2022-01-23 at 17 54 59" src="https://user-images.githubusercontent.com/719641/150689179-5ef96ca3-78e0-4995-b60c-317a87082604.png">

#### Light Mode
<img width="189" alt="Screenshot 2022-01-23 at 17 46 27" align="left" src="https://user-images.githubusercontent.com/719641/150689061-a3264961-390a-4182-bd81-ba84b6e4979f.png">
<img width="189" alt="Screenshot 2022-01-23 at 17 55 09" src="https://user-images.githubusercontent.com/719641/150689188-17efc7d9-7add-409e-af3b-befa5fbba0bc.png">

Reviewed By: aigoncharov

Differential Revision: D33738722

Pulled By: lblasa

fbshipit-source-id: b992ecacd31bb6aa2a53885ca6dcc858fa510775
 2022-01-24 08:52:22 -08:00
Simek
1fef844878 fix ReleaseChannel info in WelcomeScreen in dark mode (#3328) 
Summary:
This PR fixes the color of ReleaseChannel information in the WelcomeScreen, when user uses dark mode.

I have decided to switch to `textColorSecondary` instead of `textColorPrimary` to emphasise a bit more the information, but I can change it to the primary color if you think it will fit there better. Also the font size has been adjusted to match the paragraph font size.

## Changelog

* fix ReleaseChannel info in WelcomeScreen in dark mode

Pull Request resolved: https://github.com/facebook/flipper/pull/3328

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview

#### Dark Mode (before & after)

<img width="333" alt="Screenshot 2022-01-23 at 15 14 12" align="left" src="https://user-images.githubusercontent.com/719641/150682951-6e256054-d8d9-4293-8f76-4d67b654482f.png">
<img width="333" alt="Screenshot 2022-01-23 at 15 09 58" src="https://user-images.githubusercontent.com/719641/150682954-942eda7a-443d-4ca1-be51-b6d0036548cd.png">

#### Light Mode
<img width="333" alt="Screenshot 2022-01-23 at 15 22 42" src="https://user-images.githubusercontent.com/719641/150683094-62983788-646e-4745-b9c0-3c7f7bea9787.png">

Reviewed By: aigoncharov

Differential Revision: D33738596

Pulled By: lblasa

fbshipit-source-id: 2fdd18871fbf9d1c215b58173932d57d5731948a
 2022-01-24 06:10:03 -08:00
Simek
f1b83a96fd do not add GrayedOutOverlay if there is no children (#3329) 
Summary:
Do not add `GrayedOutOverlay` to the `ToggledSection` component if there is no children.

Current approach was causing UI issue in the Settings Modal in dark mode.

## Changelog

* do not add `GrayedOutOverlay` to the `ToggledSection` if there is no children

Pull Request resolved: https://github.com/facebook/flipper/pull/3329

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

<img width="390" alt="Screenshot 2022-01-23 at 15 32 29" align="left" src="https://user-images.githubusercontent.com/719641/150683689-d70f2af9-d835-4139-a8bb-a638aca9b8d3.png">
<img width="390" alt="Screenshot 2022-01-23 at 15 32 12" src="https://user-images.githubusercontent.com/719641/150683692-86da3fba-5740-426e-96c7-6838632f42f0.png">

Reviewed By: aigoncharov

Differential Revision: D33738627

Pulled By: lblasa

fbshipit-source-id: 12b028e3c7986a4fa196bac6f32a9efc19f1883d
 2022-01-24 05:42:22 -08:00
Pascal Hartig
7135456434 Dep bump 
Summary: Get ahead of dependabot by bundling a few small bumps.

Reviewed By: nikoant

Differential Revision: D33739602

fbshipit-source-id: 1482c062493a4214da81cbf5daf408aa382fb0ac
 2022-01-24 04:57:29 -08:00
Simek
4b0091df0f fix Plugins table UI glitch in dark mode, add column name (#3332) 
Summary:
Same as Settings modal, the Plugin Manager table used in Plugins modal includes the UI glitch in dark mode due to overflow setting. This PR fixes that and also adds missing column caption in "Install Plugins" table.

I have chosen `Action` as a title but this can be altered, I have no strong preference in there. The goal was to improve the clarity and also improve the context menu content (where user can show/hide columns).

## Changelog

* fix Plugins table UI glitch in dark mode, add column name

Pull Request resolved: https://github.com/facebook/flipper/pull/3332

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)
<img width="396" alt="Screenshot 2022-01-23 at 16 19 02" align="left" src="https://user-images.githubusercontent.com/719641/150685739-e2047e70-de14-4801-ac5a-0fc45a6ea476.png">
<img width="396" alt="Screenshot 2022-01-23 at 16 19 31" src="https://user-images.githubusercontent.com/719641/150685735-3de8b7a2-ea3f-489a-b1f8-7af73f0a5225.png">

Reviewed By: aigoncharov

Differential Revision: D33738705

Pulled By: lblasa

fbshipit-source-id: 704fe40f26d424c62a9bbc3e73132a0026f2e8b8
 2022-01-24 03:56:59 -08:00
Simek
41950946a2 tweak Doctor modal footer UI, replace deprecated UI components (#3331) 
Summary:
This PR fixes the unaligned checkbox in the Doctor modal (I have based the solution of the Settings modal code) and also replaces deprecated components `FlexRow` and `FlexColumn` in Settings modal.

## Changelog

* fix checkbox placement in the Doctor modal footer

Pull Request resolved: https://github.com/facebook/flipper/pull/3331

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

<img width="596" alt="Screenshot 2022-01-23 at 16 01 48" src="https://user-images.githubusercontent.com/719641/150685091-ce494847-eea6-4263-900a-2b5541d3d897.png">
<img width="596" alt="Screenshot 2022-01-23 at 16 01 44" src="https://user-images.githubusercontent.com/719641/150685096-29723d14-6cfc-42aa-9564-431a61b1061d.png">

Reviewed By: aigoncharov

Differential Revision: D33738683

Pulled By: lblasa

fbshipit-source-id: 900657d6cb095d6d32dd412205e714a46e64a564
 2022-01-24 02:40:39 -08:00
Simek
d897cfd765 fix Settings modal UI glitch with overlow in dark mode (#3330) 
Summary:
This small tweak fixes the Setting modal UI glitch (white rectangle in the bottom right) related to the modal content overflow setting.

## Changelog

* fix Settings modal UI glitch with content overflow setting in dark mode

Pull Request resolved: https://github.com/facebook/flipper/pull/3330

Test Plan:
The change has been testes by running the desktop Flipper app locally from source.

## Preview (before & after)

#### No scrollbar

<img width="390" alt="Screenshot 2022-01-23 at 15 45 47" align="left" src="https://user-images.githubusercontent.com/719641/150684278-b09031bd-9b8c-4c9c-9ac2-2dba3c1af63d.png">
<img width="390" alt="Screenshot 2022-01-23 at 15 45 39" src="https://user-images.githubusercontent.com/719641/150684279-151b83d6-c819-45e0-a662-3d294f4f6a77.png">

#### With scrollbar
<img width="390" alt="Screenshot 2022-01-23 at 15 51 40" align="left" src="https://user-images.githubusercontent.com/719641/150684331-a8f27623-9a2b-4ffe-b4c1-3fb06a6362a2.png">
<img width="390" alt="Screenshot 2022-01-23 at 15 51 47" src="https://user-images.githubusercontent.com/719641/150684330-57434f21-0d4d-4ef6-be41-fdd88d082d1b.png">

Reviewed By: aigoncharov

Differential Revision: D33738647

Pulled By: lblasa

fbshipit-source-id: f5a170950271302241a29d4382c481f2ce8bf4ec
 2022-01-24 02:33:42 -08:00
dependabot[bot]
a93d4aee71 Bump antd from 4.18.0 to 4.18.2 in /desktop (#3233) 
Summary:
allow-large-files

Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.0 to 4.18.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.18.2</h2>
<ul>
<li>🐞 Revert <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33411">#33411</a> to Table onChange being invoked infinitely.</li>
</ul>
<hr />
<ul>
<li>🐞 回滚 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33411">#33411</a> 以修复 Table 死循环调用 onChange 的问题。</li>
</ul>
<h2>4.18.1</h2>
<ul>
<li>🐞 Fix Popconfirm throws <code>Can't perform a React state update on an unmounted component.</code> warning in some async case. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33432">#33432</a> <a href="https://github.com/MadCcc"><code>@​MadCcc</code></a></li>
<li>🐞 Fix Input with <code>suffix</code> will crash when <code>value</code> is number type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33462">#33462</a></li>
<li>🐞 Fix Divider with text dashed border color error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33452">#33452</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>🐞 Fix Dropdown.Button not support <code>destroyPopupOnHide</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33442">#33442</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 Fix Table Pagination not trigger <code>onChange</code> when <code>current</code> changed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> <a href="https://github.com/2724635499"><code>@​2724635499</code></a></li>
</ul>
<hr />
<ul>
<li>🐞 修复 Popconfirm 在某些情况下会出现 <code>Can't perform a React state update on an unmounted component.</code> 的错误。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33432">#33432</a> <a href="https://github.com/MadCcc"><code>@​MadCcc</code></a></li>
<li>🐞 修复 Input 配置 <code>suffix</code> 时 <code>value</code> 为数字类型会崩溃的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33462">#33462</a></li>
<li>🐞 修复 Divider with text dashed 的边框颜色错误问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33452">#33452</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>🐞 修复 Dropdown.Button 不支持 <code>destroyPopupOnHide</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33442">#33442</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 修复 Table 的 Pagination 在 <code>current</code> 改变时不触发 <code>pagination.onChange</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> <a href="https://github.com/2724635499"><code>@​2724635499</code></a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.18.2</h2>
<p><code>2021-12-30</code></p>
<ul>
<li>🐞 Revert <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> to Table <code>onChange</code> being invoked infinitely.</li>
</ul>
<h2>4.18.1</h2>
<p><code>2021-12-29</code></p>
<ul>
<li>🐞 Fix Popconfirm throws <code>Can't perform a React state update on an unmounted component.</code> warning in some async case. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33432">#33432</a> <a href="https://github.com/MadCcc"><code>@​MadCcc</code></a></li>
<li>🐞 Fix Input with <code>suffix</code> will crash when <code>value</code> is number type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33462">#33462</a></li>
<li>🐞 Fix Divider with text dashed border color error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33452">#33452</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>🐞 Fix Dropdown.Button not support <code>destroyPopupOnHide</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33442">#33442</a> <a href="https://github.com/LongHaoo"><code>@​LongHaoo</code></a></li>
<li>🐞 Fix Table Pagination not trigger <code>onChange</code> when <code>current</code> changed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> <a href="https://github.com/2724635499"><code>@​2724635499</code></a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e94f467209"><code>e94f467</code></a> docs: release 4.18.2 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33491">#33491</a>)</li>
<li><a href="9ec2709b16"><code>9ec2709</code></a> Revert &quot;fix: The current change of pagination triggers onChange  (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33411">#33411</a>)&quot; (#...</li>
<li><a href="150bd23d53"><code>150bd23</code></a> docs: improve changelog</li>
<li><a href="fb59bd2a47"><code>fb59bd2</code></a> docs: improve Cascader API documentation (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33484">#33484</a>)</li>
<li><a href="3913fd51fb"><code>3913fd5</code></a> docs: 4.18.1 changelog (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33476">#33476</a>)</li>
<li><a href="7df1d52dee"><code>7df1d52</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33432">#33432</a> from MadCcc/dev</li>
<li><a href="3effa51572"><code>3effa51</code></a> refactor: refactor useMounted to useDestroyed</li>
<li><a href="285e2bd9ea"><code>285e2bd</code></a> refactor: refactor useMountedRef to useMounted</li>
<li><a href="d53e16fe76"><code>d53e16f</code></a> docs: Update index.en-US.md (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33464">#33464</a>)</li>
<li><a href="0c621c4832"><code>0c621c4</code></a> fix: input not support number value (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33462">#33462</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.18.0...4.18.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.18.0&new-version=4.18.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3233

Reviewed By: lawrencelomax

Differential Revision: D33403862

Pulled By: passy

fbshipit-source-id: 4daefc5dee2fb186866b877af0212a6e1492696e
 2022-01-10 03:05:33 -08:00
Lorenzo Blasa
e8dd7ffcc0 Adresses an issue with menu mutation 
Summary:
A Logview issue was raised for the following error:
Cannot assign to read only property '0' of object '[object Array]'.

Analysis:
Currently, the menuEntries are stored by reference in the reducer, and made read only to protect it against accidental writes. Tha's probably why the '0' assignment fails, and the fix is that the reducer should only get a defensive copy as config about the current menu entries to show.

Reviewed By: mweststrate

Differential Revision: D33454514

fbshipit-source-id: 2faf3036eb6ae4fbe9a8d0253fde27cf389d3e4c
 2022-01-06 08:15:52 -08:00
Michel Weststrate
9267a19c89 Fix settings not being saved before restart 
Summary:
2022 New years intention: don't fix problems with arbitrarily timeouts

In production builds, settings weren't saved if apply + restart was used (apply and manual restart did work). I suspect a bug in redux-persist, since we do await a flush, but anyway a little delay seems to fix it consistently.

Changelog: Fixed an issue where changing settings wasn't persisted when using "Apply + Restart

P.S. I won't accept any insinuations that this was my new years intention of 2015, 2017, 2018, 2020 and 2021 as well.

Reviewed By: cekkaewnumchai

Differential Revision: D33377718

fbshipit-source-id: 3a9ec58b4f8208603d786342ddaf6bf02b3887c7
 2022-01-04 04:18:16 -08:00
Michel Weststrate
b77b234e98 fix table header column widths deviating from rows 
Summary:
changelog: Improved column widths in data tables

This diff fixes two issues:
1) dynamic width columns became invisible if there is too much else, and therefor it was hard to make them bigger or even notice them
2) column headers could be out of sync with the actually rendered rows, due to minor styling differences

Reviewed By: cekkaewnumchai

Differential Revision: D33364781

fbshipit-source-id: c3d47bb8db4af521859a5cbdf525d8ce39c71d00
 2022-01-04 04:08:23 -08:00
Michel Weststrate
b6c884f011 Make sure flipper server initialization errors are propagated properly 
Summary:
This diff makes sure that errors are propagated similarly in flipper desktop and browser version, and that they are shown in either case.

Since in the browser version, the UI loads after the error happened, we'll store the error so that any client connecting in the future will read and report it.

Also added a `--failFast` flag to flipper-server, so that the process exits immediately if misconfigured, which is convenient in CI use cases and such

Reviewed By: nikoant

Differential Revision: D33348922

fbshipit-source-id: 0f584104f881141fde38da3f0031748415343ea2
 2022-01-04 02:57:25 -08:00
dependabot[bot]
4e11458655 Bump antd from 4.16.8 to 4.18.0 in /desktop (#3222) 
Summary:
Bumps [antd](https://github.com/ant-design/ant-design) from 4.16.8 to 4.18.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p>
<blockquote>
<h2>4.18.0</h2>
<ul>
<li>🐞 Fix Skeleton missing <code>style</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li>
<li>🐞 Fix Descriptions overflow style cause other components being cut. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li>
<li>🆕 Unique Select-like component generic as OptionType to support FieldNames type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li>
<li>🐞 Fix Slider rail hover color when it is disabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Table
<ul>
<li>🆕 Table <code>colSpan</code> &amp; <code>rowSpan</code> move to <code>onCell</code> function to optimize performance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li>
<li>🆕 Table support Table.EXPAND_COLUMN &amp; Table.SELECTION_COLUMN to customize column order. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🔥 Form.List nest Form.Item no longer need pass <code>fieldKey</code> anymore. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li>
<li>🆕 Form <code>label</code> can wrap via setting <code>labelWrap</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li>
</ul>
</li>
<li>🆕 ConfigProvider support Form <code>colon</code>. <a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@​seaSuper</code></a></li>
<li>🆕 add <code>prefix</code> to <code>InputNumber</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@​Austaras</code></a></li>
<li>🆕 Modal static function support <code>wrapClassName</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Popconfirm add <code>showCancel</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Dropdown.Button supports <code>loading</code> property now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@​kaysonwu</code></a></li>
<li>🆕 Input adds <code>showCount</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Alert supports <code>closeIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Typography
<ul>
<li>🆕 for editable Paragraph, edit can be triggered by clicking the icon or the value itself (or both) with <code>triggerType</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
<li>🆕 Typography support <code>enterIcon</code> to config confirm icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
</ul>
</li>
<li>🆕 Divider added <code>orientationMargin</code> APIs for customizing <code>margin-left/right</code> of title. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32084">#32084</a> <a href="https://github.com/neotan"><code>@​neotan</code></a></li>
<li>🆕 Avatar add <code>maxPopoverTrigger</code> to support configuration of popover trigger. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32197">#32197</a> <a href="https://github.com/RiteshMakan"><code>@​RiteshMakan</code></a></li>
<li>🆕 Upload supports <code>showUploadList.previewIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32059">#32059</a> <a href="https://github.com/1040961807"><code>@​1040961807</code></a></li>
<li>🏴󠁥󠁳󠁣󠁴󠁿 Fix Catalan (ca_ES) missing translation key with <code>Form</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33377">#33377</a> <a href="https://github.com/ZzGGitter"><code>@​ZzGGitter</code></a></li>
<li>🇫🇮 Fix Finland (fi_FI) missing translation key with <code>Table</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33372">#33372</a> <a href="https://github.com/ZakarFin"><code>@​ZakarFin</code></a></li>
<li>🇰🇭 Added locales for Khmer (km_KH) translation. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32853">#32853</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
<li>TypeScript
<ul>
<li>� Add Upload <code>capture</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33370">#33370</a> <a href="https://github.com/MichalPodeszwa"><code>@​MichalPodeszwa</code></a></li>
</ul>
</li>
</ul>
<hr />
<ul>
<li>🐞 修复 Skeleton 不支持 <code>style</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li>
<li>🐞 修复 Descriptions 内使用其他组件会被切割的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li>
<li>🆕 统一类 Select 组件泛型定义为 OptionType 以支持自定义 FieldNames 匹配。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li>
<li>🐞 修复 Slider 禁用时 <code>hover</code> 色彩的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Table
<ul>
<li>🆕 Table <code>colSpan</code> 与 <code>rowSpan</code> 迁移至 <code>onCell</code> 方法中，以优化渲染性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li>
<li>🆕 Table 支持 Table.EXPAND_COLUMN 和 Table.SELECTION_COLUMN 以实现自定义列排序。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🔥 Form.List 嵌套使用 Form.Item 时不再需要手工指定 <code>fieldKey</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li>
<li>🆕 Form 现在支持通过 <code>labelWrap</code> 开启标签可换行。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li>
</ul>
</li>
<li>🆕 ConfigProvider 支持 Form 的 colon 配置。<a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@​seaSuper</code></a></li>
<li>🆕 <code>InputNumber</code> 增加 <code>prefix</code> 属性支持。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@​Austaras</code></a></li>
<li>🆕 Modal 静态方法支持 <code>wrapClassName</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Popconfirm 新增是否显示取消按钮。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Dropdown.Button 新增 <code>loading</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@​kaysonwu</code></a></li>
<li>🆕 Input 新增 <code>showCount</code> 属性。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Alert 支持 <code>closeIcon</code> 自定义关闭图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Typography
<ul>
<li>🆕 对于可编辑段落，可以通过配置 <code>triggerType</code> 配置触发编辑状态。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
<li>🆕 Typography 支持 <code>enterIcon</code> 以设置编辑确认图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
</ul>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p>
<blockquote>
<h2>4.18.0</h2>
<p><code>2021-12-27</code></p>
<ul>
<li>🐞 Fix Skeleton missing <code>style</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33405">#33405</a></li>
<li>🐞 Fix Descriptions overflow style cause other components being cut. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33392">#33392</a></li>
<li>🆕 Unique Select-like component generic as OptionType to support FieldNames type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33364">#33364</a></li>
<li>🐞 Fix Slider rail hover color when it is disabled. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33369">#33369</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Table
<ul>
<li>🆕 Table <code>colSpan</code> &amp; <code>rowSpan</code> move to <code>onCell</code> function to optimize performance. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33114">#33114</a></li>
<li>🆕 Table support Table.EXPAND_COLUMN &amp; Table.SELECTION_COLUMN to customize column order. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33026">#33026</a></li>
</ul>
</li>
<li>Form
<ul>
<li>🔥 Form.List nest Form.Item no longer need pass <code>fieldKey</code> anymore. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32689">#32689</a></li>
<li>🆕 Form <code>label</code> can wrap via setting <code>labelWrap</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33048">#33048</a></li>
</ul>
</li>
<li>🆕 ConfigProvider support Form <code>colon</code>. <a href="https://github.com/ant-design/ant-design/commit/9bc148a">9bc148a</a> <a href="https://github.com/seaSuper"><code>@​seaSuper</code></a></li>
<li>🆕 add <code>prefix</code> to <code>InputNumber</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32600">#32600</a> <a href="https://github.com/Austaras"><code>@​Austaras</code></a></li>
<li>🆕 Modal static function support <code>wrapClassName</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32676">#32676</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Popconfirm add <code>showCancel</code> prop. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32620">#32620</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Dropdown.Button supports <code>loading</code> property now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32467">#32467</a> <a href="https://github.com/kaysonwu"><code>@​kaysonwu</code></a></li>
<li>🆕 Input adds <code>showCount</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32522">#32522</a> <a href="https://github.com/cwjTerrace"><code>@​cwjTerrace</code></a></li>
<li>🆕 Alert supports <code>closeIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32345">#32345</a> <a href="https://github.com/chen-jingjie"><code>@​chen-jingjie</code></a></li>
<li>Typography
<ul>
<li>🆕 for editable Paragraph, edit can be triggered by clicking the icon or the value itself (or both) with <code>triggerType</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32219">#32219</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
<li>🆕 Typography support <code>enterIcon</code> to config confirm icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32220">#32220</a> <a href="https://github.com/kachanovskiy"><code>@​kachanovskiy</code></a></li>
</ul>
</li>
<li>🆕 Divider added <code>orientationMargin</code> APIs for customizing <code>margin-left/right</code> of title. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32084">#32084</a> <a href="https://github.com/neotan"><code>@​neotan</code></a></li>
<li>🆕 Avatar add <code>maxPopoverTrigger</code> to support configuration of popover trigger. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32197">#32197</a> <a href="https://github.com/RiteshMakan"><code>@​RiteshMakan</code></a></li>
<li>🆕 Upload supports <code>showUploadList.previewIcon</code> now. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32059">#32059</a> <a href="https://github.com/1040961807"><code>@​1040961807</code></a></li>
<li>🏴󠁥󠁳󠁣󠁴󠁿 Fix Catalan (ca_ES) missing translation key with <code>Form</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33377">#33377</a> <a href="https://github.com/ZzGGitter"><code>@​ZzGGitter</code></a></li>
<li>🇫🇮 Fix Finland (fi_FI) missing translation key with <code>Table</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33372">#33372</a> <a href="https://github.com/ZakarFin"><code>@​ZakarFin</code></a></li>
<li>🇰🇭 Added locales for Khmer (km_KH) translation. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32853">#32853</a> <a href="https://github.com/vireakkeosokvibol"><code>@​vireakkeosokvibol</code></a></li>
<li>TypeScript
<ul>
<li>� Add Upload <code>capture</code> definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33370">#33370</a> <a href="https://github.com/MichalPodeszwa"><code>@​MichalPodeszwa</code></a></li>
</ul>
</li>
</ul>
<h2>4.17.4</h2>
<p><code>2021-12-19</code></p>
<ul>
<li>🐞 Fix a bug that Form.Item name is &quot;parentNode&quot; casue endless loop and memory leak. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/31846">#31846</a> <a href="https://github.com/DaoxingHuang"><code>@​DaoxingHuang</code></a></li>
<li>🐞 Revert <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32448">#32448</a> to fix emoji input at Input.TextArea. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33312">#33312</a></li>
</ul>
<h2>4.17.3</h2>
<p><code>2021-12-08</code></p>
<ul>
<li>🐞 Fix Drawer broken style caused by title width. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33205">#33205</a></li>
<li>🐞 Fix Badge flash style when switch from <code>display:none</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33083">#33083</a> <a href="https://github.com/songlinn"><code>@​songlinn</code></a></li>
<li>💄 Change Anchor className form <code>.fixed</code> to <code>.ant-anchor-fixed</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33085">#33085</a> <a href="https://github.com/tangjinzhou"><code>@​tangjinzhou</code></a></li>
<li>💄 Fix Button loading style missing in Firefox. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33199">#33199</a></li>
<li>Select
<ul>
<li>🐞 Fix Select width became small when searching. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/32988">#32988</a></li>
</ul>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="41ac1f0c1a"><code>41ac1f0</code></a> chore: 4.18.0 changelog (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33424">#33424</a>)</li>
<li><a href="24458eb54e"><code>24458eb</code></a> chore: auto merge branchs (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33423">#33423</a>)</li>
<li><a href="b3cc1e5276"><code>b3cc1e5</code></a> chore: auto merge branchs (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33422">#33422</a>)</li>
<li><a href="7ae451729f"><code>7ae4517</code></a> test: update snapshot</li>
<li><a href="6ed4d855b1"><code>6ed4d85</code></a> Merge remote-tracking branch 'origin/master' into feature-merge-master</li>
<li><a href="73ac1b1aaa"><code>73ac1b1</code></a> docs: Update practical-projects.zh-CN.md (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33419">#33419</a>)</li>
<li><a href="7f09f0a604"><code>7f09f0a</code></a> chore(deps): update dependency scrollama to v3 (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33418">#33418</a>)</li>
<li><a href="9c086c5328"><code>9c086c5</code></a> fix: Skeleton missing style (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33405">#33405</a>)</li>
<li><a href="f1e0c9c1d2"><code>f1e0c9c</code></a> chore: Internal Menu interface for ProLayout usage (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33399">#33399</a>)</li>
<li><a href="0edf04253e"><code>0edf042</code></a> fix: Descriptions default overflow value (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33392">#33392</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ant-design/ant-design/compare/4.16.8...4.18.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=antd&package-manager=npm_and_yarn&previous-version=4.16.8&new-version=4.18.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3222

Reviewed By: timur-valiev

Differential Revision: D33348265

Pulled By: nikoant

fbshipit-source-id: e219049791c8341b4795fc8b742edaa61ee7559d
 2022-01-01 20:28:45 -08:00
Andres Suarez
79023ee190 Update copyright headers from Facebook to Meta 
Reviewed By: bhamodi

Differential Revision: D33331422

fbshipit-source-id: 016e8dcc0c0c7f1fc353a348b54fda0d5e2ddc01
 2021-12-27 14:31:45 -08:00
Anton Nikolaev
dd4d7bbe7f API for creating pastes without showing notifications 
Reviewed By: mweststrate

Differential Revision: D33277470

fbshipit-source-id: 2ec9ad7d9fc48d7d2da64be3bfc1a66bb5b3a347
 2021-12-22 15:34:11 -08:00
Andrey Goncharov
debf872806 Allow to start only one instance of log listener and crash watcher 
Summary:
Changelog: Allow only a single crash watcher and a single log listener per device. Start log listener and crash watcher for every device upon connection. Remove commands to start/stop them externally.

Monitored CPU load for a physical Android device with the log listener on and off. Did not notice any real difference.

Resolved crashing adbkit-logcat by forcing the usage of 2.0.1. A proper fix would be to unify babel transforms for browser flipper and electron flipper, but we might re-think how we distribute flipper in the next half, so a simple hot fix might be a better use of time and resources.

Reviewed By: mweststrate

Differential Revision: D33132506

fbshipit-source-id: 39d422682a10a64830ac516e30f43f32f416819d
 2021-12-20 11:39:01 -08:00
Andrey Goncharov
731749b41f Move crash reporting listener to the server 
Summary: Changelog: Move crash watcher to the server. Add 'device-crash' event. Add 'device-start-crash-watcher', 'device-stop-crash-watcher' commands. Add 'onDeviceCrash' method to Plugin Client.

Reviewed By: mweststrate

Differential Revision: D33089810

fbshipit-source-id: ed62ee7c1129e5e25af18b444744b0796f567b72
 2021-12-20 11:39:00 -08:00
Andrey Goncharov
3f771c05dd Remove fs usage from Navigator plugin 
Reviewed By: mweststrate

Differential Revision: D33019873

fbshipit-source-id: 6d48971dc04161b64fdd32ac4e658b56aa98b7ec
 2021-12-20 11:39:00 -08:00
dependabot[bot]
9085fc6f72 Bump immer from 9.0.6 to 9.0.7 in /desktop (#3138) 
Summary:
Bumps [immer](https://github.com/immerjs/immer) from 9.0.6 to 9.0.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/immerjs/immer/releases">immer's releases</a>.</em></p>
<blockquote>
<h2>v9.0.7</h2>
<h2><a href="https://github.com/immerjs/immer/compare/v9.0.6...v9.0.7">9.0.7</a> (2021-11-24)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>Append to array when key is &quot;-&quot; (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/872">https://github.com/facebook/flipper/issues/872</a>) (<a href="2afdb1b37d">2afdb1b</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8507692c72"><code>8507692</code></a> chore(deps): bump prismjs from 1.24.0 to 1.25.0 in /website (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/853">https://github.com/facebook/flipper/issues/853</a>)</li>
<li><a href="5e71d58499"><code>5e71d58</code></a> chore(deps): bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/854">https://github.com/facebook/flipper/issues/854</a>)</li>
<li><a href="26355d7531"><code>26355d7</code></a> chore: typo (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/857">https://github.com/facebook/flipper/issues/857</a>)</li>
<li><a href="4e062c4292"><code>4e062c4</code></a> docs: Fix typo (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/862">https://github.com/facebook/flipper/issues/862</a>)</li>
<li><a href="fb28e8835d"><code>fb28e88</code></a> docs: Update produce.mdx (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/868">https://github.com/facebook/flipper/issues/868</a>)</li>
<li><a href="6e7cd9aaf9"><code>6e7cd9a</code></a> docs: fix mobile navbar menu styles (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/870">https://github.com/facebook/flipper/issues/870</a>)</li>
<li><a href="437e745258"><code>437e745</code></a> chore(deps): bump ws from 5.2.2 to 5.2.3</li>
<li><a href="2afdb1b37d"><code>2afdb1b</code></a> fix: Append to array when key is &quot;-&quot; (<a href="https://github-redirect.dependabot.com/immerjs/immer/issues/872">https://github.com/facebook/flipper/issues/872</a>)</li>
<li><a href="2794576206"><code>2794576</code></a> chore: fix release job</li>
<li><a href="e6aa92c141"><code>e6aa92c</code></a> chore: fix tests on master</li>
<li>Additional commits viewable in <a href="https://github.com/immerjs/immer/compare/v9.0.6...v9.0.7">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=immer&package-manager=npm_and_yarn&previous-version=9.0.6&new-version=9.0.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3138

Reviewed By: aigoncharov

Differential Revision: D33234026

Pulled By: mweststrate

fbshipit-source-id: 95134c207a685125e1eaab4a6c9bc565a3077828
 2021-12-20 03:26:23 -08:00
Michel Weststrate
e46fcba0b2 Make sure that test stuff doesn't end up in bundles 
Summary: When bundling a production bundle of flipper-ui / flipper-server, noticed that a lot of irrelevant stuff ends up. Like: `jest`, `metro`, `testing-library`. The whole jungle basically. Will add safety checks in the next diffs that this no longer happens

Reviewed By: passy

Differential Revision: D33186531

fbshipit-source-id: 1e2034153c8c4a3fac02cd9ce27d99224223df7a
 2021-12-17 14:12:50 -08:00
Michel Weststrate
d9488f06ac Clean up flipper-ui-core deps 
Summary: Noticed that flipper-ui-core bundled quite some unused / node based deps. No longer

Reviewed By: aigoncharov

Differential Revision: D33184489

fbshipit-source-id: a180f9b8f3eb00ffa6c91e0cca654d4b9b609692
 2021-12-17 10:04:23 -08:00
Michel Weststrate
cea7be7fde Clean up globals 
Summary: This diff is some boyscouting on cleaning up our globals, and stop using them inconsistently icmw global or window

Reviewed By: aigoncharov

Differential Revision: D33171108

fbshipit-source-id: 400893e5f31523631a7ab6fda428524c751901f1
 2021-12-17 10:04:23 -08:00
Michel Weststrate
8f40949bb0 clean slate package resolutions 
Summary:
Over time we collected a lot of harcoded resolutions, but it is really hard to get signal about their sanity:
* some resolutions generate a lot of yarn warnings as they resolve with a different major than required, and it's really hard to tell whether they actually make things worse or better
* some resolutions are for package we don't even use any more
* some resolutions were there to fix type incompatibilities which have been solved now by keeping them uniquely required
* some resolutions are there to fix "security issues" or security issues in transient dependencies that might have been upgraded int he mean time

So this diff radically removes all of them, trusting Github to propose restoring the sane ones of them :). In terms of functionality everything seems to be working at least

Reviewed By: timur-valiev

Differential Revision: D33158981

fbshipit-source-id: 83e74cdbc8e47ccbf554b97620cf7caa2c6599ce
 2021-12-17 07:36:07 -08:00
Michel Weststrate
5df34a337c Unshare global types 
Summary:
This diff adds `types` fields on the compiler config for every project. This way we can make sure that for example node types and packages are not available in flipper-ui-core. Without an explicit types field, all types would be shared between all packages, and implicitly included into the compilation of everything. For the same reason `types/index.d.ts` has been removed, we want to be intentional on which types are being used in which package.

This diff does most of the work, the next diff will fine tune the globals, and do some further cleanup.

As an alternative solution I first tried a `nohoist: **/node_modules/types/**` and make sure every package list explicitly the types used in package json, which works but is much more error prone, as for example two different react types versions in two packages will cause the most unreadable compiler error due to the types not being shared and not literally the same.

Reviewed By: lawrencelomax

Differential Revision: D33124441

fbshipit-source-id: c2b9d768f845ac28005d8331ef5fa1066c7e4cd7
 2021-12-17 07:36:07 -08:00
Andrey Goncharov
af3757dcae Add left margin for app names in app selector 
Summary: Changelog: Add left margin for app names in app selector

Reviewed By: timur-valiev

Differential Revision: D33162189

fbshipit-source-id: 4eb1a565e5cbcdfb44b0dfcaa4b0988c8a69d200
 2021-12-17 05:01:54 -08:00
Michel Weststrate
dcfeb4a4d5 Clean up packages and types 
Summary:
This diff removes most deps from the root package.json, which now only contains electron and shared build / test infra structure: lint, prettier, jest, typescript.

This makes it possible to control much better which packages are used where, as all sub packages now have their deps explicitly in their package.json instead of incidentally shared. This allows for example to disable DOM types for all packages by default (flipper-plugin, ui(-core) and app still request it), and in the next diff I hope to add to this that nodeJS types are no longer shared either, so that UI oriented packages will generate compile errors when using Node built-ins

This diff removes most deps that were currently unused, and dedupes a bunch of other ones, so the build should probably be a bit smaller now as well:

{F686704253}

{F686704295}

Reviewed By: antonk52

Differential Revision: D33062859

fbshipit-source-id: 5afaa4f2103d055188382a3370c1fffa295a298a
 2021-12-16 14:54:59 -08:00
Michel Weststrate
78413c1ecf Register shortcuts on window instead of globally 
Summary:
Changelog: Register shortcuts only for Flipper application instead of globally. Fixes https://github.com/facebook/flipper/issues/3090

As reported, during decapitation we accidentally started registering shortcuts globally, rather per app as it used to be in the menu's. This diff fixes that and also makes sure shortcuts are supported in the browser version of flipper

Reviewed By: lawrencelomax

Differential Revision: D33158445

fbshipit-source-id: 8371e5b96e772152eeb93ba990e1f5edb9e67085
 2021-12-16 14:51:08 -08:00
Anton Nikolaev
2c976546c7 Redirect to Support Entry Point 
Reviewed By: mweststrate

Differential Revision: D33091179

fbshipit-source-id: da0c3e5fc21eef1693f7da2d00d90347bf2e0b51
 2021-12-14 09:04:19 -08:00
Michel Weststrate
5ce5d897c8 Make loading of bundled plugins working and robust 
Summary:
Bundled plugins so far didn't load because the defaultPlugins was not generated yet. Fixed follow up errors that resulted from node modules not being available in the browser, and made the process more robust so that one plugin that fails to initialise doesn't kill all bundled plugins from being loaded.

Cleaned up the server scripts, and reused the BUILTINS list that is already maintained in the babel transformer.

Report errors during the build process if modules are referred that are stubbed out (later on we could maybe error on that)

Reviewed By: aigoncharov

Differential Revision: D33020243

fbshipit-source-id: 3ce13b0049664b5fb19c1f45f0b33c1d7fdbea4c
 2021-12-13 05:48:17 -08:00
Michel Weststrate
9e09c0d5f7 Stop exposing adbkit and crc32 as globals 
Summary: Since no plugin directly uses adbkit or crc32 anymore, we removed them from the globals. They wouldn't work in the browser anyway

Reviewed By: aigoncharov

Differential Revision: D33019084

fbshipit-source-id: 66ab0756399fdb401c63f5e8271bdd62cb79ab4a
 2021-12-13 05:48:17 -08:00
Michel Weststrate
ac9080abac Remove 'process' usage 
Summary: Removed process, adbkit and electron usages that were still remaining. Verified changes by disabling the built-in module stubbing (will be cleaned up further later in this stack).

Reviewed By: aigoncharov

Differential Revision: D33019083

fbshipit-source-id: 8bfce31f4b5ed349cb4fd86d34c9b41b9b8b8360
 2021-12-13 05:48:17 -08:00