jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Suggest a quick fix for EADDRINUSE

Browse Source 
Summary:
Show users a way to fix Flipper EADDRINUSE on their own without filing a support request

CHANGELOG: Better error message for EADDRINUSE

Reviewed By: mweststrate

Differential Revision: D40338164

fbshipit-source-id: ec0419c78983b55736aa773757775b5302da51e0
This commit is contained in:
Andrey Goncharov
2022-10-13 03:14:06 -07:00
committed by Facebook GitHub Bot
parent eb4b83d0b6
commit fbbd90e9f5
1 changed files with 39 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx
View File

@@ -45,27 +45,15 @@ export function connectFlipperServerToStore(
server.on('server-state', handleServerStateChange);
server.on('server-error', (err) => {
notification.error({
message: 'Connection error',
description:
err.code === 'EADDRINUSE' ? (
<>
Couldn't start connection server. Looks like you have multiple
copies of Flipper running or another process is using the same
port(s). As a result devices will not be able to connect to Flipper.
<br />
<br />
Please try to kill the offending process by running{' '}
<code>kill $(lsof -ti:PORTNUMBER)</code> and restart flipper.
<br />
<br />
{'' + err}
</>
) : (
<>{err.message ?? err}</>
),
duration: null,
});
if (err.code === 'EADDRINUSE') {
handeEADDRINUSE('' + err);
} else {
notification.error({
message: 'Connection error',
description: <>{err.message ?? err}</>,
duration: null,
});
}
});
server.on('device-connected', (deviceInfo) => {
@@ -189,16 +177,41 @@ function handleServerStateChange({
}) {
if (state === 'error') {
console.warn(`[conn] Flipper server state -> ${state}`, error);
notification.error({
message: 'Failed to start flipper-server',
description: '' + error,
duration: null,
});
if (error?.includes('EADDRINUSE')) {
handeEADDRINUSE(error);
} else {
notification.error({
message: 'Failed to start flipper-server',
description: '' + error,
duration: null,
});
}
} else {
console.info(`[conn] Flipper server state -> ${state}`);
}
}
function handeEADDRINUSE(errorMessage: string) {
notification.error({
message: 'Connection error',
description: (
<>
Couldn't start connection server. Looks like you have multiple copies of
Flipper running or another process is using the same port(s). As a
result devices will not be able to connect to Flipper.
<br />
<br />
Please try to kill the offending process by running{' '}
<code>kill $(lsof -ti:PORTNUMBER)</code> and restart flipper.
<br />
<br />
{errorMessage}
</>
),
duration: null,
});
}
export function handleDeviceConnected(
server: FlipperServer,
store: Store,