jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SKDescriptorMapper should be a weak reference

Browse Source 
Summary:
^

SKDescriptorMapper owns the SKNodeDescriptor instances. SKNodeDescriptor instances should only have a weak reference to the mapper as to avoid retain cycles.

Reviewed By: passy

Differential Revision: D42673698

fbshipit-source-id: 8c98709b28fc3c711dc56c179c7c362417fa1f9d
This commit is contained in:
Lorenzo Blasa
2023-01-23 03:47:41 -08:00
committed by Facebook GitHub Bot
parent 764e94503e
commit f44feb69e0
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutHelpers/FlipperKitLayoutHelpers/SKNodeDescriptor.mm
View File

@@ -11,7 +11,7 @@
#import <FlipperKitLayoutTextSearchable/FKTextSearchable.h>
@implementation SKNodeDescriptor {
id<SKDescriptorMapperProtocol> _mapper;
__weak id<SKDescriptorMapperProtocol> _mapper;
}
- (void)setUp {

2
iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutIOSDescriptors/FlipperKitLayoutIOSDescriptors/SKViewControllerDescriptor.h
View File

@@ -11,8 +11,6 @@
#import <FlipperKitLayoutHelpers/SKNodeDescriptor.h>
@class SKDescriptorMapper;
@interface SKViewControllerDescriptor : SKNodeDescriptor<UIViewController*>
@end