From f44feb69e0932f4b18fd9c9d01eb6cb5d75543b6 Mon Sep 17 00:00:00 2001
From: Lorenzo Blasa <lblasa@meta.com>
Date: Mon, 23 Jan 2023 03:47:41 -0800
Subject: [PATCH] SKDescriptorMapper should be a weak reference

Summary:
^

SKDescriptorMapper owns the SKNodeDescriptor instances. SKNodeDescriptor instances should only have a weak reference to the mapper as to avoid retain cycles.

Reviewed By: passy

Differential Revision: D42673698

fbshipit-source-id: 8c98709b28fc3c711dc56c179c7c362417fa1f9d
---
 .../FlipperKitLayoutHelpers/SKNodeDescriptor.mm                 | 2 +-
 .../FlipperKitLayoutIOSDescriptors/SKViewControllerDescriptor.h | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutHelpers/FlipperKitLayoutHelpers/SKNodeDescriptor.mm b/iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutHelpers/FlipperKitLayoutHelpers/SKNodeDescriptor.mm
index 6a2967502..697e650a5 100644
--- a/iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutHelpers/FlipperKitLayoutHelpers/SKNodeDescriptor.mm
+++ b/iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutHelpers/FlipperKitLayoutHelpers/SKNodeDescriptor.mm
@@ -11,7 +11,7 @@
 #import <FlipperKitLayoutTextSearchable/FKTextSearchable.h>
 
 @implementation SKNodeDescriptor {
-  id<SKDescriptorMapperProtocol> _mapper;
+  __weak id<SKDescriptorMapperProtocol> _mapper;
 }
 
 - (void)setUp {
diff --git a/iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutIOSDescriptors/FlipperKitLayoutIOSDescriptors/SKViewControllerDescriptor.h b/iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutIOSDescriptors/FlipperKitLayoutIOSDescriptors/SKViewControllerDescriptor.h
index a506769eb..eefa7942a 100644
--- a/iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutIOSDescriptors/FlipperKitLayoutIOSDescriptors/SKViewControllerDescriptor.h
+++ b/iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutIOSDescriptors/FlipperKitLayoutIOSDescriptors/SKViewControllerDescriptor.h
@@ -11,8 +11,6 @@
 
 #import <FlipperKitLayoutHelpers/SKNodeDescriptor.h>
 
-@class SKDescriptorMapper;
-
 @interface SKViewControllerDescriptor : SKNodeDescriptor<UIViewController*>
 
 @end