jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename SidebarSection to UISection

Browse Source 
Summary: These are full width blocks, and can be put anywhere, so calling them SidebarSections isn't very helpful.

Reviewed By: danielbuechele

Differential Revision: D14833465

fbshipit-source-id: 2433337f78b6bbcb951cd90b6925de1b9a304d42
This commit is contained in:
John Knox
2019-04-09 08:21:23 -07:00
committed by Facebook Github Bot
parent 40b1c569ad
commit f21c9f1c61
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
android/src/main/java/com/facebook/flipper/nativeplugins/components/JsonSidebarSection.java → android/src/main/java/com/facebook/flipper/nativeplugins/components/JsonSection.java
View File

@@ -2,11 +2,11 @@ package com.facebook.flipper.nativeplugins.components;
import com.facebook.flipper.core.FlipperObject;
public class JsonSidebarSection implements SidebarSection {
public class JsonSection implements UISection {
private final String title;
private final FlipperObject content;
public JsonSidebarSection(String title, FlipperObject content) {
public JsonSection(String title, FlipperObject content) {
this.title = title;
this.content = content;
}

2
android/src/main/java/com/facebook/flipper/nativeplugins/components/Sidebar.java
View File

@@ -6,7 +6,7 @@ public class Sidebar {
private final FlipperArray.Builder sections = new FlipperArray.Builder();
public Sidebar addSection(SidebarSection section) {
public Sidebar addSection(UISection section) {
sections.put(section.serialize());
return this;
}

6
android/src/main/java/com/facebook/flipper/nativeplugins/components/ToolbarSidebarSection.java → android/src/main/java/com/facebook/flipper/nativeplugins/components/ToolbarSection.java
View File

@@ -3,10 +3,10 @@ package com.facebook.flipper.nativeplugins.components;
import com.facebook.flipper.core.FlipperArray;
import com.facebook.flipper.core.FlipperObject;
public class ToolbarSidebarSection implements SidebarSection {
FlipperArray.Builder items = new FlipperArray.Builder();
public class ToolbarSection implements UISection {
private FlipperArray.Builder items = new FlipperArray.Builder();
public ToolbarSidebarSection addLink(String label, String destination) {
public ToolbarSection addLink(String label, String destination) {
items.put(
new FlipperObject.Builder()
.put("type", "link")

2
android/src/main/java/com/facebook/flipper/nativeplugins/components/SidebarSection.java → android/src/main/java/com/facebook/flipper/nativeplugins/components/UISection.java
View File

@@ -2,7 +2,7 @@ package com.facebook.flipper.nativeplugins.components;
import com.facebook.flipper.core.FlipperObject;
interface SidebarSection {
interface UISection {
FlipperObject serialize();
}