From f21c9f1c617452331951847fe65c08ffaa78b6bc Mon Sep 17 00:00:00 2001 From: John Knox Date: Tue, 9 Apr 2019 08:21:23 -0700 Subject: [PATCH] Rename SidebarSection to UISection Summary: These are full width blocks, and can be put anywhere, so calling them SidebarSections isn't very helpful. Reviewed By: danielbuechele Differential Revision: D14833465 fbshipit-source-id: 2433337f78b6bbcb951cd90b6925de1b9a304d42 --- .../{JsonSidebarSection.java => JsonSection.java} | 4 ++-- .../facebook/flipper/nativeplugins/components/Sidebar.java | 2 +- .../{ToolbarSidebarSection.java => ToolbarSection.java} | 6 +++--- .../components/{SidebarSection.java => UISection.java} | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) rename android/src/main/java/com/facebook/flipper/nativeplugins/components/{JsonSidebarSection.java => JsonSection.java} (77%) rename android/src/main/java/com/facebook/flipper/nativeplugins/components/{ToolbarSidebarSection.java => ToolbarSection.java} (71%) rename android/src/main/java/com/facebook/flipper/nativeplugins/components/{SidebarSection.java => UISection.java} (83%) diff --git a/android/src/main/java/com/facebook/flipper/nativeplugins/components/JsonSidebarSection.java b/android/src/main/java/com/facebook/flipper/nativeplugins/components/JsonSection.java similarity index 77% rename from android/src/main/java/com/facebook/flipper/nativeplugins/components/JsonSidebarSection.java rename to android/src/main/java/com/facebook/flipper/nativeplugins/components/JsonSection.java index a6a6dcf3e..00b587776 100644 --- a/android/src/main/java/com/facebook/flipper/nativeplugins/components/JsonSidebarSection.java +++ b/android/src/main/java/com/facebook/flipper/nativeplugins/components/JsonSection.java @@ -2,11 +2,11 @@ package com.facebook.flipper.nativeplugins.components; import com.facebook.flipper.core.FlipperObject; -public class JsonSidebarSection implements SidebarSection { +public class JsonSection implements UISection { private final String title; private final FlipperObject content; - public JsonSidebarSection(String title, FlipperObject content) { + public JsonSection(String title, FlipperObject content) { this.title = title; this.content = content; } diff --git a/android/src/main/java/com/facebook/flipper/nativeplugins/components/Sidebar.java b/android/src/main/java/com/facebook/flipper/nativeplugins/components/Sidebar.java index 0216788b7..f79968e58 100644 --- a/android/src/main/java/com/facebook/flipper/nativeplugins/components/Sidebar.java +++ b/android/src/main/java/com/facebook/flipper/nativeplugins/components/Sidebar.java @@ -6,7 +6,7 @@ public class Sidebar { private final FlipperArray.Builder sections = new FlipperArray.Builder(); - public Sidebar addSection(SidebarSection section) { + public Sidebar addSection(UISection section) { sections.put(section.serialize()); return this; } diff --git a/android/src/main/java/com/facebook/flipper/nativeplugins/components/ToolbarSidebarSection.java b/android/src/main/java/com/facebook/flipper/nativeplugins/components/ToolbarSection.java similarity index 71% rename from android/src/main/java/com/facebook/flipper/nativeplugins/components/ToolbarSidebarSection.java rename to android/src/main/java/com/facebook/flipper/nativeplugins/components/ToolbarSection.java index 95bccedec..7e63393b1 100644 --- a/android/src/main/java/com/facebook/flipper/nativeplugins/components/ToolbarSidebarSection.java +++ b/android/src/main/java/com/facebook/flipper/nativeplugins/components/ToolbarSection.java @@ -3,10 +3,10 @@ package com.facebook.flipper.nativeplugins.components; import com.facebook.flipper.core.FlipperArray; import com.facebook.flipper.core.FlipperObject; -public class ToolbarSidebarSection implements SidebarSection { - FlipperArray.Builder items = new FlipperArray.Builder(); +public class ToolbarSection implements UISection { + private FlipperArray.Builder items = new FlipperArray.Builder(); - public ToolbarSidebarSection addLink(String label, String destination) { + public ToolbarSection addLink(String label, String destination) { items.put( new FlipperObject.Builder() .put("type", "link") diff --git a/android/src/main/java/com/facebook/flipper/nativeplugins/components/SidebarSection.java b/android/src/main/java/com/facebook/flipper/nativeplugins/components/UISection.java similarity index 83% rename from android/src/main/java/com/facebook/flipper/nativeplugins/components/SidebarSection.java rename to android/src/main/java/com/facebook/flipper/nativeplugins/components/UISection.java index 0d3c4d9b4..3d2a05381 100644 --- a/android/src/main/java/com/facebook/flipper/nativeplugins/components/SidebarSection.java +++ b/android/src/main/java/com/facebook/flipper/nativeplugins/components/UISection.java @@ -2,7 +2,7 @@ package com.facebook.flipper.nativeplugins.components; import com.facebook.flipper.core.FlipperObject; -interface SidebarSection { +interface UISection { FlipperObject serialize(); }