Socket provider

Summary:
Abstract the socket creation from FlipperConnectionManagerImpl. Instead, use FlipperSocketProvider.

There's a default provider which will always return RSocket sockets. This provider can be changed and thus can return other implementations.

Reviewed By: fabiomassimo

Differential Revision: D30396322

fbshipit-source-id: 0583865376809260b0240e5bd653d73f2fa514b1
This commit is contained in:
Lorenzo Blasa
2021-08-23 03:16:25 -07:00
committed by Facebook GitHub Bot
parent 823a90fa61
commit ef831f346d
4 changed files with 168 additions and 6 deletions

View File

@@ -0,0 +1,67 @@
/*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include "FlipperSocketProvider.h"
#include "FlipperRSocket.h"
#include "FlipperTransportTypes.h"
namespace facebook {
namespace flipper {
class FlipperDefaultSocketProvider : public FlipperSocketProvider {
public:
FlipperDefaultSocketProvider() {}
virtual std::unique_ptr<FlipperSocket> create(
FlipperConnectionEndpoint endpoint,
std::unique_ptr<FlipperSocketBasePayload> payload,
folly::EventBase* eventBase) override {
return std::make_unique<FlipperRSocket>(
std::move(endpoint), std::move(payload), eventBase);
}
virtual std::unique_ptr<FlipperSocket> create(
FlipperConnectionEndpoint endpoint,
std::unique_ptr<FlipperSocketBasePayload> payload,
folly::EventBase* eventBase,
ConnectionContextStore* connectionContextStore) override {
return std::make_unique<FlipperRSocket>(
std::move(endpoint),
std::move(payload),
eventBase,
connectionContextStore);
}
};
std::unique_ptr<FlipperSocketProvider> FlipperSocketProvider::provider_ =
std::make_unique<FlipperDefaultSocketProvider>();
std::unique_ptr<FlipperSocket> FlipperSocketProvider::socketCreate(
FlipperConnectionEndpoint endpoint,
std::unique_ptr<FlipperSocketBasePayload> payload,
folly::EventBase* eventBase) {
return provider_->create(std::move(endpoint), std::move(payload), eventBase);
}
std::unique_ptr<FlipperSocket> FlipperSocketProvider::socketCreate(
FlipperConnectionEndpoint endpoint,
std::unique_ptr<FlipperSocketBasePayload> payload,
folly::EventBase* eventBase,
ConnectionContextStore* connectionContextStore) {
return provider_->create(
std::move(endpoint),
std::move(payload),
eventBase,
connectionContextStore);
}
void FlipperSocketProvider::setDefaultProvider(
std::unique_ptr<FlipperSocketProvider> provider) {
provider_ = std::move(provider);
}
} // namespace flipper
} // namespace facebook