jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Split up the CK code so that internal refers to the latest and Open source refers to the sunset version and it won't be actively developed

Browse Source 
Summary:
This diff keeps the opensource integration of CK for Flipper at the same place. It moves the code which is referred internally to a different folder under Facebook directory.

The reason we are doing this is because, CK won't be publishing any more opensource releases to Cocoapods. Thus we would like to keep the code for opensource compatible to the latest one. Internally we would refer to the CK code from Facebook directory.

Reviewed By: fabiomassimo

Differential Revision: D26047510

fbshipit-source-id: 302890bcd36d3e4c4888577d821433f58fcab5c7
This commit is contained in:
Pritesh Nandgaonkar
2021-01-27 02:40:25 -08:00
committed by Facebook GitHub Bot
parent 6df117ba04
commit e104a1fa6b
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
FlipperKit.podspec
View File

@@ -129,8 +129,8 @@ Pod::Spec.new do |spec|
spec.subspec "FlipperKitLayoutComponentKitSupport" do |ss|
ss.header_dir = "FlipperKitLayoutComponentKitSupport"
ss.dependency 'FlipperKit/Core'
ss.dependency 'ComponentKit', '~> 0.30'
ss.dependency 'RenderCore', '~> 0.30'
ss.dependency 'ComponentKit', '0.30'
ss.dependency 'RenderCore', '0.30' # Pinning it to 0.30, as there won't be any new releases from CK team.
ss.dependency 'FlipperKit/FlipperKitLayoutPlugin'
ss.dependency 'FlipperKit/FlipperKitLayoutTextSearchable'
ss.dependency 'FlipperKit/FlipperKitHighlightOverlay'

6
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/README.md Normal file
View File

@@ -0,0 +1,6 @@
This folder is just kept for opensource integration for Flipper to work with CK
as CK is not planning to make any more releases on Cocoapods.
Do not make new changes here, the internal layout plugin refers to the code from
sonar/iOS/Plugins/Facebook/FlipperKitLayoutComponentKitSupport and the
opensource refers it from here.