From e104a1fa6bded176d1eb8d756fdea51a9c8e533d Mon Sep 17 00:00:00 2001 From: Pritesh Nandgaonkar Date: Wed, 27 Jan 2021 02:40:25 -0800 Subject: [PATCH] Split up the CK code so that internal refers to the latest and Open source refers to the sunset version and it won't be actively developed Summary: This diff keeps the opensource integration of CK for Flipper at the same place. It moves the code which is referred internally to a different folder under Facebook directory. The reason we are doing this is because, CK won't be publishing any more opensource releases to Cocoapods. Thus we would like to keep the code for opensource compatible to the latest one. Internally we would refer to the CK code from Facebook directory. Reviewed By: fabiomassimo Differential Revision: D26047510 fbshipit-source-id: 302890bcd36d3e4c4888577d821433f58fcab5c7 --- FlipperKit.podspec | 4 ++-- .../FlipperKitLayoutComponentKitSupport/README.md | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/README.md diff --git a/FlipperKit.podspec b/FlipperKit.podspec index da1132da6..37d9b0a02 100644 --- a/FlipperKit.podspec +++ b/FlipperKit.podspec @@ -129,8 +129,8 @@ Pod::Spec.new do |spec| spec.subspec "FlipperKitLayoutComponentKitSupport" do |ss| ss.header_dir = "FlipperKitLayoutComponentKitSupport" ss.dependency 'FlipperKit/Core' - ss.dependency 'ComponentKit', '~> 0.30' - ss.dependency 'RenderCore', '~> 0.30' + ss.dependency 'ComponentKit', '0.30' + ss.dependency 'RenderCore', '0.30' # Pinning it to 0.30, as there won't be any new releases from CK team. ss.dependency 'FlipperKit/FlipperKitLayoutPlugin' ss.dependency 'FlipperKit/FlipperKitLayoutTextSearchable' ss.dependency 'FlipperKit/FlipperKitHighlightOverlay' diff --git a/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/README.md b/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/README.md new file mode 100644 index 000000000..32faa1d8f --- /dev/null +++ b/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/README.md @@ -0,0 +1,6 @@ +This folder is just kept for opensource integration for Flipper to work with CK +as CK is not planning to make any more releases on Cocoapods. + +Do not make new changes here, the internal layout plugin refers to the code from +sonar/iOS/Plugins/Facebook/FlipperKitLayoutComponentKitSupport and the +opensource refers it from here.