jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

deprecated Searchable abstraction

Browse Source 
Summary: Since the functionality is now available as part of DataTable, the HoC doesn't seem to be needed as generic abstraction. it is used in handful places outside datatable / datalist, but those can be localized in the future or should datatable / datalist.

Reviewed By: fabiomassimo

Differential Revision: D28993836

fbshipit-source-id: 3e6da7c7b48348faa0c4f7281868196f5585a065
This commit is contained in:
Michel Weststrate
2021-06-10 04:44:18 -07:00
committed by Facebook GitHub Bot
parent f7732ed4fd
commit df7941e2bc
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/app/src/ui/components/searchable/Searchable.tsx
View File

@@ -144,6 +144,8 @@ function compileRegex(s: string): RegExp | null {
} }
/** /**
* @deprecated use DataTabe / DataList instead
*
* Higher-order-component that allows adding a searchbar on top of the wrapped * Higher-order-component that allows adding a searchbar on top of the wrapped
* component. See SearchableManagedTable for usage with a table. * component. See SearchableManagedTable for usage with a table.
*/ */

2
website/sidebars.js
View File

@@ -120,7 +120,6 @@ module.exports = {
'Desktop plugin APIs': [ 'Desktop plugin APIs': [
'extending/flipper-plugin', 'extending/flipper-plugin',
'extending/styling-components', 'extending/styling-components',
'extending/search-and-filter',
...fbInternalOnly([ ...fbInternalOnly([
{ {
'QPL linting': ['fb/building-a-linter', 'fb/active-linters'], 'QPL linting': ['fb/building-a-linter', 'fb/active-linters'],
@@ -131,6 +130,7 @@ module.exports = {
'extending/ui-components', 'extending/ui-components',
'extending/js-plugin-api', 'extending/js-plugin-api',
'extending/create-table-plugin', 'extending/create-table-plugin',
'extending/search-and-filter',
], ],
}, },
], ],