From df7941e2bc5017527d347407d1015f97920d417a Mon Sep 17 00:00:00 2001 From: Michel Weststrate Date: Thu, 10 Jun 2021 04:44:18 -0700 Subject: [PATCH] deprecated Searchable abstraction Summary: Since the functionality is now available as part of DataTable, the HoC doesn't seem to be needed as generic abstraction. it is used in handful places outside datatable / datalist, but those can be localized in the future or should datatable / datalist. Reviewed By: fabiomassimo Differential Revision: D28993836 fbshipit-source-id: 3e6da7c7b48348faa0c4f7281868196f5585a065 --- desktop/app/src/ui/components/searchable/Searchable.tsx | 2 ++ website/sidebars.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/desktop/app/src/ui/components/searchable/Searchable.tsx b/desktop/app/src/ui/components/searchable/Searchable.tsx index 402b130c9..52c5f2a1f 100644 --- a/desktop/app/src/ui/components/searchable/Searchable.tsx +++ b/desktop/app/src/ui/components/searchable/Searchable.tsx @@ -144,6 +144,8 @@ function compileRegex(s: string): RegExp | null { } /** + * @deprecated use DataTabe / DataList instead + * * Higher-order-component that allows adding a searchbar on top of the wrapped * component. See SearchableManagedTable for usage with a table. */ diff --git a/website/sidebars.js b/website/sidebars.js index 79a9ec752..04d82183f 100644 --- a/website/sidebars.js +++ b/website/sidebars.js @@ -120,7 +120,6 @@ module.exports = { 'Desktop plugin APIs': [ 'extending/flipper-plugin', 'extending/styling-components', - 'extending/search-and-filter', ...fbInternalOnly([ { 'QPL linting': ['fb/building-a-linter', 'fb/active-linters'], @@ -131,6 +130,7 @@ module.exports = { 'extending/ui-components', 'extending/js-plugin-api', 'extending/create-table-plugin', + 'extending/search-and-filter', ], }, ],