DetailSidebar
Summary: - rename `SonarSidebar` to `DetailSidebar` - rename portal id from `#sonarSidebar` to `#detailSidebar` Reviewed By: passy Differential Revision: D9851703 fbshipit-source-id: 2d904d17b0c6255a2ec3a79f0ada9bf621693c2e
This commit is contained in:
committed by
Facebook Github Bot
parent
e360654b28
commit
df0a0da744
@@ -151,7 +151,7 @@ class PluginContainer extends Component<Props, State> {
|
||||
{React.createElement(activePlugin, props)}
|
||||
</ErrorBoundary>
|
||||
</Container>
|
||||
<SidebarContainer id="sonarSidebar" />
|
||||
<SidebarContainer id="detailsSidebar" />
|
||||
</React.Fragment>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -18,7 +18,7 @@ type Props = {
|
||||
toggleRightSidebarAvailable: (visible: boolean) => void,
|
||||
};
|
||||
|
||||
class SonarSidebar extends React.Component<Props> {
|
||||
class DetailSidebar extends React.Component<Props> {
|
||||
componentDidMount() {
|
||||
this.updateSidebarAvailablility();
|
||||
}
|
||||
@@ -35,7 +35,7 @@ class SonarSidebar extends React.Component<Props> {
|
||||
}
|
||||
|
||||
render() {
|
||||
const domNode = document.getElementById('sonarSidebar');
|
||||
const domNode = document.getElementById('detailsSidebar');
|
||||
return (
|
||||
this.props.children &&
|
||||
this.props.rightSidebarVisible &&
|
||||
@@ -58,4 +58,4 @@ export default connect(
|
||||
{
|
||||
toggleRightSidebarAvailable,
|
||||
},
|
||||
)(SonarSidebar);
|
||||
)(DetailSidebar);
|
||||
@@ -11,7 +11,7 @@ import type {
|
||||
TableColumnSizes,
|
||||
TableColumns,
|
||||
} from 'flipper';
|
||||
import {FlexColumn, Button, SonarSidebar} from 'flipper';
|
||||
import {FlexColumn, Button, DetailSidebar} from 'flipper';
|
||||
import textContent from './utils/textContent.js';
|
||||
import createPaste from './utils/createPaste.js';
|
||||
import {FlipperPlugin, SearchableTable} from 'flipper';
|
||||
@@ -199,7 +199,7 @@ export function createTablePlugin<T: RowData>(props: Props<T>) {
|
||||
stickyBottom={true}
|
||||
actions={<Button onClick={this.clear}>Clear Table</Button>}
|
||||
/>
|
||||
<SonarSidebar>{this.renderSidebar()}</SonarSidebar>
|
||||
<DetailSidebar>{this.renderSidebar()}</DetailSidebar>
|
||||
</FlexColumn>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -24,7 +24,7 @@ import {
|
||||
ContextMenu,
|
||||
FlexColumn,
|
||||
Glyph,
|
||||
SonarSidebar,
|
||||
DetailSidebar,
|
||||
FlipperDevicePlugin,
|
||||
SearchableTable,
|
||||
styled,
|
||||
@@ -565,7 +565,7 @@ export default class LogTable extends FlipperDevicePlugin<
|
||||
actions={<Button onClick={this.clearLogs}>Clear Logs</Button>}
|
||||
stickyBottom={true}
|
||||
/>
|
||||
<SonarSidebar>{this.renderSidebar()}</SonarSidebar>
|
||||
<DetailSidebar>{this.renderSidebar()}</DetailSidebar>
|
||||
</LogTable.ContextMenu>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -16,7 +16,7 @@ export {
|
||||
FlipperDevicePlugin,
|
||||
} from './plugin.js';
|
||||
export {createTablePlugin} from './createTablePlugin.js';
|
||||
export {default as SonarSidebar} from './chrome/SonarSidebar.js';
|
||||
export {default as DetailSidebar} from './chrome/DetailSidebar.js';
|
||||
|
||||
export {default as AndroidDevice} from './devices/AndroidDevice.js';
|
||||
export {default as Device} from './devices/BaseDevice.js';
|
||||
|
||||
@@ -21,7 +21,7 @@ import {
|
||||
SearchBox,
|
||||
SearchInput,
|
||||
SearchIcon,
|
||||
SonarSidebar,
|
||||
DetailSidebar,
|
||||
VerticalRule,
|
||||
Popover,
|
||||
ToggleButton,
|
||||
@@ -1229,7 +1229,7 @@ export default class Layout extends FlipperPlugin<InspectorState> {
|
||||
/>
|
||||
) : null}
|
||||
</FlexRow>
|
||||
<SonarSidebar>{this.renderSidebar()}</SonarSidebar>
|
||||
<DetailSidebar>{this.renderSidebar()}</DetailSidebar>
|
||||
</FlexColumn>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -15,7 +15,7 @@ import {
|
||||
Glyph,
|
||||
colors,
|
||||
PureComponent,
|
||||
SonarSidebar,
|
||||
DetailSidebar,
|
||||
styled,
|
||||
} from 'flipper';
|
||||
import {FlipperPlugin, SearchableTable} from 'flipper';
|
||||
@@ -177,7 +177,7 @@ export default class extends FlipperPlugin<State, *, PersistedState> {
|
||||
clear={this.clearLogs}
|
||||
onRowHighlighted={this.onRowHighlighted}
|
||||
/>
|
||||
<SonarSidebar>{this.renderSidebar()}</SonarSidebar>
|
||||
<DetailSidebar>{this.renderSidebar()}</DetailSidebar>
|
||||
</FlexColumn>
|
||||
);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user