From df0a0da744236a43a177b0c56efa3a689876c3b1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20B=C3=BCchele?= <danielbuechele@fb.com>
Date: Tue, 18 Sep 2018 06:38:23 -0700
Subject: [PATCH] DetailSidebar

Summary:
- rename `SonarSidebar` to `DetailSidebar`
- rename portal id from `#sonarSidebar` to `#detailSidebar`

Reviewed By: passy

Differential Revision: D9851703

fbshipit-source-id: 2d904d17b0c6255a2ec3a79f0ada9bf621693c2e
---
 src/PluginContainer.js                           | 2 +-
 src/chrome/{SonarSidebar.js => DetailSidebar.js} | 6 +++---
 src/createTablePlugin.js                         | 4 ++--
 src/device-plugins/logs/index.js                 | 4 ++--
 src/index.js                                     | 2 +-
 src/plugins/layout/index.js                      | 4 ++--
 src/plugins/network/index.js                     | 4 ++--
 7 files changed, 13 insertions(+), 13 deletions(-)
 rename src/chrome/{SonarSidebar.js => DetailSidebar.js} (91%)

diff --git a/src/PluginContainer.js b/src/PluginContainer.js
index 6ad08714f..a51a41a54 100644
--- a/src/PluginContainer.js
+++ b/src/PluginContainer.js
@@ -151,7 +151,7 @@ class PluginContainer extends Component<Props, State> {
             {React.createElement(activePlugin, props)}
           </ErrorBoundary>
         </Container>
-        <SidebarContainer id="sonarSidebar" />
+        <SidebarContainer id="detailsSidebar" />
       </React.Fragment>
     );
   }
diff --git a/src/chrome/SonarSidebar.js b/src/chrome/DetailSidebar.js
similarity index 91%
rename from src/chrome/SonarSidebar.js
rename to src/chrome/DetailSidebar.js
index 0e2ba35b1..4fa23970d 100644
--- a/src/chrome/SonarSidebar.js
+++ b/src/chrome/DetailSidebar.js
@@ -18,7 +18,7 @@ type Props = {
   toggleRightSidebarAvailable: (visible: boolean) => void,
 };
 
-class SonarSidebar extends React.Component<Props> {
+class DetailSidebar extends React.Component<Props> {
   componentDidMount() {
     this.updateSidebarAvailablility();
   }
@@ -35,7 +35,7 @@ class SonarSidebar extends React.Component<Props> {
   }
 
   render() {
-    const domNode = document.getElementById('sonarSidebar');
+    const domNode = document.getElementById('detailsSidebar');
     return (
       this.props.children &&
       this.props.rightSidebarVisible &&
@@ -58,4 +58,4 @@ export default connect(
   {
     toggleRightSidebarAvailable,
   },
-)(SonarSidebar);
+)(DetailSidebar);
diff --git a/src/createTablePlugin.js b/src/createTablePlugin.js
index 9948e652c..85142d5b5 100644
--- a/src/createTablePlugin.js
+++ b/src/createTablePlugin.js
@@ -11,7 +11,7 @@ import type {
   TableColumnSizes,
   TableColumns,
 } from 'flipper';
-import {FlexColumn, Button, SonarSidebar} from 'flipper';
+import {FlexColumn, Button, DetailSidebar} from 'flipper';
 import textContent from './utils/textContent.js';
 import createPaste from './utils/createPaste.js';
 import {FlipperPlugin, SearchableTable} from 'flipper';
@@ -199,7 +199,7 @@ export function createTablePlugin<T: RowData>(props: Props<T>) {
             stickyBottom={true}
             actions={<Button onClick={this.clear}>Clear Table</Button>}
           />
-          <SonarSidebar>{this.renderSidebar()}</SonarSidebar>
+          <DetailSidebar>{this.renderSidebar()}</DetailSidebar>
         </FlexColumn>
       );
     }
diff --git a/src/device-plugins/logs/index.js b/src/device-plugins/logs/index.js
index d58f97927..9a65ecf82 100644
--- a/src/device-plugins/logs/index.js
+++ b/src/device-plugins/logs/index.js
@@ -24,7 +24,7 @@ import {
   ContextMenu,
   FlexColumn,
   Glyph,
-  SonarSidebar,
+  DetailSidebar,
   FlipperDevicePlugin,
   SearchableTable,
   styled,
@@ -565,7 +565,7 @@ export default class LogTable extends FlipperDevicePlugin<
           actions={<Button onClick={this.clearLogs}>Clear Logs</Button>}
           stickyBottom={true}
         />
-        <SonarSidebar>{this.renderSidebar()}</SonarSidebar>
+        <DetailSidebar>{this.renderSidebar()}</DetailSidebar>
       </LogTable.ContextMenu>
     );
   }
diff --git a/src/index.js b/src/index.js
index 22e8dce05..bc59b1171 100644
--- a/src/index.js
+++ b/src/index.js
@@ -16,7 +16,7 @@ export {
   FlipperDevicePlugin,
 } from './plugin.js';
 export {createTablePlugin} from './createTablePlugin.js';
-export {default as SonarSidebar} from './chrome/SonarSidebar.js';
+export {default as DetailSidebar} from './chrome/DetailSidebar.js';
 
 export {default as AndroidDevice} from './devices/AndroidDevice.js';
 export {default as Device} from './devices/BaseDevice.js';
diff --git a/src/plugins/layout/index.js b/src/plugins/layout/index.js
index e895b72e0..d3160ecc6 100644
--- a/src/plugins/layout/index.js
+++ b/src/plugins/layout/index.js
@@ -21,7 +21,7 @@ import {
   SearchBox,
   SearchInput,
   SearchIcon,
-  SonarSidebar,
+  DetailSidebar,
   VerticalRule,
   Popover,
   ToggleButton,
@@ -1229,7 +1229,7 @@ export default class Layout extends FlipperPlugin<InspectorState> {
             />
           ) : null}
         </FlexRow>
-        <SonarSidebar>{this.renderSidebar()}</SonarSidebar>
+        <DetailSidebar>{this.renderSidebar()}</DetailSidebar>
       </FlexColumn>
     );
   }
diff --git a/src/plugins/network/index.js b/src/plugins/network/index.js
index 212e97f39..0ab7735dd 100644
--- a/src/plugins/network/index.js
+++ b/src/plugins/network/index.js
@@ -15,7 +15,7 @@ import {
   Glyph,
   colors,
   PureComponent,
-  SonarSidebar,
+  DetailSidebar,
   styled,
 } from 'flipper';
 import {FlipperPlugin, SearchableTable} from 'flipper';
@@ -177,7 +177,7 @@ export default class extends FlipperPlugin<State, *, PersistedState> {
           clear={this.clearLogs}
           onRowHighlighted={this.onRowHighlighted}
         />
-        <SonarSidebar>{this.renderSidebar()}</SonarSidebar>
+        <DetailSidebar>{this.renderSidebar()}</DetailSidebar>
       </FlexColumn>
     );
   }