DetailSidebar

Summary:
- rename `SonarSidebar` to `DetailSidebar`
- rename portal id from `#sonarSidebar` to `#detailSidebar`

Reviewed By: passy

Differential Revision: D9851703

fbshipit-source-id: 2d904d17b0c6255a2ec3a79f0ada9bf621693c2e
This commit is contained in:
Daniel Büchele
2018-09-18 06:38:23 -07:00
committed by Facebook Github Bot
parent e360654b28
commit df0a0da744
7 changed files with 13 additions and 13 deletions

View File

@@ -151,7 +151,7 @@ class PluginContainer extends Component<Props, State> {
{React.createElement(activePlugin, props)} {React.createElement(activePlugin, props)}
</ErrorBoundary> </ErrorBoundary>
</Container> </Container>
<SidebarContainer id="sonarSidebar" /> <SidebarContainer id="detailsSidebar" />
</React.Fragment> </React.Fragment>
); );
} }

View File

@@ -18,7 +18,7 @@ type Props = {
toggleRightSidebarAvailable: (visible: boolean) => void, toggleRightSidebarAvailable: (visible: boolean) => void,
}; };
class SonarSidebar extends React.Component<Props> { class DetailSidebar extends React.Component<Props> {
componentDidMount() { componentDidMount() {
this.updateSidebarAvailablility(); this.updateSidebarAvailablility();
} }
@@ -35,7 +35,7 @@ class SonarSidebar extends React.Component<Props> {
} }
render() { render() {
const domNode = document.getElementById('sonarSidebar'); const domNode = document.getElementById('detailsSidebar');
return ( return (
this.props.children && this.props.children &&
this.props.rightSidebarVisible && this.props.rightSidebarVisible &&
@@ -58,4 +58,4 @@ export default connect(
{ {
toggleRightSidebarAvailable, toggleRightSidebarAvailable,
}, },
)(SonarSidebar); )(DetailSidebar);

View File

@@ -11,7 +11,7 @@ import type {
TableColumnSizes, TableColumnSizes,
TableColumns, TableColumns,
} from 'flipper'; } from 'flipper';
import {FlexColumn, Button, SonarSidebar} from 'flipper'; import {FlexColumn, Button, DetailSidebar} from 'flipper';
import textContent from './utils/textContent.js'; import textContent from './utils/textContent.js';
import createPaste from './utils/createPaste.js'; import createPaste from './utils/createPaste.js';
import {FlipperPlugin, SearchableTable} from 'flipper'; import {FlipperPlugin, SearchableTable} from 'flipper';
@@ -199,7 +199,7 @@ export function createTablePlugin<T: RowData>(props: Props<T>) {
stickyBottom={true} stickyBottom={true}
actions={<Button onClick={this.clear}>Clear Table</Button>} actions={<Button onClick={this.clear}>Clear Table</Button>}
/> />
<SonarSidebar>{this.renderSidebar()}</SonarSidebar> <DetailSidebar>{this.renderSidebar()}</DetailSidebar>
</FlexColumn> </FlexColumn>
); );
} }

View File

@@ -24,7 +24,7 @@ import {
ContextMenu, ContextMenu,
FlexColumn, FlexColumn,
Glyph, Glyph,
SonarSidebar, DetailSidebar,
FlipperDevicePlugin, FlipperDevicePlugin,
SearchableTable, SearchableTable,
styled, styled,
@@ -565,7 +565,7 @@ export default class LogTable extends FlipperDevicePlugin<
actions={<Button onClick={this.clearLogs}>Clear Logs</Button>} actions={<Button onClick={this.clearLogs}>Clear Logs</Button>}
stickyBottom={true} stickyBottom={true}
/> />
<SonarSidebar>{this.renderSidebar()}</SonarSidebar> <DetailSidebar>{this.renderSidebar()}</DetailSidebar>
</LogTable.ContextMenu> </LogTable.ContextMenu>
); );
} }

View File

@@ -16,7 +16,7 @@ export {
FlipperDevicePlugin, FlipperDevicePlugin,
} from './plugin.js'; } from './plugin.js';
export {createTablePlugin} from './createTablePlugin.js'; export {createTablePlugin} from './createTablePlugin.js';
export {default as SonarSidebar} from './chrome/SonarSidebar.js'; export {default as DetailSidebar} from './chrome/DetailSidebar.js';
export {default as AndroidDevice} from './devices/AndroidDevice.js'; export {default as AndroidDevice} from './devices/AndroidDevice.js';
export {default as Device} from './devices/BaseDevice.js'; export {default as Device} from './devices/BaseDevice.js';

View File

@@ -21,7 +21,7 @@ import {
SearchBox, SearchBox,
SearchInput, SearchInput,
SearchIcon, SearchIcon,
SonarSidebar, DetailSidebar,
VerticalRule, VerticalRule,
Popover, Popover,
ToggleButton, ToggleButton,
@@ -1229,7 +1229,7 @@ export default class Layout extends FlipperPlugin<InspectorState> {
/> />
) : null} ) : null}
</FlexRow> </FlexRow>
<SonarSidebar>{this.renderSidebar()}</SonarSidebar> <DetailSidebar>{this.renderSidebar()}</DetailSidebar>
</FlexColumn> </FlexColumn>
); );
} }

View File

@@ -15,7 +15,7 @@ import {
Glyph, Glyph,
colors, colors,
PureComponent, PureComponent,
SonarSidebar, DetailSidebar,
styled, styled,
} from 'flipper'; } from 'flipper';
import {FlipperPlugin, SearchableTable} from 'flipper'; import {FlipperPlugin, SearchableTable} from 'flipper';
@@ -177,7 +177,7 @@ export default class extends FlipperPlugin<State, *, PersistedState> {
clear={this.clearLogs} clear={this.clearLogs}
onRowHighlighted={this.onRowHighlighted} onRowHighlighted={this.onRowHighlighted}
/> />
<SonarSidebar>{this.renderSidebar()}</SonarSidebar> <DetailSidebar>{this.renderSidebar()}</DetailSidebar>
</FlexColumn> </FlexColumn>
); );
} }