jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix starting screen captures

Browse Source 
Summary:
Starting a screencapture longer than 30 seconds would timeout as the start command waits for the process to finish. Removed that wait is it is the stop command that should only wait for the finish.

(n.b. please ship after accepting, as I'm on PTO)

Reviewed By: LukeDefeo

Differential Revision: D38918570

fbshipit-source-id: fd93e1239985c81a2143ceb79312518e7ebb27f5
This commit is contained in:
Lorenzo Blasa
2022-08-25 02:18:40 -07:00
committed by Facebook GitHub Bot
parent 947d00c6c3
commit dab510c546
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
desktop/flipper-server-core/src/devices/android/AndroidDevice.tsx
View File

@@ -250,8 +250,7 @@ export default class AndroidDevice extends ServerDevice {
}), }),
) )
.then((_) => destination); .then((_) => destination);
// Intentionally not return a promise, this just kicks off the recording!
return this.recordingProcess.then((_) => {});
} }
async stopScreenCapture(): Promise<string> { async stopScreenCapture(): Promise<string> {